jh7370 wrote:
Just chiming in that I happened to spot the pre-merge check failure looks
possibly related.
https://github.com/llvm/llvm-project/pull/107494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/l
nikic wrote:
Should be fixed by
https://github.com/llvm/llvm-project/commit/940f89255e4a3982d94dad57837e8e658092af78.
https://github.com/llvm/llvm-project/pull/107257
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
@@ -251,6 +251,24 @@ SPIRV::MemorySemantics::MemorySemantics
getMemSemantics(AtomicOrdering Ord) {
llvm_unreachable(nullptr);
}
+SPIRV::Scope::Scope getMemScope(const LLVMContext &Ctx, SyncScope::ID ID) {
+ SmallVector SSNs;
+ Ctx.getSyncScopeNames(SSNs);
+
+ StringRef M
@@ -0,0 +1,52 @@
+// RUN: %clang_cc1 -flax-vector-conversions=none -ffreestanding %s
-triple=i386-unknown-unknown -target-feature +avx10.2-512 -emit-llvm -Wall
-Werror -verify
MalaySanghi wrote:
Hi,
Thanks for bringing this to my notice. I'll send a patch next
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/108513
Fixes #108333.
>From c85d8cdd44ad577bbc2a29e45058b0c972c6fa9e Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Fri, 13 Sep 2024 01:21:29 -0700
Subject: [PATCH] [clang-format] Reimplement InsertNewlineAtEOF
Fixes #
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Fixes #108333.
---
Full diff: https://github.com/llvm/llvm-project/pull/108513.diff
3 Files Affected:
- (modified) clang/lib/Format/FormatTokenLexer.cpp (+7)
- (modified) clang/lib/Format/TokenAnnotator
https://github.com/MalaySanghi edited
https://github.com/llvm/llvm-project/pull/102592
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kwk wrote:
I'm trying this patch locally now.
https://github.com/llvm/llvm-project/pull/108488
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Timm Baeder
Date: 2024-09-13T10:30:02+02:00
New Revision: 5d1d2f08c4a92580e7f6b3b6b77b2b6f6184e126
URL:
https://github.com/llvm/llvm-project/commit/5d1d2f08c4a92580e7f6b3b6b77b2b6f6184e126
DIFF:
https://github.com/llvm/llvm-project/commit/5d1d2f08c4a92580e7f6b3b6b77b2b6f6184e126.diff
L
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/106733
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1243,12 +1247,19 @@ bool
ASTUnit::Parse(std::shared_ptr PCHContainerOps,
}
std::unique_ptr Act(
- new TopLevelDeclTrackerAction(*this));
+ new TopLevelDeclTrackerAction(*this, true));
cor3ntin wrote:
Moreover, can you explain the "reuse pr
https://github.com/labrinea edited
https://github.com/llvm/llvm-project/pull/108383
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
DanielKristofKiss wrote:
> I think this is OK but do you know if the dsp side works with cortex-m?
> Target attributes are less likely to be used there, but it's worth testing if
> the command line args are still all happy.
This seems works fine:
```c
#include
int dsp() {
return __smlabb(
@@ -502,3 +502,28 @@
// RUN: %clang --target=riscv64 -### -c %s 2>&1 -mtune=syntacore-scr5-rv64 |
FileCheck -check-prefix=MTUNE-SYNTACORE-SCR5-RV64 %s
// MTUNE-SYNTACORE-SCR5-RV64: "-tune-cpu" "syntacore-scr5-rv64"
+
+// RUN: %clang --target=riscv64 -### -c %s 2>&1 -mcpu=synt
https://github.com/asi-sc updated
https://github.com/llvm/llvm-project/pull/108406
>From 0c2925d18e8e4312a16d081c1c97d3298b85e8d4 Mon Sep 17 00:00:00 2001
From: Anton Sidorenko
Date: Mon, 2 Sep 2024 13:25:39 +0300
Subject: [PATCH 1/2] [RISCV] Add Syntacore SCR7 processor definition
Syntacore S
@@ -33,7 +33,6 @@ enum CPUFeatures {
FEAT_FP,
FEAT_SIMD,
FEAT_CRC,
- FEAT_SHA1,
labrinea wrote:
It was raised on another pr, so perhaps it is.
https://github.com/llvm/llvm-project/pull/108383
___
cfe-commits
@@ -439,6 +439,9 @@ def warn_deprecated_literal_operator_id: Warning<
"is deprecated">, InGroup, DefaultIgnore;
def warn_reserved_module_name : Warning<
"%0 is a reserved name for a module">, InGroup;
+def warn_import_implementation_partition_unit_in_interface_unit : Warnin
RKSimon wrote:
@tru This patch at the very least needs to make it for 19.x but I was hoping
we'd get some of the tuning improvements in as well - should we wait for those
PRs or just get this committed and cherry picked straight away?
https://github.com/llvm/llvm-project/pull/107964
__
https://github.com/ChuanqiXu9 updated
https://github.com/llvm/llvm-project/pull/108493
>From b109ea29ee6d1c290766e141ce75317fbf450767 Mon Sep 17 00:00:00 2001
From: Chuanqi Xu
Date: Fri, 13 Sep 2024 13:18:43 +0800
Subject: [PATCH 1/2] [C++20] [Modules] Warn for importing implementation
partiti
@@ -439,6 +439,9 @@ def warn_deprecated_literal_operator_id: Warning<
"is deprecated">, InGroup, DefaultIgnore;
def warn_reserved_module_name : Warning<
"%0 is a reserved name for a module">, InGroup;
+def warn_import_implementation_partition_unit_in_interface_unit : Warnin
Author: Mariya Podchishchaeva
Date: 2024-09-13T11:11:34+02:00
New Revision: a0f88901a4e6a6618c3ec02108103d0415e28834
URL:
https://github.com/llvm/llvm-project/commit/a0f88901a4e6a6618c3ec02108103d0415e28834
DIFF:
https://github.com/llvm/llvm-project/commit/a0f88901a4e6a6618c3ec02108103d0415e288
https://github.com/Fznamznon closed
https://github.com/llvm/llvm-project/pull/103917
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dtcxzyw approved this pull request.
LG
https://github.com/llvm/llvm-project/pull/108406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Nikita Popov
Date: 2024-09-13T11:15:22+02:00
New Revision: 1c298c927498983dee29037ed1d3e71b72ca0082
URL:
https://github.com/llvm/llvm-project/commit/1c298c927498983dee29037ed1d3e71b72ca0082
DIFF:
https://github.com/llvm/llvm-project/commit/1c298c927498983dee29037ed1d3e71b72ca0082.diff
nikic wrote:
ping
https://github.com/llvm/llvm-project/pull/107601
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ckandeler updated
https://github.com/llvm/llvm-project/pull/67802
>From f441c0bd52add3d5b63bc0f19a3d38cb12477359 Mon Sep 17 00:00:00 2001
From: Christian Kandeler
Date: Fri, 29 Sep 2023 15:01:58 +0200
Subject: [PATCH] [clangd] Collect comments from function definitions into t
ckandeler wrote:
> Meanwhile, I thought of a fix for #108145 and submitted it as #108475.
> If that's accepted, you should be able to drop the `ASTContext.cpp` changes
> from this patch.
Nice, will do.
https://github.com/llvm/llvm-project/pull/67802
__
tbaederr wrote:
Apparently I've already pushed this.
https://github.com/llvm/llvm-project/pull/107565
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Timm Baeder
Date: 2024-09-13T11:32:12+02:00
New Revision: fbf0a8015389bccab80bba00be49955079913152
URL:
https://github.com/llvm/llvm-project/commit/fbf0a8015389bccab80bba00be49955079913152
DIFF:
https://github.com/llvm/llvm-project/commit/fbf0a8015389bccab80bba00be49955079913152.diff
L
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/108499
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Nikolas Klauser
Date: 2024-09-13T11:34:20+02:00
New Revision: e7f782e7481cea23ef452a75607d3d61f5bd0d22
URL:
https://github.com/llvm/llvm-project/commit/e7f782e7481cea23ef452a75607d3d61f5bd0d22
DIFF:
https://github.com/llvm/llvm-project/commit/e7f782e7481cea23ef452a75607d3d61f5bd0d22.dif
https://github.com/philnik777 edited
https://github.com/llvm/llvm-project/pull/108453
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tbaederr closed
https://github.com/llvm/llvm-project/pull/107565
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -446,7 +446,12 @@ static bool tryDiagnoseOverloadedCast(Sema &S, CastType CT,
: InitializationKind::CreateCast(/*type range?*/ range);
InitializationSequence sequence(S, entity, initKind, src);
- assert(sequence.Failed() && "initialization succeeded on second try?");
https://github.com/alejandro-alvarez-sonarsource edited
https://github.com/llvm/llvm-project/pull/108021
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -73,8 +73,6 @@ enum CPUFeatures {
FEAT_SSBS,
FEAT_SSBS2,
FEAT_BTI,
- FEAT_LS64,
- FEAT_LS64_V,
labrinea wrote:
Thanks for flagging this up. I am puzzled though since I was under the
impression that FMV is still not production ready. When did the en
RKSimon wrote:
@ganeshgit Ignore what I said earlier about waiting for the tuning patches :)
Please can we get this committed to trunk, we'll let it brew for a few days and
then cherry pick for 19.x - if you can create PRs for the tuning changes as
soon as possible we can review them for 19.x
alex1701c wrote:
Can we expect this to be backported and released with clang-format-18?
https://github.com/llvm/llvm-project/pull/99791
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vogelsgesang wrote:
My 2cts:
I think it would be best for clang-users, if HALO / coroutine optimizations
work out-of-the-box in as many cases as possible.
Unfortunately, it seems we have an "either-or" decision here. Either, the
"thin-lto + HALO" work out-of-the-box or the llc-code-generation
Author: Piyou Chen
Date: 2024-09-13T18:04:53+08:00
New Revision: 9cd93774098c861c260090a690f428b7ae031c65
URL:
https://github.com/llvm/llvm-project/commit/9cd93774098c861c260090a690f428b7ae031c65
DIFF:
https://github.com/llvm/llvm-project/commit/9cd93774098c861c260090a690f428b7ae031c65.diff
LO
https://github.com/BeMg closed https://github.com/llvm/llvm-project/pull/85786
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vogelsgesang wrote:
> Unfortunately, it seems we have an "either-or" decision here
Although... Is this even an either-or decision?
Could we add coro-split to the llc unconditionally, also for non-thin-lto
pipelines? Afaict, coro-split is a no-op pass if coroutines were already split
previousl
nikic wrote:
Zen 5 support in GCC was upstreamed more than half a year ago -- why is the
LLVM support being upstreamed only now, after missing the 19.x window? What
steps are being taken to ensure this does not happen again?
The change to X86TargetParser.h looks ABI breaking to me.
https://gi
https://github.com/BeMg updated https://github.com/llvm/llvm-project/pull/99040
>From 54b5d6833a52271dfd1ca3912d5d9e886b1970c2 Mon Sep 17 00:00:00 2001
From: Piyou Chen
Date: Tue, 19 Mar 2024 02:02:35 -0700
Subject: [PATCH] [RISCV][FMV] Support target_version
---
clang/lib/AST/ASTContext.cpp
BeMg wrote:
Rebase to main
https://github.com/llvm/llvm-project/pull/99040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/BeMg updated https://github.com/llvm/llvm-project/pull/99040
>From 54b5d6833a52271dfd1ca3912d5d9e886b1970c2 Mon Sep 17 00:00:00 2001
From: Piyou Chen
Date: Tue, 19 Mar 2024 02:02:35 -0700
Subject: [PATCH 1/2] [RISCV][FMV] Support target_version
---
clang/lib/AST/ASTContext.c
https://github.com/BeMg updated https://github.com/llvm/llvm-project/pull/99040
>From 54b5d6833a52271dfd1ca3912d5d9e886b1970c2 Mon Sep 17 00:00:00 2001
From: Piyou Chen
Date: Tue, 19 Mar 2024 02:02:35 -0700
Subject: [PATCH 1/3] [RISCV][FMV] Support target_version
---
clang/lib/AST/ASTContext.c
https://github.com/rjmansfield created
https://github.com/llvm/llvm-project/pull/108527
None
>From 8bea5472c6be19664b4c044f510b757b88ec441f Mon Sep 17 00:00:00 2001
From: Ryan Mansfield
Date: Fri, 13 Sep 2024 06:31:50 -0400
Subject: [PATCH] [clang] Fix various typos and whitespace in HelpText.
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Ryan Mansfield (rjmansfield)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/108527.diff
1 Files Affected:
- (modified) clang/include/clang/Driver/Options.td (+10-10)
``diff
diff --git a/clang/include/clang/
@@ -58,7 +58,35 @@ class SPIRVTargetCodeGenInfo : public
CommonSPIRTargetCodeGenInfo {
SPIRVTargetCodeGenInfo(CodeGen::CodeGenTypes &CGT)
: CommonSPIRTargetCodeGenInfo(std::make_unique(CGT)) {}
void setCUDAKernelCallingConvention(const FunctionType *&FT) const overri
https://github.com/vgvassilev created
https://github.com/llvm/llvm-project/pull/108529
Posix call to ::getenv is not guarenteed to be thread safe while C++11 made
std::getenv thread safe.
This resolves bugs when using llvm in multithreaded environment similar to
cms-sw/cmssw#44659
>From 4ae2
llvmbot wrote:
@llvm/pr-subscribers-llvm-support
@llvm/pr-subscribers-clang-driver
Author: Vassil Vassilev (vgvassilev)
Changes
Posix call to ::getenv is not guarenteed to be thread safe while C++11 made
std::getenv thread safe.
This resolves bugs when using llvm in multithreaded environ
VyacheslavLevytskyy wrote:
With the full respect to @AlexVlx work I created
https://github.com/llvm/llvm-project/pull/108528 just as an utility to discuss
and agree about memory scoped issues.
https://github.com/llvm/llvm-project/pull/106429
___
cfe-
ganeshgit wrote:
> @ganeshgit Ignore what I said earlier about waiting for the tuning patches :)
> Please can we get this committed to trunk, we'll let it brew for a few days
> and then cherry pick for 19.x - if you can create PRs for the tuning changes
> as soon as possible we can review them
ganeshgit wrote:
> Zen 5 support in GCC was upstreamed more than half a year ago -- why is the
> LLVM support being upstreamed only now, after missing the 19.x window? What
> steps are being taken to ensure this does not happen again?
>
> The change to X86TargetParser.h looks ABI breaking to m
https://github.com/antoniofrighetto created
https://github.com/llvm/llvm-project/pull/108532
Utility functions have been moved out to Utils. Minor opportunity to drop the
header where not needed.
>From 42fef89fcc75d7f1f869c70d5357fcf3a0d410e1 Mon Sep 17 00:00:00 2001
From: Antonio Frighetto
D
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Antonio Frighetto (antoniofrighetto)
Changes
Utility functions have been moved out to Utils. Minor opportunity to drop the
header where not needed.
---
Full diff: https://github.com/llvm/llvm-project/pull/108532.diff
26 Files Affected:
llvmbot wrote:
@llvm/pr-subscribers-llvm-transforms
@llvm/pr-subscribers-clang-codegen
Author: Antonio Frighetto (antoniofrighetto)
Changes
Utility functions have been moved out to Utils. Minor opportunity to drop the
header where not needed.
---
Full diff: https://github.com/llvm/llvm-p
llvmbot wrote:
@llvm/pr-subscribers-compiler-rt-sanitizer
Author: Antonio Frighetto (antoniofrighetto)
Changes
Utility functions have been moved out to Utils. Minor opportunity to drop the
header where not needed.
---
Full diff: https://github.com/llvm/llvm-project/pull/108532.diff
26
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `lld-x86_64-win` running on
`as-worker-93` while building `clang,llvm` at step 7
"test-build-unified-tree-check-all".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/146/builds/1139
Here is the releva
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c0e308ba3d8ac252b8118d94a17b1351ca92b813
42fef89fcc75d7f1f869c70d5357fcf3a0d410e1 --e
https://github.com/antoniofrighetto updated
https://github.com/llvm/llvm-project/pull/108532
>From 4518980e2698b76825d9650373df7414f61062d9 Mon Sep 17 00:00:00 2001
From: Antonio Frighetto
Date: Fri, 13 Sep 2024 11:43:30 +0200
Subject: [PATCH] [Instrumentation] Move out to Utils (NFC)
Utility
metaflow wrote:
there is also `avx10_2satcvtds-builtins-errors.c` that calls emit
https://github.com/llvm/llvm-project/pull/108525
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
metaflow wrote:
thank you for the fix @MalaySanghi !
https://github.com/llvm/llvm-project/pull/108525
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mahesh-attarde created
https://github.com/llvm/llvm-project/pull/108537
Ref.: https://cdrdv2.intel.com/v1/dl/getContent/828965
Chapter 14 INTEL® AVX10 ZERO-EXTENDING PARTIAL VECTOR COPY INSTRUCTIONS
>From d8e76ea27679df40d0c796a5e8e5bc31433b6bff Mon Sep 17 00:00:00 2001
From
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Mahesh-Attarde (mahesh-attarde)
Changes
Ref.: https://cdrdv2.intel.com/v1/dl/getContent/828965
Chapter 14 INTEL® AVX10 ZERO-EXTENDING PARTIAL VECTOR COPY INSTRUCTIONS
---
Full diff: https://github.com/llvm/llvm-project/pull/108537.diff
llvmbot wrote:
@llvm/pr-subscribers-mc
Author: Mahesh-Attarde (mahesh-attarde)
Changes
Ref.: https://cdrdv2.intel.com/v1/dl/getContent/828965
Chapter 14 INTEL® AVX10 ZERO-EXTENDING PARTIAL VECTOR COPY INSTRUCTIONS
---
Full diff: https://github.com/llvm/llvm-project/pull/108537.diff
15
mahesh-attarde wrote:
@phoebewang @FreddyLeaf @KanRobert Can you review please?
https://github.com/llvm/llvm-project/pull/108537
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cor3ntin approved this pull request.
LGTM, thanks!
https://github.com/llvm/llvm-project/pull/108527
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mstorsjo created
https://github.com/llvm/llvm-project/pull/108539
This allows the clang driver to know which tool is meant to be executed, which
allows the clang driver to load the right clang config files, and allows clang
to find colocated sysroots.
This makes sure that d
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Martin Storsjö (mstorsjo)
Changes
This allows the clang driver to know which tool is meant to be executed, which
allows the clang driver to load the right clang config files, and allows clang
to find colocated sysroots.
This makes sure t
tru wrote:
> The change to X86TargetParser.h looks ABI breaking to me.
This seems unfortunate to me. But I don't think it would be good to insert the
enum at the end of the list and changing the sorting order.
How big of a problem would it be with a ABI break now? I know you have
requested th
https://github.com/paulwalker-arm closed
https://github.com/llvm/llvm-project/pull/108008
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alex-t wrote:
> @alex-t Just curious about the status of this PR. Both this PR and the
> register-allocation PR by CD will have significant impact to the generated
> code. If we decide this is the right direction, then I feel it would be
> better to get it in earlier, so we can access its impa
RKSimon wrote:
It would be messy, but could we not place the CK_ZNVER5 enum entry at the end
of the enum list just for 19.x and then fix the sorting in trunk?
https://github.com/llvm/llvm-project/pull/107964
___
cfe-commits mailing list
cfe-commits@li
AaronBallman wrote:
> It would be messy, but could we not place the CK_ZNVER5 enum entry at the end
> of the enum list just for 19.x and then fix the sorting in trunk?
Seems better than an ABI break this late in the cycle, but I don't have *super*
strong feelings.
https://github.com/llvm/llvm
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/108478
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/108477
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/AaronBallman approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/108476
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tru wrote:
> It would be messy, but could we not place the CK_ZNVER5 enum entry at the end
> of the enum list just for 19.x and then fix the sorting in trunk?
I would be fine with that. WDYT @nikic ?
https://github.com/llvm/llvm-project/pull/107964
_
https://github.com/ilya-biryukov edited
https://github.com/llvm/llvm-project/pull/102040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilya-biryukov commented:
See my comment about `VerifyOnly` and duplicate diagnostics.
The rest are small NITs.
https://github.com/llvm/llvm-project/pull/102040
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
@@ -119,6 +119,14 @@ FIELD(HasInitMethod, 1, NO_MERGE)
/// within anonymous unions or structs.
FIELD(HasInClassInitializer, 1, NO_MERGE)
+/// Custom attribute that is True if any field is marked as explicit in a type
ilya-biryukov wrote:
Suggestion: could we
@@ -2148,6 +2158,19 @@ void
CXXRecordDecl::completeDefinition(CXXFinalOverriderMap *FinalOverriders) {
for (conversion_iterator I = conversion_begin(), E = conversion_end();
I != E; ++I)
I.setAccess((*I)->getAccess());
+
+ ASTContext &Context = getASTContext();
+
@@ -743,6 +743,12 @@ void InitListChecker::FillInEmptyInitForField(unsigned
Init, FieldDecl *Field,
ILE->updateInit(SemaRef.Context, Init, Filler);
return;
}
+
+if (Field->hasAttr()) {
+ SemaRef.Diag(ILE->getExprLoc(), diag::warn_field_requires_expli
@@ -1472,3 +1472,49 @@ template struct Outer {
};
};
Outer::Inner outerinner;
+
+void aggregate() {
+ struct S {
+[[clang::requires_explicit_initialization]] int x;
+int y;
+int z = 12;
+[[clang::requires_explicit_initialization]] int q = 100;
+static voi
@@ -743,6 +743,12 @@ void InitListChecker::FillInEmptyInitForField(unsigned
Init, FieldDecl *Field,
ILE->updateInit(SemaRef.Context, Init, Filler);
return;
}
+
+if (Field->hasAttr()) {
+ SemaRef.Diag(ILE->getExprLoc(), diag::warn_field_requires_expli
ilya-biryukov wrote:
@AaronBallman @cor3ntin I believe we are getting close to finalizing this PR.
Would you be okay with this feature landing and myself approving this when it's
ready?
There was some discussion here and in the RFC, but I don't think there was
explicit approval (or objection)
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108500
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Mikhail Goncharov
Date: 2024-09-13T14:24:09+02:00
New Revision: a41bb71f2216cef08ab04f1d730ae1701c145f3c
URL:
https://github.com/llvm/llvm-project/commit/a41bb71f2216cef08ab04f1d730ae1701c145f3c
DIFF:
https://github.com/llvm/llvm-project/commit/a41bb71f2216cef08ab04f1d730ae1701c145f3c.d
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108500
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108502
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
metaflow wrote:
I have submitted it as a41bb71f2216cef08ab04f1d730ae1701c145f3c (with 3 files).
Sorry for the race, but I want it working :)
https://github.com/llvm/llvm-project/pull/108525
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https
https://github.com/jurahul edited
https://github.com/llvm/llvm-project/pull/108503
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ganeshgit wrote:
> It would be messy, but could we not place the CK_ZNVER5 enum entry at the end
> of the enum list just for 19.x and then fix the sorting in trunk?
> > It would be messy, but could we not place the CK_ZNVER5 enum entry at the
> > end of the enum list just for 19.x and then fix
https://github.com/jurahul updated
https://github.com/llvm/llvm-project/pull/108500
>From e07fa2170e4a9699e89f54442a730d1c14702fa5 Mon Sep 17 00:00:00 2001
From: Rahul Joshi
Date: Thu, 12 Sep 2024 19:50:11 -0700
Subject: [PATCH] [clang][TableGen] Change MVE Emitter to use const
RecordKeeper
-
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108501
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Rahul Joshi (jurahul)
Changes
Change NeonEmitter to use const RecordKeeper.
This is a part of effort to have better const correctness in TableGen backends:
https://discourse.llvm.org/t/psa-planned-changes-to-tablegen-getallderiveddefiniti
https://github.com/jurahul ready_for_review
https://github.com/llvm/llvm-project/pull/108502
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
1 - 100 of 483 matches
Mail list logo
