[clang] [clang][TableGen] Change ASTProperties Emitter to use const RecordKeeper (PR #108274)

2024-09-12 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/108274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TableGen] Change ASTProperties Emitter to use const RecordKeeper (PR #108274)

2024-09-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Rahul Joshi (jurahul) Changes Change ASTProperties Emitter to use const RecordKeeper. This is a part of effort to have better const correctness in TableGen backends: https://discourse.llvm.org/t/psa-planned-changes-to-tablegen-getallderiv

[clang] [clang] Do not substitute parameter pack while retaining the pack expansion (PR #108197)

2024-09-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-armv8-quick` running on `linaro-clang-armv8-quick` while building `clang` at step 5 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/154/builds/4277 Here is the relevant piece of

[clang] [clang][TableGen] Change AST Nodes Emitter to use const RecordKeeper (PR #108270)

2024-09-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/108270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TableGen] Change AttrEmitter to use const RecordKeeper (PR #108269)

2024-09-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/108269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [mlir] [NFC] Fix some typos (PR #108355)

2024-09-12 Thread via cfe-commits
https://github.com/VitalyAnkh edited https://github.com/llvm/llvm-project/pull/108355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TableGen] Change ASTProperties Emitter to use const RecordKeeper (PR #108274)

2024-09-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/108274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Explicitly register NoStoreFuncVisitor from alpha.unix.cst… (PR #108373)

2024-09-12 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus created https://github.com/llvm/llvm-project/pull/108373 …ring.UninitRead This is a drastic simplification of #106982. If you read that patch, this is the same thing with all BugReporterVisitors.cpp and SValBuilder.cpp changes removed! (since all replies came rega

[clang] [analyzer] Implement binary operations on LazyCompoundVals (PR #106982)

2024-09-12 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus closed https://github.com/llvm/llvm-project/pull/106982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Implement binary operations on LazyCompoundVals (PR #106982)

2024-09-12 Thread Kristóf Umann via cfe-commits
Szelethus wrote: Superceding this patch to 108373. https://github.com/llvm/llvm-project/pull/106982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Explicitly register NoStoreFuncVisitor from alpha.unix.cst… (PR #108373)

2024-09-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Kristóf Umann (Szelethus) Changes …ring.UninitRead This is a drastic simplification of #106982. If you read that patch, this is the same thing with all BugReporterVisitors.cpp and SValBuilder.cpp changes removed! (since

[clang] [analyzer] Model overflow builtins (PR #102602)

2024-09-12 Thread Pavel Skripkin via cfe-commits
https://github.com/pskrgag updated https://github.com/llvm/llvm-project/pull/102602 >From 7b4f999b39f4308cab253204e6be41ea7a70f695 Mon Sep 17 00:00:00 2001 From: Pavel Skripkin Date: Fri, 9 Aug 2024 14:37:47 +0300 Subject: [PATCH 01/10] clang/csa: add initial support for builtin overflow ---

[clang] [NFC] Fix an inaccurate comment about typo-correction. (PR #108143)

2024-09-12 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/108143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] Emit predefined macro __riscv_cmodel_large for large code model (PR #108131)

2024-09-12 Thread Sam Elliott via cfe-commits
https://github.com/lenary approved this pull request. Nice catch in the test. Code still LGTM. https://github.com/llvm/llvm-project/pull/108131 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-12 Thread Chris B via cfe-commits
@@ -0,0 +1,42 @@ +//===- hlsl_intrinsics.h - HLSL definitions for intrinsics --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache

[clang] [clang][C23] Support N3029 Improved Normal Enumerations (PR #103917)

2024-09-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM, thank you! https://github.com/llvm/llvm-project/pull/103917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Fix modify_global diagnostics in C++11 (PR #108358)

2024-09-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-qemu` running on `sanitizer-buildbot4` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/139/builds/3638 Here is the relevant piece o

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

2024-09-12 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/107397 >From 621578de568be1e71665254060956ea1971965c9 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 5 Sep 2024 05:42:26 -0700 Subject: [PATCH 1/4] [NFC] Move warning from COdeGen to Sema. --- clang/i

[clang] [compiler-rt] [llvm] [FMV][AArch64] Remove feature sha1 from FMV. (PR #108383)

2024-09-12 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea created https://github.com/llvm/llvm-project/pull/108383 Sha1 has been unified with sha2 in the ACLE spec (see https://github.com/ARM-software/acle/pull/347) so I am changing the compiler to adhere to it. >From 50820f4f3ded438162a33eabca84c5077fd2a5aa Mon Sep 17 00:0

[clang] [compiler-rt] [llvm] [FMV][AArch64] Remove feature sha1 from FMV. (PR #108383)

2024-09-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Author: Alexandros Lamprineas (labrinea) Changes Sha1 has been unified with sha2 in the ACLE spec (see https://github.com/ARM-software/acle/pull/347) so I am changing the compiler to adhere to it. --- Patch is 60.07 KiB, truncated to 20

[clang] [clang-tools-extra] Fix OOM in FormatDiagnostic (PR #108187)

2024-09-12 Thread Aaron Ballman via cfe-commits
@@ -538,24 +511,51 @@ bool DiagnosticsEngine::EmitCurrentDiagnostic(bool Force) { Emitted = (DiagLevel != DiagnosticIDs::Ignored); if (Emitted) { // Emit the diagnostic regardless of suppression level. - Diags->EmitDiag(*this, DiagLevel); + Diags->EmitD

[clang] [clang-tools-extra] Fix OOM in FormatDiagnostic (PR #108187)

2024-09-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you for working on this! I'm not certain that there is a reasonable way to add test coverage for the changes, but if you can devise a test, that would be appreciated. Have you run your changes with address and ub sanitizers to see if there are

[clang] [clang-tools-extra] Fix OOM in FormatDiagnostic (PR #108187)

2024-09-12 Thread Aaron Ballman via cfe-commits
@@ -538,24 +511,51 @@ bool DiagnosticsEngine::EmitCurrentDiagnostic(bool Force) { Emitted = (DiagLevel != DiagnosticIDs::Ignored); if (Emitted) { // Emit the diagnostic regardless of suppression level. - Diags->EmitDiag(*this, DiagLevel); + Diags->EmitD

[clang] [clang-tools-extra] Fix OOM in FormatDiagnostic (PR #108187)

2024-09-12 Thread Aaron Ballman via cfe-commits
@@ -538,24 +511,51 @@ bool DiagnosticsEngine::EmitCurrentDiagnostic(bool Force) { Emitted = (DiagLevel != DiagnosticIDs::Ignored); if (Emitted) { // Emit the diagnostic regardless of suppression level. - Diags->EmitDiag(*this, DiagLevel); + Diags->EmitD

[clang] [clang-tools-extra] Fix OOM in FormatDiagnostic (PR #108187)

2024-09-12 Thread Aaron Ballman via cfe-commits
@@ -571,8 +571,7 @@ DiagnosticIDs::getDiagnosticSeverity(unsigned DiagID, SourceLocation Loc, } // If explicitly requested, map fatal errors to errors. - if (Result == diag::Severity::Fatal && - Diag.CurDiagID != diag::fatal_too_many_errors && Diag.FatalsAsError) --

[clang] [clang-tools-extra] Fix OOM in FormatDiagnostic (PR #108187)

2024-09-12 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/108187 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CGData] Clang Options (PR #90304)

2024-09-12 Thread Ellis Hoag via cfe-commits
https://github.com/ellishg commented: Can we add some documentation to https://github.com/llvm/llvm-project/blob/main/clang/docs/UsersManual.rst? This could also be a separate PR. LGTM, but I want to give others a chance to review. https://github.com/llvm/llvm-project/pull/90304 _

[clang] [analyzer] Refactor MallocChecker to use `BindExpr` in `evalCall` (PR #106081)

2024-09-12 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat approved this pull request. LGTM, feel free to merge this patch. I'm glad that you implemented this; and sorry for this final review delay. https://github.com/llvm/llvm-project/pull/106081 ___ cfe-commits mailing list cfe-

[clang] [llvm] Delete the clang-format Visual Studio plugin code (PR #108342)

2024-09-12 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-aarch64-sve-vls` running on `linaro-g3-04` while building `clang,llvm` at step 7 "ninja check 1". Full details are available at: https://lab.llvm.org/buildbot/#/builders/143/builds/2098 Here is the relevant piece of th

[clang] [clang-tools-extra] Fix OOM in FormatDiagnostic (PR #108187)

2024-09-12 Thread Vakhurin Sergei via cfe-commits
@@ -538,24 +511,51 @@ bool DiagnosticsEngine::EmitCurrentDiagnostic(bool Force) { Emitted = (DiagLevel != DiagnosticIDs::Ignored); if (Emitted) { // Emit the diagnostic regardless of suppression level. - Diags->EmitDiag(*this, DiagLevel); + Diags->EmitD

[clang-tools-extra] [mlir] [NFC] Fix some typos (PR #108355)

2024-09-12 Thread Jakub Kuderski via cfe-commits
@@ -101,7 +101,7 @@ module.exports = { // $predicate `,` $lhs `,` $rhs attr-dict `:` type($lhs) seq(choice('arith.cmpi', 'arith.cmpf'), field('predicate', - choice('eq', 'ne', 'oeq', 'o

[clang-tools-extra] [mlir] [NFC] Fix some typos (PR #108355)

2024-09-12 Thread Jakub Kuderski via cfe-commits
@@ -24,7 +24,7 @@ "eq" "ne" "oeq" - "olt" + "old" kuhar wrote: also here https://github.com/llvm/llvm-project/pull/108355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang-tools-extra] [mlir] [NFC] Fix some typos (PR #108355)

2024-09-12 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar edited https://github.com/llvm/llvm-project/pull/108355 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [mlir] [NFC] Fix some typos (PR #108355)

2024-09-12 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar requested changes to this pull request. I think this will be easier to review / merge if you split the PR into a few smaller ones, e.g., by project (clang, mlir, llvm, etc.). We could further split it down by stuff that's clearly safe to land (e.g., comments), and thing

[clang] [clang-tools-extra] Fix OOM in FormatDiagnostic (PR #108187)

2024-09-12 Thread Vakhurin Sergei via cfe-commits
igelbox wrote: > Have you run your changes with address and ub sanitizers to see if there are > some uncaught edge cases? Not quire sure I get the point about UB-sanitizers. I tested this changes against my proprietary code which caused the issue with OOM/infinite-loop and it works just fine.

[clang] [clang-tools-extra] Fix OOM in FormatDiagnostic (PR #108187)

2024-09-12 Thread Vakhurin Sergei via cfe-commits
igelbox wrote: > I'm not certain that there is a reasonable way to add test coverage for the > changes, but if you can devise a test, that would be appreciated. I wonder there should be some tests like: - input = some source files - output = expected it compiles well and has no assertions fired

[clang] b433023 - [Clang][NFC] Remove trailing whitespace from clang/tools/libclang/CXStoredDIagnostic.cpp

2024-09-12 Thread Nikolas Klauser via cfe-commits
Author: Nikolas Klauser Date: 2024-09-12T15:43:27+02:00 New Revision: b43302372f592fd48a22d32b2603f8efee40a88e URL: https://github.com/llvm/llvm-project/commit/b43302372f592fd48a22d32b2603f8efee40a88e DIFF: https://github.com/llvm/llvm-project/commit/b43302372f592fd48a22d32b2603f8efee40a88e.dif

[clang] [analyzer] Fix StreamChecker crash in fread modeling (PR #108393)

2024-09-12 Thread Balazs Benics via cfe-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/108393 In #93408 https://github.com/llvm/llvm-project/commit/69bc159142c6e4ed168e32a6168392d396f891de I refined how invalidation is done for `fread`. It can crash, if the "size" or "count" parameters of "fread" is a

[clang] [analyzer] Fix StreamChecker crash in fread modeling (PR #108393)

2024-09-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Balazs Benics (steakhal) Changes In #93408 https://github.com/llvm/llvm-project/commit/69bc159142c6e4ed168e32a6168392d396f891de I refined how invalidation is done for `fread`. It can crash, if the "size" or "count" param

[clang] [analyzer] Fix StreamChecker crash in fread modeling (PR #108393)

2024-09-12 Thread Balazs Benics via cfe-commits
steakhal wrote: I'm debating if we should backport this to clang-19, but I'd say this crash does not happen too often in real life to advocate for it. So I don't intend to backport this, unless someone asks for it. https://github.com/llvm/llvm-project/pull/108393 __

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] Probe for -nostdlib++ and -nostdinc++ with the C compiler (PR #108357)

2024-09-12 Thread Louis Dionne via cfe-commits
@@ -38,9 +38,13 @@ check_cxx_compiler_flag(-nolibc CXX_SUPPORTS_NOLIBC_FLAG) # required during compilation (which has the -nostdlib++ or -nodefaultlibs). libc is # required for the link to go through. We remove sanitizers from the # configuration checks to avoid spurious link

[clang] [clang][bytecode] Add support for creating dummies for expressions (PR #108394)

2024-09-12 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/108394 None >From 39e7df01a18e43a681e20e375afcd0dc8e67432c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Thu, 12 Sep 2024 15:16:08 +0200 Subject: [PATCH] [clang][bytecode] Add support for creatin

[clang-tools-extra] [clang-tidy] Improve documentation of bugprone-pointer-arithmetic-on-polymorphic-object (PR #108324)

2024-09-12 Thread Mainak Sil via cfe-commits
https://github.com/MainakSil updated https://github.com/llvm/llvm-project/pull/108324 >From edb6664fbdafb5127d141fde633779865a90dde1 Mon Sep 17 00:00:00 2001 From: Mainak Sil Date: Thu, 12 Sep 2024 08:58:15 +0530 Subject: [PATCH] Improve documentation for bugprone-pointer-arithmetic-on-polymor

[clang] [clang][bytecode] Add support for creating dummies for expressions (PR #108394)

2024-09-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/108394.diff 4 Files Affected: - (modified) clang/lib/AST/ByteCode/Compiler.cpp (+6-2) - (modified) clang/lib/AST/ByteCode/Program.cpp (+20-9) - (

[clang-tools-extra] [clang-tidy] Improve documentation of bugprone-pointer-arithmetic-on-polymorphic-object (PR #108324)

2024-09-12 Thread Mainak Sil via cfe-commits
https://github.com/MainakSil updated https://github.com/llvm/llvm-project/pull/108324 >From edb6664fbdafb5127d141fde633779865a90dde1 Mon Sep 17 00:00:00 2001 From: Mainak Sil Date: Thu, 12 Sep 2024 08:58:15 +0530 Subject: [PATCH] Improve documentation for bugprone-pointer-arithmetic-on-polymor

[clang] dbc90b5 - [clang][TableGen] Change AttrEmitter to use const RecordKeeper (#108269)

2024-09-12 Thread via cfe-commits
Author: Rahul Joshi Date: 2024-09-12T06:51:25-07:00 New Revision: dbc90b55e832695c96d8dc1427e9df3bfeb73e5a URL: https://github.com/llvm/llvm-project/commit/dbc90b55e832695c96d8dc1427e9df3bfeb73e5a DIFF: https://github.com/llvm/llvm-project/commit/dbc90b55e832695c96d8dc1427e9df3bfeb73e5a.diff L

[clang] [clang][TableGen] Change AttrEmitter to use const RecordKeeper (PR #108269)

2024-09-12 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/108269 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b6ff8ed - [clang][TableGen] Change AST Nodes Emitter to use const RecordKeeper (#108270)

2024-09-12 Thread via cfe-commits
Author: Rahul Joshi Date: 2024-09-12T06:51:51-07:00 New Revision: b6ff8ed5d4d03b28e41b73ef8e76ce94a8fa76f0 URL: https://github.com/llvm/llvm-project/commit/b6ff8ed5d4d03b28e41b73ef8e76ce94a8fa76f0 DIFF: https://github.com/llvm/llvm-project/commit/b6ff8ed5d4d03b28e41b73ef8e76ce94a8fa76f0.diff L

[clang] [clang][TableGen] Change AST Nodes Emitter to use const RecordKeeper (PR #108270)

2024-09-12 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/108270 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TableGen] Change ASTProperties Emitter to use const RecordKeeper (PR #108274)

2024-09-12 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul updated https://github.com/llvm/llvm-project/pull/108274 >From c2c1486a0427ff33e3caf584bac3f0baed3c1476 Mon Sep 17 00:00:00 2001 From: Rahul Joshi Date: Wed, 11 Sep 2024 11:51:51 -0700 Subject: [PATCH] [clang][TableGen] Change ASTProperties Emitter to use const Recor

[clang-tools-extra] [clang-tidy] Improve documentation of bugprone-pointer-arithmetic-on-polymorphic-object (PR #108324)

2024-09-12 Thread Mainak Sil via cfe-commits
https://github.com/MainakSil updated https://github.com/llvm/llvm-project/pull/108324 >From edb6664fbdafb5127d141fde633779865a90dde1 Mon Sep 17 00:00:00 2001 From: Mainak Sil Date: Thu, 12 Sep 2024 08:58:15 +0530 Subject: [PATCH] Improve documentation for bugprone-pointer-arithmetic-on-polymor

[clang-tools-extra] [clang-tidy] add default error message for performance-avoid-endl (PR #107867)

2024-09-12 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/107867 >From 31b01c0cd3fc809e5451853b820d021dd43d16c7 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 9 Sep 2024 22:32:48 +0800 Subject: [PATCH 1/5] [clang-tidy] add default error message for performance-av

[clang] [Clang][ARM] Make CRC and DSP intrinsics always available. (PR #107417)

2024-09-12 Thread David Green via cfe-commits
https://github.com/davemgreen commented: I think this is OK but do you know if the dsp side works with cortex-m? Target attributes are less likely to be used there, but it's worth testing if the command line args are still all happy. https://github.com/llvm/llvm-project/pull/107417 ___

[clang] [analyzer] Fix StreamChecker crash in fread modeling (PR #108393)

2024-09-12 Thread Donát Nagy via cfe-commits
@@ -443,3 +443,33 @@ void test_unaligned_start_read(void) { fclose(fp); } } + +void no_crash_if_count_is_negative(long s, unsigned char *buffer) { + FILE *fp = fopen("path", "r"); + if (fp) { +if (s * s == -1) { NagyDonat wrote: Nitpick: $s^2 = -1$

[clang] [analyzer] Fix StreamChecker crash in fread modeling (PR #108393)

2024-09-12 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/108393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Fix StreamChecker crash in fread modeling (PR #108393)

2024-09-12 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat approved this pull request. LGTM, thanks for catching this! https://github.com/llvm/llvm-project/pull/108393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit

[clang] [clang][HLSL] Add sign intrinsic part 4 (PR #108396)

2024-09-12 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich ready_for_review https://github.com/llvm/llvm-project/pull/108396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Improve documentation of bugprone-pointer-arithmetic-on-polymorphic-object (PR #108324)

2024-09-12 Thread Mainak Sil via cfe-commits
https://github.com/MainakSil updated https://github.com/llvm/llvm-project/pull/108324 >From edb6664fbdafb5127d141fde633779865a90dde1 Mon Sep 17 00:00:00 2001 From: Mainak Sil Date: Thu, 12 Sep 2024 08:58:15 +0530 Subject: [PATCH 1/2] Improve documentation for bugprone-pointer-arithmetic-on-pol

[clang] [clang][HLSL] Add sign intrinsic part 4 (PR #108396)

2024-09-12 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich edited https://github.com/llvm/llvm-project/pull/108396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HLSL] Add sign intrinsic part 4 (PR #108396)

2024-09-12 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich edited https://github.com/llvm/llvm-project/pull/108396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HLSL] Add sign intrinsic part 4 (PR #108396)

2024-09-12 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich edited https://github.com/llvm/llvm-project/pull/108396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HLSL] Add sign intrinsic part 4 (PR #108396)

2024-09-12 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: Tim Gymnich (tgymnich) Changes - Add handling for unsigned integers to hlsl_elementwise_sign - Use `select` instead of adding dx and spirv intrinsics for unsigned integers as [di

[clang] [analyzer] Fix StreamChecker crash in fread modeling (PR #108393)

2024-09-12 Thread Balazs Benics via cfe-commits
@@ -443,3 +443,33 @@ void test_unaligned_start_read(void) { fclose(fp); } } + +void no_crash_if_count_is_negative(long s, unsigned char *buffer) { + FILE *fp = fopen("path", "r"); + if (fp) { +if (s * s == -1) { steakhal wrote: Yea, I noticed that

[clang] [analyzer] Fix StreamChecker crash in fread modeling (PR #108393)

2024-09-12 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/108393 >From d2e5e284980843867652df499b05169cc6058c36 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Thu, 12 Sep 2024 15:20:19 +0200 Subject: [PATCH 1/2] [analyzer] Fix StreamChecker crash in fread modeling In #9

[clang] [clang][HLSL] Add sign intrinsic part 4 (PR #108396)

2024-09-12 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich edited https://github.com/llvm/llvm-project/pull/108396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HLSL] Add sign intrinsic part 4 (PR #108396)

2024-09-12 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich edited https://github.com/llvm/llvm-project/pull/108396 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] add default error message for performance-avoid-endl (PR #107867)

2024-09-12 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/107867 >From 31b01c0cd3fc809e5451853b820d021dd43d16c7 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Mon, 9 Sep 2024 22:32:48 +0800 Subject: [PATCH 1/5] [clang-tidy] add default error message for performance-av

[clang] [clang][HLSL] Add sign intrinsic part 4 (PR #108396)

2024-09-12 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich created https://github.com/llvm/llvm-project/pull/108396 - add handling for unsigned integers to hlsl_elementwise_sign ### Related PRs - https://github.com/llvm/llvm-project/pull/101987 - https://github.com/llvm/llvm-project/pull/101988 - https://github.com/llvm/llvm

[clang-tools-extra] [clang-tidy] Improve documentation of bugprone-pointer-arithmetic-on-polymorphic-object (PR #108324)

2024-09-12 Thread Mainak Sil via cfe-commits
https://github.com/MainakSil updated https://github.com/llvm/llvm-project/pull/108324 >From edb6664fbdafb5127d141fde633779865a90dde1 Mon Sep 17 00:00:00 2001 From: Mainak Sil Date: Thu, 12 Sep 2024 08:58:15 +0530 Subject: [PATCH 1/2] Improve documentation for bugprone-pointer-arithmetic-on-pol

[clang] Don't emit int TBAA metadata on more complex FP math libcalls. (PR #107598)

2024-09-12 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/107598 >From 0763f8d25194e18a040d4cd4cde7c88b6fccbb44 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Fri, 6 Sep 2024 08:01:25 -0700 Subject: [PATCH 1/4] Don't emit int TBAA metadata on more complex FP math

[clang] Don't emit int TBAA metadata on more complex FP math libcalls. (PR #107598)

2024-09-12 Thread Zahira Ammarguellat via cfe-commits
@@ -699,9 +699,20 @@ static RValue emitLibraryCall(CodeGenFunction &CGF, const FunctionDecl *FD, bool ConstWithoutErrnoAndExceptions = Context.BuiltinInfo.isConstWithoutErrnoAndExceptions(BuiltinID); // Restrict to target with errno, for example, MacOS doesn't

[clang] [clang][analyzer] Move 'alpha.core.PointerSub' checker into 'core.PointerSub' (PR #107596)

2024-09-12 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat commented: I think this checker is definitely good enough to be moved out of `alpha`, but I'm not sure that it should be placed in the `core` group, where we have a strong requirement that "These checkers must be always switched on as other checker rely on them.".

[clang] [NFC] Fix an inaccurate comment about typo-correction. (PR #108143)

2024-09-12 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/108143 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 64dba97 - [NFC] Fix an inaccurate comment about typo-correction. (#108143)

2024-09-12 Thread via cfe-commits
Author: Michael Park Date: 2024-09-12T16:38:59+02:00 New Revision: 64dba97a981393c21cff8bddc0d2272535da45d5 URL: https://github.com/llvm/llvm-project/commit/64dba97a981393c21cff8bddc0d2272535da45d5 DIFF: https://github.com/llvm/llvm-project/commit/64dba97a981393c21cff8bddc0d2272535da45d5.diff

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] Probe for -nostdlib++ and -nostdinc++ with the C compiler (PR #108357)

2024-09-12 Thread Martin Storsjö via cfe-commits
@@ -38,9 +38,13 @@ check_cxx_compiler_flag(-nolibc CXX_SUPPORTS_NOLIBC_FLAG) # required during compilation (which has the -nostdlib++ or -nodefaultlibs). libc is # required for the link to go through. We remove sanitizers from the # configuration checks to avoid spurious link

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

2024-09-12 Thread Vlad Serebrennikov via cfe-commits
@@ -1180,6 +1180,16 @@ void Sema::PrintPragmaAttributeInstantiationPoint() { diag::note_pragma_attribute_applied_decl_here); } +void Sema::DiagnoseExcessPrecision() { + if (NumExcessPrecisionNotSatisfied > 0) { +for (auto &[Loc, Type, Num] : ExcessPrecision

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

2024-09-12 Thread Vlad Serebrennikov via cfe-commits
@@ -626,6 +626,11 @@ class Sema final : public SemaBase { const llvm::MapVector & getMismatchingDeleteExpressions() const; + std::vector> + ExcessPrecisionNotSatisfied; Endilll wrote: I think all three data members should be moved down to `SemaExpr.

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

2024-09-12 Thread Vlad Serebrennikov via cfe-commits
@@ -1180,6 +1180,16 @@ void Sema::PrintPragmaAttributeInstantiationPoint() { diag::note_pragma_attribute_applied_decl_here); } +void Sema::DiagnoseExcessPrecision() { + if (NumExcessPrecisionNotSatisfied > 0) { +for (auto &[Loc, Type, Num] : ExcessPrecision

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

2024-09-12 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/107397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Move 'alpha.core.PointerSub' checker into 'core.PointerSub' (PR #107596)

2024-09-12 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/107596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

2024-09-12 Thread Vlad Serebrennikov via cfe-commits
@@ -626,6 +626,11 @@ class Sema final : public SemaBase { const llvm::MapVector & getMismatchingDeleteExpressions() const; + std::vector> + ExcessPrecisionNotSatisfied; Endilll wrote: Or `(Num >1 ? 1 : 0)` if you wany https://github.com/llvm/llvm-p

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

2024-09-12 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/107397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Move warning from CodeGen to Sema. (PR #107397)

2024-09-12 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/107397 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Move 'alpha.core.PointerSub' checker into 'core.PointerSub' (PR #107596)

2024-09-12 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/107596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86][AVX10.2] Support AVX10.2-SATCVT-DS new instructions. (PR #102592)

2024-09-12 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/102592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-12 Thread via cfe-commits
https://github.com/joaosaffran updated https://github.com/llvm/llvm-project/pull/107292 >From c6434c06d17a2442863f8843e75dc870966fb97c Mon Sep 17 00:00:00 2001 From: Joao Saffran Date: Tue, 3 Sep 2024 19:06:22 + Subject: [PATCH 1/5] Adding `asuint` implementation to hlsl --- clang/includ

[clang] [HLSL] Allow narrowing in initialization lists (PR #108035)

2024-09-12 Thread Chris B via cfe-commits
llvm-beanz wrote: > Can we test this? It is tested. The modified test case adds a run line with `-std=hlsl202x` which fails without this change due to narrowing conversion in an initializer list. https://github.com/llvm/llvm-project/pull/108035 ___ c

[clang-tools-extra] [clang-tidy] Improve documentation of bugprone-pointer-arithmetic-on-polymorphic-object (PR #108324)

2024-09-12 Thread Mainak Sil via cfe-commits
MainakSil wrote: I have updated the example based on your feedback. The `new`/`delete` usage has been removed to avoid additional undefined behavior. The example now directly passes a pointer to a function, which performs the pointer arithmetic, focusing solely on the issue of undefined behavi

[clang] Adding `asuint` implementation to hlsl (PR #107292)

2024-09-12 Thread via cfe-commits
@@ -0,0 +1,42 @@ +//===- hlsl_intrinsics.h - HLSL definitions for intrinsics --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apache

[clang-tools-extra] [clang-tidy] add default error message for performance-avoid-endl (PR #107867)

2024-09-12 Thread Danny Mösch via cfe-commits
https://github.com/SimplyDanny approved this pull request. https://github.com/llvm/llvm-project/pull/107867 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2e30f8d - [analyzer] Fix StreamChecker crash in fread modeling (#108393)

2024-09-12 Thread via cfe-commits
Author: Balazs Benics Date: 2024-09-12T17:06:52+02:00 New Revision: 2e30f8d114e1406b35dc63868a92f4279330251b URL: https://github.com/llvm/llvm-project/commit/2e30f8d114e1406b35dc63868a92f4279330251b DIFF: https://github.com/llvm/llvm-project/commit/2e30f8d114e1406b35dc63868a92f4279330251b.diff

[clang] [analyzer] Fix StreamChecker crash in fread modeling (PR #108393)

2024-09-12 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/108393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Move 'alpha.core.PointerSub' checker into 'core.PointerSub' (PR #107596)

2024-09-12 Thread Balazs Benics via cfe-commits
steakhal wrote: Agreed! https://github.com/llvm/llvm-project/pull/107596 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Implement base casts on integral pointers (PR #108340)

2024-09-12 Thread via cfe-commits
https://github.com/yronglin approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/108340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Implement base casts on integral pointers (PR #108340)

2024-09-12 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/108340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 43fd2c4 - [clang][bytecode] Implement base casts on integral pointers (#108340)

2024-09-12 Thread via cfe-commits
Author: Timm Baeder Date: 2024-09-12T17:19:37+02:00 New Revision: 43fd2c401edd4f3ca0c687dd6937c2603fb15f71 URL: https://github.com/llvm/llvm-project/commit/43fd2c401edd4f3ca0c687dd6937c2603fb15f71 DIFF: https://github.com/llvm/llvm-project/commit/43fd2c401edd4f3ca0c687dd6937c2603fb15f71.diff L

[clang] [RISCV][FMV] Support target_clones (PR #85786)

2024-09-12 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/85786 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Add support for creating dummies for expressions (PR #108394)

2024-09-12 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/108394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Add support for creating dummies for expressions (PR #108394)

2024-09-12 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr edited https://github.com/llvm/llvm-project/pull/108394 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] bd8d432 - [clang][bytecode] Add support for creating dummies for expressions (#108394)

2024-09-12 Thread via cfe-commits
Author: Timm Baeder Date: 2024-09-12T17:25:40+02:00 New Revision: bd8d432d7bd0891132ae69daa70e18ba387df43f URL: https://github.com/llvm/llvm-project/commit/bd8d432d7bd0891132ae69daa70e18ba387df43f DIFF: https://github.com/llvm/llvm-project/commit/bd8d432d7bd0891132ae69daa70e18ba387df43f.diff L

<    1   2   3   4   5   6   >