[clang] [clang] Do not substitute parameter pack while retaining the pack expansion (PR #108197)

2024-09-11 Thread Ilya Biryukov via cfe-commits
ilya-biryukov wrote: I have spent some time poking at the code and looking at the debugger and came up with a smaller repro, see https://gcc.godbolt.org/z/6ccPPd6hz: ```cpp int bar(...); template struct Int {}; template constexpr auto foo(T... x) -> decltype(bar(T(x)...)) { return 1; } temp

[clang] [clangl[TableGen] Change Diagnostic Emitter to use const RecordKeeper (PR #108209)

2024-09-11 Thread Rahul Joshi via cfe-commits
@@ -68,7 +69,8 @@ getCategoryFromDiagGroup(const Record *Group, // The diag group may the subgroup of one or more other diagnostic groups, // check these for a category as well. - const std::vector &Parents = DiagGroupParents.getParents(Group); + const std::vector &Paren

[clang] [clang-tools-extra] [clang] Extend diagnose_if to accept more detailed warning information (PR #70976)

2024-09-11 Thread Aaron Ballman via cfe-commits
@@ -870,7 +872,8 @@ class DiagnosticsEngine : public RefCountedBase { /// \param FormatString A fixed diagnostic format string that will be hashed /// and mapped to a unique DiagID. template - unsigned getCustomDiagID(Level L, const char (&FormatString)[N]) { + [[depr

[clang] [clang-tools-extra] [clang] Extend diagnose_if to accept more detailed warning information (PR #70976)

2024-09-11 Thread Aaron Ballman via cfe-commits
@@ -179,13 +180,85 @@ class DiagnosticMapping { class DiagnosticIDs : public RefCountedBase { public: /// The level of the diagnostic, after it has been through mapping. - enum Level { -Ignored, Note, Remark, Warning, Error, Fatal + enum Level : uint8_t { Ignored, Note,

[clang] [clang-tools-extra] [clang] Extend diagnose_if to accept more detailed warning information (PR #70976)

2024-09-11 Thread Aaron Ballman via cfe-commits
@@ -597,6 +592,15 @@ DiagnosticIDs::getDiagnosticSeverity(unsigned DiagID, SourceLocation Loc, return Result; } +DiagnosticIDs::Class DiagnosticIDs::getDiagClass(unsigned DiagID) const { + if (IsCustomDiag(DiagID)) +return Class(CustomDiagInfo->getDescription(DiagID).G

[clang] [clang-tools-extra] [clang] Extend diagnose_if to accept more detailed warning information (PR #70976)

2024-09-11 Thread Aaron Ballman via cfe-commits
@@ -200,7 +273,33 @@ class DiagnosticIDs : public RefCountedBase { // FIXME: Replace this function with a create-only facilty like // createCustomDiagIDFromFormatString() to enforce safe usage. At the time of // writing, nearly all callers of this function were invalid.

[clang] [clang-tools-extra] [clang] Extend diagnose_if to accept more detailed warning information (PR #70976)

2024-09-11 Thread Aaron Ballman via cfe-commits
@@ -509,30 +499,32 @@ DiagnosticIDs::getDiagnosticLevel(unsigned DiagID, SourceLocation Loc, diag::Severity DiagnosticIDs::getDiagnosticSeverity(unsigned DiagID, SourceLocation Loc, const DiagnosticsEngine &Diag) const { - assert(getBuilti

[clang] [clang-tools-extra] [clang] Extend diagnose_if to accept more detailed warning information (PR #70976)

2024-09-11 Thread Aaron Ballman via cfe-commits
@@ -33,14 +33,14 @@ CXDiagnosticSeverity CXStoredDiagnostic::getSeverity() const { case DiagnosticsEngine::Error: return CXDiagnostic_Error; case DiagnosticsEngine::Fatal: return CXDiagnostic_Fatal; } - + AaronBallman wrote: A lot of unrelated

[clang] [clang-tools-extra] [clang] Extend diagnose_if to accept more detailed warning information (PR #70976)

2024-09-11 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/70976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] Extend diagnose_if to accept more detailed warning information (PR #70976)

2024-09-11 Thread Aaron Ballman via cfe-commits
@@ -269,11 +268,60 @@ CATEGORY(INSTALLAPI, REFACTORING) return Found; } -DiagnosticMapping DiagnosticIDs::getDefaultMapping(unsigned DiagID) { +//===--===// +// Custom Diagnostic information +//===--

[clang] [clang-tools-extra] [clang] Extend diagnose_if to accept more detailed warning information (PR #70976)

2024-09-11 Thread Aaron Ballman via cfe-commits
@@ -200,7 +273,33 @@ class DiagnosticIDs : public RefCountedBase { // FIXME: Replace this function with a create-only facilty like // createCustomDiagIDFromFormatString() to enforce safe usage. At the time of // writing, nearly all callers of this function were invalid.

[clang] [clang-tools-extra] [clang] Extend diagnose_if to accept more detailed warning information (PR #70976)

2024-09-11 Thread Aaron Ballman via cfe-commits
@@ -179,13 +180,85 @@ class DiagnosticMapping { class DiagnosticIDs : public RefCountedBase { public: /// The level of the diagnostic, after it has been through mapping. - enum Level { -Ignored, Note, Remark, Warning, Error, Fatal + enum Level : uint8_t { Ignored, Note,

[clang] [clang-tools-extra] [clang] Extend diagnose_if to accept more detailed warning information (PR #70976)

2024-09-11 Thread Aaron Ballman via cfe-commits
@@ -166,8 +166,12 @@ DiagnosticsEngine::DiagState::getOrAddMapping(diag::kind Diag) { DiagMap.insert(std::make_pair(Diag, DiagnosticMapping())); // Initialize the entry if we added it. - if (Result.second) -Result.first->second = DiagnosticIDs::getDefaultMapping(

[clang] [clang-tools-extra] [clang] Extend diagnose_if to accept more detailed warning information (PR #70976)

2024-09-11 Thread Aaron Ballman via cfe-commits
@@ -286,6 +334,18 @@ DiagnosticMapping DiagnosticIDs::getDefaultMapping(unsigned DiagID) { return Info; } +void DiagnosticIDs::initCustomDiagMapping(DiagnosticMapping &Mapping, + unsigned DiagID) { + assert(IsCustomDiag(DiagID)); +

[clang] [clang-tools-extra] [clang] Extend diagnose_if to accept more detailed warning information (PR #70976)

2024-09-11 Thread Aaron Ballman via cfe-commits
@@ -179,13 +180,85 @@ class DiagnosticMapping { class DiagnosticIDs : public RefCountedBase { public: /// The level of the diagnostic, after it has been through mapping. - enum Level { -Ignored, Note, Remark, Warning, Error, Fatal + enum Level : uint8_t { Ignored, Note,

[clang] [clang-tools-extra] [clang] Extend diagnose_if to accept more detailed warning information (PR #70976)

2024-09-11 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Sorry for the delayed review! Just some minor points, mostly. https://github.com/llvm/llvm-project/pull/70976 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] [clangl[TableGen] Change Diagnostic Emitter to use const RecordKeeper (PR #108209)

2024-09-11 Thread Rahul Joshi via cfe-commits
@@ -255,20 +257,18 @@ class InferPedantic { GMap; DiagGroupParentMap &DiagGroupParents; - const std::vector &Diags; - const std::vector DiagGroups; + ArrayRef Diags; jurahul wrote: Yes. If you look at https://discourse.llvm.org/t/psa-planned-chang

[clang] [clangl[TableGen] Change Diagnostic Emitter to use const RecordKeeper (PR #108209)

2024-09-11 Thread Aaron Ballman via cfe-commits
@@ -68,7 +69,8 @@ getCategoryFromDiagGroup(const Record *Group, // The diag group may the subgroup of one or more other diagnostic groups, // check these for a category as well. - const std::vector &Parents = DiagGroupParents.getParents(Group); + const std::vector &Paren

[clang] [clangl[TableGen] Change Diagnostic Emitter to use const RecordKeeper (PR #108209)

2024-09-11 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/108209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clangl[TableGen] Change Diagnostic Emitter to use const RecordKeeper (PR #108209)

2024-09-11 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/108209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clangl[TableGen] Change Diagnostic Emitter to use const RecordKeeper (PR #108209)

2024-09-11 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/108209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Parser] Build up QualifiedTemplateName for typo correction (PR #108148)

2024-09-11 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/108148 >From bd6097801e9a822f5b9e49a6f2fb09b999b4a80d Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Wed, 11 Sep 2024 14:28:46 +0800 Subject: [PATCH 1/2] [Clang][Parser] Build up QualifiedTemplateName for typo corr

[clang] [Clang][Parser] Build up QualifiedTemplateName for typo correction (PR #108148)

2024-09-11 Thread Younan Zhang via cfe-commits
@@ -3567,7 +3567,10 @@ bool Sema::resolveAssumedTemplateNameAsType(Scope *S, TemplateName &Name, if (Corrected && Corrected.getFoundDecl()) { diagnoseTypo(Corrected, PDiag(diag::err_no_template_suggest) << ATN->getDeclName()); -Name =

[clang] [clang] Do not substitute parameter pack while retaining the pack expansion (PR #108197)

2024-09-11 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/108197 >From 5901d82ea0543074853b963f7dc9106a6fe3bcee Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Wed, 11 Sep 2024 11:33:45 + Subject: [PATCH 1/3] [clang] Do not expand pack while retaining expansion --- cl

[clang-tools-extra] Add clang-tidy external examples (PR #106675)

2024-09-11 Thread Danny Mösch via cfe-commits
@@ -0,0 +1,32 @@ + +External Clang-Tidy Examples + + +Introduction + + +This page provides examples of what people have done with :program:`clang-tidy` that +might serve as useful guides (or starting points) to

[clang-tools-extra] Add clang-tidy external examples (PR #106675)

2024-09-11 Thread Danny Mösch via cfe-commits
@@ -0,0 +1,32 @@ + +External Clang-Tidy Examples + + +Introduction + + +This page provides examples of what people have done with :program:`clang-tidy` that +might serve as useful guides (or starting points) to

[clang] Add AlignFunctionDeclarations attribute to AlignConsecutiveDeclarations (PR #108241)

2024-09-11 Thread Brad House via cfe-commits
https://github.com/bradh352 created https://github.com/llvm/llvm-project/pull/108241 Enabling AlignConsecutiveDeclarations also aligns function prototypes or declarations. This is often unexpected as typically function prototypes, especially in public headers, don't use any padding. Setting Al

[clang] Add AlignFunctionDeclarations attribute to AlignConsecutiveDeclarations (PR #108241)

2024-09-11 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] Add AlignFunctionDeclarations attribute to AlignConsecutiveDeclarations (PR #108241)

2024-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Brad House (bradh352) Changes Enabling AlignConsecutiveDeclarations also aligns function prototypes or declarations. This is often unexpected as typically function prototypes, especially in public headers, don't use any padding. Setting A

[clang] clang-format: Add AlignFunctionDeclarations attribute to AlignConsecutiveDeclarations (PR #108241)

2024-09-11 Thread Brad House via cfe-commits
https://github.com/bradh352 edited https://github.com/llvm/llvm-project/pull/108241 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clangl[TableGen] Change Diagnostic Emitter to use const RecordKeeper (PR #108209)

2024-09-11 Thread Rahul Joshi via cfe-commits
@@ -39,12 +39,13 @@ using namespace llvm; namespace { class DiagGroupParentMap { - RecordKeeper &Records; - std::map > Mapping; + const RecordKeeper &Records; + std::map> Mapping; jurahul wrote: Sound good, I'll change in the follow on. https://github.co

[clang] [clangl[TableGen] Change Diagnostic Emitter to use const RecordKeeper (PR #108209)

2024-09-11 Thread Rahul Joshi via cfe-commits
@@ -255,20 +257,18 @@ class InferPedantic { GMap; DiagGroupParentMap &DiagGroupParents; - const std::vector &Diags; - const std::vector DiagGroups; + ArrayRef Diags; jurahul wrote: Let me know if that answers your question. This PR will unblock som

[clang-tools-extra] [clang-tidy] fix false positive in modernize-min-max-use-initializer-list (PR #107649)

2024-09-11 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/107649 >From 097a679f33bdded29fa67833b7fcd4707057cbf3 Mon Sep 17 00:00:00 2001 From: Julian Schmidt Date: Sat, 7 Sep 2024 00:10:08 +0200 Subject: [PATCH 1/2] [clang-tidy] fix false positive in modernize-min-max-use-i

[clang-tools-extra] [clang-tidy] fix false positive in modernize-min-max-use-initializer-list (PR #107649)

2024-09-11 Thread Julian Schmidt via cfe-commits
5chmidti wrote: You're right with both of your comments. I've changed the implementation in the latest commit. https://github.com/llvm/llvm-project/pull/107649 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [clangl[TableGen] Change Diagnostic Emitter to use const RecordKeeper (PR #108209)

2024-09-11 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul deleted https://github.com/llvm/llvm-project/pull/108209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 463c9d2 - [clang][TableGen] Change ASTTableGen to use const Record pointers (#108193)

2024-09-11 Thread via cfe-commits
Author: Rahul Joshi Date: 2024-09-11T08:55:01-07:00 New Revision: 463c9d29664a27e3cb6d07928f44bd50064d3898 URL: https://github.com/llvm/llvm-project/commit/463c9d29664a27e3cb6d07928f44bd50064d3898 DIFF: https://github.com/llvm/llvm-project/commit/463c9d29664a27e3cb6d07928f44bd50064d3898.diff L

[clang] [clang][TableGen] Change ASTTableGen to use const Record pointers (PR #108193)

2024-09-11 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/108193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Parser] Build up QualifiedTemplateName for typo correction (PR #108148)

2024-09-11 Thread Erich Keane via cfe-commits
https://github.com/erichkeane approved this pull request. https://github.com/llvm/llvm-project/pull/108148 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TableGen] Change OpenCL emitter to use const RecordKeeper (PR #108213)

2024-09-11 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul ready_for_review https://github.com/llvm/llvm-project/pull/108213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TableGen] Change OpenCL emitter to use const RecordKeeper (PR #108213)

2024-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Rahul Joshi (jurahul) Changes Change OpenCL builtins emitter to use const RecordKeeper This is a part of effort to have better const correctness in TableGen backends: https://discourse.llvm.org/t/psa-planned-changes-to-tablegen-getallderi

[clang-tools-extra] [clang-tidy] Add `std::span` to default `bugprone-dangling-handle.HandleClasses` (PR #107711)

2024-09-11 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti commented: Please modify the check's documentation of the `HandleClasses` option to include `std::span` (https://github.com/llvm/llvm-project/blob/main/clang-tools-extra/docs/clang-tidy/checks/bugprone/dangling-handle.rst). https://github.com/llvm/llvm-project/pull/

[clang] [clang][TableGen] Change Builtins emitter to use const RecordKeeper (PR #108195)

2024-09-11 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/108195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TableGen] Change Builtins emitter to use const RecordKeeper (PR #108195)

2024-09-11 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul edited https://github.com/llvm/llvm-project/pull/108195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 970e2c1 - [clang][TableGen] Change Builtins emitter to use const RecordKeeper (#108195)

2024-09-11 Thread via cfe-commits
Author: Rahul Joshi Date: 2024-09-11T08:59:03-07:00 New Revision: 970e2c1fe7e1fffb5de6aeaa18d84db406ba4c29 URL: https://github.com/llvm/llvm-project/commit/970e2c1fe7e1fffb5de6aeaa18d84db406ba4c29 DIFF: https://github.com/llvm/llvm-project/commit/970e2c1fe7e1fffb5de6aeaa18d84db406ba4c29.diff L

[clang] [clang][TableGen] Change Builtins emitter to use const RecordKeeper (PR #108195)

2024-09-11 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/108195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][TableGen] Change OpenCL emitter to use const RecordKeeper (PR #108213)

2024-09-11 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh approved this pull request. https://github.com/llvm/llvm-project/pull/108213 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPIRV][RFC] Rework / extend support for memory scopes (PR #106429)

2024-09-11 Thread Dmitry Sidorov via cfe-commits
@@ -251,6 +251,24 @@ SPIRV::MemorySemantics::MemorySemantics getMemSemantics(AtomicOrdering Ord) { llvm_unreachable(nullptr); } +SPIRV::Scope::Scope getMemScope(const LLVMContext &Ctx, SyncScope::ID ID) { + SmallVector SSNs; + Ctx.getSyncScopeNames(SSNs); + + StringRef M

[clang] [llvm] [SPIRV][RFC] Rework / extend support for memory scopes (PR #106429)

2024-09-11 Thread Dmitry Sidorov via cfe-commits
https://github.com/MrSidims edited https://github.com/llvm/llvm-project/pull/106429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPIRV][RFC] Rework / extend support for memory scopes (PR #106429)

2024-09-11 Thread Dmitry Sidorov via cfe-commits
@@ -58,7 +58,35 @@ class SPIRVTargetCodeGenInfo : public CommonSPIRTargetCodeGenInfo { SPIRVTargetCodeGenInfo(CodeGen::CodeGenTypes &CGT) : CommonSPIRTargetCodeGenInfo(std::make_unique(CGT)) {} void setCUDAKernelCallingConvention(const FunctionType *&FT) const overri

[clang] [llvm] [SPIRV][RFC] Rework / extend support for memory scopes (PR #106429)

2024-09-11 Thread Dmitry Sidorov via cfe-commits
https://github.com/MrSidims edited https://github.com/llvm/llvm-project/pull/106429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] remove type annotations that require python3.9 in add_new_check.py (PR #107850)

2024-09-11 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/107850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SPIRV][RFC] Rework / extend support for memory scopes (PR #106429)

2024-09-11 Thread Dmitry Sidorov via cfe-commits
https://github.com/MrSidims edited https://github.com/llvm/llvm-project/pull/106429 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][Triple] Add `Environment` members and parsing for glibc/musl parity. (PR #107664)

2024-09-11 Thread Alex Rønne Petersen via cfe-commits
alexrp wrote: cc @wzssyqa @yingopq for the MIPS bits. https://github.com/llvm/llvm-project/pull/107664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy][NFC] fix add_new_check python3.8 incompatibility (PR #107871)

2024-09-11 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti approved this pull request. https://github.com/llvm/llvm-project/pull/107871 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libcxx] [lldb] [llvm] Rename Sanitizer Coverage => Coverage Sanitizer (PR #106505)

2024-09-11 Thread via cfe-commits
cor3ntin wrote: ping! https://github.com/llvm/llvm-project/pull/106505 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CGData] Clang Options (PR #90304)

2024-09-11 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com edited https://github.com/llvm/llvm-project/pull/90304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CGData] Clang Options (PR #90304)

2024-09-11 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com ready_for_review https://github.com/llvm/llvm-project/pull/90304 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CGData] Clang Options (PR #90304)

2024-09-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Kyungwoo Lee (kyulee-com) Changes This adds new Clang flags to support codegen (CG) data: - `-fcodegen-data-generate{=path}`: This flag passes `-codegen-data-generate` as a boolean to the LLVM backend, causing the raw CG data to be

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-09-11 Thread Sebastian Kreutzer via cfe-commits
https://github.com/sebastiankreutzer updated https://github.com/llvm/llvm-project/pull/90959 >From 86e252cb84803bfaa2ec096b671ef366fd3ac5cb Mon Sep 17 00:00:00 2001 From: Sebastian Kreutzer Date: Thu, 26 Oct 2023 15:13:05 +0200 Subject: [PATCH] [XRay] Add DSO support for XRay instrumentation on

[clang] [clang] Do not substitute parameter pack while retaining the pack expansion (PR #108197)

2024-09-11 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/108197 >From 5901d82ea0543074853b963f7dc9106a6fe3bcee Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Wed, 11 Sep 2024 11:33:45 + Subject: [PATCH 1/4] [clang] Do not expand pack while retaining expansion --- cl

[clang] [clang] Do not substitute parameter pack while retaining the pack expansion (PR #108197)

2024-09-11 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: Thanks. I have moved this to `ForgetPartiallySubstitutedPackRAII`. https://github.com/llvm/llvm-project/pull/108197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Emit error for duplicate mangled names within a lambda (PR #107581)

2024-09-11 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: Sure, it makes sense to print a diagnostic for lambdas. - I'm having a bit of trouble understanding the way the new code is structured. What makes the definition of lambda call operators special here? Do we not call GetOrCreateLLVMFunction with IsForDefinition set?

[clang] [clang] Do not substitute parameter pack while retaining the pack expansion (PR #108197)

2024-09-11 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/108197 >From 5901d82ea0543074853b963f7dc9106a6fe3bcee Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Wed, 11 Sep 2024 11:33:45 + Subject: [PATCH 1/5] [clang] Do not expand pack while retaining expansion --- cl

[clang] [alpha.webkit.UncountedCallArgsChecker] Allow protector functions in Objective-C++ (PR #108184)

2024-09-11 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/108184 >From c8cd18baa5b285262905ad0d8c49ba102993ef1e Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Wed, 11 Sep 2024 03:14:31 -0700 Subject: [PATCH 1/2] [alpha.webkit.UncountedCallArgsChecker] Allow protector functi

[clang] [clangl[TableGen] Change Diagnostic Emitter to use const RecordKeeper (PR #108209)

2024-09-11 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM thank you for the explanation! https://github.com/llvm/llvm-project/pull/108209 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe

[clang] [clang] Do not substitute parameter pack while retaining the pack expansion (PR #108197)

2024-09-11 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/108197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebAssembly] Change F16x8 extract lane to require constant integer. (PR #108116)

2024-09-11 Thread Brendan Dahl via cfe-commits
@@ -1888,18 +1888,15 @@ static __inline__ v128_t __FP16_FN_ATTRS wasm_f16x8_splat(float __a) { return (v128_t)__builtin_wasm_splat_f16x8(__a); } -static __inline__ float __FP16_FN_ATTRS wasm_f16x8_extract_lane(v128_t __a, -

[clang] fa4a631 - [NFC] [HLSL] Update test for HLSL 202x (#108097)

2024-09-11 Thread via cfe-commits
Author: Chris B Date: 2024-09-11T11:49:44-05:00 New Revision: fa4a631fc63bdd9ffe5598bcc744656cea6fdb56 URL: https://github.com/llvm/llvm-project/commit/fa4a631fc63bdd9ffe5598bcc744656cea6fdb56 DIFF: https://github.com/llvm/llvm-project/commit/fa4a631fc63bdd9ffe5598bcc744656cea6fdb56.diff LOG:

[clang] [NFC] [HLSL] Update test for HLSL 202x (PR #108097)

2024-09-11 Thread Chris B via cfe-commits
https://github.com/llvm-beanz closed https://github.com/llvm/llvm-project/pull/108097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Create bugprone-incorrect-enable-shared-from-this check (PR #102299)

2024-09-11 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,105 @@ +//===--- IncorrectEnableSharedFromThisCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Create bugprone-incorrect-enable-shared-from-this check (PR #102299)

2024-09-11 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,105 @@ +//===--- IncorrectEnableSharedFromThisCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Create bugprone-incorrect-enable-shared-from-this check (PR #102299)

2024-09-11 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti commented: > Side note, for future knowledge, what do you mean by > > > it is technically not in the format of the RecursiveASTVisitor and may be > > confusing > > ? Is there a guide that can point out what format Visit... should have? My bad, it actually was named

[clang-tools-extra] [clang-tidy] Create bugprone-incorrect-enable-shared-from-this check (PR #102299)

2024-09-11 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,105 @@ +//===--- IncorrectEnableSharedFromThisCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Create bugprone-incorrect-enable-shared-from-this check (PR #102299)

2024-09-11 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,105 @@ +//===--- IncorrectEnableSharedFromThisCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Create bugprone-incorrect-enable-shared-from-this check (PR #102299)

2024-09-11 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,33 @@ +.. title:: clang-tidy - bugprone-incorrect-enable-shared-from-this + +bugprone-incorrect-enable-shared-from-this +== + +Checks if class/struct publicly inherits from +``std::enable_shared_from_this``, because otherwise whe

[clang-tools-extra] [clang-tidy] Create bugprone-incorrect-enable-shared-from-this check (PR #102299)

2024-09-11 Thread Julian Schmidt via cfe-commits
@@ -0,0 +1,105 @@ +//===--- IncorrectEnableSharedFromThisCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang-tools-extra] [clang-tidy] Create bugprone-incorrect-enable-shared-from-this check (PR #102299)

2024-09-11 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/102299 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 2f321fa - [NFC][clang-tidy] fix tests of deleted functions for missing-std-forward (#106861)

2024-09-11 Thread via cfe-commits
Author: Julian Schmidt Date: 2024-09-11T18:52:41+02:00 New Revision: 2f321fac722e6c7913825f003c194b923d027354 URL: https://github.com/llvm/llvm-project/commit/2f321fac722e6c7913825f003c194b923d027354 DIFF: https://github.com/llvm/llvm-project/commit/2f321fac722e6c7913825f003c194b923d027354.diff

[clang-tools-extra] [NFC][clang-tidy] fix tests of deleted functions for missing-std-forward (PR #106861)

2024-09-11 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti closed https://github.com/llvm/llvm-project/pull/106861 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebKit Static Analyzer] Treat WTFReportBacktrace as a trivial function. (PR #108167)

2024-09-11 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ approved this pull request. https://github.com/llvm/llvm-project/pull/108167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [alpha.webkit.UncountedCallArgsChecker] Allow protector functions in Objective-C++ (PR #108184)

2024-09-11 Thread Artem Dergachev via cfe-commits
@@ -143,6 +143,16 @@ bool isReturnValueRefCounted(const clang::FunctionDecl *F) { return false; } +std::optional isUncounted(const clang::QualType T) { haoNoQ wrote: `clang::` is redundant because you're in `using namespace clang`. https://github.com/llvm

[clang] [alpha.webkit.UncountedCallArgsChecker] Allow protector functions in Objective-C++ (PR #108184)

2024-09-11 Thread Artem Dergachev via cfe-commits
https://github.com/haoNoQ edited https://github.com/llvm/llvm-project/pull/108184 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [WebKit Static Analyzer] Treat WTFReportBacktrace as a trivial function. (PR #108167)

2024-09-11 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/108167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7721db4 - [WebKit Static Analyzer] Treat WTFReportBacktrace as a trivial function. (#108167)

2024-09-11 Thread via cfe-commits
Author: Ryosuke Niwa Date: 2024-09-11T10:08:30-07:00 New Revision: 7721db489630166a220cfc27051d6259588229e1 URL: https://github.com/llvm/llvm-project/commit/7721db489630166a220cfc27051d6259588229e1 DIFF: https://github.com/llvm/llvm-project/commit/7721db489630166a220cfc27051d6259588229e1.diff

[clang] [Clang] Add `__builtin_experimental_vectorcompress` (PR #102476)

2024-09-11 Thread Lawrence Benson via cfe-commits
lawben wrote: @philnik777 This PR is still waiting for #104904 and #105515 to be merged, so we have support for vaid x86, NEON, and SVE vectors. Once those PRs are in, this can probably be merged too. https://github.com/llvm/llvm-project/pull/102476

[clang] [WebAssembly] Change F16x8 extract lane to require constant integer. (PR #108116)

2024-09-11 Thread Derek Schuff via cfe-commits
https://github.com/dschuff approved this pull request. https://github.com/llvm/llvm-project/pull/108116 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [alpha.webkit.UncountedCallArgsChecker] Allow protector functions in Objective-C++ (PR #108184)

2024-09-11 Thread Ryosuke Niwa via cfe-commits
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/108184 >From c8cd18baa5b285262905ad0d8c49ba102993ef1e Mon Sep 17 00:00:00 2001 From: Ryosuke Niwa Date: Wed, 11 Sep 2024 03:14:31 -0700 Subject: [PATCH 1/3] [alpha.webkit.UncountedCallArgsChecker] Allow protector functi

[clang] [alpha.webkit.UncountedCallArgsChecker] Allow protector functions in Objective-C++ (PR #108184)

2024-09-11 Thread Ryosuke Niwa via cfe-commits
@@ -143,6 +143,16 @@ bool isReturnValueRefCounted(const clang::FunctionDecl *F) { return false; } +std::optional isUncounted(const clang::QualType T) { rniwa wrote: Fixed! https://github.com/llvm/llvm-project/pull/108184 __

[clang] [llvm] [HLSL] Implement elementwise popcount (PR #108121)

2024-09-11 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,10 @@ +; RUN: not opt -S -dxil-op-lower -mtriple=dxil-pc-shadermodel6.3-library %s 2>&1 | FileCheck %s + +; DXIL operation ctpop does not support double overload type +; CHECK: invalid intrinsic signature + +define noundef double @countbits_double(double noundef %a) {

[clang] [llvm] [HLSL] Implement elementwise popcount (PR #108121)

2024-09-11 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,31 @@ +; RUN: opt -S -dxil-op-lower -mtriple=dxil-pc-shadermodel6.3-library %s | FileCheck %s + +; Make sure dxil operation function calls for countbits are generated for all integer types. + +; Function Attrs: nounwind +define noundef i16 @test_countbits_short(i16 no

[clang] [llvm] [HLSL] Implement elementwise popcount (PR #108121)

2024-09-11 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,31 @@ +; RUN: opt -S -dxil-op-lower -mtriple=dxil-pc-shadermodel6.3-library %s | FileCheck %s + +; Make sure dxil operation function calls for countbits are generated for all integer types. + +; Function Attrs: nounwind +define noundef i16 @test_countbits_short(i16 no

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-09-11 Thread Sebastian Kreutzer via cfe-commits
sebastiankreutzer wrote: I rebased on upstream `main` again and tested locally. @MaskRay Let me know if you have further comments or concerns. https://github.com/llvm/llvm-project/pull/90959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] 943182e - [clang][TableGen] Change comment command emitter to const RecordKeeper (#108199)

2024-09-11 Thread via cfe-commits
Author: Rahul Joshi Date: 2024-09-11T10:49:33-07:00 New Revision: 943182e3112756de8982babad6b5c8e74fdf8d02 URL: https://github.com/llvm/llvm-project/commit/943182e3112756de8982babad6b5c8e74fdf8d02 DIFF: https://github.com/llvm/llvm-project/commit/943182e3112756de8982babad6b5c8e74fdf8d02.diff L

[clang] [clang][TableGen] Change comment command emitter to const RecordKeeper (PR #108199)

2024-09-11 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/108199 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] dca9f21 - [clang][TableGen] Change HTML Emitter to use const RecordKeeper (#108201)

2024-09-11 Thread via cfe-commits
Author: Rahul Joshi Date: 2024-09-11T10:50:00-07:00 New Revision: dca9f21724c2206973b78ddc3ab3327b85f1e3ec URL: https://github.com/llvm/llvm-project/commit/dca9f21724c2206973b78ddc3ab3327b85f1e3ec DIFF: https://github.com/llvm/llvm-project/commit/dca9f21724c2206973b78ddc3ab3327b85f1e3ec.diff L

[clang] [clang][TableGen] Change HTML Emitter to use const RecordKeeper (PR #108201)

2024-09-11 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/108201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e382b0c - [clang][TableGen] Change HTML Tags emitter to use const RecordKeeper (#108202)

2024-09-11 Thread via cfe-commits
Author: Rahul Joshi Date: 2024-09-11T10:50:26-07:00 New Revision: e382b0c9972b4a3cf6c4bc21be50e12b76a488bd URL: https://github.com/llvm/llvm-project/commit/e382b0c9972b4a3cf6c4bc21be50e12b76a488bd DIFF: https://github.com/llvm/llvm-project/commit/e382b0c9972b4a3cf6c4bc21be50e12b76a488bd.diff L

[clang] [clang][TableGen] Change HTML Tags emitter to use const RecordKeeper (PR #108202)

2024-09-11 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/108202 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 07dc9b8 - [clang][TableGen] Change DataCollector to use const RecordKeeper (#108203)

2024-09-11 Thread via cfe-commits
Author: Rahul Joshi Date: 2024-09-11T10:50:57-07:00 New Revision: 07dc9b838efc32647aeafbf7325e3d710412a0bf URL: https://github.com/llvm/llvm-project/commit/07dc9b838efc32647aeafbf7325e3d710412a0bf DIFF: https://github.com/llvm/llvm-project/commit/07dc9b838efc32647aeafbf7325e3d710412a0bf.diff L

[clang] [clang][TableGen] Change DataCollector to use const RecordKeeper (PR #108203)

2024-09-11 Thread Rahul Joshi via cfe-commits
https://github.com/jurahul closed https://github.com/llvm/llvm-project/pull/108203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   6   >