[clang] [Clang] Fix handling of placeholder variables name in init captures (PR #107055)

2024-09-03 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. https://github.com/llvm/llvm-project/pull/107055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix handling of placeholder variables name in init captures (PR #107055)

2024-09-03 Thread Younan Zhang via cfe-commits
@@ -1323,7 +1323,6 @@ void Sema::ActOnLambdaExpressionAfterIntroducer(LambdaIntroducer &Intro, if (C->Init.isUsable()) { addInitCapture(LSI, cast(Var), C->Kind == LCK_ByRef); - PushOnScopeChains(Var, CurScope, false); zyn0217 wrote: Yeah, 2 is

[clang] [clang-format] Handle spaces in file paths in git-clang-format.bat (PR #107041)

2024-09-03 Thread Julian Liebig via cfe-commits
https://github.com/jeliebig approved this pull request. Thank you! https://github.com/llvm/llvm-project/pull/107041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] [MallocChecker] suspect all release functions as candidate for suppression (PR #104599)

2024-09-03 Thread Pavel Skripkin via cfe-commits
@@ -3648,35 +3655,54 @@ PathDiagnosticPieceRef MallocBugVisitor::VisitNode(const ExplodedNode *N, return nullptr; } - // See if we're releasing memory while inlining a destructor - // (or one of its callees). This turns on various common - //

[clang] [analyzer] [MallocChecker] suspect all release functions as candidate for suppression (PR #104599)

2024-09-03 Thread Pavel Skripkin via cfe-commits
https://github.com/pskrgag updated https://github.com/llvm/llvm-project/pull/104599 >From 913036ab795d6b91d6bb74d82aa2d329fe689535 Mon Sep 17 00:00:00 2001 From: Pavel Skripkin Date: Fri, 16 Aug 2024 17:45:57 +0300 Subject: [PATCH 1/6] clang/csa: suspect all functions as those that may do refc

[clang] [Clang][CodeGen] Fix type for atomic float incdec operators (PR #107075)

2024-09-03 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw created https://github.com/llvm/llvm-project/pull/107075 `llvm::ConstantFP::get(llvm::LLVMContext&, APFloat(float))` always returns a f32 constant. Fix https://github.com/llvm/llvm-project/issues/107054. >From eb403d3195cda22ca53411b2a12f259ad557f820 Mon Sep 17 00:0

[clang] [Clang][CodeGen] Fix type for atomic float incdec operators (PR #107075)

2024-09-03 Thread Yingwei Zheng via cfe-commits
dtcxzyw wrote: cc @Krishna-13-cyber https://github.com/llvm/llvm-project/pull/107075 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][CodeGen] Fix type for atomic float incdec operators (PR #107075)

2024-09-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-backend-x86 Author: Yingwei Zheng (dtcxzyw) Changes `llvm::ConstantFP::get(llvm::LLVMContext&, APFloat(float))` always returns a f32 constant. Fix https://github.com/llvm/llvm-project/issues/107054. --- Patch is 46.

[clang] [Clang] Fix handling of placeholder variables name in init captures (PR #107055)

2024-09-03 Thread via cfe-commits
cor3ntin wrote: The second was clearly duplicated. The first one introduce a scope for the captures, so that captures are available in the declaration of the lambda (before its compound statement). But the body introduces a new scope wherein we inject the parameters - and we also need to reinj

[clang] [analyzer] Model overflow builtins (PR #102602)

2024-09-03 Thread Donát Nagy via cfe-commits
@@ -50,6 +118,75 @@ class BuiltinFunctionChecker : public Checker { } // namespace +std::pair +BuiltinFunctionChecker::checkOverflow(CheckerContext &C, SVal RetVal, + QualType Res) const { + ProgramStateRef State = C.getState(); + SValBu

[clang] [Clang] Treat default template argument as constant expressions (PR #107073)

2024-09-03 Thread Younan Zhang via cfe-commits
@@ -960,6 +960,8 @@ Parser::ParseNonTypeTemplateParameter(unsigned Depth, unsigned Position) { EnterExpressionEvaluationContext ConstantEvaluated( Actions, Sema::ExpressionEvaluationContext::ConstantEvaluated); DefaultArg = Actions.CorrectDelayedTyposInEx

[clang] [clang][bytecode] Pass FPOptions to floating point ops (PR #107063)

2024-09-03 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/107063 >From f8b31c957fc281bf4c73f3b032099e2de4f58193 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 3 Sep 2024 10:59:22 +0200 Subject: [PATCH] [clang][bytecode] Pass FPOptions to floating poi

[clang] [Clang] Treat default template argument as constant expressions (PR #107073)

2024-09-03 Thread via cfe-commits
@@ -960,6 +960,8 @@ Parser::ParseNonTypeTemplateParameter(unsigned Depth, unsigned Position) { EnterExpressionEvaluationContext ConstantEvaluated( Actions, Sema::ExpressionEvaluationContext::ConstantEvaluated); DefaultArg = Actions.CorrectDelayedTyposInEx

[clang] [flang] [flang][Driver] support -fno-openmp (PR #107087)

2024-09-03 Thread Tom Eccles via cfe-commits
https://github.com/tblah created https://github.com/llvm/llvm-project/pull/107087 Closes #83148 >From 10a0bc5c82ef820593528c034c26cd1f5c90d6e5 Mon Sep 17 00:00:00 2001 From: Tom Eccles Date: Tue, 3 Sep 2024 11:11:47 + Subject: [PATCH] [flang][Driver] support -fno-openmp Closes #83148 ---

[clang] [flang] [flang][Driver] support -fno-openmp (PR #107087)

2024-09-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-flang-driver Author: Tom Eccles (tblah) Changes Closes #83148 --- Full diff: https://github.com/llvm/llvm-project/pull/107087.diff 4 Files Affected: - (modified) clang/include/clang/Driver/Options.td (+1) - (modified) flang/lib/Frontend/CompilerInvo

[clang] [flang] [flang][Driver] support -fno-openmp (PR #107087)

2024-09-03 Thread Paul Osmialowski via cfe-commits
https://github.com/pawosm-arm commented: As I'm not seeing how linker is invoked, I just need to ask (for the sake of completeness) will it also prevent addition of `-lomp` to the linker's command line? https://github.com/llvm/llvm-project/pull/107087 __

[clang] [flang] [flang][Driver] support -fno-openmp (PR #107087)

2024-09-03 Thread Tom Eccles via cfe-commits
https://github.com/tblah updated https://github.com/llvm/llvm-project/pull/107087 >From 10a0bc5c82ef820593528c034c26cd1f5c90d6e5 Mon Sep 17 00:00:00 2001 From: Tom Eccles Date: Tue, 3 Sep 2024 11:11:47 + Subject: [PATCH 1/2] [flang][Driver] support -fno-openmp Closes #83148 --- clang/incl

[clang] [flang] [flang][Driver] support -fno-openmp (PR #107087)

2024-09-03 Thread Tom Eccles via cfe-commits
tblah wrote: > As I'm not seeing how linker is invoked, I just need to ask (for the sake of > completeness) will it also prevent addition of `-lomp` to the linker's > command line? Thanks for pointing this out. I've added a test for the linker invocation. https://github.com/llvm/llvm-project/

[clang] [clang-format] Handle spaces in file paths in git-clang-format.bat (PR #107041)

2024-09-03 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/107041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a regression in annotating ObjCBlockLParen (PR #107021)

2024-09-03 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/107021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Treat default template argument as constant expressions (PR #107073)

2024-09-03 Thread Younan Zhang via cfe-commits
@@ -960,6 +960,8 @@ Parser::ParseNonTypeTemplateParameter(unsigned Depth, unsigned Position) { EnterExpressionEvaluationContext ConstantEvaluated( Actions, Sema::ExpressionEvaluationContext::ConstantEvaluated); DefaultArg = Actions.CorrectDelayedTyposInEx

[clang] [clang-format] Add new option: WrapNamespaceBodyWithNewlines (PR #106145)

2024-09-03 Thread via cfe-commits
https://github.com/mydeveloperday requested changes to this pull request. https://github.com/llvm/llvm-project/pull/106145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add new option: WrapNamespaceBodyWithNewlines (PR #106145)

2024-09-03 Thread via cfe-commits
@@ -32,6 +32,26 @@ bool isRecordLBrace(const FormatToken &Tok) { TT_StructLBrace, TT_UnionLBrace); } +bool LineStartsNamespaceScope(const AnnotatedLine *Line, + const AnnotatedLine *PreviousLine, +

[clang] [clang-format] Add new option: WrapNamespaceBodyWithNewlines (PR #106145)

2024-09-03 Thread via cfe-commits
@@ -829,6 +829,18 @@ template <> struct ScalarEnumerationTraits { } }; +template <> mydeveloperday wrote: should there be some config parse tests https://github.com/llvm/llvm-project/pull/106145 ___ cfe-commits

[clang] [clang-format] Add new option: WrapNamespaceBodyWithNewlines (PR #106145)

2024-09-03 Thread via cfe-commits
@@ -28104,6 +28104,251 @@ TEST_F(FormatTest, BreakBinaryOperations) { Style); } +TEST_F(FormatTest, WrapNamespaceBodyWithEmptyLinesNever) { + FormatStyle Style = getLLVMStyle(); + Style.FixNamespaceComments = false; + Style.ShortNamespaceLines = 0; + Style.M

[clang] [clang-format] Add new option: WrapNamespaceBodyWithNewlines (PR #106145)

2024-09-03 Thread via cfe-commits
@@ -6652,6 +6652,48 @@ the configuration (without a prefix: ``Auto``). For example: BOOST_PP_STRINGIZE +.. _WrapNamespaceBodyWithEmptyLines: + +**WrapNamespaceBodyWithEmptyLines** (``WrapNamespaceBodyWithEmptyLinesStyle``) :versionbadge:`clang-format 19` :ref:`¶ `

[clang] [clang-format] Add new option: WrapNamespaceBodyWithNewlines (PR #106145)

2024-09-03 Thread via cfe-commits
@@ -5057,6 +5057,43 @@ struct FormatStyle { /// \version 11 std::vector WhitespaceSensitiveMacros; + /// Different styles for modify number of empty lines in + /// the beginning and at the of end of namespaces. + enum WrapNamespaceBodyWithEmptyLinesStyle : int8_t { +

[clang] [Clang] Treat default template argument as constant expressions (PR #107073)

2024-09-03 Thread via cfe-commits
@@ -960,6 +960,8 @@ Parser::ParseNonTypeTemplateParameter(unsigned Depth, unsigned Position) { EnterExpressionEvaluationContext ConstantEvaluated( Actions, Sema::ExpressionEvaluationContext::ConstantEvaluated); DefaultArg = Actions.CorrectDelayedTyposInEx

[clang] [clang-format] Add new option: WrapNamespaceBodyWithNewlines (PR #106145)

2024-09-03 Thread via cfe-commits
https://github.com/mydeveloperday requested changes to this pull request. https://github.com/llvm/llvm-project/pull/106145 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add new option: WrapNamespaceBodyWithNewlines (PR #106145)

2024-09-03 Thread via cfe-commits
@@ -32,6 +32,26 @@ bool isRecordLBrace(const FormatToken &Tok) { TT_StructLBrace, TT_UnionLBrace); } +bool LineStartsNamespaceScope(const AnnotatedLine *Line, + const AnnotatedLine *PreviousLine, +

[clang] [clang-format] Handle pointer/reference in macro definitions (PR #107074)

2024-09-03 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/107074 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Treat default template argument as constant expressions (PR #107073)

2024-09-03 Thread Younan Zhang via cfe-commits
@@ -960,6 +960,8 @@ Parser::ParseNonTypeTemplateParameter(unsigned Depth, unsigned Position) { EnterExpressionEvaluationContext ConstantEvaluated( Actions, Sema::ExpressionEvaluationContext::ConstantEvaluated); DefaultArg = Actions.CorrectDelayedTyposInEx

[clang] [Clang] Treat default template argument as constant expressions (PR #107073)

2024-09-03 Thread via cfe-commits
@@ -960,6 +960,8 @@ Parser::ParseNonTypeTemplateParameter(unsigned Depth, unsigned Position) { EnterExpressionEvaluationContext ConstantEvaluated( Actions, Sema::ExpressionEvaluationContext::ConstantEvaluated); DefaultArg = Actions.CorrectDelayedTyposInEx

[clang] [flang] [flang][Driver] support -fno-openmp (PR #107087)

2024-09-03 Thread Paul Osmialowski via cfe-commits
https://github.com/pawosm-arm approved this pull request. https://github.com/llvm/llvm-project/pull/107087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Start moving X86Builtins.def to X86Builtins.td (PR #106005)

2024-09-03 Thread Simon Pilgrim via cfe-commits
RKSimon wrote: @philnik777 Is this part of a larger scheme covering other targets? https://github.com/llvm/llvm-project/pull/106005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Treat default template argument as constant expressions (PR #107073)

2024-09-03 Thread via cfe-commits
@@ -960,6 +960,8 @@ Parser::ParseNonTypeTemplateParameter(unsigned Depth, unsigned Position) { EnterExpressionEvaluationContext ConstantEvaluated( Actions, Sema::ExpressionEvaluationContext::ConstantEvaluated); DefaultArg = Actions.CorrectDelayedTyposInEx

[clang] [X86] Enable constexpr on LZCNT & BMI intrinsics (PR #94161)

2024-09-03 Thread Simon Pilgrim via cfe-commits
RKSimon wrote: @aniplcc reverse ping https://github.com/llvm/llvm-project/pull/94161 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Fix handling of placeholder variables name in init captures (PR #107055)

2024-09-03 Thread via cfe-commits
cor3ntin wrote: Should we backport this? https://github.com/llvm/llvm-project/pull/107055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Treat default template argument as constant expressions (PR #107073)

2024-09-03 Thread Younan Zhang via cfe-commits
@@ -960,6 +960,8 @@ Parser::ParseNonTypeTemplateParameter(unsigned Depth, unsigned Position) { EnterExpressionEvaluationContext ConstantEvaluated( Actions, Sema::ExpressionEvaluationContext::ConstantEvaluated); DefaultArg = Actions.CorrectDelayedTyposInEx

[clang] [analyzer] Fix false positive for stack-addr leak on simple param ptr (PR #107003)

2024-09-03 Thread Balazs Benics via cfe-commits
@@ -791,3 +791,58 @@ void global_ptr_to_ptr() { *global_pp = nullptr; } } // namespace leaking_via_indirect_global_invalidated + +namespace not_leaking_via_simple_ptr { +void simple_ptr(const char *p) { + char tmp; + p = &tmp; // no-warning +} + +void ref_ptr(const char *&p

[clang] [Clang] Treat default template argument as constant expressions (PR #107073)

2024-09-03 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. https://github.com/llvm/llvm-project/pull/107073 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] aa4f81e - [analyzer] Fix false positive for stack-addr leak on simple param ptr (#107003)

2024-09-03 Thread via cfe-commits
Author: Arseniy Zaostrovnykh Date: 2024-09-03T14:06:57+02:00 New Revision: aa4f81efb99c93da3283ff3178be8db51cd655e2 URL: https://github.com/llvm/llvm-project/commit/aa4f81efb99c93da3283ff3178be8db51cd655e2 DIFF: https://github.com/llvm/llvm-project/commit/aa4f81efb99c93da3283ff3178be8db51cd655e

[clang] [analyzer] Fix false positive for stack-addr leak on simple param ptr (PR #107003)

2024-09-03 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/107003 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][bytecode] Implement placement-new (PR #107033)

2024-09-03 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/107033 >From 4f6db8a9c37c2fd5df32e3611c3630b5d7581a30 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 3 Sep 2024 02:52:35 +0200 Subject: [PATCH] [clang][bytecode] Implement placement-new ---

[clang] [Clang] Fix handling of placeholder variables name in init captures (PR #107055)

2024-09-03 Thread Younan Zhang via cfe-commits
zyn0217 wrote: I think so, yes. https://github.com/llvm/llvm-project/pull/107055 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Start moving X86Builtins.def to X86Builtins.td (PR #106005)

2024-09-03 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: > @philnik777 Is this part of a larger scheme covering other targets? Ultimately all the builtins should be in TableGen files instead of the `.def` files, but that's going to take a while. Probably years, since it's not exactly high priority. https://github.com/llvm/llvm-pro

[clang] [clang][bytecode] Implement placement-new (PR #107033)

2024-09-03 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr updated https://github.com/llvm/llvm-project/pull/107033 >From 5286c57c1664bf64dae570c13de6956dbb762ab1 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 3 Sep 2024 02:52:35 +0200 Subject: [PATCH] [clang][bytecode] Implement placement-new ---

[clang] 0f5f440 - [clang][bytecode] Pass FPOptions to floating point ops (#107063)

2024-09-03 Thread via cfe-commits
Author: Timm Baeder Date: 2024-09-03T14:24:11+02:00 New Revision: 0f5f440f24bc2af4e8ab481a99e03de438b12987 URL: https://github.com/llvm/llvm-project/commit/0f5f440f24bc2af4e8ab481a99e03de438b12987 DIFF: https://github.com/llvm/llvm-project/commit/0f5f440f24bc2af4e8ab481a99e03de438b12987.diff L

[clang] [clang][bytecode] Pass FPOptions to floating point ops (PR #107063)

2024-09-03 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/107063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Treat default template argument as constant expressions (PR #107073)

2024-09-03 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/107073 >From 5edd9a9abe019af2a14ccf9fbf43858f4141071b Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Tue, 3 Sep 2024 11:25:27 +0200 Subject: [PATCH 1/2] [Clang] Treat default template argument as constant expres

[clang] [clang] [docs] Clarify the issue with compiler-rt on Windows/MSVC (PR #106875)

2024-09-03 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. Added @vitalybuka for awareness, but given that the other PR was accepted and landed, I think this one makes sense to land as well. LGTM, thank you! https://github.com/llvm/llvm-project/pull/106875 _

[clang] [llvm] [RISCV][VCIX] Add vcix_state to GNU inline assembly register set (PR #106914)

2024-09-03 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat updated https://github.com/llvm/llvm-project/pull/106914 >From 32126871d3dae79edaaa03bd1760790ca8a42e84 Mon Sep 17 00:00:00 2001 From: Brandon Wu Date: Sun, 1 Sep 2024 09:35:34 -0700 Subject: [PATCH 1/2] [RISCV][VCIX] Precommit test --- llvm/test/CodeGen/RISCV/inlin

[clang] [Clang][Sema] Refactor collection of multi-level template argument lists (PR #106585)

2024-09-03 Thread Krystian Stasiowski via cfe-commits
@@ -33,11 +33,12 @@ class D{}; // expected-note{{previous definition is here}} template class D{}; // expected-error{{class template partial specialization does not specialize any template argument; to define the primary template, remove the template argument list}} expected-e

[clang-tools-extra] Update clang tidy Contributing guide (PR #106672)

2024-09-03 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > If anyone reads this and tests it out, please tell the results. I'll open a > new PR to add the Windows exception if it doesn't work. (Or if there's a > better workflow that LLVM uses, do tell.) Correct, it doesn't work out of the box on Windows. https://github.com/llvm/

[clang-tools-extra] Update clang tidy Contributing guide (PR #106672)

2024-09-03 Thread via cfe-commits
MichelleCDjunaidi wrote: I see; thanks for notifying me! Does anyone know of the workaround on Windows, or should I try to find it after I have access to my laptop? https://github.com/llvm/llvm-project/pull/106672 ___ cfe-commits mailing list cfe-comm

[clang-tools-extra] Update clang tidy Contributing guide (PR #106672)

2024-09-03 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: There is no workaround on Windows currently; the issue is that tab autocompletion is handled via https://github.com/llvm/llvm-project/blob/0797c184c636889f2897746dc71390ae28005c7c/llvm/lib/LineEditor/LineEditor.cpp#L212 and that's not available on Windows; we don't have any

[clang] [flang] [flang][Driver] support -fno-openmp (PR #107087)

2024-09-03 Thread Tom Eccles via cfe-commits
https://github.com/tblah updated https://github.com/llvm/llvm-project/pull/107087 >From 10a0bc5c82ef820593528c034c26cd1f5c90d6e5 Mon Sep 17 00:00:00 2001 From: Tom Eccles Date: Tue, 3 Sep 2024 11:11:47 + Subject: [PATCH 1/3] [flang][Driver] support -fno-openmp Closes #83148 --- clang/incl

[clang] [clang][bytecode][NFC] Move Call ops into Interp.cpp (PR #107104)

2024-09-03 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/107104 They are quite long and not templated. >From f395bdadb094477b757a2c0789f902d56eb14df0 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 3 Sep 2024 15:11:57 +0200 Subject: [PATCH] [clang][

[clang] [clang][bytecode][NFC] Move Call ops into Interp.cpp (PR #107104)

2024-09-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes They are quite long and not templated. --- Full diff: https://github.com/llvm/llvm-project/pull/107104.diff 2 Files Affected: - (modified) clang/lib/AST/ByteCode/Interp.cpp (+235) - (modified) clang/lib/A

[clang] [clang] Fixing Clang HIP inconsistent order for template functions (PR #101627)

2024-09-03 Thread via cfe-commits
https://github.com/Ritanya-B-Bharadwaj closed https://github.com/llvm/llvm-project/pull/101627 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ValueLattice][SCCP] Do not track undefs (PR #107105)

2024-09-03 Thread Nikita Popov via cfe-commits
@@ -35,6 +35,7 @@ typedef unsigned long long uint64_t; // CHECK: while.cond.i: // CHECK-NEXT:[[__TAGP_ADDR_0_I:%.*]] = phi ptr [ [[P:%.*]], [[ENTRY:%.*]] ], [ [[__TAGP_ADDR_1_I:%.*]], [[CLEANUP_I:%.*]] ] // CHECK-NEXT:[[__R_0_I:%.*]] = phi i64 [ 0, [[ENTRY]] ], [

[clang] [llvm] [ValueLattice][SCCP] Do not track undefs (PR #107105)

2024-09-03 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 0797c184c636889f2897746dc71390ae28005c7c be08a5a9d2e9a56b3e9fa08b970aeec7ee3e2b0e --e

[clang] [clang][OpenMP] Simplify handling of implicit DSA/mapping information (PR #106786)

2024-09-03 Thread Alexey Bataev via cfe-commits
@@ -6060,69 +6057,55 @@ StmtResult SemaOpenMP::ActOnOpenMPExecutableDirective( return StmtError(); // Generate list of implicitly defined firstprivate variables. VarsWithInheritedDSA = DSAChecker.getVarsWithInheritedDSA(); +VariableImplicitInfo ImpInfo = DSACh

[clang] [llvm] [RISCV][VCIX] Add vcix_state to GNU inline assembly register set (PR #106914)

2024-09-03 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat edited https://github.com/llvm/llvm-project/pull/106914 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Update clang tidy Contributing guide (PR #106672)

2024-09-03 Thread via cfe-commits
MichelleCDjunaidi wrote: Hmm, in that case, would it be better to note the Windows exception in the documentation and open up an issue tracker for the tab issue instead, since the bug and fix (due to it affecting all tab-related operations on Windows) is out of scope for this documentation PR?

[clang] [Clang][Sema] Refactor collection of multi-level template argument lists (PR #106585)

2024-09-03 Thread Krystian Stasiowski via cfe-commits
@@ -2112,6 +2078,33 @@ DeclResult Sema::CheckClassTemplate( NewClass->setLexicalDeclContext(CurContext); NewTemplate->setLexicalDeclContext(CurContext); + // Ensure that the template parameter lists are compatible. Skip this check + // for a friend in a dependent context

[clang] [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (PR #104458)

2024-09-03 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @cor3ntin After giving it another look, I think the existing tests are sufficient (the tests updated by this PR were written by me to test this exact scenario). WDYT? https://github.com/llvm/llvm-project/pull/104458 ___ cfe-commits

[clang] [Clang][Sema] Refactor collection of multi-level template argument lists (PR #106585)

2024-09-03 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: Ping @mizvekov https://github.com/llvm/llvm-project/pull/106585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PS4,PS5][Driver] Check for absent SDK when -nostdlib/-nodefaultlibs (PR #107112)

2024-09-03 Thread Edd Dawson via cfe-commits
https://github.com/playstation-edd created https://github.com/llvm/llvm-project/pull/107112 The PlayStation drivers emit warnings if it looks like SDK libraries are missing. Until this point, the check was skipped when either -nostdlib or -nodefaultlibs was supplied. I believe the idea is that

[clang] [PS4,PS5][Driver] Check for absent SDK when -nostdlib/-nodefaultlibs (PR #107112)

2024-09-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Edd Dawson (playstation-edd) Changes The PlayStation drivers emit warnings if it looks like SDK libraries are missing. Until this point, the check was skipped when either -nostdlib or -nodefaultlibs was supplied. I believe the idea is tha

[clang] [flang] [llvm] [mlir] [ADT] Deprecate DenseMap::getOrInsertDefault (PR #107040)

2024-09-03 Thread Jakub Kuderski via cfe-commits
https://github.com/kuhar approved this pull request. https://github.com/llvm/llvm-project/pull/107040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [mlir] [ADT] Deprecate DenseMap::getOrInsertDefault (PR #107040)

2024-09-03 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. https://github.com/llvm/llvm-project/pull/107040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add tests for CWG issues about language linkage (PR #107019)

2024-09-03 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/107019 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Catch missing format attributes (PR #105479)

2024-09-03 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovichtec updated https://github.com/llvm/llvm-project/pull/105479 From a727077325a289e801ab8ebe4b4e6479e2cd0ec3 Mon Sep 17 00:00:00 2001 From: budimirarandjelovicsyrmia Date: Fri, 5 Apr 2024 15:20:37 +0200 Subject: [PATCH] [clang] Catch missing format attribute

[clang] f70ccda - [clang][bytecode][NFC] Move Call ops into Interp.cpp (#107104)

2024-09-03 Thread via cfe-commits
Author: Timm Baeder Date: 2024-09-03T16:15:58+02:00 New Revision: f70ccdaeb4ef9681ea490ea7779efbe72e643eda URL: https://github.com/llvm/llvm-project/commit/f70ccdaeb4ef9681ea490ea7779efbe72e643eda DIFF: https://github.com/llvm/llvm-project/commit/f70ccdaeb4ef9681ea490ea7779efbe72e643eda.diff L

[clang] [clang][bytecode][NFC] Move Call ops into Interp.cpp (PR #107104)

2024-09-03 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/107104 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 7852ebc - [BPF] Make -mcpu=v3 as the default (#107008)

2024-09-03 Thread via cfe-commits
Author: yonghong-song Date: 2024-09-03T07:15:18-07:00 New Revision: 7852ebc088b925ef1c1940cbd56a93d9f8e3e330 URL: https://github.com/llvm/llvm-project/commit/7852ebc088b925ef1c1940cbd56a93d9f8e3e330 DIFF: https://github.com/llvm/llvm-project/commit/7852ebc088b925ef1c1940cbd56a93d9f8e3e330.diff

[clang] [llvm] [BPF] Make -mcpu=v3 as the default (PR #107008)

2024-09-03 Thread via cfe-commits
https://github.com/yonghong-song closed https://github.com/llvm/llvm-project/pull/107008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] set alwaysinline on HLSL functions (PR #106588)

2024-09-03 Thread Greg Roth via cfe-commits
@@ -414,9 +414,20 @@ void CGHLSLRuntime::emitEntryFunction(const FunctionDecl *FD, void CGHLSLRuntime::setHLSLFunctionAttributes(const FunctionDecl *FD, llvm::Function *Fn) { - if (FD->isInExportDeclContext()) { -const String

[clang] [HLSL] set alwaysinline on HLSL functions (PR #106588)

2024-09-03 Thread Greg Roth via cfe-commits
@@ -290,8 +290,6 @@ struct BuiltinTypeDeclBuilder { SourceLocation())); MethodDecl->setLexicalDeclContext(Record); MethodDecl->setAccess(AccessSpecifier::AS_public); -MethodDecl->addAttr(AlwaysInlineAttr::CreateImplicit(

[clang] [llvm] [ValueLattice][SCCP] Do not track undefs (PR #107105)

2024-09-03 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw commented: Crash reproducer: ``` ; bin/opt -passes=sccp reduced.ll -S define void @debug_send_line1() { %1 = load ptr, ptr null, align 8 %2 = load ptr, ptr %1, align 8 call void %2() ret void } define void @debug_send_line2() { %1 = load ptr, ptr undef, alig

[clang] [Clang] Remove 3-element vector load and store special handling (PR #104661)

2024-09-03 Thread Shilei Tian via cfe-commits
@@ -45,7 +45,7 @@ void test3(packedfloat3 *p) { *p = (packedfloat3) { 3.2f, 2.3f, 0.1f }; } // CHECK: @test3( -// CHECK: store <4 x float> {{.*}}, align 4 +// CHECK: store <3 x float> {{.*}}, align 4 shiltian wrote: So what is the conclusion here? Do we want

[clang] [clang][bytecode][NFC] Simplify builtin-functions.cpp (PR #107118)

2024-09-03 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/107118 The effect is the same, but this version doesn't take as long to evaluate. >From b203f7fe81a98258690ebb8d6385a9384a1b7ba6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Tue, 3 Sep 2024 16:5

[clang] [clang][bytecode][NFC] Simplify builtin-functions.cpp (PR #107118)

2024-09-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes The effect is the same, but this version doesn't take as long to evaluate. --- Full diff: https://github.com/llvm/llvm-project/pull/107118.diff 1 Files Affected: - (modified) clang/test/AST/ByteCode/builti

[clang] [llvm] [AARCH64][SVE] Add intrinsics for SVE LUTI instructions (PR #97058)

2024-09-03 Thread via cfe-commits
https://github.com/Lukacma updated https://github.com/llvm/llvm-project/pull/97058 >From 4a6c4033f7deddcd4094ebde81402960de85bd80 Mon Sep 17 00:00:00 2001 From: Marian Lukac Date: Fri, 28 Jun 2024 10:13:16 + Subject: [PATCH 1/3] [AARCH64][SVE] Add intrinsics for SVE LUTI instructions ---

[clang] [clang][ExtractAPI] Remove erroneous module name check in MacroCallbacks (PR #107059)

2024-09-03 Thread via cfe-commits
https://github.com/QuietMisdreavus approved this pull request. https://github.com/llvm/llvm-project/pull/107059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PS4,PS5][Driver] Check for absent SDK when -nostdlib/-nodefaultlibs (PR #107112)

2024-09-03 Thread Jeremy Morse via cfe-commits
@@ -36,9 +35,6 @@ // RUN: env SCE_ORBIS_SDK_DIR=.. %clang -Winvalid-or-nonexistent-directory -### -emit-ast -isysroot foo -target x86_64-scei-ps4 %s 2>&1 | FileCheck -check-prefix=WARN-ISYSROOT -check-prefix=NO-WARN %s // RUN: env SCE_ORBIS_SDK_DIR=.. %clang -Winvalid-or-nonex

[clang] [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (PR #104458)

2024-09-03 Thread via cfe-commits
@@ -7939,7 +7927,14 @@ ExprResult Sema::ActOnStartCXXMemberReference(Scope *S, Expr *Base, } } return ExprError(); + } else if (Result.isUnset()) { +// BuildOverloadedArrowExpr returns an empty expression to indicate +// that we n

[clang] [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (PR #104458)

2024-09-03 Thread via cfe-commits
cor3ntin wrote: > @cor3ntin After giving it another look, I think the existing tests are > sufficient (the tests updated by this PR were written by me to test this > exact scenario). WDYT? I think the tests you have are fine https://github.com/llvm/llvm-project/pull/104458 ___

[clang] 59a3b41 - [ADT] Deprecate DenseMap::getOrInsertDefault (#107040)

2024-09-03 Thread via cfe-commits
Author: Kazu Hirata Date: 2024-09-03T08:19:45-07:00 New Revision: 59a3b4156836c3ea8589d7a39e7b4712fc8698ec URL: https://github.com/llvm/llvm-project/commit/59a3b4156836c3ea8589d7a39e7b4712fc8698ec DIFF: https://github.com/llvm/llvm-project/commit/59a3b4156836c3ea8589d7a39e7b4712fc8698ec.diff L

[clang] [flang] [llvm] [mlir] [ADT] Deprecate DenseMap::getOrInsertDefault (PR #107040)

2024-09-03 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/107040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 86835d2 - [clang][ExtractAPI] Remove erroneous module name check in MacroCallbacks (#107059)

2024-09-03 Thread via cfe-commits
Author: Daniel Grumberg Date: 2024-09-03T16:21:35+01:00 New Revision: 86835d2d5a24ed00ed3747b77029c896ba935036 URL: https://github.com/llvm/llvm-project/commit/86835d2d5a24ed00ed3747b77029c896ba935036 DIFF: https://github.com/llvm/llvm-project/commit/86835d2d5a24ed00ed3747b77029c896ba935036.dif

[clang] [clang][ExtractAPI] Remove erroneous module name check in MacroCallbacks (PR #107059)

2024-09-03 Thread Daniel Grumberg via cfe-commits
https://github.com/daniel-grumberg closed https://github.com/llvm/llvm-project/pull/107059 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (PR #104458)

2024-09-03 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @cor3ntin Excellent, then I think this is good to go https://github.com/llvm/llvm-project/pull/104458 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 93857af - [clang][Driver] Add missing include after 26bf0b4ae7df7f5350f71afd40a57cdf8f98c588.

2024-09-03 Thread via cfe-commits
Author: Christian Sigg Date: 2024-09-03T17:25:51+02:00 New Revision: 93857afc24abeeacdd58277b4ab32d38daa1e531 URL: https://github.com/llvm/llvm-project/commit/93857afc24abeeacdd58277b4ab32d38daa1e531 DIFF: https://github.com/llvm/llvm-project/commit/93857afc24abeeacdd58277b4ab32d38daa1e531.diff

[clang] [PS4,PS5][Driver] Check for absent SDK when -nostdlib/-nodefaultlibs (PR #107112)

2024-09-03 Thread Paul T Robinson via cfe-commits
@@ -36,9 +35,6 @@ // RUN: env SCE_ORBIS_SDK_DIR=.. %clang -Winvalid-or-nonexistent-directory -### -emit-ast -isysroot foo -target x86_64-scei-ps4 %s 2>&1 | FileCheck -check-prefix=WARN-ISYSROOT -check-prefix=NO-WARN %s // RUN: env SCE_ORBIS_SDK_DIR=.. %clang -Winvalid-or-nonex

[clang] [libclc] [llvm] [libclc] More cross compilation fixes (PR #97811)

2024-09-03 Thread Tom Stellard via cfe-commits
https://github.com/tstellar approved this pull request. https://github.com/llvm/llvm-project/pull/97811 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver] Support passing arbitrary args to -cc1as with -Xclangas. (PR #100714)

2024-09-03 Thread Alex Rønne Petersen via cfe-commits
https://github.com/alexrp edited https://github.com/llvm/llvm-project/pull/100714 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Driver] Define soft float macros for PPC. (PR #106012)

2024-09-03 Thread Alex Rønne Petersen via cfe-commits
alexrp wrote: Forgot to note in the PR description that I don't have commit access. https://github.com/llvm/llvm-project/pull/106012 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PS4,PS5][Driver] Check for absent SDK when -nostdlib/-nodefaultlibs (PR #107112)

2024-09-03 Thread Edd Dawson via cfe-commits
@@ -36,9 +35,6 @@ // RUN: env SCE_ORBIS_SDK_DIR=.. %clang -Winvalid-or-nonexistent-directory -### -emit-ast -isysroot foo -target x86_64-scei-ps4 %s 2>&1 | FileCheck -check-prefix=WARN-ISYSROOT -check-prefix=NO-WARN %s // RUN: env SCE_ORBIS_SDK_DIR=.. %clang -Winvalid-or-nonex

<    1   2   3   4   5   >