[clang] [clang-tools-extra] [clang-tidy] bugprone-implicit-widening ignores unsigned consts (PR #101073)

2024-08-29 Thread Chris Warner via cfe-commits
https://github.com/cwarner-8702 updated https://github.com/llvm/llvm-project/pull/101073 >From 24f52fbfb9117a6498769cebdc7b09ecbd7e019e Mon Sep 17 00:00:00 2001 From: Chris Warner Date: Wed, 17 Jul 2024 11:22:39 -0700 Subject: [PATCH 1/5] [clang-tidy] bugprone-implicit-widening ignores unsigned

[clang] Make PCH's respect any VFS specified. (PR #106577)

2024-08-29 Thread Neil Henning via cfe-commits
https://github.com/sheredom created https://github.com/llvm/llvm-project/pull/106577 We want to be able to generate a PCH against one file-system path, and then re-use that PCH when the file-system path is different (but the sources are the same). We also do not know when generating the PCH wh

[clang] Make PCH's respect any VFS specified. (PR #106577)

2024-08-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Neil Henning (sheredom) Changes We want to be able to generate a PCH against one file-system path, and then re-use that PCH when the file-system path is different (but the sources are the same). We also do not know when generating the PCH

[clang] Make PCH's respect any VFS specified. (PR #106577)

2024-08-29 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 175aa864f33786f3a6a4ee7381cbcafd0758501a e8e06cef736577eb098de57f8dfae201c945d2af --e

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-08-29 Thread via cfe-commits
https://github.com/higher-performance updated https://github.com/llvm/llvm-project/pull/102040 >From 9850a8b34b83090ba69c77f71f69bc700bd6306d Mon Sep 17 00:00:00 2001 From: higher-performance Date: Mon, 5 Aug 2024 15:04:19 -0400 Subject: [PATCH] Add Clang attribute to ensure that fields are ini

[clang-tools-extra] [clang-tidy] Add user-defined functions to `bugprone-unsafe-functions` check (PR #106350)

2024-08-29 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti edited https://github.com/llvm/llvm-project/pull/106350 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add user-defined functions to `bugprone-unsafe-functions` check (PR #106350)

2024-08-29 Thread Julian Schmidt via cfe-commits
@@ -86,6 +123,22 @@ Options this option enables. Default is `true`. +.. option:: ReportDefaultFunctions + +When `true`, the check reports the default set of functions. +Default is `true`. + +.. option:: CustomNormalFunctions + +A comma-separated list of regul

[clang-tools-extra] [clang-tidy] Add user-defined functions to `bugprone-unsafe-functions` check (PR #106350)

2024-08-29 Thread Julian Schmidt via cfe-commits
@@ -186,16 +298,62 @@ void UnsafeFunctionsCheck::check(const MatchFinder::MatchResult &Result) { const auto *FuncDecl = cast(DeclRef->getDecl()); assert(DeclRef && FuncDecl && "No valid matched node in check()"); + // Only one of these are matched at a time. const aut

[clang-tools-extra] [clang-tidy] Add user-defined functions to `bugprone-unsafe-functions` check (PR #106350)

2024-08-29 Thread Julian Schmidt via cfe-commits
@@ -127,57 +139,157 @@ static bool isAnnexKAvailable(std::optional &CacheVar, Preprocessor *PP, return CacheVar.value(); } +static std::vector +ParseCheckedFunctions(StringRef Option, StringRef OptionName, 5chmidti wrote: nit: Function names start with low

[clang-tools-extra] [clang-tidy] Add user-defined functions to `bugprone-unsafe-functions` check (PR #106350)

2024-08-29 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti commented: Just some small things https://github.com/llvm/llvm-project/pull/106350 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add user-defined functions to `bugprone-unsafe-functions` check (PR #106350)

2024-08-29 Thread Julian Schmidt via cfe-commits
@@ -186,16 +298,62 @@ void UnsafeFunctionsCheck::check(const MatchFinder::MatchResult &Result) { const auto *FuncDecl = cast(DeclRef->getDecl()); assert(DeclRef && FuncDecl && "No valid matched node in check()"); + // Only one of these are matched at a time. const aut

[clang-tools-extra] [clang-tidy] Add user-defined functions to `bugprone-unsafe-functions` check (PR #106350)

2024-08-29 Thread Julian Schmidt via cfe-commits
@@ -127,57 +139,157 @@ static bool isAnnexKAvailable(std::optional &CacheVar, Preprocessor *PP, return CacheVar.value(); } +static std::vector +ParseCheckedFunctions(StringRef Option, StringRef OptionName, + ClangTidyContext *Context) { + std::vector F

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-08-29 Thread via cfe-commits
higher-performance wrote: I updated the PR to change the attribute name from `explicit` to `explicit_init` and to clarify the error message that initializations must be explicit. @AaronBallman are we good to move forward? https://github.com/llvm/llvm-project/pull/102040 __

[clang] Add Clang attribute to ensure that fields are initialized explicitly (PR #102040)

2024-08-29 Thread via cfe-commits
https://github.com/higher-performance updated https://github.com/llvm/llvm-project/pull/102040 >From 471b41ac2c1f5c55576d2849db604a64edd3060d Mon Sep 17 00:00:00 2001 From: higher-performance Date: Mon, 5 Aug 2024 15:04:19 -0400 Subject: [PATCH] Add Clang attribute to ensure that fields are ini

[clang] [clang-tools-extra] [clang] Hide the `DiagnosticOptions` pointer from `CompilerInvocation` (PR #106274)

2024-08-29 Thread Jan Svoboda via cfe-commits
jansvoboda11 wrote: > yes turning diagnosticoptions to be a ThreadSafeRefCountedBase pointer should > ensure we have similar guarantees. so LG from clangd side Thanks for confirming! > I am not sure about implications on using thread-aware structs in core parts > of clang. so it might be wort

[clang] [NFC]Fix memory leak in HeaderSearchTest (PR #95927)

2024-08-29 Thread Danial Klimkin via cfe-commits
dklimkin wrote: Hi AaronBallman, I think I opted to have a minimal change, it was on heap and I kept it this way. Seems not important for a test only code. As per NFC, thank you for the note. I considered it NFC as the prod code behavior didn't change. I'll keep in mind any behavior change cou

[clang] [llvm] [AArch64] Implement intrinsics for SVE FAMIN/FAMAX (PR #99042)

2024-08-29 Thread Momchil Velikov via cfe-commits
https://github.com/momchil-velikov updated https://github.com/llvm/llvm-project/pull/99042 >From aa74d04751558f3ab47d566c91fb8ad178df0dce Mon Sep 17 00:00:00 2001 From: Momchil Velikov Date: Tue, 16 Jul 2024 13:37:34 +0100 Subject: [PATCH 1/3] [AArch64] Implement intrinsics for SVE FAMIN/FAMAX

[clang] [llvm] [AArch64] Implement intrinsics for SVE FAMIN/FAMAX (PR #99042)

2024-08-29 Thread Momchil Velikov via cfe-commits
@@ -717,6 +717,11 @@ let Predicates = [HasSVEorSME] in { defm FDIV_ZPZZ : sve_fp_bin_pred_hfd; } // End HasSVEorSME +let Predicates = [HasSVE2orSME2, HasFAMINMAX] in { + defm FAMAX_ZPZZ : sve_fp_bin_pred_hfd; + defm FAMIN_ZPZZ : sve_fp_bin_pred_hfd; +} +

[clang] [llvm] [AArch64] Implement intrinsics for SVE FAMIN/FAMAX (PR #99042)

2024-08-29 Thread Momchil Velikov via cfe-commits
@@ -0,0 +1,115 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 4 +; RUN: llc -mattr=+sve2 < %s | FileCheck %s +; RUN: llc -mattr=+sme2 -force-streaming < %s | FileCheck %s + +target triple = "aarch64-linux" + +define @famin_f

[clang] [llvm] Added instant events and marking defered templated instantiation. (PR #103039)

2024-08-29 Thread Ilya Biryukov via cfe-commits
@@ -104,6 +105,23 @@ struct llvm::TimeTraceProfilerEntry { } }; +struct InProgressEntry { + std::unique_ptr Event; ilya-biryukov wrote: Could we store it directly as `TimeTraceProfilerEntry` without unique_ptr? We are already creating `InProgressEntry` in

[clang] [llvm] Added instant events and marking defered templated instantiation. (PR #103039)

2024-08-29 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov commented: I have left quite a few comments, but they are mostly about the code style. I think this looks really good overall and almost ready to land. Could you split the change to Sema into a separate PR so that we have time profiler changes separately? https

[clang] [llvm] Added instant events and marking defered templated instantiation. (PR #103039)

2024-08-29 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/103039 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Added instant events and marking defered templated instantiation. (PR #103039)

2024-08-29 Thread Ilya Biryukov via cfe-commits
@@ -75,18 +76,18 @@ struct llvm::TimeTraceProfilerEntry { const std::string Name; TimeTraceMetadata Metadata; - const bool AsyncEvent = false; + TimeTraceEventType EventType; ilya-biryukov wrote: Let's assign the default to avoid accidentally having uni

[clang] [llvm] Added instant events and marking defered templated instantiation. (PR #103039)

2024-08-29 Thread Ilya Biryukov via cfe-commits
@@ -104,6 +105,23 @@ struct llvm::TimeTraceProfilerEntry { } }; +struct InProgressEntry { + std::unique_ptr Event; + std::vector InstantEvents; + + InProgressEntry(TimePointType &&S, TimePointType &&E, std::string &&N, + std::string &&Dt, TimeTraceEventTy

[clang] [llvm] Added instant events and marking defered templated instantiation. (PR #103039)

2024-08-29 Thread Ilya Biryukov via cfe-commits
@@ -83,6 +83,8 @@ namespace llvm { class raw_pwrite_stream; +enum class TimeTraceEventType { CompleteEvent, InstantEvent, AsyncEvent }; ilya-biryukov wrote: It would be useful to add a comment explaining what different event types are about (e.g. it would m

[clang] [llvm] Added instant events and marking defered templated instantiation. (PR #103039)

2024-08-29 Thread Ilya Biryukov via cfe-commits
@@ -104,6 +105,23 @@ struct llvm::TimeTraceProfilerEntry { } }; +struct InProgressEntry { + std::unique_ptr Event; + std::vector InstantEvents; + + InProgressEntry(TimePointType &&S, TimePointType &&E, std::string &&N, ilya-biryukov wrote: Suggestion: re

[clang] [llvm] Added instant events and marking defered templated instantiation. (PR #103039)

2024-08-29 Thread Ilya Biryukov via cfe-commits
@@ -406,34 +450,50 @@ TimeTraceProfilerEntry *llvm::timeTraceProfilerBegin(StringRef Name, StringRef Detail) { if (TimeTraceProfilerInstance != nullptr) return TimeTraceProfilerInstance->begin( -std::string(Nam

[clang] [llvm] Added instant events and marking defered templated instantiation. (PR #103039)

2024-08-29 Thread Ilya Biryukov via cfe-commits
@@ -194,13 +236,15 @@ struct llvm::TimeTraceProfiler { J.attribute("pid", Pid); J.attribute("tid", int64_t(Tid)); J.attribute("ts", StartUs); -if (E.AsyncEvent) { +if (TimeTraceEventType::AsyncEvent == E.EventType) { J.attribut

[clang] [C++20] [Modules] Embed all source files for C++20 Modules (PR #102444)

2024-08-29 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: FWIW, I meant to review this, but somehow this disappeared from my waiting for review list and I lost track of it :) https://github.com/llvm/llvm-project/pull/102444 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[clang] [llvm] [AArch64] Make apple-m4 armv8.7-a again (from armv9.2-a). (PR #106312)

2024-08-29 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha updated https://github.com/llvm/llvm-project/pull/106312 >From c9b283760399f46cc4cb4a728069fb8c33e00e5f Mon Sep 17 00:00:00 2001 From: Ahmed Bougacha Date: Tue, 27 Aug 2024 16:48:35 -0700 Subject: [PATCH 1/2] [AArch64] Add incorrect target(cpu=apple-m4) fn attr

[clang] e5e38dd - [AArch64] Make apple-m4 armv8.7-a again (from armv9.2-a). (#106312)

2024-08-29 Thread via cfe-commits
Author: Ahmed Bougacha Date: 2024-08-29T09:50:44-07:00 New Revision: e5e38ddf1b8043324175868831da21e941c00aff URL: https://github.com/llvm/llvm-project/commit/e5e38ddf1b8043324175868831da21e941c00aff DIFF: https://github.com/llvm/llvm-project/commit/e5e38ddf1b8043324175868831da21e941c00aff.diff

[clang] [llvm] [AArch64] Make apple-m4 armv8.7-a again (from armv9.2-a). (PR #106312)

2024-08-29 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha closed https://github.com/llvm/llvm-project/pull/106312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][AArch64] Add customisable immediate range checking to NEON (PR #100278)

2024-08-29 Thread via cfe-commits
https://github.com/SpencerAbson edited https://github.com/llvm/llvm-project/pull/100278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Make apple-m4 armv8.7-a again (from armv9.2-a). (PR #106312)

2024-08-29 Thread Ahmed Bougacha via cfe-commits
ahmedbougacha wrote: /cherry-pick e5e38ddf1b8043324175868831da21e941c00aff https://github.com/llvm/llvm-project/pull/106312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Refactor collection of multi-level template argument lists (PR #106585)

2024-08-29 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 6f62757e779492b288a98c7c2e27eba95a551e3b 7bbecfeae5bc40c3ead47cc4bf677eb705928812 --e

[clang] [llvm] [AArch64] Make apple-m4 armv8.7-a again (from armv9.2-a). (PR #106312)

2024-08-29 Thread via cfe-commits
llvmbot wrote: Failed to cherry-pick: e5e38ddf1b8043324175868831da21e941c00aff https://github.com/llvm/llvm-project/actions/runs/10619317445 Please manually backport the fix and push it to your github fork. Once this is done, please create a [pull request](https://github.com/llvm/llvm-proje

[clang] [Driver] Normalize the baremetal handling of libc++ and runtimes (PR #101259)

2024-08-29 Thread Petr Hosek via cfe-commits
@@ -382,38 +382,6 @@ void BareMetal::AddClangCXXStdlibIncludeArgs(const ArgList &DriverArgs, } } -void BareMetal::AddCXXStdlibLibArgs(const ArgList &Args, -ArgStringList &CmdArgs) const { - switch (GetCXXStdlibType(Args)) { - case ToolC

[clang] [Driver] Normalize the baremetal handling of libc++ and runtimes (PR #101259)

2024-08-29 Thread Petr Hosek via cfe-commits
petrhosek wrote: > Gentle ping @petrhosek I'd like to go ahead and merge this PR but I still need someone to approve this change. https://github.com/llvm/llvm-project/pull/101259 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang] 2dc3b50 - [HLSL] Apply NoRecurse attrib to all HLSL functions (#105907)

2024-08-29 Thread via cfe-commits
Author: Greg Roth Date: 2024-08-29T10:01:52-07:00 New Revision: 2dc3b509879518340b991733bfde5c7a4becd559 URL: https://github.com/llvm/llvm-project/commit/2dc3b509879518340b991733bfde5c7a4becd559 DIFF: https://github.com/llvm/llvm-project/commit/2dc3b509879518340b991733bfde5c7a4becd559.diff LOG

[clang] [HLSL] Apply NoRecurse attrib to all HLSL functions (PR #105907)

2024-08-29 Thread Greg Roth via cfe-commits
https://github.com/pow2clk closed https://github.com/llvm/llvm-project/pull/105907 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] Clang2 (PR #105453)

2024-08-29 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com updated https://github.com/llvm/llvm-project/pull/105453 >From a0a5bea46b69f2b40dd7fa737efdd51281a39429 Mon Sep 17 00:00:00 2001 From: Kyungwoo Lee Date: Wed, 24 Apr 2024 11:26:23 -0700 Subject: [PATCH 1/4] [CGData][MachineOutliner] Global Outlining2 This commit i

[clang] [HLSL] Add HLSLAttributedResourceType (PR #106181)

2024-08-29 Thread Helena Kotas via cfe-commits
@@ -799,6 +799,19 @@ static bool IsEquivalentExceptionSpec(StructuralEquivalenceContext &Context, return true; } +// Determine structural equivalence of two instances of +// HLSLAttributedResourceType::Attributes +static bool +IsStructurallyEquivalent(StructuralEquivalenceC

[clang] [Driver] Normalize the baremetal handling of libc++ and runtimes (PR #101259)

2024-08-29 Thread Louis Dionne via cfe-commits
ldionne wrote: > > Gentle ping @petrhosek > > I'd like to go ahead and merge this PR but I still need someone to approve > this change. Sorry, somehow I thought this was waiting on a reply from you. https://github.com/llvm/llvm-project/pull/101259 _

[clang] [Driver] Normalize the baremetal handling of libc++ and runtimes (PR #101259)

2024-08-29 Thread Louis Dionne via cfe-commits
https://github.com/ldionne approved this pull request. LGTM. I don't own the driver, but this is how we want libc++ to be used (as generically as possible). https://github.com/llvm/llvm-project/pull/101259 ___ cfe-commits mailing list cfe-commits@list

[clang] [HLSL] Add HLSLAttributedResourceType (PR #106181)

2024-08-29 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/106181 >From 11a6b3aac44889d39911a6704a9a963f29e92388 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Mon, 26 Aug 2024 12:13:09 -0700 Subject: [PATCH 1/8] Add HLSLAttributedResourceType - WIP --- clang/include/clang

[clang] [HLSL] set alwaysinline on HLSL functions (PR #106588)

2024-08-29 Thread Greg Roth via cfe-commits
https://github.com/pow2clk created https://github.com/llvm/llvm-project/pull/106588 HLSL inlines all its functions by default. This uses the alwaysinline attribute to force that in the corresponding pass for user functions by default and overrides the default noinline of some implicit function

[clang] [HLSL] set alwaysinline on HLSL functions (PR #106588)

2024-08-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Greg Roth (pow2clk) Changes HLSL inlines all its functions by default. This uses the alwaysinline attribute to force that in the corresponding pass for user functions by default and overrides the default noinline of some implicit function

[clang] [HLSL] set alwaysinline on HLSL functions (PR #106588)

2024-08-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Greg Roth (pow2clk) Changes HLSL inlines all its functions by default. This uses the alwaysinline attribute to force that in the corresponding pass for user functions by default and overrides the default noinline of some implicit functions

[clang] [HLSL] set alwaysinline on HLSL functions (PR #106588)

2024-08-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Greg Roth (pow2clk) Changes HLSL inlines all its functions by default. This uses the alwaysinline attribute to force that in the corresponding pass for user functions by default and overrides the default noinline of some implicit

[clang] [llvm] [mlir] Revert "[Support] Validate number of arguments passed to formatv()" (PR #106589)

2024-08-29 Thread Mehdi Amini via cfe-commits
https://github.com/joker-eph created https://github.com/llvm/llvm-project/pull/106589 Reverts llvm/llvm-project#105745 Some bots are broken apparently. >From 89a7a0b178e406164641e3f88bd5694994b15ba8 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Thu, 29 Aug 2024 10:29:20 -0700 Subject: [PAT

[clang] ed37b5f - Revert "[Support] Validate number of arguments passed to formatv()" (#106589)

2024-08-29 Thread via cfe-commits
Author: Mehdi Amini Date: 2024-08-29T10:30:11-07:00 New Revision: ed37b5f6c341a2c72d1f5f0c016f0f8a41a9bf83 URL: https://github.com/llvm/llvm-project/commit/ed37b5f6c341a2c72d1f5f0c016f0f8a41a9bf83 DIFF: https://github.com/llvm/llvm-project/commit/ed37b5f6c341a2c72d1f5f0c016f0f8a41a9bf83.diff L

[clang] [llvm] [mlir] Revert "[Support] Validate number of arguments passed to formatv()" (PR #106589)

2024-08-29 Thread Mehdi Amini via cfe-commits
https://github.com/joker-eph closed https://github.com/llvm/llvm-project/pull/106589 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Refactor MallocChecker to use `BindExpr` in `evalCall` (PR #106081)

2024-08-29 Thread Pavel Skripkin via cfe-commits
@@ -58,14 +60,14 @@ void testFreeOpNew() { void *p = operator new(0); free(p); // mismatch-warning@-1{{Memory allocated by 'operator new' should be deallocated by 'delete', not 'free()'}} -} // leak-warning{{Potential leak of memory pointed to by 'p'}} +} ---

[clang] [Clang][Sema] Refactor collection of multi-level template argument lists (PR #106585)

2024-08-29 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: Awesome, thanks! I will give a review later, but just want to note a different (but much smaller) PR touching the same area: https://github.com/llvm/llvm-project/pull/102922 Just to keep in mind that the idea is to later further simplify `getTemplateInstantiationArgs` by remo

[clang] [Driver] Normalize the baremetal handling of libc++ and runtimes (PR #101259)

2024-08-29 Thread Peter Smith via cfe-commits
@@ -382,38 +382,6 @@ void BareMetal::AddClangCXXStdlibIncludeArgs(const ArgList &DriverArgs, } } -void BareMetal::AddCXXStdlibLibArgs(const ArgList &Args, -ArgStringList &CmdArgs) const { - switch (GetCXXStdlibType(Args)) { - case ToolC

[clang] [llvm] [WebAssembly] Add intrinsics to wasm_simd128.h for all FP16 instructions (PR #106465)

2024-08-29 Thread Dan Gohman via cfe-commits
sunfishcode wrote: Would it make sense to put these declarations behind `#ifdef __wasm_fp16__` so that they aren't declared if fp16 support isn't enabled? https://github.com/llvm/llvm-project/pull/106465 ___ cfe-commits mailing list cfe-commits@lists.

[clang] [flang] [flang][driver] Add pre-processing type for Fortran pre-processed files (PR #104664)

2024-08-29 Thread Kareem Ergawy via cfe-commits
https://github.com/ergawy edited https://github.com/llvm/llvm-project/pull/104664 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

2024-08-29 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/101989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add [[clang::no_specializations]] (PR #101469)

2024-08-29 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: > > > > I did think about it more, and I think it would be more consistent to > > > > support the attribute on any sort of specializable entity, including > > > > functions - regardless of STL needs @AaronBallman @ldionne > > > > > > > > > Agreed; if we're adding a custom at

[clang] [flang] [flang][driver] Add pre-processing type for Fortran pre-processed files (PR #104664)

2024-08-29 Thread Kareem Ergawy via cfe-commits
https://github.com/ergawy updated https://github.com/llvm/llvm-project/pull/104664 >From 4ad28a2ab6566121994f14ea233f4fd27aca3285 Mon Sep 17 00:00:00 2001 From: ergawy Date: Sat, 17 Aug 2024 00:20:11 -0500 Subject: [PATCH] [flang][driver] Add pre-processing type to `.i` files This diff allows

[clang] [llvm] [AArch64] Make apple-m4 armv8.7-a again (from armv9.2-a). (PR #106312)

2024-08-29 Thread Ahmed Bougacha via cfe-commits
ahmedbougacha wrote: #106599 release/19.x: [AArch64] Make apple-m4 armv8.7-a again (from armv9.2-a). https://github.com/llvm/llvm-project/pull/106312 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] [Clang] [Test] Use lit Syntax for Environment Variables in Clang subproject (PR #102647)

2024-08-29 Thread via cfe-commits
https://github.com/Harini0924 edited https://github.com/llvm/llvm-project/pull/102647 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

2024-08-29 Thread Tim Gymnich via cfe-commits
https://github.com/tgymnich updated https://github.com/llvm/llvm-project/pull/101989 >From 4516f38d4cba70f2368dc68c72e0024f3f3e0732 Mon Sep 17 00:00:00 2001 From: Tim Gymnich Date: Fri, 2 Aug 2024 21:40:24 +0200 Subject: [PATCH 1/5] [clang][HLSL] Add sign intrinsic part 3 --- clang/include/cl

[clang] [flang] [flang][driver] Add pre-processing type for Fortran pre-processed files (PR #104664)

2024-08-29 Thread Kareem Ergawy via cfe-commits
ergawy wrote: Thanks a lot for the reply and apologies for being late, it is my turn to be OoO :). Your reply definitely clarified a few things for me. I updated the PR title and added as a note as requested. Let me know if further details need to be added. https://github.com/llvm/llvm-proj

[clang] [lld] [llvm] Thin2 (PR #106602)

2024-08-29 Thread Kyungwoo Lee via cfe-commits
https://github.com/kyulee-com created https://github.com/llvm/llvm-project/pull/106602 None >From a0a5bea46b69f2b40dd7fa737efdd51281a39429 Mon Sep 17 00:00:00 2001 From: Kyungwoo Lee Date: Wed, 24 Apr 2024 11:26:23 -0700 Subject: [PATCH 1/6] [CGData][MachineOutliner] Global Outlining2 This co

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2024-08-29 Thread Matheus Izvekov via cfe-commits
@@ -13051,11 +13051,14 @@ class Sema final : public SemaBase { /// instantiation arguments. /// /// \param DC In the event we don't HAVE a declaration yet, we instead provide - /// the decl context where it will be created. In this case, the `Innermost` - /// shoul

[clang] [Clang] Add [[clang::no_specializations]] (PR #101469)

2024-08-29 Thread via cfe-commits
cor3ntin wrote: The list is there https://eel.is/c++draft/temp.expl.spec#1 https://github.com/llvm/llvm-project/pull/101469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Avoid potential null pointer dereferences in Sema::AddInitializerToDecl(). (PR #106235)

2024-08-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/106235 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Sema] Move `Sema::AssignmentAction` into its own scoped enum (PR #106453)

2024-08-29 Thread Dan Liew via cfe-commits
https://github.com/delcypher updated https://github.com/llvm/llvm-project/pull/106453 >From 54a5f90ce219aad942074d78d986d24d6690b30c Mon Sep 17 00:00:00 2001 From: Dan Liew Date: Wed, 28 Aug 2024 13:44:44 -0700 Subject: [PATCH 1/5] [NFC][Sema] Move `Sema::AssignmentAction` into its own scoped

[clang] [NFC][Sema] Move `Sema::AssignmentAction` into its own scoped enum (PR #106453)

2024-08-29 Thread Dan Liew via cfe-commits
https://github.com/delcypher updated https://github.com/llvm/llvm-project/pull/106453 >From 54a5f90ce219aad942074d78d986d24d6690b30c Mon Sep 17 00:00:00 2001 From: Dan Liew Date: Wed, 28 Aug 2024 13:44:44 -0700 Subject: [PATCH 1/4] [NFC][Sema] Move `Sema::AssignmentAction` into its own scoped

[clang] [NFC][Sema] Move `Sema::AssignmentAction` into its own scoped enum (PR #106453)

2024-08-29 Thread Dan Liew via cfe-commits
https://github.com/delcypher updated https://github.com/llvm/llvm-project/pull/106453 >From 54a5f90ce219aad942074d78d986d24d6690b30c Mon Sep 17 00:00:00 2001 From: Dan Liew Date: Wed, 28 Aug 2024 13:44:44 -0700 Subject: [PATCH 1/6] [NFC][Sema] Move `Sema::AssignmentAction` into its own scoped

[clang] [compiler-rt] [llvm] [CMake][compiler-rt] Support for using compiler-rt atomic library (PR #106603)

2024-08-29 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek created https://github.com/llvm/llvm-project/pull/106603 Not every toolchain provides and want to use libatomic which is a part of GCC, some toolchains may opt into using compiler-rt atomic library. >From 18814eb544e4e8d9274583c41e65b7f16c3bdfcc Mon Sep 17 00:00:00

[clang] [compiler-rt] [llvm] [CMake][compiler-rt] Support for using compiler-rt atomic library (PR #106603)

2024-08-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-compiler-rt-sanitizer Author: Petr Hosek (petrhosek) Changes Not every toolchain provides and want to use libatomic which is a part of GCC, some toolchains may opt into using compiler-rt atomic library. --- Full diff: https://github.com/llvm/llvm-proje

[clang] [llvm] [WebAssembly] Add intrinsics to wasm_simd128.h for all FP16 instructions (PR #106465)

2024-08-29 Thread Brendan Dahl via cfe-commits
brendandahl wrote: > Would it make sense to put these declarations behind `#ifdef __wasm_fp16__` > so that they aren't declared if fp16 support isn't enabled? I could do that, if that's preferred. I followed what the relaxed instructions did and use the target attribute `__target__("fp16")`.

[clang] [llvm] [WebAssembly] Add intrinsics to wasm_simd128.h for all FP16 instructions (PR #106465)

2024-08-29 Thread Dan Gohman via cfe-commits
sunfishcode wrote: Oh, I missed that. In that case, that seems sufficient. Thanks! https://github.com/llvm/llvm-project/pull/106465 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Sema] Move `Sema::AssignmentAction` into its own scoped enum (PR #106453)

2024-08-29 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1601879f5d690595889a5537c0049b62df4657c7 f1f0975a05d1fe9dc9c1544888939a4a7f4e7633 --e

[clang] [NFC][Sema] Move `Sema::AssignmentAction` into its own scoped enum (PR #106453)

2024-08-29 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1601879f5d690595889a5537c0049b62df4657c7 74e9de59d57496cc79d8e4260fec3bac53190af0 --e

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

2024-08-29 Thread Farzon Lotfi via cfe-commits
farzonl wrote: > @farzonl This PR requires the SPIRV part (#101987) to be merged. I haven't signed off on that one because I wanted input from others. I'll ping some folks. If the pr is still sitting we can make a small change in this pr that will unbloc it. Add the spirv intrinsic to this pr t

[clang] [compiler-rt] [llvm] [CMake][compiler-rt] Support for using compiler-rt atomic library (PR #106603)

2024-08-29 Thread Chris Apple via cfe-commits
https://github.com/cjappl approved this pull request. Seems reasonable to me, I would wait for other approvals, as I'm relatively new here. Just ensure this is good to go with rtsan, I recommend running the tests locally, as I don't think they're a part of the default pre-commit set ``` ninja

[clang] Make PCH's respect any VFS specified. (PR #106577)

2024-08-29 Thread Neil Henning via cfe-commits
https://github.com/sheredom updated https://github.com/llvm/llvm-project/pull/106577 >From 774ca72fd61c98a830930dab9c60e16fcc6782a9 Mon Sep 17 00:00:00 2001 From: Neil Henning Date: Thu, 29 Aug 2024 13:15:49 +0100 Subject: [PATCH] Make PCH's respect any VFS specified. We want to be able to gen

[clang] [compiler-rt] [llvm] [CMake][compiler-rt] Support for using compiler-rt atomic library (PR #106603)

2024-08-29 Thread Shoaib Meenai via cfe-commits
https://github.com/smeenai approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/106603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2024-08-29 Thread Matheus Izvekov via cfe-commits
@@ -1144,6 +1164,46 @@ bool Sema::CheckInstantiatedFunctionTemplateConstraints( PointOfInstantiation, Satisfaction); } +bool Sema::CheckFunctionConstraintsWithoutInstantiation( +SourceLocation PointOfInstantiation, FunctionTemplateDecl

[clang] [libcxx] [Clang] Implement CWG2369 "Ordering between constraints and substitution" (PR #102857)

2024-08-29 Thread Matheus Izvekov via cfe-commits
@@ -1144,6 +1164,46 @@ bool Sema::CheckInstantiatedFunctionTemplateConstraints( PointOfInstantiation, Satisfaction); } +bool Sema::CheckFunctionConstraintsWithoutInstantiation( +SourceLocation PointOfInstantiation, FunctionTemplateDecl

[clang] [clang][test] add TestLanguage.def to specify all tested language versions (PR #94243)

2024-08-29 Thread Aaron Ballman via cfe-commits
@@ -1224,7 +1224,7 @@ TEST_P(ASTMatchersTest, CastExpression_MatchesImplicitCasts) { } TEST_P(ASTMatchersTest, CastExpr_DoesNotMatchNonCasts) { - if (GetParam().Language == Lang_C89 || GetParam().Language == Lang_C99) { + if (GetParam().isC()) { AaronBallma

[clang] [clang][test] add TestLanguage.def to specify all tested language versions (PR #94243)

2024-08-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM, unless @Sirraide has other concerns. https://github.com/llvm/llvm-project/pull/94243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [clang][test] add TestLanguage.def to specify all tested language versions (PR #94243)

2024-08-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/94243 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] prevent assertion failure when converting vectors to int/float with invalid expressions (PR #105727)

2024-08-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/105727 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Sema] Move `Sema::AssignmentAction` into its own scoped enum (PR #106453)

2024-08-29 Thread Dan Liew via cfe-commits
https://github.com/delcypher updated https://github.com/llvm/llvm-project/pull/106453 >From 5497f530a717ff302deb85fc30ff75e59dba Mon Sep 17 00:00:00 2001 From: Dan Liew Date: Thu, 29 Aug 2024 11:48:12 -0700 Subject: [PATCH] [NFC][Sema] Move Sema::AssignmentAction into its own scoped enum

[clang] Create Texture Dimension attribute in HLSL (PR #104239)

2024-08-29 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 converted_to_draft https://github.com/llvm/llvm-project/pull/104239 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ValueTracking] use KnownBits to compute fpclass from bitcast (PR #97762)

2024-08-29 Thread via cfe-commits
@@ -5921,6 +5921,61 @@ void computeKnownFPClass(const Value *V, const APInt &DemandedElts, break; } + case Instruction::BitCast: { +const Value *Src; +if (!match(Op, m_ElementWiseBitCast(m_Value(Src))) || +!Src->getType()->isIntOrIntVectorTy()) + b

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-29 Thread Doug Wyatt via cfe-commits
@@ -210,24 +210,88 @@ void nb18(void (^block)() [[clang::nonblocking]]) [[clang::nonblocking]] } // Builtin functions -void nb18a() [[clang::nonblocking]] { +void nb19() [[clang::nonblocking]] { __builtin_assume(1); void *ptr = __builtin_malloc(1); // expected

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-29 Thread Doug Wyatt via cfe-commits
@@ -908,9 +936,9 @@ class Analyzer { static bool isSafeBuiltinFunction(const FunctionDecl *FD) { unsigned BuiltinID = FD->getBuiltinID(); switch (BuiltinID) { - case 0: // not builtin + case 0: // Not builtin. return false; - default: //

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-29 Thread Doug Wyatt via cfe-commits
@@ -1,44 +1,67 @@ -//=== EffectAnalysis.cpp - Sema warnings for function effects -===// +//=== SemaFunctionEffects.cpp - Sema handling of function effects -===// // // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. // See ht

[clang] [HLSL] Add StructuredBuffer to external sema source (PR #106316)

2024-08-29 Thread Damyan Pepper via cfe-commits
https://github.com/damyanp approved this pull request. I had a bunch of questions about the tests, but I see that what's happening here is that the same tests for RWBuffer are being adapter for StructuredBuffer. I don't know how much everything differs between the two...I'm wondering if there'

[clang] [HLSL] set alwaysinline on HLSL functions (PR #106588)

2024-08-29 Thread Greg Roth via cfe-commits
https://github.com/pow2clk updated https://github.com/llvm/llvm-project/pull/106588 >From 12253818bd47aa8c324f6222586965f356b11c90 Mon Sep 17 00:00:00 2001 From: Greg Roth Date: Wed, 24 Jul 2024 16:49:19 -0600 Subject: [PATCH 1/2] [HLSL] set alwaysinline on HLSL functions HLSL inlines all its

[clang] [NFC][Sema] Move `Sema::AssignmentAction` into its own scoped enum (PR #106453)

2024-08-29 Thread Dan Liew via cfe-commits
https://github.com/delcypher edited https://github.com/llvm/llvm-project/pull/106453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Sema] Move `Sema::AssignmentAction` into its own scoped enum (PR #106453)

2024-08-29 Thread Dan Liew via cfe-commits
https://github.com/delcypher closed https://github.com/llvm/llvm-project/pull/106453 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ff04c5b - [NFC][Sema] Move `Sema::AssignmentAction` into its own scoped enum (#106453)

2024-08-29 Thread via cfe-commits
Author: Dan Liew Date: 2024-08-29T12:00:28-07:00 New Revision: ff04c5b2e69481fc3b828bfcf32e05ff7a2c4b05 URL: https://github.com/llvm/llvm-project/commit/ff04c5b2e69481fc3b828bfcf32e05ff7a2c4b05 DIFF: https://github.com/llvm/llvm-project/commit/ff04c5b2e69481fc3b828bfcf32e05ff7a2c4b05.diff LOG:

[clang] [clang] Install scan-build-py into plain "lib" directory (#106608) (PR #106612)

2024-08-29 Thread Michał Górny via cfe-commits
https://github.com/mgorny created https://github.com/llvm/llvm-project/pull/106612 Install scan-build-py modules into the plain `lib` directory, without LLVM_LIBDIR_SUFFIX appended, to match the path expected by `intercept-build` executable. This fixes the program being unable to find its mod

[clang] a0441ce - [NFC] whitespace cleanup on clang/test/SemaTemplate/temp_arg_nontype.cpp

2024-08-29 Thread Matheus Izvekov via cfe-commits
Author: Matheus Izvekov Date: 2024-08-29T16:03:42-03:00 New Revision: a0441ced7a770036e00610989e2fabba5caeb31b URL: https://github.com/llvm/llvm-project/commit/a0441ced7a770036e00610989e2fabba5caeb31b DIFF: https://github.com/llvm/llvm-project/commit/a0441ced7a770036e00610989e2fabba5caeb31b.dif

<    1   2   3   4   5   >