llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Kazu Hirata (kazutakahirata)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/105829.diff
1 Files Affected:
- (modified) clang-tools-extra/clangd/TUScheduler.cpp (+1-1)
``diff
diff --git a/clang-t
@@ -3298,22 +3315,40 @@ LValue CodeGenFunction::EmitPredefinedLValue(const
PredefinedExpr *E) {
/// { i16 TypeKind, i16 TypeInfo }
/// \endcode
///
-/// followed by an array of i8 containing the type name. TypeKind is 0 for an
-/// integer, 1 for a floating point value, and
https://github.com/usx95 updated
https://github.com/llvm/llvm-project/pull/105817
>From 77003063912f691d246c4f94dd7a952ceace9268 Mon Sep 17 00:00:00 2001
From: Utkarsh Saxena
Date: Fri, 23 Aug 2024 11:57:40 +
Subject: [PATCH 1/2] [clang] Compiler builtin for deduping a list of types
---
.
https://github.com/cor3ntin approved this pull request.
Thanks for adding that `(Deprecated)`
Makes sense to me that a diagnostic would be controlled by a diagnostic flag :)
https://github.com/llvm/llvm-project/pull/105821
___
cfe-commits mailing list
https://github.com/earnol edited https://github.com/llvm/llvm-project/pull/96240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
Sorry about the delayed response.. gmail decided that reviews were spam and so
I didn't notice a whole lot of email until I thought to ask myself why the
community reviews seemed so quiet lately. :-D
I'm going to revert the changes entirely until we can figure out a better
Author: Aaron Ballman
Date: 2024-08-23T09:49:08-04:00
New Revision: e3ce979f1b3ac1e7f2d0261d3abffbd12064eae6
URL:
https://github.com/llvm/llvm-project/commit/e3ce979f1b3ac1e7f2d0261d3abffbd12064eae6
DIFF:
https://github.com/llvm/llvm-project/commit/e3ce979f1b3ac1e7f2d0261d3abffbd12064eae6.diff
https://github.com/earnol edited https://github.com/llvm/llvm-project/pull/96240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/earnol edited https://github.com/llvm/llvm-project/pull/96240
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,32 @@
+// RUN: %clang_cc1 -std=c++23 -verify %s
+
+namespace t1 {
+template struct enable_if { typedef void type; };
+template class Foo {};
+template constexpr bool check() { return true; }
+template struct Bar {};
+
+template void func(Bar()>::type>) {}
+// expecte
hokein wrote:
> I think the PR https://github.com/llvm/llvm-project/pull/104556 should fix
> this.
The PRdoesn't address this issue, it appears to be a different problem. I have
identified the correct solution, so my plan is as follows:
1. Reland this PR without removing EnableLifetimeWarning
https://github.com/hokein closed
https://github.com/llvm/llvm-project/pull/105753
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
hokein wrote:
Thanks, acked. Closing it now. I will reland it.
https://github.com/llvm/llvm-project/pull/105753
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/NagyDonat approved this pull request.
Thanks for the update, I'm satisfied with this commit now.
https://github.com/llvm/llvm-project/pull/105653
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
@@ -0,0 +1,32 @@
+// RUN: %clang_cc1 -std=c++23 -verify %s
+
+namespace t1 {
+template struct enable_if { typedef void type; };
+template class Foo {};
+template constexpr bool check() { return true; }
+template struct Bar {};
+
+template void func(Bar()>::type>) {}
+// expecte
ldionne wrote:
@hokein @vvereschaka Yeah, I get the same conclusion as you. I think that's a
false positive, this is just moving the content of an engaged `std::optional`.
https://github.com/llvm/llvm-project/pull/104906
___
cfe-commits mailing list
c
https://github.com/ldionne commented:
I did a very cursory review and this seems good to me, the tests seem to cover
what the paper was intending to provide.
https://github.com/llvm/llvm-project/pull/91895
___
cfe-commits mailing list
cfe-commits@list
@@ -0,0 +1,431 @@
+// RUN: %clang_cc1 -std=c++20 -Wno-unused %s -verify=expected,cxx20
-Wno-vla-cxx-extension
+// RUN: %clang_cc1 -std=c++23 -Wno-unused %s -verify=expected,sincecxx23
-Wno-vla-cxx-extension
+// RUN: %clang_cc1 -std=c++26 -Wno-unused %s -verify=expected,sincecxx2
https://github.com/ldionne edited
https://github.com/llvm/llvm-project/pull/91895
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,32 @@
+// RUN: %clang_cc1 -std=c++23 -verify %s
+
+namespace t1 {
+template struct enable_if { typedef void type; };
+template class Foo {};
+template constexpr bool check() { return true; }
+template struct Bar {};
+
+template void func(Bar()>::type>) {}
+// expecte
gonzalobg wrote:
> Sorry, I dont get it. Should I press the merge button? Because I dont have
> one... or I can't find it
No, @Artem-B will press it, I think there is nothing else for you to do. The
current failures are not this PRs fault.
@Artem-B could we merge this despite the failures?
ht
@@ -0,0 +1,32 @@
+// RUN: %clang_cc1 -std=c++23 -verify %s
+
+namespace t1 {
+template struct enable_if { typedef void type; };
+template class Foo {};
+template constexpr bool check() { return true; }
+template struct Bar {};
+
+template void func(Bar()>::type>) {}
+// expecte
https://github.com/hokein created
https://github.com/llvm/llvm-project/pull/105838
Reland without the `EnableLifetimeWarnings` removal. I will remove the
EnableLifetimeWarnings in a follow-up patch.
I have added a test to prevent regression.
>From c248c80164965e82807a8682d30ce387f7801cc4 Mon
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Haojian Wu (hokein)
Changes
Reland without the `EnableLifetimeWarnings` removal. I will remove the
EnableLifetimeWarnings in a follow-up patch.
I have added a test to prevent regression.
---
Full diff: https://github.com/llvm/llvm-projec
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff e3ce979f1b3ac1e7f2d0261d3abffbd12064eae6
c248c80164965e82807a8682d30ce387f7801cc4 --e
Author: Edd Dawson
Date: 2024-08-23T15:58:00+01:00
New Revision: 05ce95ef0412ba8b3e3189db5ed130a9949bbefd
URL:
https://github.com/llvm/llvm-project/commit/05ce95ef0412ba8b3e3189db5ed130a9949bbefd
DIFF:
https://github.com/llvm/llvm-project/commit/05ce95ef0412ba8b3e3189db5ed130a9949bbefd.diff
LO
https://github.com/tahonermann updated
https://github.com/llvm/llvm-project/pull/105738
>From 6377cc2f64ba494e769848d257fe683fb0059e6c Mon Sep 17 00:00:00 2001
From: Tom Honermann
Date: Thu, 22 Aug 2024 09:44:56 -0700
Subject: [PATCH] [Clang] Match MSVC handling of duplicate header search paths
https://github.com/playstation-edd closed
https://github.com/llvm/llvm-project/pull/105810
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tahonermann edited
https://github.com/llvm/llvm-project/pull/105738
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jcranmer-intel approved this pull request.
https://github.com/llvm/llvm-project/pull/105693
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/usx95 approved this pull request.
LGTM. Thanks.
https://github.com/llvm/llvm-project/pull/105838
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/105838
>From c248c80164965e82807a8682d30ce387f7801cc4 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Fri, 23 Aug 2024 16:20:45 +0200
Subject: [PATCH 1/2] Reland "[clang] Merge lifetimebound and GSL code paths
for life
@@ -0,0 +1,32 @@
+// RUN: %clang_cc1 -std=c++23 -verify %s
+
+namespace t1 {
+template struct enable_if { typedef void type; };
+template class Foo {};
+template constexpr bool check() { return true; }
+template struct Bar {};
+
+template void func(Bar()>::type>) {}
+// expecte
https://github.com/cor3ntin edited
https://github.com/llvm/llvm-project/pull/100692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,32 @@
+// RUN: %clang_cc1 -std=c++23 -verify %s
+
+namespace t1 {
+template struct enable_if { typedef void type; };
+template class Foo {};
+template constexpr bool check() { return true; }
+template struct Bar {};
+
+template void func(Bar()>::type>) {}
+// expecte
https://github.com/cjappl created
https://github.com/llvm/llvm-project/pull/105841
This reverts commit a1e9b7e646b76bf844e8a9a101ebd27de11992ff
This relands commit d010ec6af8162a8ae4e42d2cac5282f83db0ce07
No modifications from the original patch. It was determined that the ubsan
build failure
Author: Chris Apple
Date: 2024-08-23T08:16:52-07:00
New Revision: f77e8f765e425a575516c16e7034cb448d270fcc
URL:
https://github.com/llvm/llvm-project/commit/f77e8f765e425a575516c16e7034cb448d270fcc
DIFF:
https://github.com/llvm/llvm-project/commit/f77e8f765e425a575516c16e7034cb448d270fcc.diff
L
https://github.com/cjappl closed
https://github.com/llvm/llvm-project/pull/105841
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Chris Apple (cjappl)
Changes
This reverts commit a1e9b7e646b76bf844e8a9a101ebd27de11992ff
This relands commit d010ec6af8162a8ae4e42d2cac5282f83db0ce07
No modifications from the original patch. It was determined that the ubsan
buil
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
@llvm/pr-subscribers-clang
Author: Chris Apple (cjappl)
Changes
This reverts commit a1e9b7e646b76bf844e8a9a101ebd27de11992ff
This relands commit d010ec6af8162a8ae4e42d2cac5282f83db0ce07
No modifications from the original patch. It was deter
Author: Aaron Ballman
Date: 2024-08-23T11:17:34-04:00
New Revision: 3faf5b93cfd2b2723851191a244a9616d40771e7
URL:
https://github.com/llvm/llvm-project/commit/3faf5b93cfd2b2723851191a244a9616d40771e7
DIFF:
https://github.com/llvm/llvm-project/commit/3faf5b93cfd2b2723851191a244a9616d40771e7.diff
https://github.com/AaronBallman closed
https://github.com/llvm/llvm-project/pull/105693
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cjappl wrote:
Relanded as f77e8f765e42
https://github.com/llvm/llvm-project/pull/102622
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
@mizvekov do you think a refactor would help your future work or should
@Endilll postpone for now?
https://github.com/llvm/llvm-project/pull/104687
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
https://github.com/MaskRay approved this pull request.
LGTM
@zatrazz
https://github.com/llvm/llvm-project/pull/105821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: cor3ntin
Date: 2024-08-23T17:24:08+02:00
New Revision: 6e78aef646c22b7087cbf7939c8016f4f59614a1
URL:
https://github.com/llvm/llvm-project/commit/6e78aef646c22b7087cbf7939c8016f4f59614a1
DIFF:
https://github.com/llvm/llvm-project/commit/6e78aef646c22b7087cbf7939c8016f4f59614a1.diff
LOG:
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/104586
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/105829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/105821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/kadircet created
https://github.com/llvm/llvm-project/pull/105844
In practice most of these expressions just resolve to implicitly
provided `operator new` and standard says it's not necessary to include
`` for that.
Hence this is resulting in a lot of churn in cases where incl
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: kadir çetinkaya (kadircet)
Changes
In practice most of these expressions just resolve to implicitly
provided `operator new` and standard says it's not necessary to include
`` for that.
Hence this is resulting in a lot of ch
https://github.com/gandhi56 created
https://github.com/llvm/llvm-project/pull/105845
Change-Id: I7d8fa4251c80a6f815f55a0998677d18ade25b72
>From 8830b6f390039c9a952a86ea52e8fe9559900448 Mon Sep 17 00:00:00 2001
From: Anshil Gandhi
Date: Thu, 22 Aug 2024 18:57:33 +
Subject: [PATCH] [AMDGPU]
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Anshil Gandhi (gandhi56)
Changes
Change-Id: I7d8fa4251c80a6f815f55a0998677d18ade25b72
---
Full diff: https://github.com/llvm/llvm-project/pull/105845.diff
3 Files Affected:
- (added) clang/test/CodeGenCUDA/gpu-rdc-amdgpu-attrs.cu (+12)
https://github.com/gandhi56 edited
https://github.com/llvm/llvm-project/pull/105845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 6e78aef646c22b7087cbf7939c8016f4f59614a1
8830b6f390039c9a952a86ea52e8fe9559900448 --e
https://github.com/gandhi56 updated
https://github.com/llvm/llvm-project/pull/105845
>From d4b8e5b213b4ea9b5b615354d264b71ed76508d5 Mon Sep 17 00:00:00 2001
From: Anshil Gandhi
Date: Thu, 22 Aug 2024 18:57:33 +
Subject: [PATCH] [AMDGPU][LTO] Assume closed world after linking
Change-Id: I7d
ldionne wrote:
The libc++ part: https://github.com/llvm/llvm-project/pull/105847
https://github.com/llvm/llvm-project/pull/100393
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Kazu Hirata
Date: 2024-08-23T08:45:29-07:00
New Revision: 5a25854ed18ec5a51df6d1f7a2366a574a6846b0
URL:
https://github.com/llvm/llvm-project/commit/5a25854ed18ec5a51df6d1f7a2366a574a6846b0
DIFF:
https://github.com/llvm/llvm-project/commit/5a25854ed18ec5a51df6d1f7a2366a574a6846b0.diff
L
https://github.com/kazutakahirata closed
https://github.com/llvm/llvm-project/pull/105829
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Haojian Wu
Date: 2024-08-23T17:50:27+02:00
New Revision: b1560bdb2bc67006f3b8f7e84ee0356632bf8126
URL:
https://github.com/llvm/llvm-project/commit/b1560bdb2bc67006f3b8f7e84ee0356632bf8126
DIFF:
https://github.com/llvm/llvm-project/commit/b1560bdb2bc67006f3b8f7e84ee0356632bf8126.diff
LO
https://github.com/hokein closed
https://github.com/llvm/llvm-project/pull/105838
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -761,7 +761,8 @@ void
AMDGPUTargetMachine::registerPassBuilderCallbacks(PassBuilder &PB) {
if (EnableLowerModuleLDS)
PM.addPass(AMDGPULowerModuleLDSPass(*this));
if (EnableAMDGPUAttributor && Level != OptimizationLevel::O0)
- PM.addPass(AM
@@ -0,0 +1,431 @@
+// RUN: %clang_cc1 -std=c++20 -Wno-unused %s -verify=expected,cxx20
-Wno-vla-cxx-extension
+// RUN: %clang_cc1 -std=c++23 -Wno-unused %s -verify=expected,sincecxx23
-Wno-vla-cxx-extension
+// RUN: %clang_cc1 -std=c++26 -Wno-unused %s -verify=expected,sincecxx2
@@ -0,0 +1,431 @@
+// RUN: %clang_cc1 -std=c++20 -Wno-unused %s -verify=expected,cxx20
-Wno-vla-cxx-extension
+// RUN: %clang_cc1 -std=c++23 -Wno-unused %s -verify=expected,sincecxx23
-Wno-vla-cxx-extension
+// RUN: %clang_cc1 -std=c++26 -Wno-unused %s -verify=expected,sincecxx2
https://github.com/shiltian approved this pull request.
LGTM with one nit
https://github.com/llvm/llvm-project/pull/105845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shiltian requested changes to this pull request.
Oops, replied the wrong PR. Sorry.
https://github.com/llvm/llvm-project/pull/105845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
@@ -0,0 +1,12 @@
+// RUN: clang -x hip -O3 -fgpu-rdc %s -mllvm -debug-only=amdgpu-attributor -o
- | FileCheck %s
shiltian wrote:
This should not be a clang test. You can have an opt test.
https://github.com/llvm/llvm-project/pull/105845
https://github.com/shiltian edited
https://github.com/llvm/llvm-project/pull/105845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rnk approved this pull request.
Thanks for doing this!
https://github.com/llvm/llvm-project/pull/105821
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/smanna12 edited
https://github.com/llvm/llvm-project/pull/105556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/pogo59 created
https://github.com/llvm/llvm-project/pull/105852
Certain intrinsics map to builtins that require an immediate (literal)
argument; make sure we report non-literal arguments. Also verify that shift
intrinsics map to the expected builtins.
These have been kickin
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Paul T Robinson (pogo59)
Changes
Certain intrinsics map to builtins that require an immediate (literal)
argument; make sure we report non-literal arguments. Also verify that shift
intrinsics map to the expected builtins.
These have been
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
Author: Paul T Robinson (pogo59)
Changes
Certain intrinsics map to builtins that require an immediate (literal)
argument; make sure we report non-literal arguments. Also verify that shift
intrinsics map to the expected builtins.
These have
https://github.com/smanna12 closed
https://github.com/llvm/llvm-project/pull/97105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smanna12 wrote:
I am unable to add new change in this PR. Follow-up is here:
https://github.com/llvm/llvm-project/pull/105556.
https://github.com/llvm/llvm-project/pull/97105
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
https://github.com/vegerot updated
https://github.com/llvm/llvm-project/pull/97926
>From 55e3359cf82d766e8b361b6f167d6cc445853eb0 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Max=20=F0=9F=91=A8=F0=9F=8F=BD=E2=80=8D=F0=9F=92=BB=20Copl?=
=?UTF-8?q?an?=
Date: Sat, 6 Jul 2024 17:22:55 -0700
Subject: [
https://github.com/vegerot ready_for_review
https://github.com/llvm/llvm-project/pull/97926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vegerot wrote:
@mordante @AaronBallman This diff is ready for review 🙂
https://github.com/llvm/llvm-project/pull/97926
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ian-twilightcoder created
https://github.com/llvm/llvm-project/pull/105855
Apple's API_AVAILABLE macro has its own notion of platform names which are
supported by __API_AVAILABLE_PLATFORM_ macros. They don't follow a
consistent naming convention, but there's at least one tha
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Ian Anderson (ian-twilightcoder)
Changes
Apple's API_AVAILABLE macro has its own notion of platform names which are
supported by __API_AVAILABLE_PLATFORM_ macros. They don't follow a
consistent naming convention, but there's at leas
https://github.com/ian-twilightcoder edited
https://github.com/llvm/llvm-project/pull/105855
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -488,22 +488,43 @@ static void DoEmitAvailabilityWarning(Sema &S,
AvailabilityResult K,
// Don't offer a fixit for declarations with availability attributes.
if (Enclosing->hasAttr())
return;
- if (!S.getPreprocessor().isMacroDefined("API_AVAILABLE"
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff a2d8743cc86f96f6b1cbd85798328bd3fb2bf4de
4cbf377e71fe7bd3503fc51c0217d5bb3ae6355e --e
@@ -98,3 +98,6 @@ enum E8 { A8 = -128, B8 = 127 } x8;
// CHECK-NOT: DIFlagEnumClass
// CHECK: !DIEnumerator(name: "A8", value: -128)
+// Forward declaration of an enum class.
+enum class Color : int;
+// CHECK-NOT: !DICompositeType(tag: DW_TAG_enumeration_type, name: "Color"
-
Artem-B wrote:
I can land the patch.
The buildkite failures appear to be unrelated (something in lldb tests).
Let's wait till clang format checks are done.
https://github.com/llvm/llvm-project/pull/99646
___
cfe-commits mailing list
cfe-commits@lists
@@ -1,8 +1,9 @@
-// RUN: %clang_hwasan -Wl,--build-id -g %s -o %t
-// RUN: echo '[{"prefix": "'"$(realpath $(dirname %s))"'/", "link":
"http://test.invalid/{file}:{line}"}]' > %t.linkify
-// RUN: %env_hwasan_opts=symbolize=0 not %run %t 2>&1 | hwasan_symbolize
--html --symbols $
https://github.com/tahonermann approved this pull request.
Per discussion in https://github.com/llvm/llvm-project/pull/97105, this looks
good to me.
However, please do update the PR title and adjust the commit message
accordingly when merging the change as requested by @pogo59.
https://github
https://github.com/smanna12 edited
https://github.com/llvm/llvm-project/pull/105556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/smanna12 edited
https://github.com/llvm/llvm-project/pull/105556
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
smanna12 wrote:
> Per discussion in #97105, this looks good to me.
>
> However, please do update the PR title and adjust the commit message
> accordingly when merging the change as requested by @pogo59.
Thanks @tahonermann and @pogo59 for reviews.
I have updated title and commit messages.
ht
mpark wrote:
> Thanks (Hi!). Do you have commit access or should I merge that for you?
Hi Corentin! I have commit access 🙂
https://github.com/llvm/llvm-project/pull/105784
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/
Author: Michael Park
Date: 2024-08-23T10:29:33-07:00
New Revision: 1821cb38995796e1b8d46357c2b26eff4ca0f88c
URL:
https://github.com/llvm/llvm-project/commit/1821cb38995796e1b8d46357c2b26eff4ca0f88c
DIFF:
https://github.com/llvm/llvm-project/commit/1821cb38995796e1b8d46357c2b26eff4ca0f88c.diff
https://github.com/mpark closed https://github.com/llvm/llvm-project/pull/105784
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ldionne wrote:
Gentle ping
https://github.com/llvm/llvm-project/pull/101688
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -459,7 +467,412 @@ void SemaHLSL::handleResourceClassAttr(Decl *D, const
ParsedAttr &AL) {
D->addAttr(HLSLResourceClassAttr::Create(getASTContext(), RC, ArgLoc));
}
-void SemaHLSL::handleResourceBindingAttr(Decl *D, const ParsedAttr &AL) {
+struct RegisterBindingFlags {
@@ -459,7 +467,412 @@ void SemaHLSL::handleResourceClassAttr(Decl *D, const
ParsedAttr &AL) {
D->addAttr(HLSLResourceClassAttr::Create(getASTContext(), RC, ArgLoc));
}
-void SemaHLSL::handleResourceBindingAttr(Decl *D, const ParsedAttr &AL) {
+struct RegisterBindingFlags {
https://github.com/hekota approved this pull request.
https://github.com/llvm/llvm-project/pull/97103
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Joshua Batista
Date: 2024-08-23T10:47:05-07:00
New Revision: ebc4a66e9b525f7efc03053e3c7472d3e3fb0412
URL:
https://github.com/llvm/llvm-project/commit/ebc4a66e9b525f7efc03053e3c7472d3e3fb0412
DIFF:
https://github.com/llvm/llvm-project/commit/ebc4a66e9b525f7efc03053e3c7472d3e3fb0412.diff
https://github.com/bob80905 closed
https://github.com/llvm/llvm-project/pull/97103
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ilya-biryukov approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/105844
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 200 of 362 matches
Mail list logo
