Author: Chris Apple
Date: 2024-08-22T14:08:24-07:00
New Revision: d010ec6af8162a8ae4e42d2cac5282f83db0ce07
URL:
https://github.com/llvm/llvm-project/commit/d010ec6af8162a8ae4e42d2cac5282f83db0ce07
DIFF:
https://github.com/llvm/llvm-project/commit/d010ec6af8162a8ae4e42d2cac5282f83db0ce07.diff
L
https://github.com/cjappl closed
https://github.com/llvm/llvm-project/pull/102622
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -503,9 +503,11 @@ void
HLSLExternalSemaSource::defineHLSLTypesWithForwardDeclarations() {
Decl = BuiltinTypeDeclBuilder(*SemaPtr, HLSLNamespace, "RWBuffer")
.addSimpleTemplateParams(*SemaPtr, {"element_type"})
.Record;
+
onCompletion(Decl, [th
@@ -0,0 +1,123 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o -
-fsyntax-only %s -verify
+
+struct MySRV {
+ [[hlsl::resource_class(SRV)]] int x;
+};
+
+struct MySampler {
+ [[hlsl::resource_class(Sampler)]] int x;
+};
+
+struct MyUAV {
+ [[hlsl::reso
@@ -459,7 +467,412 @@ void SemaHLSL::handleResourceClassAttr(Decl *D, const
ParsedAttr &AL) {
D->addAttr(HLSLResourceClassAttr::Create(getASTContext(), RC, ArgLoc));
}
-void SemaHLSL::handleResourceBindingAttr(Decl *D, const ParsedAttr &AL) {
+struct RegisterBindingFlags {
@@ -551,24 +541,21 @@ getHLSLResourceAttrFromEitherDecl(VarDecl *VD,
// the resource attr could be on the record decl itself or on one of
// its fields (the resource handle, most commonly)
-const auto *Attr = TheRecordDecl->getAttr();
+const auto *Attr = TheRec
@@ -459,7 +467,412 @@ void SemaHLSL::handleResourceClassAttr(Decl *D, const
ParsedAttr &AL) {
D->addAttr(HLSLResourceClassAttr::Create(getASTContext(), RC, ArgLoc));
}
-void SemaHLSL::handleResourceBindingAttr(Decl *D, const ParsedAttr &AL) {
+struct RegisterBindingFlags {
@@ -459,7 +467,412 @@ void SemaHLSL::handleResourceClassAttr(Decl *D, const
ParsedAttr &AL) {
D->addAttr(HLSLResourceClassAttr::Create(getASTContext(), RC, ArgLoc));
}
-void SemaHLSL::handleResourceBindingAttr(Decl *D, const ParsedAttr &AL) {
+struct RegisterBindingFlags {
@@ -0,0 +1,123 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o -
-fsyntax-only %s -verify
+
+struct MySRV {
+ [[hlsl::resource_class(SRV)]] int x;
+};
+
+struct MySampler {
+ [[hlsl::resource_class(Sampler)]] int x;
+};
+
+struct MyUAV {
+ [[hlsl::reso
@@ -459,7 +467,412 @@ void SemaHLSL::handleResourceClassAttr(Decl *D, const
ParsedAttr &AL) {
D->addAttr(HLSLResourceClassAttr::Create(getASTContext(), RC, ArgLoc));
}
-void SemaHLSL::handleResourceBindingAttr(Decl *D, const ParsedAttr &AL) {
+struct RegisterBindingFlags {
@@ -459,7 +467,412 @@ void SemaHLSL::handleResourceClassAttr(Decl *D, const
ParsedAttr &AL) {
D->addAttr(HLSLResourceClassAttr::Create(getASTContext(), RC, ArgLoc));
}
-void SemaHLSL::handleResourceBindingAttr(Decl *D, const ParsedAttr &AL) {
+struct RegisterBindingFlags {
@@ -459,7 +467,412 @@ void SemaHLSL::handleResourceClassAttr(Decl *D, const
ParsedAttr &AL) {
D->addAttr(HLSLResourceClassAttr::Create(getASTContext(), RC, ArgLoc));
}
-void SemaHLSL::handleResourceBindingAttr(Decl *D, const ParsedAttr &AL) {
+struct RegisterBindingFlags {
@@ -459,7 +467,412 @@ void SemaHLSL::handleResourceClassAttr(Decl *D, const
ParsedAttr &AL) {
D->addAttr(HLSLResourceClassAttr::Create(getASTContext(), RC, ArgLoc));
}
-void SemaHLSL::handleResourceBindingAttr(Decl *D, const ParsedAttr &AL) {
+struct RegisterBindingFlags {
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/97103
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/97103
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hekota edited https://github.com/llvm/llvm-project/pull/97103
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vvereschaka wrote:
Hi @hokein ,
for some reason these changes break one of the libc++ test with the following
compilation error:
```
# .---command stderr
# | In file included from
C:\buildbot\as-builder-2\x-aarch64\llvm-project\libcxx\test\std\algorithms\alg.sorting\alg.merge\pstl.
https://github.com/arichardson approved this pull request.
https://github.com/llvm/llvm-project/pull/105726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
=?utf-8?q?Balázs_Kéri?=
Message-ID:
In-Reply-To:
@@ -5968,11 +5962,21 @@
ASTNodeImporter::VisitTemplateTypeParmDecl(TemplateTypeParmDecl *D) {
}
if (D->hasDefaultArgument()) {
+// Default argument can be "inherited" when it has a reference to the
+// previous d
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`sanitizer-aarch64-linux-fuzzer` running on `sanitizer-buildbot11` while
building `clang` at step 2 "annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/159/builds/4466
Here is the relevant piec
=?utf-8?q?Balázs_Kéri?=
Message-ID:
In-Reply-To:
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/101836
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -503,9 +503,11 @@ void
HLSLExternalSemaSource::defineHLSLTypesWithForwardDeclarations() {
Decl = BuiltinTypeDeclBuilder(*SemaPtr, HLSLNamespace, "RWBuffer")
.addSimpleTemplateParams(*SemaPtr, {"element_type"})
.Record;
+
onCompletion(Decl, [th
@@ -0,0 +1,256 @@
+// RUN: %clang_cc1 -fsyntax-only -fblocks -fcxx-exceptions -std=c++20 -verify
%s
+// These are in a separate file because errors (e.g. incompatible attributes)
currently prevent
+// the FXAnalysis pass from running at all.
+
+// This diagnostic is re-enabled a
Sirraide wrote:
> I believe I have addressed all feedback so far.
Alright; I’ll see if I can do another review tomorrow.
https://github.com/llvm/llvm-project/pull/99656
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/Sirraide updated
https://github.com/llvm/llvm-project/pull/105121
>From 1cc581a3b3af057793c11a862b8facfba2aef926 Mon Sep 17 00:00:00 2001
From: Sirraide
Date: Tue, 20 Aug 2024 18:40:18 +0200
Subject: [PATCH 1/4] [Clang] [Parser] Improve diagnostic for 'friend concept'
---
c
Author: Sirraide
Date: 2024-08-22T23:33:40+02:00
New Revision: 8b5f606612de30ece5e113517decacca0d8ccb35
URL:
https://github.com/llvm/llvm-project/commit/8b5f606612de30ece5e113517decacca0d8ccb35
DIFF:
https://github.com/llvm/llvm-project/commit/8b5f606612de30ece5e113517decacca0d8ccb35.diff
LOG:
https://github.com/Sirraide closed
https://github.com/llvm/llvm-project/pull/105121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
matinraayai wrote:
> > The TargetMachine interface functions addPassesToEmitFile and
> > addPassesToEmitMC now require a reference to an MMI; This IMO breaks the
> > abstraction of the TargetMachine, since an MMI requires a
> > LLVMTargetMachine, and if you have a TargetMachine you should do t
cjappl wrote:
(investigating this issue right now, I'm unfamiliar with the fuzzer, so I'm
trying to figure out if this is my failure or not. Will keep people posted)
https://github.com/llvm/llvm-project/pull/102622
___
cfe-commits mailing list
cfe-com
https://github.com/AlanRosenthal updated
https://github.com/llvm/llvm-project/pull/104868
>From 5f84cc47cde13732ed61eccc0b17f6c420a64ab7 Mon Sep 17 00:00:00 2001
From: Alan Rosenthal
Date: Thu, 22 Aug 2024 21:42:04 +
Subject: [PATCH] [clang-tidy] Update TODO comment check
The doc for googl
https://github.com/vvereschaka updated
https://github.com/llvm/llvm-project/pull/105580
>From b34482f4f9e1273f69d47b2d500989a5c3c857df Mon Sep 17 00:00:00 2001
From: Vladimir Vereschaka
Date: Wed, 21 Aug 2024 13:37:47 -0700
Subject: [PATCH] Allow installation of Clang .cfg files if they where
https://github.com/tahonermann created
https://github.com/llvm/llvm-project/pull/105738
Clang has historically mimicked gcc behavior for header file searching in which
user search paths are ordered before system search paths, user search paths
that duplicate a (later) system search path are ig
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Tom Honermann (tahonermann)
Changes
Clang has historically mimicked gcc behavior for header file searching in which
user search paths are ordered before system search paths, user search paths
that duplicate a (later) system search path ar
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder
`openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building
`clang` at step 10 "Add check check-offload".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/73/builds/4288
Here is the re
Sirraide wrote:
> LLVM Buildbot has detected a new failure on builder
> `openmp-offload-libc-amdgpu-runtime`
Er, if that’s not unrelated then I have no idea what’s going on. I’m pretty
sure we can ignore that.
https://github.com/llvm/llvm-project/pull/105121
__
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff e49068624c48f4d906707b32b31f6a1d561605be
b4b550f2dbf47dbce0acd9388fe3c8c8d1cb7ce9 --e
https://github.com/vvereschaka edited
https://github.com/llvm/llvm-project/pull/105580
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vvereschaka wrote:
There is an example how the clang configuration file can be generated within
the cmake cache file during the build configuration
https://github.com/llvm/llvm-project/blob/911e246fe8fd35bd82fc11db001513a1e2f6990c/clang/cmake/caches/CrossWinToARMLinux.cmake#L92
https://github.c
https://github.com/vvereschaka updated
https://github.com/llvm/llvm-project/pull/105580
>From b34482f4f9e1273f69d47b2d500989a5c3c857df Mon Sep 17 00:00:00 2001
From: Vladimir Vereschaka
Date: Wed, 21 Aug 2024 13:37:47 -0700
Subject: [PATCH] Allow installation of Clang .cfg files if they where
cor3ntin wrote:
yup. Post commit CI is batched, someone's else PR broke it
https://github.com/llvm/llvm-project/pull/105121
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cjappl wrote:
So it's happening in a pass away from the Realtime sanitizer pass, the top of
the stack says:
```
3. Running pass 'Function Pass Manager' on module
'/home/b/sanitizer-aarch64-linux-fuzzer/build/llvm-project/compiler-rt/lib/ubsan_minimal/ubsan_minimal_handlers.cpp'.
4. R
@@ -459,7 +467,412 @@ void SemaHLSL::handleResourceClassAttr(Decl *D, const
ParsedAttr &AL) {
D->addAttr(HLSLResourceClassAttr::Create(getASTContext(), RC, ArgLoc));
}
-void SemaHLSL::handleResourceBindingAttr(Decl *D, const ParsedAttr &AL) {
+struct RegisterBindingFlags {
Sirraide wrote:
> yup. Post commit CI is batched, someone's else PR broke it
Yeah, that’s what I figured, but normally the bot doesn’t comment on the pr if
that’s the case—or at least it didn’t use to do that.
https://github.com/llvm/llvm-project/pull/105121
___
@@ -45,7 +54,7 @@ class TodoCommentCheck::TodoCommentHandler : public
CommentHandler {
private:
TodoCommentCheck &Check;
std::string User;
- llvm::Regex TodoMatch;
+ std::list TodoMatches;
AlanRosenthal wrote:
Hi @njames93, thanks for the review. I've u
@@ -459,7 +467,412 @@ void SemaHLSL::handleResourceClassAttr(Decl *D, const
ParsedAttr &AL) {
D->addAttr(HLSLResourceClassAttr::Create(getASTContext(), RC, ArgLoc));
}
-void SemaHLSL::handleResourceBindingAttr(Decl *D, const ParsedAttr &AL) {
+struct RegisterBindingFlags {
https://github.com/cjappl created
https://github.com/llvm/llvm-project/pull/105744
…r (#102622)"
This reverts commit d010ec6af8162a8ae4e42d2cac5282f83db0ce07.
Build failure: https://lab.llvm.org/buildbot/#/builders/159/builds/4466
>From b663988416adf8be4188c10521db585c234763a0 Mon Sep 17 00:0
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Chris Apple (cjappl)
Changes
…r (#102622)"
This reverts commit d010ec6af8162a8ae4e42d2cac5282f83db0ce07.
Build failure: https://lab.llvm.org/buildbot/#/builders/159/builds/4466
---
Full diff: https://github.com/llvm/llvm-project/
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
@llvm/pr-subscribers-clang
Author: Chris Apple (cjappl)
Changes
…r (#102622)"
This reverts commit d010ec6af8162a8ae4e42d2cac5282f83db0ce07.
Build failure: https://lab.llvm.org/buildbot/#/builders/159/builds/4466
---
Full diff: https://git
Author: Chris Apple
Date: 2024-08-22T15:19:41-07:00
New Revision: a1e9b7e646b76bf844e8a9a101ebd27de11992ff
URL:
https://github.com/llvm/llvm-project/commit/a1e9b7e646b76bf844e8a9a101ebd27de11992ff
DIFF:
https://github.com/llvm/llvm-project/commit/a1e9b7e646b76bf844e8a9a101ebd27de11992ff.diff
L
https://github.com/cjappl closed
https://github.com/llvm/llvm-project/pull/105744
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cjappl wrote:
Out of an abundance of caution I have reverted this. I am still unsure of what
in my code could have caused this failure.
If anyone out there has a bright idea please let me know. I will monitor the
builds for a bit and ensure they are back to green
https://github.com/llvm/llvm
@@ -459,7 +467,506 @@ void SemaHLSL::handleResourceClassAttr(Decl *D, const
ParsedAttr &AL) {
D->addAttr(HLSLResourceClassAttr::Create(getASTContext(), RC, ArgLoc));
}
-void SemaHLSL::handleResourceBindingAttr(Decl *D, const ParsedAttr &AL) {
+struct RegisterBindingFlags {
@@ -0,0 +1,76 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o -
-fsyntax-only %s -verify
+
+// This test validates the diagnostics that are emitted when a variable with a
"resource" type
+// is bound to a register using the register annotation
+
+// expe
@@ -5272,22 +5272,46 @@ the configuration (without a prefix: ``Auto``).
.. _ReflowComments:
-**ReflowComments** (``Boolean``) :versionbadge:`clang-format 3.8` :ref:`¶
`
- If ``true``, clang-format will attempt to re-flow comments. That is it
- will touch a comment and *ref
@@ -0,0 +1,71 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o -
-fsyntax-only %s -verify
+
+// This test validates the diagnostics that are emitted when a variable with a
"resource" type
+// is bound to a register using the register annotation
+
+/*
+tem
https://github.com/andykaylor created
https://github.com/llvm/llvm-project/pull/105746
Change the handling of -ffp-contract=fast such that the contract
semantics described in the IR are always respected. The front end was
already generating IR that enabled or disabled contraction as requested
by
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
@llvm/pr-subscribers-clang-driver
Author: Andy Kaylor (andykaylor)
Changes
Change the handling of -ffp-contract=fast such that the contract
semantics described in the IR are always respected. The front end was
already generating IR that ena
https://github.com/damyanp requested changes to this pull request.
A few open issues I'd like to see addressed before approving this:
* https://github.com/llvm/llvm-project/pull/97103#discussion_r1720126674
* https://github.com/llvm/llvm-project/pull/97103#discussion_r1722532927
* https://github
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 172c4a4a147833f1c08df1555f3170aa9ccb6cbe
973e7fb1a09f5479f88616e19642a71edc977b4a --e
llvm-ci wrote:
LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux`
running on `sanitizer-buildbot2` while building `libunwind` at step 2
"annotate".
Full details are available at:
https://lab.llvm.org/buildbot/#/builders/66/builds/3020
Here is the relevant piece of t
@@ -551,24 +541,21 @@ getHLSLResourceAttrFromEitherDecl(VarDecl *VD,
// the resource attr could be on the record decl itself or on one of
// its fields (the resource handle, most commonly)
-const auto *Attr = TheRecordDecl->getAttr();
+const auto *Attr = TheRec
@@ -0,0 +1,76 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o -
-fsyntax-only %s -verify
+
+// This test validates the diagnostics that are emitted when a variable with a
"resource" type
+// is bound to a register using the register annotation
+
+// expe
@@ -459,7 +467,408 @@ void SemaHLSL::handleResourceClassAttr(Decl *D, const
ParsedAttr &AL) {
D->addAttr(HLSLResourceClassAttr::Create(getASTContext(), RC, ArgLoc));
}
-void SemaHLSL::handleResourceBindingAttr(Decl *D, const ParsedAttr &AL) {
+struct RegisterBindingFlags {
https://github.com/aaronpuchert edited
https://github.com/llvm/llvm-project/pull/99919
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aaronpuchert commented:
Otherwise looks good to me. The old terminology is still heavily used
internally, but I found the code still readable, so I don't think we need to
rewrite all of it.
https://github.com/llvm/llvm-project/pull/99919
_
@@ -887,7 +887,7 @@ class LockableFactEntry : public FactEntry {
}
};
-class ScopedLockableFactEntry : public FactEntry {
+class ScopedCapabilityFactEntry : public FactEntry {
aaronpuchert wrote:
The other derived class is still called `LockableFactEntry`.
@@ -0,0 +1,71 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o -
-fsyntax-only %s -verify
+
+// This test validates the diagnostics that are emitted when a variable with a
"resource" type
+// is bound to a register using the register annotation
+
+/*
+tem
@@ -551,24 +541,21 @@ getHLSLResourceAttrFromEitherDecl(VarDecl *VD,
// the resource attr could be on the record decl itself or on one of
// its fields (the resource handle, most commonly)
-const auto *Attr = TheRecordDecl->getAttr();
+const auto *Attr = TheRec
https://github.com/efriedma-quic edited
https://github.com/llvm/llvm-project/pull/105746
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/efriedma-quic commented:
Is the backend actually ready for this? Looking quickly at the backend, it
looks like target-independent code is fine, but some of the target-specific
code doesn't respect the "contract" flag on instructions.
https://github.com/llvm/llvm-project/pul
@@ -348,20 +348,8 @@ static bool initTargetOptions(DiagnosticsEngine &Diags,
.Default(llvm::FloatABI::Default);
// Set FP fusion mode.
- switch (LangOpts.getDefaultFPContractMode()) {
- case LangOptions::FPM_Off:
-// Preserve any contraction performed by the
@@ -0,0 +1,76 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o -
-fsyntax-only %s -verify
+
+// This test validates the diagnostics that are emitted when a variable with a
"resource" type
+// is bound to a register using the register annotation
+
+// expe
@@ -551,24 +541,21 @@ getHLSLResourceAttrFromEitherDecl(VarDecl *VD,
// the resource attr could be on the record decl itself or on one of
// its fields (the resource handle, most commonly)
-const auto *Attr = TheRecordDecl->getAttr();
+const auto *Attr = TheRec
@@ -0,0 +1,76 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o -
-fsyntax-only %s -verify
+
+// This test validates the diagnostics that are emitted when a variable with a
"resource" type
+// is bound to a register using the register annotation
+
+// expe
@@ -182,18 +182,8 @@ void LangOptions::setLangDefaults(LangOptions &Opts,
Language Lang,
Opts.HIP = Lang == Language::HIP;
Opts.CUDA = Lang == Language::CUDA || Opts.HIP;
- if (Opts.HIP) {
-// HIP toolchain does not support 'Fast' FPOpFusion in backends since it
-
@@ -3178,6 +3178,13 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
StringRef Val = A->getValue();
if (Val == "fast" || Val == "on" || Val == "off" ||
Val == "fast-honor-pragmas") {
+// fast-honor-pragmas is depreca
@@ -68,35 +68,12 @@
// RUN: -O3 -target-cpu gfx906 -o - -x ir %t.ll \
// RUN: | FileCheck -check-prefixes=COMMON,AMD-OPT-FASTSTD %s
-// Explicit -ffp-contract=fast-honor-pragmas
-// In IR, fmul/fadd instructions with contract flag are emitted.
-// In backend
-//nvptx/a
@@ -0,0 +1,76 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -x hlsl -o -
-fsyntax-only %s -verify
+
+// This test validates the diagnostics that are emitted when a variable with a
"resource" type
+// is bound to a register using the register annotation
+
+// expe
@@ -45,7 +45,7 @@ void test3(packedfloat3 *p) {
*p = (packedfloat3) { 3.2f, 2.3f, 0.1f };
}
// CHECK: @test3(
-// CHECK: store <4 x float> {{.*}}, align 4
+// CHECK: store <3 x float> {{.*}}, align 4
efriedma-quic wrote:
Even if we can prove it doesn't trap,
@@ -459,7 +467,408 @@ void SemaHLSL::handleResourceClassAttr(Decl *D, const
ParsedAttr &AL) {
D->addAttr(HLSLResourceClassAttr::Create(getASTContext(), RC, ArgLoc));
}
-void SemaHLSL::handleResourceBindingAttr(Decl *D, const ParsedAttr &AL) {
+struct RegisterBindingFlags {
aaronpuchert wrote:
> > Yeah, it's a tricky question. On one hand there have been previous issues
> > like #42194 (which this would basically address), and it would definitely
> > improve consistency and prevent beginner's mistakes. On the other hand it
> > seems useful to allow adding attribu
https://github.com/damyanp approved this pull request.
Thank you!
https://github.com/llvm/llvm-project/pull/97103
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
Also https://lab.llvm.org/buildbot/#/builders/164/builds/2291
https://github.com/llvm/llvm-project/pull/104906
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
andykaylor wrote:
> Is the backend actually ready for this? Looking quickly at the backend, it
> looks like target-independent code is fine, but some of the target-specific
> code doesn't respect the "contract" flag on instructions.
Doesn't respect it in what way? Do you mean it doesn't attemp
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/105752
Revert as it breaks libc++ tests, see #104906.
This reverts commit c368a720a0b40bb8fe4aff3971fe9a7009c85aa6.
>From 1482dc3f18243d09e7d205b724c76d69c0284b99 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date:
Author: Vitaly Buka
Date: 2024-08-22T16:38:19-07:00
New Revision: 1df15042bdda3817827e39c772525a4a24c1adbe
URL:
https://github.com/llvm/llvm-project/commit/1df15042bdda3817827e39c772525a4a24c1adbe
DIFF:
https://github.com/llvm/llvm-project/commit/1df15042bdda3817827e39c772525a4a24c1adbe.diff
L
https://github.com/vitalybuka closed
https://github.com/llvm/llvm-project/pull/105752
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Vitaly Buka (vitalybuka)
Changes
Revert as it breaks libc++ tests, see #104906.
This reverts commit c368a720a0b40bb8fe4aff3971fe9a7009c85aa6.
---
Patch is 25.78 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/l
https://github.com/vitalybuka created
https://github.com/llvm/llvm-project/pull/105753
... just for visibility
>From 04376ece0618912d85a9a52a5f00f3eb3aa63c30 Mon Sep 17 00:00:00 2001
From: Vitaly Buka
Date: Thu, 22 Aug 2024 16:38:31 -0700
Subject: [PATCH] =?UTF-8?q?Revert=20"Revert=20"[clang]=
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Vitaly Buka (vitalybuka)
Changes
... just for visibility
---
Patch is 25.79 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/105753.diff
3 Files Affected:
- (modified) clang/docs/ReleaseNotes.
@@ -3178,6 +3178,13 @@ static void RenderFloatingPointOptions(const ToolChain
&TC, const Driver &D,
StringRef Val = A->getValue();
if (Val == "fast" || Val == "on" || Val == "off" ||
Val == "fast-honor-pragmas") {
+// fast-honor-pragmas is depreca
https://github.com/connieyzhu created
https://github.com/llvm/llvm-project/pull/105754
This patch rewrites tests in clang and compiler-rt that uses bash command
substitution syntax $() to execute the dirname command. This is done so that
the tests can be run using lit's internal shell.
Fixes
https://github.com/vitalybuka edited
https://github.com/llvm/llvm-project/pull/105753
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-driver
Author: Connie Zhu (connieyzhu)
Changes
This patch rewrites tests in clang and compiler-rt that uses bash command
substitution syntax $() to execute the dirname command. This is done so that
the tests can be run
efriedma-quic wrote:
It doesn't fuse unless AllowFPOpFusion is set.
https://github.com/llvm/llvm-project/pull/105746
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -68,35 +68,12 @@
// RUN: -O3 -target-cpu gfx906 -o - -x ir %t.ll \
// RUN: | FileCheck -check-prefixes=COMMON,AMD-OPT-FASTSTD %s
-// Explicit -ffp-contract=fast-honor-pragmas
-// In IR, fmul/fadd instructions with contract flag are emitted.
-// In backend
-//nvptx/a
h-vetinari wrote:
Gentle ping on this (I don't have the commit bit).
https://github.com/llvm/llvm-project/pull/104866
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cjappl wrote:
Tests continue to fail after reverting this:
https://lab.llvm.org/buildbot/#/builders/159/builds/4474
I am trying to bisect locally, I will likely reland this with no modifications
tomorrow if it continues to look like this did not contribute to the build
failures.
https://git
Sirraide wrote:
I haven’t looked too much into this, but yeah, this sounds like it might have
just been an unrelated CI failure
https://github.com/llvm/llvm-project/pull/102622
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm
cjappl wrote:
Thanks for taking a look @Sirraide , greatly appreciated.
https://github.com/llvm/llvm-project/pull/102622
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
201 - 300 of 353 matches
Mail list logo
