[clang] [SPARC][Driver] Add -m(no-)v8plus flags handling (PR #98713)

2024-08-15 Thread via cfe-commits
https://github.com/koachan closed https://github.com/llvm/llvm-project/pull/98713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] update default validator version to 1.8. (PR #104040)

2024-08-15 Thread Cooper Partin via cfe-commits
https://github.com/coopp approved this pull request. Looks good. https://github.com/llvm/llvm-project/pull/104040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] update default validator version to 1.8. (PR #104040)

2024-08-15 Thread Damyan Pepper via cfe-commits
damyanp wrote: How does this relate to #102963? https://github.com/llvm/llvm-project/pull/104040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] update default validator version to 1.8. (PR #104040)

2024-08-15 Thread Xiang Li via cfe-commits
python3kgae wrote: > How does this relate to #102963? It will make default 1.8 so default case will work. But we still need to have a plan for what to do with -validator-version. https://github.com/llvm/llvm-project/pull/104040 ___ cfe-commits mailing

[clang] [Clang] fix generic lambda inside requires-clause of friend function template (PR #99813)

2024-08-15 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. Thinking about it more, this is probably fine @AaronBallman and @mizvekov for extra pairs of eyes https://github.com/llvm/llvm-project/pull/99813 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [llvm] [BPF] introduce `__attribute__((bpf_fastcall))` (PR #101228)

2024-08-15 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Thank you (all) for the explanations, that was helpful -- it addressed my concerns with the design. https://github.com/llvm/llvm-project/pull/101228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [Clang] Overflow Pattern Exclusions (PR #100272)

2024-08-15 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: We should revert this patch. It breaks mupltiple bots, introducing Msan reports. Also on a first look I don't like `-fsanitize-pattern-exclusion=` at all, very inconsistent. I assumed we agreed to splitting sanitizers into smaller sets? I would like to know why we need to intr

[clang] [llvm] [BPF] introduce `__attribute__((bpf_fastcall))` (PR #101228)

2024-08-15 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,7 @@ +// REQUIRES: bpf-registered-target +// RUN: %clang_cc1 %s -triple bpf -verify + +__attribute__((bpf_fastcall)) int var; // expected-warning {{'bpf_fastcall' attribute only applies to functions and function pointers}} + +__attribute__((bpf_fastcall)) void func();

[clang] [llvm] [BPF] introduce `__attribute__((bpf_fastcall))` (PR #101228)

2024-08-15 Thread Aaron Ballman via cfe-commits
@@ -2189,6 +2189,14 @@ def BTFTypeTag : TypeAttr { let LangOpts = [COnly]; } +def BPFFastCall : InheritableAttr, + TargetSpecificAttr { + let Spellings = [GCC<"bpf_fastcall">]; + let Subjects = SubjectList<[FunctionLike]>; AaronBallman wro

[clang] [llvm] [BPF] introduce `__attribute__((bpf_fastcall))` (PR #101228)

2024-08-15 Thread Aaron Ballman via cfe-commits
@@ -2189,6 +2189,14 @@ def BTFTypeTag : TypeAttr { let LangOpts = [COnly]; } +def BPFFastCall : InheritableAttr, + TargetSpecificAttr { + let Spellings = [GCC<"bpf_fastcall">]; AaronBallman wrote: Does GCC support this attribute with this

[clang] Implement resource binding type prefix mismatch diagnostic infrastructure (PR #97103)

2024-08-15 Thread Joshua Batista via cfe-commits
@@ -459,7 +467,506 @@ void SemaHLSL::handleResourceClassAttr(Decl *D, const ParsedAttr &AL) { D->addAttr(HLSLResourceClassAttr::Create(getASTContext(), RC, ArgLoc)); } -void SemaHLSL::handleResourceBindingAttr(Decl *D, const ParsedAttr &AL) { +struct RegisterBindingFlags {

[clang] [clang][Interp] Add scopes to conditional operator subexpressions (PR #104418)

2024-08-15 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/104418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Clang] Overflow Pattern Exclusions (#100272)" (PR #104472)

2024-08-15 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/104472 This reverts commit 9a666deecb9ff6ca3a6b12e6c2877e19b74b54da. >From 29256f6703beafdfbb74df08c8358301a5873885 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Thu, 15 Aug 2024 10:09:35 -0700 Subject: [PATCH]

[clang] Revert "[Clang] Overflow Pattern Exclusions (#100272)" (PR #104472)

2024-08-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Vitaly Buka (vitalybuka) Changes This reverts commit 9a666deecb9ff6ca3a6b12e6c2877e19b74b54da. --- Patch is 24.83 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/104472.diff 16 Files A

[clang] Revert "[Clang] Overflow Pattern Exclusions (#100272)" (PR #104472)

2024-08-15 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/104472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Clang] Overflow Pattern Exclusions (#100272)" (PR #104472)

2024-08-15 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/104472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Clang] Overflow Pattern Exclusions (#100272)" (PR #104472)

2024-08-15 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/104472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Clang] Overflow Pattern Exclusions (#100272)" (PR #104472)

2024-08-15 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/104472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Clang] Overflow Pattern Exclusions (#100272)" (PR #104472)

2024-08-15 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/104472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e398da2 - Revert "[Clang] Overflow Pattern Exclusions (#100272)"

2024-08-15 Thread Thurston Dang via cfe-commits
Author: Thurston Dang Date: 2024-08-15T10:18:52-07:00 New Revision: e398da2b37fcc2696e1f5c661e5372844f4e1550 URL: https://github.com/llvm/llvm-project/commit/e398da2b37fcc2696e1f5c661e5372844f4e1550 DIFF: https://github.com/llvm/llvm-project/commit/e398da2b37fcc2696e1f5c661e5372844f4e1550.diff

[clang] [Clang] Implement C++26’s P2893R3 ‘Variadic friends’ (PR #101448)

2024-08-15 Thread via cfe-commits
@@ -17509,8 +17528,17 @@ Decl *Sema::ActOnFriendTypeDecl(Scope *S, const DeclSpec &DS, if (TheDeclarator.isInvalidType()) return nullptr; - if (DiagnoseUnexpandedParameterPack(Loc, TSI, UPPC_FriendDeclaration)) + // If '...' is present, the type must contain an unexpa

[clang] [Clang][Sema] Use the correct lookup context when building overloaded 'operator->' in the current instantiation (PR #104458)

2024-08-15 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/104458 >From 9f4fb3fb8df6d0981723ce9b8da809d9f2284348 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Thu, 15 Aug 2024 11:27:34 -0400 Subject: [PATCH 1/2] [Clang][Sema] Use the correct lookup context when

[clang] [Clang] Implement C++26’s P2893R3 ‘Variadic friends’ (PR #101448)

2024-08-15 Thread via cfe-commits
Sirraide wrote: > I’ll get those removed from this pr. Also done. I think that’s everything now? https://github.com/llvm/llvm-project/pull/101448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [clang-format] Adjust requires clause wrapping (#101550) (PR #102078)

2024-08-15 Thread Nathan Sidwell via cfe-commits
urnathan wrote: @mydeveloperday, have I addressed your request -- I think so, as tests are no longer being changed. https://github.com/llvm/llvm-project/pull/102078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] Revert "[Clang] Overflow Pattern Exclusions (#100272)" (PR #104472)

2024-08-15 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/104472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[Clang] Overflow Pattern Exclusions (#100272)" (PR #104472)

2024-08-15 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: Already reverted. https://github.com/llvm/llvm-project/pull/104472 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement C++26’s P2893R3 ‘Variadic friends’ (PR #101448)

2024-08-15 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/101448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Overflow Pattern Exclusions (PR #100272)

2024-08-15 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: Before reland, please include me into review I'd like to understand why `-fsanitize-pattern-exclusion=all` is better than something like `-fno-sanitize=overflow-pattern-all` https://github.com/llvm/llvm-project/pull/100272 ___ cfe-co

[clang] clang/AMDGPU: Emit atomicrmw for __builtin_amdgcn_global_atomic_fadd_{f32|f64} (PR #96872)

2024-08-15 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm updated https://github.com/llvm/llvm-project/pull/96872 >From 099aec4c343868155104109c66c99d97ae669c4c Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Tue, 11 Jun 2024 10:58:44 +0200 Subject: [PATCH 1/2] clang/AMDGPU: Emit atomicrmw for __builtin_amdgcn_global_ato

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-15 Thread Doug Wyatt via cfe-commits
@@ -0,0 +1,256 @@ +// RUN: %clang_cc1 -fsyntax-only -fblocks -fcxx-exceptions -std=c++20 -verify %s +// These are in a separate file because errors (e.g. incompatible attributes) currently prevent +// the FXAnalysis pass from running at all. + +// This diagnostic is re-enabled a

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-15 Thread Doug Wyatt via cfe-commits
https://github.com/dougsonos edited https://github.com/llvm/llvm-project/pull/99656 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL][Doc] Document multi-argument resolution (PR #104474)

2024-08-15 Thread Chris B via cfe-commits
https://github.com/llvm-beanz created https://github.com/llvm/llvm-project/pull/104474 This updates the expected diffferences document to capture the difference in multi-argument overload resolution between Clang and DXC. Fixes #99530 >From d00a28b19bebec1f48144f777ca60bff94190650 Mon Sep 17

[clang] [llvm] [RISCV] Add Hazard3 CPU (PR #102452)

2024-08-15 Thread Min-Yih Hsu via cfe-commits
mshockwave wrote: > So for this particular PR, we just need a name people are happy with (perhaps > check if the vendor has a preference?). Something like `-mcpu=rp2350-hazard3` > perhaps? +1 on `-mcpu=rp2350-hazard3` over `-mcpu=raspberrypi-rp2350` because the former is more specific to the

[clang] [HLSL][Doc] Document multi-argument resolution (PR #104474)

2024-08-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Chris B (llvm-beanz) Changes This updates the expected diffferences document to capture the difference in multi-argument overload resolution between Clang and DXC. Fixes #99530 --- Full diff: https://github.com/llvm/llvm-project/pull/1044

[clang] [Clang] Fix sema checks thinking kernels aren't kernels (PR #104460)

2024-08-15 Thread Artem Belevich via cfe-commits
@@ -7163,24 +7163,27 @@ void Sema::ProcessDeclAttributeList( } else if (const auto *A = D->getAttr()) { Diag(D->getLocation(), diag::err_opencl_kernel_attr) << A; D->setInvalidDecl(); -} else if (!D->hasAttr()) { - if (const auto *A = D->getAttr()) { -

[clang] [Clang] Fix sema checks thinking kernels aren't kernels (PR #104460)

2024-08-15 Thread Artem Belevich via cfe-commits
@@ -7163,24 +7163,27 @@ void Sema::ProcessDeclAttributeList( } else if (const auto *A = D->getAttr()) { Diag(D->getLocation(), diag::err_opencl_kernel_attr) << A; D->setInvalidDecl(); -} else if (!D->hasAttr()) { - if (const auto *A = D->getAttr()) { -

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #96240)

2024-08-15 Thread Thurston Dang via cfe-commits
thurstond wrote: One of the tests is failing: ``` compiler-rt/test/ubsan/TestCases/Integer/bit-int-pass.c:31:15: error: CHECK-NOT: excluded string found in input // CHECK-NOT: runtime error: ^ :1:110: note: found here compiler-rt/test/ubsan/TestCases/Integer/bit-int-pass.c:11:10: r

[clang] [HLSL] update default validator version to 1.8. (PR #104040)

2024-08-15 Thread Damyan Pepper via cfe-commits
damyanp wrote: > > How does this relate to #102963? > > It will make default 1.8 so default case will work. But we still need to have > a plan for what to do with -validator-version. Chatting with @bharadwajy, it sounds like this PR should also fix #102963. https://github.com/llvm/llvm-projec

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-15 Thread Doug Wyatt via cfe-commits
@@ -0,0 +1,256 @@ +// RUN: %clang_cc1 -fsyntax-only -fblocks -fcxx-exceptions -std=c++20 -verify %s +// These are in a separate file because errors (e.g. incompatible attributes) currently prevent +// the FXAnalysis pass from running at all. + +// This diagnostic is re-enabled a

[clang] 7332713 - [Clang] prevent null explicit object argument from being deduced (#104328)

2024-08-15 Thread via cfe-commits
Author: Oleksandr T. Date: 2024-08-15T19:47:14+02:00 New Revision: 7332713b8eea9bb84d8481376f62b8de7c0ddb3a URL: https://github.com/llvm/llvm-project/commit/7332713b8eea9bb84d8481376f62b8de7c0ddb3a DIFF: https://github.com/llvm/llvm-project/commit/7332713b8eea9bb84d8481376f62b8de7c0ddb3a.diff

[clang] [Clang] prevent null explicit object argument from being deduced (PR #104328)

2024-08-15 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/104328 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] update default validator version to 1.8. (PR #104040)

2024-08-15 Thread Xiang Li via cfe-commits
https://github.com/python3kgae edited https://github.com/llvm/llvm-project/pull/104040 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] update default validator version to 1.8. (PR #104040)

2024-08-15 Thread Xiang Li via cfe-commits
python3kgae wrote: > > > How does this relate to #102963? > > > > > > It will make default 1.8 so default case will work. But we still need to > > have a plan for what to do with -validator-version. > > Chatting with @bharadwajy, it sounds like this PR should also fix #102963. Added Fixes fo

[clang] [clang][driver] Don't warn when -S and -c are used together without -fsyntax-only (PR #104477)

2024-08-15 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi created https://github.com/llvm/llvm-project/pull/104477 Claim `-c` when using `-S`, so that we don't warn for unused arguments when they are used together without `-fsyntax-only`. Fixes #104347 >From 0af4f441447f39df7f496e62f8620d9c8404a5d2 Mon Sep 17 00:00:00 2001

[clang] [clang][driver] Don't warn when -S and -c are used together without -fsyntax-only (PR #104477)

2024-08-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Paul Kirth (ilovepi) Changes Claim `-c` when using `-S`, so that we don't warn for unused arguments when they are used together without `-fsyntax-only`. Fixes #104347 --- Full diff: https://github.com/llvm/llvm-project/pull/104477.diff

[clang] [Clang] Add wraps attribute (for granular integer overflow handling) (PR #86618)

2024-08-15 Thread Breno Leitao via cfe-commits
leitao wrote: Thanks for working on this @JustinStitt . This might be useful to help the code to be explict about fields that are expected to wrap, and tag it properly. https://github.com/llvm/llvm-project/pull/86618 ___ cfe-commits mailing list cfe-c

[clang] [clang][driver] Don't warn when -S and -c are used together without -fsyntax-only (PR #104477)

2024-08-15 Thread Paul Kirth via cfe-commits
@@ -1,7 +1,14 @@ // RUN: %clang --target=x86_64 -fsyntax-only -E %s 2>&1 | FileCheck %s --check-prefix=CHECK-PP // RUN: %clang --target=x86_64 -fsyntax-only -S %s 2>&1 | FileCheck %s --check-prefix=CHECK-ASM // RUN: %clang --target=x86_64 -fsyntax-only -c %s 2>&1 | FileCheck

[clang] [clang][driver] Don't warn when -S and -c are used together without -fsyntax-only (PR #104477)

2024-08-15 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff d9b9ae6ba9d85114c61878b783d4eac816fd06a6 0af4f441447f39df7f496e62f8620d9c8404a5d2 --e

[clang] [clang][driver] Don't warn when -S and -c are used together without -fsyntax-only (PR #104477)

2024-08-15 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/104477 >From 0af4f441447f39df7f496e62f8620d9c8404a5d2 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Thu, 15 Aug 2024 10:52:13 -0700 Subject: [PATCH 1/2] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UTF-

[clang] [Clang] prevent null explicit object argument from being deduced (PR #104328)

2024-08-15 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-hip-vega20` running on `hip-vega20-0` while building `clang` at step 3 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/123/builds/3747 Here is the relevant piece of the build log for

[clang] [HLSL] Add __is_scalarized_layout_compatible (PR #102227)

2024-08-15 Thread Chris B via cfe-commits
llvm-beanz wrote: > Is this the expected behaviour: > > ```c++ > struct EmptyPadding : Empty { Empty e; int X; }; > struct Repeated : Empty, DerivedEmpty { int X; }; // expected-warning > {{inaccessible due to ambiguity}} > _Static_assert(sizeof(EmptyPadding) == 8, ""); > _Static_assert(sizeof(

[clang] 75ea8e8 - [clang][Interp] Call move function for certain primitive types (#104437)

2024-08-15 Thread via cfe-commits
Author: Timm Baeder Date: 2024-08-15T19:59:55+02:00 New Revision: 75ea8e803a6560b5e16644bb25d6340926156503 URL: https://github.com/llvm/llvm-project/commit/75ea8e803a6560b5e16644bb25d6340926156503 DIFF: https://github.com/llvm/llvm-project/commit/75ea8e803a6560b5e16644bb25d6340926156503.diff L

[clang] [clang][Interp] Call move function for certain primitive types (PR #104437)

2024-08-15 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/104437 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][driver] Don't warn when -S and -c are used together without -fsyntax-only (PR #104477)

2024-08-15 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/104477 >From 0af4f441447f39df7f496e62f8620d9c8404a5d2 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Thu, 15 Aug 2024 10:52:13 -0700 Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UTF-

[clang] [clang][driver] Don't warn when -S and -c are used together without -fsyntax-only (PR #104477)

2024-08-15 Thread Paul Kirth via cfe-commits
@@ -377,8 +377,10 @@ phases::ID Driver::getFinalPhase(const DerivedArgList &DAL, // -S only runs up to the backend. } else if ((PhaseArg = DAL.getLastArg(options::OPT_S))) { FinalPhase = phases::Backend; +// Avoid unused argument warnings when combining -S and -c. +

[clang] [llvm] [ARM] musttail fixes (PR #102896)

2024-08-15 Thread Eli Friedman via cfe-commits
@@ -5085,7 +5085,7 @@ RValue CodeGenFunction::EmitCall(const CGFunctionInfo &CallInfo, RawAddress SRetAlloca = RawAddress::invalid(); llvm::Value *UnusedReturnSizePtr = nullptr; if (RetAI.isIndirect() || RetAI.isInAlloca() || RetAI.isCoerceAndExpand()) { -if (IsVirtu

[clang] [clang][llvm-lit] Rewrite constexpr vectors test to use element access (PR #102757)

2024-08-15 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/102757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][llvm-lit] Rewrite constexpr vectors test to use element access (PR #102757)

2024-08-15 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/102757 >From 7c594e09860fd1be7d66a7c3f99d079267581c11 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 10 Aug 2024 16:54:33 +0200 Subject: [PATCH] [clang][llvm-lit] Rewrite constexpr vectors test to use ele

[clang] [clang][llvm-lit] Rewrite constexpr vectors test to use element access (PR #102757)

2024-08-15 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/102757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][llvm-lit] Rewrite constexpr vectors test to use element access (PR #102757)

2024-08-15 Thread Amr Hesham via cfe-commits
https://github.com/AmrDeveloper updated https://github.com/llvm/llvm-project/pull/102757 >From 7c0c21c60b70ee2970e1fa5ed414529b5bd5bc23 Mon Sep 17 00:00:00 2001 From: AmrDeveloper Date: Sat, 10 Aug 2024 16:54:33 +0200 Subject: [PATCH] [clang][llvm-lit] Rewrite constexpr vectors test to use ele

[clang] 7493ea2 - [test]Fix test error due to CRT dependency (#104462)

2024-08-15 Thread via cfe-commits
Author: earnol Date: 2024-08-15T14:11:27-04:00 New Revision: 7493ea22f8027dc163ca521a71150d264891853c URL: https://github.com/llvm/llvm-project/commit/7493ea22f8027dc163ca521a71150d264891853c DIFF: https://github.com/llvm/llvm-project/commit/7493ea22f8027dc163ca521a71150d264891853c.diff LOG: [

[clang] [compiler-rt] [test]Fix test error due to CRT dependency (PR #104462)

2024-08-15 Thread via cfe-commits
https://github.com/earnol closed https://github.com/llvm/llvm-project/pull/104462 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #96240)

2024-08-15 Thread via cfe-commits
earnol wrote: On what platform this failure is observed? https://github.com/llvm/llvm-project/pull/96240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #96240)

2024-08-15 Thread via cfe-commits
earnol wrote: > One of the tests is failing: > > ``` > $ LIT_FILTER=bit-int-pass ninja check-ubsan > > compiler-rt/test/ubsan/TestCases/Integer/bit-int-pass.c:31:15: error: > CHECK-NOT: excluded string found in input > // CHECK-NOT: runtime error: > ^ > :1:110: note: found here >

[clang] [Clang] prevent null explicit object argument from being deduced (PR #104328)

2024-08-15 Thread Matheus Izvekov via cfe-commits
@@ -4462,6 +4462,9 @@ TemplateDeductionResult Sema::DeduceTemplateArguments( ParamTypesForArgChecking.push_back(ParamType); if (ParamIdx == 0 && HasExplicitObject) { +if (ObjectType.isNull()) + return TemplateDeductionResult::InvalidExplicitArgumen

[clang] [clang] Handle tm mangling on Solaris in PPMacroExpansion.cpp (PR #100724)

2024-08-15 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: The mangler is in clang/lib/AST/ItaniumMangle.cpp; maybe look at CXXNameMangler::mangleStandardSubstitution. https://github.com/llvm/llvm-project/pull/100724 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #96240)

2024-08-15 Thread Thurston Dang via cfe-commits
thurstond wrote: > > One of the tests is failing: > > ``` > > $ LIT_FILTER=bit-int-pass ninja check-ubsan > > > > compiler-rt/test/ubsan/TestCases/Integer/bit-int-pass.c:31:15: error: > > CHECK-NOT: excluded string found in input > > // CHECK-NOT: runtime error: > > ^ > > :1:110:

[clang] [clang][driver] Don't warn when -S and -c are used together without -fsyntax-only (PR #104477)

2024-08-15 Thread Fangrui Song via cfe-commits
MaskRay wrote: > Fixes https://github.com/llvm/llvm-project/issues/104347 I made a comment on #104347 . The warning for `-S -c` works as intended. https://github.com/llvm/llvm-project/pull/104477 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [Clang] prevent null explicit object argument from being deduced (PR #104328)

2024-08-15 Thread Matheus Izvekov via cfe-commits
@@ -4462,6 +4462,9 @@ TemplateDeductionResult Sema::DeduceTemplateArguments( ParamTypesForArgChecking.push_back(ParamType); if (ParamIdx == 0 && HasExplicitObject) { +if (ObjectType.isNull()) + return TemplateDeductionResult::InvalidExplicitArgumen

[clang] [llvm] [mlir] [APInt] Assert correct values in APInt constructor (PR #80309)

2024-08-15 Thread Craig Topper via cfe-commits
@@ -2142,7 +2142,9 @@ ScheduleDAGSDNodes *SelectionDAGISel::CreateScheduler() { bool SelectionDAGISel::CheckAndMask(SDValue LHS, ConstantSDNode *RHS, int64_t DesiredMaskS) const { const APInt &ActualMask = RHS->getAPIntValue(); - const API

[clang] Implement resource binding type prefix mismatch diagnostic infrastructure (PR #97103)

2024-08-15 Thread Joshua Batista via cfe-commits
@@ -459,7 +467,506 @@ void SemaHLSL::handleResourceClassAttr(Decl *D, const ParsedAttr &AL) { D->addAttr(HLSLResourceClassAttr::Create(getASTContext(), RC, ArgLoc)); } -void SemaHLSL::handleResourceBindingAttr(Decl *D, const ParsedAttr &AL) { +struct RegisterBindingFlags {

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-15 Thread Doug Wyatt via cfe-commits
@@ -4914,6 +4920,78 @@ class FunctionEffectsRef { void dump(llvm::raw_ostream &OS) const; }; +/// A mutable set of FunctionEffect::Kind. +class FunctionEffectKindSet { dougsonos wrote: For now I've left the special iterator but replaced the manual bit-twidd

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-15 Thread Doug Wyatt via cfe-commits
@@ -15012,6 +14992,12 @@ class Sema final : public SemaBase { return hasAcceptableDefinition(D, &Hidden, Kind); } + /// Try to parse the conditional expression attached to an effect attribute + /// (e.g. 'nonblocking'). (c.f. Sema::ActOnNoexceptSpec). Return an empty +

[clang] [HLSL] Add __is_scalarized_layout_compatible (PR #102227)

2024-08-15 Thread Chris B via cfe-commits
@@ -1142,3 +1142,85 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { } return false; } + +static void BuildFlattenedTypeList(QualType BaseTy, + llvm::SmallVectorImpl &List) { + llvm::SmallVector WorkList

[clang] [llvm] [RISCV] Add Hazard3 CPU (PR #102452)

2024-08-15 Thread Sam Elliott via cfe-commits
lenary wrote: I've reached out to Luke to ask his/RPi's opinion (but I think he might be away at the moment, so a reply might be slow). My preference remains `raspberrypi-rp2350` because it matches our `-` approach taken so far (for everything except rocket). https://github.com/llvm/llvm-proj

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-15 Thread via cfe-commits
@@ -15012,6 +14992,12 @@ class Sema final : public SemaBase { return hasAcceptableDefinition(D, &Hidden, Kind); } + /// Try to parse the conditional expression attached to an effect attribute + /// (e.g. 'nonblocking'). (c.f. Sema::ActOnNoexceptSpec). Return an empty +

[clang] [HLSL] Add __is_scalarized_layout_compatible (PR #102227)

2024-08-15 Thread Chris B via cfe-commits
@@ -1142,3 +1142,85 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { } return false; } + +static void BuildFlattenedTypeList(QualType BaseTy, + llvm::SmallVectorImpl &List) { + llvm::SmallVector WorkList

[clang] nonblocking/nonallocating attributes: 2nd pass caller/callee analysis (PR #99656)

2024-08-15 Thread via cfe-commits
Sirraide wrote: @dougsonos Maybe you’ve just not pushed that change yet, but remember to put an entry for `SemaFunctionEffects.cpp` in the table of contents at the start of the `Sema` class definition. https://github.com/llvm/llvm-project/pull/99656

[clang] [HLSL] Flesh out basic type typedefs (PR #104479)

2024-08-15 Thread Chris B via cfe-commits
https://github.com/llvm-beanz created https://github.com/llvm/llvm-project/pull/104479 We had a few missing typedefs that are supported by DXC. Specifically 1-element vectors, size-explicit 32-bit types and size-explicit floating point types. This adds the typedefs and a test file that just ve

[clang] [HLSL] Flesh out basic type typedefs (PR #104479)

2024-08-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Chris B (llvm-beanz) Changes We had a few missing typedefs that are supported by DXC. Specifically 1-element vectors, size-explicit 32-bit types and size-explicit floating point types. This adds the typedefs and a test file that just verif

[clang] [HLSL] Flesh out basic type typedefs (PR #104479)

2024-08-15 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Chris B (llvm-beanz) Changes We had a few missing typedefs that are supported by DXC. Specifically 1-element vectors, size-explicit 32-bit types and size-explicit floating point types. This adds the typedefs and a test file that jus

[clang] [HLSL] Add __is_scalarized_layout_compatible (PR #102227)

2024-08-15 Thread Aaron Ballman via cfe-commits
@@ -658,6 +658,9 @@ KEYWORD(out , KEYHLSL) #define HLSL_INTANGIBLE_TYPE(Name, Id, SingletonId) KEYWORD(Name, KEYHLSL) #include "clang/Basic/HLSLIntangibleTypes.def" +// HLSL Type traits. +TYPE_TRAIT_2(__is_scalarized_layout_compatible, IsScalarizedLayou

[clang] [Clang] handle both gnu and cpp11 attributes to ensure correct parsing inside extern block (PR #102864)

2024-08-15 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman updated https://github.com/llvm/llvm-project/pull/102864 >From b0e53b1c8a687165fa28bd21200f83bf1b1a9234 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 12 Aug 2024 13:56:30 +0300 Subject: [PATCH 1/2] [Clang] handle both gnu and cpp11 attributes to ensure c

[clang] 6cbd96e - [Clang] handle both gnu and cpp11 attributes to ensure correct parsing inside extern block (#102864)

2024-08-15 Thread via cfe-commits
Author: Oleksandr T. Date: 2024-08-15T14:42:39-04:00 New Revision: 6cbd96e24c6a60cbc3dbb849d2ed7afc39c77a80 URL: https://github.com/llvm/llvm-project/commit/6cbd96e24c6a60cbc3dbb849d2ed7afc39c77a80 DIFF: https://github.com/llvm/llvm-project/commit/6cbd96e24c6a60cbc3dbb849d2ed7afc39c77a80.diff

[clang] [Clang] handle both gnu and cpp11 attributes to ensure correct parsing inside extern block (PR #102864)

2024-08-15 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/102864 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Implement resource binding type prefix mismatch diagnostic infrastructure (PR #97103)

2024-08-15 Thread Joshua Batista via cfe-commits
@@ -459,7 +467,506 @@ void SemaHLSL::handleResourceClassAttr(Decl *D, const ParsedAttr &AL) { D->addAttr(HLSLResourceClassAttr::Create(getASTContext(), RC, ArgLoc)); } -void SemaHLSL::handleResourceBindingAttr(Decl *D, const ParsedAttr &AL) { +struct RegisterBindingFlags {

[clang] Implement resource binding type prefix mismatch diagnostic infrastructure (PR #97103)

2024-08-15 Thread Joshua Batista via cfe-commits
@@ -459,7 +467,506 @@ void SemaHLSL::handleResourceClassAttr(Decl *D, const ParsedAttr &AL) { D->addAttr(HLSLResourceClassAttr::Create(getASTContext(), RC, ArgLoc)); } -void SemaHLSL::handleResourceBindingAttr(Decl *D, const ParsedAttr &AL) { +struct RegisterBindingFlags {

[clang] [Clang] Fix sema checks thinking kernels aren't kernels (PR #104460)

2024-08-15 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/104460 >From 84c89feaea8135f7dfaba488b442818974b51c9d Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Thu, 15 Aug 2024 10:34:17 -0500 Subject: [PATCH 1/3] [Clang] Fix sema checks thinking kernels aren't kernels Summ

[clang] [Clang] Fix sema checks thinking kernels aren't kernels (PR #104460)

2024-08-15 Thread Joseph Huber via cfe-commits
@@ -7163,24 +7163,27 @@ void Sema::ProcessDeclAttributeList( } else if (const auto *A = D->getAttr()) { Diag(D->getLocation(), diag::err_opencl_kernel_attr) << A; D->setInvalidDecl(); -} else if (!D->hasAttr()) { - if (const auto *A = D->getAttr()) { -

[clang] [Clang] Fix sema checks thinking kernels aren't kernels (PR #104460)

2024-08-15 Thread Joseph Huber via cfe-commits
@@ -7163,24 +7163,27 @@ void Sema::ProcessDeclAttributeList( } else if (const auto *A = D->getAttr()) { Diag(D->getLocation(), diag::err_opencl_kernel_attr) << A; D->setInvalidDecl(); -} else if (!D->hasAttr()) { - if (const auto *A = D->getAttr()) { -

[clang] [Clang] Fix sema checks thinking kernels aren't kernels (PR #104460)

2024-08-15 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/104460 >From 84c89feaea8135f7dfaba488b442818974b51c9d Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Thu, 15 Aug 2024 10:34:17 -0500 Subject: [PATCH 1/3] [Clang] Fix sema checks thinking kernels aren't kernels Summ

[clang] [llvm] [BPF] introduce `__attribute__((bpf_fastcall))` (PR #101228)

2024-08-15 Thread via cfe-commits
@@ -2189,6 +2189,14 @@ def BTFTypeTag : TypeAttr { let LangOpts = [COnly]; } +def BPFFastCall : InheritableAttr, + TargetSpecificAttr { + let Spellings = [GCC<"bpf_fastcall">]; + let Subjects = SubjectList<[FunctionLike]>; eddyz87 wrote:

[clang] [Clang] Fix sema checks thinking kernels aren't kernels (PR #104460)

2024-08-15 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/104460 >From 84c89feaea8135f7dfaba488b442818974b51c9d Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Thu, 15 Aug 2024 10:34:17 -0500 Subject: [PATCH 1/3] [Clang] Fix sema checks thinking kernels aren't kernels Summ

[clang] [Clang] Fix sema checks thinking kernels aren't kernels (PR #104460)

2024-08-15 Thread Joseph Huber via cfe-commits
@@ -7163,24 +7163,27 @@ void Sema::ProcessDeclAttributeList( } else if (const auto *A = D->getAttr()) { Diag(D->getLocation(), diag::err_opencl_kernel_attr) << A; D->setInvalidDecl(); -} else if (!D->hasAttr()) { - if (const auto *A = D->getAttr()) { -

[clang] [llvm] [BPF] introduce `__attribute__((bpf_fastcall))` (PR #101228)

2024-08-15 Thread Aaron Ballman via cfe-commits
@@ -2189,6 +2189,14 @@ def BTFTypeTag : TypeAttr { let LangOpts = [COnly]; } +def BPFFastCall : InheritableAttr, + TargetSpecificAttr { + let Spellings = [GCC<"bpf_fastcall">]; + let Subjects = SubjectList<[FunctionLike]>; AaronBallman wro

[clang] clang/AMDGPU: Emit atomicrmw for __builtin_amdgcn_global_atomic_fadd_{f32|f64} (PR #96872)

2024-08-15 Thread Matt Arsenault via cfe-commits
arsenm wrote: ### Merge activity * **Aug 15, 2:58 PM EDT**: @arsenm started a stack merge that includes this pull request via [Graphite](https://app.graphite.dev/github/pr/llvm/llvm-project/96872). https://github.com/llvm/llvm-project/pull/96872 __

[clang] b5e63cc - clang/AMDGPU: Emit atomicrmw for __builtin_amdgcn_global_atomic_fadd_{f32|f64} (#96872)

2024-08-15 Thread via cfe-commits
Author: Matt Arsenault Date: 2024-08-15T22:59:24+04:00 New Revision: b5e63cc533b5e752eb475ac657f09b9bb5eb2373 URL: https://github.com/llvm/llvm-project/commit/b5e63cc533b5e752eb475ac657f09b9bb5eb2373 DIFF: https://github.com/llvm/llvm-project/commit/b5e63cc533b5e752eb475ac657f09b9bb5eb2373.diff

[clang] clang/AMDGPU: Emit atomicrmw for __builtin_amdgcn_global_atomic_fadd_{f32|f64} (PR #96872)

2024-08-15 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm closed https://github.com/llvm/llvm-project/pull/96872 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang/AMDGPU: Emit atomicrmw from {global|flat}_atomic_fadd_v2f16 builtins (PR #96873)

2024-08-15 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/96873 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] clang/AMDGPU: Emit atomicrmw from {global|flat}_atomic_fadd_v2f16 builtins (PR #96873)

2024-08-15 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm updated https://github.com/llvm/llvm-project/pull/96873 >From f03c978a942c9169b987b817bbb5ae68126dc766 Mon Sep 17 00:00:00 2001 From: Matt Arsenault Date: Wed, 26 Jun 2024 19:12:59 +0200 Subject: [PATCH] clang/AMDGPU: Emit atomicrmw from {global|flat}_atomic_fadd_v2f1

<    1   2   3   4   5   6   >