[clang] [APINotes] Support C++ tag conformances to Swift protocols (PR #102664)

2024-08-10 Thread Saleem Abdulrasool via cfe-commits
@@ -1230,6 +1231,12 @@ class TagTableInfo : public CommonTypeTableInfo { } else { writer.write(0); } +if (auto ConformsTo = TI.SwiftConformsTo) { + writer.write(ConformsTo->size() + 1); + OS.write(ConformsTo->c_str(), ConformsTo->size()); --

[clang] [clang] Stop adjusting the module cache path (PR #102540)

2024-08-10 Thread Alexandre Ganea via cfe-commits
aganea wrote: > This enables more efficient implementation of the caching VFS in #88800. Thanks @jansvoboda11 for working on this, I appreciate. One question, what do you mean by "more efficient"? https://github.com/llvm/llvm-project/pull/102540 ___

[clang] [clang][deps] Only bypass scanning VFS for the module cache (PR #88800)

2024-08-10 Thread Alexandre Ganea via cfe-commits
https://github.com/aganea approved this pull request. This solves the performance issue I was seeing on Windows with a C++ clang database. Thanks again for doing this @jansvoboda11! https://github.com/llvm/llvm-project/pull/88800 ___ cfe-commits maili

[clang] [Clang][CodeGen] Fix bad codegen when building Clang with latest MSVC (PR #102681)

2024-08-10 Thread Alexandre Ganea via cfe-commits
aganea wrote: > Might be nice to clean this up in the future when Microsoft releases a fix. I can add a comment to that effect. https://github.com/llvm/llvm-project/pull/102681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm

[clang] [Clang][CodeGen] Fix bad codegen when building Clang with latest MSVC (PR #102681)

2024-08-10 Thread Alexandre Ganea via cfe-commits
https://github.com/aganea updated https://github.com/llvm/llvm-project/pull/102681 >From 16efda65bb3d30b67b3215d7e8d69a105e2d771c Mon Sep 17 00:00:00 2001 From: Alexandre Ganea Date: Fri, 9 Aug 2024 16:32:09 -0400 Subject: [PATCH 1/2] [Clang][CodeGen] Fix a bad codegen when building Clang with

[clang] 2ba1cc8 - [Clang][CodeGen] Fix bad codegen when building Clang with latest MSVC (#102681)

2024-08-10 Thread via cfe-commits
Author: Alexandre Ganea Date: 2024-08-10T16:26:10-04:00 New Revision: 2ba1cc8ea53cd76fbeac79dad837dcae32cc7e59 URL: https://github.com/llvm/llvm-project/commit/2ba1cc8ea53cd76fbeac79dad837dcae32cc7e59 DIFF: https://github.com/llvm/llvm-project/commit/2ba1cc8ea53cd76fbeac79dad837dcae32cc7e59.dif

[clang] [Clang][CodeGen] Fix bad codegen when building Clang with latest MSVC (PR #102681)

2024-08-10 Thread Alexandre Ganea via cfe-commits
https://github.com/aganea closed https://github.com/llvm/llvm-project/pull/102681 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c5a4291 - [clang-format] Add BreakBinaryOperations configuration (#95013)

2024-08-10 Thread via cfe-commits
Author: Ameer J Date: 2024-08-10T13:28:33-07:00 New Revision: c5a4291fb704b4cff469bab18ff7ebab41807564 URL: https://github.com/llvm/llvm-project/commit/c5a4291fb704b4cff469bab18ff7ebab41807564 DIFF: https://github.com/llvm/llvm-project/commit/c5a4291fb704b4cff469bab18ff7ebab41807564.diff LOG:

[clang] [clang-format] Add BreakBinaryOperations configuration (PR #95013)

2024-08-10 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/95013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 986bc3d - [clang-format] Fix a serious bug in `git clang-format -f` (#102629)

2024-08-10 Thread via cfe-commits
Author: Owen Pan Date: 2024-08-10T13:31:35-07:00 New Revision: 986bc3d0719af653fecb77e8cfc59f39bec148fd URL: https://github.com/llvm/llvm-project/commit/986bc3d0719af653fecb77e8cfc59f39bec148fd DIFF: https://github.com/llvm/llvm-project/commit/986bc3d0719af653fecb77e8cfc59f39bec148fd.diff LOG:

[clang] [clang-format] Fix a serious bug in `git clang-format -f` (PR #102629)

2024-08-10 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/102629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a serious bug in `git clang-format -f` (PR #102629)

2024-08-10 Thread Owen Pan via cfe-commits
owenca wrote: /cherry-pick 986bc3d0719af653fecb77e8cfc59f39bec148fd https://github.com/llvm/llvm-project/pull/102629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a serious bug in `git clang-format -f` (PR #102629)

2024-08-10 Thread Owen Pan via cfe-commits
https://github.com/owenca milestoned https://github.com/llvm/llvm-project/pull/102629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a serious bug in `git clang-format -f` (PR #102629)

2024-08-10 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#102770 https://github.com/llvm/llvm-project/pull/102629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][OMPX] Add the code generation for multi-dim `thread_limit` clause (PR #102717)

2024-08-10 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/102717 >From 323ab9b867ade1b029bf55bff07d71abfc9d09ac Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Fri, 9 Aug 2024 23:25:21 -0400 Subject: [PATCH] [Clang][OMPX] Add the code generation for multi-dim `thread_limit

[clang] [llvm] [Clang][OMPX] Add the code generation for multi-dim `thread_limit` clause (PR #102717)

2024-08-10 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a417083e27b155dc92b7f7271c0093aee0d7231c 323ab9b867ade1b029bf55bff07d71abfc9d09ac --e

[clang] Add flag to suppress overflow errors in C++ constant expressions. (PR #102390)

2024-08-10 Thread Hubert Tong via cfe-commits
hubert-reinterpretcast wrote: I don't see a compelling reason for the extension and I find its behaviour somewhat arbitrary: why is it okay to allow the overflow in the definition of an enumerator but not okay to allow for `alignas`? https://github.com/llvm/llvm-project/pull/102390 ___

[clang-tools-extra] [clang-tidy] Fix modernize-use-std-format lit test signature (PR #102759)

2024-08-10 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 approved this pull request. https://github.com/llvm/llvm-project/pull/102759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen][SPIR-V][AMDGPU] Tweak AMDGCNSPIRV ABI to allow for the correct handling of aggregates passed to kernels / functions. (PR #102776)

2024-08-10 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx created https://github.com/llvm/llvm-project/pull/102776 The AMDGPU kernel ABI is not directly representable in SPIR-V, since it relies on passing aggregates `byref`, and SPIR-V only encodes `byval` (which the AMDGPU BE disallows for kernel arguments). As a temporary

[clang] [clang][CodeGen][SPIR-V][AMDGPU] Tweak AMDGCNSPIRV ABI to allow for the correct handling of aggregates passed to kernels / functions. (PR #102776)

2024-08-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-spir-v Author: Alex Voicu (AlexVlx) Changes The AMDGPU kernel ABI is not directly representable in SPIR-V, since it relies on passing aggregates `byref`, and SPIR-V only encodes `byval` (which the AMDGPU BE disallows for kernel arguments). As a

[clang] [clang][CodeGen][SPIR-V][AMDGPU] Tweak AMDGCNSPIRV ABI to allow for the correct handling of aggregates passed to kernels / functions. (PR #102776)

2024-08-10 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx ready_for_review https://github.com/llvm/llvm-project/pull/102776 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen][SPIR-V][AMDGPU] Tweak AMDGCNSPIRV ABI to allow for the correct handling of aggregates passed to kernels / functions. (PR #102776)

2024-08-10 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a417083e27b155dc92b7f7271c0093aee0d7231c d41faf6da8a9eed8c32f6a62fa9ebf38d5824c2c --e

[clang] [clang][CodeGen][SPIR-V][AMDGPU] Tweak AMDGCNSPIRV ABI to allow for the correct handling of aggregates passed to kernels / functions. (PR #102776)

2024-08-10 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/102776 >From d41faf6da8a9eed8c32f6a62fa9ebf38d5824c2c Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Sun, 11 Aug 2024 01:39:46 +0300 Subject: [PATCH 1/2] Tweak AMDGCNSPIRV ABI to allow for the correct handling of agg

[clang] [Clang][OpenMP] Fix the wrong transform of `num_teams` claused introduced in #99732 (PR #102716)

2024-08-10 Thread Shilei Tian via cfe-commits
shiltian wrote: > > > A test is required > > > > > > I literally don't know how to test this TBH. I think our current OpenMP > > tests generally don't cover this at all. > > They do. To test this, you need to use clause in the template and check that > template params successfully replaced u

[clang] [llvm] [Clang][OMPX] Add the code generation for multi-dim `thread_limit` clause (PR #102717)

2024-08-10 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/102717 >From 998bb28ebbb72eccbf4461ba456bbc07499f10d4 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Fri, 9 Aug 2024 23:25:21 -0400 Subject: [PATCH] [Clang][OMPX] Add the code generation for multi-dim `thread_limit

[clang] [Clang][OpenMP] Fix the wrong transform of `num_teams` claused introduced in #99732 (PR #102716)

2024-08-10 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/102716 >From 838e1ccc1593a12107fd96b36eea048dd9d38869 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Fri, 9 Aug 2024 23:11:43 -0400 Subject: [PATCH] [Clang][OpenMP] Fix the wrong transform of `num_teams` claused in

[clang] [Clang][OpenMP] Fix the wrong transform of `num_teams` claused introduced in #99732 (PR #102716)

2024-08-10 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/102716 >From 5f168adb3ce6935ad4d0c48ee29285a2a1053d74 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Fri, 9 Aug 2024 23:11:43 -0400 Subject: [PATCH] [Clang][OpenMP] Fix the wrong transform of `num_teams` claused in

[clang] [clang-format] Fix a serious bug in `git clang-format -f` (PR #102629)

2024-08-10 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-android` running on `sanitizer-buildbot-android` while building `clang` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/186/builds/1330 Here is the relevan

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

2024-08-10 Thread Farzon Lotfi via cfe-commits
@@ -4737,6 +4737,12 @@ def HLSLRSqrt : LangBuiltin<"HLSL_LANG"> { let Prototype = "void(...)"; } +def HLSLSign : LangBuiltin<"HLSL_LANG"> { + let Spellings = ["__builtin_hlsl_elementwise_sign"]; + let Attributes = [NoThrow, Const]; + let Prototype = "int(...)"; --

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

2024-08-10 Thread Farzon Lotfi via cfe-commits
@@ -1725,5 +1725,76 @@ _HLSL_AVAILABILITY(shadermodel, 6.0) _HLSL_BUILTIN_ALIAS(__builtin_hlsl_wave_get_lane_index) __attribute__((convergent)) uint WaveGetLaneIndex(); +//===--===// +// sign builtins +//===--

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

2024-08-10 Thread Farzon Lotfi via cfe-commits
@@ -1725,5 +1725,76 @@ _HLSL_AVAILABILITY(shadermodel, 6.0) _HLSL_BUILTIN_ALIAS(__builtin_hlsl_wave_get_lane_index) __attribute__((convergent)) uint WaveGetLaneIndex(); +//===--===// +// sign builtins +//===--

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

2024-08-10 Thread Farzon Lotfi via cfe-commits
@@ -1725,5 +1725,76 @@ _HLSL_AVAILABILITY(shadermodel, 6.0) _HLSL_BUILTIN_ALIAS(__builtin_hlsl_wave_get_lane_index) __attribute__((convergent)) uint WaveGetLaneIndex(); +//===--===// +// sign builtins +//===--

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

2024-08-10 Thread Farzon Lotfi via cfe-commits
@@ -1725,5 +1725,76 @@ _HLSL_AVAILABILITY(shadermodel, 6.0) _HLSL_BUILTIN_ALIAS(__builtin_hlsl_wave_get_lane_index) __attribute__((convergent)) uint WaveGetLaneIndex(); +//===--===// +// sign builtins +//===--

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

2024-08-10 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/101989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

2024-08-10 Thread Farzon Lotfi via cfe-commits
@@ -1108,6 +1117,14 @@ bool SemaHLSL::CheckBuiltinFunctionCall(unsigned BuiltinID, CallExpr *TheCall) { return true; break; } + case Builtin::BI__builtin_hlsl_elementwise_sign: { +if (CheckFloatingOrSignedIntRepresentation(&SemaRef, TheCall)) + return tru

[clang] [clang][Interp] Improve "in call to" call argument printing (PR #102735)

2024-08-10 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: Breaks https://lab.llvm.org/buildbot/#/builders/52/builds/1496 https://github.com/llvm/llvm-project/pull/102735 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[clang][Interp] Improve "in call to" call argument printing" (PR #102785)

2024-08-10 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/102785 Reverts llvm/llvm-project#102735 Breaks >From 7e8bb8c52f51fd6b41c0b6485b93fd0315b58bab Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Sat, 10 Aug 2024 19:55:54 -0700 Subject: [PATCH] Revert "[clang][Inte

[clang] Revert "[clang][Interp] Improve "in call to" call argument printing" (PR #102785)

2024-08-10 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka edited https://github.com/llvm/llvm-project/pull/102785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[clang][Interp] Improve "in call to" call argument printing" (PR #102785)

2024-08-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vitaly Buka (vitalybuka) Changes Reverts llvm/llvm-project#102735 Breaks https://lab.llvm.org/buildbot/#/builders/52/builds/1496 --- Full diff: https://github.com/llvm/llvm-project/pull/102785.diff 2 Files Affected: - (modified) clang/

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

2024-08-10 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/101989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][HLSL] Add sign intrinsic part 3 (PR #101989)

2024-08-10 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/101989 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[clang][Interp] Improve "in call to" call argument printing" (PR #102785)

2024-08-10 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka closed https://github.com/llvm/llvm-project/pull/102785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f498638 - Revert "[clang][Interp] Improve "in call to" call argument printing" (#102785)

2024-08-10 Thread via cfe-commits
Author: Vitaly Buka Date: 2024-08-10T20:39:55-07:00 New Revision: f498638a4cd5f60dafcda512e4de848ee627ab95 URL: https://github.com/llvm/llvm-project/commit/f498638a4cd5f60dafcda512e4de848ee627ab95 DIFF: https://github.com/llvm/llvm-project/commit/f498638a4cd5f60dafcda512e4de848ee627ab95.diff L

[clang] Revert "Revert "[clang][Interp] Improve "in call to" call argument printing"" (PR #102786)

2024-08-10 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka created https://github.com/llvm/llvm-project/pull/102786 Reverts llvm/llvm-project#102785 >From 0066d85186fda169b17acc63e4e85ad901e0cbe4 Mon Sep 17 00:00:00 2001 From: Vitaly Buka Date: Sat, 10 Aug 2024 20:40:10 -0700 Subject: [PATCH] =?UTF-8?q?Revert=20"Revert=20

[clang] Revert "Revert "[clang][Interp] Improve "in call to" call argument printing"" (PR #102786)

2024-08-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vitaly Buka (vitalybuka) Changes Reverts llvm/llvm-project#102785 --- Full diff: https://github.com/llvm/llvm-project/pull/102786.diff 2 Files Affected: - (modified) clang/lib/AST/Interp/InterpFrame.cpp (+3-2) - (modified) clang/test/A

[clang] Revert "Revert "[clang][Interp] Improve "in call to" call argument printing"" (PR #102786)

2024-08-10 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: I am not sure what is going on there, maybe it needs // UNSUPPORTED: asan I am not going to reland, it's just a notice, to make sure you noticed the revert. https://github.com/llvm/llvm-project/pull/102786 ___ cfe-commits mailing li

[clang] [Clang] fix generic lambda inside requires-clause of friend function template (PR #99813)

2024-08-10 Thread Zhikai Zeng via cfe-commits
Backl1ght wrote: > So, friend functions do not increase the template depth? That seems... weird! This is not the cause, as for template depth friend functions behave just the same as other functions I think. Maybe you are confused by my first comment in https://github.com/llvm/llvm-project/iss

[clang] [llvm] [Inliner] Propagate more attributes to params when inlining (PR #91101)

2024-08-10 Thread via cfe-commits
goldsteinn wrote: ping3 https://github.com/llvm/llvm-project/pull/91101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[clang][Interp] Improve "in call to" call argument printing" (PR #102785)

2024-08-10 Thread Timm Baeder via cfe-commits
tbaederr wrote: That test doesn't even use the new constant interpreter? https://github.com/llvm/llvm-project/pull/102785 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Revert "[clang][Interp] Improve "in call to" call argument printing" (PR #102785)

2024-08-10 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > That test doesn't even use the new constant interpreter? Yes, that's looks strange, but it fixes the bot https://lab.llvm.org/buildbot/#/builders/52 https://github.com/llvm/llvm-project/pull/102785 ___ cfe-commits mailing list

[clang] [clang] Support --sysroot= for ${arch}-windows-msvc targets (PR #96417)

2024-08-10 Thread via cfe-commits
trcrsired wrote: > This could close #54868 that I had opened a while back to support cross > compiling using clang with [xwin](https://github.com/Jake-Shadle/xwin/). no. I do not want that complicated file structure. I just want normal GNU style's sysroot https://github.com/llvm/llvm-project/

[clang] [clang] Support --sysroot= for ${arch}-windows-msvc targets (PR #96417)

2024-08-10 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/96417 >From 25519e89cad1676cbabaf0d9a88739626b63 Mon Sep 17 00:00:00 2001 From: trcrsired Date: Sun, 23 Jun 2024 00:07:19 -0400 Subject: [PATCH] Support --sysroot= for ${arch}-windows-msvc targets I think it is

<    1   2