[clang] [llvm] [Sanitizer] Make sanitizer passes idempotent (PR #99439)

2024-08-05 Thread via cfe-commits
https://github.com/skc7 updated https://github.com/llvm/llvm-project/pull/99439 >From 3c7c677b7d6dc3934fddc452021dcc2c06086606 Mon Sep 17 00:00:00 2001 From: skc7 Date: Thu, 18 Jul 2024 11:49:24 +0530 Subject: [PATCH] [Sanitizer] Make sanitizer passes idempotent. --- clang/test/CodeGenObjC/no-

[clang] [Clang][Sema][OpenMP] Allow `num_teams` to accept multiple expressions (PR #99732)

2024-08-05 Thread Johannes Doerfert via cfe-commits
@@ -11357,8 +11358,13 @@ void OMPClauseReader::VisitOMPAllocateClause(OMPAllocateClause *C) { void OMPClauseReader::VisitOMPNumTeamsClause(OMPNumTeamsClause *C) { VisitOMPClauseWithPreInit(C); - C->setNumTeams(Record.readSubExpr()); C->setLParenLoc(Record.readSourceLoca

[clang] [llvm] target ABI: improve call parameters extensions handling (PR #100757)

2024-08-05 Thread Jonas Paulsson via cfe-commits
@@ -1185,6 +1189,9 @@ Currently, only the following parameter attributes are defined: value should be sign-extended to the extent required by the target's ABI (which is usually 32-bits) by the caller (for a parameter) or the callee (for a return value). +``noext``

[clang-tools-extra] [clang-tidy] Fix smart pointers handling in bugprone-use-after-move (PR #94869)

2024-08-05 Thread via cfe-commits
https://github.com/martinboehme requested changes to this pull request. Sorry - I only noticed now after your rebase that this had been sitting in my review queue for quite a while. * I would suggest rewording the option name. The "ignore" (`IgnoreNonDerefSmartPtrs`) reads like a negation, w

[clang] [llvm] [X86][AVX10.2] Support AVX10.2 VNNI FP16/INT8/INT16 new instructions (PR #101783)

2024-08-05 Thread Shengchen Kan via cfe-commits
https://github.com/KanRobert approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/101783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Handle CXXInheritedCtorInitExpr in ResultObjectVisitor. (PR #99616)

2024-08-05 Thread via cfe-commits
martinboehme wrote: @haoNoQ Thank you for going to the trouble to explain all of this in detail! > I'm very open to changes in `ConstructionContext` to accommodate your needs, > like provide extra information that we didn't need but you did, or provide it > in a different way. I haven't looke

[clang] [Clang] Fix potential null pointer dereferences in Sema::AddInitializerToDecl (PR #94368)

2024-08-05 Thread via cfe-commits
https://github.com/cor3ntin requested changes to this pull request. Do you have any test that crashes without this change? I agree with @feg208, we should assert Init is not null there (rather that silently return). If there are cases where init could in fact be null, we should add a test for i

[clang] [Clang] Fix potential null pointer dereferences in Sema::AddInitializerToDecl (PR #94368)

2024-08-05 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/94368 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Add GCS support for AArch64 (PR #99335)

2024-08-05 Thread Tobias Hieta via cfe-commits
tru wrote: > Though having said all this, I marked this for LLVM 19 as my reading of > https://discourse.llvm.org/t/update-on-llvm-19-x-releases/80511 was that new > features are still ok before RC2, but re-reading it it's a bit ambiguous: it > says "New features will have to wait until LLVM 2

[clang] 7536ebf - [Clang][SemaCXX] Fix bug where unexpanded lambda captures where assumed to have size 1 (#101385)

2024-08-05 Thread via cfe-commits
Author: Mital Ashok Date: 2024-08-05T16:16:55+08:00 New Revision: 7536ebf0ea8e2d09f47ee77e0d60470b5eeb2743 URL: https://github.com/llvm/llvm-project/commit/7536ebf0ea8e2d09f47ee77e0d60470b5eeb2743 DIFF: https://github.com/llvm/llvm-project/commit/7536ebf0ea8e2d09f47ee77e0d60470b5eeb2743.diff L

[clang] [Clang][SemaCXX] Fix bug where unexpanded lambda captures where assumed to have size 1 (PR #101385)

2024-08-05 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/101385 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Handle Pointer::toAPValue() for expr bases (PR #101937)

2024-08-05 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr created https://github.com/llvm/llvm-project/pull/101937 No reason to return early for them anymore. >From 3b8a063c42f92faf6eac8b254b208d8d48013046 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timm=20B=C3=A4der?= Date: Mon, 5 Aug 2024 09:18:23 +0200 Subject: [PATCH] [cl

[clang] [clang][Interp] Handle Pointer::toAPValue() for expr bases (PR #101937)

2024-08-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Timm Baeder (tbaederr) Changes No reason to return early for them anymore. --- Full diff: https://github.com/llvm/llvm-project/pull/101937.diff 3 Files Affected: - (modified) clang/lib/AST/Interp/Pointer.cpp (+25-4) - (modified) clang/

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-05 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok edited https://github.com/llvm/llvm-project/pull/101853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-05 Thread Mital Ashok via cfe-commits
@@ -12370,6 +12379,17 @@ void Sema::CheckMain(FunctionDecl* FD, const DeclSpec& DS) { } } +bool Sema::CheckLinkageSpecification(DeclContext *DC, Decl *D) { + // [basic.start.main] p2 + // The main function shall not be declared with a linkage-specification. + if (DC->i

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-05 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok requested changes to this pull request. You can put some of the tests in `clang/test/CXX/basic/basic.start/basic.start.main/p3.cpp` You lost the check for `extern "C++" int main() {}` at global scope. To recap: ```c++ // These are disallowed by [basic.start.main]p

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-05 Thread Mital Ashok via cfe-commits
@@ -7353,6 +7353,15 @@ void emitReadOnlyPlacementAttrWarning(Sema &S, const VarDecl *VD) { } } +static bool isMainVar(DeclarationName Name, VarDecl *VD) { + if (Name.getAsIdentifierInfo() && Name.getAsIdentifierInfo()->isStr("main") && + !VD->getDescribedVarTemplate(

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-05 Thread Mital Ashok via cfe-commits
@@ -3292,11 +3292,9 @@ bool FunctionDecl::isImmediateFunction() const { } bool FunctionDecl::isMain() const { - const TranslationUnitDecl *tunit = -dyn_cast(getDeclContext()->getRedeclContext()); - return tunit && - !tunit->getASTContext().getLangOpts().Freestand

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-05 Thread Mital Ashok via cfe-commits
@@ -990,6 +990,8 @@ def warn_main_redefined : Warning<"variable named 'main' with external linkage " "has undefined behavior">, InGroup; def ext_main_used : Extension< "referring to 'main' within an expression is a Clang extension">, InGroup; +def err_main_invalid_lin

[clang] #101784 part 1: introduce ctyped in an independent manner (PR #101941)

2024-08-05 Thread via cfe-commits
https://github.com/TsXor created https://github.com/llvm/llvm-project/pull/101941 This is part 1 as described in #101784. I moved `LibclangExports`, `LibclangError` and modified `Config` class to a new file: `binder.py`. It can now be used by `cindex.py` with a simple `from .binder import Conf

[clang] #101784 part 1: introduce ctyped in an independent manner (PR #101941)

2024-08-05 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [Sema] Preserve ContainsUnexpandedParameterPack in TransformLambdaExpr (PR #86265)

2024-08-05 Thread via cfe-commits
cor3ntin wrote: I might be stupid but i still do not get why fold expressions are special, they should not be. Can you add tests for ```cpp void f(auto...); template void foo() { []() { f([]() requires (!C) {}()...); }.template operator()(); } ``` other interesting expansions might be

[clang] #101784 part 1: introduce ctyped in an independent manner (PR #101941)

2024-08-05 Thread via cfe-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 98e4413a38f286147b863a6ead9625228ab0ec7d...3e12ffd4afa52126e5fd162d62f832626bfb8578 clang

[clang] #101784 part 1: introduce ctyped in an independent manner (PR #101941)

2024-08-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (TsXor) Changes This is part 1 as described in #101784. I moved `LibclangExports`, `LibclangError` and modified `Config` class to a new file: `binder.py`. It can now be used by `cindex.py` with a simple `from .binder import Config`.

[clang] [llvm] target ABI: improve call parameters extensions handling (PR #100757)

2024-08-05 Thread Jonas Paulsson via cfe-commits
@@ -2,7 +2,7 @@ ; PR933 JonPsson1 wrote: Handling of these tests here: https://github.com/llvm/llvm-project/pull/101944. https://github.com/llvm/llvm-project/pull/100757 ___ cfe-commits mailing list cfe-commits@lists

[clang] 1fec981 - [C++20] [Modules] Skip ODR checks in implicit global modules

2024-08-05 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2024-08-05T17:01:24+08:00 New Revision: 1fec981b67ac57abd4d8defd73beb5a9433c602f URL: https://github.com/llvm/llvm-project/commit/1fec981b67ac57abd4d8defd73beb5a9433c602f DIFF: https://github.com/llvm/llvm-project/commit/1fec981b67ac57abd4d8defd73beb5a9433c602f.diff LO

[clang] [clang][Interp] Handle Pointer::toAPValue() for expr bases (PR #101937)

2024-08-05 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr closed https://github.com/llvm/llvm-project/pull/101937 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 72fb188 - [clang][Interp] Handle Pointer::toAPValue() for expr bases (#101937)

2024-08-05 Thread via cfe-commits
Author: Timm Baeder Date: 2024-08-05T11:10:56+02:00 New Revision: 72fb1889424fc371ef7d630009e4e579d18b9247 URL: https://github.com/llvm/llvm-project/commit/72fb1889424fc371ef7d630009e4e579d18b9247 DIFF: https://github.com/llvm/llvm-project/commit/72fb1889424fc371ef7d630009e4e579d18b9247.diff L

[libunwind] 710590e - [libunwind] Undefined behaviour pointer arithmetic with null pointer (#98648)

2024-08-05 Thread via cfe-commits
Author: Daniel Kiss Date: 2024-08-05T11:16:51+02:00 New Revision: 710590e33d19649f08c716d827eb465e3a132d23 URL: https://github.com/llvm/llvm-project/commit/710590e33d19649f08c716d827eb465e3a132d23 DIFF: https://github.com/llvm/llvm-project/commit/710590e33d19649f08c716d827eb465e3a132d23.diff L

[libunwind] [libunwind] Undefined behaviour pointer arithmetic with null pointer (PR #98648)

2024-08-05 Thread Daniel Kiss via cfe-commits
https://github.com/DanielKristofKiss closed https://github.com/llvm/llvm-project/pull/98648 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-05 Thread via cfe-commits
https://github.com/Sirraide requested changes to this pull request. This needs some cleanup I think, but it’s going in the right direction. https://github.com/llvm/llvm-project/pull/101853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:/

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-05 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/101853 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-05 Thread via cfe-commits
@@ -3292,11 +3292,9 @@ bool FunctionDecl::isImmediateFunction() const { } bool FunctionDecl::isMain() const { - const TranslationUnitDecl *tunit = -dyn_cast(getDeclContext()->getRedeclContext()); - return tunit && - !tunit->getASTContext().getLangOpts().Freestand

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-05 Thread via cfe-commits
@@ -145,6 +145,8 @@ Improvements to Clang's diagnostics - -Wdangling-assignment-gsl is enabled by default. +- Clang now diagnoses the use of `main` in `extern` context as invalid according to [basic.start.main] p2. Fixes #GH101512. Sirraide wrote: ```sugges

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-05 Thread via cfe-commits
@@ -0,0 +1,22 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -pedantic-errors %s + Sirraide wrote: I think this was already pointed out, but some tests w/ `extern "C++"` would be nice, as well as tests for when a namespace is contained in a linkage-spec-decl. htt

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-05 Thread via cfe-commits
@@ -8052,15 +8061,13 @@ NamedDecl *Sema::ActOnVariableDeclarator( } // Special handling of variable named 'main'. - if (Name.getAsIdentifierInfo() && Name.getAsIdentifierInfo()->isStr("main") && - NewVD->getDeclContext()->getRedeclContext()->isTranslationUnit() && -

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-05 Thread via cfe-commits
@@ -3292,11 +3292,9 @@ bool FunctionDecl::isImmediateFunction() const { } bool FunctionDecl::isMain() const { - const TranslationUnitDecl *tunit = -dyn_cast(getDeclContext()->getRedeclContext()); - return tunit && - !tunit->getASTContext().getLangOpts().Freestand

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-05 Thread via cfe-commits
@@ -7353,6 +7353,15 @@ void emitReadOnlyPlacementAttrWarning(Sema &S, const VarDecl *VD) { } } +static bool isMainVar(DeclarationName Name, VarDecl *VD) { + if (Name.getAsIdentifierInfo() && Name.getAsIdentifierInfo()->isStr("main") && + !VD->getDescribedVarTemplate(

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-05 Thread via cfe-commits
@@ -990,6 +990,8 @@ def warn_main_redefined : Warning<"variable named 'main' with external linkage " "has undefined behavior">, InGroup; def ext_main_used : Extension< "referring to 'main' within an expression is a Clang extension">, InGroup; +def err_main_invalid_lin

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-05 Thread via cfe-commits
@@ -2156,6 +2156,8 @@ class DeclContext { return getDeclKind() == Decl::TranslationUnit; } + bool isLinkageSpec() const { return getDeclKind() == Decl::LinkageSpec; } Sirraide wrote: I don’t think we need this. The place where this is used can just do

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-05 Thread via cfe-commits
@@ -3585,8 +3585,9 @@ class Sema final : public SemaBase { /// \param OldT The portion of the type of the old declaration to check. bool canFullyTypeCheckRedeclaration(ValueDecl *NewD, ValueDecl *OldD, QualType NewT, QualType OldT); -

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-05 Thread via cfe-commits
@@ -0,0 +1,5 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -pedantic-errors %s + Sirraide wrote: Also add a test for this (at the top level w/o any linkage-spec-decl) if we don’t already have one: ``` int main; ``` which is also invalid; probably in a separate fi

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-05 Thread via cfe-commits
@@ -12370,6 +12379,17 @@ void Sema::CheckMain(FunctionDecl* FD, const DeclSpec& DS) { } } +bool Sema::CheckLinkageSpecification(DeclContext *DC, Decl *D) { + // [basic.start.main] p2 + // The main function shall not be declared with a linkage-specification. + if (DC->i

[clang] [Clang] strengthen checks for 'main' function to meet [basic.start.main] p2 requirements (PR #101853)

2024-08-05 Thread via cfe-commits
@@ -8052,15 +8061,13 @@ NamedDecl *Sema::ActOnVariableDeclarator( } // Special handling of variable named 'main'. - if (Name.getAsIdentifierInfo() && Name.getAsIdentifierInfo()->isStr("main") && - NewVD->getDeclContext()->getRedeclContext()->isTranslationUnit() && -

[clang] [llvm] target ABI: improve call parameters extensions handling (PR #100757)

2024-08-05 Thread Nikita Popov via cfe-commits
nikic wrote: Could you please post an RFC on discourse for this (or link it if it already exists)? https://github.com/llvm/llvm-project/pull/100757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [llvm] target ABI: improve call parameters extensions handling (PR #100757)

2024-08-05 Thread Jonas Paulsson via cfe-commits
@@ -2,7 +2,7 @@ ; PR933 JonPsson1 wrote: (committed now) https://github.com/llvm/llvm-project/pull/100757 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [analyzer][NFC] Eliminate a dyn_cast (PR #100719)

2024-08-05 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus updated https://github.com/llvm/llvm-project/pull/100719 From d176b03b211144dadaa1efb4b7da959110d7725c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krist=C3=B3f=20Umann?= Date: Fri, 26 Jul 2024 11:01:41 +0200 Subject: [PATCH 1/2] [analyzer][NFC] Eliminate a dyn_cast --

[clang] [Clang] Implement C++26’s P2893R3 ‘Variadic friends’ (PR #101448)

2024-08-05 Thread via cfe-commits
@@ -1442,8 +1442,49 @@ Decl *TemplateDeclInstantiator::VisitFriendDecl(FriendDecl *D) { if (D->isUnsupportedFriend()) { InstTy = Ty; } else { - InstTy = SemaRef.SubstType(Ty, TemplateArgs, - D->getLocation(), DeclarationName()

[clang] [Clang] Implement C++26’s P2893R3 ‘Variadic friends’ (PR #101448)

2024-08-05 Thread via cfe-commits
Sirraide wrote: > Looks generally good from a cursory review. I think we want to add tests for > modules / in the test/PCH directory. We already have tests for PCHs, but I can add some more for modules. > We probably want that as an extension indeed, no reason not to We allow `friend` type de

[clang] [Clang] Define __cpp_pack_indexing (PR #101956)

2024-08-05 Thread via cfe-commits
https://github.com/Sirraide created https://github.com/llvm/llvm-project/pull/101956 Following the discussion on [#101448](https://github.com/llvm/llvm-project/pull/101448#pullrequestreview-2217511926), this defines `__cpp_pack_indexing`. Since pack indexing is currently supported in all lang

[clang] [Clang] Define __cpp_pack_indexing (PR #101956)

2024-08-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Sirraide) Changes Following the discussion on [#101448](https://github.com/llvm/llvm-project/pull/101448#pullrequestreview-2217511926), this defines `__cpp_pack_indexing`. Since pack indexing is currently supported in all language m

[clang-tools-extra] [IncludeCleaner] display overview (PR #93932)

2024-08-05 Thread via cfe-commits
https://github.com/TheHillBright updated https://github.com/llvm/llvm-project/pull/93932 >From e803c635a64ed3c2ad0381e82ca308f63dcf4604 Mon Sep 17 00:00:00 2001 From: TheHillBright <150074496+thehillbri...@users.noreply.github.com> Date: Fri, 31 May 2024 15:00:37 +0800 Subject: [PATCH] IncludeCl

[clang] [clang][driver][clang-cl] Support `--precompile` and `-fmodule-*` options in Clang-CL (PR #98761)

2024-08-05 Thread Sharadh Rajaraman via cfe-commits
sharadhr wrote: @ChuanqiXu9, do make a re-review when you can, thanks! https://github.com/llvm/llvm-project/pull/98761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 77011b0 - [Clang] Fix path-sensitivity in ubsan-bool.m test (NFC)

2024-08-05 Thread Nikita Popov via cfe-commits
Author: Nikita Popov Date: 2024-08-05T12:56:33+02:00 New Revision: 77011b00ad5f7f1789e788e85aed1babeb540213 URL: https://github.com/llvm/llvm-project/commit/77011b00ad5f7f1789e788e85aed1babeb540213 DIFF: https://github.com/llvm/llvm-project/commit/77011b00ad5f7f1789e788e85aed1babeb540213.diff

[clang] [llvm] [X86][AVX10.2] Support AVX10.2 VNNI FP16/INT8/INT16 new instructions (PR #101783)

2024-08-05 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/101783 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] target ABI: improve call parameters extensions handling (PR #100757)

2024-08-05 Thread Jonas Paulsson via cfe-commits
JonPsson1 wrote: > Could you please post an RFC on discourse for this (or link it if it already > exists)? Made an attempt here: https://discourse.llvm.org/t/target-abi-improve-call-parameters-extensions-handling/80553. https://github.com/llvm/llvm-project/pull/100757

[clang] [OpenMP][Map][NFC] improve map chain. (PR #101903)

2024-08-05 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/101903 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema][OpenMP] Allow `num_teams` to accept multiple expressions (PR #99732)

2024-08-05 Thread Alexey Bataev via cfe-commits
@@ -13004,13 +13004,34 @@ StmtResult SemaOpenMP::ActOnOpenMPTargetUpdateDirective( Clauses, AStmt); } +// This checks whether num_teams clause only has one expression. alexey-bataev wrote: Use `///` style of comment

[clang] [llvm] [MC] Emit a jump table size section (PR #101962)

2024-08-05 Thread Nabeel Omer via cfe-commits
https://github.com/omern1 created https://github.com/llvm/llvm-project/pull/101962 This patch will make LLVM emit a jump table size section containing tuples of (jump table address, entry count) in object files. This section is useful for tools that need to statically reconstruct the control f

[clang] [llvm] [X86][AVX10.2] Support AVX10.2-SATCVT new instructions. (PR #101599)

2024-08-05 Thread Simon Pilgrim via cfe-commits
@@ -0,0 +1,327 @@ +/*===-- avx10_2_512satcvtintrin.h - AVX10_2_512SATCVT intrinsics ---=== + * + * Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. + * See https://llvm.org/LICENSE.txt for license information. + * SPDX-License-Identifier: Apac

[clang] [llvm] [MC] Emit a jump table size section (PR #101962)

2024-08-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-llvm-binary-utilities Author: Nabeel Omer (omern1) Changes This patch will make LLVM emit a jump table size section containing tuples of (jump table address, entry count) in object files. This section is useful for too

[clang] [llvm] [MC] Emit a jump table size section (PR #101962)

2024-08-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Nabeel Omer (omern1) Changes This patch will make LLVM emit a jump table size section containing tuples of (jump table address, entry count) in object files. This section is useful for tools that need to statically reconstruct the c

[clang] 8370ba4 - [analyzer][NFC] Eliminate a dyn_cast (#100719)

2024-08-05 Thread via cfe-commits
Author: Kristóf Umann Date: 2024-08-05T13:25:31+02:00 New Revision: 8370ba4d15c6726ed82bcd0d42a3ea9c94cc56b0 URL: https://github.com/llvm/llvm-project/commit/8370ba4d15c6726ed82bcd0d42a3ea9c94cc56b0 DIFF: https://github.com/llvm/llvm-project/commit/8370ba4d15c6726ed82bcd0d42a3ea9c94cc56b0.diff

[clang] [analyzer][NFC] Eliminate a dyn_cast (PR #100719)

2024-08-05 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus closed https://github.com/llvm/llvm-project/pull/100719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [MC] Emit a jump table size section (PR #101962)

2024-08-05 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 832203545d4e2157ca29f99b18e3360ffa180183 14f3cb82f0d7e69261bd7e1317bd66392e9a2c2b --e

[clang] [llvm] [MC] Emit a jump table size section (PR #101962)

2024-08-05 Thread Nabeel Omer via cfe-commits
https://github.com/omern1 updated https://github.com/llvm/llvm-project/pull/101962 >From 14f3cb82f0d7e69261bd7e1317bd66392e9a2c2b Mon Sep 17 00:00:00 2001 From: Nabeel Omer Date: Mon, 5 Aug 2024 11:50:18 +0100 Subject: [PATCH 1/2] [MC] Emit a jump table size section This patch will make LLVM e

[clang] [analyzer] Assert Callee is FunctionDecl in doesFnIntendToHandleOwnership() (PR #101066)

2024-08-05 Thread Kristóf Umann via cfe-commits
Szelethus wrote: Just landed the patch, sorry for the slack! https://github.com/llvm/llvm-project/pull/101066 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fix issue: [Clang][OpenMP] Implicit conversion with `pragma omp taskloop` #100536 (PR #101812)

2024-08-05 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: Again, I doubt this is the right fix. I assume the proper fix should properly cast expressions to the required type before using them in the expressions. This patch not fixes the issues, but hides it. https://github.com/llvm/llvm-project/pull/101812 ___

[clang] a42e515 - [OpenMP] OpenMP 5.1 "assume" directive parsing support (#92731)

2024-08-05 Thread via cfe-commits
Author: Julian Brown Date: 2024-08-05T07:37:07-04:00 New Revision: a42e515e3a9f3bb4e44389c097b89104d95b9b29 URL: https://github.com/llvm/llvm-project/commit/a42e515e3a9f3bb4e44389c097b89104d95b9b29 DIFF: https://github.com/llvm/llvm-project/commit/a42e515e3a9f3bb4e44389c097b89104d95b9b29.diff

[clang] [llvm] [OpenMP] OpenMP 5.1 "assume" directive parsing support (PR #92731)

2024-08-05 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev closed https://github.com/llvm/llvm-project/pull/92731 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP] OpenMP 5.1 "assume" directive parsing support (PR #92731)

2024-08-05 Thread via cfe-commits
github-actions[bot] wrote: @jtb20 Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build, y

[clang] [llvm] [X86][AVX10.2] Support AVX10.2-SATCVT new instructions. (PR #101599)

2024-08-05 Thread Freddy Ye via cfe-commits
@@ -417,3 +417,173 @@ defm VMINMAXSH : avx10_minmax_scalar<"vminmaxsh", v8f16x_info, X86vminmaxs, X86v AVX512PSIi8Base, VEX_LIG, EVEX, , EVEX_CD8<16, CD8VT1>, TA; defm VMINMAXSS : avx10_minmax_scalar<"vminmaxss", v4f32x_info, X86vminmaxs, X86vminmaxsSae>,

[clang] [Clang] Implement C++26’s P2893R3 ‘Variadic friends’ (PR #101448)

2024-08-05 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/101448 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Restrict Ofast deprecation help message to Clang (PR #101682)

2024-08-05 Thread Kiran Chandramohan via cfe-commits
https://github.com/kiranchandramohan milestoned https://github.com/llvm/llvm-project/pull/101682 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] e60ee1f - [Driver] Restrict Ofast deprecation help message to Clang (#101682)

2024-08-05 Thread via cfe-commits
Author: Kiran Chandramohan Date: 2024-08-05T12:43:37+01:00 New Revision: e60ee1f2d70bdb0ac87b09ae685d669d8543b7bd URL: https://github.com/llvm/llvm-project/commit/e60ee1f2d70bdb0ac87b09ae685d669d8543b7bd DIFF: https://github.com/llvm/llvm-project/commit/e60ee1f2d70bdb0ac87b09ae685d669d8543b7bd.

[clang] [Driver] Restrict Ofast deprecation help message to Clang (PR #101682)

2024-08-05 Thread Kiran Chandramohan via cfe-commits
https://github.com/kiranchandramohan closed https://github.com/llvm/llvm-project/pull/101682 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Restrict Ofast deprecation help message to Clang (PR #101682)

2024-08-05 Thread Kiran Chandramohan via cfe-commits
kiranchandramohan wrote: /cherry-pick e60ee1f https://github.com/llvm/llvm-project/pull/101682 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86][AVX10.2] Support AVX10.2-SATCVT new instructions. (PR #101599)

2024-08-05 Thread Freddy Ye via cfe-commits
@@ -821,6 +821,88 @@ def X86vpdpbuuds : SDNode<"X86ISD::VPDPBUUDS", SDTVnni>; def X86Vmpsadbw : SDNode<"X86ISD::MPSADBW", SDTX86PSADBW>; +def SDTAVX10SATCVT_BF162I : SDTypeProfile<1, 1, [ + SDTCVecEltisVT<0, i16>, SDTCVecEltisVT<1, bf16> +]>; + +def SDTAVX10SATCVT_PH2I : SDT

[clang] [clang][PowerPC] Add flag to enable compatibility with GNU for complex arguments (PR #77732)

2024-08-05 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/77732 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][PowerPC] Add flag to enable compatibility with GNU for complex arguments (PR #77732)

2024-08-05 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: I'm wondering why the GNU-compatible behavior is not on by default, especially when in GNU mode (e.g., `-std=gnu17`)? Also, the changes should come with a release note in `clang/docs/ReleaseNotes.rst` so users know about the new functionality. https:

[clang] [clang][PowerPC] Add flag to enable compatibility with GNU for complex arguments (PR #77732)

2024-08-05 Thread Aaron Ballman via cfe-commits
@@ -1654,6 +1654,10 @@ void CompilerInvocationBase::GenerateCodeGenArgs(const CodeGenOptions &Opts, GenerateArg(Consumer, Opt); } + if (T.isPPC32() && Opts.ComplexInRegABI == CodeGenOptions::CMPLX_InGPR) { +GenerateArg(Consumer, OPT_fcomplex_ppc_gnu_abi); + } + --

[clang] [clang][PowerPC] Add flag to enable compatibility with GNU for complex arguments (PR #77732)

2024-08-05 Thread Aaron Ballman via cfe-commits
@@ -2028,6 +2032,10 @@ bool CompilerInvocation::ParseCodeGenArgs(CodeGenOptions &Opts, ArgList &Args, } } + if (Args.getLastArg(OPT_fcomplex_ppc_gnu_abi)) { +Opts.setComplexInRegABI(CodeGenOptions::CMPLX_InGPR); + } AaronBallman wrote: ```suggest

[clang] [clang][PowerPC] Add flag to enable compatibility with GNU for complex arguments (PR #77732)

2024-08-05 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,9 @@ +// RUN: %clang -c --target=ppc32 -fcomplex-ppc-gnu-abi %s 2>&1 AaronBallman wrote: It'd be nice for this to check `-###` output to ensure that it's passing along the correct `-cc1` option. https://github.com/llvm/llvm-project/pull/77732 ___

[clang] [Driver] Restrict Ofast deprecation help message to Clang (PR #101682)

2024-08-05 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#101963 https://github.com/llvm/llvm-project/pull/101682 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [X86][AVX10.2] Support AVX10.2-SATCVT new instructions. (PR #101599)

2024-08-05 Thread Freddy Ye via cfe-commits
https://github.com/FreddyLeaf edited https://github.com/llvm/llvm-project/pull/101599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Define __cpp_pack_indexing (PR #101956)

2024-08-05 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM. I think we should backport to Clang 19. WDYT? https://github.com/llvm/llvm-project/pull/101956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [llvm] [X86][AVX10.2] Support AVX10.2-SATCVT new instructions. (PR #101599)

2024-08-05 Thread Freddy Ye via cfe-commits
@@ -821,6 +821,88 @@ def X86vpdpbuuds : SDNode<"X86ISD::VPDPBUUDS", SDTVnni>; def X86Vmpsadbw : SDNode<"X86ISD::MPSADBW", SDTX86PSADBW>; +def SDTAVX10SATCVT_BF162I : SDTypeProfile<1, 1, [ + SDTCVecEltisVT<0, i16>, SDTCVecEltisVT<1, bf16> +]>; + +def SDTAVX10SATCVT_PH2I : SDT

[clang] c65afad - [Clang] Define __cpp_pack_indexing (#101956)

2024-08-05 Thread via cfe-commits
Author: Sirraide Date: 2024-08-05T14:02:15+02:00 New Revision: c65afad9c58474a784633314e945c874ed06584a URL: https://github.com/llvm/llvm-project/commit/c65afad9c58474a784633314e945c874ed06584a DIFF: https://github.com/llvm/llvm-project/commit/c65afad9c58474a784633314e945c874ed06584a.diff LOG:

[clang] [Clang] Define __cpp_pack_indexing (PR #101956)

2024-08-05 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/101956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Define __cpp_pack_indexing (PR #101956)

2024-08-05 Thread via cfe-commits
Sirraide wrote: > I think we should backport to Clang 19. WDYT? That makes a lot of sense to me imo: the feature is already in Clang 19, this just makes it so we claim to support it too. https://github.com/llvm/llvm-project/pull/101956 ___ cfe-commit

[clang] [Clang] Define __cpp_pack_indexing (PR #101956)

2024-08-05 Thread via cfe-commits
https://github.com/Sirraide milestoned https://github.com/llvm/llvm-project/pull/101956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Define __cpp_pack_indexing (PR #101956)

2024-08-05 Thread via cfe-commits
Sirraide wrote: /cherry-pick https://github.com/llvm/llvm-project/commit/c65afad9c58474a784633314e945c874ed06584a https://github.com/llvm/llvm-project/pull/101956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] 31bb759 - Fix an unused variable and -Wswitch warning after a42e515e3a9f3bb4e44389c097b89104d95b9b29

2024-08-05 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2024-08-05T14:05:14+02:00 New Revision: 31bb759d78576bec4c5b844edd52686eb6cc9fc3 URL: https://github.com/llvm/llvm-project/commit/31bb759d78576bec4c5b844edd52686eb6cc9fc3 DIFF: https://github.com/llvm/llvm-project/commit/31bb759d78576bec4c5b844edd52686eb6cc9fc3.diff LO

[clang] [Clang] Define __cpp_pack_indexing (PR #101956)

2024-08-05 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#101965 https://github.com/llvm/llvm-project/pull/101956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [MC] Emit a jump table size section (PR #101962)

2024-08-05 Thread Nabeel Omer via cfe-commits
https://github.com/omern1 updated https://github.com/llvm/llvm-project/pull/101962 >From 14f3cb82f0d7e69261bd7e1317bd66392e9a2c2b Mon Sep 17 00:00:00 2001 From: Nabeel Omer Date: Mon, 5 Aug 2024 11:50:18 +0100 Subject: [PATCH 1/3] [MC] Emit a jump table size section This patch will make LLVM e

[clang] [Clang] SFINAE on mismatching pack length during constraint satisfaction checking (PR #101879)

2024-08-05 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! This should be backported, thank you for the quick fix! https://github.com/llvm/llvm-project/pull/101879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [compiler-rt] [llvm] [PAC][AArch64] Support init/fini array signing (PR #96478)

2024-08-05 Thread Daniil Kovalev via cfe-commits
kovdan01 wrote: Ping: this PR blocks merging already approved #96159 (see https://github.com/llvm/llvm-project/pull/96159#issuecomment-2211411440), which transitively also blocks merging already approved dependent #96164. Would be glad to see feedback on the changes from those who are interest

[clang] 69c6a3f - More -Wswitch warning fixes for a42e515e3a9f3bb4e44389c097b89104d95b9b29

2024-08-05 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2024-08-05T14:21:34+02:00 New Revision: 69c6a3faafe8fa3fa8d7554e0ebe64aae3c3d10b URL: https://github.com/llvm/llvm-project/commit/69c6a3faafe8fa3fa8d7554e0ebe64aae3c3d10b DIFF: https://github.com/llvm/llvm-project/commit/69c6a3faafe8fa3fa8d7554e0ebe64aae3c3d10b.diff LO

[clang] da380b2 - [Clang] SFINAE on mismatching pack length during constraint satisfaction checking (#101879)

2024-08-05 Thread via cfe-commits
Author: cor3ntin Date: 2024-08-05T14:22:07+02:00 New Revision: da380b26e4748ade5a8dba85b7df5e1c4eded8bc URL: https://github.com/llvm/llvm-project/commit/da380b26e4748ade5a8dba85b7df5e1c4eded8bc DIFF: https://github.com/llvm/llvm-project/commit/da380b26e4748ade5a8dba85b7df5e1c4eded8bc.diff LOG:

[clang] [Clang] SFINAE on mismatching pack length during constraint satisfaction checking (PR #101879)

2024-08-05 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/101879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   >