https://github.com/kparzysz updated
https://github.com/llvm/llvm-project/pull/101058
>From e6286e542ede1dfe5b63ce3b8d86a78fc8c8c895 Mon Sep 17 00:00:00 2001
From: Krzysztof Parzyszek
Date: Mon, 29 Jul 2024 13:29:09 -0500
Subject: [PATCH 1/2] [clang][OpenMP] Rename `varlists` to `varlist`, NFC
AaronBallman wrote:
> We shouldn't merge this PR unless we need an immediate fix, which seems
> unlikely given how longstanding this behavior is.
Agreed, it's definitely not in shape for committing. As for needing an
immediate fix, what surprised me was that two different people ran into this
rjmccall wrote:
Note that we're forced to override that ABI rule in C++ sometimes — I believe
we're now required (since C++11?) to elide a copy/move when initializing a
normal object with a return value, and even if we weren't, it'd clearly be
unreasonable compiler behavior to do an extra non-
https://github.com/wangpc-pp approved this pull request.
https://github.com/llvm/llvm-project/pull/101046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
AaronBallman wrote:
I'm a bit less clear on what to do now. It sounds like nobody is opposed to a
language dialect flag (default off) so users can retain the existing behavior.
But it also sounds like perhaps the correct approach to this is to modify
codegen and not the NRVO markings when buil
https://github.com/PiJoules approved this pull request.
https://github.com/llvm/llvm-project/pull/100908
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vortex73 created
https://github.com/llvm/llvm-project/pull/101063
None
>From 97de745341dfc17e7ad9c595d239346a9114a4c6 Mon Sep 17 00:00:00 2001
From: Narayan Sreekumar
Date: Tue, 30 Jul 2024 00:18:46 +0530
Subject: [PATCH] [Clang] add support for handling assume attributes
-
https://github.com/vortex73 edited
https://github.com/llvm/llvm-project/pull/101063
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mizvekov wrote:
I agree it's strange choice the effects of elide-constructor are applied on the
CodeGen side, by ignoring the AST, instead of on the AST directly.
https://github.com/llvm/llvm-project/pull/101038
___
cfe-commits mailing list
cfe-commit
vortex73 wrote:
@steakhal Kinda stuck... It builds properly but doesn't detect the assume
attribute.
https://github.com/llvm/llvm-project/pull/101063
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listi
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 13996378d81c8fa9a364aeaafd7382abbc1db83a
97de745341dfc17e7ad9c595d239346a9114a4c6 --e
https://github.com/smanna12 created
https://github.com/llvm/llvm-project/pull/101066
…ship()
This patch replaces dyn_cast<> with cast<> for converting Callee to
FunctionDecl, asserting non-null assumption to prevent undefined behavior due
to null dereferences and enforces the invariant that C
https://github.com/smanna12 edited
https://github.com/llvm/llvm-project/pull/101066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/smanna12 edited
https://github.com/llvm/llvm-project/pull/101066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/smanna12 ready_for_review
https://github.com/llvm/llvm-project/pull/101066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (smanna12)
Changes
This patch replaces dyn_cast<> with cast<> for converting Callee to
FunctionDecl, asserting non-null assumption to prevent undefined behavior due
to null dereferences and enforces the invariant that Callee must be
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: None (smanna12)
Changes
This patch replaces dyn_cast<> with cast<> for converting Callee to
FunctionDecl, asserting non-null assumption to prevent undefined behavior due
to null dereferences and enforces the invariant th
steakhal wrote:
No, its cool. You are on the right track. Ill come back to you tomorrow.
https://github.com/llvm/llvm-project/pull/101063
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
rjmccall wrote:
My argument above is that the x86-64 psABI requires us to not pass `&t` as the
indirect return address. Following that rule fixes the problem here even if we
keep doing NRVO.
I think the approximate shape of the correct fix here is to:
(1) Use the function Eli pointed out to c
https://github.com/hanickadot updated
https://github.com/llvm/llvm-project/pull/98756
From e21d8acf36c188056bc2f08b60470fdd6d62cf7f Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Hana=20Dusi=CC=81kova=CC=81?=
Date: Sat, 13 Jul 2024 20:59:22 +0200
Subject: [PATCH] [clang] constexpr atomic builtins (__
https://github.com/HazardyKnusperkeks requested changes to this pull request.
You certainly can add the double hyphen flags, but you can't remove the single
ones.
https://github.com/llvm/llvm-project/pull/100978
___
cfe-commits mailing list
cfe-commit
mizvekov wrote:
>From my testing in compiler explorer, GCC and Clang always produce programs
>that return 1 as far back as we can test.
ICC and MSVC do otherwise, they return 0.
So I think this supports the notion that this should be a dialect, and we have
to wire defaults differently in MSVC
https://github.com/xingxue-ibm created
https://github.com/llvm/llvm-project/pull/101069
Patch [llvm#92291](https://github.com/llvm/llvm-project/pull/92291) causes
wrong traceback from a signal handler for AIX because the AIX unwinder uses the
traceback table at the end of each function instead
llvmbot wrote:
@llvm/pr-subscribers-libunwind
Author: Xing Xue (xingxue-ibm)
Changes
Patch [llvm#92291](https://github.com/llvm/llvm-project/pull/92291)
causes wrong traceback from a signal handler for AIX because the AIX unwinder
uses the traceback table at the end of each function inst
https://github.com/smanna12 edited
https://github.com/llvm/llvm-project/pull/101066
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/88978
>From 3acc848f4fcc68445dfc849f9c6f8d384d3692af Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Tue, 16 Apr 2024 13:09:58 -0700
Subject: [PATCH 01/14] Adding C23 constexpr math functions fmin and frexp.
https://github.com/DeinAlptraum created
https://github.com/llvm/llvm-project/pull/101070
Resolves #101041
>From 521082f25bc42104fd436a412b2de2edb60b7b0e Mon Sep 17 00:00:00 2001
From: Jannick Kremer
Date: Mon, 29 Jul 2024 20:24:15 +0100
Subject: [PATCH] [Clang][Sema] Remove duplicate check in
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Jannick Kremer (DeinAlptraum)
Changes
Resolves #101041
---
Full diff: https://github.com/llvm/llvm-project/pull/101070.diff
1 Files Affected:
- (modified) clang/lib/Sema/SemaOpenMP.cpp (+1-2)
``diff
diff --git a/clang/lib/Se
zygoloid wrote:
> Richard, I'm sorry to contradict you, but Aaron is correct to guess that this
> is ABI-affecting: ABIs should and sometimes do specify whether an indirect
> return address is allowed to be aliased.
My claim was narrowly that the choice to perform or not perform NRVO for an
i
magic-akari wrote:
> You certainly can add the double hyphen flags, but you can't remove the
> single ones.
There seems to be a misunderstanding. Please review the original issue.
I did _not_ eliminate support for single hyphens in clang-format.
What I did was modify the scripts that call c
DeinAlptraum wrote:
@zyn0217 I hope you're the right person to ask for a review here?
https://github.com/llvm/llvm-project/pull/101070
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma-quic wrote:
>So I think this supports the notion that this should be a dialect, and we have
>to wire defaults differently in MSVC mode as well.
I doubt anyone is intentionally depending on equality here.
> C++ does have some restrictions on accessing objects that are being
> initiali
https://github.com/daltenty milestoned
https://github.com/llvm/llvm-project/pull/101069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/daltenty approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/101069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mizvekov wrote:
> I doubt anyone is intentionally depending on equality here.
>
The difference wrt the gnu::cleanup behavior looks plausible:
https://github.com/llvm/llvm-project/issues/100868
https://github.com/llvm/llvm-project/pull/101038
___
cf
HazardyKnusperkeks wrote:
My bad, I thought you changed the options to those scripts.
https://github.com/llvm/llvm-project/pull/100978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HazardyKnusperkeks wrote:
Okay, I can't revoke my vote and remove me as reviewer. As demonstrated I'm not
qualified to review python changes.
https://github.com/llvm/llvm-project/pull/100978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
http
https://github.com/cwarner-8702 created
https://github.com/llvm/llvm-project/pull/101073
Expanding on [the previous
PR](https://github.com/llvm/llvm-project/pull/98352), this is an attempt to
remove the limitation that the option can only apply to signed integer types.
Because unsigned types
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-tidy
@llvm/pr-subscribers-clang-tools-extra
Author: Chris Warner (cwarner-8702)
Changes
Expanding on [the previous
PR](https://github.com/llvm/llvm-project/pull/98352), this is an attempt to
remove the limitation that t
https://github.com/RSilicon closed
https://github.com/llvm/llvm-project/pull/85316
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/xingxue-ibm updated
https://github.com/llvm/llvm-project/pull/101069
>From 05110959c01b5b7d4f2530e4d21232053db939f3 Mon Sep 17 00:00:00 2001
From: Xing Xue
Date: Mon, 29 Jul 2024 14:53:36 -0400
Subject: [PATCH 1/2] Fix the problem introduced by upstream patch
https://github.
https://github.com/kparzysz updated
https://github.com/llvm/llvm-project/pull/101058
>From e6286e542ede1dfe5b63ce3b8d86a78fc8c8c895 Mon Sep 17 00:00:00 2001
From: Krzysztof Parzyszek
Date: Mon, 29 Jul 2024 13:29:09 -0500
Subject: [PATCH 1/3] [clang][OpenMP] Rename `varlists` to `varlist`, NFC
https://github.com/compnerd approved this pull request.
https://github.com/llvm/llvm-project/pull/101069
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -32,6 +32,9 @@ def builtin_bitcode_EQ : Joined<["--"], "builtin-bitcode=">,
def device_linker_args_EQ : Joined<["--"], "device-linker=">,
Flags<[WrapperOnlyOption]>, MetaVarName<" or =">,
HelpText<"Arguments to pass to the device linker invocation">;
+def device_compiler
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/101032
>From 19d0d5622fbc5b7df07e2fc907b8e7c50216bcde Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Mon, 29 Jul 2024 10:36:12 -0500
Subject: [PATCH 1/2] [LinkerWrapper] Make `-Xoffload-linker` match `-Xlinker`
sem
https://github.com/jdenny-ornl approved this pull request.
https://github.com/llvm/llvm-project/pull/101032
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/njames93 updated
https://github.com/llvm/llvm-project/pull/99917
>From 4762dc02504b63ad8ee5922e0f051aff6c4b1f15 Mon Sep 17 00:00:00 2001
From: Nathan James
Date: Tue, 23 Jul 2024 10:59:45 +0100
Subject: [PATCH] Create a new check to look for mis-use in calls that take
iterat
rjmccall wrote:
I accept your pedantry. 🫡
> Do we support ABIs that don't have a rule like x86_64's?
The ARM and ARM64 AAPCSs specify that "The memory to be used for the result may
be modified at any point during the function call" and "The callee may modify
the result memory block at any po
rjmccall wrote:
> > C++ does have some restrictions on accessing objects that are being
> > initialized through other names. It's possible that they're strong enough
> > to satisfy the ABI rule here through a sort of reverse of the normal
> > analysis: basically, any program that would violate
https://github.com/jplehr commented:
Do we have some sort of documentation where this change of behavior needs to be
communicated?
https://github.com/llvm/llvm-project/pull/101032
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.l
https://github.com/jyknight approved this pull request.
LGTM, thanks.
https://github.com/llvm/llvm-project/pull/101005
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
apivovarov wrote:
If there are no further questions, comments, or objections, I will merge this
PR in a few hours.
https://github.com/llvm/llvm-project/pull/99698
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
jhuber6 wrote:
> Do we have some sort of documentation where this change of behavior needs to
> be communicated?
Could probably specify it more in the docs.
https://github.com/llvm/llvm-project/pull/101032
___
cfe-commits mailing list
cfe-commits@lis
https://github.com/JustinStitt updated
https://github.com/llvm/llvm-project/pull/100272
>From 06b702cd38943314b2e6f873e64d70baed6f57f7 Mon Sep 17 00:00:00 2001
From: Justin Stitt
Date: Tue, 23 Jul 2024 20:21:49 +
Subject: [PATCH 1/5] implement idiom exclusions
Add flag `-fno-sanitize-overf
@@ -492,6 +493,18 @@ void Flang::addOffloadOptions(Compilation &C, const
InputInfoList &Inputs,
if (Args.hasArg(options::OPT_nogpulib))
CmdArgs.push_back("-nogpulib");
}
+
+ // For all the host OpenMP offloading compile jobs we need to pass the
targets
+ // info
https://github.com/shiltian edited
https://github.com/llvm/llvm-project/pull/99732
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
qiongsiwu wrote:
> I'm wondering why this option isn't on by default for AIX. I don't think
> anyone is going to know to turn this option on, whereas if it's on by
> default, users have to make a decision as to how to proceed, which seems like
> the better default.
Yes I agree. This is at th
efriedma-quic wrote:
> > And C++17 rules forbid a copy on the caller side: "guaranteed copy elision"
> > means semantically, there is no copy.
>
> An extra copy is permitted for trivially-copyable types; otherwise we'd be
> required to pass and return all classes indirectly. So we're not forbi
zygoloid wrote:
> Typically, the absence of a statement must be interpreted as a lack of a
> guarantee. In this case, however, I would argue it is more plausible to infer
> that the ABI authors did not consider the possibility of passing a pointer to
> aliased memory for the return value, and
https://github.com/efriedma-quic approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/99849
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvm-beanz created
https://github.com/llvm/llvm-project/pull/101083
HLSL output parameters are denoted with the `inout` and `out` keywords in the
function declaration. When an argument to an output parameter is constructed a
temporary value is constructed for the argument.
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-hlsl
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Chris B (llvm-beanz)
Changes
HLSL output parameters are denoted with the `inout` and `out` keywords in the
function declaration. When an argument to an output parameter
https://github.com/llvm-beanz edited
https://github.com/llvm/llvm-project/pull/101083
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -21587,32 +21597,39 @@ const ValueDecl
*SemaOpenMP::getOpenMPDeclareMapperVarName() const {
return cast(DSAStack->getDeclareMapperVarRef())->getDecl();
}
-OMPClause *SemaOpenMP::ActOnOpenMPNumTeamsClause(Expr *NumTeams,
+OMPClause *SemaOpenMP::ActOnOpenMPNumTeamsClause(A
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff fb7028237bac1dccd328b6c3150e50e222a0879b
874a9d50b63f2ed7220b2e19e8377b545455cd69 --e
chaitanyav wrote:
I am moving this under readability, i will also post some code on how am i
planning to output a fix. For now i don't have a good way to handle
```
int a = /*some value */ 5;
```
https://github.com/llvm/llvm-project/pull/99713
___
c
https://github.com/llvm-beanz updated
https://github.com/llvm/llvm-project/pull/101083
>From e8ec3e24e0061714b5dc440b1b92086965809483 Mon Sep 17 00:00:00 2001
From: Chris Bieneman
Date: Mon, 29 Jul 2024 16:05:11 -0500
Subject: [PATCH] [HLSL] Implement output parameter
HLSL output parameters ar
https://github.com/topperc approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/101046
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/efriedma-quic commented:
Approach generally seems fine; not sure I'll have time to look more closely.
https://github.com/llvm/llvm-project/pull/101083
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/efriedma-quic edited
https://github.com/llvm/llvm-project/pull/101083
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4057,6 +4057,10 @@ bool Sema::MergeFunctionDecl(FunctionDecl *New,
NamedDecl *&OldD, Scope *S,
NewQType))
return MergeCompatibleFunctionDecls(New, Old, S, MergeTypeWithOld);
+if (getLangOpts().HLSL && Cont
https://github.com/mrexodia edited
https://github.com/llvm/llvm-project/pull/100759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/efriedma-quic closed
https://github.com/llvm/llvm-project/pull/94282
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma-quic wrote:
Don't have time to continue looking at this for now.
https://github.com/llvm/llvm-project/pull/94282
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/apolloww updated
https://github.com/llvm/llvm-project/pull/100205
>From bd652d600a1b1c71fcc2d399f33024ca5c78f5ce Mon Sep 17 00:00:00 2001
From: Wei Wang
Date: Mon, 29 Apr 2024 10:24:53 -0700
Subject: [PATCH] [Pipelines] Do not run CoroSplit and CoroCleanup in ThinLTO
pre-lin
@@ -4057,6 +4057,10 @@ bool Sema::MergeFunctionDecl(FunctionDecl *New,
NamedDecl *&OldD, Scope *S,
NewQType))
return MergeCompatibleFunctionDecls(New, Old, S, MergeTypeWithOld);
+if (getLangOpts().HLSL && Cont
@@ -4148,6 +4151,30 @@ static void emitWriteback(CodeGenFunction &CGF,
assert(!isProvablyNull(srcAddr.getBasePointer()) &&
"shouldn't have writeback for provably null argument");
+ if (CGF.getLangOpts().HLSL) {
+if (writeback.CastExpr) {
+ RValue TmpVal =
https://github.com/apolloww updated
https://github.com/llvm/llvm-project/pull/100205
>From 041670dc6a8e9f6a86af152567f0705034db6ad2 Mon Sep 17 00:00:00 2001
From: Wei Wang
Date: Mon, 29 Apr 2024 10:24:53 -0700
Subject: [PATCH 1/2] [Pipelines] Do not run CoroSplit and CoroCleanup in
ThinLTO pre
https://github.com/topperc edited
https://github.com/llvm/llvm-project/pull/100110
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvm-beanz edited
https://github.com/llvm/llvm-project/pull/101083
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/macurtis-amd updated
https://github.com/llvm/llvm-project/pull/101008
>From 5590228721e4ce719001311137d8eb674b0e2a3d Mon Sep 17 00:00:00 2001
From: Matthew Curtis
Date: Thu, 25 Jul 2024 15:37:25 -0500
Subject: [PATCH 1/3] [clang-linker-wrapper] Add '--lto-in-process' to force
https://github.com/macurtis-amd edited
https://github.com/llvm/llvm-project/pull/101008
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4057,6 +4057,10 @@ bool Sema::MergeFunctionDecl(FunctionDecl *New,
NamedDecl *&OldD, Scope *S,
NewQType))
return MergeCompatibleFunctionDecls(New, Old, S, MergeTypeWithOld);
+if (getLangOpts().HLSL && Cont
https://github.com/mrexodia edited
https://github.com/llvm/llvm-project/pull/100759
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rjmccall wrote:
> Should we try to convince at least the GCC folks that they're getting this
> wrong too?
It does feel like a wider conversation is necessary, yeah. The fact that
everybody is doing this even on x86_64 where it's pretty incontrovertibly
forbidden seems significant.
https://g
https://github.com/shafik updated
https://github.com/llvm/llvm-project/pull/95474
>From 69b09ea5b0f0a1c5419c488ade29b6fedc6de773 Mon Sep 17 00:00:00 2001
From: Shafik Yaghmour
Date: Thu, 13 Jun 2024 14:20:50 -0700
Subject: [PATCH 1/4] [Clang] Implement P2280R4 Using unknown pointers and
refere
@@ -781,6 +791,8 @@ bool isValidCIdentifier(StringRef S) {
Error linkBitcodeFiles(SmallVectorImpl &InputFiles,
SmallVectorImpl &OutputFiles,
const ArgList &Args) {
+ if (Verbose)
+llvm::errs() << "Linking bitcode files\n";
@@ -581,8 +581,16 @@ Expected clang(ArrayRef InputFiles,
const ArgList &Args) {
if (SaveTemps)
CmdArgs.push_back("-save-temps");
- if (SaveTemps && linkerSupportsLTO(Args))
-CmdArgs.push_back("-Wl,--save-temps");
+ if (linkerSupportsLTO(Args)) {
+if (SaveTemps
@@ -581,8 +581,16 @@ Expected clang(ArrayRef InputFiles,
const ArgList &Args) {
if (SaveTemps)
CmdArgs.push_back("-save-temps");
- if (SaveTemps && linkerSupportsLTO(Args))
-CmdArgs.push_back("-Wl,--save-temps");
+ if (linkerSupportsLTO(Args)) {
+if (SaveTemps
https://github.com/MaskRay created
https://github.com/llvm/llvm-project/pull/101103
compile_commands.json entries often have -c. When adding -fsyntax-only,
we should remove -c to prevent the following warning:
```
% clang -c -fsyntax-only a.c
clang: warning: argument unused during compilation:
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Fangrui Song (MaskRay)
Changes
compile_commands.json entries often have -c. When adding -fsyntax-only,
we should remove -c to prevent the following warning:
```
% clang -c -fsyntax-only a.c
clang: warning: argument unused during compilatio
https://github.com/PeterChou1 created
https://github.com/llvm/llvm-project/pull/101104
Fixes https://github.com/llvm/llvm-project/issues/96819
currently the html output for clang-doc does not include block command comments
this patch modifies the html generator to generate its output
>From fb
https://github.com/MaxEW707 updated
https://github.com/llvm/llvm-project/pull/99833
>From e0528ecc441e33822426b8b3d6522d056c95bb54 Mon Sep 17 00:00:00 2001
From: MaxEW707
Date: Fri, 21 Jun 2024 20:37:40 -0700
Subject: [PATCH 1/7] Support MSVC lvalue to temporary reference binding
---
clang/do
https://github.com/zyn0217 approved this pull request.
Thanks.
(However I'm not an OpenMP maintainer, but since this PR is clearly an NFC
change, I'd boldly approve it.)
https://github.com/llvm/llvm-project/pull/101070
___
cfe-commits mailing list
cfe
https://github.com/ChuanqiXu9 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/100739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4543,7 +4544,7 @@ ASTReader::ASTReadResult ASTReader::ReadAST(StringRef
FileName, ModuleKind Type,
// Mark this identifier as being from an AST file so that we can track
// whether we need to serialize it.
- markIdentifierFromAST(*this, *II);
+ markI
https://github.com/ChuanqiXu9 edited
https://github.com/llvm/llvm-project/pull/100739
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
zyn0217 wrote:
(I presume you don't have commit access, so I'll help you merge it. Next time,
please add an "NFC" term to the commit title if the PR doesn't contain any
functional changes.)
https://github.com/llvm/llvm-project/pull/101070
___
cfe-com
Author: Jannick Kremer
Date: 2024-07-30T10:02:15+08:00
New Revision: c9cc6c4772df6fc6f30d1e6831b83fe4db5f2044
URL:
https://github.com/llvm/llvm-project/commit/c9cc6c4772df6fc6f30d1e6831b83fe4db5f2044
DIFF:
https://github.com/llvm/llvm-project/commit/c9cc6c4772df6fc6f30d1e6831b83fe4db5f2044.diff
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/101070
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
301 - 400 of 419 matches
Mail list logo
