[clang] [APINotes] Do not crash for C++ operators (PR #101001)

2024-07-29 Thread Saleem Abdulrasool via cfe-commits
@@ -1044,11 +1044,13 @@ void Sema::ProcessAPINotes(Decl *D) { if (auto TagContext = dyn_cast(D->getDeclContext())) { if (auto CXXMethod = dyn_cast(D)) { - for (auto Reader : APINotes.findAPINotes(D->getLocation())) { -if (auto Context = UnwindTagContext(TagC

[clang] [llvm] [Sanitizer] Make sanitizer passes idempotent (PR #99439)

2024-07-29 Thread via cfe-commits
https://github.com/skc7 updated https://github.com/llvm/llvm-project/pull/99439 >From 2bcca883eae902238cb49d44ed24aa1304364646 Mon Sep 17 00:00:00 2001 From: skc7 Date: Thu, 18 Jul 2024 11:49:24 +0530 Subject: [PATCH 1/3] [Sanitizer] Make sanitizer passes idempotent. --- clang/test/CodeGenObjC

[clang] [llvm] [Sanitizer] Make sanitizer passes idempotent (PR #99439)

2024-07-29 Thread via cfe-commits
@@ -12,12 +12,33 @@ //===--===// #include "llvm/Transforms/Instrumentation.h" +#include "llvm/IR/DiagnosticInfo.h" #include "llvm/IR/IntrinsicInst.h" #include "llvm/IR/Module.h" #include "llvm/TargetParser

[clang] [APINotes] Do not crash for C++ operators (PR #101001)

2024-07-29 Thread Egor Zhdan via cfe-commits
@@ -1044,11 +1044,13 @@ void Sema::ProcessAPINotes(Decl *D) { if (auto TagContext = dyn_cast(D->getDeclContext())) { if (auto CXXMethod = dyn_cast(D)) { - for (auto Reader : APINotes.findAPINotes(D->getLocation())) { -if (auto Context = UnwindTagContext(TagC

[clang] [PS4/PS5][Driver] Allow unified-lto.c test to find .*ld.exe (PR #101034)

2024-07-29 Thread Edd Dawson via cfe-commits
https://github.com/playstation-edd created https://github.com/llvm/llvm-project/pull/101034 It's common in SIE development environments to have the PlayStation linkers on the %PATH%. In such cases, the driver will resolve the linker name to an existing executable, replete with ".exe" extension

[clang] [PS4/PS5][Driver] Allow unified-lto.c test to find .*ld.exe (PR #101034)

2024-07-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Edd Dawson (playstation-edd) Changes It's common in SIE development environments to have the PlayStation linkers on the %PATH%. In such cases, the driver will resolve the linker name to an existing executable, replete with ".exe" extensio

[clang] [PS4/PS5][Driver] Allow unified-lto.c test to find .*ld.exe (PR #101034)

2024-07-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Edd Dawson (playstation-edd) Changes It's common in SIE development environments to have the PlayStation linkers on the %PATH%. In such cases, the driver will resolve the linker name to an existing executable, replete with ".exe" e

[clang-tools-extra] Create a new check to look for mis-use in calls that take iterators (PR #99917)

2024-07-29 Thread Julian Schmidt via cfe-commits
5chmidti wrote: The `++` and `--` operators could be mis-used as well, similar to `+` and `-`. And there are some control statements with a single statement that has a compound statement around it, please remove those. Checking the log, it looks like the check works well. I know that TBB has

[clang] [APINotes] Do not crash for C++ operators (PR #101001)

2024-07-29 Thread Saleem Abdulrasool via cfe-commits
@@ -1044,11 +1044,13 @@ void Sema::ProcessAPINotes(Decl *D) { if (auto TagContext = dyn_cast(D->getDeclContext())) { if (auto CXXMethod = dyn_cast(D)) { - for (auto Reader : APINotes.findAPINotes(D->getLocation())) { -if (auto Context = UnwindTagContext(TagC

[clang] [PS4/PS5][Driver] Allow unified-lto.c test to find .*ld.exe (PR #101034)

2024-07-29 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/101034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement CWG2627 Bit-fields and narrowing conversions (PR #78112)

2024-07-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: I'm pretty sure the C implementation of `constexpr` leans on this code to determine if the value is exactly representable without a change in value. But it looks like Clang currently doesn't get this quite right: https://godbolt.org/z/W3a8cPjnM Can yo

[clang] 7b3db55 - [libclang/python] Export all enums (#100941)

2024-07-29 Thread via cfe-commits
Author: Jannick Kremer Date: 2024-07-29T20:24:26+04:00 New Revision: 7b3db551e499a7ecef6a29c0ffbc923c45277332 URL: https://github.com/llvm/llvm-project/commit/7b3db551e499a7ecef6a29c0ffbc923c45277332 DIFF: https://github.com/llvm/llvm-project/commit/7b3db551e499a7ecef6a29c0ffbc923c45277332.diff

[clang] [libclang/python] Export all enums (PR #100941)

2024-07-29 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/100941 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] prevent checking destructor reference with an invalid initializer (PR #97860)

2024-07-29 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @cor3ntin If no further feedback is needed, could you please proceed with the merge? Thanks https://github.com/llvm/llvm-project/pull/97860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [APINotes] Do not crash for C++ operators (PR #101001)

2024-07-29 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan updated https://github.com/llvm/llvm-project/pull/101001 >From 63e76d8e6576f651b7a2aa6358444e82e8a1b662 Mon Sep 17 00:00:00 2001 From: Egor Zhdan Date: Mon, 29 Jul 2024 13:01:18 +0100 Subject: [PATCH] [APINotes] Do not crash for C++ operators This fixes a crash dur

[clang] [APINotes] Do not crash for C++ operators (PR #101001)

2024-07-29 Thread Egor Zhdan via cfe-commits
@@ -1044,11 +1044,13 @@ void Sema::ProcessAPINotes(Decl *D) { if (auto TagContext = dyn_cast(D->getDeclContext())) { if (auto CXXMethod = dyn_cast(D)) { - for (auto Reader : APINotes.findAPINotes(D->getLocation())) { -if (auto Context = UnwindTagContext(TagC

[clang] [clang][CUDA] Add 'noconvergent' function and statement attribute (PR #100637)

2024-07-29 Thread via cfe-commits
https://github.com/darkbuck updated https://github.com/llvm/llvm-project/pull/100637 >From d9de73264bf4d555e7e09a2c2687eae72c1fa19e Mon Sep 17 00:00:00 2001 From: Michael Liao Date: Thu, 25 Jul 2024 15:19:15 -0400 Subject: [PATCH 1/7] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?U

[clang] [clang][CUDA] Add 'noconvergent' function and statement attribute (PR #100637)

2024-07-29 Thread via cfe-commits
https://github.com/darkbuck edited https://github.com/llvm/llvm-project/pull/100637 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Correctly pass the target-id to `ld.lld` (PR #101037)

2024-07-29 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/101037 Summary: The `ld.lld` linker handles LTO, but it does not understand the target-id syntax some AMDGPU targets use. This patch parses the target-id and passes the processor name in `-mcpu` and features in `-mattr`

[clang] [analyzer] Don't invalidate the super region when a std object ctor runs (PR #100405)

2024-07-29 Thread Balazs Benics via cfe-commits
@@ -923,12 +923,31 @@ SVal AnyCXXConstructorCall::getCXXThisVal() const { return UnknownVal(); } +static bool isWithinStdNamespace(const Decl *D) { steakhal wrote: @AaronBallman Do you think we clang already has something like this? Or it would make sense

[clang] [AMDGPU] Correctly pass the target-id to `ld.lld` (PR #101037)

2024-07-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Joseph Huber (jhuber6) Changes Summary: The `ld.lld` linker handles LTO, but it does not understand the target-id syntax some AMDGPU targets use. This patch parses the target-id and passes the processor name in `-mcpu` and features

[clang] [APINotes] Do not crash for C++ operators (PR #101001)

2024-07-29 Thread Saleem Abdulrasool via cfe-commits
https://github.com/compnerd approved this pull request. https://github.com/llvm/llvm-project/pull/101001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CUDA] Add 'noconvergent' function and statement attribute (PR #100637)

2024-07-29 Thread via cfe-commits
darkbuck wrote: > We should be removing the source level convergent attribute, not adding more > uses of it. It was a mistake to define it in the positive direction, and it > is completely unusable for end users. Every piece of code that transitively > calls the function in the entire program

[clang] [clang][CUDA] Add 'noconvergent' function and statement attribute (PR #100637)

2024-07-29 Thread Matt Arsenault via cfe-commits
@@ -10,36 +11,74 @@ #include "Inputs/cuda.h" -// DEVICE: Function Attrs: -// DEVICE-SAME: convergent -// DEVICE-NEXT: define{{.*}} void @_Z3foov +// DEVICE-LABEL: define dso_local void @_Z3foov( +// DEVICE-SAME: ) #[[ATTR0:[0-9]+]] { +// DEVICE-NEXT: [[ENTRY:.*:]] +// DEVICE

[clang] [clang][CUDA] Add 'noconvergent' function and statement attribute (PR #100637)

2024-07-29 Thread Matt Arsenault via cfe-commits
@@ -1380,10 +1379,31 @@ Sample usage: // Setting it as a C++11 attribute is also valid in a C++ program. // void convfunc(void) [[clang::convergent]]; - int f() { -[[clang::convergent]] foo(arg); -// The call to 'foo' has attribute 'convergent'. + }]; +} + +def N

[clang] [clang][CUDA] Add 'noconvergent' function and statement attribute (PR #100637)

2024-07-29 Thread Matt Arsenault via cfe-commits
@@ -1357,11 +1357,10 @@ of the condition. def ConvergentDocs : Documentation { let Category = DocCatFunction; let Content = [{ -The ``convergent`` attribute can be placed on a function declaration or a -statement containing call expressions. It is translated into the LLVM -

[clang] [clang][CUDA] Add 'noconvergent' function and statement attribute (PR #100637)

2024-07-29 Thread Matt Arsenault via cfe-commits
@@ -5636,9 +5639,10 @@ RValue CodeGenFunction::EmitCall(const CGFunctionInfo &CallInfo, Attrs = Attrs.addFnAttribute(getLLVMContext(), llvm::Attribute::AlwaysInline); - // Add call-site convergent attribute if exists. - if (InConvergentAttributedStmt) -Attrs

[clang] [AMDGPU] Correctly pass the target-id to `ld.lld` (PR #101037)

2024-07-29 Thread Matt Arsenault via cfe-commits
@@ -634,7 +634,17 @@ void amdgpu::Linker::ConstructJob(Compilation &C, const JobAction &JA, C.getDriver().getLTOMode() == LTOK_Thin); else if (Args.hasArg(options::OPT_mcpu_EQ)) CmdArgs.push_back(Args.MakeArgString( -"-plugin-opt=mcpu=" + Args.g

[clang] [AMDGPU] Correctly pass the target-id to `ld.lld` (PR #101037)

2024-07-29 Thread Matt Arsenault via cfe-commits
@@ -634,7 +634,17 @@ void amdgpu::Linker::ConstructJob(Compilation &C, const JobAction &JA, C.getDriver().getLTOMode() == LTOK_Thin); else if (Args.hasArg(options::OPT_mcpu_EQ)) arsenm wrote: Braces https://github.com/llvm/llvm-project/pu

[clang] ee57ce5 - [Clang] prevent checking destructor reference with an invalid initializer (#97860)

2024-07-29 Thread via cfe-commits
Author: Oleksandr T. Date: 2024-07-29T18:39:30+02:00 New Revision: ee57ce57d8094026e2795182758bc57027a72293 URL: https://github.com/llvm/llvm-project/commit/ee57ce57d8094026e2795182758bc57027a72293 DIFF: https://github.com/llvm/llvm-project/commit/ee57ce57d8094026e2795182758bc57027a72293.diff

[clang] [Clang] prevent checking destructor reference with an invalid initializer (PR #97860)

2024-07-29 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/97860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Don't invalidate the super region when a std object ctor runs (PR #100405)

2024-07-29 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/100405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Correctly pass the target-id to `ld.lld` (PR #101037)

2024-07-29 Thread Gheorghe-Teodor Bercea via cfe-commits
https://github.com/doru1004 approved this pull request. LG https://github.com/llvm/llvm-project/pull/101037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Correctly pass the target-id to `ld.lld` (PR #101037)

2024-07-29 Thread Joseph Huber via cfe-commits
@@ -634,7 +634,17 @@ void amdgpu::Linker::ConstructJob(Compilation &C, const JobAction &JA, C.getDriver().getLTOMode() == LTOK_Thin); else if (Args.hasArg(options::OPT_mcpu_EQ)) CmdArgs.push_back(Args.MakeArgString( -"-plugin-opt=mcpu=" + Args.g

[clang] [Clang] prevent checking destructor reference with an invalid initializer (PR #97860)

2024-07-29 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @cor3ntin thanks https://github.com/llvm/llvm-project/pull/97860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Don't invalidate the super region when a std object ctor runs (PR #100405)

2024-07-29 Thread Aaron Ballman via cfe-commits
@@ -923,12 +923,31 @@ SVal AnyCXXConstructorCall::getCXXThisVal() const { return UnknownVal(); } +static bool isWithinStdNamespace(const Decl *D) { AaronBallman wrote: We've already got one of these at home: https://github.com/llvm/llvm-project/blob/ee57ce

[clang] [AMDGPU] Correctly pass the target-id to `ld.lld` (PR #101037)

2024-07-29 Thread Joseph Huber via cfe-commits
@@ -634,7 +634,17 @@ void amdgpu::Linker::ConstructJob(Compilation &C, const JobAction &JA, C.getDriver().getLTOMode() == LTOK_Thin); else if (Args.hasArg(options::OPT_mcpu_EQ)) CmdArgs.push_back(Args.MakeArgString( -"-plugin-opt=mcpu=" + Args.g

[clang] [clang][CUDA] Add 'noconvergent' function and statement attribute (PR #100637)

2024-07-29 Thread via cfe-commits
@@ -5636,9 +5639,10 @@ RValue CodeGenFunction::EmitCall(const CGFunctionInfo &CallInfo, Attrs = Attrs.addFnAttribute(getLLVMContext(), llvm::Attribute::AlwaysInline); - // Add call-site convergent attribute if exists. - if (InConvergentAttributedStmt) -Attrs

[clang] Fix hasName matcher assertion with inline namespaces (PR #100975)

2024-07-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/100975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Disallow applying `onwership_returns` to functions that return non-pointers (PR #99564)

2024-07-29 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. https://github.com/llvm/llvm-project/pull/99564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 150bf63 - [Clang][Sema] Disallow applying `onwership_returns` to functions that return non-pointers (#99564)

2024-07-29 Thread via cfe-commits
Author: Pavel Skripkin Date: 2024-07-29T18:43:50+02:00 New Revision: 150bf637baad2ba4df6369600b65d897ed9b31a7 URL: https://github.com/llvm/llvm-project/commit/150bf637baad2ba4df6369600b65d897ed9b31a7 DIFF: https://github.com/llvm/llvm-project/commit/150bf637baad2ba4df6369600b65d897ed9b31a7.diff

[clang] [Clang][Sema] Disallow applying `onwership_returns` to functions that return non-pointers (PR #99564)

2024-07-29 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/99564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Disallow applying `onwership_returns` to functions that return non-pointers (PR #99564)

2024-07-29 Thread via cfe-commits
github-actions[bot] wrote: @pskrgag Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build,

[clang] [Clang][Sema] Make UnresolvedLookupExprs in class scope explicit specializations instantiation dependent (PR #100392)

2024-07-29 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/100392 >From c4f8a620a2a4692c9fa27b41f7e86c8cb042e533 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Wed, 24 Jul 2024 10:15:47 -0400 Subject: [PATCH] [Clang][Sema] Make UnresolvedLookupExprs in class scope

[clang] [libcxx] Reapply "[Clang] Implement resolution for CWG1835 (#92957, #98547)" (PR #100425)

2024-07-29 Thread Krystian Stasiowski via cfe-commits
@@ -767,6 +757,7 @@ bool Sema::BuildCXXNestedNameSpecifier(Scope *S, NestedNameSpecInfo &IdInfo, else Diag(IdInfo.IdentifierLoc, diag::err_undeclared_var_use) << IdInfo.Identifier; +#endif sdkrystian wrote: Yeah, these changes shouldn't really b

[clang] [analyzer] Don't invalidate the super region when a std object ctor runs (PR #100405)

2024-07-29 Thread Balazs Benics via cfe-commits
@@ -923,12 +923,31 @@ SVal AnyCXXConstructorCall::getCXXThisVal() const { return UnknownVal(); } +static bool isWithinStdNamespace(const Decl *D) { steakhal wrote: AFAIK not quite. Mine works even if the class a nested subclass within the std namespace, su

[clang] [Clang][Interp] Fix the location of uninitialized base warning (PR #100761)

2024-07-29 Thread via cfe-commits
https://github.com/Sirraide requested changes to this pull request. `CXXRecordDecl` already exposes `bases()` and `vbases()`, I don’t think we need this new API for accessing a base by index. This pr looks like it should just be using `llvm::enumerate`. https://github.com/llvm/llvm-project/pul

[clang] [AMDGPU] Correctly pass the target-id to `ld.lld` (PR #101037)

2024-07-29 Thread Matt Arsenault via cfe-commits
@@ -634,7 +634,17 @@ void amdgpu::Linker::ConstructJob(Compilation &C, const JobAction &JA, C.getDriver().getLTOMode() == LTOK_Thin); else if (Args.hasArg(options::OPT_mcpu_EQ)) CmdArgs.push_back(Args.MakeArgString( -"-plugin-opt=mcpu=" + Args.g

[clang-tools-extra] Create a new check to look for mis-use in calls that take iterators (PR #99917)

2024-07-29 Thread Nathan James via cfe-commits
njames93 wrote: > The `++` and `--` operators could be mis-used as well, similar to `+` and > `-`. And there are some control statements with a single statement that has a > compound statement around it, please remove those. The `++` and `--` operators work on lvalues only(`std::end(Range)++`

[clang] [AMDGPU] Correctly pass the target-id to `ld.lld` (PR #101037)

2024-07-29 Thread Joseph Huber via cfe-commits
@@ -634,7 +634,17 @@ void amdgpu::Linker::ConstructJob(Compilation &C, const JobAction &JA, C.getDriver().getLTOMode() == LTOK_Thin); else if (Args.hasArg(options::OPT_mcpu_EQ)) CmdArgs.push_back(Args.MakeArgString( -"-plugin-opt=mcpu=" + Args.g

[clang] [analyzer] Don't invalidate the super region when a std object ctor runs (PR #100405)

2024-07-29 Thread Aaron Ballman via cfe-commits
@@ -923,12 +923,31 @@ SVal AnyCXXConstructorCall::getCXXThisVal() const { return UnknownVal(); } +static bool isWithinStdNamespace(const Decl *D) { AaronBallman wrote: Huh, that behavior would be surprising to me because nested subclasses are not in the `s

[clang] [Clang][Parse] Fix ambiguity with nested-name-specifiers that may declarative (PR #96364)

2024-07-29 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/96364 >From 037fb12412e9b3787e91d0a8ca826e098eab4e85 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Wed, 12 Jun 2024 14:14:26 -0400 Subject: [PATCH 1/7] [Clang][Parse] Fix ambiguity with nested-name-specif

[clang] [Clang][Parse] Fix ambiguity with nested-name-specifiers that may declarative (PR #96364)

2024-07-29 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/96364 >From 037fb12412e9b3787e91d0a8ca826e098eab4e85 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Wed, 12 Jun 2024 14:14:26 -0400 Subject: [PATCH 1/8] [Clang][Parse] Fix ambiguity with nested-name-specif

[clang] [Clang][Parse] Fix ambiguity with nested-name-specifiers that may declarative (PR #96364)

2024-07-29 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/96364 >From 691b0d3b23aa89af08ff6b1f4e09ff62c4b36ef6 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Wed, 12 Jun 2024 14:14:26 -0400 Subject: [PATCH 1/8] [Clang][Parse] Fix ambiguity with nested-name-specif

[clang] [X86] Enable constexpr on LZCNT & BMI intrinsics (PR #94161)

2024-07-29 Thread Simon Pilgrim via cfe-commits
RKSimon wrote: @aniplcc reverse ping https://github.com/llvm/llvm-project/pull/94161 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Parse] Fix ambiguity with nested-name-specifiers that may declarative (PR #96364)

2024-07-29 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian updated https://github.com/llvm/llvm-project/pull/96364 >From 496e0cf24b07622bd9354297c20091c2057a55c6 Mon Sep 17 00:00:00 2001 From: Krystian Stasiowski Date: Wed, 12 Jun 2024 14:14:26 -0400 Subject: [PATCH 1/8] [Clang][Parse] Fix ambiguity with nested-name-specif

[clang] [Clang][Parse] Fix ambiguity with nested-name-specifiers that may declarative (PR #96364)

2024-07-29 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: I think this is ready to merge. I have [a branch](https://github.com/sdkrystian/llvm-project/tree/perf/backtrack-raii) which fully implements annotated/unannotated preprocessor backtrack using RAII objects, but I think this is beyond the scope of this PR. https://github.com/

[clang] [AMDGPU] Correctly pass the target-id to `ld.lld` (PR #101037)

2024-07-29 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/101037 >From 3ff8ea9a35e8949e53e4947d6fa0688e6d5b3939 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 29 Jul 2024 11:29:45 -0500 Subject: [PATCH] [AMDGPU] Correctly pass the target-id to `ld.lld` Summary: The `

[clang] 2c0ec01 - [AMDGPU] Correctly pass the target-id to `ld.lld` (#101037)

2024-07-29 Thread via cfe-commits
Author: Joseph Huber Date: 2024-07-29T12:09:37-05:00 New Revision: 2c0ec01b516deba8922c1aae59b1907de6443587 URL: https://github.com/llvm/llvm-project/commit/2c0ec01b516deba8922c1aae59b1907de6443587 DIFF: https://github.com/llvm/llvm-project/commit/2c0ec01b516deba8922c1aae59b1907de6443587.diff

[clang] [AMDGPU] Correctly pass the target-id to `ld.lld` (PR #101037)

2024-07-29 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/101037 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [RISCV] full support for riscv_rvv_vector_bits attribute (PR #100110)

2024-07-29 Thread Craig Topper via cfe-commits
@@ -0,0 +1,98 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// RUN: %clang_cc1 -triple riscv64-none-linux-gnu -target-feature +f -target-feature +d -target-feature +zve64d -mvscale-min=1 -mvscale-max=1 -O1 -emit-llvm -o - %s | FileCheck %s --

[clang] [RISCV] full support for riscv_rvv_vector_bits attribute (PR #100110)

2024-07-29 Thread Craig Topper via cfe-commits
@@ -10014,14 +10023,33 @@ bool ASTContext::areCompatibleRVVTypes(QualType FirstType, BuiltinVectorTypeInfo Info = getBuiltinVectorTypeInfo(BT); return FirstType->isRVVVLSBuiltinType() && Info.ElementType == BoolTy && - getTy

[clang] [PAC][clang][test] Implement missing tests for some PAuth features (PR #100206)

2024-07-29 Thread Daniil Kovalev via cfe-commits
kovdan01 wrote: /cherry-pick 70c6e79e6d3e897418f3556a25e22e66ff018dc4 https://github.com/llvm/llvm-project/pull/100206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement P2280R4 Using unknown pointers and references in constant expressions (PR #95474)

2024-07-29 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik updated https://github.com/llvm/llvm-project/pull/95474 >From 69b09ea5b0f0a1c5419c488ade29b6fedc6de773 Mon Sep 17 00:00:00 2001 From: Shafik Yaghmour Date: Thu, 13 Jun 2024 14:20:50 -0700 Subject: [PATCH 1/2] [Clang] Implement P2280R4 Using unknown pointers and refere

[clang] [C] Disable use of NRVO (PR #101038)

2024-07-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Aaron Ballman (AaronBallman) Changes Applying NRVO changes the observable behavior of the abstract machine, which makes it an invalid optimization to apply in C. This disables the functionality in C. This is the only code path where we s

[clang] [C] Disable use of NRVO (PR #101038)

2024-07-29 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: One question I had is: this is an ABI breaking change for us, isn't it? Do we need/want ABI tags in that case? Should I call it out as a potentially breaking change? https://github.com/llvm/llvm-project/pull/101038 ___ cfe-commits

[clang] [PAC][clang][test] Implement missing tests for some PAuth features (PR #100206)

2024-07-29 Thread via cfe-commits
llvmbot wrote: >/cherry-pick 70c6e79e6d3e897418f3556a25e22e66ff018dc4 Error: Command failed due to missing milestone. https://github.com/llvm/llvm-project/pull/100206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang-tools-extra] Create a new check to look for mis-use in calls that take iterators (PR #99917)

2024-07-29 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti approved this pull request. LGTM (- single statement compound statements), but wait for another review please https://github.com/llvm/llvm-project/pull/99917 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://l

[clang] [clang][CUDA] Add 'noconvergent' function and statement attribute (PR #100637)

2024-07-29 Thread via cfe-commits
https://github.com/darkbuck updated https://github.com/llvm/llvm-project/pull/100637 >From d9de73264bf4d555e7e09a2c2687eae72c1fa19e Mon Sep 17 00:00:00 2001 From: Michael Liao Date: Thu, 25 Jul 2024 15:19:15 -0400 Subject: [PATCH 1/8] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?U

[clang] [Clang] Implement P2280R4 Using unknown pointers and references in constant expressions (PR #95474)

2024-07-29 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff d4a0154902fb9b0611ed857134b26a64a1d5ad1e 3c944c05fded091f9488a9786bc80c57e291b6ed --e

[clang] [clang][CUDA] Add 'noconvergent' function and statement attribute (PR #100637)

2024-07-29 Thread via cfe-commits
@@ -1357,11 +1357,10 @@ of the condition. def ConvergentDocs : Documentation { let Category = DocCatFunction; let Content = [{ -The ``convergent`` attribute can be placed on a function declaration or a -statement containing call expressions. It is translated into the LLVM -

[clang] [PAC][clang][test] Implement missing tests for some PAuth features (PR #100206)

2024-07-29 Thread Daniil Kovalev via cfe-commits
https://github.com/kovdan01 milestoned https://github.com/llvm/llvm-project/pull/100206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PAC][clang][test] Implement missing tests for some PAuth features (PR #100206)

2024-07-29 Thread Daniil Kovalev via cfe-commits
kovdan01 wrote: /cherry-pick 70c6e79 https://github.com/llvm/llvm-project/pull/100206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] RFC: [cmake] Export CLANG_RESOURCE_DIR in ClangConfig (PR #97197)

2024-07-29 Thread Kim Gräsman via cfe-commits
kimgr wrote: > Or making CustomResourceDir = CLANG_RESOURCE_DIR by default instead of "". Binding that default value in Driver.h would leave it to external projects (using Clang) to resolve `CLANG_RESOURCE_DIR`, which is not available outside Clang. So it somehow needs to move into the body of

[clang] [PAC][clang][test] Implement missing tests for some PAuth features (PR #100206)

2024-07-29 Thread via cfe-commits
llvmbot wrote: /pull-request llvm/llvm-project#101044 https://github.com/llvm/llvm-project/pull/100206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C] Disable use of NRVO (PR #101038)

2024-07-29 Thread Richard Smith via cfe-commits
zygoloid wrote: NRVO vs not-NRVO is not an ABI difference, just a behavior difference -- it doesn't change the calling convention, and different choices here are link-compatible (in C++ we can make different choices for different emissions of the same inline function even). This is also not a

[clang] [C] Disable use of NRVO (PR #101038)

2024-07-29 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: I'll get on top of fixing the other failing test cases, but I'd appreciate confirmation that we agree with the direction this patch is heading first. https://github.com/llvm/llvm-project/pull/101038 ___ cfe-commits mailing list cfe

[clang] c66d25d - [APINotes] Do not crash for C++ operators

2024-07-29 Thread via cfe-commits
Author: Egor Zhdan Date: 2024-07-29T18:40:01+01:00 New Revision: c66d25d1429fbf49c97ee9cd0195246642178cb7 URL: https://github.com/llvm/llvm-project/commit/c66d25d1429fbf49c97ee9cd0195246642178cb7 DIFF: https://github.com/llvm/llvm-project/commit/c66d25d1429fbf49c97ee9cd0195246642178cb7.diff LO

[clang] [APINotes] Do not crash for C++ operators (PR #101001)

2024-07-29 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan closed https://github.com/llvm/llvm-project/pull/101001 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C] Disable use of NRVO (PR #101038)

2024-07-29 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Instead of forcing this off for C compilations, how would you feel about > instead changing the default for -felide-constructors to be off for C, so > people can still re-enable the optimization to avoid performance / stack > usage regressions? (Weird flag name for C, I k

[clang] [Driver] Introduce ffp-model=aggressive (PR #100453)

2024-07-29 Thread Andy Kaylor via cfe-commits
@@ -102,6 +102,16 @@ Deprecated Compiler Flags Modified Compiler Flags --- +- The ``-ffp-model`` option has been updated to enable a more limited set of + optimizations when the ``fast`` argument is used and to accept a new argument, + ``aggressive``. Th

[clang] [NFC][clang] Fix typo of `riscv_rvv_vector_bits` in AttrDocs (PR #101046)

2024-07-29 Thread Brandon Wu via cfe-commits
https://github.com/4vtomat created https://github.com/llvm/llvm-project/pull/101046 None >From 1d756559b956f24d144c6819d264df062ec7d2cb Mon Sep 17 00:00:00 2001 From: Brandon Wu Date: Mon, 29 Jul 2024 10:44:05 -0700 Subject: [PATCH] [NFC][clang] Fix typo of `riscv_rvv_vector_bits` in AttrDocs

[clang] [NFC][clang] Fix typo of `riscv_rvv_vector_bits` in AttrDocs (PR #101046)

2024-07-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Brandon Wu (4vtomat) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/101046.diff 1 Files Affected: - (modified) clang/include/clang/Basic/AttrDocs.td (+1-1) ``diff diff --git a/clang/include/clang/Basic/Attr

[clang] [C] Disable use of NRVO (PR #101038)

2024-07-29 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: It doesn't seem like elide-constructors is wired to control this behavior. Seems to be wired only to the StaticAnalyzer presently. Regardless, the decision where to apply NRVO is currently centralized in SemaStmt. I think "Sema::getNamedReturnInfo(const VarDecl *VD)" would be

[clang] [PPC] Disable vsx and altivec when -msoft-float is used (PR #100450)

2024-07-29 Thread Zaara Syeda via cfe-commits
https://github.com/syzaara updated https://github.com/llvm/llvm-project/pull/100450 >From eac208b559feb3ccdfbd1d2ee6bcdd20db32f6a7 Mon Sep 17 00:00:00 2001 From: Zaara Syeda Date: Wed, 24 Jul 2024 14:58:53 -0400 Subject: [PATCH 1/2] [PPC] Disable vsx and altivec when -msoft-float is used ---

[clang] [C] Disable use of NRVO (PR #101038)

2024-07-29 Thread John McCall via cfe-commits
rjmccall wrote: I agree that the standard does not appear to permit this in C. There are three ways to fix this: 1. Disable NRVO in the callee just in case the address being initialized is aliased. 2. Disable RVO in the caller when aliasing is possible. 3. Convince the committee that they shou

[clang] 708a9a0 - [Clang][Parse] Fix ambiguity with nested-name-specifiers that may declarative (#96364)

2024-07-29 Thread via cfe-commits
Author: Krystian Stasiowski Date: 2024-07-29T14:01:00-04:00 New Revision: 708a9a06cba66bc8f739b05646e7d3be9247feee URL: https://github.com/llvm/llvm-project/commit/708a9a06cba66bc8f739b05646e7d3be9247feee DIFF: https://github.com/llvm/llvm-project/commit/708a9a06cba66bc8f739b05646e7d3be9247feee

[clang] [Clang][Parse] Fix ambiguity with nested-name-specifiers that may declarative (PR #96364)

2024-07-29 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian closed https://github.com/llvm/llvm-project/pull/96364 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix hasName matcher assertion with inline namespaces (PR #100975)

2024-07-29 Thread Nathan James via cfe-commits
https://github.com/njames93 closed https://github.com/llvm/llvm-project/pull/100975 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f9e7cba - Fix hasName matcher assertion with inline namespaces (#100975)

2024-07-29 Thread via cfe-commits
Author: Nathan James Date: 2024-07-29T19:11:02+01:00 New Revision: f9e7cba122c2b636ddb975791aadf33c69f3f056 URL: https://github.com/llvm/llvm-project/commit/f9e7cba122c2b636ddb975791aadf33c69f3f056 DIFF: https://github.com/llvm/llvm-project/commit/f9e7cba122c2b636ddb975791aadf33c69f3f056.diff

[clang] [C] Disable use of NRVO (PR #101038)

2024-07-29 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: We already have some code for detecting variable inits that access the variable; see isAccessedBy() in CGDecl.cpp. https://github.com/llvm/llvm-project/pull/101038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] [C] Disable use of NRVO (PR #101038)

2024-07-29 Thread John McCall via cfe-commits
https://github.com/rjmccall requested changes to this pull request. We shouldn't merge this PR unless we need an immediate fix, which seems unlikely given how longstanding this behavior is. https://github.com/llvm/llvm-project/pull/101038 ___ cfe-comm

[clang] RFC: [cmake] Export CLANG_RESOURCE_DIR in ClangConfig (PR #97197)

2024-07-29 Thread Tulio Magno Quites Machado Filho via cfe-commits
tuliom wrote: @kimgr Good points. I agree with you. https://github.com/llvm/llvm-project/pull/97197 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Rename `varlists` to `varlist`, NFC (PR #101058)

2024-07-29 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/101058 It returns a range of variables (via Expr*), not a range of lists. >From e6286e542ede1dfe5b63ce3b8d86a78fc8c8c895 Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Mon, 29 Jul 2024 13:29:09 -0500 Subjec

[clang] [clang][OpenMP] Rename `varlists` to `varlist`, NFC (PR #101058)

2024-07-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules @llvm/pr-subscribers-clang-codegen @llvm/pr-subscribers-clang Author: Krzysztof Parzyszek (kparzysz) Changes It returns a range of variables (via Expr*), not a range of lists. --- Patch is 44.69 KiB, truncated to 20.00 KiB below, full ver

[clang] [clang] Update argument checking tablegen code to use a 'full' name (PR #99993)

2024-07-29 Thread Mike Rice via cfe-commits
mikerice1969 wrote: > That code was added very recently by #94056 and seem to be specific to the > `ptrauth_vtable_pointer` attribute. Perhaps we're lacking test coverage if > nothing breaks without that code? @AaronBallman The code is logically useless so there's no way to add tests that mak

[clang] [clang][OpenMP] Rename `varlists` to `varlist`, NFC (PR #101058)

2024-07-29 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/101058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][OpenMP] Rename `varlists` to `varlist`, NFC (PR #101058)

2024-07-29 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 1b4be6a474b3747765a218201bd637f899fd9b66 e6286e542ede1dfe5b63ce3b8d86a78fc8c8c895 --e

[clang] Ofast deprecation clarifications (PR #101005)

2024-07-29 Thread Vlad Serebrennikov via cfe-commits
@@ -429,8 +429,12 @@ Code Generation Options :option:`-Ofast` Enables all the optimizations from :option:`-O3` along with other aggressive optimizations that may violate strict compliance with -language standards. This is deprecated in favor of :option:`-O3` -i

[clang] Ofast deprecation clarifications (PR #101005)

2024-07-29 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll approved this pull request. https://github.com/llvm/llvm-project/pull/101005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >