[clang] Fix hasName matcher assertion with inline namespaces (PR #100975)

2024-07-29 Thread Nathan James via cfe-commits
njames93 wrote: > I can't get the assertion to reproduce, but I can see the behavioral change > with the first matcher: https://godbolt.org/z/TcsYPoGEh > > So this should probably come with a release note for the fix? The assertions are only shown on debug build, but it comes from [here](http

[clang] [AMDGPU] Use the AMDGPUToolChain when targeting C/C++ directly (PR #99687)

2024-07-29 Thread Matt Arsenault via cfe-commits
@@ -29,6 +29,9 @@ // RUN: -fuse-ld=ld %s 2>&1 | FileCheck -check-prefixes=LD %s // LD: ld.lld +// RUN: %clang -### --target=amdgcn-amd-amdhsa -mcpu=gfx906 %s 2>&1 | FileCheck -check-prefix=ROCM %s +// ROCM-NOT: -mlink-builtin-bitcode + // RUN: %clang -### --target=amdgcn-a

[clang] [AMDGPU] Use the AMDGPUToolChain when targeting C/C++ directly (PR #99687)

2024-07-29 Thread Joseph Huber via cfe-commits
@@ -29,6 +29,9 @@ // RUN: -fuse-ld=ld %s 2>&1 | FileCheck -check-prefixes=LD %s // LD: ld.lld +// RUN: %clang -### --target=amdgcn-amd-amdhsa -mcpu=gfx906 %s 2>&1 | FileCheck -check-prefix=ROCM %s +// ROCM-NOT: -mlink-builtin-bitcode + // RUN: %clang -### --target=amdgcn-a

[clang] 13d39cb - [analyzer] Fix crash of StreamChecker when eval calling 'fopen' (#100990)

2024-07-29 Thread via cfe-commits
Author: Balazs Benics Date: 2024-07-29T14:15:02+02:00 New Revision: 13d39cb6f7b20e596b66f59ebf4dba766451398b URL: https://github.com/llvm/llvm-project/commit/13d39cb6f7b20e596b66f59ebf4dba766451398b DIFF: https://github.com/llvm/llvm-project/commit/13d39cb6f7b20e596b66f59ebf4dba766451398b.diff

[clang] [analyzer] Fix crash of StreamChecker when eval calling 'fopen' (PR #100990)

2024-07-29 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/100990 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Use the AMDGPUToolChain when targeting C/C++ directly (PR #99687)

2024-07-29 Thread Joseph Huber via cfe-commits
@@ -29,6 +29,9 @@ // RUN: -fuse-ld=ld %s 2>&1 | FileCheck -check-prefixes=LD %s // LD: ld.lld +// RUN: %clang -### --target=amdgcn-amd-amdhsa -mcpu=gfx906 %s 2>&1 | FileCheck -check-prefix=ROCM %s +// ROCM-NOT: -mlink-builtin-bitcode + // RUN: %clang -### --target=amdgcn-a

[clang] [AMDGPU] Use the AMDGPUToolChain when targeting C/C++ directly (PR #99687)

2024-07-29 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/99687 >From 59901100a2c11d37947938dfb9db5dd1164cbbf5 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 19 Jul 2024 14:07:18 -0500 Subject: [PATCH 1/4] [AMDGPU] Use the AMDGPUToolChain when targeting C/C++ directl

[clang] [clang-format] Add BreakBinaryOperations configuration (PR #95013)

2024-07-29 Thread Ameer J via cfe-commits
ameerj wrote: @owenca Can you review once more please? https://github.com/llvm/llvm-project/pull/95013 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix hasName matcher assertion with inline namespaces (PR #100975)

2024-07-29 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > I can't get the assertion to reproduce, but I can see the behavioral change > > with the first matcher: https://godbolt.org/z/TcsYPoGEh > > So this should probably come with a release note for the fix? > > The assertions are only shown on debug build, but it comes from

[clang] [llvm] Finish deleting the le32/le64 targets (PR #98497)

2024-07-29 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Note that Halide has removed its dependency on the le32/le64 targets as of > [halide/Halide#8344](https://github.com/halide/Halide/pull/8344). Thank you for letting us know! Does anyone know of any reasons we should not revert the revert (so le32/le64 is removed in Clang

[clang] [libclang/python] Export all enums (PR #100941)

2024-07-29 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll approved this pull request. LGTM I think `__all__` can be made a tuple instead, but it's not necessarily in the scope of this PR. https://github.com/llvm/llvm-project/pull/100941 ___ cfe-commits mailing list cfe-commits@list

[clang] [llvm] [OpenMP] OpenMP 5.1 "assume" directive parsing support (PR #92731)

2024-07-29 Thread Julian Brown via cfe-commits
https://github.com/jtb20 updated https://github.com/llvm/llvm-project/pull/92731 >From 945c37825742aa6a988ee1bf74b0f3feefbbd906 Mon Sep 17 00:00:00 2001 From: Julian Brown Date: Wed, 1 May 2024 06:35:59 -0500 Subject: [PATCH] [OpenMP] OpenMP 5.1 "assume" directive parsing support This patch sup

[clang] [clang][FMV][AArch64] Improve streaming mode compatibility. (PR #100181)

2024-07-29 Thread Alexandros Lamprineas via cfe-commits
labrinea wrote: Created a PR for the backport https://github.com/llvm/llvm-project/pull/101007 https://github.com/llvm/llvm-project/pull/100181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] [libclang/python] Export all enums (PR #100941)

2024-07-29 Thread Jannick Kremer via cfe-commits
DeinAlptraum wrote: Could you also merge please? (or are you waiting for something else?) https://github.com/llvm/llvm-project/pull/100941 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] RFC: [cmake] Export CLANG_RESOURCE_DIR in ClangConfig (PR #97197)

2024-07-29 Thread Tulio Magno Quites Machado Filho via cfe-commits
tuliom wrote: > I wonder if that last one is a bug...? Agreed. > If so, it seems it would be better to just fold `CLANG_RESOURCE_DIR` into > `Driver::GetResourcesPath` and remove the optional argument. Or making `CustomResourceDir = CLANG_RESOURCE_DIR` by default instead of `""`. This would a

[clang] [lld] [llvm] Add debug options to clang-linker-wrapper (PR #101008)

2024-07-29 Thread via cfe-commits
https://github.com/macurtis-amd created https://github.com/llvm/llvm-project/pull/101008 New options: ``` clang-linker-wrapper --- --lto-debug-pass-manager Prints debug information for the new pass manager during LTO --lto-in-process Use in-process LTO

[clang] [lld] [llvm] Add debug options to clang-linker-wrapper (PR #101008)

2024-07-29 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [lld] [llvm] Add debug options to clang-linker-wrapper (PR #101008)

2024-07-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: None (macurtis-amd) Changes New options: ``` clang-linker-wrapper --- --lto-debug-pass-manager Prints debug information for the new pass manager during LTO --lto-in-process Use in-process LT

[clang] [lld] [llvm] Add debug options to clang-linker-wrapper (PR #101008)

2024-07-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-lld-elf Author: None (macurtis-amd) Changes New options: ``` clang-linker-wrapper --- --lto-debug-pass-manager Prints debug information for the new pass manager during LTO --lto-in-process Use in-process LTO eve

[clang] [llvm] [OpenMP] OpenMP 5.1 "assume" directive parsing support (PR #92731)

2024-07-29 Thread Alexey Bataev via cfe-commits
@@ -2013,6 +2014,179 @@ class OMPMergeableClause : public OMPClause { } }; +/// This represents the 'absent' clause in the '#pragma omp assume' +/// directive. +/// +/// \code +/// #pragma omp assume absent() +/// \endcode +/// In this example directive '#pragma omp assume'

[clang] [llvm] [OpenMP] OpenMP 5.1 "assume" directive parsing support (PR #92731)

2024-07-29 Thread Alexey Bataev via cfe-commits
@@ -2013,6 +2014,179 @@ class OMPMergeableClause : public OMPClause { } }; +/// This represents the 'absent' clause in the '#pragma omp assume' +/// directive. +/// +/// \code +/// #pragma omp assume absent() +/// \endcode +/// In this example directive '#pragma omp assume'

[clang] [clang codegen] Emit int TBAA metadata on more FP math libcalls (PR #100302)

2024-07-29 Thread via cfe-commits
https://github.com/vfdff updated https://github.com/llvm/llvm-project/pull/100302 >From c750234674531788ee26958954a5f9a6b59ea866 Mon Sep 17 00:00:00 2001 From: zhongyunde 00443407 Date: Tue, 23 Jul 2024 23:10:42 -0400 Subject: [PATCH 1/4] [clang codegen] Emit int TBAA metadata on more FP math

[clang] [clang codegen] Emit int TBAA metadata on more FP math libcalls (PR #100302)

2024-07-29 Thread via cfe-commits
@@ -4,37 +4,76 @@ // RUN: %clang_cc1 -triple=aarch64-unknown-linux-gnu -fmath-errno -O3 -new-struct-path-tbaa -emit-llvm -o - -x c++ %s | FileCheck %s -check-prefixes=CHECK,NewStructPathTBAA extern "C" float expf(float); +extern "C" double remainder(double, double); +extern

[clang] [clang codegen] Emit int TBAA metadata on more FP math libcalls (PR #100302)

2024-07-29 Thread via cfe-commits
@@ -4,37 +4,76 @@ // RUN: %clang_cc1 -triple=aarch64-unknown-linux-gnu -fmath-errno -O3 -new-struct-path-tbaa -emit-llvm -o - -x c++ %s | FileCheck %s -check-prefixes=CHECK,NewStructPathTBAA extern "C" float expf(float); +extern "C" double remainder(double, double); +extern

[clang] [libclang/python] Export all enums (PR #100941)

2024-07-29 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: @DeinAlptraum Can you merge `main` into this branch? I'd like to merge this with a green CI. @tbaederr CI for this patch has failed due to unrelated failure that is likely to be connected to your work: ``` _bk;t=1722188500258 TEST 'Clang :: AST/Interp/lite

[clang] [libclang/python] Export all enums (PR #100941)

2024-07-29 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum updated https://github.com/llvm/llvm-project/pull/100941 >From 4b1322b8add0a1189f0f1cbf5583841f3a591f0c Mon Sep 17 00:00:00 2001 From: Jannick Kremer Date: Sun, 28 Jul 2024 18:30:35 +0100 Subject: [PATCH] [libclang/python] Export all enums --- clang/bindings/py

[clang] [llvm] [CUDA] Add a pseudo GPU sm_next which allows overriding for SM/PTX version. (PR #100247)

2024-07-29 Thread Justin Holewinski via cfe-commits
@@ -26,24 +27,38 @@ static cl::opt NoF16Math("nvptx-no-f16-math", cl::Hidden, cl::desc("NVPTX Specific: Disable generation of f16 math ops."), cl::init(false)); +static cl::opt +NextSM("nvptx-next-sm", cl::Hidden, + cl::desc("NVPTX

[clang] [libclang/python] Export all enums (PR #100941)

2024-07-29 Thread Timm Baeder via cfe-commits
tbaederr wrote: > @tbaederr CI for this patch has failed due to unrelated failure that is > likely to be connected to your work: That should be fixed already, I assume this is using an old version of the test. https://github.com/llvm/llvm-project/pull/100941 ___

[clang] [llvm] [CUDA] Add a pseudo GPU sm_next which allows overriding for SM/PTX version. (PR #100247)

2024-07-29 Thread Justin Holewinski via cfe-commits
jholewinski wrote: I'm wondering if this feature would be better named `sm_custom` or similar. The `sm_next` moniker implies that the target is for a _future_ architecture target, but this feature can be used to inject any custom SM/PTX combination. Especially if this is extended to support th

[clang] [lld] [llvm] Add debug options to clang-linker-wrapper (PR #101008)

2024-07-29 Thread via cfe-commits
https://github.com/macurtis-amd edited https://github.com/llvm/llvm-project/pull/101008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libclang/python] Export all enums (PR #100941)

2024-07-29 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > > @tbaederr CI for this patch has failed due to unrelated failure that is > > likely to be connected to your work: > > That should be fixed already, I assume this is using an old version of the > test. Sure, but it's annoying then you make a branch from `main`, only to find o

[clang] [libclang/python] Fix some type errors, add type annotations (PR #98745)

2024-07-29 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum updated https://github.com/llvm/llvm-project/pull/98745 >From 00631fc559197d2bc6bfa9e8ccdae47f33926a37 Mon Sep 17 00:00:00 2001 From: Jannick Kremer Date: Sat, 13 Jul 2024 14:12:34 +0100 Subject: [PATCH 1/2] [libclang/python] Fix some type errors, add type annot

[clang] [libclang/python] Export all enums (PR #100941)

2024-07-29 Thread Jannick Kremer via cfe-commits
DeinAlptraum wrote: This may be my fault, I don't remember if I pulled main before branching for this PR, especially seeing how my last PR also had unrelated test failures https://github.com/llvm/llvm-project/pull/100941 ___ cfe-commits mailing list c

[clang] [ASTMatchers] Extend hasName matcher when matching templates (PR #100349)

2024-07-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/100349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ASTMatchers] Extend hasName matcher when matching templates (PR #100349)

2024-07-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: The changes should also come with a release note in clang/docs/ReleaseNotes.rst. https://github.com/llvm/llvm-project/pull/100349 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] [ASTMatchers] Extend hasName matcher when matching templates (PR #100349)

2024-07-29 Thread Aaron Ballman via cfe-commits
@@ -3076,6 +3076,21 @@ inline internal::BindableMatcher sizeOfExpr( /// \code /// namespace a { namespace b { class X; } } /// \endcode +/// +/// Qualified names in templated classes can be matched explicitly or implicity +/// by specifying the template type or using `<*>` to

[clang] [clang-repl] [codegen] Reduce the state in TBAA. NFC for static compilation. (PR #98138)

2024-07-29 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Hi @AaronBallman, could we move that forward? I've added the Clang codegen code owners, as they really should be involved in this sort of change. https://github.com/llvm/llvm-project/pull/98138 ___ cfe-commits mailing list cfe-c

[clang] [clang-format] Fix misannotations of `<` in ternary expressions (PR #100980)

2024-07-29 Thread Emilia Kond via cfe-commits
https://github.com/rymiel approved this pull request. Wow! https://github.com/llvm/llvm-project/pull/100980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix misannotations of `<` in ternary expressions (PR #100980)

2024-07-29 Thread Emilia Kond via cfe-commits
https://github.com/rymiel edited https://github.com/llvm/llvm-project/pull/100980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix misannotations of `<` in ternary expressions (PR #100980)

2024-07-29 Thread Emilia Kond via cfe-commits
@@ -176,31 +176,38 @@ class AnnotatingParser { FormatToken *Left = CurrentToken->Previous; Left->ParentBracket = Contexts.back().ContextKind; ScopedContextCreator ContextCreator(*this, tok::less, 12); - Contexts.back().IsExpression = false; + +const auto *B

[clang] f7e9d48 - [Clang] Fix confusing diagnositcs related to explicit this parameters (#100351)

2024-07-29 Thread via cfe-commits
Author: Braden Helmer Date: 2024-07-29T09:40:35-04:00 New Revision: f7e9d48a73dd68c8b652692d8a9e559a6ceb722e URL: https://github.com/llvm/llvm-project/commit/f7e9d48a73dd68c8b652692d8a9e559a6ceb722e DIFF: https://github.com/llvm/llvm-project/commit/f7e9d48a73dd68c8b652692d8a9e559a6ceb722e.diff

[clang] [Clang] Fix confusing diagnositcs related to explicit this parameters (PR #100351)

2024-07-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/100351 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [Flang][Driver] Introduce -fopenmp-targets offloading option (PR #100152)

2024-07-29 Thread Anastasia Stulova via cfe-commits
AnastasiaStulova wrote: > In my opinion, the decision to potentially rename or move to a different set > of offloading flags should be independent from this work, as it doesn't > really add anything new, it only replicates one of the features clang already > has. If a change to that is agreed

[clang] [AIX] Detect `#pragma mc_func` (PR #99888)

2024-07-29 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Oh, this is even weirder than I realized -- that example gives a declaration for `add_logical()` (line 6), so that's why there's no "unknown function" diagnostic from the compiler, just a link error. That's a plausible reason for this to be handled in a special way, but now

[clang] [lld] [llvm] Add debug options to clang-linker-wrapper (PR #101008)

2024-07-29 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 commented: `lld` changes need to be separate, forwarding `-mllvm` is https://github.com/llvm/llvm-project/pull/100424 but I forgot to merge it so I'll do that. https://github.com/llvm/llvm-project/pull/101008 ___ cfe-commit

[clang] [flang] [Flang][Driver] Introduce -fopenmp-targets offloading option (PR #100152)

2024-07-29 Thread Sergio Afonso via cfe-commits
skatrak wrote: > The only issue I see is that this PR adds a new driver flag that may be used > to compile the applications. Renaming the user visible flags is not that > easy. But if they get renamed before any compiler release then it should be > fine. Thank you for the comment. Actually, t

[clang] [LinkerWrapper] Forward `-mllvm` and `--offload-opt` arguments to device (PR #100424)

2024-07-29 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/100424 >From 88b8b4fc649dd9c900fc941f1e03cd5fc097acc1 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Wed, 24 Jul 2024 11:44:22 -0500 Subject: [PATCH] [LinkerWrapper] Forward `-mllvm` and `--offload-opt` arguments t

[clang] [Clang][Interp] Fix the location of uninitialized base warning (PR #100761)

2024-07-29 Thread via cfe-commits
https://github.com/yronglin updated https://github.com/llvm/llvm-project/pull/100761 >From eb237d1b6434c16366f8095f47af1456cb776a27 Mon Sep 17 00:00:00 2001 From: yronglin Date: Fri, 26 Jul 2024 23:09:42 +0800 Subject: [PATCH 1/3] [Clang][Interp] Fix the location of uninitialized base warning

[clang] [clang codegen] Emit int TBAA metadata on more FP math libcalls (PR #100302)

2024-07-29 Thread Matt Arsenault via cfe-commits
@@ -46,21 +48,71 @@ extern "C" double foo_fabs (double num[]) { // CHECK-NEXT: [[ENTRY:.*:]] // CHECK-NEXT:[[ARRAYIDX:%.*]] = getelementptr inbounds i8, ptr [[NUM]], i64 80 // CHECK-NEXT:[[TMP0:%.*]] = load double, ptr [[ARRAYIDX]], align 8, !tbaa [[TBAA8]] -// CHECK

[clang] [clang codegen] Emit int TBAA metadata on more FP math libcalls (PR #100302)

2024-07-29 Thread Matt Arsenault via cfe-commits
@@ -692,21 +692,13 @@ static RValue emitLibraryCall(CodeGenFunction &CGF, const FunctionDecl *FD, RValue Call = CGF.EmitCall(E->getCallee()->getType(), callee, E, ReturnValueSlot()); - ASTContext &Context = CGF.getContext(); if (unsigned BuiltinID = FD->getBuiltin

[clang] [clang-cl] [Sema] Support MSVC non-const lvalue to user-defined temporary reference (PR #99833)

2024-07-29 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > This should be controllable via -fms-extensions/-fno-ms-extensions; having > > its own dialect flag is a bit novel but I'm not strongly opposed. CC > > @MaskRay @jansvoboda11 for driver/options opinions > > For this feedback I intentionally didn't do this because this m

[clang] 97c62b8 - [LinkerWrapper] Forward `-mllvm` and `--offload-opt` arguments to device (#100424)

2024-07-29 Thread via cfe-commits
Author: Joseph Huber Date: 2024-07-29T09:12:14-05:00 New Revision: 97c62b8f7501d1c6c2f507b075fbe45a31d2b9dc URL: https://github.com/llvm/llvm-project/commit/97c62b8f7501d1c6c2f507b075fbe45a31d2b9dc DIFF: https://github.com/llvm/llvm-project/commit/97c62b8f7501d1c6c2f507b075fbe45a31d2b9dc.diff

[clang] [LinkerWrapper] Forward `-mllvm` and `--offload-opt` arguments to device (PR #100424)

2024-07-29 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/100424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lld] [llvm] Add debug options to clang-linker-wrapper (PR #101008)

2024-07-29 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 edited https://github.com/llvm/llvm-project/pull/101008 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][deps] Only bypass scanning VFS for the module cache (PR #88800)

2024-07-29 Thread Alexandre Ganea via cfe-commits
aganea wrote: Ping @jansvoboda11! Just checking if you had time to finish this PR, to then possibly integrate it into 19.x. https://github.com/llvm/llvm-project/pull/88800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] [lld] [llvm] Add debug options to clang-linker-wrapper (PR #101008)

2024-07-29 Thread via cfe-commits
macurtis-amd wrote: > `lld` and `LLVM` changes need to be separate, forwarding `-mllvm` is #100424 > but I forgot to merge it so I'll do that. I've created: PR #101018 created for that commit. Once that has been merged, I'll rebase this PR. https://github.com/llvm/llvm-project/pull/101008 ___

[clang] [LinkerWrapper] Forward `-mllvm` and `--offload-opt` arguments to device (PR #100424)

2024-07-29 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-amdgpu-runtime` running on `omp-vega20-0` while building `clang` at step 7 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/30/builds/3043 Here is the relevant

[clang] [llvm] [Sanitizer] Make sanitizer passes idempotent (PR #99439)

2024-07-29 Thread Nikita Popov via cfe-commits
https://github.com/nikic commented: Some nits, no strong opinion on overall approach. https://github.com/llvm/llvm-project/pull/99439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Sanitizer] Make sanitizer passes idempotent (PR #99439)

2024-07-29 Thread Nikita Popov via cfe-commits
https://github.com/nikic edited https://github.com/llvm/llvm-project/pull/99439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Sanitizer] Make sanitizer passes idempotent (PR #99439)

2024-07-29 Thread Nikita Popov via cfe-commits
@@ -12,12 +12,33 @@ //===--===// #include "llvm/Transforms/Instrumentation.h" +#include "llvm/IR/DiagnosticInfo.h" #include "llvm/IR/IntrinsicInst.h" #include "llvm/IR/Module.h" #include "llvm/TargetParser

[clang] [llvm] [Sanitizer] Make sanitizer passes idempotent (PR #99439)

2024-07-29 Thread Nikita Popov via cfe-commits
@@ -19,6 +19,7 @@ #include "llvm/IR/Function.h" #include "llvm/IR/IRBuilder.h" #include "llvm/IR/Instruction.h" +#include "llvm/IR/Module.h" nikic wrote: Should be a forward-declare. https://github.com/llvm/llvm-project/pull/99439

[clang] [llvm] [Sanitizer] Make sanitizer passes idempotent (PR #99439)

2024-07-29 Thread Nikita Popov via cfe-commits
@@ -12,12 +12,33 @@ //===--===// #include "llvm/Transforms/Instrumentation.h" +#include "llvm/IR/DiagnosticInfo.h" #include "llvm/IR/IntrinsicInst.h" #include "llvm/IR/Module.h" #include "llvm/TargetParser

[clang] [LinkerWrapper] Forward `-mllvm` and `--offload-opt` arguments to device (PR #100424)

2024-07-29 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `openmp-offload-libc-amdgpu-runtime` running on `omp-vega20-1` while building `clang` at step 10 "Add check check-offload". Full details are available at: https://lab.llvm.org/buildbot/#/builders/73/builds/2822 Here is the re

[clang] [compiler-rt] [flang] [libc] [libcxx] [libcxxabi] [lld] [llvm] Ofast deprecation clarifications (PR #101005)

2024-07-29 Thread Sjoerd Meijer via cfe-commits
https://github.com/sjoerdmeijer edited https://github.com/llvm/llvm-project/pull/101005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [Flang][Driver] Introduce -fopenmp-targets offloading option (PR #100152)

2024-07-29 Thread Anastasia Stulova via cfe-commits
AnastasiaStulova wrote: > > The only issue I see is that this PR adds a new driver flag that may be > > used to compile the applications. Renaming the user visible flags is not > > that easy. But if they get renamed before any compiler release then it > > should be fine. > > Thank you for the

[clang] [Clang][Parser] Fix name lookup of template parameters for out-of-line specializations (PR #101020)

2024-07-29 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/101020 Since the implementation of DR458 (d1446017), we have had an algorithm that template parameters would take precedence over its parent scopes at the name lookup. However, we failed to handle the following case w

[clang] Ofast deprecation clarifications (PR #101005)

2024-07-29 Thread Sjoerd Meijer via cfe-commits
https://github.com/sjoerdmeijer updated https://github.com/llvm/llvm-project/pull/101005 >From 22f2e40c6d44c562e97162f04dee055a1be57460 Mon Sep 17 00:00:00 2001 From: Sjoerd Meijer Date: Mon, 29 Jul 2024 19:31:18 +0530 Subject: [PATCH] Ofast documentation deprecation clarifications Following u

[clang] [Clang][Parser] Fix name lookup of template parameters for out-of-line specializations (PR #101020)

2024-07-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Younan Zhang (zyn0217) Changes Since the implementation of DR458 (d1446017), we have had an algorithm that template parameters would take precedence over its parent scopes at the name lookup. However, we failed to handle the following cas

[clang] [Clang][Parser] Fix name lookup of template parameters for out-of-line specializations (PR #101020)

2024-07-29 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/101020 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Introduce ffp-model=aggressive (PR #100453)

2024-07-29 Thread Aaron Ballman via cfe-commits
@@ -102,6 +102,16 @@ Deprecated Compiler Flags Modified Compiler Flags --- +- The ``-ffp-model`` option has been updated to enable a more limited set of + optimizations when the ``fast`` argument is used and to accept a new argument, + ``aggressive``. Th

[clang] Ofast deprecation clarifications (PR #101005)

2024-07-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: FWIW, I'm happy enough with the proposed wording (I want to give others a chance to weigh in before approving though). https://github.com/llvm/llvm-project/pull/101005 ___ cfe-commits mailing list cfe-commits

[clang] Ofast deprecation clarifications (PR #101005)

2024-07-29 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/101005 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Ofast deprecation clarifications (PR #101005)

2024-07-29 Thread Aaron Ballman via cfe-commits
@@ -429,8 +429,12 @@ Code Generation Options :option:`-Ofast` Enables all the optimizations from :option:`-O3` along with other aggressive optimizations that may violate strict compliance with -language standards. This is deprecated in favor of :option:`-O3` -i

[clang] [SystemZ][z/OS] Implement z/OS XPLINK ABI (PR #101024)

2024-07-29 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree created https://github.com/llvm/llvm-project/pull/101024 The XPLINK calling convention is specified in the Language Environment Vendor Interface, chapter 22, (https://www.ibm.com/support/knowledgecenter/SSLTBW_2.4.0/com.ibm.zos.v2r4.cee/cee.htm) and in Redbook XP

[clang] [SystemZ][z/OS] Implement z/OS XPLINK ABI (PR #101024)

2024-07-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-systemz @llvm/pr-subscribers-clang Author: Abhina Sree (abhina-sree) Changes The XPLINK calling convention is specified in the Language Environment Vendor Interface, chapter 22, (https://www.ibm.com/support/knowledgecenter/SSLTBW_2.4.0/com.ibm.z

[clang] [SystemZ][z/OS] Implement z/OS XPLINK ABI (PR #91384)

2024-07-29 Thread Abhina Sree via cfe-commits
abhina-sree wrote: I will be taking over this change from Fanbo here https://github.com/llvm/llvm-project/pull/101024. I will address the comments here on that PR. https://github.com/llvm/llvm-project/pull/91384 ___ cfe-commits mailing list cfe-commi

[clang] [SystemZ][z/OS] Implement z/OS XPLINK ABI (PR #101024)

2024-07-29 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 97c62b8f7501d1c6c2f507b075fbe45a31d2b9dc e89f2e619fb7b4e5c942d7236768e79bb189aee8 --e

[clang] [SystemZ][z/OS] Implement z/OS XPLINK ABI (PR #101024)

2024-07-29 Thread Abhina Sree via cfe-commits
https://github.com/abhina-sree updated https://github.com/llvm/llvm-project/pull/101024 >From 9d30fcbac4ecdc592663d20a2b18b6b4e2ee873e Mon Sep 17 00:00:00 2001 From: Abhina Sreeskantharajan Date: Mon, 29 Jul 2024 10:49:08 -0400 Subject: [PATCH] [SystemZ][z/OS] Implement z/OS XPLINK ABI --- cl

[clang] [clang-format] Fix the indent of the ternary operator when AlignOperands and BreakBeforeTernaryOperators is specified. (PR #100860)

2024-07-29 Thread Hirofumi Nakamura via cfe-commits
hnakamura5 wrote: > this is the default behavior of clang-format. And someone did intend it that > way. > If the change is desired, the BreakBeforeTernaryOperators option should be > expanded to an enum or AlignOperands extended. I agree. The current style has been default in this many years.

[clang] [SystemZ][z/OS] Implement z/OS XPLINK ABI (PR #91384)

2024-07-29 Thread Fanbo Meng via cfe-commits
https://github.com/fanbo-meng closed https://github.com/llvm/llvm-project/pull/91384 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SystemZ][z/OS] __ptr32 support for z/OS in Clang (PR #96063)

2024-07-29 Thread Fanbo Meng via cfe-commits
https://github.com/fanbo-meng closed https://github.com/llvm/llvm-project/pull/96063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [SystemZ][z/OS] __ptr32 support for z/OS in Clang (PR #96063)

2024-07-29 Thread Fanbo Meng via cfe-commits
fanbo-meng wrote: Transferring this to @abhina-sree https://github.com/llvm/llvm-project/pull/96063 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [OpenMP] OpenMP 5.1 "assume" directive parsing support (PR #92731)

2024-07-29 Thread Julian Brown via cfe-commits
@@ -2013,6 +2014,179 @@ class OMPMergeableClause : public OMPClause { } }; +/// This represents the 'absent' clause in the '#pragma omp assume' +/// directive. +/// +/// \code +/// #pragma omp assume absent() +/// \endcode +/// In this example directive '#pragma omp assume'

[clang] Fix hasName matcher assertion with inline namespaces (PR #100975)

2024-07-29 Thread Nathan James via cfe-commits
https://github.com/njames93 updated https://github.com/llvm/llvm-project/pull/100975 >From b208791fbdc9fe665f2b8ecd44c9b15a5d729f6f Mon Sep 17 00:00:00 2001 From: Nathan James Date: Mon, 29 Jul 2024 07:21:53 +0100 Subject: [PATCH] Fix hasName matcher assertion with inline namespaces Fix handli

[clang] [clang-cl] [Sema] Support MSVC non-const lvalue to user-defined temporary reference (PR #99833)

2024-07-29 Thread Max Winkler via cfe-commits
https://github.com/MaxEW707 updated https://github.com/llvm/llvm-project/pull/99833 >From e0528ecc441e33822426b8b3d6522d056c95bb54 Mon Sep 17 00:00:00 2001 From: MaxEW707 Date: Fri, 21 Jun 2024 20:37:40 -0700 Subject: [PATCH 1/5] Support MSVC lvalue to temporary reference binding --- clang/do

[clang] [clang-cl] [Sema] Support MSVC non-const lvalue to user-defined temporary reference (PR #99833)

2024-07-29 Thread Max Winkler via cfe-commits
https://github.com/MaxEW707 updated https://github.com/llvm/llvm-project/pull/99833 >From e0528ecc441e33822426b8b3d6522d056c95bb54 Mon Sep 17 00:00:00 2001 From: MaxEW707 Date: Fri, 21 Jun 2024 20:37:40 -0700 Subject: [PATCH 1/6] Support MSVC lvalue to temporary reference binding --- clang/do

[clang] [llvm] [OpenMP] OpenMP 5.1 "assume" directive parsing support (PR #92731)

2024-07-29 Thread Alexey Bataev via cfe-commits
@@ -2013,6 +2014,179 @@ class OMPMergeableClause : public OMPClause { } }; +/// This represents the 'absent' clause in the '#pragma omp assume' +/// directive. +/// +/// \code +/// #pragma omp assume absent() +/// \endcode +/// In this example directive '#pragma omp assume'

[clang] [llvm] [NVPTX] Support __usAtomicCAS builtin (PR #99646)

2024-07-29 Thread via cfe-commits
DenisGZM wrote: Ping https://github.com/llvm/llvm-project/pull/99646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [NVPTX] Support __usAtomicCAS builtin (PR #99646)

2024-07-29 Thread via cfe-commits
DenisGZM wrote: Should I provide more tests or just wait for maintainer to aprove? https://github.com/llvm/llvm-project/pull/99646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ASTImporter] Fix typos in trailing return testing on lambda p… (PR #101031)

2024-07-29 Thread Ding Fei via cfe-commits
https://github.com/danix800 created https://github.com/llvm/llvm-project/pull/101031 …roto The test should be true on function with trailing return. This fixes crashes (infinite recursion) on lambda expr without parameters (without parentheses). >From 336bebf7d20feb7a6fab5ad038239b058f62bdfb

[clang] [clang][ASTImporter] Fix typos in trailing return testing on lambda p… (PR #101031)

2024-07-29 Thread Ding Fei via cfe-commits
https://github.com/danix800 edited https://github.com/llvm/llvm-project/pull/101031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ASTImporter] Fix typos in trailing return testing on lambda p… (PR #101031)

2024-07-29 Thread Ding Fei via cfe-commits
https://github.com/danix800 edited https://github.com/llvm/llvm-project/pull/101031 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ASTImporter] Fix typos in trailing return testing on lambda p… (PR #101031)

2024-07-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ding Fei (danix800) Changes The test should be true on function with trailing return. This fixes crashes (infinite recursion) on lambda expr without parameters (no parentheses). --- Full diff: https://github.com/llvm/llvm-project/pull/10

[clang] [LinkerWrapper] Make `-Xoffload-linker` match `-Xlinker` semantics (PR #101032)

2024-07-29 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/101032 Summary: `-Xlinker` is supposed to pass options to the linker, while `-Xoffload-linker` instead passes it to the `clang` job. This is unintuitive and results in unnecessarily complex command lines. Because passin

[clang] [APINotes] Do not crash for C++ operators (PR #101001)

2024-07-29 Thread Saleem Abdulrasool via cfe-commits
@@ -1044,11 +1044,13 @@ void Sema::ProcessAPINotes(Decl *D) { if (auto TagContext = dyn_cast(D->getDeclContext())) { if (auto CXXMethod = dyn_cast(D)) { - for (auto Reader : APINotes.findAPINotes(D->getLocation())) { -if (auto Context = UnwindTagContext(TagC

[clang] [LinkerWrapper] Make `-Xoffload-linker` match `-Xlinker` semantics (PR #101032)

2024-07-29 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Joseph Huber (jhuber6) Changes Summary: `-Xlinker` is supposed to pass options to the linker, while `-Xoffload-linker` instead passes it to the `clang` job. This is unintuitive and results in unnecessarily complex command lines. Beca

[clang] [APINotes] Do not crash for C++ operators (PR #101001)

2024-07-29 Thread Egor Zhdan via cfe-commits
@@ -1044,11 +1044,13 @@ void Sema::ProcessAPINotes(Decl *D) { if (auto TagContext = dyn_cast(D->getDeclContext())) { if (auto CXXMethod = dyn_cast(D)) { - for (auto Reader : APINotes.findAPINotes(D->getLocation())) { -if (auto Context = UnwindTagContext(TagC

[clang] [LinkerWrapper] Make `-Xoffload-linker` match `-Xlinker` semantics (PR #101032)

2024-07-29 Thread Matt Arsenault via cfe-commits
@@ -1236,6 +1238,23 @@ DerivedArgList getLinkerArgs(ArrayRef Input, Args.MakeArgString(Value)); } + // Forward '-Xoffload-compiler' options to the appropriate backend. + for (StringRef Arg : Args.getAllArgValues(OPT_device_compiler_args_EQ)) { +a

[clang] [LinkerWrapper] Make `-Xoffload-linker` match `-Xlinker` semantics (PR #101032)

2024-07-29 Thread Joseph Huber via cfe-commits
@@ -1236,6 +1238,23 @@ DerivedArgList getLinkerArgs(ArrayRef Input, Args.MakeArgString(Value)); } + // Forward '-Xoffload-compiler' options to the appropriate backend. + for (StringRef Arg : Args.getAllArgValues(OPT_device_compiler_args_EQ)) { +a

[clang] [LinkerWrapper] Make `-Xoffload-linker` match `-Xlinker` semantics (PR #101032)

2024-07-29 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/101032 >From 19d0d5622fbc5b7df07e2fc907b8e7c50216bcde Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 29 Jul 2024 10:36:12 -0500 Subject: [PATCH] [LinkerWrapper] Make `-Xoffload-linker` match `-Xlinker` semanti

<    1   2   3   4   5   >