[clang] [libcxx] [clang] Add -Wimplicit-fallthrough to -Wextra (PR #97926)

2024-07-26 Thread Max Coplan via cfe-commits
Max =?utf-8?b?8J+RqPCfj73igI3wn5K7?= Copl Message-ID: In-Reply-To: vegerot wrote: @AaronBallman I stacked this diff on top of #100821 to remove that build error. https://github.com/llvm/llvm-project/pull/97926 ___ cfe-commits mailing list cfe-commits

[clang] [llvm] [Sanitizer] Make sanitizer passes idempotent (PR #99439)

2024-07-26 Thread Fangrui Song via cfe-commits
MaskRay wrote: > @MaskRay can you talk more about your concerns? This won't affect compile > time, and instrumenting a shadow load will cause an immediate crash of the > application at runtime. This patch seems much more robust than counting on > toolchains to always arrange to avoid double in

[clang] [llvm] [Sanitizer] Make sanitizer passes idempotent (PR #99439)

2024-07-26 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > In the worse case we need this, I'd hope that this is target-specific. What does this mean? https://github.com/llvm/llvm-project/pull/99439 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] dbb8b7a - Reapply "[OpenMP][libc] Remove special handling for OpenMP printf (#98940)"

2024-07-26 Thread Joseph Huber via cfe-commits
Author: Joseph Huber Date: 2024-07-26T17:21:56-05:00 New Revision: dbb8b7a0f4eea1aa333cec9a38aa6eb7ecf6c1dc URL: https://github.com/llvm/llvm-project/commit/dbb8b7a0f4eea1aa333cec9a38aa6eb7ecf6c1dc DIFF: https://github.com/llvm/llvm-project/commit/dbb8b7a0f4eea1aa333cec9a38aa6eb7ecf6c1dc.diff

[clang] [llvm] [Sanitizer] Make sanitizer passes idempotent (PR #99439)

2024-07-26 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > > @MaskRay can you talk more about your concerns? This won't affect compile > > time, and instrumenting a shadow load will cause an immediate crash of the > > application at runtime. This patch seems much more robust than counting on > > toolchains to always arrange to avoi

[clang-tools-extra] [clang-tidy] Add bugprone-move-shared-pointer-contents check. (PR #67467)

2024-07-26 Thread via cfe-commits
https://github.com/pizzud updated https://github.com/llvm/llvm-project/pull/67467 >From 04a3e8d8cbd6943f44a81fddb0524902202a1a78 Mon Sep 17 00:00:00 2001 From: David Pizzuto Date: Tue, 26 Sep 2023 10:45:42 -0700 Subject: [PATCH 1/7] [clang-tidy] Add bugprone-move-shared-pointer-contents check.

[clang-tools-extra] [clang-tidy] Add bugprone-move-shared-pointer-contents check. (PR #67467)

2024-07-26 Thread via cfe-commits
https://github.com/pizzud updated https://github.com/llvm/llvm-project/pull/67467 >From 04a3e8d8cbd6943f44a81fddb0524902202a1a78 Mon Sep 17 00:00:00 2001 From: David Pizzuto Date: Tue, 26 Sep 2023 10:45:42 -0700 Subject: [PATCH 1/8] [clang-tidy] Add bugprone-move-shared-pointer-contents check.

[clang-tools-extra] [clang-tidy] Add bugprone-move-shared-pointer-contents check. (PR #67467)

2024-07-26 Thread via cfe-commits
https://github.com/pizzud updated https://github.com/llvm/llvm-project/pull/67467 >From 04a3e8d8cbd6943f44a81fddb0524902202a1a78 Mon Sep 17 00:00:00 2001 From: David Pizzuto Date: Tue, 26 Sep 2023 10:45:42 -0700 Subject: [PATCH 1/9] [clang-tidy] Add bugprone-move-shared-pointer-contents check.

[clang-tools-extra] [clang-tidy] Add bugprone-move-shared-pointer-contents check. (PR #67467)

2024-07-26 Thread via cfe-commits
https://github.com/pizzud updated https://github.com/llvm/llvm-project/pull/67467 >From 04a3e8d8cbd6943f44a81fddb0524902202a1a78 Mon Sep 17 00:00:00 2001 From: David Pizzuto Date: Tue, 26 Sep 2023 10:45:42 -0700 Subject: [PATCH 01/10] [clang-tidy] Add bugprone-move-shared-pointer-contents chec

[clang] [clang-tools-extra] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-07-26 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/100692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add bugprone-move-shared-pointer-contents check. (PR #67467)

2024-07-26 Thread via cfe-commits
https://github.com/pizzud updated https://github.com/llvm/llvm-project/pull/67467 >From 04a3e8d8cbd6943f44a81fddb0524902202a1a78 Mon Sep 17 00:00:00 2001 From: David Pizzuto Date: Tue, 26 Sep 2023 10:45:42 -0700 Subject: [PATCH 01/10] [clang-tidy] Add bugprone-move-shared-pointer-contents chec

[clang-tools-extra] [clang-tidy] Add bugprone-move-shared-pointer-contents check. (PR #67467)

2024-07-26 Thread via cfe-commits
@@ -0,0 +1,125 @@ +// RUN: %check_clang_tidy %s bugprone-move-shared-pointer-contents %t -- -config="{CheckOptions: {bugprone-move-shared-pointer-contents.SharedPointerClasses: '::std::shared_ptr;my::OtherSharedPtr;'}}" + +// Some dummy definitions we'll need. + +namespace std

[clang-tools-extra] [clang-tidy] Add bugprone-move-shared-pointer-contents check. (PR #67467)

2024-07-26 Thread via cfe-commits
pizzud wrote: Should be resolved now. Thanks for your patience. https://github.com/llvm/llvm-project/pull/67467 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add bugprone-move-shared-pointer-contents check. (PR #67467)

2024-07-26 Thread via cfe-commits
@@ -0,0 +1,22 @@ +.. title:: clang-tidy - bugprone-move-shared-pointer-contents + +bugprone-move-shared-pointer-contents += + + +Detects calls to move the contents out of a ``std::shared_ptr`` rather +than moving the pointer itself. In other wor

[clang-tools-extra] [clang-tidy] Add bugprone-move-shared-pointer-contents check. (PR #67467)

2024-07-26 Thread via cfe-commits
https://github.com/pizzud updated https://github.com/llvm/llvm-project/pull/67467 >From 04a3e8d8cbd6943f44a81fddb0524902202a1a78 Mon Sep 17 00:00:00 2001 From: David Pizzuto Date: Tue, 26 Sep 2023 10:45:42 -0700 Subject: [PATCH 01/11] [clang-tidy] Add bugprone-move-shared-pointer-contents chec

[clang] [Modules] Fix using `va_list` with modules and a precompiled header. (PR #100837)

2024-07-26 Thread Volodymyr Sapsai via cfe-commits
https://github.com/vsapsai created https://github.com/llvm/llvm-project/pull/100837 Fix the false warning > incompatible pointer types passing 'va_list' (aka '__builtin_va_list') to > parameter of type 'struct __va_list_tag *' [-Wincompatible-pointer-types] The warning is wrong because both in

[clang] [Modules] Fix using `va_list` with modules and a precompiled header. (PR #100837)

2024-07-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Volodymyr Sapsai (vsapsai) Changes Fix the false warning > incompatible pointer types passing 'va_list' (aka '__builtin_va_list') to parameter of type 'struct __va_list_tag *' [-Wincompatible-pointer-types] The warning is wrong because bo

[clang] [flang] [llvm] [C++23] [CLANG] Adding C++23 constexpr math functions: fmin, fmax and frexp. (PR #88978)

2024-07-26 Thread Hubert Tong via cfe-commits
@@ -0,0 +1,162 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 4 +// RUN: %clang_cc1 -x c++ -triple x86_64-unknown-unknown -std=c++23 \ +// RUN: -DWIN -emit-llvm -o - %s | FileCheck %s --check-prefixes=WIN + +// RUN: %clang_cc

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-07-26 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov updated https://github.com/llvm/llvm-project/pull/100692 >From 1aa99ba557fd563dc55c9cd4c6d8ce7f05b3bd6d Mon Sep 17 00:00:00 2001 From: Matheus Izvekov Date: Wed, 24 Jul 2024 03:59:41 -0300 Subject: [PATCH] [clang] check deduction consistency when partial ordering fu

[clang] [lldb] [llvm] [BOLT][DWARF][NFC] Add tests to check with an increased batch size (PR #100851)

2024-07-26 Thread Sayhaan Siddiqui via cfe-commits
https://github.com/sayhaan created https://github.com/llvm/llvm-project/pull/100851 Adds tests to check debug_ranges with an increased batch size and sets previous test's batch size at 1 to prevent a functional change. >From ace8031ce49898d2f59b32eb07f2208461da9028 Mon Sep 17 00:00:00 2001 Fro

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-07-26 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov edited https://github.com/llvm/llvm-project/pull/100692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-07-26 Thread Fangrui Song via cfe-commits
MaskRay wrote: Building abseil-cpp with the new Clang runs into errors. Are they expected? ```sh git clone https://github.com/abseil/abseil-cpp/ cd abseil-cpp cmake -GNinja -S. -Bout/release -DCMAKE_BUILD_TYPE=Release -DCMAKE_CXX_COMPILER=/tmp/Rel/bin/clang++ -DCMAKE_C_COMPILER=/tmp/Rel/bin/cla

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-07-26 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: > Building abseil-cpp with the new Clang runs into errors. Are they expected? Did you test the version I just pushed 25 minutes ago? I believe these particular breakages should be fixed there. We just implemented a rule change to account for the string_view failures, but in an

[clang] [clang-format] Handle parenthesized list in RemoveParentheses (PR #100852)

2024-07-26 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/100852 Also, reformat clang-format source to remove redundant parentheses enclosing single list items. Fixes #100768. >From f06f3ab5e59217348e72179c9581be338efa8789 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri,

[clang] [clang-format] Handle parenthesized list in RemoveParentheses (PR #100852)

2024-07-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Also, reformat clang-format source to remove redundant parentheses enclosing single list items. Fixes #100768. --- Full diff: https://github.com/llvm/llvm-project/pull/100852.diff 4 Files Affected: - (

[clang] [clang] check deduction consistency when partial ordering function templates (PR #100692)

2024-07-26 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: > Building abseil-cpp with the new Clang runs into errors. Are they expected? Nevermind, that's a different failure. Still investigating. https://github.com/llvm/llvm-project/pull/100692 ___ cfe-commits mailing list cfe-commits@lists

[libunwind] [libunwind] fix unwinding from signal handler (PR #92291)

2024-07-26 Thread David Tenty via cfe-commits
daltenty wrote: This is breaking a number of tests for the UBSAN on AIX, the traceback produced by the runtime are no longer correct. Before this change: ``` UndefinedBehaviorSanitizer:DEADLYSIGNAL ==52887862==ERROR: UndefinedBehaviorSanitizer: SEGV on unknown address 0x (pc 0x1784

[clang] [llvm] target ABI: improve call parameters extensions handling (PR #100757)

2024-07-26 Thread Phoebe Wang via cfe-commits
@@ -1185,6 +1189,9 @@ Currently, only the following parameter attributes are defined: value should be sign-extended to the extent required by the target's ABI (which is usually 32-bits) by the caller (for a parameter) or the callee (for a return value). +``noext``

[clang-tools-extra] clang-tidy: readability-redundant-smartptr-get does not remove (#97964) (PR #100177)

2024-07-26 Thread via cfe-commits
https://github.com/akshaykumars614 updated https://github.com/llvm/llvm-project/pull/100177 >From a9850211dae37e5b3d0cbbaf7eb25435ad8810f9 Mon Sep 17 00:00:00 2001 From: akshaykumars614 Date: Tue, 23 Jul 2024 14:32:24 -0400 Subject: [PATCH 1/3] clang-tidy: readability-redundant-smartptr-get doe

[clang-tools-extra] clang-tidy: readability-redundant-smartptr-get does not remove (#97964) (PR #100177)

2024-07-26 Thread via cfe-commits
https://github.com/akshaykumars614 updated https://github.com/llvm/llvm-project/pull/100177 >From a9850211dae37e5b3d0cbbaf7eb25435ad8810f9 Mon Sep 17 00:00:00 2001 From: akshaykumars614 Date: Tue, 23 Jul 2024 14:32:24 -0400 Subject: [PATCH 1/4] clang-tidy: readability-redundant-smartptr-get doe

[clang] [Clang][Interp] Fix the location of uninitialized base warning (PR #100761)

2024-07-26 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr edited https://github.com/llvm/llvm-project/pull/100761 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Interp] Fix the location of uninitialized base warning (PR #100761)

2024-07-26 Thread Timm Baeder via cfe-commits
@@ -122,22 +122,20 @@ static bool CheckFieldsInitialized(InterpState &S, SourceLocation Loc, } // Check Fields in all bases - for (const Record::Base &B : R->bases()) { + unsigned BaseIndex = 0; + const CXXRecordDecl *CD = dyn_cast(R->getDecl()); + for (const CXXBaseS

[clang] [Clang][Interp] Fix the location of uninitialized base warning (PR #100761)

2024-07-26 Thread Timm Baeder via cfe-commits
@@ -122,22 +122,20 @@ static bool CheckFieldsInitialized(InterpState &S, SourceLocation Loc, } // Check Fields in all bases - for (const Record::Base &B : R->bases()) { + unsigned BaseIndex = 0; + const CXXRecordDecl *CD = dyn_cast(R->getDecl()); + for (const CXXBaseS

[clang] [Clang][Interp] Fix the location of uninitialized base warning (PR #100761)

2024-07-26 Thread Timm Baeder via cfe-commits
@@ -122,22 +122,20 @@ static bool CheckFieldsInitialized(InterpState &S, SourceLocation Loc, } // Check Fields in all bases - for (const Record::Base &B : R->bases()) { + unsigned BaseIndex = 0; + const CXXRecordDecl *CD = dyn_cast(R->getDecl()); tbaed

[clang] [Clang][Interp] Fix the location of uninitialized base warning (PR #100761)

2024-07-26 Thread Timm Baeder via cfe-commits
@@ -122,22 +122,20 @@ static bool CheckFieldsInitialized(InterpState &S, SourceLocation Loc, } // Check Fields in all bases - for (const Record::Base &B : R->bases()) { + unsigned BaseIndex = 0; + const CXXRecordDecl *CD = dyn_cast(R->getDecl()); tbaed

[clang] [Clang][Interp] Fix the location of uninitialized base warning (PR #100761)

2024-07-26 Thread Timm Baeder via cfe-commits
@@ -14,33 +14,29 @@ struct DelBase { constexpr DelBase() = delete; // expected-note {{'DelBase' has been explicitly marked deleted here}} tbaederr wrote: The second bullet point of the comment at the top of the file is obsolete now. https://github.com/llvm/l

[clang] [Clang][Interp] Fix the location of uninitialized base warning (PR #100761)

2024-07-26 Thread Timm Baeder via cfe-commits
https://github.com/tbaederr commented: ![Screenshot from 2024-07-27 07-04-02](https://github.com/user-attachments/assets/5a7c4b26-2c68-4bb1-8480-4b7ff9e4be87) The three regressions all have similar stack traces: ``` #5 0x0bba9f4c clang::Redeclarable::getFirstDecl() /home/fedora/interp

[clang] [Clang] fix generic lambda inside requires-clause of friend function template (PR #99813)

2024-07-26 Thread Zhikai Zeng via cfe-commits
https://github.com/Backl1ght updated https://github.com/llvm/llvm-project/pull/99813 >From 5d7f291e35930e07f52a7ac17a09f93690b64def Mon Sep 17 00:00:00 2001 From: Backl1ght Date: Sun, 21 Jul 2024 23:43:24 +0800 Subject: [PATCH 1/2] fix --- clang/docs/ReleaseNotes.rst | 2 ++

[clang] [Clang] fix generic lambda inside requires-clause of friend function template (PR #99813)

2024-07-26 Thread Zhikai Zeng via cfe-commits
@@ -1691,10 +1691,7 @@ class ConstraintRefersToContainingTemplateChecker using inherited::TransformTemplateTypeParmType; QualType TransformTemplateTypeParmType(TypeLocBuilder &TLB, TemplateTypeParmTypeLoc TL, bool) { -assert(TL.g

[clang] [llvm] [Sanitizer] Make sanitizer passes idempotent (PR #99439)

2024-07-26 Thread via cfe-commits
https://github.com/skc7 updated https://github.com/llvm/llvm-project/pull/99439 >From 2bcca883eae902238cb49d44ed24aa1304364646 Mon Sep 17 00:00:00 2001 From: skc7 Date: Thu, 18 Jul 2024 11:49:24 +0530 Subject: [PATCH] [Sanitizer] Make sanitizer passes idempotent. --- clang/test/CodeGenObjC/no-

[clang] [ASTMatchers] Extend hasName matcher when matching templates (PR #100349)

2024-07-26 Thread Nathan James via cfe-commits
https://github.com/njames93 updated https://github.com/llvm/llvm-project/pull/100349 >From a81c1b2ee0bd0d0622abf1d5ec06846a2e2e3a27 Mon Sep 17 00:00:00 2001 From: Nathan James Date: Wed, 24 Jul 2024 12:43:39 +0100 Subject: [PATCH] [ASMMatchers] Extend hasName matcher when matching templates Al

[clang-tools-extra] Extend support for specifying languages and version in add_new_check.py (PR #100129)

2024-07-26 Thread Nathan James via cfe-commits
https://github.com/njames93 updated https://github.com/llvm/llvm-project/pull/100129 >From ed5cdfdd4696f4af2f6cd3dd09d4104744b74cc5 Mon Sep 17 00:00:00 2001 From: Nathan James Date: Tue, 23 Jul 2024 15:24:52 +0100 Subject: [PATCH] Extend support for specifying languages and version in add_new_

[clang-tools-extra] Extend support for specifying languages and version in add_new_check.py (PR #100129)

2024-07-26 Thread via cfe-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 13996378d81c8fa9a364aeaafd7382abbc1db83a...ed5cdfdd4696f4af2f6cd3dd09d4104744b74cc5 clang

<    1   2   3   4