[clang] [clang] Implement `__is_virtual_base_of()` intrinsic (PR #100393)

2024-07-26 Thread via cfe-commits
cor3ntin wrote: The CI issues are unrelated so I'll merge this (someone should investigate why `clang-doc` tests are still failing though @PeterChou1. Thanks) @Endilll Thanks for the patch :) https://github.com/llvm/llvm-project/pull/100393 ___ cfe-c

[clang] 988fd95 - [clang] Implement `__builtin_is_virtual_base_of()` intrinsic (#100393)

2024-07-26 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2024-07-26T09:09:54+02:00 New Revision: 988fd956e776bad8057a8b7ee051a524308c097b URL: https://github.com/llvm/llvm-project/commit/988fd956e776bad8057a8b7ee051a524308c097b DIFF: https://github.com/llvm/llvm-project/commit/988fd956e776bad8057a8b7ee051a524308c097b.

[clang] [clang] Implement `__is_virtual_base_of()` intrinsic (PR #100393)

2024-07-26 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/100393 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][FMV][AArch64] Improve streaming mode compatibility. (PR #100181)

2024-07-26 Thread Sander de Smalen via cfe-commits
https://github.com/sdesmalen-arm approved this pull request. Thanks for addressing the feedback @labrinea, LGTM! https://github.com/llvm/llvm-project/pull/100181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] [Clang] Use private address space for builtin_alloca return type for OpenCL (PR #95750)

2024-07-26 Thread Vikash Gupta via cfe-commits
https://github.com/vg0204 updated https://github.com/llvm/llvm-project/pull/95750 >From ac967e4f887bd511bdfcaf30a0c94aa083cbf980 Mon Sep 17 00:00:00 2001 From: vg0204 Date: Mon, 17 Jun 2024 11:20:02 +0530 Subject: [PATCH 1/9] [Clang] Use private address space for builtin_alloca for OpenCL The

[clang-tools-extra] ed1c67b - Add a description parameter to the add_new_check script (#100111)

2024-07-26 Thread via cfe-commits
Author: Nathan James Date: 2024-07-26T08:16:08+01:00 New Revision: ed1c67b129bdb4343a147e1d72968e7d1f0cd1cf URL: https://github.com/llvm/llvm-project/commit/ed1c67b129bdb4343a147e1d72968e7d1f0cd1cf DIFF: https://github.com/llvm/llvm-project/commit/ed1c67b129bdb4343a147e1d72968e7d1f0cd1cf.diff

[clang-tools-extra] Add a description parameter to the add_new_check script (PR #100111)

2024-07-26 Thread Nathan James via cfe-commits
https://github.com/njames93 closed https://github.com/llvm/llvm-project/pull/100111 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix #99858 (PR #99859)

2024-07-26 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: My impression is that in this case, the Decl is supposed to be instantiated here, so in valid code, a instantiation would be found, so strictly speaking the null check would not be the right thing. But we do have cases where we don't instantiate in case the Decl is invalid. In

[clang] [clang] Enable the -Wdangling-assignment-gsl diagnostic by default. (PR #100708)

2024-07-26 Thread Haojian Wu via cfe-commits
https://github.com/hokein created https://github.com/llvm/llvm-project/pull/100708 None >From 69670cf28f04d82adde27be86af6b8ce40e7a01c Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Fri, 26 Jul 2024 09:17:50 +0200 Subject: [PATCH] [clang] Enable the -Wdangling-assignment-gsl diagnostic by de

[clang] [clang] Enable the -Wdangling-assignment-gsl diagnostic by default. (PR #100708)

2024-07-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Haojian Wu (hokein) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/100708.diff 2 Files Affected: - (modified) clang/docs/ReleaseNotes.rst (+2) - (modified) clang/include/clang/Basic/DiagnosticSemaKinds.td (+1-1) `

[clang] 9482a83 - [PS5][Driver] Ensure stack sizes are emitted by LTO (#100592)

2024-07-26 Thread via cfe-commits
Author: Edd Dawson Date: 2024-07-26T08:21:42+01:00 New Revision: 9482a8385b94f2c32379fb0b946516ff54261b32 URL: https://github.com/llvm/llvm-project/commit/9482a8385b94f2c32379fb0b946516ff54261b32 DIFF: https://github.com/llvm/llvm-project/commit/9482a8385b94f2c32379fb0b946516ff54261b32.diff LO

[clang] [PS5][Driver] Ensure stack sizes are emitted by LTO (PR #100592)

2024-07-26 Thread Edd Dawson via cfe-commits
https://github.com/playstation-edd closed https://github.com/llvm/llvm-project/pull/100592 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [SemaCXX] Implement CWG2627 Bit-fields and narrowing conversions (PR #78112)

2024-07-26 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok updated https://github.com/llvm/llvm-project/pull/78112 >From 92f8720e3d21521b589d5291f086a2f32b87bfe0 Mon Sep 17 00:00:00 2001 From: Mital Ashok Date: Sun, 14 Jan 2024 19:52:31 + Subject: [PATCH 01/10] [clang] [SemaCXX] Implement CWG2627 Bit-fields and narrow

[clang] [clang] Implement CWG2627 Bit-fields and narrowing conversions (PR #78112)

2024-07-26 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok edited https://github.com/llvm/llvm-project/pull/78112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable the -Wdangling-assignment-gsl diagnostic by default. (PR #100708)

2024-07-26 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/100708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement CWG2627 Bit-fields and narrowing conversions (PR #78112)

2024-07-26 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok edited https://github.com/llvm/llvm-project/pull/78112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement CWG2851: floating-point conversions in converted constant expressions (PR #90387)

2024-07-26 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok updated https://github.com/llvm/llvm-project/pull/90387 >From 77cb28e6faf95f5beb3fadc225cb5f0525b3dfe6 Mon Sep 17 00:00:00 2001 From: Mital Ashok Date: Sun, 28 Apr 2024 09:48:47 +0100 Subject: [PATCH 1/3] [clang] Implement CWG2851: floating-point conversions in co

[clang] [clang][Driver] Support passing arbitrary args to -cc1as with -Xclangas. (PR #100714)

2024-07-26 Thread Alex Rønne Petersen via cfe-commits
https://github.com/alexrp created https://github.com/llvm/llvm-project/pull/100714 This is one of the ideas I gave in #97517. I opted to propose this one first as introducing a new `-Xclangas` option comes with no concerns about GCC compatibility as with `-Xassembler`. I am not sure where wou

[clang] [clang][Driver] Support passing arbitrary args to -cc1as with -Xclangas. (PR #100714)

2024-07-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Alex Rønne Petersen (alexrp) Changes This is one of the ideas I gave in #97517. I opted to propose this one first as introducing a new `-Xclangas` option comes with no concerns about GCC compatibility as with `-Xassembler`. I am n

[clang] [flang] [Flang-new][OpenMP] Add bitcode files for AMD GPU OpenMP (PR #96742)

2024-07-26 Thread Dominik Adamski via cfe-commits
https://github.com/DominikAdamski updated https://github.com/llvm/llvm-project/pull/96742 >From 5b487aac3c8414b6f37f6888f361ca7488094048 Mon Sep 17 00:00:00 2001 From: Dominik Adamski Date: Fri, 21 Jun 2024 18:03:53 +0200 Subject: [PATCH 1/5] [Flang-new][OpenMP] Add offload related flags for AM

[clang] [Clang] Add __builtin_is_within_lifetime to implement P2641R4's std::is_within_lifetime (PR #91895)

2024-07-26 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok updated https://github.com/llvm/llvm-project/pull/91895 >From 56aed689dc5825fc5bacc6dfdff58ee0eaf71f82 Mon Sep 17 00:00:00 2001 From: Mital Ashok Date: Sun, 12 May 2024 19:48:24 +0100 Subject: [PATCH 1/9] [Clang] Add attribute for consteval builtins; Declare const

[clang] [flang] [Flang-new][OpenMP] Add bitcode files for AMD GPU OpenMP (PR #96742)

2024-07-26 Thread Dominik Adamski via cfe-commits
DominikAdamski wrote: > > > Who could be the right person to ask? > > > > I don't know. Open-source LLVM Flang meetings can be good place to ask this > > question. > > Did you ask? What feedback did you get? @banach-space I asked question on flang-slack, I mentioned the issue on the latest Fl

[clang] [clang][Driver] Support passing arbitrary args to -cc1as with -Xclangas. (PR #100714)

2024-07-26 Thread Alex Rønne Petersen via cfe-commits
alexrp wrote: I'm assuming this failure is not caused by my changes: https://github.com/llvm/llvm-project/actions/runs/10107700664/job/27952082137?pr=100714 https://github.com/llvm/llvm-project/pull/100714 ___ cfe-commits mailing list cfe-commits@list

[clang] 9440a49 - [clang][analyzer] MmapWriteExecChecker improvements (#97078)

2024-07-26 Thread via cfe-commits
Author: Balázs Kéri Date: 2024-07-26T10:10:36+02:00 New Revision: 9440a49b0ff812c889927e4dc81e746b32124bb4 URL: https://github.com/llvm/llvm-project/commit/9440a49b0ff812c889927e4dc81e746b32124bb4 DIFF: https://github.com/llvm/llvm-project/commit/9440a49b0ff812c889927e4dc81e746b32124bb4.diff L

[clang] [clang][analyzer] MmapWriteExecChecker improvements (PR #97078)

2024-07-26 Thread Balázs Kéri via cfe-commits
https://github.com/balazske closed https://github.com/llvm/llvm-project/pull/97078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] f8ae128 - [clang][FMV][AArch64] Improve streaming mode compatibility. (#100181)

2024-07-26 Thread via cfe-commits
Author: Alexandros Lamprineas Date: 2024-07-26T09:22:47+01:00 New Revision: f8ae128755777424cf4133e4e8e819c0bc08d2b1 URL: https://github.com/llvm/llvm-project/commit/f8ae128755777424cf4133e4e8e819c0bc08d2b1 DIFF: https://github.com/llvm/llvm-project/commit/f8ae128755777424cf4133e4e8e819c0bc08d2

[clang] [clang][FMV][AArch64] Improve streaming mode compatibility. (PR #100181)

2024-07-26 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea closed https://github.com/llvm/llvm-project/pull/100181 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Implement intrinsics for SME2 FAMIN/FAMAX (PR #99063)

2024-07-26 Thread via cfe-commits
https://github.com/CarolineConcatto approved this pull request. Thank you Momchil, the patch looks fine. This time a checked the flags in arm_sve.td and they look ok. https://github.com/llvm/llvm-project/pull/99063 ___ cfe-commits mailing list cfe-comm

[clang] [Clang] Qualified functions can't decay into pointers (PR #90353)

2024-07-26 Thread via cfe-commits
https://github.com/cor3ntin commented: Thanks! I think the general approach makes sense There are a few DR that might be worth mentioning/add tests for/look into https://cplusplus.github.io/CWG/issues/713.html https://cplusplus.github.io/CWG/issues/1417.html https://cplusplus.github.io/CWG/issu

[clang] [Clang] Qualified functions can't decay into pointers (PR #90353)

2024-07-26 Thread via cfe-commits
@@ -15071,6 +15071,13 @@ ParmVarDecl *Sema::CheckParameter(DeclContext *DC, SourceLocation StartLoc, T = Context.getLifetimeQualifiedType(T, lifetime); } + if (T->isFunctionType() && !T.isReferenceable()) { +Diag(NameLoc, diag::err_compound_qualified_function_type)

[clang] [Clang] Qualified functions can't decay into pointers (PR #90353)

2024-07-26 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/90353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][FMV][AArch64] Improve streaming mode compatibility. (PR #100181)

2024-07-26 Thread via cfe-commits
llvmbot wrote: Failed to cherry-pick: [f8ae128](https://github.com/llvm/llvm-project/commit/f8ae128755777424cf4133e4e8e819c0bc08d2b1) https://github.com/llvm/llvm-project/actions/runs/10108416112 Please manually backport the fix and push it to your github fork. Once this is done, please cre

[clang] [clang-tools-extra] [Clang] Implement CWG2813: Class member access with prvalues (PR #95112)

2024-07-26 Thread via cfe-commits
@@ -10673,6 +10673,11 @@ class Sema final : public SemaBase { SourceLocation EndLoc); void ActOnForEachDeclStmt(DeclGroupPtrTy Decl); + /// DiagnoseDiscardedNodiscard - Given an expression that is semantically + /// a discarded-value expression,

[clang] [analyzer][NFC] Eliminate a dyn_cast (PR #100719)

2024-07-26 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus created https://github.com/llvm/llvm-project/pull/100719 Response to the catch in this comment: https://github.com/llvm/llvm-project/pull/94357/files/07f6daf2cf0f5d5bd4fc9950f2585a3f52b4ad2f#r1692084074 From d176b03b211144dadaa1efb4b7da959110d7725c Mon Sep 17 00:00

[clang] [analyzer][NFC] Factor out NoOwnershipChangeVisitor (PR #94357)

2024-07-26 Thread Kristóf Umann via cfe-commits
@@ -804,23 +751,21 @@ class NoOwnershipChangeVisitor final : public NoStateChangeFuncVisitor { return false; } + bool hasResourceStateChanged(ProgramStateRef CallEnterState, + ProgramStateRef CallExitEndState) final { +return CallEnter

[clang] [analyzer][NFC] Eliminate a dyn_cast (PR #100719)

2024-07-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 Author: Kristóf Umann (Szelethus) Changes Response to the catch in this comment: https://github.com/llvm/llvm-project/pull/94357/files/07f6daf2cf0f5d5bd4fc9950f2585a3f52b4ad2f#r1692084074 --- Full diff: https://github.com/llvm/l

[clang] [analyzer][NFC] Eliminate a dyn_cast (PR #100719)

2024-07-26 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat approved this pull request. https://github.com/llvm/llvm-project/pull/100719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ASTImporter] Fix import of template parameter default values. (PR #100100)

2024-07-26 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat approved this pull request. https://github.com/llvm/llvm-project/pull/100100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ASTImporter] Fix import of template parameter default values. (PR #100100)

2024-07-26 Thread Donát Nagy via cfe-commits
@@ -359,6 +359,31 @@ namespace clang { Params, Importer.getToContext().getTranslationUnitDecl()); } +template +void tryUpdateTemplateParmDeclInheritedFrom(NamedDecl *RecentParm, +NamedDecl *NewParm) { +

[clang] [clang] replaced the usage of `asctime` with `std::put_time` (PR #99075)

2024-07-26 Thread Rainer Orth via cfe-commits
rorth wrote: > > At least in the short term. ISTM that `clang++` may need to do something > > along the lines of Bug 33767 (resp. the underlying GCC bug/patch), > > otherwise users are in for a nasty surprise. > > Agreed; long-term we need a better solution. Hopefully someone maintaining > So

[clang] [clang-tools-extra] [Clang] Implement CWG2813: Class member access with prvalues (PR #95112)

2024-07-26 Thread via cfe-commits
@@ -222,17 +222,17 @@ static bool DiagnoseNoDiscard(Sema &S, const WarnUnusedResultAttr *A, return S.Diag(Loc, diag::warn_unused_result_msg) << A << Msg << R1 << R2; } -void Sema::DiagnoseUnusedExprResult(const Stmt *S, unsigned DiagID) { - if (const LabelStmt *Label = dyn

[clang] [clang-tools-extra] [Clang] Implement CWG2813: Class member access with prvalues (PR #95112)

2024-07-26 Thread via cfe-commits
https://github.com/cor3ntin commented: General direction looks good https://github.com/llvm/llvm-project/pull/95112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [Clang] Implement CWG2813: Class member access with prvalues (PR #95112)

2024-07-26 Thread via cfe-commits
@@ -222,17 +222,17 @@ static bool DiagnoseNoDiscard(Sema &S, const WarnUnusedResultAttr *A, return S.Diag(Loc, diag::warn_unused_result_msg) << A << Msg << R1 << R2; } -void Sema::DiagnoseUnusedExprResult(const Stmt *S, unsigned DiagID) { - if (const LabelStmt *Label = dyn

[clang] [clang-tools-extra] [Clang] Implement CWG2813: Class member access with prvalues (PR #95112)

2024-07-26 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/95112 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Handle tm mangling on Solaris in PPMacroExpansion.cpp (PR #100724)

2024-07-26 Thread Rainer Orth via cfe-commits
https://github.com/rorth created https://github.com/llvm/llvm-project/pull/100724 The introduction of `std::put_time` in fad17b43dbc09ac7e0a95535459845f72c2b739a broke the Solaris build: ``` Undefined first referenced symbol in file _ZNKSt8time_

[clang] [clang] Handle tm mangling on Solaris in PPMacroExpansion.cpp (PR #100724)

2024-07-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Rainer Orth (rorth) Changes The introduction of `std::put_time` in fad17b43dbc09ac7e0a95535459845f72c2b739a broke the Solaris build: ``` Undefined first referenced symbol in file _ZNKSt8tim

[clang] d65f037 - [Clang] Use private address space for builtin_alloca return type for OpenCL (#95750)

2024-07-26 Thread via cfe-commits
Author: Vikash Gupta Date: 2024-07-26T15:24:06+05:30 New Revision: d65f0375910f6dfeaa94c1060e7d81fb7bdf76be URL: https://github.com/llvm/llvm-project/commit/d65f0375910f6dfeaa94c1060e7d81fb7bdf76be DIFF: https://github.com/llvm/llvm-project/commit/d65f0375910f6dfeaa94c1060e7d81fb7bdf76be.diff

[clang] [Clang] Use private address space for builtin_alloca return type for OpenCL (PR #95750)

2024-07-26 Thread Vikash Gupta via cfe-commits
https://github.com/vg0204 closed https://github.com/llvm/llvm-project/pull/95750 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Avoid accessing unset optional, workaround for #100095 (PR #100408)

2024-07-26 Thread Alexander Kornienko via cfe-commits
alexfh wrote: > Could we merge the test into this change? I think we could then land this as > a temporary workaround indeed. I'll keep looking into fixing this proper and > will remove the XFAIL line when appropriate. I've added the test to the change and verified it: * fails without the Sem

[clang] [clang][analyzer] MmapWriteExecChecker improvements (PR #97078)

2024-07-26 Thread LLVM Continuous Integration via cfe-commits
=?utf-8?q?Balázs_Kéri?= , =?utf-8?q?Balázs_Kéri?= Message-ID: In-Reply-To: llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux-bootstrap-asan` running on `sanitizer-buildbot1` while building `clang` at step 2 "annotate". Full details are available at:

[clang] [clang][CGRecordLayout] Remove dependency on isZeroSize (PR #96422)

2024-07-26 Thread Sergei Barannikov via cfe-commits
@@ -137,6 +137,16 @@ bool isEmptyField(ASTContext &Context, const FieldDecl *FD, bool AllowArrays, bool isEmptyRecord(ASTContext &Context, QualType T, bool AllowArrays, bool AsIfNoUniqueAddr = false); +/// isEmptyFieldForLayout - Return true iff the field i

[clang-tools-extra] 88549cf - [clang-doc] Disable flaky test `basic-project.test`

2024-07-26 Thread Vlad Serebrennikov via cfe-commits
Author: Vlad Serebrennikov Date: 2024-07-26T13:15:35+03:00 New Revision: 88549cf47cafc4c4a6042393ee07fc2dc20566cc URL: https://github.com/llvm/llvm-project/commit/88549cf47cafc4c4a6042393ee07fc2dc20566cc DIFF: https://github.com/llvm/llvm-project/commit/88549cf47cafc4c4a6042393ee07fc2dc20566cc.

[clang] [llvm] [AARCH64][SVE] Add intrinsics for SVE LUTI instructions (PR #97058)

2024-07-26 Thread via cfe-commits
https://github.com/CarolineConcatto approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/97058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Enable the -Wdangling-assignment-gsl diagnostic by default. (PR #100708)

2024-07-26 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 approved this pull request. Thanks. Looks good since we are past the branch cut. https://github.com/llvm/llvm-project/pull/100708 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] Add _MM_FROUND_TO_NEAREST_TIES_EVEN to avx512fintrin.h (PR #99691)

2024-07-26 Thread Robin Charles Gilbert via cfe-commits
robincharlesgilbert wrote: To be fair, regarding MSVC, it might be more than just a chicken and the egg problem. It is sometimes in the best interests of Microsoft to make it as painful as possible for their customers to port their code onto other platforms, or to use standard libraries which

[clang] [analyzer][NFC] Eliminate a dyn_cast (PR #100719)

2024-07-26 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. https://github.com/llvm/llvm-project/pull/100719 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][clang] Avoid unnecessary assignment (PR #100728)

2024-07-26 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon created https://github.com/llvm/llvm-project/pull/100728 `IsStartOfLine` is set to false at the end of the loop. >From e41e817050df138a0ac791c8aac0a3331c66d8df Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Fri, 26 Jul 2024 03:39:51 -0700 Subject: [P

[clang] [NFC][clang] Avoid unnecessary assignment (PR #100728)

2024-07-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mariya Podchishchaeva (Fznamznon) Changes `IsStartOfLine` is set to false at the end of the loop. --- Full diff: https://github.com/llvm/llvm-project/pull/100728.diff 1 Files Affected: - (modified) clang/lib/Frontend/PrintPreprocessedOu

[clang] [llvm] [AArch64] Implement intrinsics for SVE FAMIN/FAMAX (PR #99042)

2024-07-26 Thread Momchil Velikov via cfe-commits
@@ -2385,3 +2385,8 @@ let SVETargetGuard = "sve2p1", SMETargetGuard = "sme2" in { def SVBFMLSLB_LANE : SInst<"svbfmlslb_lane[_{d}]", "dd$$i", "f", MergeNone, "aarch64_sve_bfmlslb_lane", [IsOverloadNone, VerifyRuntimeMode], [ImmCheck<3, ImmCheck0_7>]>; def SVBFMLSLT_LANE :

[clang] [flang] [Flang][Driver] Introduce -fopenmp-targets offloading option (PR #100152)

2024-07-26 Thread Sergio Afonso via cfe-commits
@@ -492,6 +493,18 @@ void Flang::addOffloadOptions(Compilation &C, const InputInfoList &Inputs, if (Args.hasArg(options::OPT_nogpulib)) CmdArgs.push_back("-nogpulib"); } + + // For all the host OpenMP offloading compile jobs we need to pass the targets + // info

[clang] [llvm] [Sanitizer] Make sanitizer passes idempotent (PR #99439)

2024-07-26 Thread via cfe-commits
https://github.com/skc7 updated https://github.com/llvm/llvm-project/pull/99439 >From 8a2a63ba5e2005fb2bf03b24610dc0e19130a978 Mon Sep 17 00:00:00 2001 From: skc7 Date: Thu, 18 Jul 2024 11:49:24 +0530 Subject: [PATCH 1/7] [ASAN] Make asan pass idempotent. --- .../Instrumentation/AddressSanitiz

[clang] 8d4cb92 - [NFC][Clang][Interp] Add more test for `__builtin_os_log_format_buffer_size` (#100566)

2024-07-26 Thread via cfe-commits
Author: yronglin Date: 2024-07-26T19:34:27+08:00 New Revision: 8d4cb92e3536e86b177c354c9c5cf6f06bd61c8d URL: https://github.com/llvm/llvm-project/commit/8d4cb92e3536e86b177c354c9c5cf6f06bd61c8d DIFF: https://github.com/llvm/llvm-project/commit/8d4cb92e3536e86b177c354c9c5cf6f06bd61c8d.diff LOG:

[clang] [NFC][Clang][Interp] Add more test for `__builtin_os_log_format_buffer_size` (PR #100566)

2024-07-26 Thread via cfe-commits
https://github.com/yronglin closed https://github.com/llvm/llvm-project/pull/100566 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Avoid accessing unset optional, workaround for #100095 (PR #100408)

2024-07-26 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov approved this pull request. LGTM, since it now has a test that executes this code path and changes from UB to defined (even if undesired behavior). As mentioned earlier, I'm working on a proper fix for those cases https://github.com/llvm/llvm-project/pull/10040

[clang] Avoid accessing unset optional, workaround for #100095 (PR #100408)

2024-07-26 Thread Ilya Biryukov via cfe-commits
https://github.com/ilya-biryukov edited https://github.com/llvm/llvm-project/pull/100408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] prevent checking destructor reference with an invalid initializer (PR #97860)

2024-07-26 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @cor3ntin If no further feedback is needed, could you please proceed with the merge? Thanks https://github.com/llvm/llvm-project/pull/97860 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [clang-cl] [Sema] Support MSVC non-const lvalue to user-defined temporary reference (PR #99833)

2024-07-26 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman requested changes to this pull request. Thank you for this! I think there's some work left to be done though. 1) Please add an extension warning (and tests for it) so users know where the extension is being used even if they opt into it explicitly. This is import

[clang] [clang-tools-extra] [llvm] [mlir] [clang][lldb][mlir] Fix some identical sub-expressions warnings (NFC) (PR #95715)

2024-07-26 Thread Shivam Gupta via cfe-commits
@@ -96,7 +96,7 @@ bool areStatementsIdentical(const Stmt *FirstStmt, const Stmt *SecondStmt, if (FirstStmt == SecondStmt) return true; - if (FirstStmt->getStmtClass() != FirstStmt->getStmtClass()) + if (FirstStmt->getStmtClass() != SecondStmt->getStmtClass())

[clang] [clang-tools-extra] [llvm] [mlir] [clang][lldb][mlir] Fix some identical sub-expressions warnings (NFC) (PR #95715)

2024-07-26 Thread Shivam Gupta via cfe-commits
@@ -4368,7 +4368,7 @@ bool Sema::DiagRedefinedPlaceholderFieldDecl(SourceLocation Loc, Diag(Loc, diag::err_using_placeholder_variable) << Name; for (DeclContextLookupResult::iterator It = Found; It != Result.end(); It++) { const NamedDecl *ND = *It; -if (ND->getDe

[clang] [NFC][clang] Avoid unnecessary assignment (PR #100728)

2024-07-26 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/100728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Handle tm mangling on Solaris in PPMacroExpansion.cpp (PR #100724)

2024-07-26 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you for helping out with this odd edge case! I don't suppose there's a way we can shove this hack into CMake (basically, like a kind of linker script hack)? If so, can we apply it broadly enough so that any use of `time_put` in other TUs will al

[clang] [llvm] [mlir] [clang][lldb][mlir] Fix some identical sub-expressions warnings (NFC) (PR #95715)

2024-07-26 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta updated https://github.com/llvm/llvm-project/pull/95715 >From c30bfb621f413c7271bb5a02a7d699e68e053ba1 Mon Sep 17 00:00:00 2001 From: Shivam Gupta Date: Sun, 16 Jun 2024 23:39:47 +0530 Subject: [PATCH 1/4] [clang][lldb][mlir] Fix some identical sub-expressions warning

[clang] [llvm] [mlir] [clang][lldb][mlir] Fix some identical sub-expressions warnings (NFC) (PR #95715)

2024-07-26 Thread Shivam Gupta via cfe-commits
https://github.com/xgupta edited https://github.com/llvm/llvm-project/pull/95715 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c9c91f5 - Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (#97342)

2024-07-26 Thread via cfe-commits
Author: Zahira Ammarguellat Date: 2024-07-26T08:16:38-04:00 New Revision: c9c91f59c318e28d884e5762f303348ba5724d21 URL: https://github.com/llvm/llvm-project/commit/c9c91f59c318e28d884e5762f303348ba5724d21 DIFF: https://github.com/llvm/llvm-project/commit/c9c91f59c318e28d884e5762f303348ba5724d21

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-26 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam closed https://github.com/llvm/llvm-project/pull/97342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Handle tm mangling on Solaris in PPMacroExpansion.cpp (PR #100724)

2024-07-26 Thread Rainer Orth via cfe-commits
rorth wrote: > Thank you for helping out with this odd edge case! I don't suppose there's a > way we can shove this hack into CMake (basically, like a kind of linker > script hack)? If so, can we apply it broadly enough so that any use of > `time_put` in other TUs will also benefit? This woul

[clang] bfa0cae - [NFC][clang] Avoid unnecessary assignment (#100728)

2024-07-26 Thread via cfe-commits
Author: Mariya Podchishchaeva Date: 2024-07-26T14:19:16+02:00 New Revision: bfa0cae31c1db7627c41dcebd660f5eaea796778 URL: https://github.com/llvm/llvm-project/commit/bfa0cae31c1db7627c41dcebd660f5eaea796778 DIFF: https://github.com/llvm/llvm-project/commit/bfa0cae31c1db7627c41dcebd660f5eaea7967

[clang] [NFC][clang] Avoid unnecessary assignment (PR #100728)

2024-07-26 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon closed https://github.com/llvm/llvm-project/pull/100728 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][AArch64] Add customisable immediate range checking to NEON (PR #100278)

2024-07-26 Thread via cfe-commits
https://github.com/SpencerAbson edited https://github.com/llvm/llvm-project/pull/100278 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8322a30 - Avoid accessing unset optional, workaround for #100095 (#100408)

2024-07-26 Thread via cfe-commits
Author: Alexander Kornienko Date: 2024-07-26T14:24:56+02:00 New Revision: 8322a3085c902de9759a40ccdcd194a4c46e7185 URL: https://github.com/llvm/llvm-project/commit/8322a3085c902de9759a40ccdcd194a4c46e7185 DIFF: https://github.com/llvm/llvm-project/commit/8322a3085c902de9759a40ccdcd194a4c46e7185

[clang] Avoid accessing unset optional, workaround for #100095 (PR #100408)

2024-07-26 Thread Alexander Kornienko via cfe-commits
https://github.com/alexfh closed https://github.com/llvm/llvm-project/pull/100408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] Remove unnecessary copy (PR #100688)

2024-07-26 Thread via cfe-commits
smanna12 wrote: Thank you @cor3ntin for reviews! https://github.com/llvm/llvm-project/pull/100688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 6e0a913 - [Clang][NFC] Remove unnecessary copy (#100688)

2024-07-26 Thread via cfe-commits
Author: smanna12 Date: 2024-07-26T07:27:09-05:00 New Revision: 6e0a913973111926f9fdbd82b72ea640b013167e URL: https://github.com/llvm/llvm-project/commit/6e0a913973111926f9fdbd82b72ea640b013167e DIFF: https://github.com/llvm/llvm-project/commit/6e0a913973111926f9fdbd82b72ea640b013167e.diff LOG:

[clang] [Clang][NFC] Remove unnecessary copy (PR #100688)

2024-07-26 Thread via cfe-commits
https://github.com/smanna12 closed https://github.com/llvm/llvm-project/pull/100688 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove `IDNS_Ordinary` flag in `IndirectFieldDecl::IdentifierNamespace` (PR #100525)

2024-07-26 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. The C standard does not make this particularly clear, but the changes are correct. Per C23 6.2.1p4 Each member of the structure has file scope (because why not) but per 6.2.3p1, each member is in a distinct name space and the member i

[clang] [Clang] Remove `IDNS_Ordinary` flag in `IndirectFieldDecl::IdentifierNamespace` (PR #100525)

2024-07-26 Thread Yanzuo Liu via cfe-commits
zwuis wrote: Thank you for your review! I don't have commit access. Please help me merge this PR if it's ready. https://github.com/llvm/llvm-project/pull/100525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] [Clang] Qualified functions can't decay into pointers (PR #90353)

2024-07-26 Thread Mital Ashok via cfe-commits
MitalAshok wrote: > https://cplusplus.github.io/CWG/issues/713.html This one is entirely editorial: it adds a note and edits another note. I've added a test for what the note says > https://cplusplus.github.io/CWG/issues/1417.html I'm not sure that this DR actually changes anything. It seems

[clang] [Clang] Qualified functions can't decay into pointers (PR #90353)

2024-07-26 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok updated https://github.com/llvm/llvm-project/pull/90353 >From d983badd09dcc227f5945f4b4759214b7b6adbf5 Mon Sep 17 00:00:00 2001 From: Mital Ashok Date: Fri, 26 Jul 2024 08:44:19 +0100 Subject: [PATCH 1/4] [Clang] Qualified functions can't decay into pointers ---

[clang] 9d22095 - [Clang] Remove `IDNS_Ordinary` flag in `IndirectFieldDecl::IdentifierNamespace` (#100525)

2024-07-26 Thread via cfe-commits
Author: Yanzuo Liu Date: 2024-07-26T08:39:46-04:00 New Revision: 9d220956320a36fd127ee14ed41f0ecdcc0fb5b0 URL: https://github.com/llvm/llvm-project/commit/9d220956320a36fd127ee14ed41f0ecdcc0fb5b0 DIFF: https://github.com/llvm/llvm-project/commit/9d220956320a36fd127ee14ed41f0ecdcc0fb5b0.diff LO

[clang] [Clang] Remove `IDNS_Ordinary` flag in `IndirectFieldDecl::IdentifierNamespace` (PR #100525)

2024-07-26 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/100525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] [Clang] Some core issues have changed status from tentatively ready -> ready / review (PR #97200)

2024-07-26 Thread Mital Ashok via cfe-commits
MitalAshok wrote: I've just found out "accepted" is a resolved DR, not open: https://www.open-std.org/jtc1/sc22/wg21/docs/cwg_active.html#Issue%20Status https://github.com/llvm/llvm-project/pull/97200 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [NFC] [Clang] Some core issues have changed status from tentatively ready -> ready / review (PR #97200)

2024-07-26 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok updated https://github.com/llvm/llvm-project/pull/97200 >From 0dea95701ca4dfca9b7d0bd889003fc35aa3017e Mon Sep 17 00:00:00 2001 From: Mital Ashok Date: Sun, 30 Jun 2024 10:39:15 +0100 Subject: [PATCH 01/13] [NFC] [Clang] Some core issues have changed status from t

[clang] [Clang] Qualified functions can't decay into pointers (PR #90353)

2024-07-26 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/90353 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Qualified functions can't decay into pointers (PR #90353)

2024-07-26 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll commented: Current CWG713 behavior was introduced sometime after Clang 18, and is not affected by this patch. Current CWG1584 behavior was introduced in Clang 7, and is also not affected by this patch. (https://godbolt.org/z/xYec9rP5x) This PR is large enough already.

[clang] [Clang] Qualified functions can't decay into pointers (PR #90353)

2024-07-26 Thread Vlad Serebrennikov via cfe-commits
@@ -71,6 +76,17 @@ namespace cwg712 { // cwg712: partial #endif } +namespace cwg713 { // cwg713: yes Endilll wrote: Please, run your test through various Clang versions before claiming availability. In this case, this is rejected by 18, but accepted on trunk

[clang] [Clang] Qualified functions can't decay into pointers (PR #90353)

2024-07-26 Thread Vlad Serebrennikov via cfe-commits
@@ -71,6 +76,17 @@ namespace cwg712 { // cwg712: partial #endif } +namespace cwg713 { // cwg713: yes +static_assert(!__is_const(void()const), ""); +static_assert(!__is_const(void()const&), ""); +// cxx98-error@-1 {{reference qualifiers on functions are a C++11 extension}}

[clang] [C++20][Modules] Allow using stdarg.h with header units (PR #100739)

2024-07-26 Thread Dmitry Polukhin via cfe-commits
https://github.com/dmpolukhin created https://github.com/llvm/llvm-project/pull/100739 Summary: Macro like `va_start`/`va_end` marked as builtin functions that makes these identifiers special and it results in redefinition of the identifiers as builtins and it hides macro definitions during pr

[clang] [C++20][Modules] Allow using stdarg.h with header units (PR #100739)

2024-07-26 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-modules Author: Dmitry Polukhin (dmpolukhin) Changes Summary: Macro like `va_start`/`va_end` marked as builtin functions that makes these identifiers special and it results in redefinition of the identifiers as builtins

[clang] [C++20][Modules] Allow using stdarg.h with header units (PR #100739)

2024-07-26 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 38d0b2d174efe05504a18988299b4d78d37999b7 edc7f5c84caefeae197a5884c91ec2194fd3148b --e

[clang] [Clang] Remove `IDNS_Ordinary` flag in `IndirectFieldDecl::IdentifierNamespace` (PR #100525)

2024-07-26 Thread Yanzuo Liu via cfe-commits
zwuis wrote: > I don’t believe the standard supports anonymous structs in C++ Do we need tests about anonymous union? C++ standard supports it. https://github.com/llvm/llvm-project/pull/100525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org ht

  1   2   3   4   >