@@ -1691,10 +1691,7 @@ class ConstraintRefersToContainingTemplateChecker
using inherited::TransformTemplateTypeParmType;
QualType TransformTemplateTypeParmType(TypeLocBuilder &TLB,
TemplateTypeParmTypeLoc TL, bool) {
-assert(TL.g
vegerot wrote:
> CTMark is not compiled with `-Wextra`, so we'd not get any useful data out of
> this patch. What changes does one have to do to enable
> `-Wimplicit-fallthrough` by default (not just for `-Wextra`)?
@nikic done! At
[vegerot/llvm-project/perf/add-implicit-fallthrough-to-wextr
dcci wrote:
This commit seems to have broken well-formed code in thrift:
```
fbcode/thrift/compiler/generate/t_py_generator.cc:881:20: error: declaration of
variable 'module' with deduced type 'const auto &' requires an initializer
881 | for (const auto &module : modules) {
|
dcci wrote:
Code in question:
https://github.com/facebook/fbthrift/blob/ccfcd6743488c26d720bc4ff3348534491078b43/thrift/compiler/generate/t_py_generator.cc#L881
^ I am trying to find out a reduced testcase, but sending this here in case it
rings a bell.
https://github.com/llvm/llvm-project/pul
mizvekov wrote:
I am also seeing breakages which are solved by reverting this change.
The failure occurs when importing modules from within header files:
```
error: expected a module name after 'import'
11 | import std;
```
https://github.com/llvm/llvm-project/pull/90574
___
yronglin wrote:
Thank you for reporting this issue. if we have a reproducer, I'll try to quick
fix it today.
https://github.com/llvm/llvm-project/pull/90574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
mizvekov wrote:
I don't think I'll be able to provide a reproducer today. Regardless, bugs in
modules are in general not easy to reduce.
Unless you think you can fix this soon enough, I think a revert is appropriate
here.
https://github.com/llvm/llvm-project/pull/90574
brad0 wrote:
@AaronBallman
https://github.com/llvm/llvm-project/pull/98713
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
asl wrote:
@ahatanak Will you please take a look into all these issues?
https://github.com/llvm/llvm-project/pull/93906
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yronglin created
https://github.com/llvm/llvm-project/pull/99838
Reverts llvm/llvm-project#90574
>From 3830c428298d0f781e1a82d1885d8903e7169c4d Mon Sep 17 00:00:00 2001
From: yronglin
Date: Mon, 22 Jul 2024 13:16:19 +0800
Subject: [PATCH] =?UTF-8?q?Revert=20"[Clang]=20Implem
https://github.com/yronglin closed
https://github.com/llvm/llvm-project/pull/99838
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: yronglin
Date: 2024-07-22T13:16:51+08:00
New Revision: c91e85278cb87a35924d86463d3c0a379c64e9d1
URL:
https://github.com/llvm/llvm-project/commit/c91e85278cb87a35924d86463d3c0a379c64e9d1
DIFF:
https://github.com/llvm/llvm-project/commit/c91e85278cb87a35924d86463d3c0a379c64e9d1.diff
LOG:
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (yronglin)
Changes
Reverts llvm/llvm-project#90574
---
Patch is 55.48 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/99838.diff
19 Files Affected:
- (modified) clang/docs/ReleaseNotes.r
yronglin wrote:
> I am also seeing breakages which are solved by reverting this change.
>
> The failure occurs when importing modules from within header files:
>
> ```
> error: expected a module name after 'import'
>11 | import std;
> ```
It would be nice to have a reproducer. I can't tell
yronglin wrote:
> This commit seems to have broken well-formed code in thrift:
>
> ```
> fbcode/thrift/compiler/generate/t_py_generator.cc:881:20: error: declaration
> of variable 'module' with deduced type 'const auto &' requires an initializer
> 881 | for (const auto &module : modules) {
mizvekov wrote:
> It would be nice to have a reproducer. I can't tell the root cause from this
> error, so I can't use it to strengthen the current tests.
I intend to provide a reproducer. I just can't do it today. So don't wait on it
as a justification to avoid reverting.
https://github.com/
dcci wrote:
> This is clearer, I think I may have figured out where the problem is.
^ I have a reproducer that's running through `creduce`. It should be ready
tomorrow morning PST time, and I'll add you here. In the meanwhile, do you mind
if I revert this given we understand it breaks several
dcci wrote:
Notice you already reverted, thanks. I'll follow-up with a reproducer once
`creduce` finishes running.
https://github.com/llvm/llvm-project/pull/90574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
yronglin wrote:
Thanks!
https://github.com/llvm/llvm-project/pull/90574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/brad0 updated https://github.com/llvm/llvm-project/pull/74025
>From bfee80b825aeb5c99f23149a2c4317eda10c1cd4 Mon Sep 17 00:00:00 2001
From: Brad Smith
Date: Thu, 30 Nov 2023 20:50:01 -0500
Subject: [PATCH] [Clang] Remove NetBSD/i386 workaround for FP eval method with
older ve
@@ -5337,9 +5337,13 @@ def mmadd4 : Flag<["-"], "mmadd4">,
Group,
def mno_madd4 : Flag<["-"], "mno-madd4">, Group,
HelpText<"Disable the generation of 4-operand madd.s, madd.d and related
instructions.">;
def mmsa : Flag<["-"], "mmsa">, Group,
- HelpText<"Enable MSA ASE (M
https://github.com/Meinersbur approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/93977
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/99840
This seems to be low-hanging fruit: We could remove all calls to
`Context.getCanonicalTemplateArgument()` and gain a better diagnostic/AST.
The non-canonical template arguments shouldn't make a difference when
https://github.com/DanielKristofKiss updated
https://github.com/llvm/llvm-project/pull/86212
>From f2f3356da08d68dab4431f49d0921515560e4927 Mon Sep 17 00:00:00 2001
From: Daniel Kiss
Date: Fri, 8 Mar 2024 15:06:28 +0100
Subject: [PATCH] BTI,GCS,PAC Module flag update.
Module flag is used to in
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Younan Zhang (zyn0217)
Changes
This seems to be low-hanging fruit: We could remove all calls to
`Context.getCanonicalTemplateArgument()` and gain a better diagnostic/AST.
The non-canonical template arguments shouldn't make a difference wh
101 - 125 of 125 matches
Mail list logo
