[clang] [llvm] [RISCV][FMV] Support target_clones (PR #85786)

2024-07-19 Thread Philip Reames via cfe-commits
@@ -2854,10 +2854,121 @@ void CodeGenFunction::EmitMultiVersionResolver( case llvm::Triple::aarch64: EmitAArch64MultiVersionResolver(Resolver, Options); return; + case llvm::Triple::riscv32: + case llvm::Triple::riscv64: +EmitRISCVMultiVersionResolver(Resolver,

[clang] [llvm] [RISCV][FMV] Support target_clones (PR #85786)

2024-07-19 Thread Philip Reames via cfe-commits
@@ -2854,10 +2854,121 @@ void CodeGenFunction::EmitMultiVersionResolver( case llvm::Triple::aarch64: EmitAArch64MultiVersionResolver(Resolver, Options); return; + case llvm::Triple::riscv32: + case llvm::Triple::riscv64: +EmitRISCVMultiVersionResolver(Resolver,

[clang] [llvm] [RISCV][FMV] Support target_clones (PR #85786)

2024-07-19 Thread Philip Reames via cfe-commits
https://github.com/preames requested changes to this pull request. At a high level, I think this is a quite a ways from being ready to land. There's both code style issues (mostly false generality), and missing bits of the user interface on the clang side. I do not think this has any real ser

[clang] [llvm] Remove 3dnow from X86TargetParser. (PR #99352)

2024-07-19 Thread James Y Knight via cfe-commits
https://github.com/jyknight updated https://github.com/llvm/llvm-project/pull/99352 >From 70160e033ac94de92fc2cd6289548094cd893498 Mon Sep 17 00:00:00 2001 From: James Y Knight Date: Wed, 17 Jul 2024 11:40:38 -0400 Subject: [PATCH 1/4] Remove 3dnow from X86TargetParser. This should've been par

[clang] [llvm] Remove 3dnow from X86TargetParser. (PR #99352)

2024-07-19 Thread James Y Knight via cfe-commits
@@ -175,8 +175,6 @@ X86_FEATURE_COMPAT(AVX512BF16, "avx512bf16", 34) X86_FEATURE_COMPAT(AVX512VP2INTERSECT, "avx512vp2intersect", 35) // Below Features has some missings comparing to gcc, it's because gcc has some // not one-to-one mapped in llvm. -X86_FEATURE_

[clang] 22eb290 - [PS4/PS5][Driver][DWARF] Always emit .debug_aranges for SCE tuning (#99629)

2024-07-19 Thread via cfe-commits
Author: Edd Dawson Date: 2024-07-19T17:52:00+01:00 New Revision: 22eb290a9696e2a3fd042096c61e35eca2fcce0c URL: https://github.com/llvm/llvm-project/commit/22eb290a9696e2a3fd042096c61e35eca2fcce0c DIFF: https://github.com/llvm/llvm-project/commit/22eb290a9696e2a3fd042096c61e35eca2fcce0c.diff LO

[clang] [llvm] [PS4/PS5][Driver][DWARF] Always emit .debug_aranges for SCE tuning (PR #99629)

2024-07-19 Thread Edd Dawson via cfe-commits
https://github.com/playstation-edd closed https://github.com/llvm/llvm-project/pull/99629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PS4/PS5][Driver][DWARF] Always emit .debug_aranges for SCE tuning (PR #99629)

2024-07-19 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-ubuntu-fast` running on `sie-linux-worker` while building `clang,llvm` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/144/builds/27

[clang] [lldb] [clang] Split ObjectFilePCHContainerReader from ObjectFilePCHContainerWriter (PR #99599)

2024-07-19 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir approved this pull request. LGTM other than what Jan already mentioned, thanks! https://github.com/llvm/llvm-project/pull/99599 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [llvm] [PS4/PS5][Driver][DWARF] Always emit .debug_aranges for SCE tuning (PR #99629)

2024-07-19 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-win` running on `sie-win-worker` while building `clang,llvm` at step 7 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/46/builds/1956 Here is

[clang] [Clang][Sema] Disallow applying `onwership_returns` to functions that return non-pointers (PR #99564)

2024-07-19 Thread Pavel Skripkin via cfe-commits
https://github.com/pskrgag updated https://github.com/llvm/llvm-project/pull/99564 >From f517162e629535446f5a261b81aa11b3155de6ed Mon Sep 17 00:00:00 2001 From: Pavel Skripkin Date: Thu, 18 Jul 2024 18:48:47 +0300 Subject: [PATCH 1/4] clang/sema: disallow ownership_returns for functions that r

[clang] [Clang][Sema] Disallow applying `onwership_returns` to functions that return non-pointers (PR #99564)

2024-07-19 Thread Pavel Skripkin via cfe-commits
@@ -1481,6 +1481,17 @@ static void handleOwnershipAttr(Sema &S, Decl *D, const ParsedAttr &AL) { break; } + // Allow only pointers to be return type for functions with ownership_takes + // attribute. This matches with current OwnershipAttr::Takes semantics + if (K ==

[clang] [Clang][Sema] Disallow applying `onwership_returns` to functions that return non-pointers (PR #99564)

2024-07-19 Thread Pavel Skripkin via cfe-commits
pskrgag wrote: Fixed test and applied suggestions. Thank you for review! https://github.com/llvm/llvm-project/pull/99564 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Handle constant "pointers" for `__atomic_always_lock_free`/`__atomic_is_lock_free`. (PR #99340)

2024-07-19 Thread James Y Knight via cfe-commits
https://github.com/jyknight updated https://github.com/llvm/llvm-project/pull/99340 >From 2cb327b0377d4196982842455e2aaf4e6a21f667 Mon Sep 17 00:00:00 2001 From: James Y Knight Date: Wed, 17 Jul 2024 10:43:45 -0400 Subject: [PATCH 1/2] Handle constant "pointers" for `__atomic_always_lock_free`

[clang] [compiler-rt] [llvm] [PAC][AArch64] Support init/fini array signing (PR #96478)

2024-07-19 Thread Daniil Kovalev via cfe-commits
https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/96478 >From 5399237a71c0ccd872821034d83ea2c3a04bed3f Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 21 Jun 2024 12:32:51 +0300 Subject: [PATCH 1/4] [PAC][AArch64] Support init/fini array signing If both `-f

[clang-tools-extra] [clang-tidy] Add new check bugprone-tagged-union-member-count (PR #89925)

2024-07-19 Thread via cfe-commits
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= , =?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= Message-ID: In-Reply-To: EugeneZelenko wrote: Please resolve comments that already fixed. https://github.com/llvm/llvm-project/pull/89925 ___ cfe-commits mailing list cfe-co

[clang] Handle constant "pointers" for `__atomic_always_lock_free`/`__atomic_is_lock_free`. (PR #99340)

2024-07-19 Thread James Y Knight via cfe-commits
@@ -124,6 +124,24 @@ _Static_assert(__atomic_always_lock_free(4, &i64), ""); _Static_assert(!__atomic_always_lock_free(8, &i32), ""); _Static_assert(__atomic_always_lock_free(8, &i64), ""); +// Validate use with fake pointers constants. This mechanism is used to allow +// vali

[clang] Handle constant "pointers" for `__atomic_always_lock_free`/`__atomic_is_lock_free`. (PR #99340)

2024-07-19 Thread James Y Knight via cfe-commits
https://github.com/jyknight edited https://github.com/llvm/llvm-project/pull/99340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Handle constant "pointers" for `__atomic_always_lock_free`/`__atomic_is_lock_free`. (PR #99340)

2024-07-19 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a05724a1f84853fc655950c36453f200fba8af75 3e6440c8faf5a15dc9fe8e0bcbe9c45533373c17 --e

[clang] [compiler-rt] [llvm] [PAC][AArch64] Support init/fini array signing (PR #96478)

2024-07-19 Thread Daniil Kovalev via cfe-commits
https://github.com/kovdan01 updated https://github.com/llvm/llvm-project/pull/96478 >From 5399237a71c0ccd872821034d83ea2c3a04bed3f Mon Sep 17 00:00:00 2001 From: Daniil Kovalev Date: Fri, 21 Jun 2024 12:32:51 +0300 Subject: [PATCH 1/4] [PAC][AArch64] Support init/fini array signing If both `-f

[clang] Fix issue https://github.com/llvm/llvm-project/issues/98018. (PR #99672)

2024-07-19 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/99672 None >From 452bc424b7e6d63c50af1ed8f3623ad84e9b091c Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Fri, 19 Jul 2024 10:31:18 -0700 Subject: [PATCH] Fix issue https://github.com/llvm/llvm-project/issue

[clang] Handle constant "pointers" for `__atomic_always_lock_free`/`__atomic_is_lock_free`. (PR #99340)

2024-07-19 Thread James Y Knight via cfe-commits
https://github.com/jyknight updated https://github.com/llvm/llvm-project/pull/99340 >From 2cb327b0377d4196982842455e2aaf4e6a21f667 Mon Sep 17 00:00:00 2001 From: James Y Knight Date: Wed, 17 Jul 2024 10:43:45 -0400 Subject: [PATCH 1/3] Handle constant "pointers" for `__atomic_always_lock_free`

[clang] [llvm] Clang: convert `__m64` intrinsics to unconditionally use SSE2 instead of MMX. (PR #96540)

2024-07-19 Thread James Y Knight via cfe-commits
jyknight wrote: I believe all the comments here are addressed; any more concerns/comments, or is this good to go? https://github.com/llvm/llvm-project/pull/96540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] Fix assertion failure during conversion function overload resolution. (PR #98671)

2024-07-19 Thread Daniel M. Katz via cfe-commits
@@ -1519,7 +1519,8 @@ bool Sema::IsAtLeastAsConstrained(NamedDecl *D1, auto IsExpectedEntity = [](const FunctionDecl *FD) { FunctionDecl::TemplatedKind Kind = FD->getTemplatedKind(); return Kind == FunctionDecl::TK_NonTemplate || - Kind == FunctionDe

[clang] Fix assertion failure during conversion function overload resolution. (PR #98671)

2024-07-19 Thread Daniel M. Katz via cfe-commits
https://github.com/katzdm edited https://github.com/llvm/llvm-project/pull/98671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [msan] Implement support for Arm NEON vst{2,3,4} instructions (PR #99360)

2024-07-19 Thread Thurston Dang via cfe-commits
https://github.com/thurstond closed https://github.com/llvm/llvm-project/pull/99360 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix assertion failure during conversion function overload resolution. (PR #98671)

2024-07-19 Thread Daniel M. Katz via cfe-commits
https://github.com/katzdm deleted https://github.com/llvm/llvm-project/pull/98671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ExprConstant] Handle shift overflow the same way as other kinds of overflow (PR #99579)

2024-07-19 Thread Eli Friedman via cfe-commits
@@ -142,7 +142,7 @@ constexpr int arb(int n) { // expected-note {{declared here}} expected-note {{function parameter 'n' with unknown value cannot be used in a constant expression}} } constexpr long Overflow[(1 << 30) << 2]{}; // expected-warning {{requires 34

[clang] [clang-scan-deps] Ignore import/include directives with missing filenames (PR #99520)

2024-07-19 Thread Argyrios Kyrtzidis via cfe-commits
akyrtzi wrote: This is similar feedback that I gave for https://github.com/llvm/llvm-project/pull/97654, could you test the change with a unit test in `DependencyDirectivesScannerTest.cpp` instead? It's much simpler to setup and execution-wise it's orders of magnitude more lightweight than a

[clang] [Clang][Sema] Add a test for move ctor calling for a base class. NFC (PR #97164)

2024-07-19 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: > Gentle ping. Oh, you should click "re-request review", so it's popup in github review query. Looking. https://github.com/llvm/llvm-project/pull/97164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] [ExprConstant] Handle shift overflow the same way as other kinds of overflow (PR #99579)

2024-07-19 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: Filed #99680 and #99684 for issues caused by custom codepaths for evaluating ICEs. Hopefully we can improve that at some point. https://github.com/llvm/llvm-project/pull/99579 ___ cfe-commits mailing list cfe-commits@lists.llvm.o

[clang] [Clang][Sema] Add a test for move ctor calling for a base class. NFC (PR #97164)

2024-07-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka approved this pull request. LGTM, but probably someone who contribute these components more should take a look. https://github.com/llvm/llvm-project/pull/97164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] Fix issue https://github.com/llvm/llvm-project/issues/98018. (PR #99672)

2024-07-19 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/99672 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix issue https://github.com/llvm/llvm-project/issues/98018. (PR #99672)

2024-07-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Zahira Ammarguellat (zahiraam) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/99672.diff 3 Files Affected: - (modified) clang/lib/Sema/SemaChecking.cpp (+2-1) - (modified) clang/test/Headers/float.c (+2-1) - (modifi

[clang-tools-extra] [clang-tidy] Add new check bugprone-tagged-union-member-count (PR #89925)

2024-07-19 Thread via cfe-commits
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= , =?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= Message-ID: In-Reply-To: @@ -0,0 +1,181 @@ +// RUN: %check_clang_tidy %s bugprone-tagged-union-member-count %t + +enum tags3 { + tags3_1, + tags3_2, + tags3_3, +}; + +enum tags4 { +

[clang] [ExprConstant] Handle shift overflow the same way as other kinds of overflow (PR #99579)

2024-07-19 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic updated https://github.com/llvm/llvm-project/pull/99579 >From 1137011c51285b083cab6c15de670e64337d3de0 Mon Sep 17 00:00:00 2001 From: Eli Friedman Date: Thu, 18 Jul 2024 14:51:13 -0700 Subject: [PATCH 1/4] [ExprConstant] Handle shift overflow the same way as ot

[clang] [ExprConstant] Handle shift overflow the same way as other kinds of overflow (PR #99579)

2024-07-19 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: Added a few more tests; let me know if there are other tests I should be considering. https://github.com/llvm/llvm-project/pull/99579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang-tools-extra] [clang-tidy] Add new check bugprone-tagged-union-member-count (PR #89925)

2024-07-19 Thread via cfe-commits
=?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= , =?utf-8?b?R8OhYm9yIFTDs3RodsOhcmk=?= Message-ID: In-Reply-To: https://github.com/EugeneZelenko edited https://github.com/llvm/llvm-project/pull/89925 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https

[clang] [clang] [C++20] Defaulted operator== doesn't lookup in using-directive properly #97087 (PR #99542)

2024-07-19 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll commented: Thank you for working on this! You should add one or more tests under `clang/test/SemaCXX`. You should also add an entry to `clang/doc/ReleaseNotes.rst`. https://github.com/llvm/llvm-project/pull/99542 ___ cfe-comm

[clang] [AMDGPU] Use the AMDGPUToolChain when targeting C/C++ directly (PR #99687)

2024-07-19 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/99687 Summary: The `getToolChain` pass uses the triple to determine which toolchain to create. Currently the `amdgcn-amd-amdhsa` triple maps to the `ROCmToolChain` which uses things expected to be provided by `ROCm`. Th

[clang] [AMDGPU] Use the AMDGPUToolChain when targeting C/C++ directly (PR #99687)

2024-07-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: The `getToolChain` pass uses the triple to determine which toolchain to create. Currently the `amdgcn-amd-amdhsa` triple maps to the `ROCmToolChain` which uses things

[clang] [llvm] [WebAssembly] Implement f16x8.replace_lane instruction. (PR #99388)

2024-07-19 Thread Heejin Ahn via cfe-commits
https://github.com/aheejin approved this pull request. https://github.com/llvm/llvm-project/pull/99388 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [WebAssembly] Implement f16x8.replace_lane instruction. (PR #99388)

2024-07-19 Thread Heejin Ahn via cfe-commits
@@ -702,6 +702,19 @@ defm "" : ReplaceLane; defm "" : ReplaceLane; defm "" : ReplaceLane; +// For now use an instrinsic for f16x8.replace_lane instead of ReplaceLane above +// since LL generated with half type arguments is not well supported and creates ahee

[clang] [ExprConstant] Handle shift overflow the same way as other kinds of overflow (PR #99579)

2024-07-19 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic updated https://github.com/llvm/llvm-project/pull/99579 >From 1137011c51285b083cab6c15de670e64337d3de0 Mon Sep 17 00:00:00 2001 From: Eli Friedman Date: Thu, 18 Jul 2024 14:51:13 -0700 Subject: [PATCH 1/5] [ExprConstant] Handle shift overflow the same way as ot

[clang] [clang-format] Fix a bug in annotating `*` in `#define`s (PR #99433)

2024-07-19 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/99433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ExprConstant] Handle shift overflow the same way as other kinds of overflow (PR #99579)

2024-07-19 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic edited https://github.com/llvm/llvm-project/pull/99579 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [AMDGPU] Use the AMDGPUToolChain when targeting C/C++ directly (PR #99687)

2024-07-19 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm commented: Needs test. I also would assume you shouldn't have to reinvent language detection code https://github.com/llvm/llvm-project/pull/99687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [AMDGPU] Use the AMDGPUToolChain when targeting C/C++ directly (PR #99687)

2024-07-19 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > Needs test. I also would assume you shouldn't have to reinvent language > detection code There's an existing function for getting the inputs, but it takes the `ToolChain` as input so it makes a circular dependency. The implementation doesn't seem to need _that_ much from the

[clang] [AMDGPU] Use the AMDGPUToolChain when targeting C/C++ directly (PR #99687)

2024-07-19 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Also, apparently there's some driver tests that expect `--target=amdgcn-amd-amdhsa-opencl` as the environment type. Is that the expected way to specify OpenCL? I'm not overly familiar. https://github.com/llvm/llvm-project/pull/99687 __

[clang] Fix assertion failure during conversion function overload resolution. (PR #98671)

2024-07-19 Thread Daniel M. Katz via cfe-commits
@@ -1519,7 +1519,8 @@ bool Sema::IsAtLeastAsConstrained(NamedDecl *D1, auto IsExpectedEntity = [](const FunctionDecl *FD) { FunctionDecl::TemplatedKind Kind = FD->getTemplatedKind(); return Kind == FunctionDecl::TK_NonTemplate || - Kind == FunctionDe

[clang] [llvm] [PowerPC] Add support for -mcpu=pwr11 / -mtune=pwr11 (PR #99511)

2024-07-19 Thread David Tenty via cfe-commits
@@ -0,0 +1,122 @@ +; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py +; ; This test is a copy of mma-acc-spill.ll except that it uses mcpu=pwr11. +; RUN: llc -verify-machineinstrs -mtriple=powerpc64le-unknown-linux-gnu \ +; RUN: -mcpu=pwr11 -ppc-asm-f

[clang] [clang-format] Add BreakBinaryOperations configuration (PR #95013)

2024-07-19 Thread Björn Schäpers via cfe-commits
HazardyKnusperkeks wrote: Fine by me. The build states: Failed Tests (1): Clang-Unit :: Format/./FormatTests/ConfigParseTest/ParsesConfiguration Is this from this change? https://github.com/llvm/llvm-project/pull/95013 ___ cfe-commits mailing list cf

[clang] [AMDGPU] Use the AMDGPUToolChain when targeting C/C++ directly (PR #99687)

2024-07-19 Thread Joseph Huber via cfe-commits
jhuber6 wrote: There's a test that's `.cl` that doesn't pass `-opencl` so probably can't rely on it. https://github.com/llvm/llvm-project/pull/99687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] [llvm] [RISCV][FMV] Support target_clones (PR #85786)

2024-07-19 Thread Philip Reames via cfe-commits
@@ -14266,6 +14277,71 @@ CodeGenFunction::EmitAArch64CpuSupports(ArrayRef FeaturesStrs) { return Result; } +Value *CodeGenFunction::EmitRISCVCpuSupports(ArrayRef FeaturesStrs, + unsigned &MaxGroupIDUsed) { + + const unsigned Feat

[clang] [AMDGPU] Use the AMDGPUToolChain when targeting C/C++ directly (PR #99687)

2024-07-19 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/99687 >From 59901100a2c11d37947938dfb9db5dd1164cbbf5 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 19 Jul 2024 14:07:18 -0500 Subject: [PATCH] [AMDGPU] Use the AMDGPUToolChain when targeting C/C++ directly S

[clang] Add _MM_FROUND_TIES_TO_EVEN to avx512fintrin.h (PR #99691)

2024-07-19 Thread via cfe-commits
https://github.com/hpkfft created https://github.com/llvm/llvm-project/pull/99691 Intrinsics such as `_mm512_add_round_ps` take a rounding mode argument to specify the floating point rounding mode. This, and similar instructions, do NOT round their result to an integer. Thus it is inappropr

[clang] Add _MM_FROUND_TIES_TO_EVEN to avx512fintrin.h (PR #99691)

2024-07-19 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] Add _MM_FROUND_TIES_TO_EVEN to avx512fintrin.h (PR #99691)

2024-07-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-backend-x86 Author: hpkfft.com (hpkfft) Changes Intrinsics such as `_mm512_add_round_ps` take a rounding mode argument to specify the floating point rounding mode. This, and similar instructions, do NOT round their result to

[clang] [AMDGPU] Use the AMDGPUToolChain when targeting C/C++ directly (PR #99687)

2024-07-19 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Okay, so the only user of the toolchain is `Darwin`. So I'd need to somehow rework that logic to make it work. https://github.com/llvm/llvm-project/pull/99687 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[clang] Add _MM_FROUND_TIES_TO_EVEN to avx512fintrin.h (PR #99691)

2024-07-19 Thread via cfe-commits
hpkfft wrote: Note that IEEE Std 754-2019 for floating-point arithmetic specifies two rounding direction attributes to nearest: `roundTiesToEven` and `roundTiesToAway`. Also, it specifies three directed rounding attributes: `roundTowardPositive`, `roundTowardNegative`, and `roundTowardZero`.

[clang] [llvm] [PowerPC] Add support for -mcpu=pwr11 / -mtune=pwr11 (PR #99511)

2024-07-19 Thread via cfe-commits
https://github.com/azhan92 updated https://github.com/llvm/llvm-project/pull/99511 >From 52100e3378c86eddb9a4757f8f3e175804a6dc76 Mon Sep 17 00:00:00 2001 From: Alison Zhang Date: Thu, 18 Jul 2024 10:27:40 -0400 Subject: [PATCH 1/5] Add support for -mcpu=pwr11 / -mtune=pwr11 --- clang/lib/Bas

[clang] Adds a pseudonym to clang"s windows mangler... (PR #97792)

2024-07-19 Thread Reid Kleckner via cfe-commits
https://github.com/rnk commented: Sorry, I made this comment some time ago, but it looks like I never published it https://github.com/llvm/llvm-project/pull/97792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] Adds a pseudonym to clang"s windows mangler... (PR #97792)

2024-07-19 Thread Reid Kleckner via cfe-commits
https://github.com/rnk edited https://github.com/llvm/llvm-project/pull/97792 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Adds a pseudonym to clang"s windows mangler... (PR #97792)

2024-07-19 Thread Reid Kleckner via cfe-commits
@@ -1938,12 +1946,23 @@ void MicrosoftCXXNameMangler::mangleTemplateArgValue(QualType T, mangleNumber(V.getLValueOffset().getQuantity()); } else if (!V.hasLValuePath()) { // FIXME: This can only happen as an extension. Invent a mangling. -break; +

[clang] [llvm] [PowerPC] Add support for -mcpu=pwr11 / -mtune=pwr11 (PR #99511)

2024-07-19 Thread via cfe-commits
https://github.com/azhan92 updated https://github.com/llvm/llvm-project/pull/99511 >From 52100e3378c86eddb9a4757f8f3e175804a6dc76 Mon Sep 17 00:00:00 2001 From: Alison Zhang Date: Thu, 18 Jul 2024 10:27:40 -0400 Subject: [PATCH 1/6] Add support for -mcpu=pwr11 / -mtune=pwr11 --- clang/lib/Bas

[clang] [llvm] [PowerPC] Add support for -mcpu=pwr11 / -mtune=pwr11 (PR #99511)

2024-07-19 Thread via cfe-commits
https://github.com/azhan92 updated https://github.com/llvm/llvm-project/pull/99511 >From 52100e3378c86eddb9a4757f8f3e175804a6dc76 Mon Sep 17 00:00:00 2001 From: Alison Zhang Date: Thu, 18 Jul 2024 10:27:40 -0400 Subject: [PATCH 1/7] Add support for -mcpu=pwr11 / -mtune=pwr11 --- clang/lib/Bas

[clang] [libcxx] [llvm] Reapply "[Clang] Implement resolution for CWG1835 (#92957)" (PR #98547)

2024-07-19 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: I have a [new branch](https://github.com/sdkrystian/llvm-project/tree/reapply-cwg-1835-again) ready where: - We only apply the resolution to CWG1835 in C++23 and later, and - We issue a diagnostic when its application results in a missing template keyword that breaks whatever

[clang] [llvm] [APFloat] Add support for f8E3M4 IEEE 754 type (PR #99698)

2024-07-19 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov created https://github.com/llvm/llvm-project/pull/99698 This PR adds `f8E4M3` type to APFloat. `f8E3M4` type follows IEEE 754 convention ```c f8E3M4 (IEEE 754) - Exponent bias: 3 - Maximum stored exponent value: 6 (binary 110) - Maximum unbiased exponent value: 6

[clang] [llvm] [APFloat] Add support for f8E3M4 IEEE 754 type (PR #99698)

2024-07-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-adt Author: Alexander Pivovarov (apivovarov) Changes This PR adds `f8E4M3` type to APFloat. `f8E3M4` type follows IEEE 754 convention ```c f8E3M4 (IEEE 754) - Exponent bias: 3 - Maximum stored exponent value: 6 (binary 110) - Maximum unbiased exp

[clang] [llvm] [APFloat] Add support for f8E3M4 IEEE 754 type (PR #99698)

2024-07-19 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff a8b90c835291df9a6c152fd32de666192aa0da77 fdcc285cf016d2dfd7883ad6fd100d676ff9ff52 --e

[clang] [llvm] [APFloat] Add support for f8E3M4 IEEE 754 type (PR #99698)

2024-07-19 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov updated https://github.com/llvm/llvm-project/pull/99698 >From 1bddc5cd8414453fd1e3b4f1ef297194f54eaa6c Mon Sep 17 00:00:00 2001 From: Alexander Pivovarov Date: Fri, 19 Jul 2024 19:28:33 + Subject: [PATCH] [APFloat] Add support for f8E3M4 IEEE 754 type --- cla

[clang] [llvm] [APFloat] Add support for f8E3M4 IEEE 754 type (PR #99698)

2024-07-19 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov edited https://github.com/llvm/llvm-project/pull/99698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [WIP][RISCV] Support __builtin_cpu_init and __builtin_cpu_supports (PR #99700)

2024-07-19 Thread Philip Reames via cfe-commits
https://github.com/preames created https://github.com/llvm/llvm-project/pull/99700 This implements the __builtin_cpu_init and __builtin_cpu_supports builtin routines based on the compiler runtime changes in https://github.com/llvm/llvm-project/pull/85790. This is inspired by https://github.co

[clang-tools-extra] . (PR #97766)

2024-07-19 Thread Vitaly Buka via cfe-commits
https://github.com/vitalybuka unassigned https://github.com/llvm/llvm-project/pull/97766 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [WIP][RISCV] Support __builtin_cpu_init and __builtin_cpu_supports (PR #99700)

2024-07-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Philip Reames (preames) Changes This implements the __builtin_cpu_init and __builtin_cpu_supports builtin routines based on the compiler runtime changes in https://github.com/llvm/llvm-project/pull/85790. This is inspired by http

[clang] [llvm] [RISCV][FMV] Support target_clones (PR #85786)

2024-07-19 Thread Philip Reames via cfe-commits
preames wrote: I have posted a cut down version of this which implements __builtin_cpu_supports and __builtin_cpu_init. I posted an early draft to avoid potentially duplicated work. If we're going to get any part of this in for the release branch, we don't have much time. See https://githu

[clang] [llvm] [APFloat] Add support for f8E3M4 IEEE 754 type (PR #99698)

2024-07-19 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov edited https://github.com/llvm/llvm-project/pull/99698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [APFloat] Add support for f8E3M4 IEEE 754 type (PR #99698)

2024-07-19 Thread Alexander Pivovarov via cfe-commits
https://github.com/apivovarov edited https://github.com/llvm/llvm-project/pull/99698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [WIP][RISCV] Support __builtin_cpu_init and __builtin_cpu_supports (PR #99700)

2024-07-19 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 5e8cd29d62a72ed18e7bc782554d7f14eccec0ee ddf2c58a864576586b89cc611e2bea15b8cf18ba --e

[clang] [AMDGPU] Use the AMDGPUToolChain when targeting C/C++ directly (PR #99687)

2024-07-19 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/99687 >From 59901100a2c11d37947938dfb9db5dd1164cbbf5 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 19 Jul 2024 14:07:18 -0500 Subject: [PATCH 1/2] [AMDGPU] Use the AMDGPUToolChain when targeting C/C++ directl

[clang] [AMDGPU] Use the AMDGPUToolChain when targeting C/C++ directly (PR #99687)

2024-07-19 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/99687 >From 59901100a2c11d37947938dfb9db5dd1164cbbf5 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 19 Jul 2024 14:07:18 -0500 Subject: [PATCH 1/2] [AMDGPU] Use the AMDGPUToolChain when targeting C/C++ directl

[clang] [llvm] [NVPTX] Support __usAtomicCAS builtin (PR #99646)

2024-07-19 Thread via cfe-commits
https://github.com/DenisGZM updated https://github.com/llvm/llvm-project/pull/99646 >From 2cc142d85e706a2a4921e831fd78c8e609b70ae2 Mon Sep 17 00:00:00 2001 From: Denis Gerasimov Date: Fri, 19 Jul 2024 15:47:57 +0300 Subject: [PATCH 1/4] [NVPTX] Support __usAtomicCAS builtin --- clang/include/

[clang] [llvm] Reapply "Add source file name for template instantiations in -ftime-trace" (PR #99545)

2024-07-19 Thread Vitaly Buka via cfe-commits
vitalybuka wrote: It introduces another issue: https://lab.llvm.org/buildbot/#/builders/164/builds/1246/steps/14/logs/stdio https://github.com/llvm/llvm-project/pull/99545 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/

[clang] [AMDGPU] Use the AMDGPUToolChain when targeting C/C++ directly (PR #99687)

2024-07-19 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/99687 >From 59901100a2c11d37947938dfb9db5dd1164cbbf5 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Fri, 19 Jul 2024 14:07:18 -0500 Subject: [PATCH 1/3] [AMDGPU] Use the AMDGPUToolChain when targeting C/C++ directl

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-07-19 Thread Pranav Bhandarkar via cfe-commits
@@ -5229,13 +5362,288 @@ static void emitTargetOutlinedFunction( OMPBuilder.emitTargetRegionFunction(EntryInfo, GenerateOutlinedFunction, true, OutlinedFn, OutlinedFnID); } +OpenMPIRBuilder::InsertPointTy OpenMPIRBuilder::emitTargetTask(

[clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [libcxx] [lld] [lldb] [llvm] [BOLT] Match functions with call graph (PR #98125)

2024-07-19 Thread Shaw Young via cfe-commits
https://github.com/shawbyoung edited https://github.com/llvm/llvm-project/pull/98125 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [compiler-rt] [flang] [libc] [libcxx] [lld] [lldb] [llvm] [BOLT] Match functions with call graph (PR #98125)

2024-07-19 Thread Shaw Young via cfe-commits
https://github.com/shawbyoung closed https://github.com/llvm/llvm-project/pull/98125 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [libcxx] [llvm] Reapply "[Clang] Implement resolution for CWG1835 (#92957)" (PR #98547)

2024-07-19 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: > WDYAT? We generally try to avoid issuing more than one error diagnostic for the same problem. Couldn't we instead issue a note `note: maybe missing 'template' keyword prior to dependent template name 'A'` attached to the first error instead? https://github.com/llvm/llvm-pro

[clang] [libcxx] [llvm] Reapply "[Clang] Implement resolution for CWG1835 (#92957)" (PR #98547)

2024-07-19 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: Another option would be to apply the resolution to all modes, but recover and issue a warning instead of an error. How feasible would that be? https://github.com/llvm/llvm-project/pull/98547 ___ cfe-commits mailing list cfe-commits@lis

[clang] [llvm] [NVPTX] Support __usAtomicCAS builtin (PR #99646)

2024-07-19 Thread via cfe-commits
gonzalobg wrote: Have sent you a MR to your branch with one test file :) https://github.com/llvm/llvm-project/pull/99646 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Diagnose use of deprecated template alias (PR #97619)

2024-07-19 Thread via cfe-commits
https://github.com/premanandrao updated https://github.com/llvm/llvm-project/pull/97619 >From e1076942f07b1d2de857688c88de6ff966861650 Mon Sep 17 00:00:00 2001 From: Premanand M Rao Date: Wed, 3 Jul 2024 11:20:42 -0700 Subject: [PATCH 1/4] [clang] Diagnose use of deprecated template alias Issu

[clang] [llvm] Revert "[PS4/PS5][Driver][DWARF] Always emit .debug_aranges for SCE t… (PR #99711)

2024-07-19 Thread Edd Dawson via cfe-commits
https://github.com/playstation-edd created https://github.com/llvm/llvm-project/pull/99711 …uning (#99629)" This reverts commit 22eb290a9696e2a3fd042096c61e35eca2fcce0c. >From 9025e82a8b7a560963160ea2a3b180fdaf3fc1d4 Mon Sep 17 00:00:00 2001 From: Edd Dawson Date: Fri, 19 Jul 2024 22:36:22 +0

[clang] [llvm] Revert "[PS4/PS5][Driver][DWARF] Always emit .debug_aranges for SCE t… (PR #99711)

2024-07-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Edd Dawson (playstation-edd) Changes …uning (#99629)" This reverts commit 22eb290a9696e2a3fd042096c61e35eca2fcce0c. --- Full diff: https://github.com/llvm/llvm-project/pull/99711.diff 8 Files Affected: - (modified) clang/lib/Dri

[clang] 84658fb - Revert "[PS4/PS5][Driver][DWARF] Always emit .debug_aranges for SCE t… (#99711)

2024-07-19 Thread via cfe-commits
Author: Edd Dawson Date: 2024-07-19T22:38:16+01:00 New Revision: 84658fb82b67fc22ecba1560d0cddd09f9104178 URL: https://github.com/llvm/llvm-project/commit/84658fb82b67fc22ecba1560d0cddd09f9104178 DIFF: https://github.com/llvm/llvm-project/commit/84658fb82b67fc22ecba1560d0cddd09f9104178.diff LO

[clang] [llvm] Revert "[PS4/PS5][Driver][DWARF] Always emit .debug_aranges for SCE t… (PR #99711)

2024-07-19 Thread Edd Dawson via cfe-commits
https://github.com/playstation-edd closed https://github.com/llvm/llvm-project/pull/99711 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Diagnose use of deprecated template alias (PR #97619)

2024-07-19 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov approved this pull request. LGTM as well. https://github.com/llvm/llvm-project/pull/97619 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] (PR #99713)

2024-07-19 Thread NagaChaitanya Vellanki via cfe-commits
https://github.com/chaitanyav created https://github.com/llvm/llvm-project/pull/99713 modernize-use-cpp-style-comments check finds C style comments and suggests to use C++ style comments Fixes #24841 @LegalizeAdulthood @PiotrZSL ``` ~/scratch/llvm_test_ground/test1.cpp:1:1: warning:

[clang-tools-extra] [clang-tidy] (PR #99713)

2024-07-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: NagaChaitanya Vellanki (chaitanyav) Changes modernize-use-cpp-style-comments check finds C style comments and suggests to use C++ style comments Fixes #24841 @LegalizeAdulthood @PiotrZSL ``` ~/scratch/llvm_test_grou

[clang-tools-extra] [clang-tidy] (PR #99713)

2024-07-19 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: NagaChaitanya Vellanki (chaitanyav) Changes modernize-use-cpp-style-comments check finds C style comments and suggests to use C++ style comments Fixes #24841 @LegalizeAdulthood @PiotrZSL ``` ~/scratch/llvm_test_ground/test

[clang-tools-extra] [clang-tidy] (PR #99713)

2024-07-19 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 837d606458f014ceed1b5d4504909f32b83362a8 dc9d737e978093505c7de44b1d29f731d837983c --e

<    1   2   3   4   5   >