[clang] dba2e66 - [clang] Inject tokens containing #embed back into token stream (#97274)

2024-07-16 Thread via cfe-commits
Author: Mariya Podchishchaeva Date: 2024-07-16T14:33:29+02:00 New Revision: dba2e66e18cc82863542d2ba2fde52b9024df307 URL: https://github.com/llvm/llvm-project/commit/dba2e66e18cc82863542d2ba2fde52b9024df307 DIFF: https://github.com/llvm/llvm-project/commit/dba2e66e18cc82863542d2ba2fde52b9024df3

[clang] [clang] Inject tokens containing #embed back into token stream (PR #97274)

2024-07-16 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon closed https://github.com/llvm/llvm-project/pull/97274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][NFC] Add some docs for LazyCompoundValue (PR #97407)

2024-07-16 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus updated https://github.com/llvm/llvm-project/pull/97407 From 9fed2b7dc5395f487cb91c10eb076bb87e05e9b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krist=C3=B3f=20Umann?= Date: Tue, 2 Jul 2024 12:58:19 +0200 Subject: [PATCH 1/2] [analyzer][NFC] Add some docs for LazyComp

[clang] [Bounds Safety][NFC] Add `SemaBoundsSafety` class and move existing Sema checks there (PR #98954)

2024-07-16 Thread Dan Liew via cfe-commits
delcypher wrote: > Unfortunately, I think this should be held off until we have a bigger picture > for the future of `Sema`. I'll elaborate below. > > If you take a close look at the existing set of `Sema` parts, it's almost > entirely comprised of other languages or language extensions (from

[clang] [Clang] Initialize AtLeastAsSpecialized to prevent undefined behavior in Sema::isTemplateTemplateParameterAtLeastAsSpecializedAs() (PR #95195)

2024-07-16 Thread via cfe-commits
https://github.com/smanna12 closed https://github.com/llvm/llvm-project/pull/95195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][NFC] Add some docs for LazyCompoundValue (PR #97407)

2024-07-16 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus updated https://github.com/llvm/llvm-project/pull/97407 From 9fed2b7dc5395f487cb91c10eb076bb87e05e9b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krist=C3=B3f=20Umann?= Date: Tue, 2 Jul 2024 12:58:19 +0200 Subject: [PATCH 1/3] [analyzer][NFC] Add some docs for LazyComp

[clang] [analyzer][NFC] Add some docs for LazyCompoundValue (PR #97407)

2024-07-16 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus updated https://github.com/llvm/llvm-project/pull/97407 From 9fed2b7dc5395f487cb91c10eb076bb87e05e9b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krist=C3=B3f=20Umann?= Date: Tue, 2 Jul 2024 12:58:19 +0200 Subject: [PATCH 1/4] [analyzer][NFC] Add some docs for LazyComp

[clang] [Clang] Remove unnecessary copy (PR #97902)

2024-07-16 Thread via cfe-commits
https://github.com/smanna12 updated https://github.com/llvm/llvm-project/pull/97902 >From 1f80c0a172b58ad15d6b1dce02b63ac682bc7dc0 Mon Sep 17 00:00:00 2001 From: "Manna, Soumi" Date: Sat, 6 Jul 2024 09:03:15 -0700 Subject: [PATCH 1/2] [Clang] Remove unnecessary copy Reported by Static Analyzer

[clang] [Clang] Remove unnecessary copy (PR #97902)

2024-07-16 Thread via cfe-commits
@@ -1551,7 +1551,7 @@ ASTNodeImporter::VisitCountAttributedType(const CountAttributedType *T) { Expr *CountExpr = importChecked(Err, T->getCountExpr()); SmallVector CoupledDecls; - for (auto TI : T->dependent_decls()) { + for (const TypeCoupledDeclRefInfo &TI : T->depen

[clang] [Clang] Remove unnecessary copy (PR #97902)

2024-07-16 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/97902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove unnecessary copy (PR #97902)

2024-07-16 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/97902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Coverage][MC/DC] Show uncoverable and unreachable conditions (PR #94137)

2024-07-16 Thread via cfe-commits
Lambdaris wrote: Renamed the test to `mcdc-exclude` and add a test to check `--mcdc-exclude=none` > So the default preserves existing behavior? Yeah, existing behavior is equivalent to `--mcdc-exclude=constant` as default. https://github.com/llvm/llvm-project/pull/94137

[clang] clang: Relax LangOpts checks when lexing quoted numbers during preprocessing (PR #95798)

2024-07-16 Thread via cfe-commits
@@ -2068,7 +2068,8 @@ bool Lexer::LexNumericConstant(Token &Result, const char *CurPtr) { } // If we have a digit separator, continue. - if (C == '\'' && (LangOpts.CPlusPlus14 || LangOpts.C23)) { + if (C == '\'' && + (LangOpts.CPlusPlus14 || LangOpts.C23 || Parsing

[clang-tools-extra] [clang-tidy] Fix modernize-use-std-print/format for fmt (PR #99021)

2024-07-16 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/99021 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Implement dynamic memory allocation handling (PR #70306)

2024-07-16 Thread David Spickett via cfe-commits
DavidSpickett wrote: I know there is UB in there (https://github.com/llvm/llvm-project/issues/94741) so this is not unsurprising. Though so far none of that has been the cause of failures natively. Let's see what Leandro finds. https://github.com/llvm/llvm-project/pull/70306 _

[clang] [Clang] Remove unnecessary copy (PR #97902)

2024-07-16 Thread via cfe-commits
https://github.com/smanna12 updated https://github.com/llvm/llvm-project/pull/97902 >From 1f80c0a172b58ad15d6b1dce02b63ac682bc7dc0 Mon Sep 17 00:00:00 2001 From: "Manna, Soumi" Date: Sat, 6 Jul 2024 09:03:15 -0700 Subject: [PATCH 1/3] [Clang] Remove unnecessary copy Reported by Static Analyzer

[clang] [clang] Extend lifetime analysis to support assignments for pointer-like objects. (PR #99032)

2024-07-16 Thread Haojian Wu via cfe-commits
https://github.com/hokein created https://github.com/llvm/llvm-project/pull/99032 This is a follow-up patch to #96475 to detect dangling assignments for C++ pointer-like objects (classes annotated with the `[[gsl::Pointer]]`). Fixes #63310. Similar to the behavior for built-in pointer types,

[clang] [clang] Extend lifetime analysis to support assignments for pointer-like objects. (PR #99032)

2024-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Haojian Wu (hokein) Changes This is a follow-up patch to #96475 to detect dangling assignments for C++ pointer-like objects (classes annotated with the `[[gsl::Pointer]]`). Fixes #63310. Similar to the behavior for built-in pointer type

[clang] [Clang] Remove unnecessary copy (PR #97902)

2024-07-16 Thread via cfe-commits
https://github.com/smanna12 updated https://github.com/llvm/llvm-project/pull/97902 >From 1f80c0a172b58ad15d6b1dce02b63ac682bc7dc0 Mon Sep 17 00:00:00 2001 From: "Manna, Soumi" Date: Sat, 6 Jul 2024 09:03:15 -0700 Subject: [PATCH 1/4] [Clang] Remove unnecessary copy Reported by Static Analyzer

[clang] [Clang] Remove unnecessary copy (PR #97902)

2024-07-16 Thread via cfe-commits
smanna12 wrote: Thank you, @cor3ntin for reviews! https://github.com/llvm/llvm-project/pull/97902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] The pragma STDC CX_LIMITED_RANGE ON should have precedence. (PR #98520)

2024-07-16 Thread Aaron Ballman via cfe-commits
@@ -344,10 +352,17 @@ class ComplexExprEmitter return QualType(); } + template + FPOptionsOverride getStoredFPFeaturesOrDefault(const T *E, + const CodeGenFunction &CGF) { AaronBallman wrote: `CGF` is u

[clang] 85cedd8 - [clang][Interp] Ignore incomplete records when visiting lambdas

2024-07-16 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-07-16T15:04:32+02:00 New Revision: 85cedd8e59be5eebad6292aee3b053f31afc8977 URL: https://github.com/llvm/llvm-project/commit/85cedd8e59be5eebad6292aee3b053f31afc8977 DIFF: https://github.com/llvm/llvm-project/commit/85cedd8e59be5eebad6292aee3b053f31afc8977.diff LO

[clang] [analyzer][NFC] Add some docs for LazyCompoundValue (PR #97407)

2024-07-16 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus updated https://github.com/llvm/llvm-project/pull/97407 From 9fed2b7dc5395f487cb91c10eb076bb87e05e9b6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Krist=C3=B3f=20Umann?= Date: Tue, 2 Jul 2024 12:58:19 +0200 Subject: [PATCH 1/5] [analyzer][NFC] Add some docs for LazyComp

[clang] [clang][Interp] Implement dynamic memory allocation handling (PR #70306)

2024-07-16 Thread Timm Baeder via cfe-commits
tbaederr wrote: > I know there is UB in there > (https://github.com/llvm/llvm-project/issues/94741) so this is not > unsurprising. Ah, interesting. Didn't know about that issue https://github.com/llvm/llvm-project/pull/70306 ___ cfe-commits mailing

[clang] [Bounds Safety][NFC] Add `SemaBoundsSafety` class and move existing Sema checks there (PR #98954)

2024-07-16 Thread Dan Liew via cfe-commits
delcypher wrote: > "Extension" is definitely quite broad. What I meant are (basically) languages > that are based off C or C++. Would you argue that `-fbounds-safety` fits into > a set of OpenMP, OpenACC, CUDA, HLSL, Objective-C, and Swift? In my opinion it fits in the set because it is a (pr

[clang] [clang] Extend lifetime analysis to support assignments for pointer-like objects. (PR #99032)

2024-07-16 Thread Gábor Horváth via cfe-commits
Xazax-hun wrote: Any reason why it is not enabled by default for clang-19? Are there any known false positives or just precautions? https://github.com/llvm/llvm-project/pull/99032 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang] The pragma STDC CX_LIMITED_RANGE ON should have precedence. (PR #98520)

2024-07-16 Thread Zahira Ammarguellat via cfe-commits
@@ -344,10 +352,17 @@ class ComplexExprEmitter return QualType(); } + template + FPOptionsOverride getStoredFPFeaturesOrDefault(const T *E, + const CodeGenFunction &CGF) { zahiraam wrote: `Expr` doesn't

[clang] [llvm] [RISCV][FMV] Support target_clones (PR #85786)

2024-07-16 Thread Piyou Chen via cfe-commits
https://github.com/BeMg updated https://github.com/llvm/llvm-project/pull/85786 >From 38e5bef5d20d7e81170720eb56354c0392f5c902 Mon Sep 17 00:00:00 2001 From: Piyou Chen Date: Wed, 5 Jun 2024 01:17:03 -0700 Subject: [PATCH 1/5] [RISCV] Add groupid/bitmask for RISC-V extension Base on https://git

[clang] The pragma STDC CX_LIMITED_RANGE ON should have precedence. (PR #98520)

2024-07-16 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/98520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove __is_nullptr (PR #99038)

2024-07-16 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 created https://github.com/llvm/llvm-project/pull/99038 `is_null_pointer` can be implemented very efficiently as `__is_same(__remove_cv(T), decltype(nullptr))`. Since GCC supports both of these builtins as well, libc++ has no interest in using `__is_nullptr` inste

[clang] [Clang] Remove __is_nullptr (PR #99038)

2024-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nikolas Klauser (philnik777) Changes `is_null_pointer` can be implemented very efficiently as `__is_same(__remove_cv(T), decltype(nullptr))`. Since GCC supports both of these builtins as well, libc++ has no interest in using `__is_nullptr

[clang] [clang][Interp] Implement dynamic memory allocation handling (PR #70306)

2024-07-16 Thread Leandro Lupori via cfe-commits
luporl wrote: I have been able to reproduce the issue on ARM hardware and collected the info below. This was with a release build. I'll check if I can get more details with a debug build. ``` Program received signal SIGSEGV, Segmentation fault. memset () at ../sysdeps/arm/memset.S:51 51 .

[libunwind] [RISCV] Allow libunwind to build for rv32e (PR #98855)

2024-07-16 Thread Louis Dionne via cfe-commits
https://github.com/ldionne commented: This seems reasonable to me, but I have basically no knowledge of risvc or the rv32e ABI so I'll let someone else stamp this. https://github.com/llvm/llvm-project/pull/98855 ___ cfe-commits mailing list cfe-commit

[clang] [clang] Diagnose use of deprecated template alias (PR #97619)

2024-07-16 Thread Louis Dionne via cfe-commits
ldionne wrote: @premanandrao There are instructions here: https://libcxx.llvm.org/BuildingLibcxx.html#bootstrapping-build You can also use e.g. `run-buildbot` for this job: https://github.com/llvm/llvm-project/blob/c7961538ff5c73ad03cbf2470e56cdc10cedc83b/libcxx/utils/ci/run-buildbot#L366 You

[clang] [Bounds Safety][NFC] Add `SemaBoundsSafety` class and move existing Sema checks there (PR #98954)

2024-07-16 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > > Unfortunately, I think this should be held off until we have a bigger > > picture for the future of `Sema`. I'll elaborate below. > > If you take a close look at the existing set of `Sema` parts, it's almost > > entirely comprised of other languages or language extensions (fr

[libunwind] [libunwind] fix unwinding from signal handler (PR #92291)

2024-07-16 Thread Louis Dionne via cfe-commits
ldionne wrote: Is it possible to add a test case for this? https://github.com/llvm/llvm-project/pull/92291 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Limit alignment for emitted vectors (PR #98629)

2024-07-16 Thread Phoebe Wang via cfe-commits
@@ -133,6 +133,7 @@ struct TransferrableTargetInfo { unsigned short SuitableAlign; unsigned short NewAlign; unsigned MaxVectorAlign; phoebewang wrote: That makes sense. Passing/returning vector larger than target capacity (e.g. <4 x i64> without AVX) is

[clang] [clang] Limit alignment for emitted vectors (PR #98629)

2024-07-16 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang edited https://github.com/llvm/llvm-project/pull/98629 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Implement NEON vamin/vamax intrinsics (PR #99041)

2024-07-16 Thread David Green via cfe-commits
https://github.com/davemgreen commented: Did you consider emitting `llvm.fmin(llvm.fabs(x), llvm.fabs(y))`? https://github.com/llvm/llvm-project/pull/99041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/l

[clang] [llvm] [AArch64] Implement NEON vamin/vamax intrinsics (PR #99041)

2024-07-16 Thread Momchil Velikov via cfe-commits
momchil-velikov wrote: > Did you consider emitting `llvm.fmin(llvm.fabs(x), llvm.fabs(y))`? Nope. I'll have a look. https://github.com/llvm/llvm-project/pull/99041 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] [clang] Add deprecation warning for `-Ofast` driver option (PR #98736)

2024-07-16 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: @jyknight As the author of the RFC, are you happy with the current state of this PR? https://github.com/llvm/llvm-project/pull/98736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [clang] Fix underlying type of EmbedExpr (PR #99050)

2024-07-16 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon created https://github.com/llvm/llvm-project/pull/99050 This patch makes remaining cases of #embed to emit int type since there is an agreement to do that for C. C++ is being discussed, but in general we don't want to produce different types for C and C++. >From c

[clang] [clang] Fix underlying type of EmbedExpr (PR #99050)

2024-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mariya Podchishchaeva (Fznamznon) Changes This patch makes remaining cases of #embed to emit int type since there is an agreement to do that for C. C++ is being discussed, but in general we don't want to produce different types for C and

[clang] [clang] Fix underlying type of EmbedExpr (PR #99050)

2024-07-16 Thread Mariya Podchishchaeva via cfe-commits
@@ -13,9 +13,9 @@ int ca[] = { }; // CHECK: %arrayinit.element = getelementptr inbounds i32, ptr %notca, i64 1 -// CHECK: store i8 106, ptr %arrayinit.element, align 4 +// CHECK: store i32 106, ptr %arrayinit.element, align 4 Fznamznon wrote: This is actually

[clang] [clang] Add deprecation warning for `-Ofast` driver option (PR #98736)

2024-07-16 Thread James Y Knight via cfe-commits
https://github.com/jyknight approved this pull request. Sounds good enough to me, thank you! https://github.com/llvm/llvm-project/pull/98736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [CMake][Fuchsia] Build libc++ on top libc for baremetal (PR #99009)

2024-07-16 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi approved this pull request. Not a fan of this approach, but, seeing as it’s temporary and only affects our builds, I suppose it’s fine for now. https://github.com/llvm/llvm-project/pull/99009 ___ cfe-commits mailing list cf

[clang] [llvm] [Inliner] Propagate more attributes to params when inlining (PR #91101)

2024-07-16 Thread Nikita Popov via cfe-commits
nikic wrote: I can see the argument for dereferenceable_or_null, but I don't see any way in which range will be useful. https://github.com/llvm/llvm-project/pull/91101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [Clang] Remove unnecessary copy (PR #97902)

2024-07-16 Thread Yeoul Na via cfe-commits
@@ -1551,7 +1551,7 @@ ASTNodeImporter::VisitCountAttributedType(const CountAttributedType *T) { Expr *CountExpr = importChecked(Err, T->getCountExpr()); SmallVector CoupledDecls; - for (auto TI : T->dependent_decls()) { + for (const TypeCoupledDeclRefInfo &TI : T->depen

[clang] [Clang] Remove unnecessary copy (PR #97902)

2024-07-16 Thread Yeoul Na via cfe-commits
https://github.com/rapidsna approved this pull request. Thanks for fixing this issue! I left a minor comment. Other than that, LGTM. https://github.com/llvm/llvm-project/pull/97902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang] [clang] Inject tokens containing #embed back into token stream (PR #97274)

2024-07-16 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: FYI https://github.com/llvm/llvm-project/pull/99050 https://github.com/llvm/llvm-project/pull/97274 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Diagnose use of deprecated template alias (PR #97619)

2024-07-16 Thread Tom Honermann via cfe-commits
@@ -0,0 +1,58 @@ +// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s +// +// This test checks that a deprecated attribute on an alias +// template triggers a warning diagnostic when it is used. + +template +struct NoAttr { + void foo() {} +}; + +// expected-note@+2 5{{'Using

[clang] [clang] Limit alignment for emitted vectors (PR #98629)

2024-07-16 Thread Mariya Podchishchaeva via cfe-commits
https://github.com/Fznamznon updated https://github.com/llvm/llvm-project/pull/98629 >From ba498f559c742e62c13a09cb0b909d57d986e19e Mon Sep 17 00:00:00 2001 From: "Podchishchaeva, Mariya" Date: Fri, 12 Jul 2024 06:13:51 -0700 Subject: [PATCH 1/2] [clang] Limit alignment for emitted vectors The

[clang] [NFC][clang] Replace unchecked dyn_cast with cast (PR #98948)

2024-07-16 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 closed https://github.com/llvm/llvm-project/pull/98948 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9454400 - [NFC][clang] Replace unchecked dyn_cast with cast (#98948)

2024-07-16 Thread via cfe-commits
Author: Mike Rice Date: 2024-07-16T08:05:43-07:00 New Revision: 945440033f50aeaf85fca709d8c2644456b2a034 URL: https://github.com/llvm/llvm-project/commit/945440033f50aeaf85fca709d8c2644456b2a034 DIFF: https://github.com/llvm/llvm-project/commit/945440033f50aeaf85fca709d8c2644456b2a034.diff LOG

[clang] [clang] Limit alignment for emitted vectors (PR #98629)

2024-07-16 Thread Mariya Podchishchaeva via cfe-commits
@@ -133,6 +133,7 @@ struct TransferrableTargetInfo { unsigned short SuitableAlign; unsigned short NewAlign; unsigned MaxVectorAlign; Fznamznon wrote: Ok, I updated the patch to use `MaxVectorAlign` instead. Thanks https://github.com/llvm/llvm-project/pu

[clang] [clang] Add deprecation warning for `-Ofast` driver option (PR #98736)

2024-07-16 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov approved this pull request. https://github.com/llvm/llvm-project/pull/98736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1cd6359 - [clang][ASTReaderStmt] Use helper function 'saveStrToCtx' (NFC)

2024-07-16 Thread Youngsuk Kim via cfe-commits
Author: Youngsuk Kim Date: 2024-07-16T10:06:08-05:00 New Revision: 1cd6359f39ab7fa55f00086c322bc183adb583bc URL: https://github.com/llvm/llvm-project/commit/1cd6359f39ab7fa55f00086c322bc183adb583bc DIFF: https://github.com/llvm/llvm-project/commit/1cd6359f39ab7fa55f00086c322bc183adb583bc.diff

[clang] [clang] Fix underlying type of EmbedExpr (PR #99050)

2024-07-16 Thread via cfe-commits
@@ -13,9 +13,9 @@ int ca[] = { }; // CHECK: %arrayinit.element = getelementptr inbounds i32, ptr %notca, i64 1 -// CHECK: store i8 106, ptr %arrayinit.element, align 4 +// CHECK: store i32 106, ptr %arrayinit.element, align 4 cor3ntin wrote: I was trying to w

[clang] [clang] Fix underlying type of EmbedExpr (PR #99050)

2024-07-16 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/99050 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [mlir] Add basic -mtune support (PR #98517)

2024-07-16 Thread Alexis Perry-Holby via cfe-commits
AlexisPerry wrote: @banach-space If this PR is indeed ready to go, would you mind committing it on my behalf? I don't have commit privileges any more. Thanks so much for all your help! And thanks to all the reviewers on previous versions of this PR as well! https://github.com/llvm/llvm-pro

[clang] Fix assertion failure during conversion function overload resolution. (PR #98671)

2024-07-16 Thread Daniel M. Katz via cfe-commits
https://github.com/katzdm updated https://github.com/llvm/llvm-project/pull/98671 >From 47db72077258ebe086059f116bbf7fb32c184c8d Mon Sep 17 00:00:00 2001 From: Dan Katz Date: Fri, 12 Jul 2024 13:57:33 -0400 Subject: [PATCH 1/2] Fix assertion failure during operator overload resolution. --- c

[clang] Fix assertion failure during conversion function overload resolution. (PR #98671)

2024-07-16 Thread Daniel M. Katz via cfe-commits
@@ -1519,7 +1519,8 @@ bool Sema::IsAtLeastAsConstrained(NamedDecl *D1, auto IsExpectedEntity = [](const FunctionDecl *FD) { FunctionDecl::TemplatedKind Kind = FD->getTemplatedKind(); return Kind == FunctionDecl::TK_NonTemplate || - Kind == FunctionDe

[clang] [Clang] Remove unnecessary copy (PR #97902)

2024-07-16 Thread via cfe-commits
@@ -1551,7 +1551,7 @@ ASTNodeImporter::VisitCountAttributedType(const CountAttributedType *T) { Expr *CountExpr = importChecked(Err, T->getCountExpr()); SmallVector CoupledDecls; - for (auto TI : T->dependent_decls()) { + for (const TypeCoupledDeclRefInfo &TI : T->depen

[clang] [Clang] Remove unnecessary copy (PR #97902)

2024-07-16 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/97902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove unnecessary copy (PR #97902)

2024-07-16 Thread Youngsuk Kim via cfe-commits
@@ -1551,7 +1551,7 @@ ASTNodeImporter::VisitCountAttributedType(const CountAttributedType *T) { Expr *CountExpr = importChecked(Err, T->getCountExpr()); SmallVector CoupledDecls; - for (auto TI : T->dependent_decls()) { + for (const TypeCoupledDeclRefInfo &TI : T->depen

[clang] [Clang] Remove unnecessary copy (PR #97902)

2024-07-16 Thread Youngsuk Kim via cfe-commits
https://github.com/JOE1994 edited https://github.com/llvm/llvm-project/pull/97902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix assertion failure during conversion function overload resolution. (PR #98671)

2024-07-16 Thread via cfe-commits
cor3ntin wrote: I think this looks good, thanks Adding @AaronBallman @mizvekov for additional pairs of eyes https://github.com/llvm/llvm-project/pull/98671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [Clang] Remove __is_nullptr (PR #99038)

2024-07-16 Thread via cfe-commits
cor3ntin wrote: It's probably reasonable to do that, however to be on the safe side, let's merge that after the Clang 19 branch. It will need a release note too, Thanks! https://github.com/llvm/llvm-project/pull/99038 ___ cfe-commits mailing list cf

[clang] [Clang] Remove unnecessary copy (PR #97902)

2024-07-16 Thread via cfe-commits
https://github.com/smanna12 deleted https://github.com/llvm/llvm-project/pull/97902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove FiniteMathOnly and use only NoHonorINFs and NoHonorNANs. (PR #97342)

2024-07-16 Thread Joshua Cranmer via cfe-commits
@@ -174,9 +174,10 @@ static void addVisualCDefines(const LangOptions &Opts, MacroBuilder &Builder) { // transformation unless the transformation is guaranteed to produce a bitwise // identical result." const bool any_imprecise_flags = - Opts.FastMath || Opts.Finite

[clang] [llvm] [Inliner] Propagate more attributes to params when inlining (PR #91101)

2024-07-16 Thread via cfe-commits
goldsteinn wrote: > I can see the argument for dereferenceable_or_null, but I don't see any way > in which range will be useful. Well I'd say if the callsite in the new inlined function gets inlined itself, we now have `range` info on that parameter we can optimize around. Further, if we ever

[clang] [HLSL] Remove hlsl::Resource (PR #98938)

2024-07-16 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. Yea, this can go. I think I had intended to use this as the underlying type for the resource descriptor heap for dynamic resources. We can figure out a better approach for that when we get there. https://github.com/llvm/llvm-project/pul

[clang] [Bounds Safety][NFC] Add `SemaBoundsSafety` class and move existing Sema checks there (PR #98954)

2024-07-16 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: The separations we've been making so far in `Sema` have been at a higher level of granularity than this proposal. Vlad was calling it "language extensions" but perhaps a different way to phrase it would be "unique language dialects". e.g., Objective-C is its own language, b

[clang] f1d3fe7 - Add basic -mtune support (#98517)

2024-07-16 Thread via cfe-commits
Author: Alexis Perry-Holby Date: 2024-07-16T16:48:24+01:00 New Revision: f1d3fe7aae7867b5de96b84d6d26b5c9f02f209a URL: https://github.com/llvm/llvm-project/commit/f1d3fe7aae7867b5de96b84d6d26b5c9f02f209a DIFF: https://github.com/llvm/llvm-project/commit/f1d3fe7aae7867b5de96b84d6d26b5c9f02f209a.

[clang] [flang] [mlir] Add basic -mtune support (PR #98517)

2024-07-16 Thread Andrzej Warzyński via cfe-commits
https://github.com/banach-space closed https://github.com/llvm/llvm-project/pull/98517 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][NFC] Move more functions from `Sema` to `SemaObjC` (PR #97172)

2024-07-16 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: While I think these changes are defensible, I think I would prefer to *not* move all of the blocks logic into SemaObjC, but I'd love to hear if @rjmccall agrees with my rationale and conclusion. Blocks are largely an Objective-C feature, so putting th

[clang] [clang] Add deprecation warning for `-Ofast` driver option (PR #98736)

2024-07-16 Thread Kiran Chandramohan via cfe-commits
kiranchandramohan wrote: Could you add a flang driver test as well? https://github.com/llvm/llvm-project/pull/98736 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove __is_nullptr (PR #99038)

2024-07-16 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: I mostly support the removal but I'd feel more comfortable documenting the extension as deprecated in Clang 18, adding a release note warning users about it going away and what the replacement code would look like, and then remove `__is_nullptr()` in

[clang] [Clang] Remove __is_nullptr (PR #99038)

2024-07-16 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/99038 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add source file name for template instantiations in -ftime-trace (PR #98320)

2024-07-16 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/98320 >From 03cc5fbebaf0c0c737e9304b8b3310ab4908fcaa Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Wed, 10 Jul 2024 13:52:46 + Subject: [PATCH 1/5] Add an option to add source file info to -ftime-trace --- cla

[clang] [llvm] Add source file name for template instantiations in -ftime-trace (PR #98320)

2024-07-16 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/98320 >From 03cc5fbebaf0c0c737e9304b8b3310ab4908fcaa Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Wed, 10 Jul 2024 13:52:46 + Subject: [PATCH 1/6] Add an option to add source file info to -ftime-trace --- cla

[clang] [Clang] Remove __is_nullptr (PR #99038)

2024-07-16 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: > I mostly support the removal but I'd feel more comfortable documenting the > extension as deprecated in Clang 19, adding a release note warning users > about it going away and what the replacement code would look like, and then > remove `__is_nullptr()` in Clang 20. (edited

[clang] [llvm] Add source file name for template instantiations in -ftime-trace (PR #98320)

2024-07-16 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/98320 >From 03cc5fbebaf0c0c737e9304b8b3310ab4908fcaa Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Wed, 10 Jul 2024 13:52:46 + Subject: [PATCH 1/6] Add an option to add source file info to -ftime-trace --- cla

[clang] [llvm] Add source file name for template instantiations in -ftime-trace (PR #98320)

2024-07-16 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 24d5c54cf52d38e63d365275f913285908aa9c9a 7032c5c7bf8f65eb4792bf9e5fdc5ba9b762c846 --e

[clang] [clang] Fix underlying type of EmbedExpr (PR #99050)

2024-07-16 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Changes LGTM but I agree with @cor3ntin that we should add the test case from https://github.com/llvm/llvm-project/pull/97274#issuecomment-2230410564 explicitly. Some other tests to consider adding at the same time: ``` static_assert(_Generic( #embed _

[clang] [llvm] Add source file name for template instantiations in -ftime-trace (PR #98320)

2024-07-16 Thread Utkarsh Saxena via cfe-commits
@@ -3430,6 +3430,7 @@ Sema::InstantiateClass(SourceLocation PointOfInstantiation, llvm::raw_string_ostream OS(Name); Instantiation->getNameForDiagnostic(OS, getPrintingPolicy(), /*Qualified=*/true); +OS << ", file:" << Source

[clang] [llvm] Remove support for 3DNow!, both intrinsics and builtins. (PR #96246)

2024-07-16 Thread James Y Knight via cfe-commits
https://github.com/jyknight closed https://github.com/llvm/llvm-project/pull/96246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix assertion failure during conversion function overload resolution. (PR #98671)

2024-07-16 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/98671 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Remove Linux path names in ROCm search paths on Windows (PR #97668)

2024-07-16 Thread David Salinas via cfe-commits
https://github.com/david-salinas updated https://github.com/llvm/llvm-project/pull/97668 >From 803e3939a726bed2f1c43a3199850d580251c6d2 Mon Sep 17 00:00:00 2001 From: David Salinas Date: Thu, 4 Jul 2024 03:32:13 + Subject: [PATCH] Remove Linux path names in ROCm search paths on Windows

[clang] [analyzer][NFC] Add some docs for LazyCompoundValue (PR #97407)

2024-07-16 Thread Kristóf Umann via cfe-commits
Szelethus wrote: I'd also love to see some docs for `Loc` and `NonLoc`, because I recall some angry looks from years ago when I touched those on their own, but I can barely recall them :( As well as some docs for the various `ProgramState::getSVal` methods... https://github.com/llvm/llvm-proj

[clang-tools-extra] Add support for std::rotate(_copy) and inplace_merge to modernize-use-ranges (PR #99057)

2024-07-16 Thread Nathan James via cfe-commits
https://github.com/njames93 created https://github.com/llvm/llvm-project/pull/99057 These algorithms take 3 iterators for the range and we are only interested in the first and last iterator argument. The ranges versions of these take a range and an iterator(defined to be inside the range) so t

[clang-tools-extra] Add support for std::rotate(_copy) and inplace_merge to modernize-use-ranges (PR #99057)

2024-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Nathan James (njames93) Changes These algorithms take 3 iterators for the range and we are only interested in the first and last iterator argument. The ranges versions of these take a range and an iterator(defined to be inside

[clang-tools-extra] Add support for std::rotate(_copy) and inplace_merge to modernize-use-ranges (PR #99057)

2024-07-16 Thread Nathan James via cfe-commits
https://github.com/njames93 updated https://github.com/llvm/llvm-project/pull/99057 >From 5b5b5ff47fd077eb9b6e306f9fab1e356432ddbe Mon Sep 17 00:00:00 2001 From: Nathan James Date: Tue, 16 Jul 2024 17:28:01 +0100 Subject: [PATCH] Add support for std::rotate(_copy) and inplace_merge to moderniz

[clang] [libcxx] [llvm] Reapply "[Clang] Implement resolution for CWG1835 (#92957)" (PR #98547)

2024-07-16 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @cor3ntin Well, if the alternative is not implementing the resolution at all I'll look into the feasibility of identifying missing `template` keywords in the non-type template parameter case. If I can get that working, I think it's pretty safe to reland this patch. Also, I r

[clang] 99153c8 - [CMake][Fuchsia] Build libc++ on top libc for baremetal (#99009)

2024-07-16 Thread via cfe-commits
Author: Petr Hosek Date: 2024-07-16T09:33:33-07:00 New Revision: 99153c84dc321a7493dd4c5888973f525bf9f65e URL: https://github.com/llvm/llvm-project/commit/99153c84dc321a7493dd4c5888973f525bf9f65e DIFF: https://github.com/llvm/llvm-project/commit/99153c84dc321a7493dd4c5888973f525bf9f65e.diff LO

[clang] [CMake][Fuchsia] Build libc++ on top libc for baremetal (PR #99009)

2024-07-16 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek closed https://github.com/llvm/llvm-project/pull/99009 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-16 Thread David Truby via cfe-commits
https://github.com/DavidTruby created https://github.com/llvm/llvm-project/pull/99058 This patch allows the -rtlib flag with flang-new to select between the libgcc_s and compiler-rt runtimes. The behaviour is identical to the same flag with clang. >From 66e13f92a0680742b552fabde25df7752f8510c9

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-16 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-flang-driver Author: David Truby (DavidTruby) Changes This patch allows the -rtlib flag with flang-new to select between the libgcc_s and compiler-rt runtimes. The behaviour is identical to the same flag with clang. --- Full

[clang] [flang] [flang] Add -rtlib flag (PR #99058)

2024-07-16 Thread Tom Eccles via cfe-commits
https://github.com/tblah approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/99058 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add deprecation warning for `-Ofast` driver option (PR #98736)

2024-07-16 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > Could you add a flang driver test as well? I have troubles building Flang on my machine to test the change, so I'd prefer this be done in a separate PR by someone who knows how to do this. Is this fine by you? https://github.com/llvm/llvm-project/pull/98736 __

<    1   2   3   4   5   >