[clang] [NFC][Clang] Move set functions out BranchProtectionInfo. (PR #98451)

2024-07-11 Thread Daniel Kiss via cfe-commits
@@ -413,6 +414,12 @@ class TargetCodeGenInfo { return nullptr; } + void setFnAttributes(const TargetInfo::BranchProtectionInfo &BPI, DanielKristofKiss wrote: agree, added. https://github.com/llvm/llvm-project/pull/98451 ___

[clang] [NFC][Clang] Move set functions out BranchProtectionInfo. (PR #98451)

2024-07-11 Thread Daniel Kiss via cfe-commits
@@ -133,7 +133,7 @@ class AArch64TargetCodeGenInfo : public TargetCodeGenInfo { } } auto *Fn = cast(GV); -BPI.setFnAttributes(*Fn); +CGM.getTargetCodeGenInfo().setFnAttributes(BPI, *Fn); DanielKristofKiss wrote: oh right. https://github.

[clang] [clang] Lower _BitInt(129+) to a different type in LLVM IR (PR #91364)

2024-07-11 Thread Mariya Podchishchaeva via cfe-commits
@@ -107,17 +107,52 @@ llvm::Type *CodeGenTypes::ConvertTypeForMem(QualType T, bool ForBitField) { return llvm::IntegerType::get(FixedVT->getContext(), BytePadded); } - // If this is a bool type, or a bit-precise integer type in a bitfield - // representation, map this

[clang] [Clang] Warn on backslash-newline-EOF (PR #97585)

2024-07-11 Thread Mital Ashok via cfe-commits
@@ -3165,7 +3165,17 @@ bool Lexer::LexEndOfFile(Token &Result, const char *CurPtr) { // C99 5.1.1.2p2: If the file is non-empty and didn't end in a newline, issue // a pedwarn. - if (CurPtr != BufferStart && (CurPtr[-1] != '\n' && CurPtr[-1] != '\r')) { + if (CurPtr !=

[clang] [Clang] Correctly recognize unexpanded packs in lambda template params (PR #98496)

2024-07-11 Thread via cfe-commits
cor3ntin wrote: > Thanks. Actually we're missing this flag many times elsewhere in > TransformLambdaExpr(). (See my patch #86265, let me try to revive that these > days before 19 is cut) I was not aware of that PR, thanks (The general direction of it looks correct to me.) Ah, lambdas, the gi

[clang] 0431c61 - [Clang] Correctly recognize unexpanded packs in lambda template params (#98496)

2024-07-11 Thread via cfe-commits
Author: cor3ntin Date: 2024-07-11T17:58:15+02:00 New Revision: 0431c61f6b80b4ba34e36e7763c58edafcbbf1a9 URL: https://github.com/llvm/llvm-project/commit/0431c61f6b80b4ba34e36e7763c58edafcbbf1a9 DIFF: https://github.com/llvm/llvm-project/commit/0431c61f6b80b4ba34e36e7763c58edafcbbf1a9.diff LOG:

[clang] [Clang] Correctly recognize unexpanded packs in lambda template params (PR #98496)

2024-07-11 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/98496 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement function pointer type discrimination (PR #96992)

2024-07-11 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak edited https://github.com/llvm/llvm-project/pull/96992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Warn on backslash-newline-EOF (PR #97585)

2024-07-11 Thread Aaron Ballman via cfe-commits
@@ -3165,7 +3165,17 @@ bool Lexer::LexEndOfFile(Token &Result, const char *CurPtr) { // C99 5.1.1.2p2: If the file is non-empty and didn't end in a newline, issue // a pedwarn. - if (CurPtr != BufferStart && (CurPtr[-1] != '\n' && CurPtr[-1] != '\r')) { + if (CurPtr !=

[clang] [arm64e] Implement function pointer type discrimination (PR #96992)

2024-07-11 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak edited https://github.com/llvm/llvm-project/pull/96992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Warn on backslash-newline-EOF (PR #97585)

2024-07-11 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/97585 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [PAC] Implement function pointer type discrimination (PR #96992)

2024-07-11 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak edited https://github.com/llvm/llvm-project/pull/96992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ae18b94 - [PAC] Implement function pointer type discrimination (#96992)

2024-07-11 Thread via cfe-commits
Author: Akira Hatanaka Date: 2024-07-11T09:09:20-07:00 New Revision: ae18b9410297963a379e03b94eae7433ff69a62b URL: https://github.com/llvm/llvm-project/commit/ae18b9410297963a379e03b94eae7433ff69a62b DIFF: https://github.com/llvm/llvm-project/commit/ae18b9410297963a379e03b94eae7433ff69a62b.diff

[clang] [PAC] Implement function pointer type discrimination (PR #96992)

2024-07-11 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak closed https://github.com/llvm/llvm-project/pull/96992 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Warn on backslash-newline-EOF (PR #97585)

2024-07-11 Thread via cfe-commits
@@ -3165,7 +3165,17 @@ bool Lexer::LexEndOfFile(Token &Result, const char *CurPtr) { // C99 5.1.1.2p2: If the file is non-empty and didn't end in a newline, issue // a pedwarn. - if (CurPtr != BufferStart && (CurPtr[-1] != '\n' && CurPtr[-1] != '\r')) { + if (CurPtr !=

[clang] [clang][OpenMP] Remove compound directives from `checkNestingOfRegions` (PR #98387)

2024-07-11 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/98387 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Finish deleting the le32/le64 targets (PR #98497)

2024-07-11 Thread Derek Schuff via cfe-commits
@@ -842,8 +842,8 @@ class LLVM_LIBRARY_VISIBILITY NaClTargetInfo : public OSTargetInfo { } else if (Triple.getArch() == llvm::Triple::mipsel) { // Handled on mips' setDataLayout. } else { - assert(Triple.getArch() == llvm::Triple::le32); - this->resetDa

[clang] [llvm] Finish deleting the le32/le64 targets (PR #98497)

2024-07-11 Thread Aaron Ballman via cfe-commits
@@ -842,8 +842,8 @@ class LLVM_LIBRARY_VISIBILITY NaClTargetInfo : public OSTargetInfo { } else if (Triple.getArch() == llvm::Triple::mipsel) { // Handled on mips' setDataLayout. } else { - assert(Triple.getArch() == llvm::Triple::le32); - this->resetDa

[clang] [libclang/python] Refactor enum usage (PR #95608)

2024-07-11 Thread Vlad Serebrennikov via cfe-commits
@@ -142,6 +142,7 @@ Clang Python Bindings Potentially Breaking Changes of variant 271. - Renamed ``TypeKind`` variant 162 from ``OBJCCLASS`` to ``OBJCTYPEPARAM``. The previous name was incorrect, it was a duplicate of variant 28. +- Refactored enum usage, switching to the s

[clang] [libclang/python] Refactor enum usage (PR #95608)

2024-07-11 Thread Jannick Kremer via cfe-commits
https://github.com/DeinAlptraum updated https://github.com/llvm/llvm-project/pull/95608 >From 35bfcfbc69ee812c59350440b7b15c5e23ad1307 Mon Sep 17 00:00:00 2001 From: Jannick Kremer Date: Fri, 14 Jun 2024 22:12:09 +0100 Subject: [PATCH 1/6] [libclang/python] Refactor enum usage Use Python's bui

[clang] [libclang/python] Refactor enum usage (PR #95608)

2024-07-11 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll approved this pull request. https://github.com/llvm/llvm-project/pull/95608 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-11 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/98016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface (PR #98489)

2024-07-11 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll commented: I think this should be rebased on top of #95608 once it lands (soon). CC @DeinAlptraum https://github.com/llvm/llvm-project/pull/98489 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang-tools-extra] [libc] Update libc namespace clang-tidy checks (PR #98424)

2024-07-11 Thread Paul Kirth via cfe-commits
ilovepi wrote: Also, as an FYI to reviewers, I'm working on the FixIts for these as a separate patch. https://github.com/llvm/llvm-project/pull/98424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [clang] Do not allow unorderable features in [[gnu::target{,_clones}]] (PR #98426)

2024-07-11 Thread Dan Klishch via cfe-commits
https://github.com/DanShaders updated https://github.com/llvm/llvm-project/pull/98426 >From 6ac4e250788570f4155108ef3baa1fa3532a67fa Mon Sep 17 00:00:00 2001 From: Dan Klishch Date: Wed, 10 Jul 2024 23:39:42 -0400 Subject: [PATCH] [clang] Do not allow unorderable features in [[gnu::target{,_cl

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-11 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: I filed https://github.com/llvm/llvm-project/issues/98504 to track the remaining issue. https://github.com/llvm/llvm-project/pull/98016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [llvm] [mlir] Remove the `x86_mmx` IR type. (PR #98505)

2024-07-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mlir-llvm @llvm/pr-subscribers-clang Author: James Y Knight (jyknight) Changes It is now translated to `<1 x i64>`, which allows the removal of a bunch of special casing. This _incompatibly_ changes the ABI of any LLVM IR function with `x86_mmx` argum

[clang] [clang] Do not allow unorderable features in [[gnu::target{,_clones}]] (PR #98426)

2024-07-11 Thread Dan Klishch via cfe-commits
DanShaders wrote: Rebased on top of main to hopefully pass github CI (no changes otherwise) https://github.com/llvm/llvm-project/pull/98426 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm

[clang] e16882f - fix bug that undefined internal is a warning only for -pedantic-errors (#98016)

2024-07-11 Thread via cfe-commits
Author: Constantin Kronbichler Date: 2024-07-11T12:35:48-04:00 New Revision: e16882fc7416a30d56d5b5a19d549ca7c653e668 URL: https://github.com/llvm/llvm-project/commit/e16882fc7416a30d56d5b5a19d549ca7c653e668 DIFF: https://github.com/llvm/llvm-project/commit/e16882fc7416a30d56d5b5a19d549ca7c653e

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-11 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/98016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-11 Thread via cfe-commits
github-actions[bot] wrote: @ccrownhill Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bui

[clang] [llvm] [mlir] Remove the `x86_mmx` IR type. (PR #98505)

2024-07-11 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 8146aeef41e9a3a272b2d0017c0e94f0e387ae08 4b625fdb92e4a13a3cbb0b20d40d3c81bddb7cc4 --e

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-11 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `llvm-clang-x86_64-sie-ubuntu-fast` running on `sie-linux-worker` while building `clang` at step 6 "test-build-unified-tree-check-all". Full details are available at: https://lab.llvm.org/buildbot/#/builders/144/builds/2080 H

[clang] [WebAssembly] Disable running `wasm-opt` on components (PR #98373)

2024-07-11 Thread Quentin Michaud via cfe-commits
mh4ck-Thales wrote: @alexcrichton sorry I thought that binaryen was under the bytecode alliance and not the webassembly org. I opened the issue here : https://github.com/WebAssembly/binaryen/issues/6728 , and proposed your idea for a solution. https://github.com/llvm/llvm-project/pull/98373 _

[clang] [llvm] [llvm][AArch64] apple-m4 is armv9.2-a (PR #98267)

2024-07-11 Thread Jon Roelofs via cfe-commits
@@ -161,14 +161,10 @@ struct CpuInfo { StringRef Name; // Name, as written for -mcpu. const ArchInfo &Arch; AArch64::ExtensionBitset - DefaultExtensions; // Default extensions for this CPU. These will be - // ORd with the architecture defaults

[clang] Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface (PR #98489)

2024-07-11 Thread Jannick Kremer via cfe-commits
DeinAlptraum wrote: For a quick overview of the changes you'll need to make after #95608 in the Python bindings: - remove `_kind`, `_name_map` and `__repr__()` from the `BinaryOperator` definition - declare all variants of `BinaryOperator` within the class definition, i.e. `Invalid = 0` inste

[clang] [clang][CGRecordLayout] Remove dependency on isZeroSize (PR #96422)

2024-07-11 Thread Michael Buch via cfe-commits
https://github.com/Michael137 updated https://github.com/llvm/llvm-project/pull/96422 >From 07e603f7afc98e5af31962a5b1f44f4e4c079ebb Mon Sep 17 00:00:00 2001 From: Michael Buch Date: Fri, 21 Jun 2024 12:15:07 +0100 Subject: [PATCH 01/15] [clang][CGRecordLayout] Remove dependency on isZeroSize

[clang-tools-extra] [libc] Update libc namespace clang-tidy checks (PR #98088)

2024-07-11 Thread via cfe-commits
https://github.com/Prabhuk closed https://github.com/llvm/llvm-project/pull/98088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Update libc namespace clang-tidy checks (PR #98088)

2024-07-11 Thread via cfe-commits
Prabhuk wrote: New version of this PR is uploaded by Paul Kirth here: https://github.com/llvm/llvm-project/pull/98424 Closing this pull request. https://github.com/llvm/llvm-project/pull/98088 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] [LoongArch][clang] Add support for option `-msimd=` and macro `__loongarch_simd_width`. (PR #97984)

2024-07-11 Thread Jake Egan via cfe-commits
jakeegan wrote: @ylzsx Thank you! https://github.com/llvm/llvm-project/pull/97984 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface (PR #98489)

2024-07-11 Thread Thomas Wucher via cfe-commits
thomaswucher wrote: Thanks for all your reviews and comments, very much appreciated! I will update this PR once https://github.com/llvm/llvm-project/pull/95608 has been merged. https://github.com/llvm/llvm-project/pull/98489 ___ cfe-commits mailing li

[clang] 9f283bf - Revert "fix bug that undefined internal is a warning only for -pedantic-errors (#98016)"

2024-07-11 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2024-07-11T13:07:06-04:00 New Revision: 9f283bfb9e66d57fefeb3a28318ec40081fa9a24 URL: https://github.com/llvm/llvm-project/commit/9f283bfb9e66d57fefeb3a28318ec40081fa9a24 DIFF: https://github.com/llvm/llvm-project/commit/9f283bfb9e66d57fefeb3a28318ec40081fa9a24.diff

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-11 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: I've reverted the changes in 9f283bfb9e66d57fefeb3a28318ec40081fa9a24 because of the bot breakage. Oddly, I am seeing a different failure on Windows locally: ``` FAIL: Clang :: Sema/undefined-internal-basic.c (1 of 1) TEST 'Clang :: Sema/undefined-interna

[clang] [HLSL] Split out resource class data from resource attribute (PR #98419)

2024-07-11 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 edited https://github.com/llvm/llvm-project/pull/98419 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [libc] Update libc namespace clang-tidy checks (PR #98424)

2024-07-11 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/98424 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-11 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Okay, the Windows issue seems to have gone away with a full rebuild, which makes *way* more sense to me. :-) So I think it's just the `llvm-clang-x86_64-sie-ubuntu-fast` issue that needs to be resolved. https://github.com/llvm/llvm-project/pull/98016 ___

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-11 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: I think adding `-std=c11` to the `RUN` line should help; it at least removes the "is a C11 extension" diagnostics. (I guess this builder isn't defaulting to C17 for some reason?) https://github.com/llvm/llvm-project/pull/98016 ___

[clang] 0171e23 - Revert "Revert fix bug that undefined internal is a warning only for -pedantic-errors

2024-07-11 Thread Aaron Ballman via cfe-commits
Author: Constantin Kronbichler Date: 2024-07-11T13:26:24-04:00 New Revision: 0171e23647d58f65c1cddbc22e16fda2bafa6e85 URL: https://github.com/llvm/llvm-project/commit/0171e23647d58f65c1cddbc22e16fda2bafa6e85 DIFF: https://github.com/llvm/llvm-project/commit/0171e23647d58f65c1cddbc22e16fda2bafa6

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-11 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: I've relanded the changes with a fix here in commit 0171e23647d58f65c1cddbc22e16fda2bafa6e85, hopefully that sticks! https://github.com/llvm/llvm-project/pull/98016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] [NFC][Clang] Move set functions out BranchProtectionInfo. (PR #98451)

2024-07-11 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic edited https://github.com/llvm/llvm-project/pull/98451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Move set functions out BranchProtectionInfo. (PR #98451)

2024-07-11 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM with one minor comment https://github.com/llvm/llvm-project/pull/98451 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Move set functions out BranchProtectionInfo. (PR #98451)

2024-07-11 Thread Eli Friedman via cfe-commits
@@ -152,7 +152,7 @@ class ARMTargetCodeGenInfo : public TargetCodeGenInfo { diag::warn_target_unsupported_branch_protection_attribute) << Arch; } else { - BPI.setFnAttributes(*Fn); + setBranchProtectionFnAttributes(BPI, (*Fn

[clang] [HLSL] Split out resource class data from resource attribute (PR #98419)

2024-07-11 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/98419 >From b740aa9da3baf4fbd32b5a2c59d70bf2f224f700 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 10 Jul 2024 17:10:26 -0700 Subject: [PATCH 1/4] split out resource class data from resource attr, add some

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-11 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Yup, that resolved the issue: https://lab.llvm.org/buildbot/#/builders/144/builds/2082 -- not certain why that builder has a different default value for `-std` though. Clang defaults to C17, but that builder seems to be defaulting to C99. https://github.com/llvm/llvm-proje

[clang] [clang] Catch missing format attributes (PR #70024)

2024-07-11 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM, thank you! https://github.com/llvm/llvm-project/pull/70024 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CIR] Build out AST consumer patterns to reach the entry point into CIRGen (PR #91007)

2024-07-11 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,2 @@ +if not config.root.clang_enable_cir: +clang.unsupported = True AaronBallman wrote: It looks like this is causing precommit CI failures: ``` llvm-lit.py: C:\ws\src\llvm\utils\lit\lit\llvm\config.py:57: note: using lit tools: C:\Program Files\

[clang] [llvm] Finish deleting the le32/le64 targets (PR #98497)

2024-07-11 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Precommit CI failure on Windows appears to be unrelated: ``` _bk;t=1720718143606 TEST 'lld :: ELF/basic-sparcv9.s' FAILED _bk;t=1720718143606Exit Code: 1 _bk;t=1720718143606 _bk;t=1720718143606Command Output (stdout): _bk;t=17

[clang] Retrieve BinaryOperator::getOpcode and BinaryOperator::getOpcodeStr via libclang and its python interface (PR #98489)

2024-07-11 Thread via cfe-commits
github-actions[bot] wrote: :warning: Python code formatter, darker found issues in your code. :warning: You can test this locally with the following command: ``bash darker --check --diff -r 8b7263ba3051125ab2bb9df514bdaadaca1b637d...04b1daff1ee00e0f26dc510670c084fec98453ac clang

[clang] [llvm] Build release binaries for multiple targets (PR #98431)

2024-07-11 Thread Tobias Hieta via cfe-commits
tru wrote: Hmm. It's a bit worrying that we can't have the tests running... I wonder what the workflow would be here since we need to verify before we run the binaries. What's the problem with the tests currently? https://github.com/llvm/llvm-project/pull/98431

[clang] [clang] Stub out gcc_struct attribute (PR #71148)

2024-07-11 Thread Dan Klishch via cfe-commits
https://github.com/DanShaders updated https://github.com/llvm/llvm-project/pull/71148 >From 39f27a9093edd1b034f193c721b76e85e790693a Mon Sep 17 00:00:00 2001 From: Dan Klishch Date: Fri, 3 Nov 2023 21:18:06 -0400 Subject: [PATCH] [clang] Stub out gcc_struct attribute This commit implements gcc

[clang] [clang] Lower _BitInt(129+) to a different type in LLVM IR (PR #91364)

2024-07-11 Thread John McCall via cfe-commits
rjmccall wrote: Okay, so x86_64 describes it in byte terms and says they're little-endian, which is consistent with the overall target. Interestingly, it does not guarantee the content of the excess bits. The code-generation in this patch is consistent with that: the extension we do is unnec

[clang] [clang] Stub out gcc_struct attribute (PR #71148)

2024-07-11 Thread Dan Klishch via cfe-commits
DanShaders wrote: Ping @MaskRay Changes in the force-push: - rebased on top of main; - moved `defaultsToMsStruct` to `ASTContext` since it also depends on auxiliary target. https://github.com/llvm/llvm-project/pull/71148 ___ cfe-commits mailing list

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-11 Thread via cfe-commits
dyung wrote: > Yup, that resolved the issue: > https://lab.llvm.org/buildbot/#/builders/144/builds/2082 -- not certain why > that builder has a different default value for `-std` though. Clang defaults > to C17, but that builder seems to be defaulting to C99. This bot targets the PS4 which ha

[clang] [clang][CGRecordLayout] Remove dependency on isZeroSize (PR #96422)

2024-07-11 Thread Eli Friedman via cfe-commits
@@ -310,6 +310,41 @@ bool CodeGen::isEmptyRecord(ASTContext &Context, QualType T, bool AllowArrays, return true; } +bool CodeGen::isEmptyFieldForLayout(const ASTContext &Context, +const FieldDecl *FD) { + if (FD->isZeroLengthBitField(Con

[clang] [HLSL] Split out resource class data from resource attribute (PR #98419)

2024-07-11 Thread Joshua Batista via cfe-commits
@@ -0,0 +1,38 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -x hlsl -ast-dump -o - %s | FileCheck %s + + +// CHECK: -HLSLResourceClassAttr 0x{{[0-9a-f]+}} <> SRV +struct [[hlsl::resource_class(SRV)]] Eg1 { + int i; +}; + +Eg1 e1; + +// CHECK: -CXXRecordDecl 0x{

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-11 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > Yup, that resolved the issue: > > https://lab.llvm.org/buildbot/#/builders/144/builds/2082 -- not certain why > > that builder has a different default value for `-std` though. Clang > > defaults to C17, but that builder seems to be defaulting to C99. > > This bot targe

[clang] [NFC][Clang] Move set functions out BranchProtectionInfo. (PR #98451)

2024-07-11 Thread Daniel Kiss via cfe-commits
https://github.com/DanielKristofKiss updated https://github.com/llvm/llvm-project/pull/98451 >From 2ffaf35f09be03e7374bde3d97ee798b01e7e3d1 Mon Sep 17 00:00:00 2001 From: Daniel Kiss Date: Thu, 11 Jul 2024 10:29:24 +0200 Subject: [PATCH 1/3] [NFC][Clang] Move setfunctions of BranchProtectionInf

[clang] [HLSL] Split out resource class data from resource attribute (PR #98419)

2024-07-11 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/98419 >From b740aa9da3baf4fbd32b5a2c59d70bf2f224f700 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 10 Jul 2024 17:10:26 -0700 Subject: [PATCH 1/5] split out resource class data from resource attr, add some

[clang] [HLSL] Split out resource class data from resource attribute (PR #98419)

2024-07-11 Thread Damyan Pepper via cfe-commits
@@ -12313,6 +12313,7 @@ def err_hlsl_missing_semantic_annotation : Error< def err_hlsl_init_priority_unsupported : Error< "initializer priorities are not supported in HLSL">; +def err_hlsl_unsupported_resource_class : Error<"invalid resource class '%0' used; expected 'SRV',

[clang] [HLSL] Split out resource class data from resource attribute (PR #98419)

2024-07-11 Thread Damyan Pepper via cfe-commits
@@ -0,0 +1,15 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -o - %s -verify + +// expected-error@+1{{'resource_class' attribute takes one argument}} +struct [[hlsl::resource_class()]] Eg1 { + int i; +}; + +Eg1 e1; + +// expected-error@+1{{invalid resource class

[clang] [llvm] [X86][MC] Added support for -msse2avx option in llvm-mc (PR #96860)

2024-07-11 Thread via cfe-commits
https://github.com/JaydeepChauhan14 updated https://github.com/llvm/llvm-project/pull/96860 >From b4a534ad6f811cf0868b7fd1ee641fae8502e171 Mon Sep 17 00:00:00 2001 From: Chauhan Jaydeep Ashwinbhai Date: Thu, 27 Jun 2024 15:17:50 +0800 Subject: [PATCH 01/13] [X86][MC] Added support for -msse2avx

[clang] [llvm] [X86][MC] Added support for -msse2avx option in llvm-mc (PR #96860)

2024-07-11 Thread via cfe-commits
@@ -335,6 +337,31 @@ void X86InstrMappingEmitter::emitND2NonNDTable( printTable(Table, "X86ND2NonNDTable", "GET_X86_ND2NONND_TABLE", OS); } +void X86InstrMappingEmitter::emitSSE2AVXTable( +ArrayRef Insts, raw_ostream &OS) { + std::vector Table; + for (const CodeGenInst

[clang-tools-extra] [clang-tidy] Only expand macros in modernize-use-std-format/print (PR #97911)

2024-07-11 Thread Mike Crowe via cfe-commits
mikecrowe wrote: Unfortunately, walking the format string looking for macros also seems to match a macro that encloses the whole function invocation. This results in the check failing to work on expressions inside Catch2 `REQUIRE` macros for example. My new test case (that currently fails) is:

[clang] [llvm] Clang: don't unnecessarily convert inline-asm operands to x86mmx in IR. (PR #98273)

2024-07-11 Thread James Y Knight via cfe-commits
https://github.com/jyknight updated https://github.com/llvm/llvm-project/pull/98273 >From 546963316017935bfbbc05d7095d645344fbd5f5 Mon Sep 17 00:00:00 2001 From: James Y Knight Date: Wed, 10 Jul 2024 00:49:25 -0400 Subject: [PATCH 1/2] Clang: don't unnecessarily convert inline-asm operands to

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-11 Thread Constantin Kronbichler via cfe-commits
ccrownhill wrote: Thank you very much for fixing that:) https://github.com/llvm/llvm-project/pull/98016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Remove mmx 3dnow (PR #96246)

2024-07-11 Thread James Y Knight via cfe-commits
https://github.com/jyknight edited https://github.com/llvm/llvm-project/pull/96246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [mlir] Add basic -mtune support (PR #98517)

2024-07-11 Thread Alexis Perry-Holby via cfe-commits
https://github.com/AlexisPerry created https://github.com/llvm/llvm-project/pull/98517 Initial implementation for the -mtune flag in Flang. This PR is a clean version of PR #96688, which is a re-land of PR #95043 >From 2e26f0f66f070cd0b684531efc63e63e2e584dfa Mon Sep 17 00:00:00 2001 From: Ale

[clang] [llvm] Remove support for 3DNow!, both intrinsics and builtins. (PR #96246)

2024-07-11 Thread James Y Knight via cfe-commits
https://github.com/jyknight edited https://github.com/llvm/llvm-project/pull/96246 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [mlir] Add basic -mtune support (PR #98517)

2024-07-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-flang-fir-hlfir @llvm/pr-subscribers-clang @llvm/pr-subscribers-flang-driver Author: Alexis Perry-Holby (AlexisPerry) Changes Initial implementation for the -mtune flag in Flang. This PR is a clean version of PR #96688, which is a re-land of PR #95043

[clang] The pragma STDC CX_LIMITED_RANGE ON should have precedence over (PR #98520)

2024-07-11 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/98520 command line -fcomplex-arithmetic. >From da863999000a6b12f2930247de9df3daf0e5a608 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 11 Jul 2024 11:54:13 -0700 Subject: [PATCH] The pragma STDC CX_LIM

[clang] [llvm] Remove support for 3DNow!, both intrinsics and builtins. (PR #96246)

2024-07-11 Thread James Y Knight via cfe-commits
jyknight wrote: I've written down an overall plan into issue #98272. I'm not sure if everything can be finished by the LLVM 19 branch date, but I don't think there's any reason to wait on this CL. I'd like to just go ahead with it. https://github.com/llvm/llvm-project/pull/96246 __

[clang] [flang] [mlir] Add basic -mtune support (PR #98517)

2024-07-11 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 41de50b773c1c146ddafd4d363dab3b492e4485a 2e26f0f66f070cd0b684531efc63e63e2e584dfa --e

[clang] The pragma STDC CX_LIMITED_RANGE ON should have precedence over (PR #98520)

2024-07-11 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/98520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] The pragma STDC CX_LIMITED_RANGE ON should have precedence over (PR #98520)

2024-07-11 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 668ee3f5478c1e1b549923667cf1b8704b1a0bd0 da863999000a6b12f2930247de9df3daf0e5a608 --e

[clang] [clang] Lower _BitInt(129+) to a different type in LLVM IR (PR #91364)

2024-07-11 Thread John McCall via cfe-commits
rjmccall wrote: Given all that, I feel pretty comfortable relying on using LLVM's `i96` stores and so on. I do worry some that we're eventually going to run into a target where the `_BitInt` ABI does not match what LLVM wants to generate for `i96` load/store, but we should be able to generali

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-11 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > Thank you very much for fixing that:) Happy to help, thank you for your contribution! https://github.com/llvm/llvm-project/pull/98016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [NFC][Clang] Move set functions out BranchProtectionInfo. (PR #98451)

2024-07-11 Thread Daniel Kiss via cfe-commits
https://github.com/DanielKristofKiss updated https://github.com/llvm/llvm-project/pull/98451 >From 2ffaf35f09be03e7374bde3d97ee798b01e7e3d1 Mon Sep 17 00:00:00 2001 From: Daniel Kiss Date: Thu, 11 Jul 2024 10:29:24 +0200 Subject: [PATCH 1/4] [NFC][Clang] Move setfunctions of BranchProtectionInf

[clang] The pragma STDC CX_LIMITED_RANGE ON should have precedence over (PR #98520)

2024-07-11 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam updated https://github.com/llvm/llvm-project/pull/98520 >From da863999000a6b12f2930247de9df3daf0e5a608 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Thu, 11 Jul 2024 11:54:13 -0700 Subject: [PATCH 1/2] The pragma STDC CX_LIMITED_RANGE ON should have prece

[clang] [NFC][Clang] Move set functions out BranchProtectionInfo. (PR #98451)

2024-07-11 Thread Daniel Kiss via cfe-commits
https://github.com/DanielKristofKiss updated https://github.com/llvm/llvm-project/pull/98451 >From 2ffaf35f09be03e7374bde3d97ee798b01e7e3d1 Mon Sep 17 00:00:00 2001 From: Daniel Kiss Date: Thu, 11 Jul 2024 10:29:24 +0200 Subject: [PATCH 1/5] [NFC][Clang] Move setfunctions of BranchProtectionInf

[clang] [NFC][Clang] Move set functions out BranchProtectionInfo. (PR #98451)

2024-07-11 Thread Daniel Kiss via cfe-commits
DanielKristofKiss wrote: #83277 needs the `setBranchProtectionFnAttributes` function but that call is from a static function so let's make it static. https://github.com/llvm/llvm-project/pull/98451 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] [NFC][Clang] Move set functions out BranchProtectionInfo. (PR #98451)

2024-07-11 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff bf4167fd1d06ff68da2cbea210a4ccfa045694d3 6c3f68439fd102070f183a77b7d58d49f399b43c --e

[clang] [HLSL] Split out resource class data from resource attribute (PR #98419)

2024-07-11 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/98419 >From b740aa9da3baf4fbd32b5a2c59d70bf2f224f700 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 10 Jul 2024 17:10:26 -0700 Subject: [PATCH 1/6] split out resource class data from resource attr, add some

[clang] The pragma STDC CX_LIMITED_RANGE ON should have precedence. (PR #98520)

2024-07-11 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam edited https://github.com/llvm/llvm-project/pull/98520 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [mlir] Add basic -mtune support (PR #98517)

2024-07-11 Thread Alexis Perry-Holby via cfe-commits
https://github.com/AlexisPerry updated https://github.com/llvm/llvm-project/pull/98517 >From 2e26f0f66f070cd0b684531efc63e63e2e584dfa Mon Sep 17 00:00:00 2001 From: Alexis Perry-Holby Date: Thu, 11 Jul 2024 12:51:39 -0600 Subject: [PATCH 1/2] Add basic -mtune support Initial implementation for

[clang] [clang] Refactor: Move CTAD code from SemaTemplate.cpp to a dedicated file, NFC (PR #98524)

2024-07-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Haojian Wu (hokein) Changes Split out the deduction guide related code from SemaTemplate.cpp to a dedicated file. These code has grown significantly, and moving it to a separate file will improve code organization. --- Patch is 127.44

[clang] [HLSL] Split out resource class data from resource attribute (PR #98419)

2024-07-11 Thread Joshua Batista via cfe-commits
@@ -7,7 +7,7 @@ struct [[hlsl::resource_class()]] Eg1 { Eg1 e1; -// expected-error@+1{{invalid resource class 'gibberish' used; expected 'SRV', 'UAV', 'CBuffer', or 'Sampler'}} +// expected-warning@+1{{ResourceClass attribute argument not supported: gibberish}}

[clang] [HLSL] Split out resource class data from resource attribute (PR #98419)

2024-07-11 Thread Justin Bogner via cfe-commits
@@ -0,0 +1,38 @@ +// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.0-compute -x hlsl -ast-dump -o - %s | FileCheck %s + + +// CHECK: -HLSLResourceClassAttr 0x{{[0-9a-f]+}} <> SRV +struct [[hlsl::resource_class(SRV)]] Eg1 { bogner wrote: Ah, I hadn't noticed the "

[clang] [C2y] Claim partial conformance to WG14 N3244 (PR #98525)

2024-07-11 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,65 @@ +// RUN: %clang_cc1 -std=c2y %s -verify -Wno-gnu-alignof-expression + +/* WG14 N3244: Partial + * Slay Some Earthly Demons I + * + * NB: the committee adopted: + * Annex J Item 21 (including additional change) -- no, we lack explicit documentation + * Annex J

[clang] [llvm] [Clang][Coroutines] Introducing the `[[clang::coro_inplace_task]]` attribute (PR #94693)

2024-07-11 Thread Yuxuan Chen via cfe-commits
https://github.com/yuxuanchen1997 updated https://github.com/llvm/llvm-project/pull/94693 >From 9f6d1cce5e6ba693e9d6bd125e19b3c653ee96dd Mon Sep 17 00:00:00 2001 From: Yuxuan Chen Date: Tue, 4 Jun 2024 23:22:00 -0700 Subject: [PATCH 1/2] [Clang] Introduce [[clang::coro_inplace_task]] --- clan

[clang] [C2y] Claim partial conformance to WG14 N3244 (PR #98525)

2024-07-11 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/98525 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   >