[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-10 Thread Constantin Kronbichler via cfe-commits
https://github.com/ccrownhill updated https://github.com/llvm/llvm-project/pull/98016 >From 5dd2bb12dee26ba93d927ad1cd99fa610f9ace97 Mon Sep 17 00:00:00 2001 From: ccrownhill Date: Mon, 8 Jul 2024 11:42:37 +0100 Subject: [PATCH 1/2] fix bug that undefined internal is a warning only for -pedant

[clang] [C++20][Modules] static data members of template classes should be allowed in header units (PR #98309)

2024-07-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-modules @llvm/pr-subscribers-clang Author: Dmitry Polukhin (dmpolukhin) Changes Summary: These is no sense to report this cases as an error or add `inline` explicitly in this cases. If it is not required in normal headers. Similar to #60079. Test

[clang] [Clang][ARM] Call constructor on BranchTargetInfo. (PR #98307)

2024-07-10 Thread Jonathan Thackray via cfe-commits
jthackray wrote: > Can something be done to prevent this happening accidentally again? +1. Currently, the struct is initialised with: `BranchProtectionInfo() = default;` so it appears this could be improved in future. https://github.com/llvm/llvm-project/pull/98307 _

[clang] Add flag to opt out of wasm-opt (PR #95208)

2024-07-10 Thread Pavel Savara via cfe-commits
pavelsavara wrote: I don't know who needs to hear this, but I got bitten by `wasm-opt` being on my PATH (while using WASI SDK 22). I was trying to compile zlib-ng for WASIp2 and it's CMake platform detection was passing `-O3` to `check_type_size("void *" SIZEOF_DATA_PTR)` It worked on some mac

[clang] [clang] Catch missing format attributes (PR #70024)

2024-07-10 Thread Budimir Aranđelović via cfe-commits
https://github.com/budimirarandjelovicsyrmia updated https://github.com/llvm/llvm-project/pull/70024 From 2abeecc9379df7c87dc32ba458a4dd79c3aabb78 Mon Sep 17 00:00:00 2001 From: budimirarandjelovicsyrmia Date: Fri, 5 Apr 2024 15:20:37 +0200 Subject: [PATCH] [clang] Catch missing format attribut

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-10 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you for working on this! C23 changed the normative wording here somewhat, so I think we should add additional test coverage. Specifically: Moreover, if an identifier declared with internal linkage is used in an expression there shall be exactly

[clang] [clang] fix sema init crash for not checking a ExprResult (PR #98102)

2024-07-10 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/98102 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix sema init crash for not checking a ExprResult (PR #98102)

2024-07-10 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: The changes LGTM, but please add a release note to clang/docs/ReleaseNotes.rst so users know about the fix. https://github.com/llvm/llvm-project/pull/98102 ___ cfe-commits mailing list cfe-commits@lists.llvm.

[clang] [clang] fix sema init crash for not checking a ExprResult (PR #98102)

2024-07-10 Thread Aaron Ballman via cfe-commits
@@ -5576,6 +5576,10 @@ static void TryOrBuildParenListInitialization( ExprResult ER; ER = IS.Perform(S, SubEntity, SubKind, Arg ? MultiExprArg(Arg) : std::nullopt); + + if (ER.isInvalid()) AaronBallman wrote: Ah you are c

[clang] [llvm] AMDGPU: Handle remote/fine-grained memory in atomicrmw fmin/fmax lowering (PR #96759)

2024-07-10 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/96759 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Splitting TaintPropagation checker into reporting and mode… (PR #98157)

2024-07-10 Thread Daniel Krupp via cfe-commits
https://github.com/dkrupp updated https://github.com/llvm/llvm-project/pull/98157 >From 75675417c324a2d1df5e42a8549f6d4bcb779ab4 Mon Sep 17 00:00:00 2001 From: Daniel Krupp Date: Fri, 5 Jul 2024 14:02:00 +0200 Subject: [PATCH 1/2] [analyzer] Splitting TaintPropagation checker into reporting an

[clang] [NFC] Add assertion to ensure FiniteMathOnly is in sync with HonorINFs and HonorNANs. (PR #97342)

2024-07-10 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/97342 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Clang][ARM][AArch64] Alway emit protection attributes for functions. (PR #82819)

2024-07-10 Thread Nikita Popov via cfe-commits
@@ -32,7 +32,9 @@ #include "llvm/ADT/StringRef.h" #include "llvm/ADT/StringSet.h" #include "llvm/Frontend/OpenMP/OMPGridValues.h" +#include "llvm/IR/Attributes.h" #include "llvm/IR/DerivedTypes.h" +#include "llvm/IR/Function.h" nikic wrote: Could you please m

[clang] [analyzer] Splitting TaintPropagation checker into reporting and mode… (PR #98157)

2024-07-10 Thread Daniel Krupp via cfe-commits
https://github.com/dkrupp updated https://github.com/llvm/llvm-project/pull/98157 >From 75675417c324a2d1df5e42a8549f6d4bcb779ab4 Mon Sep 17 00:00:00 2001 From: Daniel Krupp Date: Fri, 5 Jul 2024 14:02:00 +0200 Subject: [PATCH 1/3] [analyzer] Splitting TaintPropagation checker into reporting an

[clang] [NFC] Add assertion to ensure FiniteMathOnly is in sync with HonorINFs and HonorNANs. (PR #97342)

2024-07-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Zahira Ammarguellat (zahiraam) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/97342.diff 6 Files Affected: - (modified) clang/include/clang/Basic/LangOptions.h (+5) - (modified) clang/lib/Driver/ToolChains/Cla

[clang] [analyzer] Splitting TaintPropagation checker into reporting and mode… (PR #98157)

2024-07-10 Thread Daniel Krupp via cfe-commits
https://github.com/dkrupp updated https://github.com/llvm/llvm-project/pull/98157 >From 75675417c324a2d1df5e42a8549f6d4bcb779ab4 Mon Sep 17 00:00:00 2001 From: Daniel Krupp Date: Fri, 5 Jul 2024 14:02:00 +0200 Subject: [PATCH 1/4] [analyzer] Splitting TaintPropagation checker into reporting an

[clang] [analyzer] Splitting TaintPropagation checker into reporting and mode… (PR #98157)

2024-07-10 Thread Daniel Krupp via cfe-commits
dkrupp wrote: Thanks for the review. I updated the patch with your suggestions. -std::unique_pointer changed to std::optional -I fixed documentation related grammatical and refernce errors. https://github.com/llvm/llvm-project/pull/98157 ___ cfe-commit

[clang] [analyzer] Splitting TaintPropagation checker into reporting and mode… (PR #98157)

2024-07-10 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat approved this pull request. LGTM, thanks for the updates. @steakhal Is it OK for you if we merge this? https://github.com/llvm/llvm-project/pull/98157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.l

[clang] [analyzer] Splitting TaintPropagation checker into reporting and mode… (PR #98157)

2024-07-10 Thread Donát Nagy via cfe-commits
NagyDonat wrote: (By the way, this change doesn't have significant user-facing parts, so I don't think that we need to mention it in the release notes.) https://github.com/llvm/llvm-project/pull/98157 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [analyzer] Splitting TaintPropagation checker into reporting and mode… (PR #98157)

2024-07-10 Thread Donát Nagy via cfe-commits
@@ -1046,10 +1044,7 @@ bool GenericTaintChecker::generateReportIfTainted(const Expr *E, StringRef Msg, return false; // Generate diagnostic. NagyDonat wrote: :thinking: Perhaps add an `assert(BT)` here for the sake of paranoia? https://github.com/llvm

[clang] fix bug that undefined internal is a warning only for -pedantic-errors (PR #98016)

2024-07-10 Thread Constantin Kronbichler via cfe-commits
ccrownhill wrote: That sounds good. I will have a look at that. https://github.com/llvm/llvm-project/pull/98016 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add ability to list extensions enabled for a target (PR #98207)

2024-07-10 Thread Michael Maitland via cfe-commits
@@ -116,6 +115,44 @@ void llvm::riscvExtensionsHelp(StringMap DescMap) { "For example, clang -march=rv32i_v1p0\n"; } +void RISCVISAInfo::printEnabledExtensions( +bool IsRV64, std::set &EnabledFeatureNames, +StringMap &DescMap) { + outs() << "Extensions en

[clang] [llvm] [RISCV] Add ability to list extensions enabled for a target (PR #98207)

2024-07-10 Thread Michael Maitland via cfe-commits
@@ -116,6 +115,44 @@ void llvm::riscvExtensionsHelp(StringMap DescMap) { "For example, clang -march=rv32i_v1p0\n"; } +void RISCVISAInfo::printEnabledExtensions( +bool IsRV64, std::set &EnabledFeatureNames, +StringMap &DescMap) { + outs() << "Extensions en

[clang] [llvm] [RISCV] Add ability to list extensions enabled for a target (PR #98207)

2024-07-10 Thread Michael Maitland via cfe-commits
https://github.com/michaelmaitland updated https://github.com/llvm/llvm-project/pull/98207 >From 9db0919439f197408e9cb8314bd407beb18d075b Mon Sep 17 00:00:00 2001 From: Michael Maitland Date: Tue, 9 Jul 2024 10:44:05 -0700 Subject: [PATCH 1/4] [RISCV] Add ability to list extensions enabled for

[clang] [Clang][C++26] Implement "Ordering of constraints involving fold expressions (PR #98160)

2024-07-10 Thread Aaron Ballman via cfe-commits
@@ -143,13 +157,125 @@ struct NormalizedConstraint { return Constraint.get(); } + FoldExpandedConstraint *getFoldExpandedConstraint() const { +assert(isFoldExpanded() && + "getFoldExpandedConstraint called on non-fold-expanded constraint."); +return C

[clang] [Clang][C++26] Implement "Ordering of constraints involving fold expressions (PR #98160)

2024-07-10 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. Changes LGTM but this is complicated enough that it would be nice if @hubert-reinterpretcast could also take a look, because @erichkeane isn't back from leave yet. https://github.com/llvm/llvm-project/pull/98160 __

[clang] [Clang][C++26] Implement "Ordering of constraints involving fold expressions (PR #98160)

2024-07-10 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/98160 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][ARM] Call constructor on BranchTargetInfo. (PR #98307)

2024-07-10 Thread Sergei Barannikov via cfe-commits
s-barannikov wrote: IIRC there is a clang-tidy check that diagnoses uninitialized PODs, but probably making the constructor non-trivial is simpler. https://github.com/llvm/llvm-project/pull/98307 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [Clang][ARM] Call constructor on BranchTargetInfo. (PR #98307)

2024-07-10 Thread Sergei Barannikov via cfe-commits
https://github.com/s-barannikov approved this pull request. https://github.com/llvm/llvm-project/pull/98307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Add assertion to ensure FiniteMathOnly is in sync with HonorINFs and HonorNANs. (PR #97342)

2024-07-10 Thread Aaron Ballman via cfe-commits
@@ -816,6 +816,11 @@ class FPOptions { setAllowFPReassociate(LO.AllowFPReassoc); setNoHonorNaNs(LO.NoHonorNaNs); setNoHonorInfs(LO.NoHonorInfs); +// Ensure that if FiniteMathOnly is enabled, NoHonorNaNs and NoHonorInfs are +// also enabled. This is because

[clang] [Clang][ARM] Call constructor on BranchTargetInfo. (PR #98307)

2024-07-10 Thread Tomas Matheson via cfe-commits
tmatheson-arm wrote: Whatever the solution is, it would be better off done now, as "in future" is likely to get forgotten. https://github.com/llvm/llvm-project/pull/98307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] [Clang][C++26] Implement "Ordering of constraints involving fold expressions (PR #98160)

2024-07-10 Thread via cfe-commits
https://github.com/cor3ntin updated https://github.com/llvm/llvm-project/pull/98160 >From ba2b6ab4fd0aa5a79a849d71f2857256f8fc1c73 Mon Sep 17 00:00:00 2001 From: Corentin Jabot Date: Tue, 9 Jul 2024 16:08:44 +0200 Subject: [PATCH 1/7] [Clang][C++26] Implement "Ordering of constraints involving

[clang] [llvm] [RISCV] Add QingKe "XW" compressed opcode extension (PR #97925)

2024-07-10 Thread via cfe-commits
https://github.com/ArcaneNibble updated https://github.com/llvm/llvm-project/pull/97925 >From e83b666bdd445a265bd12c5c1611566adb0d9914 Mon Sep 17 00:00:00 2001 From: R Date: Sat, 29 Jun 2024 20:51:51 +0100 Subject: [PATCH] [RISCV] Add QingKe "XW" compressed opcode extension This extension cons

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-07-10 Thread Sebastian Kreutzer via cfe-commits
https://github.com/sebastiankreutzer updated https://github.com/llvm/llvm-project/pull/90959 >From 1f0484b73ad0bb9b40e3cd86d8abad4af14e32dc Mon Sep 17 00:00:00 2001 From: Sebastian Kreutzer Date: Thu, 26 Oct 2023 15:13:05 +0200 Subject: [PATCH 1/7] [XRay] Add DSO support for XRay instrumentatio

[clang] [llvm] [RISCV] Add ability to list extensions enabled for a target (PR #98207)

2024-07-10 Thread Michael Maitland via cfe-commits
https://github.com/michaelmaitland updated https://github.com/llvm/llvm-project/pull/98207 >From 9db0919439f197408e9cb8314bd407beb18d075b Mon Sep 17 00:00:00 2001 From: Michael Maitland Date: Tue, 9 Jul 2024 10:44:05 -0700 Subject: [PATCH 1/4] [RISCV] Add ability to list extensions enabled for

[clang] [llvm] [RISCV] Add QingKe "XW" compressed opcode extension (PR #97925)

2024-07-10 Thread via cfe-commits
ArcaneNibble wrote: Updated the newly-added `clang/test/Driver/print-supported-extensions-riscv.c` test (in addition to simply rebasing) (I don't normally run *all* tests because of how long it takes, so I didn't notice this change until it failed in CI) https://github.com/llvm/llvm-project/p

[clang] [C2y] Add documentation to conform to WG14 N3262; NFC (PR #98146)

2024-07-10 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > The pointer values in a specific `va_list` can and often do change when you > call `va_arg`, but I am not aware of any targets where they do not always > point to the same regions. In every ABI I've ever seen, `va_list` contains a > pointer to the stack argument area, and

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-07-10 Thread Sebastian Kreutzer via cfe-commits
@@ -0,0 +1,62 @@ +//===-- xray_init.cpp ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-07-10 Thread Sebastian Kreutzer via cfe-commits
@@ -63,6 +63,10 @@ XRayArgs::XRayArgs(const ToolChain &TC, const ArgList &Args) { << XRayInstrument->getSpelling() << Triple.str(); } + if (Args.hasFlag(options::OPT_fxray_enable_shared, + options::OPT_fno_xray_enable_shared, false)) +XRayEnab

[clang] [clang][CodeGen] Zero init unspecified fields in initializers in C (#97459) (PR #97121)

2024-07-10 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you for working on this! I'll leave the codegen code review to John and Eli, but I would appreciate explicit documentation in `clang/docs/LanguageExtensions.rst` so that we explicitly document this behavior and users (including the Linux kernel)

[clang] clang: Relax LangOpts checks when lexing quoted numbers during preprocessing (PR #95798)

2024-07-10 Thread Aaron Ballman via cfe-commits
@@ -2068,7 +2068,8 @@ bool Lexer::LexNumericConstant(Token &Result, const char *CurPtr) { } // If we have a digit separator, continue. - if (C == '\'' && (LangOpts.CPlusPlus14 || LangOpts.C23)) { + if (C == '\'' && + (LangOpts.CPlusPlus14 || LangOpts.C23 || Parsing

[clang] [NFC] Add assertion to ensure FiniteMathOnly is in sync with HonorINFs and HonorNANs. (PR #97342)

2024-07-10 Thread Zahira Ammarguellat via cfe-commits
@@ -816,6 +816,11 @@ class FPOptions { setAllowFPReassociate(LO.AllowFPReassoc); setNoHonorNaNs(LO.NoHonorNaNs); setNoHonorInfs(LO.NoHonorInfs); +// Ensure that if FiniteMathOnly is enabled, NoHonorNaNs and NoHonorInfs are +// also enabled. This is because

[clang] 0e7590a - [C23] Add *_NORM_MAX macros to (#96643)

2024-07-10 Thread via cfe-commits
Author: Aaron Ballman Date: 2024-07-10T09:49:21-04:00 New Revision: 0e7590a25cd2e49c5849cc7d2facd5810f8900ce URL: https://github.com/llvm/llvm-project/commit/0e7590a25cd2e49c5849cc7d2facd5810f8900ce DIFF: https://github.com/llvm/llvm-project/commit/0e7590a25cd2e49c5849cc7d2facd5810f8900ce.diff

[clang] [C23] Add *_NORM_MAX macros to (PR #96643)

2024-07-10 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/96643 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Add an option to add source file info to -ftime-trace (PR #98320)

2024-07-10 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 created https://github.com/llvm/llvm-project/pull/98320 None >From 03cc5fbebaf0c0c737e9304b8b3310ab4908fcaa Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Wed, 10 Jul 2024 13:52:46 + Subject: [PATCH] Add an option to add source file info to -ftime-trace --- c

[clang] [NFC] Add assertion to ensure FiniteMathOnly is in sync with HonorINFs and HonorNANs. (PR #97342)

2024-07-10 Thread Aaron Ballman via cfe-commits
@@ -816,6 +816,11 @@ class FPOptions { setAllowFPReassociate(LO.AllowFPReassoc); setNoHonorNaNs(LO.NoHonorNaNs); setNoHonorInfs(LO.NoHonorInfs); +// Ensure that if FiniteMathOnly is enabled, NoHonorNaNs and NoHonorInfs are +// also enabled. This is because

[clang] [Clang] Add `__CLANG_GPU_DISABLE_MATH_WRAPPERS` macro for offloading math (PR #98234)

2024-07-10 Thread Yaxun Liu via cfe-commits
@@ -345,4 +349,5 @@ __DEVICE__ float ynf(int __a, float __b) { return __nv_ynf(__a, __b); } #pragma pop_macro("__DEVICE_VOID__") #pragma pop_macro("__FAST_OR_SLOW") +#endif // __CLANG_GPU_DISABLE_MATH_WRAPPERS yxsamliu wrote: some non-libm functions e.g. `__

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-07-10 Thread Sebastian Kreutzer via cfe-commits
https://github.com/sebastiankreutzer updated https://github.com/llvm/llvm-project/pull/90959 >From 5143ef41ac88d88e53ebbf7d404f5a86ccd0a5c1 Mon Sep 17 00:00:00 2001 From: Sebastian Kreutzer Date: Thu, 26 Oct 2023 15:13:05 +0200 Subject: [PATCH 1/7] [XRay] Add DSO support for XRay instrumentatio

[clang] [Clang] Add `__CLANG_GPU_DISABLE_MATH_WRAPPERS` macro for offloading math (PR #98234)

2024-07-10 Thread Joseph Huber via cfe-commits
@@ -345,4 +349,5 @@ __DEVICE__ float ynf(int __a, float __b) { return __nv_ynf(__a, __b); } #pragma pop_macro("__DEVICE_VOID__") #pragma pop_macro("__FAST_OR_SLOW") +#endif // __CLANG_GPU_DISABLE_MATH_WRAPPERS jhuber6 wrote: Hm, good question. I added `powi`

[clang] [Clang][ARM] Call constructor on BranchTargetInfo. (PR #98307)

2024-07-10 Thread Daniel Kiss via cfe-commits
https://github.com/DanielKristofKiss updated https://github.com/llvm/llvm-project/pull/98307 >From 4e10c95c390e519853428f424cd655379d99c61c Mon Sep 17 00:00:00 2001 From: Daniel Kiss Date: Wed, 10 Jul 2024 13:58:52 +0200 Subject: [PATCH 1/2] [Clang][ARM] Call constructor on BranchTargetInfo. O

[clang] [Clang][ARM] Call constructor on BranchTargetInfo. (PR #98307)

2024-07-10 Thread Daniel Kiss via cfe-commits
DanielKristofKiss wrote: Let's initialise everything from both of the constructors (as it was in an early version of the original patches) https://github.com/llvm/llvm-project/pull/98307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] [APINotes] Refactor: remove references to `ObjCContext...` (PR #98201)

2024-07-10 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan closed https://github.com/llvm/llvm-project/pull/98201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 82ee7ae - [APINotes] Refactor: remove references to `ObjCContext...`

2024-07-10 Thread via cfe-commits
Author: Egor Zhdan Date: 2024-07-10T15:07:09+01:00 New Revision: 82ee7ae3c9273dabd9095fd3e84657fd28322d33 URL: https://github.com/llvm/llvm-project/commit/82ee7ae3c9273dabd9095fd3e84657fd28322d33 DIFF: https://github.com/llvm/llvm-project/commit/82ee7ae3c9273dabd9095fd3e84657fd28322d33.diff LO

[clang] Fix --print-libgcc-file-name on Darwin platforms (PR #98325)

2024-07-10 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun created https://github.com/llvm/llvm-project/pull/98325 On Darwin, --print-libgcc-file-name was returning a nonsensical result. It would return the name of the library that would be used by the default toolchain implementation, but that was something that didn't ex

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-07-10 Thread Sebastian Kreutzer via cfe-commits
@@ -471,42 +518,123 @@ uint16_t __xray_register_event_type( } XRayPatchingStatus __xray_patch() XRAY_NEVER_INSTRUMENT { - return controlPatching(true); + XRayPatchingStatus CombinedStatus{SUCCESS}; sebastiankreutzer wrote: After looking at it again, I have

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-07-10 Thread Sebastian Kreutzer via cfe-commits
sebastiankreutzer wrote: Needed to rebase because buildkite was complaining about archived pipelines. https://github.com/llvm/llvm-project/pull/90959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] Fix --print-libgcc-file-name on Darwin platforms (PR #98325)

2024-07-10 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff f50f7a7aa0b897ef91361d7dc159f3262d142bdc bbd66df28f451b79dccf6c879e355e2f555e48cd --

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #96240)

2024-07-10 Thread via cfe-commits
earnol wrote: One more ping as week passed from the previous one. https://github.com/llvm/llvm-project/pull/96240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add ability to list extensions enabled for a target (PR #98207)

2024-07-10 Thread Michael Maitland via cfe-commits
https://github.com/michaelmaitland updated https://github.com/llvm/llvm-project/pull/98207 >From 9db0919439f197408e9cb8314bd407beb18d075b Mon Sep 17 00:00:00 2001 From: Michael Maitland Date: Tue, 9 Jul 2024 10:44:05 -0700 Subject: [PATCH 1/5] [RISCV] Add ability to list extensions enabled for

[clang] [llvm] [RISCV] Add ability to list extensions enabled for a target (PR #98207)

2024-07-10 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw approved this pull request. LGTM. Thank you! https://github.com/llvm/llvm-project/pull/98207 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][Clang] Move functions of BranchProtectionInfo out of line (PR #98329)

2024-07-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Daniel Kiss (DanielKristofKiss) Changes Also let's add const to the setFnAttributes. --- Full diff: https://github.com/llvm/llvm-project/pull/98329.diff 2 Files Affected: - (modified) clang/include/clang/Basic/TargetInfo.h (+2-18) - (m

[clang] [llvm] [Clang][ARM][AArch64] Alway emit protection attributes for functions. (PR #82819)

2024-07-10 Thread Daniel Kiss via cfe-commits
@@ -32,7 +32,9 @@ #include "llvm/ADT/StringRef.h" #include "llvm/ADT/StringSet.h" #include "llvm/Frontend/OpenMP/OMPGridValues.h" +#include "llvm/IR/Attributes.h" #include "llvm/IR/DerivedTypes.h" +#include "llvm/IR/Function.h" DanielKristofKiss wrote: Addres

[clang] [llvm] Assume (PR #97535)

2024-07-10 Thread Krzysztof Parzyszek via cfe-commits
@@ -760,6 +760,9 @@ void clang::getOpenMPCaptureRegions( case OMPD_parallel: CaptureRegions.push_back(OMPD_parallel); break; +case OMPD_assume: + CaptureRegions.push_back(OMPD_unknown); + break; kparzysz wrote: Please don't push O

[clang] [NFC][Clang] Move functions of BranchProtectionInfo out of line (PR #98329)

2024-07-10 Thread Daniel Kiss via cfe-commits
https://github.com/DanielKristofKiss created https://github.com/llvm/llvm-project/pull/98329 Also let's add const to the setFnAttributes. >From b1e113f76b289aa8a7d4459314a0dbffb313cb51 Mon Sep 17 00:00:00 2001 From: Daniel Kiss Date: Wed, 10 Jul 2024 16:23:11 +0200 Subject: [PATCH] [NFC][Clang

[clang] [llvm] Assume (PR #97535)

2024-07-10 Thread Krzysztof Parzyszek via cfe-commits
@@ -760,6 +760,9 @@ void clang::getOpenMPCaptureRegions( case OMPD_parallel: CaptureRegions.push_back(OMPD_parallel); break; +case OMPD_assume: + CaptureRegions.push_back(OMPD_unknown); + break; kparzysz wrote: Also, please add OM

[clang] [NFC][Clang] Move functions of BranchProtectionInfo out of line (PR #98329)

2024-07-10 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 08ce14732d528ab70309f334446d39782f2f07c0 b1e113f76b289aa8a7d4459314a0dbffb313cb51 --

[clang] [Clang][ARM][AArch64] Add branch protection attributes to the defaults. (PR #83277)

2024-07-10 Thread Daniel Kiss via cfe-commits
https://github.com/DanielKristofKiss updated https://github.com/llvm/llvm-project/pull/83277 >From c421b6b9c167e82cedc5db2a67f47d3ba12deba9 Mon Sep 17 00:00:00 2001 From: Daniel Kiss Date: Wed, 28 Feb 2024 15:18:31 +0100 Subject: [PATCH 1/6] Add branch protection attributes to the defaults. Th

[clang] [llvm] Assume (PR #97535)

2024-07-10 Thread Alexey Bataev via cfe-commits
@@ -760,6 +760,9 @@ void clang::getOpenMPCaptureRegions( case OMPD_parallel: CaptureRegions.push_back(OMPD_parallel); break; +case OMPD_assume: + CaptureRegions.push_back(OMPD_unknown); + break; alexey-bataev wrote: Why? We usuall

[clang] Fix --print-libgcc-file-name on Darwin platforms (PR #98325)

2024-07-10 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,55 @@ +// Test the output of -print-libgcc-file-name on Darwin. + +// +// All platforms +// + +// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name \ +// RUN: --target=x86_64-apple-macos \ +// RUN: -resource-dir=%S/Inputs/resource_dir 2>&1 \ +// RUN: | Fi

[clang] Fix --print-libgcc-file-name on Darwin platforms (PR #98325)

2024-07-10 Thread Louis Dionne via cfe-commits
@@ -2271,6 +2271,12 @@ bool Driver::HandleImmediateArgs(const Compilation &C) { if (C.getArgs().hasArg(options::OPT_print_libgcc_file_name)) { ToolChain::RuntimeLibType RLT = TC.GetRuntimeLibType(C.getArgs()); const llvm::Triple Triple(TC.ComputeEffectiveClangTriple(C

[clang] Fix --print-libgcc-file-name on Darwin platforms (PR #98325)

2024-07-10 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,55 @@ +// Test the output of -print-libgcc-file-name on Darwin. + +// +// All platforms +// + +// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name \ +// RUN: --target=x86_64-apple-macos \ +// RUN: -resource-dir=%S/Inputs/resource_dir 2>&1 \ +// RUN: | Fi

[clang] Fix --print-libgcc-file-name on Darwin platforms (PR #98325)

2024-07-10 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,55 @@ +// Test the output of -print-libgcc-file-name on Darwin. + +// +// All platforms +// + +// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name \ +// RUN: --target=x86_64-apple-macos \ +// RUN: -resource-dir=%S/Inputs/resource_dir 2>&1 \ +// RUN: | Fi

[clang] Fix --print-libgcc-file-name on Darwin platforms (PR #98325)

2024-07-10 Thread Louis Dionne via cfe-commits
@@ -223,6 +223,11 @@ class LLVM_LIBRARY_VISIBILITY MachO : public ToolChain { // There aren't any profiling libs for embedded targets currently. } + // Return the full path of the compiler-rt library on a Darwin MachO system. + // Those are under /lib/darwin/<...>(.dyl

[clang] Fix --print-libgcc-file-name on Darwin platforms (PR #98325)

2024-07-10 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,55 @@ +// Test the output of -print-libgcc-file-name on Darwin. + +// +// All platforms +// + +// RUN: %clang -rtlib=compiler-rt -print-libgcc-file-name \ +// RUN: --target=x86_64-apple-macos \ +// RUN: -resource-dir=%S/Inputs/resource_dir 2>&1 \ +// RUN: | Fi

[clang] Fix --print-libgcc-file-name on Darwin platforms (PR #98325)

2024-07-10 Thread Louis Dionne via cfe-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/98325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix --print-libgcc-file-name on Darwin platforms (PR #98325)

2024-07-10 Thread Louis Dionne via cfe-commits
https://github.com/ldionne edited https://github.com/llvm/llvm-project/pull/98325 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][ARM] Call constructor on BranchTargetInfo. (PR #98307)

2024-07-10 Thread Tomas Matheson via cfe-commits
@@ -141,7 +141,7 @@ class ARMTargetCodeGenInfo : public TargetCodeGenInfo { ParsedTargetAttr Attr = CGM.getTarget().parseTargetAttr(TA->getFeaturesStr()); if (!Attr.BranchProtection.empty()) { -TargetInfo::BranchProtectionInfo BPI; +TargetI

[clang] [Clang][ARM] Call constructor on BranchTargetInfo. (PR #98307)

2024-07-10 Thread Tomas Matheson via cfe-commits
@@ -1434,7 +1434,14 @@ class TargetInfo : public TransferrableTargetInfo, } public: -BranchProtectionInfo() = default; +BranchProtectionInfo() { + SignReturnAddr = LangOptions::SignReturnAddressScopeKind::None; + SignKey = LangOptions::SignReturnAddress

[clang] [clang] Lower _BitInt(129+) to a different type in LLVM IR (PR #91364)

2024-07-10 Thread Momchil Velikov via cfe-commits
@@ -118,6 +124,37 @@ llvm::Type *CodeGenTypes::ConvertTypeForMem(QualType T, bool ForBitField) { return R; } +bool CodeGenTypes::LLVMTypeLayoutMatchesAST(QualType ASTTy, +llvm::Type *LLVMTy) { + CharUnits ASTSize = Context.getTyp

[clang] [Clang][ARM][AArch64] Add branch protection attributes to the defaults. (PR #83277)

2024-07-10 Thread Daniel Kiss via cfe-commits
https://github.com/DanielKristofKiss updated https://github.com/llvm/llvm-project/pull/83277 >From 0c3118713387246dc1c503f3792ba5af82e6b5eb Mon Sep 17 00:00:00 2001 From: Daniel Kiss Date: Wed, 28 Feb 2024 15:18:31 +0100 Subject: [PATCH 1/6] Add branch protection attributes to the defaults. Th

[clang] [Clang][ARM][AArch64] Add branch protection attributes to the defaults. (PR #83277)

2024-07-10 Thread Daniel Kiss via cfe-commits
DanielKristofKiss wrote: Sorry for the force push, need to be rebased. NFC since last review round. https://github.com/llvm/llvm-project/pull/83277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [llvm] Assume (PR #97535)

2024-07-10 Thread Krzysztof Parzyszek via cfe-commits
@@ -760,6 +760,9 @@ void clang::getOpenMPCaptureRegions( case OMPD_parallel: CaptureRegions.push_back(OMPD_parallel); break; +case OMPD_assume: + CaptureRegions.push_back(OMPD_unknown); + break; kparzysz wrote: This is what happen

[clang] [Clang] Correctly enable the f16 type for offloading (PR #98331)

2024-07-10 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/98331 Summary: There's an extra argument that's required to *actually* enable f16 usage. For whatever reason there's a difference between fp16 and f16, where fp16 is some weird version that converts between the two. Lon

[clang] [Clang][ARM] Call constructor on BranchTargetInfo. (PR #98307)

2024-07-10 Thread Daniel Kiss via cfe-commits
@@ -141,7 +141,7 @@ class ARMTargetCodeGenInfo : public TargetCodeGenInfo { ParsedTargetAttr Attr = CGM.getTarget().parseTargetAttr(TA->getFeaturesStr()); if (!Attr.BranchProtection.empty()) { -TargetInfo::BranchProtectionInfo BPI; +TargetI

[clang] [analyzer] Splitting TaintPropagation checker into reporting and mode… (PR #98157)

2024-07-10 Thread Balazs Benics via cfe-commits
@@ -1122,10 +1131,20 @@ void GenericTaintChecker::taintUnsafeSocketProtocol(const CallEvent &Call, } /// Checker registration -void ento::registerGenericTaintChecker(CheckerManager &Mgr) { +void ento::registerTaintPropagationChecker(CheckerManager &Mgr) { Mgr.registerCheck

[clang] a4a8d36 - [InstallAPI] Don't look for linker directive symbols in reexports (#98171)

2024-07-10 Thread via cfe-commits
Author: Cyndy Ishida Date: 2024-07-10T07:50:07-07:00 New Revision: a4a8d36b8591801696aad30fa116669c7bb2348c URL: https://github.com/llvm/llvm-project/commit/a4a8d36b8591801696aad30fa116669c7bb2348c DIFF: https://github.com/llvm/llvm-project/commit/a4a8d36b8591801696aad30fa116669c7bb2348c.diff

[clang] [InstallAPI] Don't look for linker directive symbols in reexports (PR #98171)

2024-07-10 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida closed https://github.com/llvm/llvm-project/pull/98171 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Correctly enable the f16 type for offloading (PR #98331)

2024-07-10 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Joseph Huber (jhuber6) Changes Summary: There's an extra argument that's required to *actually* enable f16 usage. For whatever reason there's a difference between fp16 and f16, where fp16 is some weird version that converts between the two.

[clang] [llvm] Assume (PR #97535)

2024-07-10 Thread Alexey Bataev via cfe-commits
@@ -760,6 +760,9 @@ void clang::getOpenMPCaptureRegions( case OMPD_parallel: CaptureRegions.push_back(OMPD_parallel); break; +case OMPD_assume: + CaptureRegions.push_back(OMPD_unknown); + break; alexey-bataev wrote: It may affect

[clang] [llvm] [Clang][ARM][AArch64] Alway emit protection attributes for functions. (PR #82819)

2024-07-10 Thread Florian Hahn via cfe-commits
fhahn wrote: It looks like there's still a failure related to this patch on current main AFAICT (MSAN finds a use of uninitialized value): https://lab.llvm.org/buildbot/#/builders/169/builds/852/steps/12/logs/stdio ``` FAIL: Clang :: CodeGen/arm-branch-protection-attr-1.c (3 of 83868)

[clang] [analyzer] Split TaintPropagation checker into reporting and modeling checkers (PR #98157)

2024-07-10 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/98157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Split TaintPropagation checker into reporting and modeling checkers (PR #98157)

2024-07-10 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/98157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Split TaintPropagation checker into reporting and modeling checkers (PR #98157)

2024-07-10 Thread Balazs Benics via cfe-commits
https://github.com/steakhal approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/98157 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Split TaintPropagation checker into reporting and modeling checkers (PR #98157)

2024-07-10 Thread Balazs Benics via cfe-commits
@@ -1046,10 +1044,7 @@ bool GenericTaintChecker::generateReportIfTainted(const Expr *E, StringRef Msg, return false; // Generate diagnostic. steakhal wrote: If we are there, maybe we should also assert that inside the register call, before emplacing i

[clang] 4753f8e - [analyzer][docs] Add clang-19 release notes for CSA (#97418)

2024-07-10 Thread via cfe-commits
Author: Balazs Benics Date: 2024-07-10T16:53:12+02:00 New Revision: 4753f8e8f678411c72759e682a03d1a0218c0b88 URL: https://github.com/llvm/llvm-project/commit/4753f8e8f678411c72759e682a03d1a0218c0b88 DIFF: https://github.com/llvm/llvm-project/commit/4753f8e8f678411c72759e682a03d1a0218c0b88.diff

[clang] [analyzer][docs] Add clang-19 release notes for CSA (PR #97418)

2024-07-10 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/97418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #96240)

2024-07-10 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: The changes seem reasonable to me, but I don't have a lot of expertise with compiler-rt. Should the changes come with a release note though? https://github.com/llvm/llvm-project/pull/96240 ___ cfe-commits mai

[clang] [clang] Catch missing format attributes (PR #70024)

2024-07-10 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: Pre-commit CI seems to have found a valid failure: ``` _bk;t=1720616429374FAIL: Clang :: Sema/attr-format-missing.c (16228 of 20429) _bk;t=1720616429374 TEST 'Clang :: Sema/attr-format-missing.c' FAILED _bk;t=1720616429374Exit Co

[clang] [clang] Catch missing format attributes (PR #70024)

2024-07-10 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,277 @@ +// RUN: %clang_cc1 -fsyntax-only -verify -Wmissing-format-attribute %s + +typedef unsigned short char16_t; +typedef unsigned int char32_t; +typedef __WCHAR_TYPE__ wchar_t; +typedef __SIZE_TYPE__ size_t; +typedef __builtin_va_list va_list; + +__attribute__((__for

[clang] [llvm] Assume (PR #97535)

2024-07-10 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz edited https://github.com/llvm/llvm-project/pull/97535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >