[clang-tools-extra] [clangd] Use std::make_unique (NFC) (PR #97915)

2024-07-06 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata created https://github.com/llvm/llvm-project/pull/97915 None >From 91325539452e0fabef33894d66a0f643319891f2 Mon Sep 17 00:00:00 2001 From: Kazu Hirata Date: Sat, 29 Jun 2024 12:40:11 -0700 Subject: [PATCH] [clangd] Use std::make_unique (NFC) --- clang-tools-

[clang-tools-extra] [clangd] Use std::make_unique (NFC) (PR #97915)

2024-07-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: Kazu Hirata (kazutakahirata) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/97915.diff 1 Files Affected: - (modified) clang-tools-extra/clangd/support/ThreadsafeFS.cpp (+1-1) ``diff diff --git a

[clang-tools-extra] [clangd] Use std::make_unique (NFC) (PR #97915)

2024-07-06 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/97915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [libcxx] [libunwind] [llvm] [openmp] [cmake] switch to CMake's native `check_{compiler,linker}_flag` (PR #96171)

2024-07-06 Thread via cfe-commits
https://github.com/h-vetinari updated https://github.com/llvm/llvm-project/pull/96171 >From 1df587efeb71fb1929667f008d7e9b251863d9d8 Mon Sep 17 00:00:00 2001 From: "H. Vetinari" Date: Thu, 20 Jun 2024 21:43:31 +1100 Subject: [PATCH 1/4] [cmake] switch to CMake's native check_linker_flag, delet

[clang-tools-extra] [clangd] Use std::make_unique (NFC) (PR #97915)

2024-07-06 Thread Kazu Hirata via cfe-commits
https://github.com/kazutakahirata closed https://github.com/llvm/llvm-project/pull/97915 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] f767295 - [clangd] Use std::make_unique (NFC) (#97915)

2024-07-06 Thread via cfe-commits
Author: Kazu Hirata Date: 2024-07-07T08:15:09+09:00 New Revision: f767295942288bd70156ad322defac60b568c927 URL: https://github.com/llvm/llvm-project/commit/f767295942288bd70156ad322defac60b568c927 DIFF: https://github.com/llvm/llvm-project/commit/f767295942288bd70156ad322defac60b568c927.diff L

[clang] [clang] Add -Wimplicit-fallthrough to -Wextra (PR #97926)

2024-07-06 Thread Max Coplan via cfe-commits
https://github.com/vegerot created https://github.com/llvm/llvm-project/pull/97926 This patch adds -Wimplicit-fallthrough to -Wextra. GCC already includes it in -Wextra. This patch also adds a test to check that -Wimplicit-fallthrough is included in -Wextra. Note: This patch may regress perf

[clang] [clang] Add -Wimplicit-fallthrough to -Wextra (PR #97926)

2024-07-06 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang] Add -Wimplicit-fallthrough to -Wextra (PR #97926)

2024-07-06 Thread Max Coplan via cfe-commits
https://github.com/vegerot ready_for_review https://github.com/llvm/llvm-project/pull/97926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add -Wimplicit-fallthrough to -Wextra (PR #97926)

2024-07-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Max Coplan (vegerot) Changes This patch adds -Wimplicit-fallthrough to -Wextra. GCC already includes it in -Wextra. This patch also adds a test to check that -Wimplicit-fallthrough is included in -Wextra. Note: This patch may regress pe

[clang] [clang] Add -Wimplicit-fallthrough to -Wextra (PR #97926)

2024-07-06 Thread Max Coplan via cfe-commits
vegerot wrote: @AaronBallman please review https://github.com/llvm/llvm-project/pull/97926 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add -Wimplicit-fallthrough to -Wextra (PR #97926)

2024-07-06 Thread Max Coplan via cfe-commits
https://github.com/vegerot updated https://github.com/llvm/llvm-project/pull/97926 >From c05d739d105b76fcf83985b20762809f6eea6f40 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Max=20=F0=9F=91=A8=F0=9F=8F=BD=E2=80=8D=F0=9F=92=BB=20Copl?= =?UTF-8?q?an?= Date: Sat, 6 Jul 2024 17:22:55 -0700 Subject: [

[clang] [clang] [NFC] Mark `UnresolvedSetImpl`'s move operations as defaulted (PR #97930)

2024-07-06 Thread via cfe-commits
https://github.com/MagentaTreehouse created https://github.com/llvm/llvm-project/pull/97930 None >From de625afb940fb87efa10c0ecf0e67c9930eab182 Mon Sep 17 00:00:00 2001 From: Mingyi Chen Date: Sat, 6 Jul 2024 21:25:15 -0400 Subject: [PATCH] [clang] [NFC] Mark `UnresolvedSetImpl`'s move operati

[clang] [clang] [NFC] Mark `UnresolvedSetImpl`'s move operations as defaulted (PR #97930)

2024-07-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (MagentaTreehouse) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/97930.diff 1 Files Affected: - (modified) clang/include/clang/AST/UnresolvedSet.h (+2-3) ``diff diff --git a/clang/include/clang/AST/Un

[clang] [Clang] Guard against null in template instantiation process (PR #97913)

2024-07-06 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/97913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Guard against null in template instantiation process (PR #97913)

2024-07-06 Thread Younan Zhang via cfe-commits
@@ -636,6 +636,9 @@ bool Sema::SetupConstraintScope( ? FD->getInstantiatedFromMemberFunction() : FD->getInstantiatedFromDecl(); +if (!InstantiatedFrom) + return true; + zyn0217 wrote: This is unnecessary. For both `TK_MemberSp

[clang] [Clang] Guard against null in template instantiation process (PR #97913)

2024-07-06 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 requested changes to this pull request. https://github.com/llvm/llvm-project/pull/97913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clang] Extend diagnose_if to accept more detailed warning information (PR #70976)

2024-07-06 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/70976 >From a91f499900d4cea4804833d004b6c4e54a7d8b15 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Sun, 3 Sep 2023 17:26:28 -0700 Subject: [PATCH 1/5] [clang] Extend diagnose_if to accept more detailed warni

[clang] [Clang] Add captures to the instantiation scope for noexcept specifiers (PR #97166)

2024-07-06 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/97166 >From 91a28dcde9dc569b955df92db91c858c550f6ad3 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Sat, 29 Jun 2024 21:32:01 +0800 Subject: [PATCH] [Clang] Add captures to the instantiation scope for noexcept spec

[clang] f4c7811 - [Clang] Add captures to the instantiation scope for noexcept specifiers (#97166)

2024-07-06 Thread via cfe-commits
Author: Younan Zhang Date: 2024-07-07T09:46:38+08:00 New Revision: f4c781174b4b8fd958d9074c25eb06b6e276cb1c URL: https://github.com/llvm/llvm-project/commit/f4c781174b4b8fd958d9074c25eb06b6e276cb1c DIFF: https://github.com/llvm/llvm-project/commit/f4c781174b4b8fd958d9074c25eb06b6e276cb1c.diff

[clang] [Clang] Add captures to the instantiation scope for noexcept specifiers (PR #97166)

2024-07-06 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/97166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add captures to the instantiation scope for noexcept specifiers (PR #97166)

2024-07-06 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Thanks for the review. https://github.com/llvm/llvm-project/pull/97166 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add captures to the instantiation scope for noexcept specifiers (PR #97166)

2024-07-06 Thread Younan Zhang via cfe-commits
@@ -60,3 +60,26 @@ template C1>> auto t3() { template C1>> auto t3(); static_assert(is_same()), X>>>); #endif + +namespace GH95735 { + +int g(int fn) { + return [f = fn](auto tpl) noexcept(noexcept(f)) { return f; }(0); +} + +int foo(auto... fn) { + // FIXME: This one hits th

[clang] [Clang] Protect ObjCMethodList assignment operator against self-assig… (PR #97933)

2024-07-06 Thread via cfe-commits
https://github.com/smanna12 created https://github.com/llvm/llvm-project/pull/97933 …nment This patch adds a self-assignment check to the ObjCMethodList assignment operator to prevent issues when an object is assigned to itself. The fix ensures the integrity of the object's data during such a

[clang] [Clang] Protect ObjCMethodList assignment operator against self-assig… (PR #97933)

2024-07-06 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/97933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Protect ObjCMethodList assignment operator against self-assig… (PR #97933)

2024-07-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (smanna12) Changes This patch adds a self-assignment check to the ObjCMethodList assignment operator to prevent issues when an object is assigned to itself. The fix ensures the integrity of the object's data during such assignments.

[clang] [Clang] Protect ObjCMethodList assignment operator against self-assignment (PR #97933)

2024-07-06 Thread via cfe-commits
https://github.com/smanna12 edited https://github.com/llvm/llvm-project/pull/97933 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format][NFC] Annotate function decl l_paren (PR #97938)

2024-07-06 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/97938 None >From eb53318b3c5dec2452c4a0d5aed7944ebdd99380 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Sat, 6 Jul 2024 22:21:26 -0700 Subject: [PATCH] [clang-format][NFC] Annotate function decl l_paren --- clang/lib

[clang] [clang-format][NFC] Annotate function decl l_paren (PR #97938)

2024-07-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/97938.diff 3 Files Affected: - (modified) clang/lib/Format/FormatToken.h (+1) - (modified) clang/lib/Format/TokenAnnotator.cpp (+6) - (modified

[clang] [clang-format] Improve BlockIndent at ColumnLimit (PR #93140)

2024-07-06 Thread Owen Pan via cfe-commits
@@ -803,6 +803,60 @@ void ContinuationIndenter::addTokenOnCurrentLine(LineState &State, bool DryRun, return !Tok.Previous->isOneOf(TT_CastRParen, tok::kw_for, tok::kw_while, tok::kw_switch); }; + // Detecting functions is brittle. It wo

[clang] [X86][vectorcall] Do not consume register for indirect return value (PR #97939)

2024-07-06 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang created https://github.com/llvm/llvm-project/pull/97939 This is how MSVC handles it. https://godbolt.org/z/Eav3vx7cd >From cf19ec8d705434ca6d989a72069dba1040c360ca Mon Sep 17 00:00:00 2001 From: Phoebe Wang Date: Sun, 7 Jul 2024 13:14:59 +0800 Subject: [PATCH] [X8

[clang] [X86][vectorcall] Do not consume register for indirect return value (PR #97939)

2024-07-06 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 @llvm/pr-subscribers-clang Author: Phoebe Wang (phoebewang) Changes This is how MSVC handles it. https://godbolt.org/z/Eav3vx7cd --- Full diff: https://github.com/llvm/llvm-project/pull/97939.diff 2 Files Affected: - (modified) clang/lib/

<    1   2