[clang] [llvm] [RISCV] Remove SeenExtMap from RISCVISAInfo::parseArchString. (PR #97506)

2024-07-03 Thread Craig Topper via cfe-commits
https://github.com/topperc closed https://github.com/llvm/llvm-project/pull/97506 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Assume (PR #97535)

2024-07-03 Thread via cfe-commits
@@ -1759,8 +1759,35 @@ void Parser::ParseOpenMPAssumesDirective(OpenMPDirectiveKind DKind, Assumptions.push_back(Assumption); } + StmtResult AssociatedStmt; + + // Fix the scope for assume. SunilKuravinakop wrote: The error was in the wording in the

[clang] [llvm] Assume (PR #97535)

2024-07-03 Thread via cfe-commits
@@ -7323,6 +7324,69 @@ void SemaOpenMP::ActOnFinishedFunctionDefinitionInOpenMPAssumeScope(Decl *D) { FD->addAttr(AA); } +class OMPAssumeStmtVisitor : public StmtVisitor { + SmallVector *OMPAssumeScoped; + +public: + OMPAssumeStmtVisitor(SmallVector *OMPAssumeScoped) {

[clang] [llvm] Assume (PR #97535)

2024-07-03 Thread via cfe-commits
@@ -760,6 +760,9 @@ void clang::getOpenMPCaptureRegions( case OMPD_parallel: CaptureRegions.push_back(OMPD_parallel); break; +case OMPD_assume: + CaptureRegions.push_back(OMPD_assume); SunilKuravinakop wrote: I have corrected this. Tha

[clang] [llvm] Assume (PR #97535)

2024-07-03 Thread via cfe-commits
https://github.com/SunilKuravinakop updated https://github.com/llvm/llvm-project/pull/97535 >From a331d2343a43a9ca2030ef07a25ca93ff26a5778 Mon Sep 17 00:00:00 2001 From: Sunil Kuravinakop Date: Mon, 1 Jul 2024 03:29:45 -0500 Subject: [PATCH 1/4] Support for "#pragma omp assume" Directive in Par

[clang] [llvm] Assume (PR #97535)

2024-07-03 Thread Alexey Bataev via cfe-commits
@@ -7323,6 +7324,69 @@ void SemaOpenMP::ActOnFinishedFunctionDefinitionInOpenMPAssumeScope(Decl *D) { FD->addAttr(AA); } +class OMPAssumeStmtVisitor : public StmtVisitor { + SmallVector *OMPAssumeScoped; + +public: + OMPAssumeStmtVisitor(SmallVector *OMPAssumeScoped) {

[clang] [llvm] Assume (PR #97535)

2024-07-03 Thread via cfe-commits
https://github.com/SunilKuravinakop edited https://github.com/llvm/llvm-project/pull/97535 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Fix Default Asset File locator for clang docs (PR #97505)

2024-07-03 Thread Chris B via cfe-commits
@@ -167,7 +167,14 @@ llvm::Error getDefaultAssetFiles(const char *Argv0, llvm::SmallString<128> AssetsPath; AssetsPath = llvm::sys::path::parent_path(NativeClangDocPath); - llvm::sys::path::append(AssetsPath, "..", "share", "clang-doc"); + llvm::sys::path::append(AssetsP

[clang-tools-extra] [clang-doc] Add basic e2e test (PR #93928)

2024-07-03 Thread Justin Bogner via cfe-commits
bogner wrote: This test fails on multi-config cmake generators (`cmake -G 'Visual Studio` etc), exposing an existing bug in clang-doc. Since binaries end up under a subdirectory like `build/Release/bin` but the default json and such end up in `build/share/clang-doc`, running `clang-doc` from t

[clang] [lldb] [HLSL] Implement intangible AST type (PR #97362)

2024-07-03 Thread Helena Kotas via cfe-commits
https://github.com/hekota ready_for_review https://github.com/llvm/llvm-project/pull/97362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [HLSL] Implement intangible AST type (PR #97362)

2024-07-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Helena Kotas (hekota) Changes HLSL has a set of _intangible types_, which are described in in the [draft HLSL Specification (**[Basic.types]**)](https://microsoft.github.io/hlsl-specs/specs/hlsl.pdf): > There are special implementation-def

[clang] [lldb] [HLSL] Implement intangible AST type (PR #97362)

2024-07-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-debuginfo Author: Helena Kotas (hekota) Changes HLSL has a set of _intangible types_, which are described in in the [draft HLSL Specification (**[Basic.types]**)](https://microsoft.github.io/hlsl-specs/specs/hlsl.pdf): > There are special implementatio

[clang] Enable frame pointer for non-leaf functions on Android (PR #97614)

2024-07-03 Thread via cfe-commits
https://github.com/yabinc updated https://github.com/llvm/llvm-project/pull/97614 >From d66a8a2a6022cd1cb3aa57fb74527f662c0ff4a3 Mon Sep 17 00:00:00 2001 From: Yabin Cui Date: Wed, 3 Jul 2024 11:03:35 -0700 Subject: [PATCH] Enable frame pointer for non-leaf functions on Android On Android, we

[clang] Enable frame pointer for non-leaf functions on Android (PR #97614)

2024-07-03 Thread via cfe-commits
yabinc wrote: I forgot part of the change. Now it is fixed. https://github.com/llvm/llvm-project/pull/97614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [HLSL] Implement intangible AST type (PR #97362)

2024-07-03 Thread Helena Kotas via cfe-commits
hekota wrote: @ChuanqiXu9 - any idea why is your new test `Modules/no-external-type-id.cppm` failing on my PR? It is expecting `// CHECK: https://github.com/llvm/llvm-project/pull/97362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] Enable frame pointer for non-leaf functions on Android (PR #97614)

2024-07-03 Thread via cfe-commits
yabinc wrote: Currently, we have frame pointer only for non-leaf functions for AArch64, RISCV64, and frame pointer for all functions for ARM. I feel frame pointer for leaf functions isn't needed to unwind a callstack (For the leaf function, we already have the IP register pointing to the leaf

[clang-tools-extra] [clang-doc] fix bug introduced by asset test (PR #97540)

2024-07-03 Thread Paul Kirth via cfe-commits
ilovepi wrote: > > I believe (and the pre-merge testing seems to validate my belief) that this > > breaks the case where you build with ninja + Visual Studio. Also, I believe > > the Xcode generator is similar to the Visual Studio generator in that they > > both are multi-config generators, so

[clang] [llvm] Assume (PR #97535)

2024-07-03 Thread via cfe-commits
@@ -7323,6 +7324,69 @@ void SemaOpenMP::ActOnFinishedFunctionDefinitionInOpenMPAssumeScope(Decl *D) { FD->addAttr(AA); } +class OMPAssumeStmtVisitor : public StmtVisitor { + SmallVector *OMPAssumeScoped; + +public: + OMPAssumeStmtVisitor(SmallVector *OMPAssumeScoped) {

[clang] [llvm] [RISCV] Remove SeenExtMap from RISCVISAInfo::parseArchString. (PR #97506)

2024-07-03 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `sanitizer-x86_64-linux` running on `sanitizer-buildbot1` while building `clang,llvm` at step 2 "annotate". Full details are available at: https://lab.llvm.org/buildbot/#/builders/66/builds/978 Here is the relevant piece of t

[clang] [clang] Diagnose use of deprecated template alias (PR #97619)

2024-07-03 Thread Matheus Izvekov via cfe-commits
mizvekov wrote: For reference, see https://reviews.llvm.org/D136533 for similar expansion of diagnostics for uses of declarations, and how that lead to trouble in MacOS land. I'd suggest building libc++ on MacOS, to be sure this won't cause regressions and a future revert. I have a MacOS mac

[clang] [llvm] [Clang][OpenMP] This is addition fix for #92210. (PR #94802)

2024-07-03 Thread via cfe-commits
https://github.com/jyu2-git updated https://github.com/llvm/llvm-project/pull/94802 >From 157744f968ff9bc23efdfd0ee5c9a3e23f9413da Mon Sep 17 00:00:00 2001 From: Jennifer Yu Date: Wed, 5 Jun 2024 13:53:34 -0700 Subject: [PATCH 1/3] [Clang][OpenMP] This is addition fix for #92210. Fix another r

[clang] [llvm] [Clang][OpenMP] This is addition fix for #92210. (PR #94802)

2024-07-03 Thread via cfe-commits
https://github.com/jyu2-git updated https://github.com/llvm/llvm-project/pull/94802 >From 157744f968ff9bc23efdfd0ee5c9a3e23f9413da Mon Sep 17 00:00:00 2001 From: Jennifer Yu Date: Wed, 5 Jun 2024 13:53:34 -0700 Subject: [PATCH 1/4] [Clang][OpenMP] This is addition fix for #92210. Fix another r

[clang] [lldb] [HLSL] Implement intangible AST type (PR #97362)

2024-07-03 Thread Xiang Li via cfe-commits
@@ -2241,6 +2247,11 @@ TypeInfo ASTContext::getTypeInfoImpl(const Type *T) const { Align = ALIGN; \ break; #include "clang/Basic/AMDGPUTypes.def" +#define HLSL_INTANGIBLE_TYPE(Name, Id, SingletonId) case Buil

[clang] [llvm] [Clang][OpenMP] This is addition fix for #92210. (PR #94802)

2024-07-03 Thread via cfe-commits
jyu2-git wrote: Thanks, Alexey, for the review! https://github.com/llvm/llvm-project/pull/94802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] fix bug introduced by asset test (PR #97540)

2024-07-03 Thread Petr Hosek via cfe-commits
petrhosek wrote: We already have set of CMake variables that we use to refer to `bin` or `lib` directory which account for various configurations: https://github.com/llvm/llvm-project/blob/c02e8f762a410e55581866c43636efcd6504c1bd/llvm/CMakeLists.txt#L446-L467 I think we should introduce anothe

[clang] [lldb] [HLSL] Implement intangible AST type (PR #97362)

2024-07-03 Thread Xiang Li via cfe-commits
@@ -757,7 +757,8 @@ void USRGenerator::VisitType(QualType T) { case BuiltinType::OCLReserveID: Out << "@BT@OCLReserveID"; break; case BuiltinType::OCLSampler: - Out << "@BT@OCLSampler"; break; + Out << "@BT@OCLSampler"; + bre

[clang] [clang] Diagnose use of deprecated template alias (PR #97619)

2024-07-03 Thread via cfe-commits
premanandrao wrote: > For reference, see https://reviews.llvm.org/D136533 for similar expansion of > diagnostics for uses of declarations, and how that lead to trouble in MacOS > land. > I'd suggest building libc++ on MacOS, to be sure this won't cause regressions > and a future revert. Thank

[clang] Enable frame pointer for non-leaf functions on Android (PR #97614)

2024-07-03 Thread via cfe-commits
https://github.com/enh-google approved this pull request. yeah, that looks more like what i was expecting to see :-) https://github.com/llvm/llvm-project/pull/97614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

[clang] [lldb] [HLSL] Implement intangible AST type (PR #97362)

2024-07-03 Thread Helena Kotas via cfe-commits
@@ -757,7 +757,8 @@ void USRGenerator::VisitType(QualType T) { case BuiltinType::OCLReserveID: Out << "@BT@OCLReserveID"; break; case BuiltinType::OCLSampler: - Out << "@BT@OCLSampler"; break; + Out << "@BT@OCLSampler"; + bre

[clang] [lldb] [HLSL] Implement intangible AST type (PR #97362)

2024-07-03 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/97362 >From a07ea8d187cbba5717b89f5c54138f12993b3ee8 Mon Sep 17 00:00:00 2001 From: Justin Bogner Date: Thu, 6 Jun 2024 11:44:56 -0700 Subject: [PATCH 1/7] wip: Stub out adding an HLSLResource builtin type There are a

[clang] [llvm] [Clang][OpenMP] This is addition fix for #92210. (PR #94802)

2024-07-03 Thread Alexey Bataev via cfe-commits
@@ -8025,6 +8025,19 @@ class MappableExprsHandler { MapCombinedInfoTy StructBaseCurInfo; const Decl *D = Data.first; const ValueDecl *VD = cast_or_null(D); + bool HasMapBasePtr = false; + bool HasMapArraySec = false; + for (const auto &M : Data.

[clang] [llvm] [Clang][OpenMP] This is addition fix for #92210. (PR #94802)

2024-07-03 Thread Alexey Bataev via cfe-commits
@@ -8025,6 +8025,19 @@ class MappableExprsHandler { MapCombinedInfoTy StructBaseCurInfo; const Decl *D = Data.first; const ValueDecl *VD = cast_or_null(D); + bool HasMapBasePtr = false; + bool HasMapArraySec = false; + for (const auto &M : Data.

[clang] [CodeGen] Add a flag to disable emitting block signature strings (PR #96944)

2024-07-03 Thread John McCall via cfe-commits
https://github.com/rjmccall commented: This all seems reasonable to me. Please add real documentation for this, though, not just a release note. https://github.com/llvm/llvm-project/pull/96944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org h

[clang] [CodeGen] Add a flag to disable emitting block signature strings (PR #96944)

2024-07-03 Thread Akira Hatanaka via cfe-commits
ahatanak wrote: Sorry, I didn't remember that I had to set `BLOCK_HAS_SIGNATURE` to 0. https://github.com/llvm/llvm-project/pull/96944 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Implement -mcmodel flag (PR #95411)

2024-07-03 Thread Mats Petersson via cfe-commits
Leporacanthicus wrote: Working on a fix - it should be trivial, just need to check that that it still builds and passes. [Trying to generate code without the correct target enabled!] https://github.com/llvm/llvm-project/pull/95411 ___ cfe-commits ma

[clang-tools-extra] [llvm] [clang-doc] fix bug introduced by asset test (PR #97540)

2024-07-03 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/97540 >From b8dd4f6f2005d2e08ae13023905d0f36edd6348b Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Wed, 3 Jul 2024 04:42:33 -0400 Subject: [PATCH 1/4] [clang-doc] fix path bug introduced by asset test --- clang-

[clang-tools-extra] [llvm] [clang-doc] fix bug introduced by asset test (PR #97540)

2024-07-03 Thread via cfe-commits
PeterChou1 wrote: > We already have set of CMake variables that we use to refer to `bin` or `lib` > directory which account for various configurations: > > https://github.com/llvm/llvm-project/blob/c02e8f762a410e55581866c43636efcd6504c1bd/llvm/CMakeLists.txt#L446-L467 > > I think we should int

[clang] [C2y] Claim conformance to WG14 N3254 (PR #97581)

2024-07-03 Thread John McCall via cfe-commits
rjmccall wrote: Yes, I agree that we can reasonably claim to support this for the indefinite future. This is something we would've seen ourselves as practically constrained from exploiting anyway, effectively making it well-defined even if the standard didn't act. https://github.com/llvm/llv

[clang-tools-extra] [llvm] [clang-doc] fix bug introduced by asset test (PR #97540)

2024-07-03 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/97540 >From b8dd4f6f2005d2e08ae13023905d0f36edd6348b Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Wed, 3 Jul 2024 04:42:33 -0400 Subject: [PATCH 1/5] [clang-doc] fix path bug introduced by asset test --- clang-

[clang] [Clang][Sema] Fix crash when rebuilding MemberExprs with invalid object expressions (PR #97455)

2024-07-03 Thread Krystian Stasiowski via cfe-commits
@@ -2896,6 +2896,9 @@ class TreeTransform { SS.Adopt(QualifierLoc); Base = BaseResult.get(); +if (Base->containsErrors()) + return ExprError(); sdkrystian wrote: @mizvekov The problems arise when we build a `MemberExpr` for a class member ac

[clang] [Clang][Sema] Fix crash when rebuilding MemberExprs with invalid object expressions (PR #97455)

2024-07-03 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian edited https://github.com/llvm/llvm-project/pull/97455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix crash when rebuilding MemberExprs with invalid object expressions (PR #97455)

2024-07-03 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian edited https://github.com/llvm/llvm-project/pull/97455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AMDGPU] Report error in clang if wave32 is requested where unsupported (PR #97633)

2024-07-03 Thread Stanislav Mekhanoshin via cfe-commits
https://github.com/rampitec created https://github.com/llvm/llvm-project/pull/97633 None >From dc9d1e2039981bb412e68975570d9911511bb880 Mon Sep 17 00:00:00 2001 From: Stanislav Mekhanoshin Date: Wed, 3 Jul 2024 13:12:21 -0700 Subject: [PATCH] [AMDGPU] Report error in clang if wave32 is request

[clang] [llvm] [AMDGPU] Report error in clang if wave32 is requested where unsupported (PR #97633)

2024-07-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-backend-amdgpu Author: Stanislav Mekhanoshin (rampitec) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/97633.diff 5 Files Affected: - (modified) clang/lib/Basic/Targets/AMDGPU.cpp (+6-2) - (modified) cla

[clang-tools-extra] Fix Default Asset File locator for clang docs (PR #97505)

2024-07-03 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/97505 >From 1c190c9c6b55aec23bab6d7b2a0f489c59285dc7 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Tue, 2 Jul 2024 18:38:24 -0700 Subject: [PATCH 1/4] if debug exists, go up an extra dir --- clang-tools-extra/

[clang] [compiler-rt] [compiler-rt] Realtime Sanitizer: Introduce Realtime Sanitizer (RTSan) backend (PR #92460)

2024-07-03 Thread Fangrui Song via cfe-commits
MaskRay wrote: > This is PR 1/?? (3? 4?) introducing the main guts of the realtime sanitizer. > For more information, please see the [discourse > thread](https://discourse.llvm.org/t/rfc-nolock-and-noalloc-attributes/76837). > We have also put together a [reviewer support > document](https://

[clang] [Parser][ObjC] Add -Wobjc-prefix-length warning option. (PR #97597)

2024-07-03 Thread Jon Roelofs via cfe-commits
@@ -0,0 +1,18 @@ +// RUN: %clang_cc1 %s -Wobjc-prefixes=NS,NSCF,NSURL -fsyntax-only -verify jroelofs wrote: is it worth adding a `-Wobjc-forbidden-prefixes=NS`, so you can e.g. forbid things outside of Foundation from defining things with the `NS` prefix? https

[clang] [Driver] Add -Wa, options --crel and --allow-experimental-crel (PR #97378)

2024-07-03 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/97378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Add -Wa, options --crel and --allow-experimental-crel (PR #97378)

2024-07-03 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay updated https://github.com/llvm/llvm-project/pull/97378 >From 6e47264dc3d7395b30bedeeba7c8ca2e7b376727 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Mon, 1 Jul 2024 19:44:57 -0700 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?= =?UTF-

[clang] 04a1a34 - [Driver] Add -Wa, options --crel and --allow-experimental-crel

2024-07-03 Thread via cfe-commits
Author: Fangrui Song Date: 2024-07-03T13:45:48-07:00 New Revision: 04a1a3482ce3ee00b5bbec1ce852e58410e4b6ad URL: https://github.com/llvm/llvm-project/commit/04a1a3482ce3ee00b5bbec1ce852e58410e4b6ad DIFF: https://github.com/llvm/llvm-project/commit/04a1a3482ce3ee00b5bbec1ce852e58410e4b6ad.diff

[clang] [Driver] Add -Wa, options --crel and --allow-experimental-crel (PR #97378)

2024-07-03 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/97378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] Add assertion to ensure FiniteMathOnly is in sync with HonorINFs and HonorNANs. (PR #97342)

2024-07-03 Thread Joshua Cranmer via cfe-commits
@@ -816,6 +816,11 @@ class FPOptions { setAllowFPReassociate(LO.AllowFPReassoc); setNoHonorNaNs(LO.NoHonorNaNs); setNoHonorInfs(LO.NoHonorInfs); +// Ensure that if FiniteMathOnly is enabled, NoHonorNaNs and NoHonorInfs are +// also enabled. This is because

[clang] [llvm] [Clang][OpenMP] This is addition fix for #92210. (PR #94802)

2024-07-03 Thread via cfe-commits
https://github.com/jyu2-git updated https://github.com/llvm/llvm-project/pull/94802 >From 157744f968ff9bc23efdfd0ee5c9a3e23f9413da Mon Sep 17 00:00:00 2001 From: Jennifer Yu Date: Wed, 5 Jun 2024 13:53:34 -0700 Subject: [PATCH 1/5] [Clang][OpenMP] This is addition fix for #92210. Fix another r

[clang] [llvm] [Clang][OpenMP] This is addition fix for #92210. (PR #94802)

2024-07-03 Thread via cfe-commits
https://github.com/jyu2-git updated https://github.com/llvm/llvm-project/pull/94802 >From 157744f968ff9bc23efdfd0ee5c9a3e23f9413da Mon Sep 17 00:00:00 2001 From: Jennifer Yu Date: Wed, 5 Jun 2024 13:53:34 -0700 Subject: [PATCH 1/6] [Clang][OpenMP] This is addition fix for #92210. Fix another r

[clang] [C23] Add *_NORM_MAX macros to (PR #96643)

2024-07-03 Thread Joshua Cranmer via cfe-commits
@@ -113,7 +113,11 @@ static T PickFP(const llvm::fltSemantics *Sem, T IEEEHalfVal, T IEEESingleVal, static void DefineFloatMacros(MacroBuilder &Builder, StringRef Prefix, const llvm::fltSemantics *Sem, StringRef Ext) { - const char *DenormMin, *

[clang] [llvm] [Clang][OpenMP] This is addition fix for #92210. (PR #94802)

2024-07-03 Thread Alexey Bataev via cfe-commits
@@ -8025,6 +8025,15 @@ class MappableExprsHandler { MapCombinedInfoTy StructBaseCurInfo; const Decl *D = Data.first; const ValueDecl *VD = cast_or_null(D); + bool HasMapBasePtr = false; + bool HasMapArraySec = false; + if (VD && VD->getType()->i

[clang] [llvm] [Clang][OpenMP] This is addition fix for #92210. (PR #94802)

2024-07-03 Thread Alexey Bataev via cfe-commits
@@ -8025,6 +8025,15 @@ class MappableExprsHandler { MapCombinedInfoTy StructBaseCurInfo; const Decl *D = Data.first; const ValueDecl *VD = cast_or_null(D); + bool HasMapBasePtr = false; + bool HasMapArraySec = false; + if (VD && VD->getType()->i

[clang-tools-extra] [llvm] [clang-doc] fix bug introduced by asset test (PR #97540)

2024-07-03 Thread via cfe-commits
PeterChou1 wrote: @dyung I do not have access to mac for xcode could you provide me with a log of the build failure on xcode https://github.com/llvm/llvm-project/pull/97540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [lldb] [HLSL] Implement intangible AST type (PR #97362)

2024-07-03 Thread Damyan Pepper via cfe-commits
@@ -115,6 +116,18 @@ GlobalVariable *replaceBuffer(CGHLSLRuntime::Buffer &Buf) { } // namespace +llvm::Type *CGHLSLRuntime::convertHLSLSpecificType(const Type *T) { + assert(T->isHLSLSpecificType() && "Not an HLSL specific type!"); + + // Check if the target has a specific

[clang] [llvm] [Clang][OpenMP] This is addition fix for #92210. (PR #94802)

2024-07-03 Thread via cfe-commits
https://github.com/jyu2-git updated https://github.com/llvm/llvm-project/pull/94802 >From 157744f968ff9bc23efdfd0ee5c9a3e23f9413da Mon Sep 17 00:00:00 2001 From: Jennifer Yu Date: Wed, 5 Jun 2024 13:53:34 -0700 Subject: [PATCH 1/7] [Clang][OpenMP] This is addition fix for #92210. Fix another r

[clang] Enable frame pointer for non-leaf functions on Android (PR #97614)

2024-07-03 Thread Stephen Hines via cfe-commits
https://github.com/stephenhines approved this pull request. Looks great! Thanks for making this more consistent. https://github.com/llvm/llvm-project/pull/97614 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [llvm] [Clang][OpenMP] This is addition fix for #92210. (PR #94802)

2024-07-03 Thread via cfe-commits
@@ -8025,6 +8025,15 @@ class MappableExprsHandler { MapCombinedInfoTy StructBaseCurInfo; const Decl *D = Data.first; const ValueDecl *VD = cast_or_null(D); + bool HasMapBasePtr = false; + bool HasMapArraySec = false; + if (VD && VD->getType()->i

[clang] [llvm] [Clang][OpenMP] This is addition fix for #92210. (PR #94802)

2024-07-03 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/94802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [HLSL] Implement intangible AST type (PR #97362)

2024-07-03 Thread Damyan Pepper via cfe-commits
damyanp wrote: I see many places where extra cases have been added for the intangible types but no corresponding tests. Is that ok? How did you know to update these places? I also don't see anywhere that actually successfully uses `__builtin_hlsl_resource_t`. Am I missing it, or should I no

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-07-03 Thread Brian Cain via cfe-commits
@@ -367,7 +420,7 @@ XRayPatchingStatus mprotectAndPatchFunction(int32_t FuncId, return XRayPatchingStatus::FAILED; } - // Here we compute the minimum sled and maximum sled associated with a + // Here we compute the minumum sled and maximum sled associated with a --

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-07-03 Thread Brian Cain via cfe-commits
@@ -346,8 +392,8 @@ else() # not Apple DEFS ${XRAY_COMMON_DEFINITIONS} OBJECT_LIBS RTXrayBASIC PARENT_TARGET xray) - # Profiler Mode runtime - add_compiler_rt_runtime(clang_rt.xray-profiling +# Profiler Mode runtime +add_compiler_rt_runtime(clang_r

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-07-03 Thread Brian Cain via cfe-commits
https://github.com/androm3da edited https://github.com/llvm/llvm-project/pull/90959 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-07-03 Thread Brian Cain via cfe-commits
@@ -1520,10 +1520,14 @@ bool tools::addSanitizerRuntimes(const ToolChain &TC, const ArgList &Args, } bool tools::addXRayRuntime(const ToolChain&TC, const ArgList &Args, ArgStringList &CmdArgs) { - if (Args.hasArg(options::OPT_shared)) -return false; - - if (TC.getXRayA

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-07-03 Thread Brian Cain via cfe-commits
https://github.com/androm3da commented: Instead of adding new commits to address feedback - please change the existing commits to alter the content to look as if it would when the PR would be merged. (Unless perhaps there's an LLVM community policy to do it this way) https://github.com/llvm/ll

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-07-03 Thread Brian Cain via cfe-commits
@@ -0,0 +1,62 @@ +//===-- xray_init.cpp ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-07-03 Thread Brian Cain via cfe-commits
@@ -50,14 +52,72 @@ atomic_uint8_t XRayInitialized{0}; // This should always be updated before XRayInitialized is updated. SpinMutex XRayInstrMapMutex; -XRaySledMap XRayInstrMap; +// XRaySledMap XRayInstrMap; +// Contains maps for the main executable as well as DSOs. +// std:

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-07-03 Thread Brian Cain via cfe-commits
@@ -63,6 +63,10 @@ XRayArgs::XRayArgs(const ToolChain &TC, const ArgList &Args) { << XRayInstrument->getSpelling() << Triple.str(); } + if (Args.hasFlag(options::OPT_fxray_enable_shared, + options::OPT_fno_xray_enable_shared, false)) +XRayEnab

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-07-03 Thread Brian Cain via cfe-commits
@@ -471,42 +518,123 @@ uint16_t __xray_register_event_type( } XRayPatchingStatus __xray_patch() XRAY_NEVER_INSTRUMENT { - return controlPatching(true); + XRayPatchingStatus CombinedStatus{SUCCESS}; + for (size_t I = 0; I < __xray_num_objects(); ++I) { +if (!isObjectLoad

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-07-03 Thread Brian Cain via cfe-commits
@@ -471,42 +518,123 @@ uint16_t __xray_register_event_type( } XRayPatchingStatus __xray_patch() XRAY_NEVER_INSTRUMENT { - return controlPatching(true); + XRayPatchingStatus CombinedStatus{SUCCESS}; androm3da wrote: If none of the objects are loaded, `__xray

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-07-03 Thread Brian Cain via cfe-commits
@@ -0,0 +1,62 @@ +//===-- xray_init.cpp ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-07-03 Thread Brian Cain via cfe-commits
@@ -111,6 +156,71 @@ void __xray_init() XRAY_NEVER_INSTRUMENT { #endif } +// Default visibility is hidden, so we have to explicitly make it visible to +// DSO. +SANITIZER_INTERFACE_ATTRIBUTE int32_t __xray_register_dso( +const XRaySledEntry *SledsBegin, const XRaySledEntry

[clang] [compiler-rt] [XRay] Add support for instrumentation of DSOs on x86_64 (PR #90959)

2024-07-03 Thread Brian Cain via cfe-commits
@@ -0,0 +1,62 @@ +//===-- xray_init.cpp ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [Clang][Sema] Fix crash when rebuilding MemberExprs with invalid object expressions (PR #97455)

2024-07-03 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov approved this pull request. https://github.com/llvm/llvm-project/pull/97455 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Add a flag to disable emitting block signature strings (PR #96944)

2024-07-03 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak updated https://github.com/llvm/llvm-project/pull/96944 >From d21bdaec94a169b27e7f7bace399e77bf99fd572 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka Date: Tue, 25 Jun 2024 19:37:46 -0700 Subject: [PATCH 1/2] [CodeGen] Add a flag to disable emitting block signature s

[clang] [llvm] [mlir] [MLIR] Add f8E4M3 IEEE 754 type (PR #97118)

2024-07-03 Thread Maksim Levental via cfe-commits
makslevental wrote: Hey @apivovarov I just wanted to say my bad for not getting to this yet - I'm buried at work but I haven't forgotten. If it's hipri I can find someone else to review. Otherwise ~couple of days I think and I'll be clear to review. https://github.com/llvm/llvm-project/pull/97

[clang-tools-extra] [llvm] [clang-doc] fix bug introduced by asset test (PR #97540)

2024-07-03 Thread via cfe-commits
dyung wrote: > @dyung I do not have access to mac for xcode could you provide me with a log > of the build failure on xcode ``` % python3 ~/src/git/llvm-dyung/build/Debug/bin/llvm-lit -v basic-project.test -- Testing: 1 tests, 1 workers -- FAIL: Clang Tools :: clang-doc/basic-project.test (1 of

[clang-tools-extra] [clang-tidy] Add `bugprone-pointer-arithmetic-on-polymorphic-object` check (PR #91951)

2024-07-03 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL approved this pull request. Some small issues with diagnostic left. Except that, looks good enough. https://github.com/llvm/llvm-project/pull/91951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.o

[clang-tools-extra] [clang-tidy] Add `bugprone-pointer-arithmetic-on-polymorphic-object` check (PR #91951)

2024-07-03 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,81 @@ +//===--- PointerArithmeticOnPolymorphicObjectCheck.cpp - clang-tidy===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] Add `bugprone-pointer-arithmetic-on-polymorphic-object` check (PR #91951)

2024-07-03 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/91951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Add `bugprone-pointer-arithmetic-on-polymorphic-object` check (PR #91951)

2024-07-03 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,81 @@ +//===--- PointerArithmeticOnPolymorphicObjectCheck.cpp - clang-tidy===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [libc] [llvm] AMDGPU: Add a subtarget feature for fine-grained remote memory support (PR #96442)

2024-07-03 Thread Matt Arsenault via cfe-commits
https://github.com/arsenm updated https://github.com/llvm/llvm-project/pull/96442 >From 803aa8823e1d2a9c4ebf2d0ab4ad7c2e0ad9d7e9 Mon Sep 17 00:00:00 2001 From: martinboehme Date: Wed, 26 Jun 2024 15:01:57 +0200 Subject: [PATCH 01/14] [clang][dataflow] Teach `AnalysisASTVisitor` that `typeid()`

[clang-tools-extra] [clang-doc] add ftime profiling (PR #97644)

2024-07-03 Thread via cfe-commits
https://github.com/PeterChou1 created https://github.com/llvm/llvm-project/pull/97644 this patches adds ftime-tracing option for clang-doc which was what I used to profile the performance problems we had with clang-doc generating the llvm docs. It introduces two option --ftime-trace and --ftim

[clang-tools-extra] [clang-doc] add ftime profiling (PR #97644)

2024-07-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tools-extra Author: None (PeterChou1) Changes this patches adds ftime-tracing option for clang-doc which was what I used to profile the performance problems we had with clang-doc generating the llvm docs. It introduces two option --ftime-trace an

[clang-tools-extra] [clang-doc] add ftime profiling (PR #97644)

2024-07-03 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 10c894cffd0f4bef21b54a43b5780240532e44cf 7462b374a1ec05f84c84ea705fdc98a9d3c02783 --

[clang] [llvm] [Clang][OpenMP] This is addition fix for #92210. (PR #94802)

2024-07-03 Thread via cfe-commits
https://github.com/jyu2-git updated https://github.com/llvm/llvm-project/pull/94802 >From 157744f968ff9bc23efdfd0ee5c9a3e23f9413da Mon Sep 17 00:00:00 2001 From: Jennifer Yu Date: Wed, 5 Jun 2024 13:53:34 -0700 Subject: [PATCH 1/8] [Clang][OpenMP] This is addition fix for #92210. Fix another r

[clang] [llvm] [Clang][OpenMP] This is addition fix for #92210. (PR #94802)

2024-07-03 Thread via cfe-commits
jyu2-git wrote: Thanks Alexey!! https://github.com/llvm/llvm-project/pull/94802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] add ftime profiling (PR #97644)

2024-07-03 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/97644 >From ff278188403a6f89e8c13f7a2330d978f31b1ab5 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Wed, 3 Jul 2024 15:42:22 -0400 Subject: [PATCH 1/2] [clang-doc] add ftime trace option --- clang-tools-extra/cla

[clang] [compiler-rt] [compiler-rt] Realtime Sanitizer: Introduce Realtime Sanitizer (RTSan) backend (PR #92460)

2024-07-03 Thread Chris Apple via cfe-commits
cjappl wrote: > clangDriver changes are usually the last. The expectation is that if > -fsanitize=realtime does not return an error, there should be some basic > functionality. Thanks for the feedback @MaskRay . I removed all of the clang components of this review, leaving only the compiler-r

[clang] [llvm] [AArch64][PAC] Sign block addresses used in indirectbr. (PR #97647)

2024-07-03 Thread Ahmed Bougacha via cfe-commits
https://github.com/ahmedbougacha created https://github.com/llvm/llvm-project/pull/97647 Enabled in clang using: -fptrauth-indirect-gotos and at the IR level using function attribute: "ptrauth-indirect-gotos" Signing uses IA and a per-function integer discriminator. The discriminator

[clang] [llvm] [AArch64][PAC] Sign block addresses used in indirectbr. (PR #97647)

2024-07-03 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 4a1fdeb04d10f5562687568ea8c494b3ef46c587 f0d8af86161c6037e9e0d1fe800e5876dd090092 --

[clang] [compiler-rt] [compiler-rt] Realtime Sanitizer: Introduce Realtime Sanitizer (RTSan) backend (PR #92460)

2024-07-03 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay commented: Sorry for the delay. I have a really huge code review backlog... https://github.com/llvm/llvm-project/pull/92460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [compiler-rt] [compiler-rt] Realtime Sanitizer: Introduce Realtime Sanitizer (RTSan) backend (PR #92460)

2024-07-03 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,50 @@ +//===--- rtsan_stack.cpp - Realtime Sanitizer ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [compiler-rt] [compiler-rt] Realtime Sanitizer: Introduce Realtime Sanitizer (RTSan) backend (PR #92460)

2024-07-03 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay edited https://github.com/llvm/llvm-project/pull/92460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [compiler-rt] Realtime Sanitizer: Introduce Realtime Sanitizer (RTSan) backend (PR #92460)

2024-07-03 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,67 @@ +import os + +# Setup config name. +config.name = "RTSAN" + config.name_suffix + +# Setup source root. +config.test_source_root = os.path.dirname(__file__) + +# Setup default compiler flags use with -frtsan-instrument option. +clang_rtsan_cflags = ["-frtsan-instru

[clang] [compiler-rt] [compiler-rt] Realtime Sanitizer: Introduce Realtime Sanitizer (RTSan) backend (PR #92460)

2024-07-03 Thread Fangrui Song via cfe-commits
@@ -0,0 +1,97 @@ +//===--- rtsan_context.cpp - Realtime Sanitizer -*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

<    1   2   3   4   >