[clang] [clang] Don't emit the warn_dangling_lifetime_pointer diagnostic for the assignment case. (PR #97408)

2024-07-02 Thread Haojian Wu via cfe-commits
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/97408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Don't emit the warn_dangling_lifetime_pointer diagnostic for the assignment case. (PR #97408)

2024-07-02 Thread Haojian Wu via cfe-commits
https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/97408 >From d1ea90918702fec85714bdd9caa68942eb4a4218 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Tue, 2 Jul 2024 14:12:36 +0200 Subject: [PATCH 1/2] [clang] Don't emit the warn_dangling_lifetime_pointer diagnostic

[clang] Support C++20 Modules in clang-repl (PR #79261)

2024-07-02 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: Do you mean the documentation? If so, yes, that’s probably not the right place. I am on my phone but can you suggest a place where we should move this or just move it? I think that was an oversight. https://github.com/llvm/llvm-project/pull/79261

[clang] 9a7248a - [clang][OpenMP] Rewrite `getOpenMPCaptureRegions` in terms of leafs (#97110)

2024-07-02 Thread via cfe-commits
Author: Krzysztof Parzyszek Date: 2024-07-02T07:45:47-05:00 New Revision: 9a7248a602eb5eff264c89ee3fe119c86f63fda1 URL: https://github.com/llvm/llvm-project/commit/9a7248a602eb5eff264c89ee3fe119c86f63fda1 DIFF: https://github.com/llvm/llvm-project/commit/9a7248a602eb5eff264c89ee3fe119c86f63fda1

[clang] [clang][OpenMP] Rewrite `getOpenMPCaptureRegions` in terms of leafs (PR #97110)

2024-07-02 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz closed https://github.com/llvm/llvm-project/pull/97110 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Don't emit the warn_dangling_lifetime_pointer diagnostic for the assignment case. (PR #97408)

2024-07-02 Thread Utkarsh Saxena via cfe-commits
@@ -1023,7 +1023,7 @@ static void checkExprLifetimeImpl(Sema &SemaRef, return false; } - if (IsGslPtrInitWithGslTempOwner && DiagLoc.isValid()) { + if (InitEntity && IsGslPtrInitWithGslTempOwner && DiagLoc.isValid()) { usx95 wrote: I t

[clang] [clang] Don't emit the warn_dangling_lifetime_pointer diagnostic for the assignment case. (PR #97408)

2024-07-02 Thread Utkarsh Saxena via cfe-commits
@@ -0,0 +1,15 @@ + +// RUN: %clang_cc1 -std=c++20 -verify -Wno-dangling-assignment %s usx95 wrote: I would suggest dropping `-Wno-dangling-assignment` and ensuring that we get "only" the dangling assignment and not GSL ones. This would also not need a new file.

[clang] Support C++20 Modules in clang-repl (PR #79261)

2024-07-02 Thread Balazs Benics via cfe-commits
steakhal wrote: > Do you mean the documentation? If so, yes, that’s probably not the right > place. I am on my phone but can you suggest a place where we should move this > or just move it? I think that was an oversight. Thanks. There is nothing urgent. I was just preparing a PR for syncing th

[clang] [clang] inherit GD to let the codegen add kcfi type for ifunc (PR #96400)

2024-07-02 Thread via cfe-commits
aokblast wrote: I think it is not the correct way to fix this issue. GD is type for ifunc not for resolver. So the CI brokes if we do things like this. https://github.com/llvm/llvm-project/pull/96400 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [flang] [flang] Implement -mcmodel flag (PR #95411)

2024-07-02 Thread Mats Petersson via cfe-commits
Leporacanthicus wrote: > Yes, thank you! This is now part of this PR. https://github.com/llvm/llvm-project/pull/95411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Support C++20 Modules in clang-repl (PR #79261)

2024-07-02 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: Oh, understood. Perhaps would be better if you move it. I am currently on vacation for a while… https://github.com/llvm/llvm-project/pull/79261 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [flang] [flang] Implement -mcmodel flag (PR #95411)

2024-07-02 Thread Tom Eccles via cfe-commits
https://github.com/tblah approved this pull request. LGTM. Thanks for picking this up Mats. Ideally, wait for @Thirumalai-Shaktivel to have another look before merging. https://github.com/llvm/llvm-project/pull/95411 ___ cfe-commits mailing list cfe-c

[clang] [clang][analyzer][doc] Migrate user-related docs from HTML to RST (PR #97034)

2024-07-02 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat commented: I'm really happy to see that this duplicated documentation is finally cleaned up after so many years :partying_face: I added a few minor remarks in inline comments, but the change looks good overall. As we discussed privately, this change should be (mos

[clang] [clang][analyzer][doc] Migrate user-related docs from HTML to RST (PR #97034)

2024-07-02 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/97034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer][doc] Migrate user-related docs from HTML to RST (PR #97034)

2024-07-02 Thread Donát Nagy via cfe-commits
@@ -0,0 +1,239 @@ +Command Line Usage: scan-build and CodeChecker +== + +This document provides guidelines for running Clang Static Analyzer from the command line on whole projects. +CodeChecker and scan-build are two CLI tools for usin

[clang] [clang][analyzer][doc] Migrate user-related docs from HTML to RST (PR #97034)

2024-07-02 Thread Donát Nagy via cfe-commits
@@ -0,0 +1,239 @@ +Command Line Usage: scan-build and CodeChecker +== + +This document provides guidelines for running Clang Static Analyzer from the command line on whole projects. +CodeChecker and scan-build are two CLI tools for usin

[clang] [flang] [flang] Implement -mcmodel flag (PR #95411)

2024-07-02 Thread Mats Petersson via cfe-commits
https://github.com/Leporacanthicus edited https://github.com/llvm/llvm-project/pull/95411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer][doc] Migrate user-related docs from HTML to RST (PR #97034)

2024-07-02 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/97034 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] fix cast failures by adjusting the resolution of record declaration contexts to handle semantic and lexical distinctions (PR #96228)

2024-07-02 Thread Oleksandr T. via cfe-commits
@@ -0,0 +1,18 @@ +// RUN: %clang_cc1 -std=c++20 -fsyntax-only -verify %s a-tarasyuk wrote: @shafik could you review the latest changes? thanks https://github.com/llvm/llvm-project/pull/96228 ___ cfe-commits mailing lis

[clang] 1a42255 - [C2y] Modify diagnostics for complex increment/decrement

2024-07-02 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2024-07-02T09:08:44-04:00 New Revision: 1a422553f9ed05ee57463ed5554cfd7eeea46800 URL: https://github.com/llvm/llvm-project/commit/1a422553f9ed05ee57463ed5554cfd7eeea46800 DIFF: https://github.com/llvm/llvm-project/commit/1a422553f9ed05ee57463ed5554cfd7eeea46800.diff

[clang] [compiler-rt] [ubsan] Display correct runtime messages for negative _BitInt (PR #96240)

2024-07-02 Thread via cfe-commits
earnol wrote: Ping! Any additional suggestions for the improvements? Selfishly want to move it forward :) https://github.com/llvm/llvm-project/pull/96240 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] [clang] Don't emit the warn_dangling_lifetime_pointer diagnostic for the assignment case. (PR #97408)

2024-07-02 Thread Haojian Wu via cfe-commits
https://github.com/hokein updated https://github.com/llvm/llvm-project/pull/97408 >From d1ea90918702fec85714bdd9caa68942eb4a4218 Mon Sep 17 00:00:00 2001 From: Haojian Wu Date: Tue, 2 Jul 2024 14:12:36 +0200 Subject: [PATCH 1/3] [clang] Don't emit the warn_dangling_lifetime_pointer diagnostic

[clang] [clang] Don't emit the warn_dangling_lifetime_pointer diagnostic for the assignment case. (PR #97408)

2024-07-02 Thread Haojian Wu via cfe-commits
@@ -1023,7 +1023,7 @@ static void checkExprLifetimeImpl(Sema &SemaRef, return false; } - if (IsGslPtrInitWithGslTempOwner && DiagLoc.isValid()) { + if (InitEntity && IsGslPtrInitWithGslTempOwner && DiagLoc.isValid()) { hokein wrote: Do

[clang] [clang] Don't emit the warn_dangling_lifetime_pointer diagnostic for the assignment case. (PR #97408)

2024-07-02 Thread Haojian Wu via cfe-commits
@@ -0,0 +1,15 @@ + +// RUN: %clang_cc1 -std=c++20 -verify -Wno-dangling-assignment %s hokein wrote: Done. https://github.com/llvm/llvm-project/pull/97408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [Clang] use const references for function parameters in operator== and operator!= overloads in Redeclarable.h (PR #92963)

2024-07-02 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @kparzysz could you review this PR? https://github.com/llvm/llvm-project/pull/92963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] improve RewriteModernObjC code quality by using const reference for function parameters (PR #93252)

2024-07-02 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @cor3ntin could you review this pr? thanks https://github.com/llvm/llvm-project/pull/93252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][NFC] Add some docs for LazyCompoundValue (PR #97407)

2024-07-02 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat commented: I'm really happy that you decided to document these :smile: https://github.com/llvm/llvm-project/pull/97407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[clang] [analyzer][NFC] Add some docs for LazyCompoundValue (PR #97407)

2024-07-02 Thread Donát Nagy via cfe-commits
@@ -346,6 +352,39 @@ class CompoundVal : public NonLoc { static bool classof(SVal V) { return V.getKind() == CompoundValKind; } }; +/// The simplest example of a concrete compound value is nonloc::CompoundVal, +/// which represents a concrete r-value of an initializer-list o

[clang] [analyzer][NFC] Add some docs for LazyCompoundValue (PR #97407)

2024-07-02 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat edited https://github.com/llvm/llvm-project/pull/97407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][NFC] Add some docs for LazyCompoundValue (PR #97407)

2024-07-02 Thread Donát Nagy via cfe-commits
@@ -346,6 +352,39 @@ class CompoundVal : public NonLoc { static bool classof(SVal V) { return V.getKind() == CompoundValKind; } }; +/// The simplest example of a concrete compound value is nonloc::CompoundVal, +/// which represents a concrete r-value of an initializer-list o

[clang] 72f9bff - Revert "[C2y] Modify diagnostics for complex increment/decrement"

2024-07-02 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2024-07-02T09:18:19-04:00 New Revision: 72f9bff4481bf50c565e3b9dc0a1495264ef4082 URL: https://github.com/llvm/llvm-project/commit/72f9bff4481bf50c565e3b9dc0a1495264ef4082 DIFF: https://github.com/llvm/llvm-project/commit/72f9bff4481bf50c565e3b9dc0a1495264ef4082.diff

[clang] [clang] Don't emit the warn_dangling_lifetime_pointer diagnostic for the assignment case. (PR #97408)

2024-07-02 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 approved this pull request. Thanks. LGTM. https://github.com/llvm/llvm-project/pull/97408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c3079ff - [clang] Don't emit the warn_dangling_lifetime_pointer diagnostic for the assignment case. (#97408)

2024-07-02 Thread via cfe-commits
Author: Haojian Wu Date: 2024-07-02T15:21:06+02:00 New Revision: c3079ffcd34e8ee2faaf7576a69a49acc1a3653f URL: https://github.com/llvm/llvm-project/commit/c3079ffcd34e8ee2faaf7576a69a49acc1a3653f DIFF: https://github.com/llvm/llvm-project/commit/c3079ffcd34e8ee2faaf7576a69a49acc1a3653f.diff LO

[clang] [Clang] use const references for function parameters in operator== and operator!= overloads in Redeclarable.h (PR #92963)

2024-07-02 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. Please explicitly say NFC in the commit title. Otherwise, LGTM https://github.com/llvm/llvm-project/pull/92963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [clang] Don't emit the warn_dangling_lifetime_pointer diagnostic for the assignment case. (PR #97408)

2024-07-02 Thread Haojian Wu via cfe-commits
https://github.com/hokein closed https://github.com/llvm/llvm-project/pull/97408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] use const references for function parameters in operator== and operator!= overloads in Redeclarable.h (PR #92963)

2024-07-02 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/92963 >From 700619984cef3c84c3f818330731f3eb70c6ae82 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Tue, 21 May 2024 22:56:06 +0300 Subject: [PATCH] [Clang][NFC] use const references for function parameters in op

[clang] [Clang][NFC] use const references for function parameters in operator== and operator!= overloads in Redeclarable.h (PR #92963)

2024-07-02 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk edited https://github.com/llvm/llvm-project/pull/92963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] use const references for function parameters in operator== and operator!= overloads in Redeclarable.h (PR #92963)

2024-07-02 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @zyn0217 Thanks. I've added [NCF] to the commit/title. https://github.com/llvm/llvm-project/pull/92963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] improve RewriteModernObjC code quality by using const reference for function parameters (PR #93252)

2024-07-02 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/93252 >From 2033cc94e4b0643e15f2adb26e976feb3578d857 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Fri, 24 May 2024 01:39:35 +0300 Subject: [PATCH] [Clang][NFC] improve RewriteModernObjC code quality by using co

[clang] [Clang][NFC] improve RewriteModernObjC code quality by using const reference for function parameters (PR #93252)

2024-07-02 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk edited https://github.com/llvm/llvm-project/pull/93252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][docs] Move entries around (PR #97416)

2024-07-02 Thread Balazs Benics via cfe-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/97416 Let's just move these under the `Non-comprehensive list of changes in this release` section. Resolves: - https://github.com/llvm/llvm-project/pull/79261#issuecomment-2202950396 - https://github.com/llvm/llvm-p

[clang] [clang][docs] Move entries around (PR #97416)

2024-07-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Balazs Benics (steakhal) Changes Let's just move these under the `Non-comprehensive list of changes in this release` section. Resolves: - https://github.com/llvm/llvm-project/pull/79261#issuecomment-2202950396 - https://github.com/llvm/l

[clang] [Clang][NFC] use const references for function parameters in operator== and operator!= overloads in Redeclarable.h (PR #92963)

2024-07-02 Thread Younan Zhang via cfe-commits
zyn0217 wrote: No problem! Do you need anyone else to help you commit it? https://github.com/llvm/llvm-project/pull/92963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 1e26a25 - [C2y] Modify diagnostics for complex increment/decrement

2024-07-02 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2024-07-02T09:29:23-04:00 New Revision: 1e26a251a36b0479c7aca21e2d65d9877c0691ce URL: https://github.com/llvm/llvm-project/commit/1e26a251a36b0479c7aca21e2d65d9877c0691ce DIFF: https://github.com/llvm/llvm-project/commit/1e26a251a36b0479c7aca21e2d65d9877c0691ce.diff

[clang] [Clang][NFC] use const references for function parameters in operator== and operator!= overloads in Redeclarable.h (PR #92963)

2024-07-02 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @zyn0217 Yes, I do. I don't have access to merge… https://github.com/llvm/llvm-project/pull/92963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] use const references for function parameters in operator== and operator!= overloads in Redeclarable.h (PR #92963)

2024-07-02 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/92963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b48623c - [Clang][NFC] use const references for function parameters in operator== and operator!= overloads in Redeclarable.h (#92963)

2024-07-02 Thread via cfe-commits
Author: Oleksandr T Date: 2024-07-02T21:34:07+08:00 New Revision: b48623c23ae16a424102cc47ad173099bb45a695 URL: https://github.com/llvm/llvm-project/commit/b48623c23ae16a424102cc47ad173099bb45a695 DIFF: https://github.com/llvm/llvm-project/commit/b48623c23ae16a424102cc47ad173099bb45a695.diff L

[clang] [analyzer][docs] Add clang-19 release notes for CSA (PR #97418)

2024-07-02 Thread Balazs Benics via cfe-commits
https://github.com/steakhal milestoned https://github.com/llvm/llvm-project/pull/97418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][docs] Add clang-19 release notes for CSA (PR #97418)

2024-07-02 Thread Balazs Benics via cfe-commits
https://github.com/steakhal created https://github.com/llvm/llvm-project/pull/97418 The day is coming for creating the release branch for clang-19, [scheduled](https://discourse.llvm.org/t/llvm-19-release-schedule-and-planning/79828) for the 23rd of July. Let's start syncing the ReleaseNotes,

[clang] [analyzer][docs] Add clang-19 release notes for CSA (PR #97418)

2024-07-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 @llvm/pr-subscribers-clang Author: Balazs Benics (steakhal) Changes The day is coming for creating the release branch for clang-19, [scheduled](https://discourse.llvm.org/t/llvm-19-release-schedule-and-planning/79828) for the 23

[clang] [analyzer][docs] Add clang-19 release notes for CSA (PR #97418)

2024-07-02 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/97418 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][NFC] use const references for function parameters in operator== and operator!= overloads in Redeclarable.h (PR #92963)

2024-07-02 Thread Oleksandr T. via cfe-commits
a-tarasyuk wrote: @zyn0217 Thanks https://github.com/llvm/llvm-project/pull/92963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][docs] Move entries around (PR #97416)

2024-07-02 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/97416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Add test for export function redeclaration (PR #97370)

2024-07-02 Thread Xiang Li via cfe-commits
https://github.com/python3kgae approved this pull request. https://github.com/llvm/llvm-project/pull/97370 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Run availability diagnostic on exported functions (PR #97352)

2024-07-02 Thread Xiang Li via cfe-commits
https://github.com/python3kgae approved this pull request. https://github.com/llvm/llvm-project/pull/97352 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [UVT] add update-verify-tests.py (PR #97369)

2024-07-02 Thread Nicolai Hähnle via cfe-commits
https://github.com/nhaehnle commented: This is a nice addition, but I think it should follow the conventions established by the existing update_*_test_checks.py scripts as much as possible, at least: * Ability to parse RUN lines, re-execute them autonomously, and modify test files in place ba

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-07-02 Thread Pranav Bhandarkar via cfe-commits
@@ -3088,10 +3102,13 @@ convertOmpTarget(Operation &opInst, llvm::IRBuilderBase &builder, if (!mapData.IsDeclareTarget[i] && !mapData.IsAMember[i]) kernelInput.push_back(mapData.OriginalValue[i]); } + SmallVector dds; + buildDependData(targetOp.getOperation(), mo

[clang] [llvm] [OpenMP] Fix stack corruption due to argument mismatch (PR #96386)

2024-07-02 Thread Shilei Tian via cfe-commits
https://github.com/shiltian approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/96386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 34f701f - Add an explicit triple to the test

2024-07-02 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2024-07-02T09:54:28-04:00 New Revision: 34f701f1d48e4014f62ee09c28669e9f1020ec23 URL: https://github.com/llvm/llvm-project/commit/34f701f1d48e4014f62ee09c28669e9f1020ec23 DIFF: https://github.com/llvm/llvm-project/commit/34f701f1d48e4014f62ee09c28669e9f1020ec23.diff

[clang] [llvm] [mlir] [OMPIRBuilder] - Handle dependencies in `createTarget` (PR #93977)

2024-07-02 Thread Pranav Bhandarkar via cfe-commits
bhandarkar-pranav wrote: @skatrak - I have updated the PR with changes based on your feedback. Could you please take a look? https://github.com/llvm/llvm-project/pull/93977 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [analyzer][NFC] Add some docs for LazyCompoundValue (PR #97407)

2024-07-02 Thread Donát Nagy via cfe-commits
@@ -346,6 +352,39 @@ class CompoundVal : public NonLoc { static bool classof(SVal V) { return V.getKind() == CompoundValKind; } }; +/// The simplest example of a concrete compound value is nonloc::CompoundVal, +/// which represents a concrete r-value of an initializer-list o

[clang] [Clang] [WIP] Added builtin_alloca support for OpenCL1.2 and below (PR #95750)

2024-07-02 Thread Anastasia Stulova via cfe-commits
@@ -6275,13 +6278,46 @@ static FunctionDecl *rewriteBuiltinFunctionDecl(Sema *Sema, ASTContext &Context, OverloadParams.push_back(Context.getPointerType(PointeeType)); } + QualType ReturnTy = FT->getReturnType(); + QualType OverloadReturnTy = ReturnTy; + if (ReturnTy

[clang] [NFC] Add assertion to ensure FiniteMathOnly is in sync with HonorINFs and HonorNANs. (PR #97342)

2024-07-02 Thread Aaron Ballman via cfe-commits
@@ -816,6 +816,11 @@ class FPOptions { setAllowFPReassociate(LO.AllowFPReassoc); setNoHonorNaNs(LO.NoHonorNaNs); setNoHonorInfs(LO.NoHonorInfs); +// Ensure that if FiniteMathOnly is enabled, NoHonorNaNs and NoHonorInfs are +// also enabled. This is because

[clang] 9da86ae - [clang][docs] Move entries around (#97416)

2024-07-02 Thread via cfe-commits
Author: Balazs Benics Date: 2024-07-02T15:58:56+02:00 New Revision: 9da86ae567a1bd46c5aa9fe225d5e7f059a5b03e URL: https://github.com/llvm/llvm-project/commit/9da86ae567a1bd46c5aa9fe225d5e7f059a5b03e DIFF: https://github.com/llvm/llvm-project/commit/9da86ae567a1bd46c5aa9fe225d5e7f059a5b03e.diff

[clang] [clang][docs] Move entries around (PR #97416)

2024-07-02 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/97416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [WIP] Added builtin_alloca support for OpenCL1.2 and below (PR #95750)

2024-07-02 Thread Anastasia Stulova via cfe-commits
@@ -0,0 +1,255 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 %s -O0 -triple amdgcn-amd-amdhsa -cl-std=CL1.2 \ +// RUN: -emit-llvm -o - | FileCheck --check-prefix=OPENCL12 %s +// RUN: %clang_cc1 %s -

[clang] [Clang] [WIP] Added builtin_alloca support for OpenCL1.2 and below (PR #95750)

2024-07-02 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,255 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 %s -O0 -triple amdgcn-amd-amdhsa -cl-std=CL1.2 \ +// RUN: -emit-llvm -o - | FileCheck --check-prefix=OPENCL12 %s +// RUN: %clang_cc1 %s -

[clang] [Clang] [WIP] Added builtin_alloca support for OpenCL1.2 and below (PR #95750)

2024-07-02 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,255 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 5 +// RUN: %clang_cc1 %s -O0 -triple amdgcn-amd-amdhsa -cl-std=CL1.2 \ +// RUN: -emit-llvm -o - | FileCheck --check-prefix=OPENCL12 %s +// RUN: %clang_cc1 %s -

[clang] [analyzer][docs] Add clang-19 release notes for CSA (PR #97418)

2024-07-02 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/97418 >From 69f2b22cf5dc7a3a5b45c00cc867685dc66b397f Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Tue, 2 Jul 2024 15:01:22 +0200 Subject: [PATCH] [analyzer][docs] Add clang-19 release notes for CSA --- clang/d

[clang] [Clang][NFC] improve RewriteModernObjC code quality by using const reference for function parameters (PR #93252)

2024-07-02 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 approved this pull request. https://github.com/llvm/llvm-project/pull/93252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0af2264 - [Clang][NFC] Improve RewriteModernObjC code quality by using const reference for function parameters (#93252)

2024-07-02 Thread via cfe-commits
Author: Oleksandr T Date: 2024-07-02T22:06:04+08:00 New Revision: 0af2264d4e0b0d05b4fc0b5b730ec8d881f384ba URL: https://github.com/llvm/llvm-project/commit/0af2264d4e0b0d05b4fc0b5b730ec8d881f384ba DIFF: https://github.com/llvm/llvm-project/commit/0af2264d4e0b0d05b4fc0b5b730ec8d881f384ba.diff L

[clang] [Clang][NFC] improve RewriteModernObjC code quality by using const reference for function parameters (PR #93252)

2024-07-02 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 closed https://github.com/llvm/llvm-project/pull/93252 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PAC][Driver] Implement `-mbranch-protection=pauthabi` option (PR #97237)

2024-07-02 Thread Peter Smith via cfe-commits
https://github.com/smithp35 edited https://github.com/llvm/llvm-project/pull/97237 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [PAC][Driver] Implement `-mbranch-protection=pauthabi` option (PR #97237)

2024-07-02 Thread Peter Smith via cfe-commits
https://github.com/smithp35 commented: As I understand it we are implicitly defining the default signing schema for ELF platforms with `-mbranch-protection=pauthabi` . Is there any thought on how we want to manage signing schemas going forward? For example I can imagine looking an environment

[clang] [llvm] [PAC][Driver] Implement `-mbranch-protection=pauthabi` option (PR #97237)

2024-07-02 Thread Peter Smith via cfe-commits
@@ -1484,6 +1484,39 @@ void AddUnalignedAccessWarning(ArgStringList &CmdArgs) { } } +static void handlePAuthABIOption(const ArgList &DriverArgs, smithp35 wrote: I think it will be worth a comment above and possibly inline explaining the ABI implications of t

[clang] [llvm] Revert changes in AddDefaultGCCPrefixes() for SystemZTriples. (PR #94729)

2024-07-02 Thread Ulrich Weigand via cfe-commits
uweigand wrote: This `/etc/lsb-release` test looks a bit weird to me. Why can't it simply do: ``` echo ${UNAME_MACHINE}-ibm-linux-${LIBC} ``` like the upstream `config.guess` does? That should properly match the other variants that are simply missing one of the triple fields. https:/

[clang] a0ab0ca - [C2y] Add diagnostics for alignof on an incomplete array

2024-07-02 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2024-07-02T10:34:34-04:00 New Revision: a0ab0ca7a733eb9e8e6442676a974ff8a2cdb930 URL: https://github.com/llvm/llvm-project/commit/a0ab0ca7a733eb9e8e6442676a974ff8a2cdb930 DIFF: https://github.com/llvm/llvm-project/commit/a0ab0ca7a733eb9e8e6442676a974ff8a2cdb930.diff

[clang] [clang][CodeGen] Add query for a target's flat address space (PR #95728)

2024-07-02 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > I still think we should not need this. DefaultIsPrivate is junk that needs to > be deleted. Querying for LangAS::Default should always give the answer 0 for > AMDGPU, which is what this is working around. > > This clang notion of address space has nothing to do with your trou

[clang] [analyzer][NFC] Add some docs for LazyCompoundValue (PR #97407)

2024-07-02 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/97407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][NFC] Add some docs for LazyCompoundValue (PR #97407)

2024-07-02 Thread Balazs Benics via cfe-commits
https://github.com/steakhal commented: Makes sense. It's good to see some love for the docs. https://github.com/llvm/llvm-project/pull/97407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [analyzer][NFC] Add some docs for LazyCompoundValue (PR #97407)

2024-07-02 Thread Balazs Benics via cfe-commits
@@ -326,6 +326,12 @@ class LocAsInteger : public NonLoc { static bool classof(SVal V) { return V.getKind() == LocAsIntegerKind; } }; +/// The simplest example of a concrete compound value is nonloc::CompoundVal, +/// which represents a concrete r-value of an initializer-list

[clang] [analyzer][NFC] Add some docs for LazyCompoundValue (PR #97407)

2024-07-02 Thread Balazs Benics via cfe-commits
@@ -346,6 +352,39 @@ class CompoundVal : public NonLoc { static bool classof(SVal V) { return V.getKind() == CompoundValKind; } }; +/// The simplest example of a concrete compound value is nonloc::CompoundVal, +/// which represents a concrete r-value of an initializer-list o

[clang] Add __builtin_fma16. (PR #97424)

2024-07-02 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam created https://github.com/llvm/llvm-project/pull/97424 None >From 417d72fdd88fddbd843ff3c19681a07e680852c7 Mon Sep 17 00:00:00 2001 From: Zahira Ammarguellat Date: Tue, 2 Jul 2024 07:41:42 -0700 Subject: [PATCH] Add __builtin_fma16. --- clang/include/clang/Basic/

[clang] [llvm] [clang][CodeGen][AMDGPU] Enable AMDGPU `printf` for `spirv64-amd-amdhsa` (PR #97132)

2024-07-02 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu approved this pull request. https://github.com/llvm/llvm-project/pull/97132 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Comments] Attach comments to decl even if preproc directives are in between (PR #88367)

2024-07-02 Thread Dana Jansens via cfe-commits
danakj wrote: `#include` and `#define` at a minimum should break the connection. Comments above a `#define` can be attributed to the macro defined there, which is something that Subdoc does (example result: https://suslib.cc/macro.sus_check.html) https://github.com/llvm/llvm-project/pull/8836

[clang] Add flag to opt out of wasm-opt (PR #95208)

2024-07-02 Thread Dan Gohman via cfe-commits
sunfishcode wrote: @mh4ck-Thales A warning could be useful in some situations, but I also don't know how to navigate the situation with existing users using `-Werror`. @sbc100 I'm open to ideas for how to limit the scope to wasm in some way. https://github.com/llvm/llvm-project/pull/95208

[clang] [clang][docs] Move entries around (PR #97416)

2024-07-02 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: Thank you! https://github.com/llvm/llvm-project/pull/97416 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][ARM] Fix warning for using VFP from interrupts. (PR #91870)

2024-07-02 Thread Chris Copeland via cfe-commits
https://github.com/chrisnc updated https://github.com/llvm/llvm-project/pull/91870 >From d4908fb17a57ddc75032e838241ff4f0e929cd36 Mon Sep 17 00:00:00 2001 From: Chris Copeland Date: Sat, 11 May 2024 00:15:50 -0700 Subject: [PATCH 1/2] [clang][ARM] Fix warning for using VFP from interrupts. Thi

[clang] [clang][ARM] Fix warning for using VFP from interrupts. (PR #91870)

2024-07-02 Thread Chris Copeland via cfe-commits
chrisnc wrote: Fixed more release notes conflicts. https://github.com/llvm/llvm-project/pull/91870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add BinPackBinaryOperations configuration (PR #95013)

2024-07-02 Thread Ameer J via cfe-commits
https://github.com/ameerj updated https://github.com/llvm/llvm-project/pull/95013 >From a50f3d4395efd09eea8ba2e750bb785857f9a550 Mon Sep 17 00:00:00 2001 From: ameerj Date: Mon, 10 Jun 2024 12:09:40 -0400 Subject: [PATCH 01/10] Add BinPackBinaryOperations --- clang/include/clang/Format/Format

[clang] [clang][CodeGen] Add query for a target's flat address space (PR #95728)

2024-07-02 Thread Matt Arsenault via cfe-commits
arsenm wrote: > LangAS::Default is not just determined by target. It also depends on > language. For OpenCL 1.2 it is private. I would have hoped this would be implemented by default assuming a hidden private addrspace qualifier https://github.com/llvm/llvm-project/pull/95728 __

[libclc] [libclc] Fix cross in-tree builds (PR #97392)

2024-07-02 Thread Tom Stellard via cfe-commits
https://github.com/tstellar approved this pull request. https://github.com/llvm/llvm-project/pull/97392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Treat explicit specializations of static data member templates declared without 'static' as static data members when diagnosing uses of 'auto' (PR #97425)

2024-07-02 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian created https://github.com/llvm/llvm-project/pull/97425 After #93873 clang no longer permits declarations of explicit specializations of static data member templates to use the `auto` _placeholder-type-specifier_: ```cpp struct A { template static constexpr aut

[clang] [Clang][Sema] Diagnose variable template explicit specializations with storage-class-specifiers (PR #93873)

2024-07-02 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: > non-static class member @alexfh Missed this one :) Opened a PR to fix this [here](https://github.com/llvm/llvm-project/pull/97425). https://github.com/llvm/llvm-project/pull/93873 ___ cfe-commits mailing list cfe-commits@lists.llv

[libclc] 5ee53d4 - [libclc] Fix cross in-tree builds (#97392)

2024-07-02 Thread via cfe-commits
Author: Harald van Dijk Date: 2024-07-02T16:26:58+01:00 New Revision: 5ee53d417f41e8f452255ded1ff6a522afe17f08 URL: https://github.com/llvm/llvm-project/commit/5ee53d417f41e8f452255ded1ff6a522afe17f08 DIFF: https://github.com/llvm/llvm-project/commit/5ee53d417f41e8f452255ded1ff6a522afe17f08.dif

[libclc] [libclc] Fix cross in-tree builds (PR #97392)

2024-07-02 Thread Harald van Dijk via cfe-commits
https://github.com/hvdijk closed https://github.com/llvm/llvm-project/pull/97392 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Treat explicit specializations of static data member templates declared without 'static' as static data members when diagnosing uses of 'auto' (PR #97425)

2024-07-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Krystian Stasiowski (sdkrystian) Changes After #93873 clang no longer permits declarations of explicit specializations of static data member templates to use the `auto` _placeholder-type-specifier_: ```cpp struct A { template s

[clang] [llvm] [AARCH64][SVE] Add intrinsics for SVE LUTI instructions (PR #97058)

2024-07-02 Thread via cfe-commits
@@ -10349,6 +10349,16 @@ multiclass sve2_luti2_vector_index { let Inst{23-22} = idx{2-1}; let Inst{12}= idx{0}; } + CarolineConcatto wrote: I can see lots of white spaces when I push the patch at the end of: def : SVE_3_Op_Imm_Pat and def : Pat<

[clang] [llvm] [AARCH64][SVE] Add intrinsics for SVE LUTI instructions (PR #97058)

2024-07-02 Thread via cfe-commits
@@ -0,0 +1,336 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py +// REQUIRES: aarch64-registered-target +// RUN: %clang_cc1 -fclang-abi-compat=latest -triple aarch64-none-linux-gnu \ +// RUN: -target-feature +sme -target-feature +sme2 -target-fea

[clang] 46f7929 - Revert "Remove llvm/MC/MCAsmLayout.h"

2024-07-02 Thread Davide Italiano via cfe-commits
Author: Davide Italiano Date: 2024-07-02T08:53:48-07:00 New Revision: 46f7929879a59ec72dc75679b4201e2d314efba9 URL: https://github.com/llvm/llvm-project/commit/46f7929879a59ec72dc75679b4201e2d314efba9 DIFF: https://github.com/llvm/llvm-project/commit/46f7929879a59ec72dc75679b4201e2d314efba9.dif

<    1   2   3   4   >