[clang-tools-extra] [clang-doc][NFC] Fix style guide violations in HTMLGenerator.cpp (PR #96924)

2024-06-27 Thread Petr Hosek via cfe-commits
https://github.com/petrhosek approved this pull request. https://github.com/llvm/llvm-project/pull/96924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-27 Thread Piotr Zegar via cfe-commits
Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heide

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-27 Thread Piotr Zegar via cfe-commits
Paul =?utf-8?q?Heidekr=C3=BCger?= , Paul =?utf-8?q?Heidekr=C3=BCger?= , Paul =?utf-8?q?Heidekr=C3=BCger?= , Paul =?utf-8?q?Heidekr=C3=BCger?= , Paul =?utf-8?q?Heidekr=C3=BCger?= , Paul =?utf-8?q?Heidekr=C3=BCger?= , Paul =?utf-8?q?Heidekr=C3=BCger?= , Paul =?utf-8?q?Heidekr=C3=BCger?= , Paul =?utf-

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-27 Thread Piotr Zegar via cfe-commits
Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heide

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-27 Thread Piotr Zegar via cfe-commits
Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heide

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-27 Thread Piotr Zegar via cfe-commits
Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heide

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-27 Thread Piotr Zegar via cfe-commits
Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heide

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-27 Thread Piotr Zegar via cfe-commits
Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heide

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-27 Thread Piotr Zegar via cfe-commits
Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heide

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-27 Thread Piotr Zegar via cfe-commits
Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heide

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-27 Thread Piotr Zegar via cfe-commits
Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heide

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-27 Thread Piotr Zegar via cfe-commits
Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heide

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-27 Thread Piotr Zegar via cfe-commits
Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heidekrüger?= , Paul =?utf-8?q?Heide

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() [Cont.] (PR #95220)

2024-06-27 Thread Piotr Zegar via cfe-commits
=��___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add wraps attribute (for granular integer overflow handling) (PR #86618)

2024-06-27 Thread Justin Stitt via cfe-commits
https://github.com/JustinStitt updated https://github.com/llvm/llvm-project/pull/86618 >From af16c497b1323983d55f92d6cfb9ab2c99a21639 Mon Sep 17 00:00:00 2001 From: Justin Stitt Date: Tue, 5 Mar 2024 03:14:49 + Subject: [PATCH] implement wraps attribute Signed-off-by: Justin Stitt --- cl

[clang] [clang][CodeGen] Add query for a target's flat address space (PR #95728)

2024-06-27 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/95728 >From 2b500ad9ef2baf27da29146b5a4123dcb75e Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Mon, 17 Jun 2024 02:15:00 +0100 Subject: [PATCH 1/3] Add interface for exposing a target's flat address space, if it

[clang] [flang] [mlir] [flang] Retry add basic -mtune support (PR #96688)

2024-06-27 Thread Andrzej Warzyński via cfe-commits
@@ -0,0 +1,9 @@ +; RUN: mlir-translate -import-llvm -split-input-file %s | FileCheck %s banach-space wrote: I have X86 disabled - I just double checked. And yes, this test works for me just fine without the guard. Alexis, what error do you get when it fails for

[clang-tools-extra] [clang-doc] Improve performance by adding a short circuit (PR #96809)

2024-06-27 Thread via cfe-commits
PeterChou1 wrote: > Second, this requires some more significant testing than is currently present > for clang-doc. Additionally, we'd need to evaluate such an invasive change on > multiple projects, and ensure that the documentation output has not changed > due to this patch. Even then, I'd wo

[clang] Extend -Wnonportable-include-path with a warning about trailing whitespace or dots (PR #96960)

2024-06-27 Thread Tobias Mayer via cfe-commits
https://github.com/tobias-mayer created https://github.com/llvm/llvm-project/pull/96960 Resolves #96064 Extends `-Wnonportable-include-path` with a warning about trailing whitespace or dots in include paths. ![Screenshot from 2024-06-27 22-10-26](https://github.com/llvm/llvm-project/assets/

[clang] Extend -Wnonportable-include-path with a warning about trailing whitespace or dots (PR #96960)

2024-06-27 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] Extend -Wnonportable-include-path with a warning about trailing whitespace or dots (PR #96960)

2024-06-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Tobias Mayer (tobias-mayer) Changes Resolves #96064 Extends `-Wnonportable-include-path` with a warning about trailing whitespace or dots in include paths. ![Screenshot from 2024-06-27 22-10-26](https://github.com/llvm/llvm-project/ass

[clang-tools-extra] f14ad74 - Reapply [clang-doc] Add --asset option to clang-doc (#96358)

2024-06-27 Thread via cfe-commits
Author: PeterChou1 Date: 2024-06-27T13:22:01-07:00 New Revision: f14ad74478494cbd9d23af841d6f6b2808afda71 URL: https://github.com/llvm/llvm-project/commit/f14ad74478494cbd9d23af841d6f6b2808afda71 DIFF: https://github.com/llvm/llvm-project/commit/f14ad74478494cbd9d23af841d6f6b2808afda71.diff LO

[clang-tools-extra] reapply [clang-doc] Add --asset option to clang-doc (PR #96358)

2024-06-27 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/96358 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Improve performance by adding a short circuit (PR #96809)

2024-06-27 Thread Paul Kirth via cfe-commits
@@ -34,13 +43,26 @@ template bool MapASTVisitor::mapDecl(const T *D) { // If there is an error generating a USR for the decl, skip this decl. if (index::generateUSRForDecl(D, USR)) return true; + + // Prevent Visiting USR twice + { +std::lock_guard Guard(USRVisi

[clang] [llvm] [Clang][Coroutines] Introducing the `[[clang::coro_inplace_task]]` attribute (PR #94693)

2024-06-27 Thread Yuxuan Chen via cfe-commits
yuxuanchen1997 wrote: > Should this be discussed in a RFC on discourse? Sure. I can write something up next week. https://github.com/llvm/llvm-project/pull/94693 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] Extend -Wnonportable-include-path with a warning about trailing whitespace or dots (PR #96960)

2024-06-27 Thread Tobias Mayer via cfe-commits
https://github.com/tobias-mayer updated https://github.com/llvm/llvm-project/pull/96960 >From 4118e37219390d8757720e62d0bdf058636d0273 Mon Sep 17 00:00:00 2001 From: Tobias Mayer Date: Thu, 27 Jun 2024 22:04:55 +0200 Subject: [PATCH] add warning about trailing whitespace or dots in include pat

[clang] [NFC] [clang][SPIR-V] Use AMDGPU prefix to avoid confusion (PR #96962)

2024-06-27 Thread Jinsong Ji via cfe-commits
https://github.com/jsji created https://github.com/llvm/llvm-project/pull/96962 Reusing prefix SPIRV64 while adding an useless(and wrong) line AMDGPUSPIRV64 is confusing. Update it by copying SPIRV64 line to AMDGPU line. >From 6779f76293607026f844f4246695a9741b4ea21e Mon Sep 17 00:00:00 2001 F

[clang] [NFC] [clang][SPIR-V] Use AMDGPU prefix to avoid confusion (PR #96962)

2024-06-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Jinsong Ji (jsji) Changes Reusing prefix SPIRV64 while adding an useless(and wrong) line AMDGPUSPIRV64 is confusing. Update it by copying SPIRV64 line to AMDGPU line. --- Full diff: https://github.com/llvm/llvm-project/pull/96962.diff

[clang] [NFC] [clang][SPIR-V] Use AMDGPU prefix to avoid confusion (PR #96962)

2024-06-27 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx requested changes to this pull request. https://github.com/llvm/llvm-project/pull/96962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] [clang][SPIR-V] Use AMDGPU prefix to avoid confusion (PR #96962)

2024-06-27 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx edited https://github.com/llvm/llvm-project/pull/96962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC] [clang][SPIR-V] Use AMDGPU prefix to avoid confusion (PR #96962)

2024-06-27 Thread Alex Voicu via cfe-commits
@@ -270,5 +270,5 @@ // VE: target datalayout = "e-m:e-i64:64-n32:64-S128-v64:64:64-v128:64:64-v256:64:64-v512:64:64-v1024:64:64-v2048:64:64-v4096:64:64-v8192:64:64-v16384:64:64" // RUN: %clang_cc1 -triple spirv64-amd -o - -emit-llvm %s | \ -// RUN: FileCheck %s -check-prefix=

[clang] [NFC] [clang][SPIR-V] Use AMDGPU prefix to avoid confusion (PR #96962)

2024-06-27 Thread Alex Voicu via cfe-commits
@@ -270,5 +270,5 @@ // VE: target datalayout = "e-m:e-i64:64-n32:64-S128-v64:64:64-v128:64:64-v256:64:64-v512:64:64-v1024:64:64-v2048:64:64-v4096:64:64-v8192:64:64-v16384:64:64" // RUN: %clang_cc1 -triple spirv64-amd -o - -emit-llvm %s | \ -// RUN: FileCheck %s -check-prefix=

[clang-tools-extra] [clang-doc][NFC] Fix style guide violations in HTMLGenerator.cpp (PR #96924)

2024-06-27 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/96924 >From 57a0b31b9b3fed6df56c251609076a89e951ef92 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Thu, 27 Jun 2024 09:27:15 -0700 Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?= =?UTF-8

[clang-tools-extra] ecfbb85 - [clang-doc][NFC] Fix style guide violations in HTMLGenerator.cpp

2024-06-27 Thread via cfe-commits
Author: Paul Kirth Date: 2024-06-27T13:46:35-07:00 New Revision: ecfbb8504ed2a92fc145045d2c05f5980405660e URL: https://github.com/llvm/llvm-project/commit/ecfbb8504ed2a92fc145045d2c05f5980405660e DIFF: https://github.com/llvm/llvm-project/commit/ecfbb8504ed2a92fc145045d2c05f5980405660e.diff LO

[clang-tools-extra] [clang-doc][NFC] Fix style guide violations in HTMLGenerator.cpp (PR #96924)

2024-06-27 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi closed https://github.com/llvm/llvm-project/pull/96924 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Improve performance by adding a short circuit (PR #96809)

2024-06-27 Thread via cfe-commits
@@ -34,13 +43,26 @@ template bool MapASTVisitor::mapDecl(const T *D) { // If there is an error generating a USR for the decl, skip this decl. if (index::generateUSRForDecl(D, USR)) return true; + + // Prevent Visiting USR twice + { +std::lock_guard Guard(USRVisi

[clang] [clang-format] Introduce "ReflowComments: IndentOnly" to re-indent comments without breaking internal structure (think Doxygen). (PR #96804)

2024-06-27 Thread Iuri Chaer via cfe-commits
https://github.com/ichaer updated https://github.com/llvm/llvm-project/pull/96804 >From 4c6b2fb52dcfe2ca5ace822ecaf6d0e8ac60f0d7 Mon Sep 17 00:00:00 2001 From: Iuri Chaer Date: Wed, 13 Dec 2023 21:33:05 + Subject: [PATCH 1/3] [clang-format] Introduce "ReflowComments: IndentOnly" to re-inde

[clang] [clang-format] Introduce "ReflowComments: IndentOnly" to re-indent comments without breaking internal structure (think Doxygen). (PR #96804)

2024-06-27 Thread Iuri Chaer via cfe-commits
@@ -3749,24 +3749,47 @@ struct FormatStyle { /// \version 13 ReferenceAlignmentStyle ReferenceAlignment; - // clang-format off - /// If ``true``, clang-format will attempt to re-flow comments. That is it - /// will touch a comment and *reflow* long comments into new lin

[clang] [clang-format] Introduce "ReflowComments: IndentOnly" to re-indent comments without breaking internal structure (think Doxygen). (PR #96804)

2024-06-27 Thread Iuri Chaer via cfe-commits
@@ -493,9 +493,25 @@ TEST_F(FormatTestComments, AlignsBlockComments) { TEST_F(FormatTestComments, CommentReflowingCanBeTurnedOff) { FormatStyle Style = getLLVMStyleWithColumns(20); - Style.ReflowComments = false; - verifyFormat("// a aa aa", Style);

[clang] [NFC] [clang][SPIR-V] Use AMDGPU prefix to avoid confusion (PR #96962)

2024-06-27 Thread Jinsong Ji via cfe-commits
@@ -270,5 +270,5 @@ // VE: target datalayout = "e-m:e-i64:64-n32:64-S128-v64:64:64-v128:64:64-v256:64:64-v512:64:64-v1024:64:64-v2048:64:64-v4096:64:64-v8192:64:64-v16384:64:64" // RUN: %clang_cc1 -triple spirv64-amd -o - -emit-llvm %s | \ -// RUN: FileCheck %s -check-prefix=

[clang] [NFC] [clang][SPIR-V] Use AMDGPU prefix to avoid confusion (PR #96962)

2024-06-27 Thread Jinsong Ji via cfe-commits
https://github.com/jsji edited https://github.com/llvm/llvm-project/pull/96962 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Introduce "ReflowComments: IndentOnly" to re-indent comments without breaking internal structure (think Doxygen). (PR #96804)

2024-06-27 Thread Iuri Chaer via cfe-commits
https://github.com/ichaer updated https://github.com/llvm/llvm-project/pull/96804 >From 4c6b2fb52dcfe2ca5ace822ecaf6d0e8ac60f0d7 Mon Sep 17 00:00:00 2001 From: Iuri Chaer Date: Wed, 13 Dec 2023 21:33:05 + Subject: [PATCH 1/4] [clang-format] Introduce "ReflowComments: IndentOnly" to re-inde

[clang] [NFC] [clang][SPIR-V] Use AMDGPU prefix to avoid confusion (PR #96962)

2024-06-27 Thread Jinsong Ji via cfe-commits
@@ -270,5 +270,5 @@ // VE: target datalayout = "e-m:e-i64:64-n32:64-S128-v64:64:64-v128:64:64-v256:64:64-v512:64:64-v1024:64:64-v2048:64:64-v4096:64:64-v8192:64:64-v16384:64:64" // RUN: %clang_cc1 -triple spirv64-amd -o - -emit-llvm %s | \ -// RUN: FileCheck %s -check-prefix=

[clang] [TBAA] Emit distinct TBAA tags for pointers with different depths,types. (PR #76612)

2024-06-27 Thread Florian Hahn via cfe-commits
@@ -185,10 +185,56 @@ llvm::MDNode *CodeGenTBAA::getTypeInfoHelper(const Type *Ty) { return getChar(); // Handle pointers and references. - // TODO: Implement C++'s type "similarity" and consider dis-"similar" - // pointers distinct. - if (Ty->isPointerType() || Ty->

[clang] [TBAA] Emit distinct TBAA tags for pointers with different depths,types. (PR #76612)

2024-06-27 Thread Florian Hahn via cfe-commits
https://github.com/fhahn edited https://github.com/llvm/llvm-project/pull/76612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [TBAA] Emit distinct TBAA tags for pointers with different depths,types. (PR #76612)

2024-06-27 Thread Florian Hahn via cfe-commits
https://github.com/fhahn commented: > Changes generally LGTM though I think this should come with a release note so > users know about the new command line options and functionality? Thanks, I tried to add release note entries for the new behavior + the new flags. Hope I added them in the righ

[clang] [flang] [llvm] Re-land: "[AArch64] Add ability to list extensions enabled for a target" (#95805) (PR #96795)

2024-06-27 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/96795 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-doc] Improve performance by adding a short circuit (PR #96809)

2024-06-27 Thread Paul Kirth via cfe-commits
@@ -34,13 +43,26 @@ template bool MapASTVisitor::mapDecl(const T *D) { // If there is an error generating a USR for the decl, skip this decl. if (index::generateUSRForDecl(D, USR)) return true; + + // Prevent Visiting USR twice + { +std::lock_guard Guard(USRVisi

[clang] [TBAA] Emit distinct TBAA tags for pointers with different depths,types. (PR #76612)

2024-06-27 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 edited https://github.com/llvm/llvm-project/pull/76612 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [TBAA] Emit distinct TBAA tags for pointers with different depths,types. (PR #76612)

2024-06-27 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 commented: First of all I want to say that this is a really cool project, especially the type sanitizer part. Thanks for working on this! > Just updated the tysan branches again. Unfortunately we aren't yet at a point > where LLVM is `tysan` clean, there is a larg

[clang] [TBAA] Emit distinct TBAA tags for pointers with different depths,types. (PR #76612)

2024-06-27 Thread Nikolas Klauser via cfe-commits
@@ -392,6 +392,10 @@ Non-comprehensive list of changes in this release - ``#pragma GCC diagnostic warning "-Wfoo"`` can now downgrade ``-Werror=foo`` errors and certain default-to-error ``-W`` diagnostics to warnings. +- Clang now emits distinct type-based alias analysis tag

[clang] [Clang] Fix __is_trivially_equality_comparable returning true with ineligebile defaulted overloads (PR #93113)

2024-06-27 Thread Nikolas Klauser via cfe-commits
@@ -1126,9 +1126,6 @@ class QualType { /// Return true if this is a trivially relocatable type. bool isTriviallyRelocatableType(const ASTContext &Context) const; - /// Return true if this is a trivially equality comparable type. - bool isTriviallyEqualityComparableType(c

[clang] [Clang] Fix __is_trivially_equality_comparable returning true with ineligebile defaulted overloads (PR #93113)

2024-06-27 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 updated https://github.com/llvm/llvm-project/pull/93113 >From 3998e9a8e130677f5932b744c0f4487861a54710 Mon Sep 17 00:00:00 2001 From: Nikolas Klauser Date: Thu, 23 May 2024 01:48:06 +0200 Subject: [PATCH] [Clang] Fix __is_trivially_equality_comparable returning tru

[clang] 5b36348 - [Clang] Fix __is_trivially_equality_comparable returning true with ineligebile defaulted overloads (#93113)

2024-06-27 Thread via cfe-commits
Author: Nikolas Klauser Date: 2024-06-27T23:32:33+02:00 New Revision: 5b363483cf2461617fbb2449491c9914811c8d53 URL: https://github.com/llvm/llvm-project/commit/5b363483cf2461617fbb2449491c9914811c8d53 DIFF: https://github.com/llvm/llvm-project/commit/5b363483cf2461617fbb2449491c9914811c8d53.dif

[clang] [Clang] Fix __is_trivially_equality_comparable returning true with ineligebile defaulted overloads (PR #93113)

2024-06-27 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 closed https://github.com/llvm/llvm-project/pull/93113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Implement `export` keyword (PR #96823)

2024-06-27 Thread Justin Bogner via cfe-commits
@@ -851,6 +851,21 @@ Decl *Sema::ActOnStartExportDecl(Scope *S, SourceLocation ExportLoc, CurContext->addDecl(D); PushDeclContext(S, D); + if (getLangOpts().HLSL) { +// exported functions cannot be in an unnamed namespace +for (const DeclContext *DC = CurContext;

[clang] [HLSL] Implement `export` keyword (PR #96823)

2024-06-27 Thread Justin Bogner via cfe-commits
@@ -924,6 +939,23 @@ static bool checkExportedDeclContext(Sema &S, DeclContext *DC, /// Check that it's valid to export \p D. static bool checkExportedDecl(Sema &S, Decl *D, SourceLocation BlockStart) { + // HLSL: export declaration is valid only on functions + if (S.getLan

[clang] [HLSL] Implement `export` keyword (PR #96823)

2024-06-27 Thread Justin Bogner via cfe-commits
@@ -924,6 +939,23 @@ static bool checkExportedDeclContext(Sema &S, DeclContext *DC, /// Check that it's valid to export \p D. static bool checkExportedDecl(Sema &S, Decl *D, SourceLocation BlockStart) { + // HLSL: export declaration is valid only on functions + if (S.getLan

[clang] [llvm] Implement resource binding type prefix mismatch errors (PR #87578)

2024-06-27 Thread Joshua Batista via cfe-commits
https://github.com/bob80905 updated https://github.com/llvm/llvm-project/pull/87578 >From 3960050439964fe3c0536696490b284a6c470cd1 Mon Sep 17 00:00:00 2001 From: Joshua Batista Date: Wed, 3 Apr 2024 13:15:59 -0700 Subject: [PATCH 01/15] implement binding type error for t/cbuffers and rwbuffers

[clang] Improve error message for invalid lambda captures (PR #94865)

2024-06-27 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/94865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Improve error message for invalid lambda captures (PR #94865)

2024-06-27 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. LGTM except that the release note could be a bit more descriptive. https://github.com/llvm/llvm-project/pull/94865 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] Improve error message for invalid lambda captures (PR #94865)

2024-06-27 Thread via cfe-commits
@@ -622,6 +622,8 @@ Improvements to Clang's diagnostics - Clang no longer emits a "declared here" note for a builtin function that has no declaration in source. Fixes #GH93369. +- Clang now has an improved error message when trying to capture a variable for lambda function

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] remove workaround for old CMake when setting `--unwindlib=none` (PR #93429)

2024-06-27 Thread via cfe-commits
https://github.com/h-vetinari updated https://github.com/llvm/llvm-project/pull/93429 >From 8c1b899aa174b107fece1edbf99eaf261bdea516 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Mon, 25 Apr 2022 09:45:22 +0300 Subject: [PATCH 01/11] [runtimes] [CMake] Use CMAKE_REQUIRE

[clang] [C11] Generic selection expressions and qualified rvalues (PR #96913)

2024-06-27 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. Implementation LGTM. https://github.com/llvm/llvm-project/pull/96913 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Introduce 'clang-nvlink-wrappaer' to work around 'nvlink' (PR #96561)

2024-06-27 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 updated https://github.com/llvm/llvm-project/pull/96561 >From 849c8dab14c9332081a8c6331c9ca0c234793393 Mon Sep 17 00:00:00 2001 From: Joseph Huber Date: Mon, 24 Jun 2024 15:14:52 -0500 Subject: [PATCH] [Clang] Introduce 'clang-nvlink-wrappaer' to work around 'nvlink'

[clang] [clang][NFC] Use range-based for loops (PR #96831)

2024-06-27 Thread via cfe-commits
@@ -2056,40 +2056,40 @@ void CXXRecordDecl::completeDefinition() { completeDefinition(nullptr); } +static bool hasPureVirtualFinalOverrider( +const CXXRecordDecl &RD, const CXXFinalOverriderMap *FinalOverriders) { + auto ExistsIn = [](const CXXFinalOverriderMap &FinalOv

[clang] [Clang] Introduce 'clang-nvlink-wrappaer' to work around 'nvlink' (PR #96561)

2024-06-27 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Re-did it and tested it against `libc` in https://github.com/llvm/llvm-project/pull/96972 so it will have a CI running it one that lands. it works for other cases I've tested, but let me know if something else should be added. https://github.com/llvm/llvm-project/pull/96561 __

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] remove workaround for old CMake when setting `--unwindlib=none` (PR #93429)

2024-06-27 Thread via cfe-commits
https://github.com/h-vetinari updated https://github.com/llvm/llvm-project/pull/93429 >From 8c1b899aa174b107fece1edbf99eaf261bdea516 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Mon, 25 Apr 2022 09:45:22 +0300 Subject: [PATCH 01/12] [runtimes] [CMake] Use CMAKE_REQUIRE

[clang] [libc] [llvm] [libc] Implement (v|f)printf on the GPU (PR #96369)

2024-06-27 Thread Michael Jones via cfe-commits
https://github.com/michaelrj-google approved this pull request. LGTM from the libc side https://github.com/llvm/llvm-project/pull/96369 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] remove workaround for old CMake when setting `--unwindlib=none` (PR #93429)

2024-06-27 Thread via cfe-commits
https://github.com/h-vetinari updated https://github.com/llvm/llvm-project/pull/93429 >From 8c1b899aa174b107fece1edbf99eaf261bdea516 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Mon, 25 Apr 2022 09:45:22 +0300 Subject: [PATCH 01/13] [runtimes] [CMake] Use CMAKE_REQUIRE

[libcxx] [libcxxabi] [libunwind] [llvm] [runtimes] remove workaround for old CMake when setting `--unwindlib=none` (PR #93429)

2024-06-27 Thread via cfe-commits
https://github.com/h-vetinari updated https://github.com/llvm/llvm-project/pull/93429 >From 8c1b899aa174b107fece1edbf99eaf261bdea516 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Martin=20Storsj=C3=B6?= Date: Mon, 25 Apr 2022 09:45:22 +0300 Subject: [PATCH 01/14] [runtimes] [CMake] Use CMAKE_REQUIRE

[clang] [Clang] Disallow explicit object parameters in more contexts (PR #89078)

2024-06-27 Thread via cfe-commits
Sirraide wrote: ping https://github.com/llvm/llvm-project/pull/89078 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [C11] Generic selection expressions and qualified rvalues (PR #96913)

2024-06-27 Thread Richard Smith via cfe-commits
zygoloid wrote: > Discussion on the WG14 reflectors suggested that the qualifiers should still > be stripped from the type of the controlling expression; the standard should > be corrected to make this more clear. Does WG14 think we're right to produce a qualified rvalue in this case? Another

[clang] [HLSL] Implement `export` keyword (PR #96823)

2024-06-27 Thread Helena Kotas via cfe-commits
@@ -851,6 +851,21 @@ Decl *Sema::ActOnStartExportDecl(Scope *S, SourceLocation ExportLoc, CurContext->addDecl(D); PushDeclContext(S, D); + if (getLangOpts().HLSL) { +// exported functions cannot be in an unnamed namespace +for (const DeclContext *DC = CurContext;

[clang] [Clang] Extend lifetime bound analysis to support assignments (PR #96475)

2024-06-27 Thread Utkarsh Saxena via cfe-commits
@@ -40,6 +40,12 @@ namespace usage_ok { int *p = A().class_member(); // expected-warning {{temporary whose address is used as value of local variable 'p' will be destroyed at the end of the full-expression}} int *q = A(); // expected-warning {{temporary whose address is us

[clang] [Clang] Extend lifetime bound analysis to support assignments (PR #96475)

2024-06-27 Thread Utkarsh Saxena via cfe-commits
@@ -1053,16 +1072,23 @@ void checkExprLifetime(Sema &SemaRef, const InitializedEntity &Entity, if (pathContainsInit(Path)) return false; -SemaRef.Diag(DiagLoc, diag::warn_dangling_variable) -<< RK << !Entity.getParent() -<< Ex

[clang] [Clang] Extend lifetime bound analysis to support assignments (PR #96475)

2024-06-27 Thread Utkarsh Saxena via cfe-commits
@@ -964,11 +966,26 @@ static bool pathOnlyInitializesGslPointer(IndirectLocalPath &Path) { return false; } -void checkExprLifetime(Sema &SemaRef, const InitializedEntity &Entity, +void checkExprLifetime(Sema &SemaRef, const CheckingEntity &CEntity, E

[clang] [Clang] Fix __is_trivially_equality_comparable returning true with ineligebile defaulted overloads (PR #93113)

2024-06-27 Thread LLVM Continuous Integration via cfe-commits
llvm-ci wrote: LLVM Buildbot has detected a new failure on builder `clang-ppc64be-linux-test-suite` running on `ppc64be-clang-test-suite` while building `clang` at step 7 "test-build-unified-tree-check-runtimes". Full details are available at: https://lab.llvm.org/buildbot/#/builders/176/buil

[clang] [clang] [TargetCXXABI] Fix -Wextra-semi warning (NFC) (PR #96982)

2024-06-27 Thread via cfe-commits
https://github.com/akirchhoff-modular created https://github.com/llvm/llvm-project/pull/96982 While building a downstream project including `TargetCXXABI.h`, I received a `-Wextra-semi` warning. This PR removes the extra semicolon, fixing the warning. >From 7a0572fe3578a6e50462ea38c6198b9525

[clang] [clang] [TargetCXXABI] Fix -Wextra-semi warning (NFC) (PR #96982)

2024-06-27 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (akirchhoff-modular) Changes While building a downstream project including `TargetCXXABI.h`, I received a `-Wextra-semi` warning. This PR removes the extra semicolon, fixing the warning. --- Full diff: https://github.com/llvm/llvm-

[clang] [clang] [TargetCXXABI] Fix -Wextra-semi warning (NFC) (PR #96982)

2024-06-27 Thread Fabian Tschopp via cfe-commits
https://github.com/naibaf7 approved this pull request. https://github.com/llvm/llvm-project/pull/96982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8e1f779 - [clang] [TargetCXXABI] Fix -Wextra-semi warning (NFC) (#96982)

2024-06-27 Thread via cfe-commits
Author: akirchhoff-modular Date: 2024-06-27T15:57:10-07:00 New Revision: 8e1f7793971b5d5b6516146260fe86ec6e0f8c1e URL: https://github.com/llvm/llvm-project/commit/8e1f7793971b5d5b6516146260fe86ec6e0f8c1e DIFF: https://github.com/llvm/llvm-project/commit/8e1f7793971b5d5b6516146260fe86ec6e0f8c1e.

[clang] [clang] [TargetCXXABI] Fix -Wextra-semi warning (NFC) (PR #96982)

2024-06-27 Thread via cfe-commits
https://github.com/akirchhoff-modular closed https://github.com/llvm/llvm-project/pull/96982 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64][NEON] Add intrinsics for LUTI (PR #96883)

2024-06-27 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: To clarify for anyone else looking at this... there are three families of LUTI instructions: one uses NEON registers, one uses SVE registers, and one uses SME registers. This patch is just the variant that uses NEON registers. https://github.com/llvm/llvm-project/pull/968

[clang] [clang][NFC] Use range-based for loops (PR #96831)

2024-06-27 Thread via cfe-commits
https://github.com/MagentaTreehouse updated https://github.com/llvm/llvm-project/pull/96831 >From bdffd46532a1f4356f51b788aba6b9c52672d053 Mon Sep 17 00:00:00 2001 From: Mingyi Chen Date: Wed, 26 Jun 2024 19:21:27 -0400 Subject: [PATCH 1/2] [clang][NFC] Use range-based for loops --- clang/lib

[clang] [NFC] [clang][SPIR-V] Use AMDGPU prefix to avoid confusion (PR #96962)

2024-06-27 Thread Alex Voicu via cfe-commits
@@ -270,5 +270,5 @@ // VE: target datalayout = "e-m:e-i64:64-n32:64-S128-v64:64:64-v128:64:64-v256:64:64-v512:64:64-v1024:64:64-v2048:64:64-v4096:64:64-v8192:64:64-v16384:64:64" // RUN: %clang_cc1 -triple spirv64-amd -o - -emit-llvm %s | \ -// RUN: FileCheck %s -check-prefix=

[clang] [lldb] [llvm] [BOLT][NFC] Move CallGraph from Passes to Core (PR #96922)

2024-06-27 Thread shaw young via cfe-commits
https://github.com/shawbyoung edited https://github.com/llvm/llvm-project/pull/96922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [BOLT][NFC] Move CallGraph from Passes to Core (PR #96922)

2024-06-27 Thread shaw young via cfe-commits
https://github.com/shawbyoung closed https://github.com/llvm/llvm-project/pull/96922 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][AArch64] Move Apple aliases into the CpuAlias map (PR #96249)

2024-06-27 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs updated https://github.com/llvm/llvm-project/pull/96249 >From ee1389a36aac9eecf00513d98cc99787b2cfe17a Mon Sep 17 00:00:00 2001 From: Jon Roelofs Date: Thu, 20 Jun 2024 16:26:45 -0700 Subject: [PATCH 1/4] [llvm][AArch64][TableGen] Create a ProcessorAlias record. NFC

[clang] [llvm] [llvm][AArch64][TableGen] Create a ProcessorAlias record (PR #96249)

2024-06-27 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs edited https://github.com/llvm/llvm-project/pull/96249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][AArch64][TableGen] Create a ProcessorAlias record (PR #96249)

2024-06-27 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs edited https://github.com/llvm/llvm-project/pull/96249 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Add wraps attribute (for granular integer overflow handling) (PR #86618)

2024-06-27 Thread Justin Stitt via cfe-commits
https://github.com/JustinStitt updated https://github.com/llvm/llvm-project/pull/86618 >From 58df542edf7d1a9f65fc804f23a2b209a49f5c5f Mon Sep 17 00:00:00 2001 From: Justin Stitt Date: Tue, 5 Mar 2024 03:14:49 + Subject: [PATCH] implement wraps attribute Signed-off-by: Justin Stitt --- cl

[clang] [HLSL] Implement `export` keyword (PR #96823)

2024-06-27 Thread Helena Kotas via cfe-commits
@@ -924,6 +939,23 @@ static bool checkExportedDeclContext(Sema &S, DeclContext *DC, /// Check that it's valid to export \p D. static bool checkExportedDecl(Sema &S, Decl *D, SourceLocation BlockStart) { + // HLSL: export declaration is valid only on functions + if (S.getLan

[clang] [HLSL] Implement `export` keyword (PR #96823)

2024-06-27 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/96823 >From b67ecd20cc2c11f4f99c2d90c95fdbd988659947 Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Wed, 26 Jun 2024 12:31:39 -0700 Subject: [PATCH 1/3] [HLSL] Implement `export` keyword Fixes #92812 --- .../clang/

[clang] [clang] Implement function pointer type discrimination (PR #96992)

2024-06-27 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak created https://github.com/llvm/llvm-project/pull/96992 Give users an option to sign a function pointer using a non-zero discrimiantor based on the type of the destination. >From cf22a4be007f7e6fdc6e4c17c1f32fa70440b123 Mon Sep 17 00:00:00 2001 From: Akira Hatanaka

[clang] [NFC] [clang][SPIR-V] Use AMDGPU prefix to avoid confusion (PR #96962)

2024-06-27 Thread Jinsong Ji via cfe-commits
https://github.com/jsji updated https://github.com/llvm/llvm-project/pull/96962 >From 6779f76293607026f844f4246695a9741b4ea21e Mon Sep 17 00:00:00 2001 From: Jinsong Ji Date: Thu, 27 Jun 2024 13:33:37 -0700 Subject: [PATCH 1/2] [NFC] [clang][SPIR-V] Use AMDGPU prefix to avoid confusion Reusing

[clang] [NFC] [clang][SPIR-V] Use AMDGPU prefix to avoid confusion (PR #96962)

2024-06-27 Thread Jinsong Ji via cfe-commits
@@ -270,5 +270,5 @@ // VE: target datalayout = "e-m:e-i64:64-n32:64-S128-v64:64:64-v128:64:64-v256:64:64-v512:64:64-v1024:64:64-v2048:64:64-v4096:64:64-v8192:64:64-v16384:64:64" // RUN: %clang_cc1 -triple spirv64-amd -o - -emit-llvm %s | \ -// RUN: FileCheck %s -check-prefix=

[clang] [clang][NFC] Use range-based for loops (PR #96831)

2024-06-27 Thread via cfe-commits
@@ -2056,40 +2056,40 @@ void CXXRecordDecl::completeDefinition() { completeDefinition(nullptr); } +static bool hasPureVirtualFinalOverrider( +const CXXRecordDecl &RD, const CXXFinalOverriderMap *FinalOverriders) { + auto ExistsIn = [](const CXXFinalOverriderMap &FinalOv

[clang] [HLSL] Implement `export` keyword (PR #96823)

2024-06-27 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/96823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][modules] Fix use-after-free in header serialization (PR #96356)

2024-06-27 Thread Volodymyr Sapsai via cfe-commits
vsapsai wrote: Non-representative check for changes in the memory consumption doesn't show anything interesting for the added test case. Maximum resident set size and peak memory footprint with the change and without it are pretty close to each other, no statistic, just eyeballing. My main co

<    1   2   3   4   5   >