https://github.com/jh7370 commented:
I've spent as much time as I can on this today. I've reviewed the code in its
entirety, but still haven't tackled the tests, I'm afraid.
https://github.com/llvm/llvm-project/pull/91280
___
cfe-commits mailing list
@@ -7525,6 +7525,8 @@ def err_explicit_object_parameter_mutable: Error<
def err_invalid_explicit_object_type_in_lambda: Error<
"invalid explicit object parameter type %0 in lambda with capture; "
"the type must be the same as, or derived from, the lambda">;
+def err_explici
DavidTruby wrote:
It looks like `-mcmodel=medium` implies another flag on x86-64 that I haven't
implemented. I will post another patch implementing `-mlarge-data-threshold`
and endeavour to merge that before this patch so that this works on x86-64.
https://github.com/llvm/llvm-project/pull/954
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 93831c73ea51dcf4dc1832a4ea5616b819d36f31
babdee51c4a40a5053ed47846ff57bae2858a21b --e
@@ -59,6 +59,14 @@ static std::string computeDataLayout(const Triple &TT) {
// Data mangling.
Ret += DataLayout::getManglingComponent(TT);
+ // Special features for z/OS.
+ if (TT.isOSzOS()) {
+if (TT.isArch64Bit()) {
zibi2 wrote:
You can collapse t
fhahn wrote:
Thanks, I'll hope to get back to this and make the suggested adjustments soonish
https://github.com/llvm/llvm-project/pull/95004
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
nikic wrote:
It looks like polly needs an update as well.
https://github.com/llvm/llvm-project/pull/94226
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -17,6 +17,8 @@
#define MODULE_PASS(NAME, CREATE_PASS)
#endif
MODULE_PASS("generic-to-nvvm", GenericToNVVMPass())
+MODULE_PASS("expand-variadics",
JonChesterfield wrote:
This shouldn't be necessary, I think. I don't recall whether I removed it from
the amdg
https://github.com/JonChesterfield commented:
With the possible exception of some alignment handling this looks about as I'd
expect it to. Ideally we'd get some feedback from nvptx-associated people but
fixing libc is a good sign
https://github.com/llvm/llvm-project/pull/96015
___
@@ -17,6 +17,8 @@
#define MODULE_PASS(NAME, CREATE_PASS)
#endif
MODULE_PASS("generic-to-nvvm", GenericToNVVMPass())
+MODULE_PASS("expand-variadics",
jhuber6 wrote:
Couldn't remember if adding it to `addIRPasses` applied to all uses. I remember
something like
jhuber6 wrote:
> With the possible exception of some alignment handling this looks about as
> I'd expect it to. Ideally we'd get some feedback from nvptx-associated people
> but fixing libc is a good sign
Yep, I believe @Artem-B is on vacation, so hopefully @AlexMaclean can chime in.
This sho
Sirraide wrote:
Alright, I think this has the behaviour that we want now:
- raw string literals are enabled in C++11 and later, as well as in C in gnuXY
mode;
- raw string literals can be explicitly enabled or disabled in C (and in C++
standards before C++11) using `-f[no-]raw-string-literals`;
https://github.com/zyn0217 created
https://github.com/llvm/llvm-project/pull/96084
Given the following invalid code,
```cpp
template
struct S {
T *a;
};
S s = {1};
```
we produce such diagnostics currently:
```
:2:8: note: candidate template ignored: could not match 'S' against
'int'
2 |
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Younan Zhang (zyn0217)
Changes
Given the following invalid code,
```cpp
template
struct S {
T *a;
};
S s = {1};
```
we produce such diagnostics currently:
```
:2:8: note: candidate template ignored: could not match
'S
https://github.com/kazutakahirata created
https://github.com/llvm/llvm-project/pull/96085
ArrayRef can infer the size of a C array. Also, C arrays can be
implicitly cast to ArrayRef.
>From 62c24545350105e24a5be6334fe7c8075c2a633d Mon Sep 17 00:00:00 2001
From: Kazu Hirata
Date: Wed, 19 Jun 20
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-codegen
Author: Kazu Hirata (kazutakahirata)
Changes
ArrayRef can infer the size of a C array. Also, C arrays can be
implicitly cast to ArrayRef.
---
Full diff: https://github.com/llvm/llvm-project/pull/96085.diff
1 F
Sirraide wrote:
So, apparently, this test here
https://github.com/llvm/llvm-project/blob/cb76896d6e45e2c9b7ef5e47b6ec37aeca43f7a8/clang/unittests/Lex/DependencyDirectivesScannerTest.cpp#L586-L589
is now failing, presumably because of this:
https://github.com/llvm/llvm-project/blob/cb76896d6e45
zyn0217 wrote:
(A screenshot that helps to understand the changes here)

(compared to what we have now and what GCC gives:
https://godbolt.org/z/948M7x7fE)
https://github.com/llvm/llvm-project/pu
mizvekov wrote:
After we fork for clang-20, we can entirely remove
`frelaxed-template-template-args`, and so won't need to worry about testing
that non-conforming mode. Would it be reasonable to postpone that until then?
https://github.com/llvm/llvm-project/p
https://github.com/Sirraide requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/96085
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
SLTozer wrote:
Alright, builds now working for LLVM, Clang, Flang, Polly, and MLIR; looks good
to merge?
https://github.com/llvm/llvm-project/pull/94226
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
https://github.com/jtb20 updated https://github.com/llvm/llvm-project/pull/92731
>From d83105c32a48d73fe547523841a115d6863f7799 Mon Sep 17 00:00:00 2001
From: Julian Brown
Date: Wed, 1 May 2024 06:35:59 -0500
Subject: [PATCH] [OpenMP] OpenMP 5.1 "assume" directive parsing support
This is a mini
https://github.com/jtb20 created https://github.com/llvm/llvm-project/pull/96087
This patch adds a diagnostic which attempts to detect the case where the
"collapse" clause is used with imperfectly-nested parallel loops, something
like this:
#pragma omp target
#pragma omp parallel for colla
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-llvm-transforms
@llvm/pr-subscribers-clang
Author: Julian Brown (jtb20)
Changes
This patch adds a diagnostic which attempts to detect the case where the
"collapse" clause is used with imperfectly-nested parallel loops, something
like this:
#pragma o
Sirraide wrote:
I will say, one worry that I do have is that this would end up issuing... a lot
of notes for a single error:

C++ error messages already have a reputation of being rather long; I’
https://github.com/Sirraide approved this pull request.
Thanks, the comments are pretty much exactly what I had in mind.
https://github.com/llvm/llvm-project/pull/95846
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/shiltian commented:
don't you need more code in AST?
https://github.com/llvm/llvm-project/pull/92731
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits