https://github.com/ChuanqiXu9 closed
https://github.com/llvm/llvm-project/pull/75912
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Chuanqi Xu
Date: 2024-06-17T10:25:35+08:00
New Revision: 15bb02650e26875c48889053d6a9697444583721
URL:
https://github.com/llvm/llvm-project/commit/15bb02650e26875c48889053d6a9697444583721
DIFF:
https://github.com/llvm/llvm-project/commit/15bb02650e26875c48889053d6a9697444583721.diff
LO
https://github.com/HerrCai0907 created
https://github.com/llvm/llvm-project/pull/95729
Fixes: #95658
Unqualified canonical type should be used instead of normal QualType for type
equality comparison
>From 40f18f2be624ed2a5b4922e67e4ed6070d2d2400 Mon Sep 17 00:00:00 2001
From: Congcong Cai
Da
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Congcong Cai (HerrCai0907)
Changes
Fixes: #95658
Unqualified canonical type should be used instead of normal QualType for type
equality comparison
---
Full diff: https://github.com/llvm/llvm-project/pull/95729.diff
2 Files Affected:
-
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Congcong Cai (HerrCai0907)
Changes
Fixes: #95658
Unqualified canonical type should be used instead of normal QualType for type
equality comparison
---
Full diff: https://github.com/llvm/llvm-project/pull/95729.diff
2
ChuanqiXu9 wrote:
Thanks for the patch. I like it in the very high level. I did a quick scanning
over the PR and here is some comments:
- I feel the name containing `concurrency` is not proper. I don't feel it
relates concurrency in any level.
- Every time we add or change IR related to corou
ChuanqiXu9 wrote:
Then we can find that the frontend part is much more complex and harder than
the middle end part. So maybe we can introduce the middle end part first and
introduce a not so powerful attribute but introducing a function and statement
level attribute `must_elide` in the beginn
https://github.com/shiltian updated
https://github.com/llvm/llvm-project/pull/94830
>From 15ed0af5f5d23213fd4c10ff704ac26bb1b80030 Mon Sep 17 00:00:00 2001
From: Shilei Tian
Date: Sun, 16 Jun 2024 23:07:29 -0400
Subject: [PATCH] [Clang][AMDGPU] Add a new builtin type for buffer rsrc
---
clang
https://github.com/ChuanqiXu9 created
https://github.com/llvm/llvm-project/pull/95730
See the comment:
https://github.com/llvm/llvm-project/pull/92083#issuecomment-2168121729
After the patch, https://github.com/llvm/llvm-project/pull/92083, the lower 32
bits of DeclID can be the same commonly.
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Chuanqi Xu (ChuanqiXu9)
Changes
See the comment:
https://github.com/llvm/llvm-project/pull/92083#issuecomment-2168121729
After the patch, https://github.com/llvm/llvm-project/pull/92083, the lower 32
bits of DeclID can be the same commonl
https://github.com/ChuanqiXu9 edited
https://github.com/llvm/llvm-project/pull/95730
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yuxuanchen1997 wrote:
Thanks for the feedback. This patch is the first iteration to model this idea
as quickly as I can. In general I agree with your comments
> * I feel the name containing `concurrency` is not proper
The name is bikesheddable as always. I was also thinking around the line of
yuxuanchen1997 wrote:
Thanks for the feedback. This patch is the first iteration to model this idea
as quickly as I can. In general, I agree with your comments.
> * I feel the name containing `concurrency` is not proper
The name is bikesheddable as always. I was also thinking around the line
yuxuanchen1997 wrote:
> What I prefer is to add a middle end function attribute (must-coro-elide) and
> apply this attribute and (always inline attribute) to the calls:
Actually this might be problematic. The same coroutine called in different
contexts (e.g. one coroutine that is also attribut
ChuanqiXu9 wrote:
> Thanks for the feedback. This patch is the first iteration to model this idea
> as quickly as I can. In general, I agree with your comments.
>
> > * I feel the name containing `concurrency` is not proper
>
> The name is bikesheddable as always. I was also thinking around th
ChuanqiXu9 wrote:
> Thanks for the feedback. This patch is the first iteration to model this idea
> as quickly as I can. In general, I agree with your comments.
>
> > * I feel the name containing `concurrency` is not proper
>
> The name is bikesheddable as always. I was also thinking around th
https://github.com/steakhal commented:
Awesome. I have one remark though.
It would be nice to see tests that does not depend on the errno, as this
eqclass merging is a major vore feature, unlike the errno modeling which is an
optional feature. If have something in mind, you could add that test
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/95712
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -15,9 +15,12 @@
#include "support/Context.h"
#include "llvm/ADT/StringRef.h"
#include "llvm/Support/ScopedPrinter.h"
+#include "llvm/Support/raw_ostream.h"
#include "gmock/gmock.h"
#include "gtest/gtest.h"
+#include
#include
+#include
zyn0217 wrote:
W
https://github.com/zyn0217 commented:
My two cents:
While I appreciate the value of inspecting more semantic information about
lambdas, I still have mixed feelings about user experience.
Admittedly, presenting implicitly captured variables provides users with
insight into ODR-used variables,
@@ -755,12 +807,34 @@ class InlayHintVisitor : public
RecursiveASTVisitor {
bool NameHint = shouldHintName(Args[I], Name);
bool ReferenceHint = shouldHintReference(Params[I], ForwardedParams[I]);
+ bool IsDefault = isa(Args[I]);
+ HasNonDefaultArgs |= !I
@@ -372,6 +382,34 @@ maybeDropCxxExplicitObjectParameters(ArrayRef Params) {
return Params;
}
+llvm::StringRef getLambdaCaptureName(const LambdaCapture &Capture) {
+ if (Capture.capturesVariable())
+return Capture.getCapturedVar()->getName();
+ if (Capture.capturesThis
@@ -1568,7 +1626,7 @@ TEST(TypeHints, SubstTemplateParameterAliases) {
)cpp";
llvm::StringRef VectorIntPtr = R"cpp(
-vector array;
+vector $init[[array]];
zyn0217 wrote:
Will the range ever be used somewhere?
https://github.com/llvm/llvm-project/
@@ -504,10 +503,10 @@ struct FragmentCompiler {
auto Fast = isFastTidyCheck(Str);
if (!Fast.has_value()) {
diag(Warning,
- llvm::formatv(
- "Latency of clang-tidy check '{0}' is not known. "
- "It will only run if
@@ -281,7 +281,7 @@ struct TextDocumentEdit {
/// The text document to change.
VersionedTextDocumentIdentifier textDocument;
- /// The edits to be applied.
+ /// The edits to be applied.
zyn0217 wrote:
Ditto. Unrelated blank changes. Please revert
@@ -1458,13 +1463,66 @@ TEST(TypeHints, DefaultTemplateArgs) {
struct A {};
A foo();
auto $var[[var]] = foo();
-A bar[1];
+A baz;
+A bar[1]{};
zyn0217 wrote:
Why there's an empty initializer? Can you revert it?
https://github.com/llvm/
@@ -372,6 +382,34 @@ maybeDropCxxExplicitObjectParameters(ArrayRef Params) {
return Params;
}
+llvm::StringRef getLambdaCaptureName(const LambdaCapture &Capture) {
+ if (Capture.capturesVariable())
+return Capture.getCapturedVar()->getName();
+ if (Capture.capturesThis
@@ -0,0 +1,65 @@
+; RUN: llc -stop-after=amdgpu-isel -mtriple=amdgcn-- -mcpu=gfx1100
-verify-machineinstrs -o - %s | FileCheck --check-prefixes=CHECK,ISEL %s
+
+; CHECK-LABEL: name:basic_readfirstlane_i64
+; CHECK:[[TOKEN:%[0-9]+]]{{[^ ]*}} = CONVERGENCECTRL
@@ -230,7 +230,11 @@ template <> struct DenseMapInfo {
}
static unsigned getHashValue(const GlobalDeclID &Key) {
-return DenseMapInfo::getHashValue(Key.get());
+// Our default hash algorithm for 64 bits integer may not be very good.
+// In GlobalDeclID's case,
vikramRH wrote:
@yuanfang-chen , @AaronBallman, @shafik, are we still actively looking into
this ? (I would be willing to commandeer this if its not high on your priority
list)
https://github.com/llvm/llvm-project/pull/72607
___
cfe-commits mailing
yuanfang-chen wrote:
Hello @vikramRH, please feel free to commandeer this.
https://github.com/llvm/llvm-project/pull/72607
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Daniel Kiss
Date: 2024-06-17T08:48:53+02:00
New Revision: 5fe7f7364abcabe34f9bf157e5e6a6fa4fa0248a
URL:
https://github.com/llvm/llvm-project/commit/5fe7f7364abcabe34f9bf157e5e6a6fa4fa0248a
DIFF:
https://github.com/llvm/llvm-project/commit/5fe7f7364abcabe34f9bf157e5e6a6fa4fa0248a.diff
L
https://github.com/DanielKristofKiss closed
https://github.com/llvm/llvm-project/pull/94271
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
101 - 133 of 133 matches
Mail list logo
