[clang] [llvm] [llvm][Support] Stop using PWD in current_path (PR #94544)

2024-06-11 Thread Iñaki Amatria Barral via cfe-commits
https://github.com/inaki-amatria edited https://github.com/llvm/llvm-project/pull/94544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ConstantFold] Drop gep of gep fold entirely (PR #95126)

2024-06-11 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/95126 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [CMake][libclc] Improve dependencies to avoid build errors (PR #95018)

2024-06-11 Thread Tim Creech via cfe-commits
https://github.com/tcreech-intel updated https://github.com/llvm/llvm-project/pull/95018 >From 3e85695cc62abf8fe0943421708b5db67750b4ea Mon Sep 17 00:00:00 2001 From: Tim Creech Date: Mon, 10 Jun 2024 11:07:55 -0400 Subject: [PATCH 1/2] [libclc] Improve dependencies to avoid build errors With

[clang] [Clang][AMDGPU] Add a new builtin type for buffer rsrc (PR #94830)

2024-06-11 Thread Shilei Tian via cfe-commits
shiltian wrote: > how does a user initialize/populate this type of objects? by calling a > builtin function? yes. The builtin functions will come next. https://github.com/llvm/llvm-project/pull/94830 ___ cfe-commits mailing list cfe-commits@lists.llv

[clang] [llvm] [llvm][Support] Stop using PWD in current_path (PR #94544)

2024-06-11 Thread Iñaki Amatria Barral via cfe-commits
https://github.com/inaki-amatria edited https://github.com/llvm/llvm-project/pull/94544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][Support] Stop using PWD in current_path (PR #94544)

2024-06-11 Thread Iñaki Amatria Barral via cfe-commits
https://github.com/inaki-amatria edited https://github.com/llvm/llvm-project/pull/94544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [llvm][Support] Stop using PWD in current_path (PR #94544)

2024-06-11 Thread Iñaki Amatria Barral via cfe-commits
https://github.com/inaki-amatria edited https://github.com/llvm/llvm-project/pull/94544 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libclc] [CMake][libclc] Improve dependencies to avoid build errors (PR #95018)

2024-06-11 Thread Tim Creech via cfe-commits
tcreech-intel wrote: Yes, the article you link to is highly relevant. Without this PR we're hitting the problem described in example #4. We can promote the issue to a build failure by choosing a custom command which can't run concurrently with itself: ```cmake cmake_minimum_required(VERSION 3.

[libclc] [CMake][libclc] Improve dependencies to avoid build errors (PR #95018)

2024-06-11 Thread Tim Creech via cfe-commits
https://github.com/tcreech-intel edited https://github.com/llvm/llvm-project/pull/95018 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Return RValue from `EmitVAArg` (PR #94635)

2024-06-11 Thread Mariya Podchishchaeva via cfe-commits
@@ -2161,6 +2161,19 @@ static RValue EmitLoadOfMatrixLValue(LValue LV, SourceLocation Loc, return RValue::get(CGF.EmitLoadOfScalar(LV, Loc)); } +RValue CodeGenFunction::EmitLoadOfAnyValue(LValue LV, SourceLocation Loc) { + QualType Ty = LV.getType(); + switch (getEvaluati

[clang] [clang-format] Add BinPackBinaryOperations configuration (PR #95013)

2024-06-11 Thread Ameer J via cfe-commits
@@ -1203,6 +1214,10 @@ unsigned ContinuationIndenter::addTokenOnNewLine(LineState &State, } } + if (!Style.BinPackBinaryOperations && Previous.is(TT_BinaryOperator) && + (Previous.getPrecedence() > prec::Conditional)) { +CurrentState.BreakBeforeParameter = tru

[clang] [clang-format] Add BinPackBinaryOperations configuration (PR #95013)

2024-06-11 Thread Ameer J via cfe-commits
https://github.com/ameerj updated https://github.com/llvm/llvm-project/pull/95013 >From a50f3d4395efd09eea8ba2e750bb785857f9a550 Mon Sep 17 00:00:00 2001 From: ameerj Date: Mon, 10 Jun 2024 12:09:40 -0400 Subject: [PATCH 1/6] Add BinPackBinaryOperations --- clang/include/clang/Format/Format.h

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-11 Thread via cfe-commits
https://github.com/Sirraide approved this pull request. Two last comments, but other than that this LGTM. https://github.com/llvm/llvm-project/pull/94159 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-11 Thread via cfe-commits
@@ -0,0 +1,49 @@ +// RUN: %clang_cc1 -std=c++23 -fsyntax-only -verify %s + +struct S { + void f() { +++this; // expected-error {{expression is not assignable}} +// expected-note@-1 {{add '*' to dereference it}} + } + + void g() const { +++this; // expected-error {{e

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-11 Thread via cfe-commits
@@ -13273,6 +13273,22 @@ enum { ConstUnknown, // Keep as last element }; +static void MaybeSuggestDerefFixIt(Sema &S, const Expr *E, SourceLocation Loc) { + ExprResult Deref; + Expr *TE = const_cast(E); + { +Sema::TentativeAnalysisScope Trap(S); +Deref = S.ActOn

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-11 Thread via cfe-commits
@@ -0,0 +1,49 @@ +// RUN: %clang_cc1 -std=c++23 -fsyntax-only -verify %s + +struct S { + void f() { +++this; // expected-error {{expression is not assignable}} +// expected-note@-1 {{add '*' to dereference it}} + } + + void g() const { +++this; // expected-error {{e

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-11 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/94159 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-11 Thread via cfe-commits
https://github.com/Sirraide edited https://github.com/llvm/llvm-project/pull/94159 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Add -mlink-builtin-bitcode option to fc1 (PR #94763)

2024-06-11 Thread via cfe-commits
https://github.com/agozillon approved this pull request. LGTM, but please do wait on the other more knowledgeable reviewers approvals :-) https://github.com/llvm/llvm-project/pull/94763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [llvm] [RISCV] Add Smcsrind and Sscsrind extension (PR #93952)

2024-06-11 Thread via cfe-commits
YanWQ-monad wrote: ping? https://github.com/llvm/llvm-project/pull/93952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] 1c59362 - [clangd] Make it possible to enable misc-const-correctness clang-tidy check (#94920)

2024-06-11 Thread via cfe-commits
Author: geza-herman Date: 2024-06-11T13:32:12-04:00 New Revision: 1c59362e4456fb0861fcf4be9831b4db3e921b2b URL: https://github.com/llvm/llvm-project/commit/1c59362e4456fb0861fcf4be9831b4db3e921b2b DIFF: https://github.com/llvm/llvm-project/commit/1c59362e4456fb0861fcf4be9831b4db3e921b2b.diff L

[clang-tools-extra] [clangd] Make it possible to enable misc-const-correctness clang-tidy check (PR #94920)

2024-06-11 Thread Nathan Ridge via cfe-commits
https://github.com/HighCommander4 closed https://github.com/llvm/llvm-project/pull/94920 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Make it possible to enable misc-const-correctness clang-tidy check (PR #94920)

2024-06-11 Thread via cfe-commits
github-actions[bot] wrote: @geza-herman Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bu

[clang] [llvm] [WebAssembly] Implement f16x8 madd and nmadd instructions. (PR #95151)

2024-06-11 Thread Brendan Dahl via cfe-commits
https://github.com/brendandahl created https://github.com/llvm/llvm-project/pull/95151 Implemented with intrinsics and builtins. Specified at: https://github.com/WebAssembly/half-precision/blob/main/proposals/half-precision/Overview.md >From fd5ea6036e97e504e3286d218fe6b966e5bead82 Mon Sep 17

[clang] [llvm] [WebAssembly] Implement f16x8 madd and nmadd instructions. (PR #95151)

2024-06-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Brendan Dahl (brendandahl) Changes Implemented with intrinsics and builtins. Specified at: https://github.com/WebAssembly/half-precision/blob/main/proposals/half-precision/Overview.md --- Full diff: https://github.com/llvm/llvm-pr

[clang] [llvm] [WebAssembly] Implement f16x8 madd and nmadd instructions. (PR #95151)

2024-06-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-webassembly Author: Brendan Dahl (brendandahl) Changes Implemented with intrinsics and builtins. Specified at: https://github.com/WebAssembly/half-precision/blob/main/proposals/half-precision/Overview.md --- Full diff: https://github.com/llvm/l

[clang] [flang] [flang] Add -mlink-builtin-bitcode option to fc1 (PR #94763)

2024-06-11 Thread Mats Petersson via cfe-commits
@@ -0,0 +1,15 @@ +! Test -mlink-builtin-bitcode flag +! RUN: %flang -emit-llvm -c -o %t.bc %S/Inputs/libfun.f90 +! RUN: %flang_fc1 -emit-llvm -o - -mlink-builtin-bitcode %t.bc %s 2>&1 | FileCheck %s + +! CHECK: define internal void @libfun_ + +! RUN: not %flang_fc1 -emit-llvm -tr

[clang] [flang] [flang] Add -mlink-builtin-bitcode option to fc1 (PR #94763)

2024-06-11 Thread Mats Petersson via cfe-commits
https://github.com/Leporacanthicus edited https://github.com/llvm/llvm-project/pull/94763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [flang] Add -mlink-builtin-bitcode option to fc1 (PR #94763)

2024-06-11 Thread Mats Petersson via cfe-commits
https://github.com/Leporacanthicus commented: Nit-pick, otherwise OK by me. https://github.com/llvm/llvm-project/pull/94763 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [WebAssembly] Implement f16x8 madd and nmadd instructions. (PR #95151)

2024-06-11 Thread Brendan Dahl via cfe-commits
brendandahl wrote: Note: I've [opened an issue](https://github.com/WebAssembly/half-precision/issues/5) about the `relaxed_` prefix and whether it should be included in the instruction name. https://github.com/llvm/llvm-project/pull/95151 ___ cfe-com

[clang] [clang][CodeGen] Return RValue from `EmitVAArg` (PR #94635)

2024-06-11 Thread John McCall via cfe-commits
https://github.com/rjmccall edited https://github.com/llvm/llvm-project/pull/94635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Return RValue from `EmitVAArg` (PR #94635)

2024-06-11 Thread John McCall via cfe-commits
@@ -2161,6 +2161,21 @@ static RValue EmitLoadOfMatrixLValue(LValue LV, SourceLocation Loc, return RValue::get(CGF.EmitLoadOfScalar(LV, Loc)); } +RValue CodeGenFunction::EmitLoadOfAnyValue(LValue LV, AggValueSlot Slot, + SourceLocati

[clang] [clang][CodeGen] Return RValue from `EmitVAArg` (PR #94635)

2024-06-11 Thread John McCall via cfe-commits
https://github.com/rjmccall commented: Other than the one slight nit (that I think may be irrelevant), this LGTM. I'd like @efriedma-quic to also do a quick review if he has time, though. https://github.com/llvm/llvm-project/pull/94635 ___ cfe-commit

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() (PR #90043)

2024-06-11 Thread Carlos Galvez via cfe-commits
carlosgalvezp wrote: > I don't think it is a good solution. Can you elaborate? As I wrote above, the C++ Core Guidelines do not require using `at()`. Therefore the check would be doing something different than what the guidelines require. The reason they don't require it is that there's multi

[clang] [llvm] [RISCV] Add Smcsrind and Sscsrind extension (PR #93952)

2024-06-11 Thread Craig Topper via cfe-commits
topperc wrote: We don't implement all the CSRs. We're missing mireg2-6, sireg2-6, and vsireg2-6 https://github.com/llvm/llvm-project/pull/93952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-

[clang] [llvm] [AArch64][SME] Save VG for unwind info when changing streaming-mode (PR #83301)

2024-06-11 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/83301 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 9b4f8ac - [clang] Fix a few comment typos to cycle bots

2024-06-11 Thread Nico Weber via cfe-commits
Author: Nico Weber Date: 2024-06-11T14:00:24-04:00 New Revision: 9b4f8acf9dd1cd517f923c6de8274eed80879f6c URL: https://github.com/llvm/llvm-project/commit/9b4f8acf9dd1cd517f923c6de8274eed80879f6c DIFF: https://github.com/llvm/llvm-project/commit/9b4f8acf9dd1cd517f923c6de8274eed80879f6c.diff LO

[clang] [HLSL] Fix FileCheck annotation typos (PR #95155)

2024-06-11 Thread Justin Bogner via cfe-commits
https://github.com/bogner created https://github.com/llvm/llvm-project/pull/95155 These are the HLSL specific fixes from #93193. Thanks @klensy! >From ef5fbb85ba550c1baefc6357e118f339e6d7d5bd Mon Sep 17 00:00:00 2001 From: Justin Bogner Date: Tue, 11 Jun 2024 10:48:30 -0700 Subject: [PATCH] [H

[clang] [HLSL] Fix FileCheck annotation typos (PR #95155)

2024-06-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Justin Bogner (bogner) Changes These are the HLSL specific fixes from #93193. Thanks @klensy! --- Full diff: https://github.com/llvm/llvm-project/pull/95155.diff 2 Files Affected: - (modified) clang/test/CodeGenHLSL/convergence/for.hlsl

[clang] [HLSL] Fix FileCheck annotation typos (PR #95155)

2024-06-11 Thread David Peixotto via cfe-commits
@@ -4,9 +4,8 @@ void test() { // CHECK: VarDecl {{.*}} used f3 'vector':'float __attribute__((ext_vector_type(3)))' cinit - // CHECK-NEXt: ImplicitCastExpr {{.*}} 'vector':'float __attribute__((ext_vector_type(3)))' - // CHECK-NEXt: ImplicitCastExpr {{.*}} 'float' -

[clang] [llvm] [WebAssembly] Implement f16x8 madd and nmadd instructions. (PR #95151)

2024-06-11 Thread Derek Schuff via cfe-commits
https://github.com/dschuff approved this pull request. https://github.com/llvm/llvm-project/pull/95151 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Return RValue from `EmitVAArg` (PR #94635)

2024-06-11 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic edited https://github.com/llvm/llvm-project/pull/94635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Return RValue from `EmitVAArg` (PR #94635)

2024-06-11 Thread Eli Friedman via cfe-commits
@@ -325,14 +325,19 @@ Address SparcV9ABIInfo::EmitVAArg(CodeGenFunction &CGF, Address VAListAddr, break; case ABIArgInfo::Ignore: -return Address(llvm::UndefValue::get(ArgPtrTy), ArgTy, TypeInfo.Align); +return CGF.EmitLoadOfAnyValue( +CGF.MakeAddrLValue

[clang] [clang][CodeGen] Return RValue from `EmitVAArg` (PR #94635)

2024-06-11 Thread Eli Friedman via cfe-commits
@@ -789,27 +791,37 @@ Address AArch64ABIInfo::EmitAAPCSVAArg(Address VAListAddr, QualType Ty, OnStackBlock, "vaargs.addr"); if (IsIndirect) -return Address(CGF.Builder.CreateLoad(ResAddr, "vaarg.addr"), ElementTy, - TyA

[clang] [clang][CodeGen] Return RValue from `EmitVAArg` (PR #94635)

2024-06-11 Thread Eli Friedman via cfe-commits
@@ -102,12 +98,7 @@ char *test_ptr(char *fmt, ...) { // N32: [[TMP2:%.+]] = load i64, ptr [[AP_CUR]], align 8 // N32: [[TMP3:%.+]] = trunc i64 [[TMP2]] to i32 // N32: [[PTR:%.+]] = inttoptr i32 [[TMP3]] to ptr -// N32: store ptr [[PTR]], ptr [[AP_CAST]], align 4 -// N32

[clang] [clang][CodeGen] Return RValue from `EmitVAArg` (PR #94635)

2024-06-11 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic commented: This generally seems fine. https://github.com/llvm/llvm-project/pull/94635 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Return RValue from `EmitVAArg` (PR #94635)

2024-06-11 Thread Eli Friedman via cfe-commits
@@ -4777,6 +4783,13 @@ class CodeGenFunction : public CodeGenTypeCache { /// aggregate type into a temporary LValue. LValue EmitAggExprToLValue(const Expr *E); + enum ExprValueKind { EVK_RValue, EVK_NonRValue }; + + /// EmitAggFinalDestCopy - Emit copy of the specified a

[clang] [clang][CodeGen] Return RValue from `EmitVAArg` (PR #94635)

2024-06-11 Thread John McCall via cfe-commits
@@ -789,27 +791,37 @@ Address AArch64ABIInfo::EmitAAPCSVAArg(Address VAListAddr, QualType Ty, OnStackBlock, "vaargs.addr"); if (IsIndirect) -return Address(CGF.Builder.CreateLoad(ResAddr, "vaarg.addr"), ElementTy, - TyA

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-11 Thread Rajveer Singh Bharadwaj via cfe-commits
@@ -13273,6 +13273,22 @@ enum { ConstUnknown, // Keep as last element }; +static void MaybeSuggestDerefFixIt(Sema &S, const Expr *E, SourceLocation Loc) { + ExprResult Deref; + Expr *TE = const_cast(E); + { +Sema::TentativeAnalysisScope Trap(S); +Deref = S.ActOn

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-11 Thread Rajveer Singh Bharadwaj via cfe-commits
@@ -0,0 +1,49 @@ +// RUN: %clang_cc1 -std=c++23 -fsyntax-only -verify %s + +struct S { + void f() { +++this; // expected-error {{expression is not assignable}} +// expected-note@-1 {{add '*' to dereference it}} + } + + void g() const { +++this; // expected-error {{e

[clang] [HLSL] Fix FileCheck annotation typos (PR #95155)

2024-06-11 Thread via cfe-commits
@@ -4,9 +4,8 @@ void test() { // CHECK: VarDecl {{.*}} used f3 'vector':'float __attribute__((ext_vector_type(3)))' cinit - // CHECK-NEXt: ImplicitCastExpr {{.*}} 'vector':'float __attribute__((ext_vector_type(3)))' - // CHECK-NEXt: ImplicitCastExpr {{.*}} 'float' -

[clang] [clang][CodeGen] Return RValue from `EmitVAArg` (PR #94635)

2024-06-11 Thread Mariya Podchishchaeva via cfe-commits
@@ -789,27 +791,37 @@ Address AArch64ABIInfo::EmitAAPCSVAArg(Address VAListAddr, QualType Ty, OnStackBlock, "vaargs.addr"); if (IsIndirect) -return Address(CGF.Builder.CreateLoad(ResAddr, "vaarg.addr"), ElementTy, - TyA

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-11 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks edited https://github.com/llvm/llvm-project/pull/95025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-11 Thread Björn Schäpers via cfe-commits
@@ -1269,10 +1269,17 @@ class AnnotatingParser { if (CurrentToken && CurrentToken->is(tok::less)) { CurrentToken->setType(TT_TemplateOpener); next(); - if (!parseAngle()) + TemplateDeclarationDepth++; + if (!parseAngle()) { +TemplateDeclar

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-11 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/95025 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Fix a bug in annotating lambda l_square (PR #95084)

2024-06-11 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks approved this pull request. https://github.com/llvm/llvm-project/pull/95084 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add BinPackBinaryOperations configuration (PR #95013)

2024-06-11 Thread Björn Schäpers via cfe-commits
@@ -27492,6 +27492,86 @@ TEST_F(FormatTest, SpaceBetweenKeywordAndLiteral) { verifyFormat("return sizeof \"5\";"); } +TEST_F(FormatTest, BinPackBinaryOperations) { + auto Style = getLLVMStyle(); + Style.BinPackBinaryOperations = false; + + // Logical operations + verifyF

[clang] [clang][CodeGen] Return RValue from `EmitVAArg` (PR #94635)

2024-06-11 Thread Eli Friedman via cfe-commits
@@ -789,27 +791,37 @@ Address AArch64ABIInfo::EmitAAPCSVAArg(Address VAListAddr, QualType Ty, OnStackBlock, "vaargs.addr"); if (IsIndirect) -return Address(CGF.Builder.CreateLoad(ResAddr, "vaarg.addr"), ElementTy, - TyA

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-11 Thread Rajveer Singh Bharadwaj via cfe-commits
https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/94159 >From bf114654e02d4723457730de0d067c7a00abf42d Mon Sep 17 00:00:00 2001 From: Rajveer Date: Sun, 2 Jun 2024 18:33:37 +0530 Subject: [PATCH] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiab

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-11 Thread Rajveer Singh Bharadwaj via cfe-commits
Rajveer100 wrote: I have done the last few changes as well. Regarding the force-push, I will try to do single commits and later squash them! https://github.com/llvm/llvm-project/pull/94159 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang] [llvm] [RISCV] Add Smcsrind and Sscsrind extension (PR #93952)

2024-06-11 Thread via cfe-commits
https://github.com/YanWQ-monad updated https://github.com/llvm/llvm-project/pull/93952 >From 3e0d38aa84506cd364174190893cb62008948a87 Mon Sep 17 00:00:00 2001 From: YanWQ-monad Date: Fri, 31 May 2024 16:11:43 +0800 Subject: [PATCH 1/3] [RISCV] add smcsrind and sscsrind extension --- .../test/

[clang] [llvm] [RISCV] Add Smcsrind and Sscsrind extension (PR #93952)

2024-06-11 Thread via cfe-commits
YanWQ-monad wrote: My bad. I though they have the same CSRs as Smcsrind/Sscsrind originate from Smaia/Ssaia. https://github.com/llvm/llvm-project/pull/93952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-11 Thread via cfe-commits
Sirraide wrote: > I will try to do single commits and later squash them! You don’t even need to squash them yourself; Github does that automatically because we use ‘squash and merge’. https://github.com/llvm/llvm-project/pull/94159 ___ cfe-commits ma

[clang] [APINotes] Update the documentation with new features (PR #95162)

2024-06-11 Thread Egor Zhdan via cfe-commits
https://github.com/egorzhdan created https://github.com/llvm/llvm-project/pull/95162 This adds the documentation for a few recently added Clang API Notes features: C++ namespaces, `SwiftImportAs` and `SwiftCopyable`. >From c9d9d115118471f0ca6a311e44b366ef9fe4fb2b Mon Sep 17 00:00:00 2001 From:

[clang] [llvm] [RISCV] Add Smcsrind and Sscsrind extension (PR #93952)

2024-06-11 Thread via cfe-commits
https://github.com/YanWQ-monad edited https://github.com/llvm/llvm-project/pull/93952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [APINotes] Update the documentation with new features (PR #95162)

2024-06-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Egor Zhdan (egorzhdan) Changes This adds the documentation for a few recently added Clang API Notes features: C++ namespaces, `SwiftImportAs` and `SwiftCopyable`. --- Full diff: https://github.com/llvm/llvm-project/pull/95162.diff 1 Fil

[clang] [clang][CodeGen] Return RValue from `EmitVAArg` (PR #94635)

2024-06-11 Thread John McCall via cfe-commits
@@ -789,27 +791,37 @@ Address AArch64ABIInfo::EmitAAPCSVAArg(Address VAListAddr, QualType Ty, OnStackBlock, "vaargs.addr"); if (IsIndirect) -return Address(CGF.Builder.CreateLoad(ResAddr, "vaarg.addr"), ElementTy, - TyA

[clang] [llvm] [RISCV] Add Smcsrind and Sscsrind extension (PR #93952)

2024-06-11 Thread via cfe-commits
https://github.com/YanWQ-monad updated https://github.com/llvm/llvm-project/pull/93952 >From 3e0d38aa84506cd364174190893cb62008948a87 Mon Sep 17 00:00:00 2001 From: YanWQ-monad Date: Fri, 31 May 2024 16:11:43 +0800 Subject: [PATCH 1/4] [RISCV] add smcsrind and sscsrind extension --- .../test/

[clang] [Clang] Swap range metadata to attribute for intrinsics. (PR #94851)

2024-06-11 Thread Andreas Jonson via cfe-commits
https://github.com/andjo403 updated https://github.com/llvm/llvm-project/pull/94851 >From 6b4556ea373d90a780c132ab2c51ae46d40a3f49 Mon Sep 17 00:00:00 2001 From: Andreas Jonson Date: Sun, 26 May 2024 10:02:25 +0200 Subject: [PATCH 1/2] [Clang] swap range metadata to attribute for Intrinsics. -

[clang] [Clang] Swap range metadata to attribute for intrinsics. (PR #94851)

2024-06-11 Thread Andreas Jonson via cfe-commits
andjo403 wrote: also changed the noundef to mach the range attribute https://github.com/llvm/llvm-project/pull/94851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Add Smcsrind and Sscsrind extension (PR #93952)

2024-06-11 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/93952 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Swap range metadata to attribute for intrinsics. (PR #94851)

2024-06-11 Thread Nikita Popov via cfe-commits
https://github.com/nikic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/94851 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Respect the [[clang::unsafe_buffer_usage]] attribute for field and constructor initializers (PR #91991)

2024-06-11 Thread Dana Jansens via cfe-commits
https://github.com/danakj updated https://github.com/llvm/llvm-project/pull/91991 >From 273f93fa4aecc0017b5c7172bc296ced1bc6d5f5 Mon Sep 17 00:00:00 2001 From: danakj Date: Mon, 13 May 2024 12:11:41 -0400 Subject: [PATCH 1/4] Generate -Wunsafe-buffer-usage warnings in ctor and field initialize

[clang] [llvm] [RISCV] Add smcdeleg and ssccfg extensions (PR #95163)

2024-06-11 Thread via cfe-commits
https://github.com/YanWQ-monad created https://github.com/llvm/llvm-project/pull/95163 Specification: https://github.com/riscv/riscv-isa-manual/blob/main/src/smcdeleg.adoc `Ssccfg` introduces one new CSR `scountinhibit`. >From 0143e88f43f6c94240de93873786baf5e400a5bd Mon Sep 17 00:00:00 2001

[clang] Bump the DWARF version number to 5 on Darwin. (PR #95164)

2024-06-11 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl created https://github.com/llvm/llvm-project/pull/95164 rdar://110925733 >From bdc0c661ca59ce1cddbc1615a3e640d2943c9c28 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 11 Jun 2024 11:04:00 -0700 Subject: [PATCH] Bump the DWARF version number to 5 on Dar

[clang] [llvm] [RISCV] Add smcdeleg and ssccfg extensions (PR #95163)

2024-06-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Monad (YanWQ-monad) Changes Specification: https://github.com/riscv/riscv-isa-manual/blob/main/src/smcdeleg.adoc `Ssccfg` introduces one new CSR `scountinhibit`. --- Full diff: https://github.com/llvm/llvm-project/pull/95163.diff 9 Fil

[clang] Bump the DWARF version number to 5 on Darwin. (PR #95164)

2024-06-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-clang-driver Author: Adrian Prantl (adrian-prantl) Changes rdar://110925733 --- Full diff: https://github.com/llvm/llvm-project/pull/95164.diff 2 Files Affected: - (modified) clang/lib/Driver/ToolChains/Darwin.cpp (+11-1)

[clang] [CodeGen] Remove IsVolatile from DominatingValue::save_type (PR #95165)

2024-06-11 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak created https://github.com/llvm/llvm-project/pull/95165 Prior to 84780af4b02cb3b86e4cb724f996bf8e02f2f2e7, the class didn't have any information about whether the saved value was volatile. This is NFC as far as I can tell. >From 09faa416eb234ab3bf8e1babb3a7c206968e

[clang] Bump the DWARF version number to 5 on Darwin. (PR #95164)

2024-06-11 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl edited https://github.com/llvm/llvm-project/pull/95164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Remove IsVolatile from DominatingValue::save_type (PR #95165)

2024-06-11 Thread Akira Hatanaka via cfe-commits
https://github.com/ahatanak ready_for_review https://github.com/llvm/llvm-project/pull/95165 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CodeGen] Remove IsVolatile from DominatingValue::save_type (PR #95165)

2024-06-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Akira Hatanaka (ahatanak) Changes Prior to 84780af4b02cb3b86e4cb724f996bf8e02f2f2e7, the class didn't have any information about whether the saved value was volatile. This is NFC as far as I can tell. --- Full diff: https://githu

[clang] [CodeGen] Remove IsVolatile from DominatingValue::save_type (PR #95165)

2024-06-11 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Akira Hatanaka (ahatanak) Changes Prior to 84780af4b02cb3b86e4cb724f996bf8e02f2f2e7, the class didn't have any information about whether the saved value was volatile. This is NFC as far as I can tell. --- Full diff: https://github.com/ll

[clang] [llvm] [RISCV] Add smcdeleg and ssccfg extensions (PR #95163)

2024-06-11 Thread Craig Topper via cfe-commits
@@ -859,6 +859,13 @@ def FeatureStdExtSmepmp : RISCVExtension<"smepmp", 1, 0, "'Smepmp' (Enhanced Physical Memory Protection)">; +def FeatureStdExtSmcdeleg +: RISCVExtension<"smcdeleg", 1, 0, + "'smcdeleg' (Counter Delegation Ma

[clang] [llvm] [RISCV] Add smcdeleg and ssccfg extensions (PR #95163)

2024-06-11 Thread via cfe-commits
https://github.com/YanWQ-monad updated https://github.com/llvm/llvm-project/pull/95163 >From 0143e88f43f6c94240de93873786baf5e400a5bd Mon Sep 17 00:00:00 2001 From: YanWQ-monad Date: Wed, 12 Jun 2024 02:37:10 +0800 Subject: [PATCH 1/2] [RISCV] Add smcdeleg and ssccfg extensions --- .../test/P

[clang] [clang][AArch64] Add validation for Global Register Variable. (PR #94271)

2024-06-11 Thread Daniel Kiss via cfe-commits
https://github.com/DanielKristofKiss updated https://github.com/llvm/llvm-project/pull/94271 >From a8dabc508583ffb12982549d1bfb86cf6845c957 Mon Sep 17 00:00:00 2001 From: Daniel Kiss Date: Sun, 21 Apr 2024 16:14:25 +0200 Subject: [PATCH] [AArch64] Add validation for Global Register Variable. F

[clang] [clang][AArch64] Add validation for Global Register Variable. (PR #94271)

2024-06-11 Thread Daniel Kiss via cfe-commits
@@ -0,0 +1,13 @@ +// Check that -ffixed register handled for globals. +// Regression test for #76426 +// RUN: %clang --target=aarch64-none-gnu -ffixed-x15 -### %s 2>&1 | FileCheck %s +// CHECK-NOT: fatal error: error in backend: Invalid register name "x15". Danie

[clang] [llvm] [RISCV] Add smcdeleg and ssccfg extensions (PR #95163)

2024-06-11 Thread Craig Topper via cfe-commits
https://github.com/topperc approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/95163 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bump the DWARF version number to 5 on Darwin. (PR #95164)

2024-06-11 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere approved this pull request. 🥳 https://github.com/llvm/llvm-project/pull/95164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bump the DWARF version number to 5 on Darwin. (PR #95164)

2024-06-11 Thread Paul T Robinson via cfe-commits
pogo59 wrote: Well, hmmm, I dunno, a radical change like this really wants an RFC and weeks of debate, right? 😄 https://github.com/llvm/llvm-project/pull/95164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mai

[clang] Bump the DWARF version number to 5 on Darwin. (PR #95164)

2024-06-11 Thread Jonas Devlieghere via cfe-commits
https://github.com/JDevlieghere edited https://github.com/llvm/llvm-project/pull/95164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Bump the DWARF version number to 5 on Darwin. (PR #95164)

2024-06-11 Thread Adrian Prantl via cfe-commits
https://github.com/adrian-prantl updated https://github.com/llvm/llvm-project/pull/95164 >From 112f03d9d014cda3c89afd4845c0c78289058d11 Mon Sep 17 00:00:00 2001 From: Adrian Prantl Date: Tue, 11 Jun 2024 11:04:00 -0700 Subject: [PATCH] Bump the DWARF version number to 5 on Darwin. The default

[clang-tools-extra] [clang-doc] Add --asset option to clang-doc (PR #94717)

2024-06-11 Thread via cfe-commits
@@ -182,23 +261,11 @@ Example usage for a project using a compile commands database: {"index.js", "index_json.js"}}; if (Format == "html") { -void *MainAddr = (void *)(intptr_t)GetExecutablePath; -std::string ClangDocPath = GetExecutablePath(argv[0], MainAddr)

[clang] [llvm] Reapply "[llvm][IR] Extend BranchWeightMetadata to track provenance of weights" (PR #95136)

2024-06-11 Thread Paul Kirth via cfe-commits
ilovepi wrote: > What is the summary of the new changes that address the compile time issue? I'm still looking at that, that's why I marked it as a draft, but I suspect I just missed updating https://github.com/llvm/llvm-project/blob/163d036d64609bf59183664aec244da5078dc1f1/llvm/lib/IR/ProfDat

[clang] Bump the DWARF version number to 5 on Darwin. (PR #95164)

2024-06-11 Thread David Blaikie via cfe-commits
dwblaikie wrote: Congrats on the milestone! Glad to have more of us together on the same version for all the positive feedback loops, etc :) https://github.com/llvm/llvm-project/pull/95164 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[clang-tools-extra] [clang-doc] Add --asset option to clang-doc (PR #94717)

2024-06-11 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/94717 >From eeb334620df72c395a5ad27f44a864a6a0c194a5 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Thu, 6 Jun 2024 23:18:12 -0400 Subject: [PATCH 1/7] [clang][clang-doc] add asset path --- .../clang-doc/tool/Cla

[clang-tools-extra] [clang-doc] Add --asset option to clang-doc (PR #94717)

2024-06-11 Thread Paul Kirth via cfe-commits
@@ -182,23 +261,11 @@ Example usage for a project using a compile commands database: {"index.js", "index_json.js"}}; if (Format == "html") { -void *MainAddr = (void *)(intptr_t)GetExecutablePath; -std::string ClangDocPath = GetExecutablePath(argv[0], MainAddr)

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-11 Thread Emilia Kond via cfe-commits
https://github.com/rymiel updated https://github.com/llvm/llvm-project/pull/95025 >From 6fc09d022a0e4e395a1b8e17166641dffc7c12eb Mon Sep 17 00:00:00 2001 From: Emilia Kond Date: Mon, 10 Jun 2024 22:17:29 +0300 Subject: [PATCH 1/2] [clang-format] Don't count template template parameter as decla

[clang] [clang-format] Don't count template template parameter as declaration (PR #95025)

2024-06-11 Thread Emilia Kond via cfe-commits
https://github.com/rymiel updated https://github.com/llvm/llvm-project/pull/95025 >From 6fc09d022a0e4e395a1b8e17166641dffc7c12eb Mon Sep 17 00:00:00 2001 From: Emilia Kond Date: Mon, 10 Jun 2024 22:17:29 +0300 Subject: [PATCH 1/3] [clang-format] Don't count template template parameter as decla

[clang-tools-extra] [clang-doc] Add --asset option to clang-doc (PR #94717)

2024-06-11 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/94717 >From eeb334620df72c395a5ad27f44a864a6a0c194a5 Mon Sep 17 00:00:00 2001 From: PeterChou1 Date: Thu, 6 Jun 2024 23:18:12 -0400 Subject: [PATCH 1/6] [clang][clang-doc] add asset path --- .../clang-doc/tool/Cla

[clang] Respect the [[clang::unsafe_buffer_usage]] attribute for field and constructor initializers (PR #91991)

2024-06-11 Thread Dana Jansens via cfe-commits
https://github.com/danakj updated https://github.com/llvm/llvm-project/pull/91991 >From 273f93fa4aecc0017b5c7172bc296ced1bc6d5f5 Mon Sep 17 00:00:00 2001 From: danakj Date: Mon, 13 May 2024 12:11:41 -0400 Subject: [PATCH 1/4] Generate -Wunsafe-buffer-usage warnings in ctor and field initialize

<    1   2   3   4   5   >