[clang] Revert changes in AddDefaultGCCPrefixes() for SystemZTriples. (PR #94729)

2024-06-07 Thread Jonas Paulsson via cfe-commits
JonPsson1 wrote: I think other folks than myself also got a similar problem, so it's not just on my machine / setup. Should everybody set LLVM_DEFAULT_TARGET_TRIPLE with cmake instead of this patch? Sorry, not very familiar with this... Would it be ok to apply this for now? https://github.c

[clang] [CodeGen] Simplify codegen for array initialization (PR #93956)

2024-06-07 Thread Nikita Popov via cfe-commits
nikic wrote: ping https://github.com/llvm/llvm-project/pull/93956 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Add winsysroot alias to the GNU driver (PR #94731)

2024-06-07 Thread via cfe-commits
https://github.com/Andarwinux created https://github.com/llvm/llvm-project/pull/94731 fixes #91216 >From c1fd8cb831abc0312fb8f0fa0ec5f5348646ed01 Mon Sep 17 00:00:00 2001 From: Andarwinux <144242044+andarwi...@users.noreply.github.com> Date: Fri, 7 Jun 2024 07:07:40 + Subject: [PATCH] [Driv

[clang] [Driver] Add winsysroot alias to the GNU driver (PR #94731)

2024-06-07 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [Driver] Add winsysroot alias to the GNU driver (PR #94731)

2024-06-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Andarwinux) Changes fixes #91216 --- Full diff: https://github.com/llvm/llvm-project/pull/94731.diff 1 Files Affected: - (modified) clang/include/clang/Driver/Options.td (+2) ``diff diff --git a/clang/include/clang/Driv

[clang] Revert changes in AddDefaultGCCPrefixes() for SystemZTriples. (PR #94729)

2024-06-07 Thread Fangrui Song via cfe-commits
MaskRay wrote: > I think other folks than myself also got a similar problem, so it's not just > on my machine / setup. > > Should everybody set LLVM_DEFAULT_TARGET_TRIPLE with cmake instead of this > patch? Sorry, not very familiar with this... > > Would it be ok to apply this for now? The i

[clang] [llvm] [MC,llvm-readobj,yaml2obj] Support CREL relocation format (PR #91280)

2024-06-07 Thread James Henderson via cfe-commits
@@ -86,6 +86,8 @@ DYNAMIC_TAG(RELRSZ, 35) // Size of Relr relocation table. DYNAMIC_TAG(RELR, 36)// Address of relocation table (Relr entries). DYNAMIC_TAG(RELRENT, 37) // Size of a Relr relocation entry. +DYNAMIC_TAG(CREL, 38) // CREL relocation table + --

[clang] [clang-tools-extra] [clangd] Fix crash with null check for Token at Loc (PR #94528)

2024-06-07 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet edited https://github.com/llvm/llvm-project/pull/94528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clangd] Fix crash with null check for Token at Loc (PR #94528)

2024-06-07 Thread kadir çetinkaya via cfe-commits
@@ -447,7 +447,7 @@ class HighlightingsBuilder { if (!RLoc.isValid()) return; -const auto *RTok = TB.spelledTokenAt(RLoc); +const auto *RTok = TB.spelledTokenContaining(RLoc); kadircet wrote: so looks like this call site was actually expecti

[clang] [clang-tools-extra] [clangd] Fix crash with null check for Token at Loc (PR #94528)

2024-06-07 Thread kadir çetinkaya via cfe-commits
https://github.com/kadircet approved this pull request. https://github.com/llvm/llvm-project/pull/94528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] c15b867 - [clang][Interp][NFC] Add GetPtrFieldPop opcode

2024-06-07 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-06-07T09:40:26+02:00 New Revision: c15b86731b78de88fadbc16ea1c2df2f60c991e9 URL: https://github.com/llvm/llvm-project/commit/c15b86731b78de88fadbc16ea1c2df2f60c991e9 DIFF: https://github.com/llvm/llvm-project/commit/c15b86731b78de88fadbc16ea1c2df2f60c991e9.diff LO

[clang] e622996 - [analyzer][NFC] Factor out NoOwnershipChangeVisitor (#94357)

2024-06-07 Thread via cfe-commits
Author: Kristóf Umann Date: 2024-06-07T09:49:16+02:00 New Revision: e622996eddfb2826d258b3a3760eed195f97aabe URL: https://github.com/llvm/llvm-project/commit/e622996eddfb2826d258b3a3760eed195f97aabe DIFF: https://github.com/llvm/llvm-project/commit/e622996eddfb2826d258b3a3760eed195f97aabe.diff

[clang] [analyzer][NFC] Factor out NoOwnershipChangeVisitor (PR #94357)

2024-06-07 Thread Kristóf Umann via cfe-commits
https://github.com/Szelethus closed https://github.com/llvm/llvm-project/pull/94357 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Revert changes in AddDefaultGCCPrefixes() for SystemZTriples. (PR #94729)

2024-06-07 Thread Jonas Paulsson via cfe-commits
https://github.com/JonPsson1 updated https://github.com/llvm/llvm-project/pull/94729 >From 9340b545ec2381937919dfd925940a191244234b Mon Sep 17 00:00:00 2001 From: Jonas Paulsson Date: Fri, 7 Jun 2024 08:24:16 +0200 Subject: [PATCH 1/3] Revert changes in AddDefaultGCCPrefixes() for SystemZTripl

[clang] [llvm] Revert changes in AddDefaultGCCPrefixes() for SystemZTriples. (PR #94729)

2024-06-07 Thread Jonas Paulsson via cfe-commits
JonPsson1 wrote: That seems to fix at least my Ubuntu build. https://github.com/llvm/llvm-project/pull/94729 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][NFC] Factor out NoOwnershipChangeVisitor (PR #94357)

2024-06-07 Thread Balázs Kéri via cfe-commits
@@ -0,0 +1,116 @@ +//===--*- C++ -*--// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [clang][CodeGen] `used` globals are fake (PR #93601)

2024-06-07 Thread Matt Arsenault via cfe-commits
@@ -8642,8 +8642,11 @@ The '``llvm.used``' Global Variable The ``@llvm.used`` global is an array which has :ref:`appending linkage `. This array contains a list of pointers to named global variables, functions and aliases which may optionally -have a pointer cast formed of bitc

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-07 Thread Rajveer Singh Bharadwaj via cfe-commits
https://github.com/Rajveer100 edited https://github.com/llvm/llvm-project/pull/94159 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [llvm] [mlir] [Flang]Fix for changed code at the end of AllocaIP. (PR #92430)

2024-06-07 Thread Nikita Popov via cfe-commits
https://github.com/nikic dismissed https://github.com/llvm/llvm-project/pull/92430 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer][NFC] Factor out NoOwnershipChangeVisitor (PR #94357)

2024-06-07 Thread Kristóf Umann via cfe-commits
@@ -0,0 +1,116 @@ +//===--*- C++ -*--// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] 1c0063b - [clang][Interp] Remove StoragKind limitation in Pointer assign operators

2024-06-07 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-06-07T10:32:16+02:00 New Revision: 1c0063b58a4fc23c94c7f5bf5a937bbdf9703cc0 URL: https://github.com/llvm/llvm-project/commit/1c0063b58a4fc23c94c7f5bf5a937bbdf9703cc0 DIFF: https://github.com/llvm/llvm-project/commit/1c0063b58a4fc23c94c7f5bf5a937bbdf9703cc0.diff LO

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() (PR #90043)

2024-06-07 Thread Paul Heidekrüger via cfe-commits
PBHDK wrote: > > > I am adding @leunam99 and @PBHDK to the PR, who will contribute in the > > > next few weeks. > > > > > > Since we cannot push to this PR, we will be submitting a new PR with > > @sebwolf-de's + our work, correct, @EugeneZelenko, @PiotrZSL, @HerrCai0907? > > Could you pleas

[clang] Testing32 bit for https://github.com/llvm/llvm-project/pull/92083 (PR #94603)

2024-06-07 Thread David Spickett via cfe-commits
DavidSpickett wrote: Sure I'll test it now. BTW if you see `Clang-Unit::ClangReplInterpreterTests/InterpreterTest/Value` failing on one of our bots, that's not due to your change. https://github.com/llvm/llvm-project/pull/94603 ___ cfe-commits mailin

[clang] [llvm] Revert changes in AddDefaultGCCPrefixes() for SystemZTriples. (PR #94729)

2024-06-07 Thread Jonas Paulsson via cfe-commits
JonPsson1 wrote: (patch updated) https://github.com/llvm/llvm-project/pull/94729 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[compiler-rt] [libcxx] [libcxxabi] [libunwind] [libunwind][libcxx][libcxxabi][compiler-rt-builtins] Fix Exception Handling build for wasm (PR #79667)

2024-06-07 Thread via cfe-commits
https://github.com/trcrsired updated https://github.com/llvm/llvm-project/pull/79667 >From 4f1ce895254dd9505150c1f5f5cb77454b9aca68 Mon Sep 17 00:00:00 2001 From: cqwrteur <100043421+trcrsi...@users.noreply.github.com> Date: Sat, 1 Jun 2024 02:55:50 -0400 Subject: [PATCH] [libunwind][libcxx][lib

[clang] [llvm] [ARM] Add support for Cortex-R52+ (PR #94633)

2024-06-07 Thread Jonathan Thackray via cfe-commits
@@ -90,6 +90,8 @@ def ProcR7 : SubtargetFeature<"r7", "ARMProcFamily", "CortexR7", "Cortex-R7 ARM processors", []>; def ProcR52 : SubtargetFeature<"r52", "ARMProcFamily", "CortexR52", "Cortex-R52 AR

[clang] [llvm] [APFloat] Add APFloat support for FP6 data types (PR #94735)

2024-06-07 Thread Durgadoss R via cfe-commits
https://github.com/durga4github created https://github.com/llvm/llvm-project/pull/94735 This patch adds APFloat type support for two FP6 data types, E2M3 and E3M2. The definitions for the two formats are detailed in section 5.3.2 of the OCP specification, which can be accessed here: https://www.

[clang] [llvm] [APFloat] Add APFloat support for FP6 data types (PR #94735)

2024-06-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-support Author: Durgadoss R (durga4github) Changes This patch adds APFloat type support for two FP6 data types, E2M3 and E3M2. The definitions for the two formats are detailed in section 5.3.2 of the OCP specification, which can be accessed here: ht

[clang] [llvm] [APFloat] Add APFloat support for FP6 data types (PR #94735)

2024-06-07 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ac404632f991fc6e7dc75ef553a99676ba8002ce 21432aeaeecc6ba06de252c460e5cb09abb68a29 --

[clang] [Driver] Add winsysroot alias to the GNU driver (PR #94731)

2024-06-07 Thread via cfe-commits
github-actions[bot] wrote: ⚠️ We detected that you are using a GitHub private e-mail address to contribute to the repo. Please turn off [Keep my email addresses private](https://github.com/settings/emails) setting in your account. See [LLVM Discourse](https://discourse.llvm.org/t/hidden-email

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-07 Thread Rajveer Singh Bharadwaj via cfe-commits
https://github.com/Rajveer100 updated https://github.com/llvm/llvm-project/pull/94159 >From e38b38773bcade3407dde112994de5a6c5f0d7e0 Mon Sep 17 00:00:00 2001 From: Rajveer Date: Sun, 2 Jun 2024 18:33:37 +0530 Subject: [PATCH] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiab

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-07 Thread Rajveer Singh Bharadwaj via cfe-commits
@@ -10,6 +10,7 @@ void h() { SEL* ps = &s; @selector(dealloc) = s; // expected-error {{expression is not assignable}} + // expected-note@-1 {{add '*' to dereference it}} Rajveer100 wrote: One way I can think of is to do a AST visit and check for `ObjCSe

[clang] [llvm] [APFloat] Add APFloat support for FP6 data types (PR #94735)

2024-06-07 Thread Durgadoss R via cfe-commits
https://github.com/durga4github updated https://github.com/llvm/llvm-project/pull/94735 >From ac137c57ee35e1662b40796637eb4b25aa773849 Mon Sep 17 00:00:00 2001 From: Durgadoss R Date: Wed, 5 Jun 2024 19:22:31 +0530 Subject: [PATCH] [APFloat] Add APFloat support for FP6 data types This patch ad

[clang] [clang-tools-extra] [clangd] Fix crash with null check for Token at Loc (PR #94528)

2024-06-07 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/94528 >From b13a663ae347649a3bcf9d6e381a5fbbfdc9ea4b Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Wed, 5 Jun 2024 19:48:48 + Subject: [PATCH 1/6] [clangd] Fix crash with null check for Token at Loc --- clang-

[clang] [llvm] [APFloat] Add APFloat support for FP6 data types (PR #94735)

2024-06-07 Thread Durgadoss R via cfe-commits
durga4github wrote: @ThomasRaoux , Could you please help review this change? https://github.com/llvm/llvm-project/pull/94735 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [clangd] Fix crash with null check for Token at Loc (PR #94528)

2024-06-07 Thread Utkarsh Saxena via cfe-commits
@@ -447,7 +447,7 @@ class HighlightingsBuilder { if (!RLoc.isValid()) return; -const auto *RTok = TB.spelledTokenAt(RLoc); +const auto *RTok = TB.spelledTokenContaining(RLoc); usx95 wrote: Done. https://github.com/llvm/llvm-project/pull/945

[clang-tools-extra] 5f1adf0 - [clangd] Fix crash with null check for Token at Loc (#94528)

2024-06-07 Thread via cfe-commits
Author: Utkarsh Saxena Date: 2024-06-07T11:08:25+02:00 New Revision: 5f1adf0433c6007f8be885b832c852da67e8524c URL: https://github.com/llvm/llvm-project/commit/5f1adf0433c6007f8be885b832c852da67e8524c DIFF: https://github.com/llvm/llvm-project/commit/5f1adf0433c6007f8be885b832c852da67e8524c.diff

[clang] [clang-tools-extra] [clangd] Fix crash with null check for Token at Loc (PR #94528)

2024-06-07 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 closed https://github.com/llvm/llvm-project/pull/94528 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] qualifier should be transformed (PR #94725)

2024-06-07 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/94725 >From 6a90ef0b3947a0de2d6453856c80d8f0fd393548 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Fri, 7 Jun 2024 14:04:52 +0800 Subject: [PATCH] [Clang][Sema] qualifier should be transformed --- clang/lib/Sema/TreeTr

[clang] [Clang][Sema] qualifier should be transformed (PR #94725)

2024-06-07 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/94725 >From 57576620fc412015bd19a34e12be61f4b81eb655 Mon Sep 17 00:00:00 2001 From: huqizhi Date: Fri, 7 Jun 2024 14:04:52 +0800 Subject: [PATCH] [Clang][Sema] qualifier should be transformed --- clang/lib/Sema/TreeTr

[clang] [clang][driver] Enable '-flto' on bare-metal (PR #94738)

2024-06-07 Thread via cfe-commits
https://github.com/walkerkd created https://github.com/llvm/llvm-project/pull/94738 Pass the linker LTO options enabled by the clang '-flto' command line options when targeting bare-metal. >From 8150a6529be5a3be65e49d5440c576d856d404d5 Mon Sep 17 00:00:00 2001 From: Keith Walker Date: Thu, 6

[clang] [clang][driver] Enable '-flto' on bare-metal (PR #94738)

2024-06-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (walkerkd) Changes Pass the linker LTO options enabled by the clang '-flto' command line options when targeting bare-metal. --- Full diff: https://github.com/llvm/llvm-project/pull/94738.diff 2 Files Affected: - (modified) clang/l

[clang] [clang][driver] Enable '-flto' on bare-metal (PR #94738)

2024-06-07 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff ac404632f991fc6e7dc75ef553a99676ba8002ce 8150a6529be5a3be65e49d5440c576d856d404d5 --

[clang] Support [[guarded_by(mutex)]] attribute inside C struct (PR #94216)

2024-06-07 Thread Pierre d'Herbemont via cfe-commits
https://github.com/pdherbemont updated https://github.com/llvm/llvm-project/pull/94216 >From 55eb00bafdd19817a2c31af6178a301582f5523b Mon Sep 17 00:00:00 2001 From: Pierre d'Herbemont Date: Wed, 29 May 2024 11:11:03 +0200 Subject: [PATCH] Support [[guarded_by(mutex)]] and friends attributes ins

[clang] Support [[guarded_by(mutex)]] attribute inside C struct (PR #94216)

2024-06-07 Thread Pierre d'Herbemont via cfe-commits
@@ -1,4 +1,4 @@ -// RUN: %clang_cc1 -fsyntax-only -verify -Wthread-safety -Wthread-safety-beta %s +// RUN: %clang_cc1 -fsyntax-only -verify -Wthread-safety -Wthread-safety-beta -fexperimental-late-parse-attributes %s pdherbemont wrote: done! https://github.com

[clang] Support [[guarded_by(mutex)]] attribute inside C struct (PR #94216)

2024-06-07 Thread Pierre d'Herbemont via cfe-commits
@@ -3330,6 +3340,112 @@ void Parser::DistributeCLateParsedAttrs(Decl *Dcl, } } +/// GuardedBy attributes (e.g., guarded_by): +/// AttrName '(' expression ')' +void Parser::ParseGuardedByAttribute( +IdentifierInfo &AttrName, SourceLocation AttrNameLoc, +ParsedAttrib

[clang] Support [[guarded_by(mutex)]] attribute inside C struct (PR #94216)

2024-06-07 Thread Pierre d'Herbemont via cfe-commits
@@ -29,6 +29,13 @@ struct LOCKABLE Mutex {}; struct Foo { struct Mutex *mu_; + int a_value GUARDED_BY(mu_); pdherbemont wrote: done! https://github.com/llvm/llvm-project/pull/94216 ___ cfe-commits mailing list

[clang] Support [[guarded_by(mutex)]] attribute inside C struct (PR #94216)

2024-06-07 Thread Pierre d'Herbemont via cfe-commits
@@ -3330,6 +3340,112 @@ void Parser::DistributeCLateParsedAttrs(Decl *Dcl, } } +/// GuardedBy attributes (e.g., guarded_by): +/// AttrName '(' expression ')' +void Parser::ParseGuardedByAttribute( +IdentifierInfo &AttrName, SourceLocation AttrNameLoc, +ParsedAttrib

[clang] Support [[guarded_by(mutex)]] attribute inside C struct (PR #94216)

2024-06-07 Thread Pierre d'Herbemont via cfe-commits
@@ -3330,6 +3340,112 @@ void Parser::DistributeCLateParsedAttrs(Decl *Dcl, } } +/// GuardedBy attributes (e.g., guarded_by): +/// AttrName '(' expression ')' +void Parser::ParseGuardedByAttribute( +IdentifierInfo &AttrName, SourceLocation AttrNameLoc, +ParsedAttrib

[clang] Support [[guarded_by(mutex)]] attribute inside C struct (PR #94216)

2024-06-07 Thread Pierre d'Herbemont via cfe-commits
@@ -3330,6 +3340,112 @@ void Parser::DistributeCLateParsedAttrs(Decl *Dcl, } } +/// GuardedBy attributes (e.g., guarded_by): +/// AttrName '(' expression ')' +void Parser::ParseGuardedByAttribute( +IdentifierInfo &AttrName, SourceLocation AttrNameLoc, +ParsedAttrib

[clang] Support [[guarded_by(mutex)]] attribute inside C struct (PR #94216)

2024-06-07 Thread Pierre d'Herbemont via cfe-commits
pdherbemont wrote: > @pdherbemont thanks for working on this. It looks pretty good and its great > to see the late parsing support I added gaining new users. I just have some > nits about missing test cases. I should have added all the requested test cases. Not sure it's the way you wanted it

[clang] [clang][analyzer] Improved PointerSubChecker (PR #93676)

2024-06-07 Thread Balazs Benics via cfe-commits
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= , =?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= , =?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= Message-ID: In-Reply-To: @@ -53,10 +62,10 @@ void f4(void) { int (*p)[m] = a; // p == &a[0] p += 1; // p == &a[1] - // FIXME: This warning is not needed + // FIXM

[clang] [clang][analyzer] Improved PointerSubChecker (PR #93676)

2024-06-07 Thread Balazs Benics via cfe-commits
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= , =?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= , =?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= Message-ID: In-Reply-To: https://github.com/steakhal approved this pull request. LGTM, thanks. Minor nits. https://github.com/llvm/llvm-project/pull/93676

[clang] [clang][analyzer] Improved PointerSubChecker (PR #93676)

2024-06-07 Thread Balazs Benics via cfe-commits
=?utf-8?q?Balázs_Kéri?= , =?utf-8?q?Balázs_Kéri?= , =?utf-8?q?Balázs_Kéri?= Message-ID: In-Reply-To: https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/93676 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] [clang][driver] Enable '-flto' on bare-metal (PR #94738)

2024-06-07 Thread via cfe-commits
https://github.com/walkerkd updated https://github.com/llvm/llvm-project/pull/94738 >From 8150a6529be5a3be65e49d5440c576d856d404d5 Mon Sep 17 00:00:00 2001 From: Keith Walker Date: Thu, 6 Jun 2024 15:14:49 +0100 Subject: [PATCH 1/2] [clang][driver] Enable '-flto' on bare-metal Pass the linker

[clang] [llvm] [CMake][Release] Use the TXZ cpack generator for binaries (PR #90138)

2024-06-07 Thread Tom Stellard via cfe-commits
https://github.com/tstellar closed https://github.com/llvm/llvm-project/pull/90138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5d6acf8 - [clang][Interp][NFC] Properly assign block pointer Pointee

2024-06-07 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-06-07T11:48:44+02:00 New Revision: 5d6acf8196a44225991ab2fb6dfc9cc72296b348 URL: https://github.com/llvm/llvm-project/commit/5d6acf8196a44225991ab2fb6dfc9cc72296b348 DIFF: https://github.com/llvm/llvm-project/commit/5d6acf8196a44225991ab2fb6dfc9cc72296b348.diff LO

[clang] 3a31eae - [clang][Interp] Fix refers_to_enclosing_variable_or_capture DREs

2024-06-07 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-06-07T11:48:44+02:00 New Revision: 3a31eaeac8482fa5e242ee00cd4e77b203db539e URL: https://github.com/llvm/llvm-project/commit/3a31eaeac8482fa5e242ee00cd4e77b203db539e DIFF: https://github.com/llvm/llvm-project/commit/3a31eaeac8482fa5e242ee00cd4e77b203db539e.diff LO

[clang] 1a52392 - [ARM] r11 is reserved when using -mframe-chain=aapcs (#86951)

2024-06-07 Thread via cfe-commits
Author: Oliver Stannard Date: 2024-06-07T10:58:10+01:00 New Revision: 1a5239251ead73ee57f4e2f7fc93433ac7cf18b1 URL: https://github.com/llvm/llvm-project/commit/1a5239251ead73ee57f4e2f7fc93433ac7cf18b1 DIFF: https://github.com/llvm/llvm-project/commit/1a5239251ead73ee57f4e2f7fc93433ac7cf18b1.dif

[clang] [llvm] [ARM] r11 is reserved when using -mframe-chain=aapcs (PR #86951)

2024-06-07 Thread Oliver Stannard via cfe-commits
https://github.com/ostannard closed https://github.com/llvm/llvm-project/pull/86951 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Testing32 bit for https://github.com/llvm/llvm-project/pull/92083 (PR #94603)

2024-06-07 Thread David Spickett via cfe-commits
DavidSpickett wrote: Ok, this new version passes `check-llvm` and `check-clang` (ignoring the pre-existing failure), using the exact config from [clang-armv8-quick](https://lab.llvm.org/buildbot/#/builders/245). https://github.com/llvm/llvm-project/pull/94603 __

[clang] 917afa8 - [ARM] Add support for Cortex-R52+ (#94633)

2024-06-07 Thread via cfe-commits
Author: Jonathan Thackray Date: 2024-06-07T11:03:32+01:00 New Revision: 917afa883258757575ac6448e83a9233d7877333 URL: https://github.com/llvm/llvm-project/commit/917afa883258757575ac6448e83a9233d7877333 DIFF: https://github.com/llvm/llvm-project/commit/917afa883258757575ac6448e83a9233d7877333.d

[clang] [llvm] [ARM] Add support for Cortex-R52+ (PR #94633)

2024-06-07 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray closed https://github.com/llvm/llvm-project/pull/94633 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Enable LLDB tests in Linux pre-merge CI (PR #94208)

2024-06-07 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray updated https://github.com/llvm/llvm-project/pull/94208 >From 5c757153a3f462d40663add6a9ae7caf42272913 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Mon, 3 Jun 2024 13:33:36 +0300 Subject: [PATCH 1/8] Enable LLDB tests in pre-submit CI --- .ci/generate-b

[clang] [llvm] Enable LLDB tests in Linux pre-merge CI (PR #94208)

2024-06-07 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/94208 >From 5c757153a3f462d40663add6a9ae7caf42272913 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Mon, 3 Jun 2024 13:33:36 +0300 Subject: [PATCH 1/8] Enable LLDB tests in pre-submit CI --- .ci/generate-bui

[clang] [llvm] Enable LLDB tests in Linux pre-merge CI (PR #94208)

2024-06-07 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/94208 >From 5c757153a3f462d40663add6a9ae7caf42272913 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Mon, 3 Jun 2024 13:33:36 +0300 Subject: [PATCH 1/9] Enable LLDB tests in pre-submit CI --- .ci/generate-bui

[clang] [llvm] Enable LLDB tests in Linux pre-merge CI (PR #94208)

2024-06-07 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/94208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Enable LLDB tests in Linux pre-merge CI (PR #94208)

2024-06-07 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: @AaronBallman @JDevlieghere @Michael137 @adrian-prantl @DavidSpickett @mizvekov I updated the PR to test LLDB on Clang changes. I hope we can start gathering approvals to get this PR moving. https://github.com/llvm/llvm-project/pull/94208

[clang] [Clang] Substitute for the type aliases inside of a CTAD guide (PR #94740)

2024-06-07 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 created https://github.com/llvm/llvm-project/pull/94740 Similar to the approach of handling nested class templates when building a CTAD guide, we substitute the template parameters of a type alias declaration with the instantiating template arguments in order to ensu

[clang] [Clang] Substitute for the type aliases inside of a CTAD guide (PR #94740)

2024-06-07 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 edited https://github.com/llvm/llvm-project/pull/94740 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 54c5dbe - [clang][test] Skip interpreter value test on Arm 32 bit

2024-06-07 Thread David Spickett via cfe-commits
Author: David Spickett Date: 2024-06-07T10:38:25Z New Revision: 54c5dbe7c3812461decbccb6ed122e41777e02bd URL: https://github.com/llvm/llvm-project/commit/54c5dbe7c3812461decbccb6ed122e41777e02bd DIFF: https://github.com/llvm/llvm-project/commit/54c5dbe7c3812461decbccb6ed122e41777e02bd.diff LOG

[clang] 6fe5428 - [Flang] Handle the newly-added "Reserved" FramePointerKind for 1a5239251ead73ee57f4e2f7fc93433ac7cf18b1

2024-06-07 Thread Haojian Wu via cfe-commits
Author: Haojian Wu Date: 2024-06-07T12:49:41+02:00 New Revision: 6fe5428ecbd18aa263417a244c0850b1271617c0 URL: https://github.com/llvm/llvm-project/commit/6fe5428ecbd18aa263417a244c0850b1271617c0 DIFF: https://github.com/llvm/llvm-project/commit/6fe5428ecbd18aa263417a244c0850b1271617c0.diff LO

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() (PR #90043)

2024-06-07 Thread Piotr Zegar via cfe-commits
PiotrZSL wrote: Check if you can commit to sebwolf-de:avoid-bounds-error-check https://github.com/llvm/llvm-project/pull/90043 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][SPIR-V] Add support for AMDGCN flavoured SPIRV (PR #89796)

2024-06-07 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx closed https://github.com/llvm/llvm-project/pull/89796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Substitute for the type aliases inside of a CTAD guide (PR #94740)

2024-06-07 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/94740 >From 2f60e51f2017e4448047f64983b2f22cdb67e816 Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Fri, 7 Jun 2024 18:08:10 +0800 Subject: [PATCH 1/2] [Clang] Substitute for the type aliases inside of a CTAD guide

[clang] [llvm] [clang][SPIR-V] Add support for AMDGCN flavoured SPIRV (PR #89796)

2024-06-07 Thread Alex Voicu via cfe-commits
AlexVlx wrote: Thank you everyone for the reviews! https://github.com/llvm/llvm-project/pull/89796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] [libunwind] Tweak tests for musl support. (PR #85097)

2024-06-07 Thread Alastair Houghton via cfe-commits
al45tair wrote: I don't have merge rights here, so someone else will need to hit the Merge button. https://github.com/llvm/llvm-project/pull/85097 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [llvm] Add SonarCloud (PR #94745)

2024-06-07 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/94745 >From 099e93f425293daf376eccbe6fd771f297126588 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Fri, 7 Jun 2024 12:55:07 +0200 Subject: [PATCH 1/2] Add initial SonarCloud config --- .github/workflows/clang-t

[clang] [llvm] Add SonarCloud (PR #94745)

2024-06-07 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-static-analyzer-1 @llvm/pr-subscribers-clang Author: Balazs Benics (steakhal) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/94745.diff 4 Files Affected: - (added) .github/workflows/clang-tests-sonar-cloud.yml (+38) - (added

[clang] [llvm] Add SonarCloud (PR #94745)

2024-06-07 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/94745 >From 099e93f425293daf376eccbe6fd771f297126588 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Fri, 7 Jun 2024 12:55:07 +0200 Subject: [PATCH 1/3] Add initial SonarCloud config --- .github/workflows/clang-t

[clang] [clang] Fix loss of `dllexport` for exported template specialization (PR #94664)

2024-06-07 Thread via cfe-commits
https://github.com/zmodem commented: Thanks! This basically looks good to me. It would be nice to keep `GetOrCreateLLVMGlobal` and `GetOrCreateLLVMFunction` in sync. Would it be possible to extract the "Handle dropped DLL attributes" logic into a small utility function that could be called fro

[clang] 9ece3eb - [clang][Interp] Check ConstantExpr results for initialization

2024-06-07 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-06-07T13:29:23+02:00 New Revision: 9ece3eb1459309f9fbd18ce8ec8f771c238e8815 URL: https://github.com/llvm/llvm-project/commit/9ece3eb1459309f9fbd18ce8ec8f771c238e8815 DIFF: https://github.com/llvm/llvm-project/commit/9ece3eb1459309f9fbd18ce8ec8f771c238e8815.diff LO

[clang] [clang] Fix loss of `dllexport` for exported template specialization (PR #94664)

2024-06-07 Thread Andrew Ng via cfe-commits
nga888 wrote: > It would be nice to keep `GetOrCreateLLVMGlobal` and > `GetOrCreateLLVMFunction` in sync. Would it be possible to extract the > "Handle dropped DLL attributes" logic into a small utility function that > could be called from both? I did briefly think about this, but does this c

[clang] [clang-repl] Lay the foundation of pretty printing for C. (PR #89811)

2024-06-07 Thread David Spickett via cfe-commits
DavidSpickett wrote: > I will get you instructions on how to do that (will be tomorrow at this > point). https://github.com/llvm/llvm-project/issues/94741#issuecomment-2154656315 There is some underlying issue (https://github.com/llvm/llvm-project/issues/94741), so if you want to try and fix

[clang] b8cc85b - [clang][Interp] Limit lambda capture lazy visting to actual captures

2024-06-07 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-06-07T13:29:23+02:00 New Revision: b8cc85b318c0dd89e4dd69e3691ffcad5e401885 URL: https://github.com/llvm/llvm-project/commit/b8cc85b318c0dd89e4dd69e3691ffcad5e401885 DIFF: https://github.com/llvm/llvm-project/commit/b8cc85b318c0dd89e4dd69e3691ffcad5e401885.diff LO

[clang] 9eb8a13 - [clang][Interp][NFC] Fix a const-correctness warning

2024-06-07 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-06-07T13:29:23+02:00 New Revision: 9eb8a130c5d708dbabe824113add072436ae9997 URL: https://github.com/llvm/llvm-project/commit/9eb8a130c5d708dbabe824113add072436ae9997 DIFF: https://github.com/llvm/llvm-project/commit/9eb8a130c5d708dbabe824113add072436ae9997.diff LO

[clang] [libcxx] [clang] Preserve Qualifiers and type sugar in TemplateNames (PR #93433)

2024-06-07 Thread kadir çetinkaya via cfe-commits
kadircet wrote: so after this patch, clang seems to be crashing on: ```cpp template struct map {}; template class foo {}; template class MapType, typename Value> Value bar(MapType map); template class MapType, typename Value> Value bar(MapType> map); void aux() { map> input; bar(input)

[clang] [clang][AArch64] Add validation for Global Register Variable. (PR #94271)

2024-06-07 Thread KAWASHIMA Takahiro via cfe-commits
https://github.com/kawashima-fj approved this pull request. Thanks for the fix. I left a minor suggestion. Some notes: - This commit make Clang emit `error: size of register '???' does not match variable size` error instead of `fatal error: error in backend: Invalid register name "???"`, rega

[clang] [clang][AArch64] Add validation for Global Register Variable. (PR #94271)

2024-06-07 Thread KAWASHIMA Takahiro via cfe-commits
@@ -0,0 +1,13 @@ +// Check that -ffixed register handled for globals. +// Regression test for #76426 +// RUN: %clang --target=aarch64-none-gnu -ffixed-x15 -### %s 2>&1 | FileCheck %s +// CHECK-NOT: fatal error: error in backend: Invalid register name "x15". kawas

[clang] [clang][AArch64] Add validation for Global Register Variable. (PR #94271)

2024-06-07 Thread KAWASHIMA Takahiro via cfe-commits
https://github.com/kawashima-fj edited https://github.com/llvm/llvm-project/pull/94271 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix loss of `dllexport` for exported template specialization (PR #94664)

2024-06-07 Thread via cfe-commits
zmodem wrote: > > It would be nice to keep `GetOrCreateLLVMGlobal` and > > `GetOrCreateLLVMFunction` in sync. Would it be possible to extract the > > "Handle dropped DLL attributes" logic into a small utility function that > > could be called from both? > > I did briefly think about this, but

[clang-tools-extra] [clang-tidy] Add WarnOnSizeOfPointer mode to bugprone-sizeof-expression (PR #94356)

2024-06-07 Thread Donát Nagy via cfe-commits
NagyDonat wrote: I re-ran the open source evaluation, and here is the clean diff that I promised (italicized notes are just copied from the old table): | Project | New Reports | Resolved Reports | Notes |-|-|--|--| | memcached | No reports | No repor

[clang] Testing32 bit for https://github.com/llvm/llvm-project/pull/92083 (PR #94603)

2024-06-07 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: Thank you very much! https://github.com/llvm/llvm-project/pull/94603 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Refine invalidation caused by `fread` (PR #93408)

2024-06-07 Thread Balazs Benics via cfe-commits
@@ -0,0 +1,443 @@ +// RUN: %clang_analyze_cc1 -verify %s \ +// RUN: -triple x86_64-linux-gnu \ +// RUN: -analyzer-checker=core,unix.Stream,alpha.security.taint \ +// RUN: -analyzer-checker=debug.ExprInspection + +#include "Inputs/system-header-simulator-for-simple-stream.h"

[clang] 5a0181f - [serialization] no transitive decl change (#92083)

2024-06-07 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2024-06-07T20:21:55+08:00 New Revision: 5a0181f568e56e37df80d0f74eca4775776fa8cd URL: https://github.com/llvm/llvm-project/commit/5a0181f568e56e37df80d0f74eca4775776fa8cd DIFF: https://github.com/llvm/llvm-project/commit/5a0181f568e56e37df80d0f74eca4775776fa8cd.diff LO

[clang] [serialization] no transitive decl change (PR #92083)

2024-06-07 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: Thanks for testing. I've resent https://github.com/llvm/llvm-project/commit/5a0181f568e56e37df80d0f74eca4775776fa8cd. https://github.com/llvm/llvm-project/pull/92083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lis

[clang] [analyzer] Refine invalidation caused by `fread` (PR #93408)

2024-06-07 Thread Balazs Benics via cfe-commits
@@ -0,0 +1,443 @@ +// RUN: %clang_analyze_cc1 -verify %s \ +// RUN: -triple x86_64-linux-gnu \ +// RUN: -analyzer-checker=core,unix.Stream,alpha.security.taint \ +// RUN: -analyzer-checker=debug.ExprInspection + +#include "Inputs/system-header-simulator-for-simple-stream.h"

[clang] [analyzer] Refine invalidation caused by `fread` (PR #93408)

2024-06-07 Thread Balazs Benics via cfe-commits
@@ -0,0 +1,443 @@ +// RUN: %clang_analyze_cc1 -verify %s \ +// RUN: -triple x86_64-linux-gnu \ +// RUN: -analyzer-checker=core,unix.Stream,alpha.security.taint \ +// RUN: -analyzer-checker=debug.ExprInspection + +#include "Inputs/system-header-simulator-for-simple-stream.h"

[clang] [analyzer] Refine invalidation caused by `fread` (PR #93408)

2024-06-07 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/93408 >From f9e841ddaa865d529c806b2d115d5ddbc7109243 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Sun, 26 May 2024 11:40:01 +0200 Subject: [PATCH 01/16] [analyzer] Refine invalidation caused by `fread` This cha

[clang] [analyzer] Refine invalidation caused by `fread` (PR #93408)

2024-06-07 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/93408 >From f9e841ddaa865d529c806b2d115d5ddbc7109243 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Sun, 26 May 2024 11:40:01 +0200 Subject: [PATCH 01/16] [analyzer] Refine invalidation caused by `fread` This cha

  1   2   3   4   5   >