https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/94288
>From a813e0afb4e0e3c6178b4dab86c9f48ff9c77261 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Tue, 4 Jun 2024 01:17:48 +0300
Subject: [PATCH 1/2] [clang] Add tests for Core issues about friend templates
MaskRay wrote:
(Friendly Ping:)
https://github.com/llvm/llvm-project/pull/91280
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -373,6 +373,98 @@ namespace cwg1837 { // cwg1837: 3.3
#endif
}
+namespace cwg1862 { // cwg1862: no
+template
+struct A {
+ struct B {
+void e();
+ };
+
+ void f();
+
+ struct D {
+void g();
+ };
+
+ T h();
+
+ template
+ T i();
+};
+
+template<>
+struc
https://github.com/farzonl updated
https://github.com/llvm/llvm-project/pull/93879
>From f1fc152552989f307ededc6076b1e97c18b25aa4 Mon Sep 17 00:00:00 2001
From: Farzon Lotfi
Date: Thu, 30 May 2024 13:51:35 -0400
Subject: [PATCH 1/3] [HLSL] add loop unroll - `Attr.td` - Define the HLSL loop
att
farzonl wrote:
done
https://github.com/llvm/llvm-project/pull/93879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/shafik commented:
LGTM, curious why you skipped some and not others from that telecom. Likely
folks won't be able to check out the DRs until after St Louis.
https://github.com/llvm/llvm-project/pull/94167
___
cfe-commits mailing li
@@ -635,6 +635,17 @@ void LoopInfoStack::push(BasicBlock *Header,
clang::ASTContext &Ctx,
Option = LoopHintAttr::UnrollCount;
State = LoopHintAttr::Numeric;
}
+} else if (HLSLLoopHint) {
+ ValueInt = HLSLLoopHint->getDirective();
+ if (HLSLL
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/91317
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/owenca commented:
Can you call `parseConfiguration()` instead of `getStyle()` in QtCreator while
the user is entering code? It seems inefficient to call `getStyle()` all the
time.
https://github.com/llvm/llvm-project/pull/91317
___
@@ -4026,12 +4030,13 @@ Expected getStyle(StringRef StyleName,
StringRef FileName,
// Reset possible inheritance
Style.InheritsParentConfig = false;
- auto dropDiagnosticHandler = [](const llvm::SMDiagnostic &, void *) {};
+ auto diagHandlerOrDropHandling =
+ DiagH
https://github.com/zygoloid edited
https://github.com/llvm/llvm-project/pull/91692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -77,3 +77,38 @@ namespace use_self {
int fib(int n) { return FibTree{n}.v; }
}
+
+namespace nested_union {
+ union Test1 {
+union {
+ int inner { 42 };
+};
+int outer;
+ };
+ static_assert(Test1{}.inner == 42, "");
+ struct Test2 {
+union {
+
https://github.com/zygoloid approved this pull request.
Looks good to me too.
https://github.com/llvm/llvm-project/pull/91692
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -77,3 +77,38 @@ namespace use_self {
int fib(int n) { return FibTree{n}.v; }
}
+
+namespace nested_union {
+ union Test1 {
+union {
+ int inner { 42 };
+};
+int outer;
+ };
+ static_assert(Test1{}.inner == 42, "");
+ struct Test2 {
+union {
+
https://github.com/farzonl updated
https://github.com/llvm/llvm-project/pull/93879
>From f1fc152552989f307ededc6076b1e97c18b25aa4 Mon Sep 17 00:00:00 2001
From: Farzon Lotfi
Date: Thu, 30 May 2024 13:51:35 -0400
Subject: [PATCH 1/4] [HLSL] add loop unroll - `Attr.td` - Define the HLSL loop
att
@@ -584,6 +585,32 @@ static Attr *handleOpenCLUnrollHint(Sema &S, Stmt *St,
const ParsedAttr &A,
return ::new (S.Context) OpenCLUnrollHintAttr(S.Context, A, UnrollFactor);
}
+static Attr *handleHLSLLoopHintAttr(Sema &S, Stmt *St, const ParsedAttr &A,
+
@@ -114,18 +114,21 @@ Parser::ParseStatementOrDeclaration(StmtVector &Stmts,
// here because we don't want to allow arbitrary orderings.
ParsedAttributes CXX11Attrs(AttrFactory);
MaybeParseCXX11Attributes(CXX11Attrs, /*MightBeObjCMessageSend*/ true);
- ParsedAttributes G
@@ -0,0 +1,99 @@
+// RUN: %clang_cc1 -std=hlsl2021 -finclude-default-header -x hlsl -triple \
+// RUN: dxil-pc-shadermodel6.3-library %s -emit-llvm -o - | FileCheck %s
+
+/*** for ***/
+void for_count()
+{
+// CHECK-LABEL: for_count
farzonl wrote:
`Are we guarant
https://github.com/farzonl updated
https://github.com/llvm/llvm-project/pull/93879
>From f1fc152552989f307ededc6076b1e97c18b25aa4 Mon Sep 17 00:00:00 2001
From: Farzon Lotfi
Date: Thu, 30 May 2024 13:51:35 -0400
Subject: [PATCH 1/4] [HLSL] add loop unroll - `Attr.td` - Define the HLSL loop
att
https://github.com/c8ef created https://github.com/llvm/llvm-project/pull/94299
close: #93650
>From 0150bd8d4d94cc25c194722471bac8a4485f6e6e Mon Sep 17 00:00:00 2001
From: c8ef
Date: Tue, 4 Jun 2024 00:59:38 +
Subject: [PATCH] fix typeid with pack index
---
clang/lib/AST/Expr.cpp
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (c8ef)
Changes
close: #93650
---
Full diff: https://github.com/llvm/llvm-project/pull/94299.diff
2 Files Affected:
- (modified) clang/lib/AST/Expr.cpp (+1-3)
- (added) clang/test/SemaCXX/GH93650.cpp (+12)
``diff
diff -
https://github.com/c8ef edited https://github.com/llvm/llvm-project/pull/94299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vvereschaka created
https://github.com/llvm/llvm-project/pull/94300
Avoid usage DEFAULT_SYSROOT CMake variable to confgiure the ARM/Aarch64 cross
platform toolchain builds. Use the Clang configuration files with proper
`--sysroot=` in it instead.
More details could be found
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Vladimir Vereschaka (vvereschaka)
Changes
Avoid usage DEFAULT_SYSROOT CMake variable to confgiure the ARM/Aarch64 cross
platform toolchain builds. Use the Clang configuration files with proper
`--sysroot=` in it instead.
More details cou
efriedma-quic wrote:
X19 is the base register; can we actually allocate arguments in it in general?
This seems hard to fix.
It looks like frame lowering assumes X9 is available; that's probably fixable,
but the code needs to be reworked, I think.
X15 is used on Windows for stack allocation;
JonChesterfield wrote:
I wish to ship this as-is. This patch is carefully constructed to be zero risk
and landing it significantly improves the chances of zero-overhead varargs
shipping. This revision passes the amdgpu libc tests. The tests are fragile to
seemingly trivial changes to the IR ge
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/93206
>From 658e9d46adf6dd79aa6aef03a1817444a880348a Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Thu, 23 May 2024 22:35:11 +0800
Subject: [PATCH 1/3] [Clang][Sema] Tweak tryCaptureVariable for unevaluated
lambda
jhuber6 wrote:
I can confirm that it passes the tests against the `libc` targets, namely basic
`stdarg.h` implementations and `sprintf`.
https://github.com/llvm/llvm-project/pull/93362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://li
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/94299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,12 @@
+// RUN: %clang_cc1 -std=c++2c -fsyntax-only -verify %s
+// expected-no-diagnostics
+
+namespace std {
+struct type_info {
+ const char *name;
+};
+} // namespace std
+
+namespace GH93650_bug {
+auto func(auto... inputArgs) { return typeid(inputArgs...[0]); }
+}
https://github.com/zyn0217 approved this pull request.
Thanks! LG with a nit. And please wait for @cor3ntin for the last approval.
https://github.com/llvm/llvm-project/pull/94299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
https://github.com/c8ef updated https://github.com/llvm/llvm-project/pull/94299
>From 0150bd8d4d94cc25c194722471bac8a4485f6e6e Mon Sep 17 00:00:00 2001
From: c8ef
Date: Tue, 4 Jun 2024 00:59:38 +
Subject: [PATCH 1/2] fix typeid with pack index
---
clang/lib/AST/Expr.cpp | 4 +---
@@ -0,0 +1,12 @@
+// RUN: %clang_cc1 -std=c++2c -fsyntax-only -verify %s
+// expected-no-diagnostics
+
+namespace std {
+struct type_info {
+ const char *name;
+};
+} // namespace std
+
+namespace GH93650_bug {
+auto func(auto... inputArgs) { return typeid(inputArgs...[0]); }
+}
https://github.com/ergawy updated
https://github.com/llvm/llvm-project/pull/93920
>From 926cf8d19c625880c303aff0527e2e6e8a1629bd Mon Sep 17 00:00:00 2001
From: ergawy
Date: Thu, 30 May 2024 23:16:39 -0500
Subject: [PATCH 1/3] [OpenMP][][LLVM] Update alloca IP after `PrivCB` in
`OMPIRBUIlder`
https://github.com/efriedma-quic updated
https://github.com/llvm/llvm-project/pull/91692
>From 2e442967c20b930788ac0818b4ce10daf2792f91 Mon Sep 17 00:00:00 2001
From: Eli Friedman
Date: Thu, 9 May 2024 19:40:46 -0700
Subject: [PATCH] [Sema] Fix handling of fields with initializers in nested
an
https://github.com/efriedma-quic updated
https://github.com/llvm/llvm-project/pull/91692
>From 6123b5f43b11f968474baa15623c4bf4d14ed188 Mon Sep 17 00:00:00 2001
From: Eli Friedman
Date: Thu, 9 May 2024 19:40:46 -0700
Subject: [PATCH] [Sema] Fix handling of fields with initializers in nested
an
antangelo wrote:
Thank you for catching these.
> X19 is the base register; can we actually allocate arguments in it in
> general? This seems hard to fix.
I will remove X19 from the argument passing list. `ghccc` also uses X19 for
argument passing, and I didn't run into issues while testing th
owenca wrote:
> As noted in the issue, I think it should also keep working without the
> attribute macro. (I'd be fine with the all upper case is a macro heuristic.)
See https://github.com/llvm/llvm-project/issues/94184#issuecomment-2146557923.
https://github.com/llvm/llvm-project/pull/94189
_
https://github.com/efriedma-quic commented:
Left some review comments. Please land
https://github.com/llvm/llvm-project/pull/94083 first.
I agree it makes sense to land this in essentially its current form; it seems
to be the right algorithm.
https://github.com/llvm/llvm-project/pull/93362
_
https://github.com/efriedma-quic edited
https://github.com/llvm/llvm-project/pull/93362
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -33,6 +33,7 @@ static_library("IPO") {
"DeadArgumentElimination.cpp",
"ElimAvailExtern.cpp",
"EmbedBitcodePass.cpp",
+"ExpandVariadics.cpp",
efriedma-quic wrote:
There's a bot that updates the gn files automatically... so unless you're
buil
@@ -0,0 +1,1037 @@
+//===-- ExpandVariadicsPass.cpp *- C++ -*-=//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,1037 @@
+//===-- ExpandVariadicsPass.cpp *- C++ -*-=//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,1037 @@
+//===-- ExpandVariadicsPass.cpp *- C++ -*-=//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,1037 @@
+//===-- ExpandVariadicsPass.cpp *- C++ -*-=//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,1037 @@
+//===-- ExpandVariadicsPass.cpp *- C++ -*-=//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,1037 @@
+//===-- ExpandVariadicsPass.cpp *- C++ -*-=//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,1037 @@
+//===-- ExpandVariadicsPass.cpp *- C++ -*-=//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,1037 @@
+//===-- ExpandVariadicsPass.cpp *- C++ -*-=//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,1037 @@
+//===-- ExpandVariadicsPass.cpp *- C++ -*-=//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
owenca wrote:
> > Ping
>
> Your PR is a draft, otherwise it would have been auto tagged and reviewers
> would be informed.
@GertyP can you remove the Draft status?
https://github.com/llvm/llvm-project/pull/89956
___
cfe-commits mailing list
cfe-comm
https://github.com/ergawy updated
https://github.com/llvm/llvm-project/pull/93920
>From 926cf8d19c625880c303aff0527e2e6e8a1629bd Mon Sep 17 00:00:00 2001
From: ergawy
Date: Thu, 30 May 2024 23:16:39 -0500
Subject: [PATCH 1/3] [OpenMP][][LLVM] Update alloca IP after `PrivCB` in
`OMPIRBUIlder`
efriedma-quic wrote:
Since nothing should be using preserve_none on aarch64 yet, it's probably fine
to just fix forward.
> I'm not sure under what conditions issues present for this
We only allocate a base pointer under restricted circumstances (primarily,
functions with dynamic allocation),
Author: Younan Zhang
Date: 2024-06-04T12:44:01+08:00
New Revision: 3d361b225fe89ce1d8c93639f27d689082bd8dad
URL:
https://github.com/llvm/llvm-project/commit/3d361b225fe89ce1d8c93639f27d689082bd8dad
DIFF:
https://github.com/llvm/llvm-project/commit/3d361b225fe89ce1d8c93639f27d689082bd8dad.diff
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/93206
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -635,6 +635,17 @@ void LoopInfoStack::push(BasicBlock *Header,
clang::ASTContext &Ctx,
Option = LoopHintAttr::UnrollCount;
State = LoopHintAttr::Numeric;
}
+} else if (HLSLLoopHint) {
+ ValueInt = HLSLLoopHint->getDirective();
+ if (HLSLL
https://github.com/dmpots edited https://github.com/llvm/llvm-project/pull/93879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/dmpots approved this pull request.
https://github.com/llvm/llvm-project/pull/93879
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/mizvekov created
https://github.com/llvm/llvm-project/pull/94311
This removes a workaround for template template arguments pointing to older
template declarations, which don't have the most recent default argument
definition.
The removed workaround was introduced in
1abacf
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Matheus Izvekov (mizvekov)
Changes
This removes a workaround for template template arguments pointing to older
template declarations, which don't have the most recent default argument
definition.
The removed workaround was introduced in
owenca wrote:
IMO breaking before a trailing comment is a bug. Can we fix it without adding
an option? If not, we should add one (e.g. `BreakBeforeTrailingComment`)
instead of using `AlignTrailingComments`.
https://github.com/llvm/llvm-project/pull/89956
___
https://github.com/owenca edited https://github.com/llvm/llvm-project/pull/77522
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4650,10 +4650,23 @@ struct FormatStyle {
/// # Should be declared this way:
/// SpacesInParens: Custom
/// SpacesInParensOptions:
+ /// ExceptDoubleParentheses: false
/// InConditionalStatements: true
/// Other: true
/// \endcode
struct
@@ -1175,8 +1176,8 @@ template <> struct MappingTraits {
(SpacesInParentheses || SpaceInEmptyParentheses ||
SpacesInConditionalStatement || SpacesInCStyleCastParentheses)) {
if (SpacesInParentheses) {
-// set all options except InCStyleCasts and I
@@ -4681,23 +4695,30 @@ struct FormatStyle {
bool InEmptyParentheses;
/// Put a space in parentheses not covered by preceding options.
/// \code
-///true: false:
-///t f( Deleted & ) & = delete; vs. t f(Deleted
https://github.com/owenca commented:
Do we need all these new test cases? If yes, consider moving the test (and
other `ConfigurableSpacesIn...` tests) to a separate file.
https://github.com/llvm/llvm-project/pull/77522
___
cfe-commits mailing list
cfe
Author: martinboehme
Date: 2024-06-04T08:32:29+02:00
New Revision: 68761a9e05693bd3986e46628e401c80a27e945d
URL:
https://github.com/llvm/llvm-project/commit/68761a9e05693bd3986e46628e401c80a27e945d
DIFF:
https://github.com/llvm/llvm-project/commit/68761a9e05693bd3986e46628e401c80a27e945d.diff
https://github.com/martinboehme closed
https://github.com/llvm/llvm-project/pull/94217
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Vladimir Vereschaka
Date: 2024-06-03T23:33:42-07:00
New Revision: f4d60e2a744463bc624cbb1b35de5a36eed6aaae
URL:
https://github.com/llvm/llvm-project/commit/f4d60e2a744463bc624cbb1b35de5a36eed6aaae
DIFF:
https://github.com/llvm/llvm-project/commit/f4d60e2a744463bc624cbb1b35de5a36eed6aaae
https://github.com/vvereschaka closed
https://github.com/llvm/llvm-project/pull/94300
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ChuanqiXu9 wrote:
Thanks for reporting. I've reproduced them (including the lldb test) locally
and fixed them. I'll try to land it again to see what happens.
https://github.com/llvm/llvm-project/pull/92083
___
cfe-commits mailing list
cfe-commits@list
Author: Chuanqi Xu
Date: 2024-06-04T14:45:00+08:00
New Revision: d8ec452db016f359feeec28994f6560b30b49824
URL:
https://github.com/llvm/llvm-project/commit/d8ec452db016f359feeec28994f6560b30b49824
DIFF:
https://github.com/llvm/llvm-project/commit/d8ec452db016f359feeec28994f6560b30b49824.diff
LO
401 - 473 of 473 matches
Mail list logo
