[clang] [HLSL] add loop unroll (PR #93879)

2024-06-03 Thread Justin Bogner via cfe-commits
https://github.com/bogner edited https://github.com/llvm/llvm-project/pull/93879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] add loop unroll (PR #93879)

2024-06-03 Thread Justin Bogner via cfe-commits
@@ -114,18 +114,21 @@ Parser::ParseStatementOrDeclaration(StmtVector &Stmts, // here because we don't want to allow arbitrary orderings. ParsedAttributes CXX11Attrs(AttrFactory); MaybeParseCXX11Attributes(CXX11Attrs, /*MightBeObjCMessageSend*/ true); - ParsedAttributes G

[clang] [HLSL] add loop unroll (PR #93879)

2024-06-03 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/93879 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Remove a bunch of unnecessary REQUIRES constraints (PR #94055)

2024-06-03 Thread Paul T Robinson via cfe-commits
pogo59 wrote: FTR, when I say I could not reproduce on X86 Windows, exactly what I did is build on an X86 Windows host but include only the AArch64 target. The test passed. https://github.com/llvm/llvm-project/pull/94055 ___ cfe-commits mailing list

[clang] [HLSL] add loop unroll (PR #93879)

2024-06-03 Thread Tex Riddell via cfe-commits
@@ -635,6 +635,17 @@ void LoopInfoStack::push(BasicBlock *Header, clang::ASTContext &Ctx, Option = LoopHintAttr::UnrollCount; State = LoopHintAttr::Numeric; } +} else if (HLSLLoopHint) { + ValueInt = HLSLLoopHint->getDirective(); + if (HLSLL

[clang] [Driver] Remove a bunch of unnecessary REQUIRES constraints (PR #94055)

2024-06-03 Thread Jessica Clarke via cfe-commits
jrtc27 wrote: Looks like the buildbots' -DDEFAULT_SYSROOT strikes again (boo...). I think adding --sysroot="" is a common way to handle this for tests. https://github.com/llvm/llvm-project/pull/94055 ___ cfe-commits mailing list cfe-commits@lists.llvm

[clang] [Driver] Remove a bunch of unnecessary REQUIRES constraints (PR #94055)

2024-06-03 Thread Vladimir Vereschaka via cfe-commits
vvereschaka wrote: >FTR, when I say I could not reproduce on X86 Windows, exactly what I did is >build on an X86 Windows host but include only the AArch64 target. The test >passed. got it, thank you. I took a closer look to the failures and I found that most of them (except Clang::hexagon-too

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Anton Korobeynikov via cfe-commits
asl wrote: Tagging @slydiman @vvereschaka https://github.com/llvm/llvm-project/pull/94208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 13f6797 - [clang-format] Handle AttributeMacros in parseRecord() (#94189)

2024-06-03 Thread via cfe-commits
Author: Owen Pan Date: 2024-06-03T12:55:10-07:00 New Revision: 13f6797826faedb910c7e8b1dfc1f134f3cef342 URL: https://github.com/llvm/llvm-project/commit/13f6797826faedb910c7e8b1dfc1f134f3cef342 DIFF: https://github.com/llvm/llvm-project/commit/13f6797826faedb910c7e8b1dfc1f134f3cef342.diff LOG:

[clang] [clang-format] Handle AttributeMacros in parseRecord() (PR #94189)

2024-06-03 Thread Owen Pan via cfe-commits
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/94189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix the sysroot.c test properly (PR #94276)

2024-06-03 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 created https://github.com/llvm/llvm-project/pull/94276 A DEFAULT_SYSROOT interfered with the test, apparently. See #95055. >From c89183017ef9719c92077c1be6fd282e22a98e4e Mon Sep 17 00:00:00 2001 From: Paul Robinson Date: Mon, 3 Jun 2024 12:43:59 -0700 Subject: [PATCH

[clang] [Driver] Fix the sysroot.c test properly (PR #94276)

2024-06-03 Thread Paul T Robinson via cfe-commits
pogo59 wrote: Pls try in your environments to see if this solves the problem. https://github.com/llvm/llvm-project/pull/94276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix the sysroot.c test properly (PR #94276)

2024-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Paul T Robinson (pogo59) Changes A DEFAULT_SYSROOT interfered with the test, apparently. See #95055. --- Full diff: https://github.com/llvm/llvm-project/pull/94276.diff 1 Files Affected: - (modified) clang/test/Driver/sysroot.c (+2-4)

[clang] [Driver] Fix the sysroot.c test properly (PR #94276)

2024-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Paul T Robinson (pogo59) Changes A DEFAULT_SYSROOT interfered with the test, apparently. See #95055. --- Full diff: https://github.com/llvm/llvm-project/pull/94276.diff 1 Files Affected: - (modified) clang/test/Driver/sysroot.c (

[clang] [Driver] Fix the sysroot.c test properly (PR #94276)

2024-06-03 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 edited https://github.com/llvm/llvm-project/pull/94276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix the sysroot.c test properly (PR #94276)

2024-06-03 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 updated https://github.com/llvm/llvm-project/pull/94276 >From b4b78efe9c8119e6b4b1f539847e5678808bf715 Mon Sep 17 00:00:00 2001 From: Paul Robinson Date: Mon, 3 Jun 2024 12:43:59 -0700 Subject: [PATCH] [Driver] Fix the sysroot.c test properly A DEFAULT_SYSROOT interfe

[clang] [Driver] Fix the sysroot.c test properly (PR #94276)

2024-06-03 Thread Jessica Clarke via cfe-commits
https://github.com/jrtc27 approved this pull request. Didn't reproduce it myself, just worked out the problem from the build log. If this test still works locally for you then this should fix it. https://github.com/llvm/llvm-project/pull/94276 ___ cfe

[clang] [HLSL] Strict Availability Diagnostics (PR #93860)

2024-06-03 Thread Helena Kotas via cfe-commits
https://github.com/hekota updated https://github.com/llvm/llvm-project/pull/93860 >From 532f10f77c862f6d429366f0d6903773da8fa79b Mon Sep 17 00:00:00 2001 From: Helena Kotas Date: Thu, 30 May 2024 11:40:27 -0700 Subject: [PATCH 1/2] Implement HLSL strict diagnostic mode --- clang/include/clang

[clang] [clang][deps] Collect discovered module dependencies' Link Libraries (PR #93588)

2024-06-03 Thread Artem Chikin via cfe-commits
https://github.com/artemcm updated https://github.com/llvm/llvm-project/pull/93588 >From f69fd6e79ca7232672b4b3759253e818e8b2cec7 Mon Sep 17 00:00:00 2001 From: artemcm Date: Fri, 24 May 2024 15:13:45 -0700 Subject: [PATCH] [clang][deps] Collect discovered module dependencies' Link Libraries

[clang] e783d5d - [Driver] Fix the sysroot.c test properly (#94276)

2024-06-03 Thread via cfe-commits
Author: Paul T Robinson Date: 2024-06-03T16:09:23-04:00 New Revision: e783d5dbb6d61579bf941d310160a0ae259c7bec URL: https://github.com/llvm/llvm-project/commit/e783d5dbb6d61579bf941d310160a0ae259c7bec DIFF: https://github.com/llvm/llvm-project/commit/e783d5dbb6d61579bf941d310160a0ae259c7bec.dif

[clang] [Driver] Fix the sysroot.c test properly (PR #94276)

2024-06-03 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 closed https://github.com/llvm/llvm-project/pull/94276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CUDA] Mark CUDA-12.5 as supported and introduce ptx 8.5. (PR #94113)

2024-06-03 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B approved this pull request. https://github.com/llvm/llvm-project/pull/94113 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Fix the sysroot.c test properly (PR #94276)

2024-06-03 Thread Vladimir Vereschaka via cfe-commits
vvereschaka wrote: I'm still building the toolchain in my environment. I'll let you known the test results. https://github.com/llvm/llvm-project/pull/94276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [llvm] [Support] Add SipHash-based 16/64-bit ptrauth stable hash. (PR #93902)

2024-06-03 Thread Daniil Kovalev via cfe-commits
https://github.com/kovdan01 edited https://github.com/llvm/llvm-project/pull/93902 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Support] Add SipHash-based 16/64-bit ptrauth stable hash. (PR #93902)

2024-06-03 Thread Daniil Kovalev via cfe-commits
https://github.com/kovdan01 commented: As far as I understand, we want to take reference SipHash implementation with minimal changes. I personally have no issues with taking cryptographic C code "as is" with minimal changes. If it is the intention, LGTM with several minor comments. Anyway, I

[clang] [llvm] [Support] Add SipHash-based 16/64-bit ptrauth stable hash. (PR #93902)

2024-06-03 Thread Daniil Kovalev via cfe-commits
@@ -0,0 +1,43 @@ +//===- llvm/unittest/Support/SipHashTest.cpp --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] [Support] Add SipHash-based 16/64-bit ptrauth stable hash. (PR #93902)

2024-06-03 Thread Daniil Kovalev via cfe-commits
@@ -0,0 +1,47 @@ +//===--- SipHash.h - An ABI-stable string SipHash ---*- C++ -*-===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [llvm] [Support] Add SipHash-based 16/64-bit ptrauth stable hash. (PR #93902)

2024-06-03 Thread Daniil Kovalev via cfe-commits
@@ -0,0 +1,174 @@ +//===--- StableHash.cpp - An ABI-stable string hash ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [Support] Add SipHash-based 16/64-bit ptrauth stable hash. (PR #93902)

2024-06-03 Thread Daniil Kovalev via cfe-commits
@@ -0,0 +1,174 @@ +//===--- StableHash.cpp - An ABI-stable string hash ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [llvm] [Support] Add SipHash-based 16/64-bit ptrauth stable hash. (PR #93902)

2024-06-03 Thread Daniil Kovalev via cfe-commits
@@ -0,0 +1,174 @@ +//===--- StableHash.cpp - An ABI-stable string hash ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Ap

[clang] [Driver] Remove a bunch of unnecessary REQUIRES constraints (PR #94055)

2024-06-03 Thread Fangrui Song via cfe-commits
MaskRay wrote: > Looks like the buildbots' -DDEFAULT_SYSROOT strikes again (boo...). I think > adding --sysroot="" is a common way to handle this for tests. I think `DEFAULT_SYSROOT` should be phased out. Downstream users can customize CMake `DEFAULT_SYSROOT` to set the default `--sysroot=`, b

[clang] [llvm] [AArch64] Decouple feature dependency expansion. (PR #94279)

2024-06-03 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea created https://github.com/llvm/llvm-project/pull/94279 The dependency expansion step which was introduced by FMV has been erroneously used for non-FMV features, for example when parsing the target attribute. The PR #93695 has rectified most of the tests which were

[clang] [llvm] [AArch64] Decouple feature dependency expansion. (PR #94279)

2024-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Alexandros Lamprineas (labrinea) Changes The dependency expansion step which was introduced by FMV has been erroneously used for non-FMV features, for example when parsing the target attribute. The PR #93695 has rectified most of the test

[clang] [llvm] [AArch64] Decouple feature dependency expansion. (PR #94279)

2024-06-03 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 875e91131847e3133d414c11c8ad721b52a287ee 2f15ae2082c996918f11076ef765914434dd615c --

[clang] [Driver] Remove a bunch of unnecessary REQUIRES constraints (PR #94055)

2024-06-03 Thread Fangrui Song via cfe-commits
MaskRay wrote: > > The best I can do is mark them UNSUPPORTED: system-windows to get the bots > > green again. > > This is not a good idea. You will disable these tests for the appropriate > cross builders for no reason and they will became useless for them. I would > strongly recommend to re

[clang] 5cb0078 - Add option to generate additional debug info for expression dereferencing pointer to pointers. (#94100)

2024-06-03 Thread via cfe-commits
Author: William Junda Huang Date: 2024-06-03T16:42:24-04:00 New Revision: 5cb00785aa56d4acc97b083df5305d2959f6bd4a URL: https://github.com/llvm/llvm-project/commit/5cb00785aa56d4acc97b083df5305d2959f6bd4a DIFF: https://github.com/llvm/llvm-project/commit/5cb00785aa56d4acc97b083df5305d2959f6bd4a

[clang] [Driver] Fix the sysroot.c test properly (PR #94276)

2024-06-03 Thread Vladimir Vereschaka via cfe-commits
vvereschaka wrote: The `clang/test/Driver/sysroot.c` test has passed in my environment. https://github.com/llvm/llvm-project/pull/94276 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add option to generate additional debug info for expression dereferencing pointer to pointers. (PR #94100)

2024-06-03 Thread William Junda Huang via cfe-commits
https://github.com/huangjd closed https://github.com/llvm/llvm-project/pull/94100 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Allow open brace with trailing comment (no line break) (PR #89956)

2024-06-03 Thread via cfe-commits
@@ -1429,6 +1429,37 @@ TEST_F(FormatTestComments, CommentsInStaticInitializers) { "0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // comment\n" "0x00, 0x00, 0x00, 0x00, 0x00, 0x00, // comment\n" "0x00, 0x00, 0x00, 0x00};

[clang] [clang] Fix self-capturing `__block` variables (PR #89475)

2024-06-03 Thread via cfe-commits
@@ -2764,6 +2794,9 @@ void CodeGenFunction::emitByrefStructureInit(const AutoVarEmission &emission) { auto layoutInfo = CGM.getObjCRuntime().BuildByrefLayout(CGM, type); storeHeaderField(layoutInfo, getPointerSize(), "byref.layout"); } + + if (emission.NeedsInitOnHe

[clang] [clang][CodeGen] `used` globals && the payloads for global ctors & dtors are globals (PR #93601)

2024-06-03 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/93601 >From 34b9646a38c6bdd0419dd9d2eb1bc847c4d16596 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Tue, 28 May 2024 20:09:15 +0100 Subject: [PATCH 1/5] Fix `emitUsed` to place `used` globals in the Global AS. Update

[clang] [llvm] [AArch64] Decouple feature dependency expansion. (PR #94279)

2024-06-03 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea updated https://github.com/llvm/llvm-project/pull/94279 >From a413428bb0fdcd45b4a251e385b6cc00ff6a0a2c Mon Sep 17 00:00:00 2001 From: Alexandros Lamprineas Date: Mon, 3 Jun 2024 19:57:49 +0100 Subject: [PATCH] [AArch64] Decouple feature dependency expansion. The dep

[clang] [Driver] Remove a bunch of unnecessary REQUIRES constraints (PR #94055)

2024-06-03 Thread Vladimir Vereschaka via cfe-commits
vvereschaka wrote: @MaskRay >// UNSUPPORTED: system-windows was a fairly reasonable workaround, after the >previously imprecise // REQUIRES: x86-registered-target had been removed. I'm not quite agree here, sorry. That kind of workarounds disable the tests for the cross platform builders on th

[clang] [clang-format] Allow open brace with trailing comment (no line break) (PR #89956)

2024-06-03 Thread via cfe-commits
GertyP wrote: > The comments are not aligned in your example, that does not seem to be the > right option to hook on. I think I've misunderstood your point: A trailing comments alignment style of 'leave' (i.e. "don't mess around in any way with my trailing comments") seems the most suitable

[clang] [compiler-rt] [compiler-rt] Realtime Sanitizer: Introduce RADSan backend (PR #92460)

2024-06-03 Thread Chris Apple via cfe-commits
https://github.com/cjappl edited https://github.com/llvm/llvm-project/pull/92460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [AArch64] Decouple feature dependency expansion. (PR #94279)

2024-06-03 Thread Alexandros Lamprineas via cfe-commits
@@ -27,7 +27,7 @@ int main(void) { (void)__builtin_cpu_supports("x86-64-v4"); (void)__builtin_cpu_supports("x86-64-v5"); // expected-warning {{invalid cpu feature string for builtin}} #else - if (__builtin_cpu_supports("neon")) // expected-warning {{invalid cpu feature s

[clang] [Driver] Remove a bunch of unnecessary REQUIRES constraints (PR #94055)

2024-06-03 Thread Vladimir Vereschaka via cfe-commits
vvereschaka wrote: >I think requiring all driver tests pass with a custom DEFAULT_SYSROOT is an >undue burden. >Do you know why llvm-zorg/buildbot/osuosl/master/config/builders.py >llvm-clang-win-x-aarch64 needs to set DEFAULT_SYSROOT? This is the arm toolchain builders. They build a whole tool

[clang] [llvm] [AArch64] Decouple feature dependency expansion. (PR #94279)

2024-06-03 Thread Alexandros Lamprineas via cfe-commits
@@ -579,6 +537,62 @@ inline constexpr CpuInfo CpuInfos[] = { AArch64::AEK_SSBS, AArch64::AEK_CSSC})}, }; +struct ExtensionSet { labrinea wrote: This has to move after the definition of `ArchInfo` because the method `toLLVMFeatu

[clang] [llvm] [AArch64] Decouple feature dependency expansion. (PR #94279)

2024-06-03 Thread Alexandros Lamprineas via cfe-commits
@@ -106,7 +106,7 @@ def FeatureFPARMv8 : Extension<"fp-armv8", "FPARMv8", "Enable ARMv8 (FEAT_FP)", [], "FEAT_FP", "+fp-armv8,+neon", 90>; -let ArchExtKindSpelling = "AEK_SIMD", MArchName = "simd" in +let ArchExtKindSpelling = "AEK_SIMD", MArchName = "simd", MArchAlias = "

[clang] [compiler-rt] [compiler-rt] Realtime Sanitizer: Introduce Realtime Sanitizer (RTSan) backend (PR #92460)

2024-06-03 Thread Chris Apple via cfe-commits
https://github.com/cjappl edited https://github.com/llvm/llvm-project/pull/92460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [compiler-rt] Realtime Sanitizer: Introduce Realtime Sanitizer (RTSan) backend (PR #92460)

2024-06-03 Thread Chris Apple via cfe-commits
https://github.com/cjappl edited https://github.com/llvm/llvm-project/pull/92460 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Comments] Support for parsing headers in Doxygen \par commands (PR #91100)

2024-06-03 Thread via cfe-commits
https://github.com/hdoc updated https://github.com/llvm/llvm-project/pull/91100 >From 2b1845352b0ea27f027c94e406cd32ae8a1e94d1 Mon Sep 17 00:00:00 2001 From: hdoc Date: Sat, 4 May 2024 18:50:16 -0700 Subject: [PATCH 1/3] Support for parsing headers in Doxygen \par commands --- .../include/clan

[clang] [clang][deps] Collect discovered module dependencies' Link Libraries (PR #93588)

2024-06-03 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/93588 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Comments] Support for parsing headers in Doxygen \par commands (PR #91100)

2024-06-03 Thread via cfe-commits
@@ -149,6 +149,63 @@ class TextTokenRetokenizer { addToken(); } + /// Check if this line starts with @par or \par + bool startsWithParCommand() { +unsigned Offset = 1; + +/// Skip all whitespace characters at the beginning. +/// This needs to backtrack beca

[clang] [clang CodeGen] Restrict return statements nested in return statements. (PR #94282)

2024-06-03 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic created https://github.com/llvm/llvm-project/pull/94282 The construct has unclear semantics in general, and it's not really interesting to try to support. So diagnose it. Some subset of the cases this rejects might be possible to handle, if this shows up in pr

[clang] [clang CodeGen] Restrict return statements nested in return statements. (PR #94282)

2024-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: Eli Friedman (efriedma-quic) Changes The construct has unclear semantics in general, and it's not really interesting to try to support. So diagnose it. Some subset of the cases this rejects might be possible to handle, if this sh

[clang] [C++20] [Modules] [Itanium ABI] Generate the vtable in the module unit of dynamic classes (PR #75912)

2024-06-03 Thread David Blaikie via cfe-commits
@@ -1180,6 +1185,21 @@ bool CodeGenVTables::isVTableExternal(const CXXRecordDecl *RD) { TSK == TSK_ExplicitInstantiationDefinition) return false; + // Itanium C++ ABI [5.2.3]: + // Virtual tables for dynamic classes are emitted as follows: + // + // - If the cla

[clang] [lldb] [llvm] Remove some `try_compile` CMake checks for compiler flags (PR #92953)

2024-06-03 Thread Chris Apple via cfe-commits
cjappl wrote: Hi @Endilll I did a git bisect that pointed to this change as the one blocking my compilation on an Ubuntu docker image with clang 14.0 The error I see: ``` CMake Error at /test_radsan/llvm-project/compiler-rt/cmake/Modules/CheckSectionExists.cmake:72 (message): cc: error:

[clang] [Sema] Fix handling of fields with initializers in nested anonymous unions. (PR #91692)

2024-06-03 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: Ping https://github.com/llvm/llvm-project/pull/91692 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Driver] Remove a bunch of unnecessary REQUIRES constraints (PR #94055)

2024-06-03 Thread Fangrui Song via cfe-commits
MaskRay wrote: > > I think requiring all driver tests pass with a custom DEFAULT_SYSROOT is an > > undue burden. > > Do you know why llvm-zorg/buildbot/osuosl/master/config/builders.py > > llvm-clang-win-x-aarch64 needs to set DEFAULT_SYSROOT? > > This is the arm toolchain builders. They build

[clang] [clang][RISCV] Enable RVV with function attribute __attribute__((target("arch=+v"))) (PR #83674)

2024-06-03 Thread Camel Coder via cfe-commits
camel-cdr wrote: FYI, the example code you shown doesn't compile anymore: https://godbolt.org/z/ooTWEGejf This feature is quite important, without it we can't compile in RVV by default in a lot of libraries, e.g. simdutf, flac, ... https://github.com/llvm/llvm-project/pull/83674 _

[clang] [Clang][Comments] Add argument parsing for @throw @throws @exception (PR #84726)

2024-06-03 Thread via cfe-commits
https://github.com/hdoc updated https://github.com/llvm/llvm-project/pull/84726 >From ec3f444913d9162de4494cdb09b336b1b00380fa Mon Sep 17 00:00:00 2001 From: hdoc Date: Mon, 11 Mar 2024 01:13:25 -0700 Subject: [PATCH 01/10] Comment parsing: add argument parsing for @throw @throws @exception Do

[clang] [lldb] [llvm] Remove some `try_compile` CMake checks for compiler flags (PR #92953)

2024-06-03 Thread Fangrui Song via cfe-commits
MaskRay wrote: > Hi @Endilll > > I did a git bisect that pointed to this change as the one blocking my > compilation on an Ubuntu docker image with clang 14.0 > > The error I see: > > ``` > CMake Error at > /test_radsan/llvm-project/compiler-rt/cmake/Modules/CheckSectionExists.cmake:72 > (m

[clang] [Clang][Comments] Add argument parsing for @throw @throws @exception (PR #84726)

2024-06-03 Thread via cfe-commits
@@ -295,6 +367,7 @@ Parser::parseCommandArgs(TextTokenRetokenizer &Retokenizer, unsigned NumArgs) { Comment::Argument[NumArgs]; unsigned ParsedArgs = 0; Token Arg; + hdoc wrote: Fixed, I try to keep the clang-format changes restricted to only the re

[clang] [Clang][Comments] Add argument parsing for @throw @throws @exception (PR #84726)

2024-06-03 Thread via cfe-commits
@@ -100,6 +100,11 @@ class Parser { ArrayRef parseCommandArgs(TextTokenRetokenizer &Retokenizer, unsigned NumArgs); + /// Parse arguments for \\throws command supported args are in form of class hdoc wrote: Fixed https://github.com/llvm/llvm-project/pul

[clang] [Clang][Comments] Add argument parsing for @throw @throws @exception (PR #84726)

2024-06-03 Thread via cfe-commits
@@ -89,6 +89,31 @@ class TextTokenRetokenizer { } } + /// Extract a template type + bool lexTemplate(SmallString<32> &WordText) { +unsigned IncrementCounter = 0; +while (!isEnd()) { + const char C = peek(); + WordText.push_back(C); + consumeChar(

[clang] [Clang][Comments] Add argument parsing for @throw @throws @exception (PR #84726)

2024-06-03 Thread via cfe-commits
@@ -89,6 +89,31 @@ class TextTokenRetokenizer { } } + /// Extract a template type + bool lexTemplate(SmallString<32> &WordText) { +unsigned IncrementCounter = 0; hdoc wrote: That's a much better name, fixed and thank you. https://github.com/llvm/

[clang] [Clang][Comments] Add argument parsing for @throw @throws @exception (PR #84726)

2024-06-03 Thread via cfe-commits
@@ -149,6 +174,54 @@ class TextTokenRetokenizer { addToken(); } + /// Extract a type argument + bool lexType(Token &Tok) { +if (isEnd()) + return false; + +// Save current position in case we need to rollback because the type is +// empty. +Positio

[clang] [lldb] [llvm] Remove some `try_compile` CMake checks for compiler flags (PR #92953)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: Yes, some try_compile checks where replaced with a check for `CMAKE_CXX_COMPILER_ID`, so it's crucial for it to reflect the reality. https://github.com/llvm/llvm-project/pull/92953 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [clang] Add tests for Core issues about friend templates (PR #94288)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/94288 This patch covers the following Core issues: [CWG1862](https://cplusplus.github.io/CWG/issues/1862.html) "Determining “corresponding members” for friendship" [CWG1918](https://cplusplus.github.io/CWG/issues/1918.

[clang] [clang] Add tests for Core issues about friend templates (PR #94288)

2024-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes This patch covers the following Core issues: [CWG1862](https://cplusplus.github.io/CWG/issues/1862.html) "Determining “corresponding members” for friendship" [CWG1918](https://cplusplus.github.io/CWG/is

[clang] [llvm] [clang][CodeGen] `used` globals && the payloads for global ctors & dtors are globals (PR #93601)

2024-06-03 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/93601 >From 34b9646a38c6bdd0419dd9d2eb1bc847c4d16596 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Tue, 28 May 2024 20:09:15 +0100 Subject: [PATCH 1/6] Fix `emitUsed` to place `used` globals in the Global AS. Update

[clang] [llvm] [AArch64] Fix feature flags dependecies (PR #90612)

2024-06-03 Thread Ahmed Bougacha via cfe-commits
ahmedbougacha wrote: > The overall idea is that system registers ought be available everywhere > without the need to explicitly enable them with a command line option. Interesting, that's kind of what I'm getting at: longer term, are you saying you folks are considering removing the feature pr

[clang] [Clang] Prevent null pointer dereference in target attribute mangling (PR #94228)

2024-06-03 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. https://github.com/llvm/llvm-project/pull/94228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ae1596a - [AArch64] Support preserve_none calling convention (#91046)

2024-06-03 Thread via cfe-commits
Author: antangelo Date: 2024-06-03T18:42:08-04:00 New Revision: ae1596a31a6fac2f4daafe1e256d4a5cf3742617 URL: https://github.com/llvm/llvm-project/commit/ae1596a31a6fac2f4daafe1e256d4a5cf3742617 DIFF: https://github.com/llvm/llvm-project/commit/ae1596a31a6fac2f4daafe1e256d4a5cf3742617.diff LOG

[clang] [llvm] [AArch64] Support preserve_none calling convention (PR #91046)

2024-06-03 Thread via cfe-commits
https://github.com/antangelo closed https://github.com/llvm/llvm-project/pull/91046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][CodeGen] `used` globals && the payloads for global ctors & dtors are globals (PR #93601)

2024-06-03 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/93601 >From 34b9646a38c6bdd0419dd9d2eb1bc847c4d16596 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Tue, 28 May 2024 20:09:15 +0100 Subject: [PATCH 1/6] Fix `emitUsed` to place `used` globals in the Global AS. Update

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Dmitry Vasilyev via cfe-commits
slydiman wrote: > First Windows CI results: LLDB unit tests do not even build. Please note the following for Windows setup: - We used cmake 3.25.3 because we got some issues with the latest cmake. - python prerequisites are: `python -m pip install swig pexpect psutil`. - Most gnu tools may be u

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > > First Windows CI results: LLDB unit tests do not even build. > > Please note the following for Windows setup: > > * We used cmake 3.25.3 because we got some issues with the latest cmake. > > * python prerequisites are: `python -m pip install swig pexpect psutil`. >

[clang] [llvm] [AArch64][SME] Save VG for unwind info when changing streaming-mode (PR #83301)

2024-06-03 Thread Eli Friedman via cfe-commits
@@ -8287,6 +8289,13 @@ AArch64TargetLowering::LowerCall(CallLoweringInfo &CLI, SDValue InGlue; if (RequiresSMChange) { + +if (Subtarget->hasSVE()) { efriedma-quic wrote: There are two different kinds of DWARF "unwind info"; one is the kind that's in

[clang] [clang-format] Add DiagHandler for getStyle function (PR #91317)

2024-06-03 Thread via cfe-commits
https://github.com/mydeveloperday commented: I don't have a major issue, but I think it needs a unit test otherwise we might forget how you are using it. https://github.com/llvm/llvm-project/pull/91317 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [clang-format] Add DiagHandler for getStyle function (PR #91317)

2024-06-03 Thread via cfe-commits
mydeveloperday wrote: I also think we need @owenca opinion https://github.com/llvm/llvm-project/pull/91317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [mlir] Avoid object libraries in the VS IDE (PR #93519)

2024-06-03 Thread Michael Kruse via cfe-commits
https://github.com/Meinersbur ready_for_review https://github.com/llvm/llvm-project/pull/93519 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [flang] [mlir] Avoid object libraries in the VS IDE (PR #93519)

2024-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mlir-core @llvm/pr-subscribers-mlir-gpu Author: Michael Kruse (Meinersbur) Changes As discussed in #89743, when using the Visual Studio solution generators, object library projects are displayed as a collection of non-editable *.obj files. To look for

[clang] [flang] [mlir] Avoid object libraries in the VS IDE (PR #93519)

2024-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-mlir-llvm Author: Michael Kruse (Meinersbur) Changes As discussed in #89743, when using the Visual Studio solution generators, object library projects are displayed as a collection of non-editable *.obj files. To look for the corresponding source files

[clang] [llvm] [clang][CodeGen] `used` globals && the payloads for global ctors & dtors are globals (PR #93601)

2024-06-03 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/93601 >From 34b9646a38c6bdd0419dd9d2eb1bc847c4d16596 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Tue, 28 May 2024 20:09:15 +0100 Subject: [PATCH 1/7] Fix `emitUsed` to place `used` globals in the Global AS. Update

[clang] [lldb] [llvm] Remove some `try_compile` CMake checks for compiler flags (PR #92953)

2024-06-03 Thread Chris Apple via cfe-commits
cjappl wrote: Thanks for your help! You were correct that cc was pointing to gcc. This is fixed when I updated my machine to use my known clang as the default compiler. For future archeologists, this meant (from [this answer](https://askubuntu.com/questions/1198087/how-to-set-clang-9-as-the-de

[clang] [Clang] Prevent null pointer dereference in target attribute mangling (PR #94228)

2024-06-03 Thread via cfe-commits
smanna12 wrote: Thank you @efriedma-quic for reviews! https://github.com/llvm/llvm-project/pull/94228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] ccaccc3 - [Clang] Prevent null pointer dereference in target attribute mangling (#94228)

2024-06-03 Thread via cfe-commits
Author: smanna12 Date: 2024-06-03T18:20:33-05:00 New Revision: ccaccc3367aa3d892ca31eb11d4bcea4979bead1 URL: https://github.com/llvm/llvm-project/commit/ccaccc3367aa3d892ca31eb11d4bcea4979bead1 DIFF: https://github.com/llvm/llvm-project/commit/ccaccc3367aa3d892ca31eb11d4bcea4979bead1.diff LOG:

[clang] [Clang] Prevent null pointer dereference in target attribute mangling (PR #94228)

2024-06-03 Thread via cfe-commits
https://github.com/smanna12 closed https://github.com/llvm/llvm-project/pull/94228 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/94208 >From 5c757153a3f462d40663add6a9ae7caf42272913 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Mon, 3 Jun 2024 13:33:36 +0300 Subject: [PATCH 1/5] Enable LLDB tests in pre-submit CI --- .ci/generate-bui

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/94208 >From 5c757153a3f462d40663add6a9ae7caf42272913 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Mon, 3 Jun 2024 13:33:36 +0300 Subject: [PATCH 1/6] Enable LLDB tests in pre-submit CI --- .ci/generate-bui

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/94208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll ready_for_review https://github.com/llvm/llvm-project/pull/94208 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add tests for Core issues about friend templates (PR #94288)

2024-06-03 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/94288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add tests for Core issues about friend templates (PR #94288)

2024-06-03 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: LGTM https://github.com/llvm/llvm-project/pull/94288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add tests for Core issues about friend templates (PR #94288)

2024-06-03 Thread Shafik Yaghmour via cfe-commits
@@ -373,6 +373,98 @@ namespace cwg1837 { // cwg1837: 3.3 #endif } +namespace cwg1862 { // cwg1862: no +template +struct A { + struct B { +void e(); + }; + + void f(); + + struct D { +void g(); + }; + + T h(); + + template + T i(); +}; + +template<> +struc

[clang] [clang] Add tests for Core issues about friend templates (PR #94288)

2024-06-03 Thread Shafik Yaghmour via cfe-commits
@@ -121,6 +145,21 @@ derived d2(42, 9); #endif } +namespace cwg1945 { // cwg1945: no +template struct A { + class B { +class C {}; + }; +}; +class X { + static int x; + // FIXME: this is ill-formed, because A::B::C does not end with a simple-template-id + template +

[clang] [clang] Add tests for Core issues about friend templates (PR #94288)

2024-06-03 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik approved this pull request. https://github.com/llvm/llvm-project/pull/94288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add tests for Core issues about friend templates (PR #94288)

2024-06-03 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/94288 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

<    1   2   3   4   5   >