[clang] a68638b - [C++20] [Modules] [Reduced BMI] Handling Deduction Guide in reduced BMI

2024-06-03 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2024-06-03T14:59:23+08:00 New Revision: a68638bf6a6a5cb60947753ccaf7d1de80f6c89e URL: https://github.com/llvm/llvm-project/commit/a68638bf6a6a5cb60947753ccaf7d1de80f6c89e DIFF: https://github.com/llvm/llvm-project/commit/a68638bf6a6a5cb60947753ccaf7d1de80f6c89e.diff LO

[clang] [Clang][Comments] Add argument parsing for @throw @throws @exception (PR #84726)

2024-06-03 Thread via cfe-commits
https://github.com/hdoc updated https://github.com/llvm/llvm-project/pull/84726 >From ec3f444913d9162de4494cdb09b336b1b00380fa Mon Sep 17 00:00:00 2001 From: hdoc Date: Mon, 11 Mar 2024 01:13:25 -0700 Subject: [PATCH 1/7] Comment parsing: add argument parsing for @throw @throws @exception Doxy

[clang] [Clang][Comments] Add argument parsing for @throw @throws @exception (PR #84726)

2024-06-03 Thread via cfe-commits
hdoc wrote: @cor3ntin we appreciate the feedback. Likewise, we agree that the home-grown parser just for parsing `type-id`s in comments is less than ideal. We had some alternative approaches in mind, like using an instance of `clang::Lexer`, but went with our original approach at first. I've

[clang] [Clang][Comments] Attach comments to decl even if preproc directives are in between (PR #88367)

2024-06-03 Thread via cfe-commits
@@ -107,6 +107,24 @@ ///The 2nd source tile. Max size is 1024 Bytes. #define _tile_cmmrlfp16ps(dst, a, b) __builtin_ia32_tcmmrlfp16ps(dst, a, b) +/// Perform matrix multiplication of two tiles containing complex elements and hdoc wrote: This is not an unr

[clang] [Clang][Comments] Attach comments to decl even if preproc directives are in between (PR #88367)

2024-06-03 Thread via cfe-commits
@@ -533,6 +533,8 @@ __rdtscp(unsigned int *__A) { /// \see __rdpmc #define _rdpmc(A) __rdpmc(A) +; hdoc wrote: If it sounds reasonable to you, I can fix this with the same method used in the `clang/lib/Headers/amxcomplexintrin.h` file. Unfortunately changing

[clang] [clang][analyzer] Move PutenvStackArrayChecker out of alpha package. (PR #93980)

2024-06-03 Thread Balázs Kéri via cfe-commits
@@ -1179,6 +1179,41 @@ security.insecureAPI.DeprecatedOrUnsafeBufferHandling (C) strncpy(buf, "a", 1); // warn } +.. _security-putenv-stack-array: + +security.PutenvStackArray (C) +" +Finds calls to the ``putenv`` function which pass a pointer t

[clang] [clang][analyzer] Move PutenvStackArrayChecker out of alpha package. (PR #93980)

2024-06-03 Thread Balázs Kéri via cfe-commits
@@ -1179,6 +1179,41 @@ security.insecureAPI.DeprecatedOrUnsafeBufferHandling (C) strncpy(buf, "a", 1); // warn } +.. _security-putenv-stack-array: + +security.PutenvStackArray (C) +" +Finds calls to the ``putenv`` function which pass a pointer t

[clang] [serialization] no transitive decl change (PR #92083)

2024-06-03 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: I'd like to land this since: - I want to give more time testing this - the design of the patch is pretty similar with the previous one (https://github.com/llvm/llvm-project/pull/86912) - the scale of the patch is not very big (100+ lines of code except new tests) - I do think t

[clang] [clang-format] Handle AttributeMacros in parseRecord() (PR #94189)

2024-06-03 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/94189 Fixes #94184. >From 45c818098c1eedd72b82e9b5362538e2781698ab Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Mon, 3 Jun 2024 00:40:18 -0700 Subject: [PATCH] [clang-format] Handle AttributeMacros in parseRecord() F

[clang] [clang-format] Handle AttributeMacros in parseRecord() (PR #94189)

2024-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes Fixes #94184. --- Full diff: https://github.com/llvm/llvm-project/pull/94189.diff 2 Files Affected: - (modified) clang/lib/Format/UnwrappedLineParser.cpp (+3-1) - (modified) clang/unittests/Format/Token

[clang] a41a20b - [NFC] [C++20] [Modules] [Reduced BMI] Reorder Emitting reduced BMI and normal BMI for named modules

2024-06-03 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2024-06-03T15:47:34+08:00 New Revision: a41a20bd47968b16bb84761578628752080e9f24 URL: https://github.com/llvm/llvm-project/commit/a41a20bd47968b16bb84761578628752080e9f24 DIFF: https://github.com/llvm/llvm-project/commit/a41a20bd47968b16bb84761578628752080e9f24.diff LO

[clang] [Clang] Fix crash on improper use of __array_extent (PR #94173)

2024-06-03 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/94173 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Move PutenvStackArrayChecker out of alpha package. (PR #93980)

2024-06-03 Thread Balázs Kéri via cfe-commits
https://github.com/balazske updated https://github.com/llvm/llvm-project/pull/93980 From 033c7c2187f4dcbd050c69c5279ae2dcfe02c529 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?= Date: Wed, 29 May 2024 16:47:42 +0200 Subject: [PATCH 1/2] [clang][analyzer] Move PutenvStackArray

[clang] [Clang] Fix crash on improper use of __array_extent (PR #94173)

2024-06-03 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. I've edited the title of the PR (which is then used as commit message) Please follow that style in the future (see also https://llvm.org/docs/DeveloperPolicy.html#commit-messages) The change itself looks fine, thanks! https://github.com/l

[clang] [Clang] Allow raw string literals in C as an extension (PR #88265)

2024-06-03 Thread via cfe-commits
cor3ntin wrote: > C has Unicode string literals as well: https://godbolt.org/z/chdjYrK9v and so > if we're allowing raw string literals, it makes sense to also allow raw > unicode string literals IMO. I don't think we need to rename the flag though. Yes, these things are completely orthogonal,

[clang] [Clang] Fix crash on improper use of __array_extent (PR #94173)

2024-06-03 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk updated https://github.com/llvm/llvm-project/pull/94173 >From b4f5d6d43d369649711cece6057c8fe2758a5a89 Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Mon, 3 Jun 2024 00:22:02 +0300 Subject: [PATCH 1/2] fix(80474): use expression error on incomplete __array_exten

[clang] f4a7f81 - [clang-format][doc] Minor cleanup

2024-06-03 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2024-06-03T01:04:05-07:00 New Revision: f4a7f81a914ca8aceddd9b7a71e36bb0828ae052 URL: https://github.com/llvm/llvm-project/commit/f4a7f81a914ca8aceddd9b7a71e36bb0828ae052 DIFF: https://github.com/llvm/llvm-project/commit/f4a7f81a914ca8aceddd9b7a71e36bb0828ae052.diff LOG:

[clang] [Clang][Comments] Add argument parsing for @throw @throws @exception (PR #84726)

2024-06-03 Thread via cfe-commits
https://github.com/cor3ntin commented: The general direction looks good now. I left a few nitpicky comments. Thanks! https://github.com/llvm/llvm-project/pull/84726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [Clang][Comments] Add argument parsing for @throw @throws @exception (PR #84726)

2024-06-03 Thread via cfe-commits
@@ -89,6 +89,31 @@ class TextTokenRetokenizer { } } + /// Extract a template type + bool lexTemplate(SmallString<32> &WordText) { +unsigned IncrementCounter = 0; +while (!isEnd()) { + const char C = peek(); + WordText.push_back(C); + consumeChar(

[clang] [Clang][Comments] Add argument parsing for @throw @throws @exception (PR #84726)

2024-06-03 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/84726 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Comments] Add argument parsing for @throw @throws @exception (PR #84726)

2024-06-03 Thread via cfe-commits
@@ -149,6 +174,54 @@ class TextTokenRetokenizer { addToken(); } + /// Extract a type argument + bool lexType(Token &Tok) { +if (isEnd()) + return false; + +// Save current position in case we need to rollback because the type is +// empty. +Positio

[clang] [Clang][Comments] Add argument parsing for @throw @throws @exception (PR #84726)

2024-06-03 Thread via cfe-commits
@@ -89,6 +89,31 @@ class TextTokenRetokenizer { } } + /// Extract a template type + bool lexTemplate(SmallString<32> &WordText) { +unsigned IncrementCounter = 0; cor3ntin wrote: `BracketCount` would be a better name https://github.com/llvm/llvm-p

[clang] [Clang][Comments] Add argument parsing for @throw @throws @exception (PR #84726)

2024-06-03 Thread via cfe-commits
@@ -295,6 +367,7 @@ Parser::parseCommandArgs(TextTokenRetokenizer &Retokenizer, unsigned NumArgs) { Comment::Argument[NumArgs]; unsigned ParsedArgs = 0; Token Arg; + cor3ntin wrote: Can you revert whitespace only changes? https://github.com/llvm/ll

[clang] [Clang][Comments] Add argument parsing for @throw @throws @exception (PR #84726)

2024-06-03 Thread via cfe-commits
@@ -100,6 +100,11 @@ class Parser { ArrayRef parseCommandArgs(TextTokenRetokenizer &Retokenizer, unsigned NumArgs); + /// Parse arguments for \\throws command supported args are in form of class cor3ntin wrote: ```suggestion /// Parse arguments for \th

[clang] [Clang][Comments] Add argument parsing for @throw @throws @exception (PR #84726)

2024-06-03 Thread via cfe-commits
@@ -149,6 +276,93 @@ class TextTokenRetokenizer { addToken(); } + /// Extract a type argument + bool lexType(Token &Tok) { +if (isEnd()) + return false; +Position SavedPos = Pos; +consumeWhitespace(); +SmallString<32> NextToken; +SmallString<32

[clang] ccb73e8 - [serialization] no transitive decl change (#92083)

2024-06-03 Thread via cfe-commits
Author: Chuanqi Xu Date: 2024-06-03T16:13:55+08:00 New Revision: ccb73e882b2d727877cfda42a14a6979cfd31f04 URL: https://github.com/llvm/llvm-project/commit/ccb73e882b2d727877cfda42a14a6979cfd31f04 DIFF: https://github.com/llvm/llvm-project/commit/ccb73e882b2d727877cfda42a14a6979cfd31f04.diff LO

[clang] [serialization] no transitive decl change (PR #92083)

2024-06-03 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 closed https://github.com/llvm/llvm-project/pull/92083 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Serialization] No transitive identifier change (PR #92085)

2024-06-03 Thread Chuanqi Xu via cfe-commits
https://github.com/ChuanqiXu9 edited https://github.com/llvm/llvm-project/pull/92085 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Pass LangOpts from CompilerInstance to DependencyScanningWorker (PR #93753)

2024-06-03 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. I think this makes sense. Thanks a lot for the fix https://github.com/llvm/llvm-project/pull/93753 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/li

[clang] [llvm] [AMDGPU] Extend readlane, writelane and readfirstlane intrinsic lowering for generic types (PR #89217)

2024-06-03 Thread Vikram Hegde via cfe-commits
vikramRH wrote: > You should add the mentioned convergence-tokens.ll test function Added the test in a separate test file https://github.com/llvm/llvm-project/pull/89217 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cg

[clang] [ClangFormat] Add DiagHandler for getStyle function (PR #91317)

2024-06-03 Thread via cfe-commits
pointhex wrote: Hi @mydeveloperday, friendly reminder :) https://github.com/llvm/llvm-project/pull/91317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() (PR #90043)

2024-06-03 Thread Paul Heidekrüger via cfe-commits
PBHDK wrote: > I am adding @leunam99 and @PBHDK to the PR, who will contribute in the next > few weeks. Since we cannot push to this PR, we will be submitting a new PR with @sebwolf-de's + our work, correct, @EugeneZelenko, @PiotrZSL, @HerrCai0907? https://github.com/llvm/llvm-project/pull/90

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() (PR #90043)

2024-06-03 Thread Manuel Pietsch via cfe-commits
@@ -0,0 +1,81 @@ +//===--- AvoidBoundsErrorsCheck.cpp - clang-tidy --===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] Enforce SL.con.3: Add check to replace operator[] with at() (PR #90043)

2024-06-03 Thread Manuel Pietsch via cfe-commits
@@ -0,0 +1,66 @@ +namespace std { + template + struct array { +T operator[](unsigned i) { + return T{1}; +} +T at(unsigned i) { + return T{1}; +} + }; + + template + struct unique_ptr { +T operator[](unsigned i) { + return T{1}; +} + };

[clang] [clang] Add tests for some CWG issues from 2024-05-31 telecon (PR #94167)

2024-06-03 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/94167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add tests for some CWG issues from 2024-05-31 telecon (PR #94167)

2024-06-03 Thread via cfe-commits
https://github.com/cor3ntin edited https://github.com/llvm/llvm-project/pull/94167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Add tests for some CWG issues from 2024-05-31 telecon (PR #94167)

2024-06-03 Thread via cfe-commits
@@ -180,3 +200,64 @@ void f() { } // namespace cwg2881 +namespace cwg2882 { // cwg2882: 2.7 tentatively ready 2024-05-31 +struct C { + operator void() = delete; + // expected-warning@-1 {{conversion function converting 'cwg2882::C' to 'void' will never be used}} + // cxx9

[clang] 8918d35 - [clang][Modules] Move `ASTSourceDescriptor` into its own file (#67930)

2024-06-03 Thread via cfe-commits
Author: David Stone Date: 2024-06-03T11:09:13+02:00 New Revision: 8918d35dbde126c95350b674a2bb102692d90260 URL: https://github.com/llvm/llvm-project/commit/8918d35dbde126c95350b674a2bb102692d90260 DIFF: https://github.com/llvm/llvm-project/commit/8918d35dbde126c95350b674a2bb102692d90260.diff L

[clang] [lldb] [clang][Modules] Move `ASTSourceDescriptor` into its own file (PR #67930)

2024-06-03 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/67930 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement resolution for CWG1835 (PR #92957)

2024-06-03 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: > > Per [[basic.lookup.qual.general] > > p1](http://eel.is/c++draft/basic.lookup.qual.general#1), lookup for a > > member-qualified name is type-only if it's an identifier followed by ::; > > Per my reading, type-only lookup is performed only for elaborated type > specifiers

[clang] [Clang] Implement resolution for CWG1835 (PR #92957)

2024-06-03 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian edited https://github.com/llvm/llvm-project/pull/92957 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Remove experimental from Zabha (PR #93831)

2024-06-03 Thread via cfe-commits
AlexGhiti wrote: > I'm guessing you don't have commit access? I don't think so indeed (?). Thanks for your quick review, Alex https://github.com/llvm/llvm-project/pull/93831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] 6b74449 - [RISCV] Remove experimental from Zabha (#93831)

2024-06-03 Thread via cfe-commits
Author: AlexGhiti Date: 2024-06-03T17:27:02+08:00 New Revision: 6b7444964a8d028989beee554a1f5c61d16a1cac URL: https://github.com/llvm/llvm-project/commit/6b7444964a8d028989beee554a1f5c61d16a1cac DIFF: https://github.com/llvm/llvm-project/commit/6b7444964a8d028989beee554a1f5c61d16a1cac.diff LOG

[clang] [llvm] [RISCV] Remove experimental from Zabha (PR #93831)

2024-06-03 Thread Yingwei Zheng via cfe-commits
https://github.com/dtcxzyw closed https://github.com/llvm/llvm-project/pull/93831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Remove experimental from Zabha (PR #93831)

2024-06-03 Thread via cfe-commits
github-actions[bot] wrote: @AlexGhiti Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a buil

[clang] 4f2dba3 - [clang] Add tests for some CWG issues from 2024-05-31 telecon (#94167)

2024-06-03 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2024-06-03T13:47:28+04:00 New Revision: 4f2dba3c0b4e5f11b968a840b5f70070f5288cfe URL: https://github.com/llvm/llvm-project/commit/4f2dba3c0b4e5f11b968a840b5f70070f5288cfe DIFF: https://github.com/llvm/llvm-project/commit/4f2dba3c0b4e5f11b968a840b5f70070f5288cfe.

[clang] [clang] Add tests for some CWG issues from 2024-05-31 telecon (PR #94167)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/94167 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ClangFormat] Add DiagHandler for getStyle function (PR #91317)

2024-06-03 Thread via cfe-commits
mydeveloperday wrote: Please log an issue explaining the problem you are trying solve, its not clear to me what problem led you to this. https://github.com/llvm/llvm-project/pull/91317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[clang] [Clang][Sema] Tweak tryCaptureVariable for unevaluated lambdas (PR #93206)

2024-06-03 Thread Younan Zhang via cfe-commits
@@ -1576,7 +1576,10 @@ ExprResult Parser::ParseLambdaExpressionAfterIntroducer( TrailingReturnTypeLoc, &DS), std::move(Attributes), DeclEndLoc); -Actions.ActOnLambdaClosureQualifiers(Intro, MutableLoc); +// We have called ActOnLa

[clang] [Clang][Sema] Tweak tryCaptureVariable for unevaluated lambdas (PR #93206)

2024-06-03 Thread Younan Zhang via cfe-commits
https://github.com/zyn0217 updated https://github.com/llvm/llvm-project/pull/93206 >From 658e9d46adf6dd79aa6aef03a1817444a880348a Mon Sep 17 00:00:00 2001 From: Younan Zhang Date: Thu, 23 May 2024 22:35:11 +0800 Subject: [PATCH 1/3] [Clang][Sema] Tweak tryCaptureVariable for unevaluated lambda

[clang] [clang-format] Handle AttributeMacros in parseRecord() (PR #94189)

2024-06-03 Thread via cfe-commits
https://github.com/mydeveloperday approved this pull request. https://github.com/llvm/llvm-project/pull/94189 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Add DiagHandler for getStyle function (PR #91317)

2024-06-03 Thread via cfe-commits
https://github.com/mydeveloperday edited https://github.com/llvm/llvm-project/pull/91317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Tweak tryCaptureVariable for unevaluated lambdas (PR #93206)

2024-06-03 Thread Younan Zhang via cfe-commits
zyn0217 wrote: @cor3ntin I have reduced the test cases (removed duplicate ones) and hopefully they look better. Can you please take another look? thanks! https://github.com/llvm/llvm-project/pull/93206 ___ cfe-commits mailing list cfe-commits@lists.ll

[clang] [clang][analyzer] Move PutenvStackArrayChecker out of alpha package (PR #93980)

2024-06-03 Thread Balazs Benics via cfe-commits
=?utf-8?q?Balázs_Kéri?= Message-ID: In-Reply-To: https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/93980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][analyzer] Move PutenvStackArrayChecker out of alpha package (PR #93980)

2024-06-03 Thread Balazs Benics via cfe-commits
=?utf-8?q?Bal=C3=A1zs_K=C3=A9ri?= Message-ID: In-Reply-To: https://github.com/steakhal approved this pull request. https://github.com/llvm/llvm-project/pull/93980 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [llvm] [OpenMP] OpenMP 5.1 "assume" directive parsing support (PR #92731)

2024-06-03 Thread Julian Brown via cfe-commits
https://github.com/jtb20 updated https://github.com/llvm/llvm-project/pull/92731 >From 4337a97fb8982addfd6740db2ff08dfb0398842e Mon Sep 17 00:00:00 2001 From: Julian Brown Date: Wed, 1 May 2024 06:35:59 -0500 Subject: [PATCH] [OpenMP] OpenMP 5.1 "assume" directive parsing support This is a mini

[clang] [clang] Make sure all C++ DR tests are running with `-pedantic-errors` (PR #94203)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/94203 In #94167 I found out that `cwg28xx.cpp` has been running without `-pedantic-errors` and fixed that. This patch fixes that for the rest of the test suite. Only one tests as affected with a trivial fix (warning w

[clang] [clang] Make sure all C++ DR tests are running with `-pedantic-errors` (PR #94203)

2024-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes In #94167 I found out that `cwg28xx.cpp` has been running without `-pedantic-errors` and fixed that. This patch fixes that for the rest of the test suite. Only one tests as affected with a trivial fix

[clang] [analyzer][NFC] Fix comparison to True/False (PR #94038)

2024-06-03 Thread Donát Nagy via cfe-commits
https://github.com/NagyDonat commented: This change follows both the letter and the spirit of PEP8. (Note that `True` and `False` are not "singletons like `None`" because the type `bool` has two possible values -- but different rules still claim that the original code was bad and the new code

[clang] [clang][analyzer] Improved PointerSubChecker (PR #93676)

2024-06-03 Thread Donát Nagy via cfe-commits
@@ -0,0 +1,74 @@ +// RUN: %clang_analyze_cc1 -analyzer-checker=alpha.core.PointerSub -verify %s + +void f1(void) { + int x, y, z[10]; + int d = &y - &x; // expected-warning{{Subtraction of two pointers that do not point into the same array is undefined behavior}} + d = z - &y;

[clang] Reapply "[Clang][CWG1815] Support lifetime extension of temporary created by aggregate initialization using a default member initializer" (PR #92527)

2024-06-03 Thread via cfe-commits
bgra8 wrote: heads-up @yronglin: we've bisected many compilation breakages to this patch. We're working on a reproducer. https://github.com/llvm/llvm-project/pull/92527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-

[clang] [clang-format] Add DiagHandler for getStyle function (PR #91317)

2024-06-03 Thread via cfe-commits
pointhex wrote: Done: https://github.com/llvm/llvm-project/issues/94205 https://github.com/llvm/llvm-project/pull/91317 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Move CWG2390 test into `cwg23xx.cpp` (PR #94206)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/94206 This patch refactors an existing test for [CWG2390](https://cplusplus.github.io/CWG/issues/2390.html) "Is the argument of `__has_cpp_attribute` macro-expanded?" to use `#error` instead of emitting a variable in

[clang] [clang] Make sure all C++ DR tests are running with `-pedantic-errors` (PR #94203)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/94203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Move CWG2390 test into `cwg23xx.cpp` (PR #94206)

2024-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes This patch refactors an existing test for [CWG2390](https://cplusplus.github.io/CWG/issues/2390.html) "Is the argument of `__has_cpp_attribute` macro-expanded?" to use `#error` instead of emitting a v

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/94208 None >From 5c757153a3f462d40663add6a9ae7caf42272913 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Mon, 3 Jun 2024 13:33:36 +0300 Subject: [PATCH 1/2] Enable LLDB tests in pre-submit CI --- .ci/genera

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-lldb Author: Vlad Serebrennikov (Endilll) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/94208.diff 2 Files Affected: - (modified) .ci/generate-buildkite-pipeline-premerge (+1-3) - (modified) clang/examples/PrintFunctionNames/Prin

[clang] [clang][analyzer] Move unix.BlockInCriticalSection out of alpha (PR #93815)

2024-06-03 Thread Endre Fülöp via cfe-commits
https://github.com/gamesh411 updated https://github.com/llvm/llvm-project/pull/93815 From 1da3d4dc3c74f1240e7d921c97b0c7eea2a53e33 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Endre=20F=C3=BCl=C3=B6p?= Date: Wed, 29 May 2024 00:38:07 +0200 Subject: [PATCH 1/2] [clang][analyzer] Move unix.BlockInCri

[clang] [clang][analyzer] Improved PointerSubChecker (PR #93676)

2024-06-03 Thread Donát Nagy via cfe-commits
NagyDonat wrote: > With the current version I have the following observations: > > * There is a warning for `(&x + 1) - &x` and `(&x - 1) - &x`. Should this > be fixed? The expression `(&x + 1) - &x` is valid and should not produce a warning. It could appear e.g. in code that's structured

[clang] [serialization] no transitive decl change (PR #92083)

2024-06-03 Thread Chuanqi Xu via cfe-commits
ChuanqiXu9 wrote: I'll close it as there are some crashes. --- The crash log: ``` ** TEST 'Clang :: Modules/redecl-ivars.m' FAILED Exit Code: 1 Command Output (stderr): -- RUN: at line 2: rm -rf /b/sanitizer-x86_64-linux-fast/build/llvm_build_asan_ubsan/tools/cla

[clang] 6b30180 - Revert "[serialization] no transitive decl change (#92083)"

2024-06-03 Thread Chuanqi Xu via cfe-commits
Author: Chuanqi Xu Date: 2024-06-03T18:49:18+08:00 New Revision: 6b30180b663e1fe4de32046398581a374c8a54f2 URL: https://github.com/llvm/llvm-project/commit/6b30180b663e1fe4de32046398581a374c8a54f2 DIFF: https://github.com/llvm/llvm-project/commit/6b30180b663e1fe4de32046398581a374c8a54f2.diff LO

[clang] [clang][analyzer] Move unix.BlockInCriticalSection out of alpha (PR #93815)

2024-06-03 Thread Balazs Benics via cfe-commits
Endre =?utf-8?q?F=C3=BCl=C3=B6p?= Message-ID: In-Reply-To: https://github.com/steakhal approved this pull request. https://github.com/llvm/llvm-project/pull/93815 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [serialization] no transitive decl change (PR #92083)

2024-06-03 Thread David Spickett via cfe-commits
DavidSpickett wrote: This also broke an lldb test: https://lab.llvm.org/buildbot/#/builders/96/builds/58449 `lldb-test: ../llvm-project/clang/lib/AST/DeclBase.cpp:132: void clang::Decl::setOwningModuleID(unsigned int): Assertion `!((*IDAddress) >> 48) && "We should only set the module ID once

[clang] [serialization] no transitive decl change (PR #92083)

2024-06-03 Thread Mitch Phillips via cfe-commits
hctim wrote: Hi from the sanitizer buildbot mainter, thanks for the fast revert! For full reproduction, you can use https://github.com/google/sanitizers/wiki/SanitizerBotReproduceBuild and `buildbot_fast.sh`. But, you can reproduce it quicker by using `-DCMAKE_C_FLAGS="-fsanitize=undefined"

[clang] [clang] Move CWG2390 test into `cwg23xx.cpp` (PR #94206)

2024-06-03 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/94206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Michael Buch via cfe-commits
Michael137 wrote: Worth a shot i guess. Though it could be somewhat disruptive if we do in fact have flaky tests. I don't think we need to run *all* tests. Should we just run the tests for the LLDB C++ language plugin (i.e., the part of LLDB that invokes Clang and the JIT). And then we could e

[clang] [serialization] no transitive decl change (PR #92083)

2024-06-03 Thread Michael Buch via cfe-commits
Michael137 wrote: I.e., also broke the macOS LLDB buildbots: https://green.lab.llvm.org/job/llvm.org/view/LLDB/job/lldb-cmake/2637/execution/node/97/log/ ``` Assertion failed: (!((*IDAddress) >> 48) && "We should only set the module ID once"), function setOwningModuleID, file DeclBase.cpp, lin

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > Should we just run the tests for the LLDB C++ language plugin (i.e., the part > of LLDB that invokes Clang and the JIT). And then we could expand the set of > tests from there later? In the bash script that currently handles this, "targets that we need to check if lldb is tes

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: First Windows CI results: LLDB unit tests do not even build. ``` FAILED: tools/lldb/unittests/Process/gdb-remote/CMakeFiles/ProcessGdbRemoteTests.dir/GDBRemoteCommunicationClientTest.cpp.obj sccache C:\BuildTools\VC\Tools\MSVC\14.29.30133\bin\Hostx64\x64\cl.exe /nologo /TP -DB

[clang] 9a7bd8a - remove goma support from clang (#93942)

2024-06-03 Thread via cfe-commits
Author: Takuto Ikuta Date: 2024-06-03T07:30:14-04:00 New Revision: 9a7bd8a60f03595be5d42315790df6d409f81091 URL: https://github.com/llvm/llvm-project/commit/9a7bd8a60f03595be5d42315790df6d409f81091 DIFF: https://github.com/llvm/llvm-project/commit/9a7bd8a60f03595be5d42315790df6d409f81091.diff

[clang] remove goma support from clang (PR #93942)

2024-06-03 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman closed https://github.com/llvm/llvm-project/pull/93942 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement resolution for CWG1835 (PR #92957)

2024-06-03 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: This does seem to cause an error in libstdc++: ``` include/c++/11/bits/shared_ptr.h:365:10: error: use 'template' keyword to treat '__shared_ptr' as a dependent template name this->__shared_ptr<_Tp>::operator=(__r); ^ ``` Since `this` is dependent (it's of t

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Michael Buch via cfe-commits
Michael137 wrote: > > Should we just run the tests for the LLDB C++ language plugin (i.e., the > > part of LLDB that invokes Clang and the JIT). And then we could expand the > > set of tests from there later? > > In the bash script that currently handles this, "targets that we need to > check

[clang] [analyzer] Refine invalidation caused by `fread` (PR #93408)

2024-06-03 Thread Balazs Benics via cfe-commits
@@ -937,8 +990,21 @@ void StreamChecker::evalFreadFwrite(const FnDescription *Desc, // At read, invalidate the buffer in any case of error or success, // except if EOF was already present. - if (IsFread && !E.isStreamEof()) -State = escapeArgs(State, C, Call, {0}); +

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: @Michael137 This is for Linux. Windows works the same way just below those lines: https://github.com/llvm/llvm-project/blob/9a7bd8a60f03595be5d42315790df6d409f81091/.ci/generate-buildkite-pipeline-premerge#L253-L255 https://github.com/llvm/llvm-project/pull/94208 ___

[clang] [Clang][Sema] Tweak tryCaptureVariable for unevaluated lambdas (PR #93206)

2024-06-03 Thread via cfe-commits
https://github.com/cor3ntin commented: I think it makes sense. I kinda wish there would be a more generic way to skip over requires expressions but I also can't think of other contexts we'd want to skip over, so this looks fine. Thanks for fixing a large number of issues https://github.com/l

[clang] [Clang][Sema] Tweak tryCaptureVariable for unevaluated lambdas (PR #93206)

2024-06-03 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/93206 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Refine invalidation caused by `fread` (PR #93408)

2024-06-03 Thread Balazs Benics via cfe-commits
@@ -717,18 +717,71 @@ const ExplodedNode *StreamChecker::getAcquisitionSite(const ExplodedNode *N, return nullptr; } +/// Invalidate only the requested elements instead of the whole buffer. +/// This is basically a refinement of the more generic 'escapeArgs' or +/// the pla

[clang] [analyzer] Refine invalidation caused by `fread` (PR #93408)

2024-06-03 Thread Balazs Benics via cfe-commits
https://github.com/steakhal updated https://github.com/llvm/llvm-project/pull/93408 >From f9e841ddaa865d529c806b2d115d5ddbc7109243 Mon Sep 17 00:00:00 2001 From: Balazs Benics Date: Sun, 26 May 2024 11:40:01 +0200 Subject: [PATCH 1/6] [analyzer] Refine invalidation caused by `fread` This chang

[clang] [analyzer] New optin.taint.TaintAlloc checker for catching unbounded memory allocation calls (PR #92420)

2024-06-03 Thread Daniel Krupp via cfe-commits
@@ -1730,6 +1721,21 @@ def UnixAPIPortabilityChecker : Checker<"UnixAPI">, } // end optin.portability + +//===--===// +// Taint checkers. +//===

[clang] [analyzer] Refine invalidation caused by `fread` (PR #93408)

2024-06-03 Thread Balazs Benics via cfe-commits
steakhal wrote: Fixed most NFC typos and suggestions. Let's continue the discussion. https://github.com/llvm/llvm-project/pull/93408 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [ExtractAPI,test] fix filecheck annotation (PR #92231)

2024-06-03 Thread via cfe-commits
https://github.com/klensy updated https://github.com/llvm/llvm-project/pull/92231 >From 910a674252a7f0968db46c9ed09879ae58e90d3b Mon Sep 17 00:00:00 2001 From: klensy Date: Wed, 15 May 2024 12:14:56 +0300 Subject: [PATCH] [ExtractAPI,test] fix filecheck annotation --- clang/test/ExtractAPI/av

[clang] [llvm] [clang][CodeGen] Global constructors/destructors are globals (PR #93914)

2024-06-03 Thread Alex Voicu via cfe-commits
https://github.com/AlexVlx updated https://github.com/llvm/llvm-project/pull/93914 >From 34b9646a38c6bdd0419dd9d2eb1bc847c4d16596 Mon Sep 17 00:00:00 2001 From: Alex Voicu Date: Tue, 28 May 2024 20:09:15 +0100 Subject: [PATCH 1/8] Fix `emitUsed` to place `used` globals in the Global AS. Update

[clang] [clang] Fix-it hint for `++this` -> `++*this` when deref is modifiable (PR #94159)

2024-06-03 Thread Rajveer Singh Bharadwaj via cfe-commits
Rajveer100 wrote: Tests which fail currently: Clang :: Sema/exprs.c Clang :: Sema/va_arg_x86_32.c Clang :: SemaObjCXX/sel-address.mm Also, what do you think about the fix-it hint wording for errors such as `assignment to cast is illegal, lvalue casts are not supported`? https://github.com/llv

[clang] [llvm] [IR] Avoid creating icmp/fcmp constant expressions (PR #92885)

2024-06-03 Thread via cfe-commits
mikaelholmen wrote: Hi @nikic The following starts crashing with this patch: ``` opt ic2.ll -S -o /dev/null -passes=instcombine ``` It hits ``` opt: ../include/llvm/Support/Casting.h:578: decltype(auto) llvm::cast(From *) [To = llvm::TruncInst, From = llvm::Value]: Assertion `isa(Val) && "cas

[clang] [llvm] Enable LLDB tests in pre-merge CI (PR #94208)

2024-06-03 Thread Michael Buch via cfe-commits
Michael137 wrote: > @Michael137 This is for Linux. Windows works the same way just below those > lines: > > https://github.com/llvm/llvm-project/blob/9a7bd8a60f03595be5d42315790df6d409f81091/.ci/generate-buildkite-pipeline-premerge#L253-L255 Ah, so what would the issue be with just adding more

[clang] [clang-repl] Teach clang-repl how to load PCHs. (PR #94166)

2024-06-03 Thread Aaron Ballman via cfe-commits
@@ -138,6 +138,8 @@ namespace { assert(!M && "Replacing existing Module?"); M.reset(new llvm::Module(ExpandModuleName(ModuleName, CodeGenOpts), C)); + IRGenFinished = false; AaronBallman wrote: Why is IR gen *finished* when we're just startin

[clang] [clang-repl] Teach clang-repl how to load PCHs. (PR #94166)

2024-06-03 Thread Aaron Ballman via cfe-commits
@@ -282,6 +288,8 @@ namespace { } void HandleTranslationUnit(ASTContext &Ctx) override { + IRGenFinished = true; AaronBallman wrote: shouldn't this be set at the end of `HandleTranslationUnit` rather than the beginning? https://github.com/llvm/

[clang] [clang] Make sure all C++ DR tests are running with `-pedantic-errors` (PR #94203)

2024-06-03 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/94203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Make sure all C++ DR tests are running with `-pedantic-errors` (PR #94203)

2024-06-03 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/94203 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

  1   2   3   4   5   >