[clang] cc3b6c3 - Fix more diagnostic wording for style; NFC

2024-05-22 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2024-05-22T13:43:34-04:00 New Revision: cc3b6c3ba9c0dd7df0fd7ac23c8609c4675dd62a URL: https://github.com/llvm/llvm-project/commit/cc3b6c3ba9c0dd7df0fd7ac23c8609c4675dd62a DIFF: https://github.com/llvm/llvm-project/commit/cc3b6c3ba9c0dd7df0fd7ac23c8609c4675dd62a.diff

[clang] [Clang] [NFC] Clarify assume diagnostic (PR #93077)

2024-05-22 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/93077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [NFC] Clarify assume diagnostic (PR #93077)

2024-05-22 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman approved this pull request. LGTM! https://github.com/llvm/llvm-project/pull/93077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Inliner] Propagate more attributes to params when inlining (PR #91101)

2024-05-22 Thread Andreas Jonson via cfe-commits
https://github.com/andjo403 edited https://github.com/llvm/llvm-project/pull/91101 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libunwind] Use relative includes to allow source-based dependencies without `-I` (PR #80443)

2024-05-22 Thread Louis Dionne via cfe-commits
ldionne wrote: > @ldionne, do you find @arichardson reasoning good enough to proceed with > merging this PR? I'm not convinced. We use `#include ` pretty consistently in libc++ and libc++abi and we should strive for all the runtimes to be consistent. I am especially not convinced that the end

[clang] [clang][FMV] Allow declaration of function versions in namespaces. (PR #93044)

2024-05-22 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea updated https://github.com/llvm/llvm-project/pull/93044 >From 1eb344d7a5e63c3e4e9e58f9141697d9d62b428c Mon Sep 17 00:00:00 2001 From: Alexandros Lamprineas Date: Wed, 22 May 2024 15:55:58 +0100 Subject: [PATCH] [clang][FMV] Allow declaration of function versions in

[clang] [clang][FMV] Allow declaration of function versions in namespaces. (PR #93044)

2024-05-22 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea edited https://github.com/llvm/llvm-project/pull/93044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][FMV] Allow declaration of function versions in namespaces. (PR #93044)

2024-05-22 Thread Alexandros Lamprineas via cfe-commits
labrinea wrote: I found another bug for implicitly declared default versions not having the namespece mangling. Fixed now, please take another look. https://github.com/llvm/llvm-project/pull/93044 ___ cfe-commits mailing list cfe-commits@lists.llvm.or

[clang] [Clang] [CodeGen] Perform derived-to-base conversion on explicit object parameter in lambda (PR #89828)

2024-05-22 Thread via cfe-commits
https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/89828 >From b5422012a65165f27bb31be7e9490892f663acfe Mon Sep 17 00:00:00 2001 From: Sirraide Date: Tue, 23 Apr 2024 22:45:29 +0200 Subject: [PATCH 1/6] [Clang] [CodeGen] Perform derived-to-base conversion on explicit

[clang] [Clang][objectsize] Generate object size calculation for sub-objects (PR #86858)

2024-05-22 Thread Bill Wendling via cfe-commits
bwendling wrote: I think I addressed your concerns. PTAL. https://github.com/llvm/llvm-project/pull/86858 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] [CodeGen] Perform derived-to-base conversion on explicit object parameter in lambda (PR #89828)

2024-05-22 Thread via cfe-commits
Sirraide wrote: > Should I just run make_cxx_dr_status again then and commit the result? I ended up figuring it out after talking to @Endilll about it. Also, the only CI failure earlier was something unrelated (CoverageMapping/mcdc-system-headers.cpp). https://github.com/llvm/llvm-project/pu

[clang] 0370beb - [Clang] Perform derived-to-base conversion on explicit object parameter in lambda (#89828)

2024-05-22 Thread via cfe-commits
Author: Sirraide Date: 2024-05-22T20:15:44+02:00 New Revision: 0370beb230a35f00b7d07c50ab95f8777662a0c6 URL: https://github.com/llvm/llvm-project/commit/0370beb230a35f00b7d07c50ab95f8777662a0c6 DIFF: https://github.com/llvm/llvm-project/commit/0370beb230a35f00b7d07c50ab95f8777662a0c6.diff LOG:

[clang] [Clang] [CodeGen] Perform derived-to-base conversion on explicit object parameter in lambda (PR #89828)

2024-05-22 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/89828 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Sema] Fix crash when diagnosing candidates with parameter packs (PR #93079)

2024-05-22 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik approved this pull request. Thank you for the fix. Can you please a little more details to your summary so that folks reading git log have more context. This also needs a release note. Please also add that this also fixes: https://github.com/llvm/llvm-project/issues/

[clang] [llvm] [IR] Avoid creating icmp/fcmp constant expressions (PR #92885)

2024-05-22 Thread Jonas Devlieghere via cfe-commits
JDevlieghere wrote: The LLDB bots are still failing: https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/as-lldb-cmake/4342/ https://ci.swift.org/view/all/job/llvm.org/view/LLDB/job/lldb-cmake/2244/ https://github.com/llvm/llvm-project/pull/92885 ___

[clang] [clang][Sema] Fix crash when diagnosing candidates with parameter packs (PR #93079)

2024-05-22 Thread Shafik Yaghmour via cfe-commits
shafik wrote: Can you also confirm this fixes: https://github.com/llvm/llvm-project/issues/70191 https://github.com/llvm/llvm-project/pull/93079 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/c

[clang] [Clang] [CodeGen] Perform derived-to-base conversion on explicit object parameter in lambda (PR #89828)

2024-05-22 Thread Nick Desaulniers via cfe-commits
@@ -4693,6 +4694,17 @@ LValue CodeGenFunction::EmitLValueForLambdaField(const FieldDecl *Field, else LambdaLV = MakeAddrLValue(AddrOfExplicitObject, D->getType().getNonReferenceType()); + +// Make sure we have an lvalue to the lamb

[clang] [llvm] [Frontend][OpenMP] Remove `reduction` from allowed clauses for `target` (PR #90754)

2024-05-22 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/90754 >From 94d79223a5c1daab292157576e8e84bb3280f22d Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 1 May 2024 12:21:51 -0500 Subject: [PATCH] [Frontend][OpenMP] Remove `reduction` from allowed clauses

[clang] [Clang] [CodeGen] Perform derived-to-base conversion on explicit object parameter in lambda (PR #89828)

2024-05-22 Thread via cfe-commits
@@ -4693,6 +4694,17 @@ LValue CodeGenFunction::EmitLValueForLambdaField(const FieldDecl *Field, else LambdaLV = MakeAddrLValue(AddrOfExplicitObject, D->getType().getNonReferenceType()); + +// Make sure we have an lvalue to the lamb

[clang] [llvm] [IR] Avoid creating icmp/fcmp constant expressions (PR #92885)

2024-05-22 Thread Daniel Thornburgh via cfe-commits
mysterymath wrote: This broke the Mac LLDB builders for Fuchsia as well. I'm going to revert to unblock CI. https://github.com/llvm/llvm-project/pull/92885 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] Add option to avoid generating coverage mappings for unused functions (PR #92582)

2024-05-22 Thread Andrew Wock via cfe-commits
ajwock wrote: cc @ZequanWu @ellishg for review https://github.com/llvm/llvm-project/pull/92582 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Remove parameter that shouldn't be there (PR #93086)

2024-05-22 Thread via cfe-commits
https://github.com/Sirraide created https://github.com/llvm/llvm-project/pull/93086 The parameter of `getAddress()` was not being used, as I recall, and seems to have been removed in the meantime. Merging this w/o review since this is breaking builds. >From c3d4bf3cf0e741d40d0d471a84bfaf53c15

[clang] da88e7f - [Clang] Remove parameter that shouldn't be there (#93086)

2024-05-22 Thread via cfe-commits
Author: Sirraide Date: 2024-05-22T20:27:26+02:00 New Revision: da88e7fbd74cef33411bb5115f20e4b474d2d8b1 URL: https://github.com/llvm/llvm-project/commit/da88e7fbd74cef33411bb5115f20e4b474d2d8b1 DIFF: https://github.com/llvm/llvm-project/commit/da88e7fbd74cef33411bb5115f20e4b474d2d8b1.diff LOG:

[clang] [Clang] Remove parameter that shouldn't be there (PR #93086)

2024-05-22 Thread via cfe-commits
https://github.com/Sirraide closed https://github.com/llvm/llvm-project/pull/93086 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Revert "[IR] Avoid creating icmp/fcmp constant expressions" (PR #93087)

2024-05-22 Thread Daniel Thornburgh via cfe-commits
https://github.com/mysterymath created https://github.com/llvm/llvm-project/pull/93087 Reverts llvm/llvm-project#92885 >From bf19260fe0d348aee801f4446c4f8666740c8896 Mon Sep 17 00:00:00 2001 From: Daniel Thornburgh Date: Wed, 22 May 2024 11:27:27 -0700 Subject: [PATCH] Revert "[IR] Avoid creat

[clang] [Clang] Remove parameter that shouldn't be there (PR #93086)

2024-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Sirraide) Changes The parameter of `getAddress()` was not being used, as I recall, and seems to have been removed in the meantime. Merging this w/o review since this is breaking builds. --- Full diff: https://github.com/llvm/llvm-p

[clang] [llvm] Revert "[IR] Avoid creating icmp/fcmp constant expressions" (PR #93087)

2024-05-22 Thread Daniel Thornburgh via cfe-commits
https://github.com/mysterymath edited https://github.com/llvm/llvm-project/pull/93087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Revert "[IR] Avoid creating icmp/fcmp constant expressions" (PR #93087)

2024-05-22 Thread Daniel Thornburgh via cfe-commits
https://github.com/mysterymath closed https://github.com/llvm/llvm-project/pull/93087 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8baf96f - Revert "[IR] Avoid creating icmp/fcmp constant expressions" (#93087)

2024-05-22 Thread via cfe-commits
Author: Daniel Thornburgh Date: 2024-05-22T11:27:55-07:00 New Revision: 8baf96f3060bc26a308b3614feed4117e5299d3c URL: https://github.com/llvm/llvm-project/commit/8baf96f3060bc26a308b3614feed4117e5299d3c DIFF: https://github.com/llvm/llvm-project/commit/8baf96f3060bc26a308b3614feed4117e5299d3c.d

[clang] [Clang] [CodeGen] Perform derived-to-base conversion on explicit object parameter in lambda (PR #89828)

2024-05-22 Thread via cfe-commits
@@ -4693,6 +4694,17 @@ LValue CodeGenFunction::EmitLValueForLambdaField(const FieldDecl *Field, else LambdaLV = MakeAddrLValue(AddrOfExplicitObject, D->getType().getNonReferenceType()); + +// Make sure we have an lvalue to the lamb

[clang] [llvm] Revert "[IR] Avoid creating icmp/fcmp constant expressions" (PR #93087)

2024-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver @llvm/pr-subscribers-llvm-analysis Author: Daniel Thornburgh (mysterymath) Changes Reverts llvm/llvm-project#92885 due to LLDB CI breakages. --- Patch is 91.88 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-

[clang] [llvm] Revert "[IR] Avoid creating icmp/fcmp constant expressions" (PR #93087)

2024-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-amdgpu Author: Daniel Thornburgh (mysterymath) Changes Reverts llvm/llvm-project#92885 due to LLDB CI breakages. --- Patch is 91.88 KiB, truncated to 20.00 KiB below, full version: https://github.com/llvm/llvm-project/pull/93087.diff 40 File

[clang] [Clang] [CodeGen] Perform derived-to-base conversion on explicit object parameter in lambda (PR #89828)

2024-05-22 Thread Nick Desaulniers via cfe-commits
@@ -4693,6 +4694,17 @@ LValue CodeGenFunction::EmitLValueForLambdaField(const FieldDecl *Field, else LambdaLV = MakeAddrLValue(AddrOfExplicitObject, D->getType().getNonReferenceType()); + +// Make sure we have an lvalue to the lamb

[clang] [Clang] [CodeGen] Perform derived-to-base conversion on explicit object parameter in lambda (PR #89828)

2024-05-22 Thread via cfe-commits
Sirraide wrote: It seems that a parameter to `getAddress()` that wasn’t being used has been removed, which caused builds to break after I merged this. My bad; I’ve already pushed a fix for this: #93086. I didn’t wait for CI this time because it was passing before (except for an unrelated issue

[clang] [clang][Sema] Fix crash when diagnosing candidates with parameter packs (PR #93079)

2024-05-22 Thread Matheus Izvekov via cfe-commits
@@ -11298,8 +11298,9 @@ static void DiagnoseBadConversion(Sema &S, OverloadCandidate *Cand, Expr *FromExpr = Conv.Bad.FromExpr; QualType FromTy = Conv.Bad.getFromType(); QualType ToTy = Conv.Bad.getToType(); - SourceRange ToParamRange = - !isObjectArgument ? Fn->ge

[clang] [clang][FMV] Allow declaration of function versions in namespaces. (PR #93044)

2024-05-22 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/93044 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] [SemaCXX] Implement CWG2627 Bit-fields and narrowing conversions (PR #78112)

2024-05-22 Thread Mital Ashok via cfe-commits
https://github.com/MitalAshok updated https://github.com/llvm/llvm-project/pull/78112 >From 92f8720e3d21521b589d5291f086a2f32b87bfe0 Mon Sep 17 00:00:00 2001 From: Mital Ashok Date: Sun, 14 Jan 2024 19:52:31 + Subject: [PATCH 1/2] [clang] [SemaCXX] Implement CWG2627 Bit-fields and narrowin

[clang] Add option to avoid generating coverage mappings for unused functions (PR #92582)

2024-05-22 Thread Zequan Wu via cfe-commits
ZequanWu wrote: I think the main purpose for emitting coverage mapping for un-emitted functions is to tell llvm-cov that those functions are not executed at all, so it shows execution count 0 for them instead of not-covered. https://github.com/llvm/llvm-project/pull/92582 _

[clang] [clang][Sema] Fix crash when diagnosing candidates with parameter packs (PR #93079)

2024-05-22 Thread Matheus Izvekov via cfe-commits
@@ -11298,8 +11298,9 @@ static void DiagnoseBadConversion(Sema &S, OverloadCandidate *Cand, Expr *FromExpr = Conv.Bad.FromExpr; QualType FromTy = Conv.Bad.getFromType(); QualType ToTy = Conv.Bad.getToType(); - SourceRange ToParamRange = - !isObjectArgument ? Fn->ge

[clang] [clang-repl] Extend the C support. (PR #89804)

2024-05-22 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: > > @jasonmolenda, I am stuck. I could not find how the bot configures llvm and > > lldb. I built lldb and ran `make check-lldb` but did not fail in the same > > way. Can you provide a recipe to reproduce the failure? > > For some reason it only fails on our Mac LLDB builders

[clang] [clang-repl] Extend the C support. (PR #89804)

2024-05-22 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: > I was able to verify that the revert fixed the tests at least. I am pretty sure that the failure ha to do with the incremental processing if-stmt in SemaDecl. I can provide a fix that does not trigger this for lldb but that would be a workaround. I suspect that change uncov

[clang] [clang-repl] Extend the C support. (PR #89804)

2024-05-22 Thread Daniel Thornburgh via cfe-commits
mysterymath wrote: I did have a means to reproduce this locally, but it's been a long time since I've used it. I should be able to recreate the setup. I'll get back to you with the details when I can; this whole afternoon is booked through pretty solid with meetings for me I'm afraid. https:/

[clang] [llvm] [Frontend][OpenMP] Remove `reduction` from allowed clauses for `target` (PR #90754)

2024-05-22 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/90754 >From 94d79223a5c1daab292157576e8e84bb3280f22d Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 1 May 2024 12:21:51 -0500 Subject: [PATCH 1/2] [Frontend][OpenMP] Remove `reduction` from allowed cla

[clang] [clang-repl] Extend the C support. (PR #89804)

2024-05-22 Thread Vassil Vassilev via cfe-commits
vgvassilev wrote: Ok, maybe I can you test this patch for a temporary fix until we figure out what's going wrong. ```diff diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp index 7f6921ea22be..d771a060f305 100644 --- a/clang/lib/Sema/SemaDecl.cpp +++ b/clang/lib/Sema/SemaDecl

[clang] [llvm] [AMDGPU][Clang] Add check of size for __builtin_amdgcn_global_load_lds (PR #93064)

2024-05-22 Thread Shilei Tian via cfe-commits
@@ -19040,6 +19040,48 @@ Value *CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID, CGM.getIntrinsic(Intrinsic::amdgcn_s_sendmsg_rtn, {ResultType}); return Builder.CreateCall(F, {Arg}); } + case AMDGPU::BI__builtin_amdgcn_global_load_lds: { +SmallVect

[clang] [llvm] [AMDGPU][Clang] Add check of size for __builtin_amdgcn_global_load_lds (PR #93064)

2024-05-22 Thread Matt Arsenault via cfe-commits
@@ -2537,6 +2537,47 @@ static RValue EmitHipStdParUnsupportedBuiltin(CodeGenFunction *CGF, return RValue::get(CGF->Builder.CreateCall(UBF, Args)); } +static void buildInstrinsicCallArgs(CodeGenFunction &CGF, const CallExpr *E, arsenm wrote: Shouldn't need

[clang] [llvm] [AMDGPU][Clang] Add check of size for __builtin_amdgcn_global_load_lds (PR #93064)

2024-05-22 Thread Matt Arsenault via cfe-commits
@@ -0,0 +1,9 @@ +// RUN: %clang_cc1 -cl-std=CL2.0 -O0 -triple amdgcn-unknown-unknown -target-cpu gfx940 -S -verify -o - %s +// REQUIRES: amdgpu-registered-target + +typedef unsigned int u32; + +void test_global_load_lds_unsupported_size(global u32* src, local u32 *dst, u32 size)

[clang] ff3f41d - [clang] Implement CWG2398 provisional TTP matching to class templates (#92855)

2024-05-22 Thread via cfe-commits
Author: Matheus Izvekov Date: 2024-05-22T15:59:55-03:00 New Revision: ff3f41deb04c03ba57658776e4e0dc26ef01187d URL: https://github.com/llvm/llvm-project/commit/ff3f41deb04c03ba57658776e4e0dc26ef01187d DIFF: https://github.com/llvm/llvm-project/commit/ff3f41deb04c03ba57658776e4e0dc26ef01187d.dif

[clang] [clang-tools-extra] [clang] Implement CWG2398 provisional TTP matching to class templates (PR #92855)

2024-05-22 Thread Matheus Izvekov via cfe-commits
https://github.com/mizvekov closed https://github.com/llvm/llvm-project/pull/92855 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] wip: Move instrumentation passes (PR #92171)

2024-05-22 Thread Egor Pasko via cfe-commits
https://github.com/pasko updated https://github.com/llvm/llvm-project/pull/92171 >From df3f8dfc47cd8d7b220ed712dc7c2cab1c563f50 Mon Sep 17 00:00:00 2001 From: Egor Pasko Date: Mon, 6 May 2024 19:48:59 +0200 Subject: [PATCH 1/6] wip: Move instrumentation passes This change is not ready for landi

[clang] [Clang] Remove parameter that shouldn't be there (PR #93086)

2024-05-22 Thread Eli Friedman via cfe-commits
efriedma-quic wrote: Looks fine. https://github.com/llvm/llvm-project/pull/93086 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] wip: Move instrumentation passes (PR #92171)

2024-05-22 Thread Egor Pasko via cfe-commits
https://github.com/pasko updated https://github.com/llvm/llvm-project/pull/92171 >From df3f8dfc47cd8d7b220ed712dc7c2cab1c563f50 Mon Sep 17 00:00:00 2001 From: Egor Pasko Date: Mon, 6 May 2024 19:48:59 +0200 Subject: [PATCH 1/7] wip: Move instrumentation passes This change is not ready for landi

[clang] [llvm] wip: Move instrumentation passes (PR #92171)

2024-05-22 Thread Egor Pasko via cfe-commits
@@ -0,0 +1,31 @@ +; RUN: opt -passes="default" -S < %s | FileCheck %s pasko wrote: Done, I think, but it is evening, and I might be missing something. https://github.com/llvm/llvm-project/pull/92171 ___ cfe-commits mai

[clang] [clang][cmake] Fixes for PGO builds when invoking ninja twice (PR #92591)

2024-05-22 Thread Tom Stellard via cfe-commits
https://github.com/tstellar milestoned https://github.com/llvm/llvm-project/pull/92591 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [CMake][Release] Use the TXZ cpack generator for binaries (PR #90138)

2024-05-22 Thread Tom Stellard via cfe-commits
https://github.com/tstellar milestoned https://github.com/llvm/llvm-project/pull/90138 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++][WIP] Move the libc++ test format to Lit (PR #90803)

2024-05-22 Thread Louis Dionne via cfe-commits
@@ -0,0 +1,355 @@ +# ===--===## +# +# Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +# See https://llvm.org/LICENSE.txt for license information. +# SPDX-License-Identifier: Apache-

[libcxx] [libcxxabi] [libunwind] [llvm] [libc++][WIP] Move the libc++ test format to Lit (PR #90803)

2024-05-22 Thread Louis Dionne via cfe-commits
https://github.com/ldionne updated https://github.com/llvm/llvm-project/pull/90803 >From 4871a82495e0056483759fa207ffbecd63b1e2f8 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Wed, 1 May 2024 18:10:07 -0600 Subject: [PATCH] [libc++][WIP] Move the libc++ test format to Lit This allows the g

[clang] [clang][FMV] Allow declaration of function versions in namespaces. (PR #93044)

2024-05-22 Thread Eli Friedman via cfe-commits
@@ -11868,8 +11868,10 @@ static bool CheckMultiVersionFunction(Sema &S, FunctionDecl *NewFD, return false; if (!OldDecl || !OldDecl->getAsFunction() || - OldDecl->getDeclContext()->getRedeclContext() != - NewFD->getDeclContext()->getRedeclContext()) { +

[clang] [ExtractAPI,test] fix filecheck annotation (PR #92231)

2024-05-22 Thread via cfe-commits
klensy wrote: `fatal error C1060: compiler is out of heap space` Looks unrelated, should i rerun CI? https://github.com/llvm/llvm-project/pull/92231 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[clang] [llvm] [Frontend][OpenMP] Remove `reduction` from allowed clauses for `target` (PR #90754)

2024-05-22 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/90754 >From 94d79223a5c1daab292157576e8e84bb3280f22d Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Wed, 1 May 2024 12:21:51 -0500 Subject: [PATCH 1/3] [Frontend][OpenMP] Remove `reduction` from allowed cla

[clang] [llvm] [AMDGPU][Clang] Add check of size for __builtin_amdgcn_global_load_lds (PR #93064)

2024-05-22 Thread Shilei Tian via cfe-commits
@@ -2537,6 +2537,47 @@ static RValue EmitHipStdParUnsupportedBuiltin(CodeGenFunction *CGF, return RValue::get(CGF->Builder.CreateCall(UBF, Args)); } +static void buildInstrinsicCallArgs(CodeGenFunction &CGF, const CallExpr *E, shiltian wrote: Yeah, no need

[clang] [clang] Fix PS "selective" DLL import/export of vtable & typeinfo (PR #92579)

2024-05-22 Thread Eli Friedman via cfe-commits
@@ -1793,6 +1793,37 @@ void ItaniumCXXABI::EmitDestructorCall(CodeGenFunction &CGF, ThisTy, VTT, VTTTy, nullptr); } +// Check if any non-inline method has the specified attribute. +template +static bool CXXRecordNonInlineHasAttr(const CXXRecordDec

[clang] [llvm] [Inliner] Propagate more attributes to params when inlining (PR #91101)

2024-05-22 Thread via cfe-commits
@@ -1427,8 +1429,20 @@ static void AddParamAndFnBasicAttributes(const CallBase &CB, ValidExactParamAttrs[ArgNo].getAlignment().valueOrOne()) AL = AL.removeParamAttribute(Context, I, Attribute::Alignment); + auto ExistingRange = AL.getParamRa

[clang] Add option to avoid generating coverage mappings for unused functions (PR #92582)

2024-05-22 Thread Andrew Wock via cfe-commits
ajwock wrote: The problem that this solves is related to binary size. In situations where a large C API is in generated code but a small part of the API is used, the size of __llvm_prf_names and __llvm_cov_fun sections can be prohibitively large. This flag offers a way to reduce binary size

[clang] [llvm] [AMDGPU][Clang] Add check of size for __builtin_amdgcn_global_load_lds (PR #93064)

2024-05-22 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/93064 >From 0ac36053bada98dc0f9e5eb2f3b215acc06b07a5 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Wed, 22 May 2024 16:06:51 -0400 Subject: [PATCH] [AMDGPU][Clang] Add check of size for __builtin_amdgcn_global_loa

[clang] [llvm] [AMDGPU][Clang] Add check of size for __builtin_amdgcn_global_load_lds (PR #93064)

2024-05-22 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/93064 >From cc1b4f7ac1a4c0a827e843068547aa5c9748ca3e Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Wed, 22 May 2024 16:09:53 -0400 Subject: [PATCH] [AMDGPU][Clang] Add check of size for __builtin_amdgcn_global_loa

[clang] [llvm] [AMDGPU][Clang] Add check of size for __builtin_amdgcn_global_load_lds (PR #93064)

2024-05-22 Thread Shilei Tian via cfe-commits
https://github.com/shiltian updated https://github.com/llvm/llvm-project/pull/93064 >From 6096d6a7a672786807173f2cbe3c08beb1b9ad74 Mon Sep 17 00:00:00 2001 From: Shilei Tian Date: Wed, 22 May 2024 16:11:04 -0400 Subject: [PATCH] [AMDGPU][Clang] Add check of size for __builtin_amdgcn_global_loa

[clang] [clang-format] Add space after a word token (PR #92741)

2024-05-22 Thread Robin Caloudis via cfe-commits
robincaloudis wrote: Thanks @owenca, @mydeveloperday and @HazardyKnusperkeks for the explanation and insights! I'm closing this issue as @owenca found a much better solution. https://github.com/llvm/llvm-project/pull/92741 ___ cfe-commits mailing list

[clang] [clang-format] Add space after a word token (PR #92741)

2024-05-22 Thread Robin Caloudis via cfe-commits
https://github.com/robincaloudis closed https://github.com/llvm/llvm-project/pull/92741 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix(93002): clang/lib/Sema/SemaOpenMP.cpp:7405: Possible & / && mixup ? (PR #93093)

2024-05-22 Thread Oleksandr T. via cfe-commits
https://github.com/a-tarasyuk created https://github.com/llvm/llvm-project/pull/93093 Fixes #93002 >From 19c54263be42fea58403d30030af76da0355ef1e Mon Sep 17 00:00:00 2001 From: Oleksandr T Date: Wed, 22 May 2024 23:47:19 +0300 Subject: [PATCH] fix(93002): switch & to && for boolean values ---

[clang] [clang] fix(93002): clang/lib/Sema/SemaOpenMP.cpp:7405: Possible & / && mixup ? (PR #93093)

2024-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Oleksandr T. (a-tarasyuk) Changes Fixes #93002 --- Full diff: https://github.com/llvm/llvm-project/pull/93093.diff 1 Files Affected: - (modified) clang/lib/Sema/SemaOpenMP.cpp (+1-1) ``diff diff --git a/clang/lib/Sema/SemaOpe

[clang] [llvm] wip: Move instrumentation passes (PR #92171)

2024-05-22 Thread Arthur Eubanks via cfe-commits
@@ -0,0 +1,44 @@ +; RUN: opt -passes="default" -S < %s | FileCheck -check-prefix=PRELTO %s +; RUN: opt -passes="default" -S < %s | FileCheck -check-prefix=PRELTO %s +; RUN: opt -passes="thinlto-pre-link,thinlto" -S < %s | FileCheck -check-prefix=PRELTO %s aeubank

[clang] [llvm] wip: Move instrumentation passes (PR #92171)

2024-05-22 Thread Arthur Eubanks via cfe-commits
@@ -0,0 +1,44 @@ +; RUN: opt -passes="default" -S < %s | FileCheck -check-prefix=PRELTO %s aeubanks wrote: `PRELTO` isn't quite accurate since we also instrument in the default pipelines, I'd use `INSTRUMENT`/`NOINSTRUMENT` or even just `YES`/`NO` :) https://gi

[clang] [llvm] wip: Move instrumentation passes (PR #92171)

2024-05-22 Thread Arthur Eubanks via cfe-commits
@@ -1,41 +0,0 @@ -// REQUIRES: arm-registered-target,aarch64-registered-target - -// RUN: %clang -target armv7-unknown-none-eabi -pg -S -emit-llvm -o - %s | FileCheck %s -check-prefixes=CHECK,UNSUPPORTED -// RUN: %clang -target armv7-unknown-none-eabi -pg -meabi gnu -S -emit-llvm

[clang] [llvm] wip: Move instrumentation passes (PR #92171)

2024-05-22 Thread Arthur Eubanks via cfe-commits
@@ -0,0 +1,44 @@ +; RUN: opt -passes="default" -S < %s | FileCheck -check-prefix=PRELTO %s +; RUN: opt -passes="default" -S < %s | FileCheck -check-prefix=PRELTO %s +; RUN: opt -passes="thinlto-pre-link,thinlto" -S < %s | FileCheck -check-prefix=PRELTO %s +; RUN: opt -passes="thi

[clang] [llvm] wip: Move instrumentation passes (PR #92171)

2024-05-22 Thread Arthur Eubanks via cfe-commits
@@ -0,0 +1,29 @@ +; RUN: llc -mtriple=x86_64-- -O0 < %s | FileCheck %s +; RUN: llc -mtriple=x86_64-- -O1 < %s | FileCheck %s +; RUN: llc -mtriple=x86_64-- -O2 < %s | FileCheck %s + +; The codegen should insert post-inlining instrumentation calls and should not +; insert pre-inlini

[clang] [Coverage][Expansion] handle nested macros in scratch space (PR #89869)

2024-05-22 Thread NAKAMURA Takumi via cfe-commits
@@ -339,8 +365,18 @@ class CoverageMappingBuilder { llvm::SmallSet Visited; SmallVector, 8> FileLocs; -for (const auto &Region : SourceRegions) { +for (auto &Region : SourceRegions) { SourceLocation Loc = Region.getBeginLoc(); + + // Replace Region

[clang] [clang] Introduce `SemaX86` (PR #93098)

2024-05-22 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/93098 This patch moves `Sema` functions that are specific for x86 into the new `SemaX86` class. This continues previous efforts to split `Sema` up. Additional context can be found in #84184 and #92682. >From 662c3458

[clang] [clang] Introduce `SemaX86` (PR #93098)

2024-05-22 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Vlad Serebrennikov (Endilll) Changes This patch moves `Sema` functions that are specific for x86 into the new `SemaX86` class. This continues previous efforts to split `Sema` up. Additional context can be found in #84184 and #92682.

[clang] [llvm] [Inliner] Propagate more attributes to params when inlining (PR #91101)

2024-05-22 Thread via cfe-commits
@@ -1427,8 +1429,20 @@ static void AddParamAndFnBasicAttributes(const CallBase &CB, ValidExactParamAttrs[ArgNo].getAlignment().valueOrOne()) AL = AL.removeParamAttribute(Context, I, Attribute::Alignment); + auto ExistingRange = AL.getParamRa

[clang] [llvm] [Inliner] Propagate more attributes to params when inlining (PR #91101)

2024-05-22 Thread via cfe-commits
https://github.com/goldsteinn updated https://github.com/llvm/llvm-project/pull/91101 >From 0f04281f4c064d0c873abf0c95c54b53fa3deafd Mon Sep 17 00:00:00 2001 From: Noah Goldstein Date: Sat, 4 May 2024 18:12:34 -0500 Subject: [PATCH 1/3] [Inliner] Add tests for propagating more parameter attrib

[clang] [CodeGen] Update test intrinsic to support immediates (PR #79174)

2024-05-22 Thread via cfe-commits
https://github.com/AtariDreams converted_to_draft https://github.com/llvm/llvm-project/pull/79174 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [Inliner] Propagate more attributes to params when inlining (PR #91101)

2024-05-22 Thread Andreas Jonson via cfe-commits
@@ -1427,8 +1429,17 @@ static void AddParamAndFnBasicAttributes(const CallBase &CB, ValidExactParamAttrs[ArgNo].getAlignment().valueOrOne()) AL = AL.removeParamAttribute(Context, I, Attribute::Alignment); + auto ExistingRange = AL.getParamRa

[clang] [lldb] [llvm] Remove some `try_compile` CMake checks for compiler flags (PR #92953)

2024-05-22 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/92953 >From 66e05ac24613435dbe774d49684d8ff9d119c4c3 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Tue, 21 May 2024 21:41:24 +0300 Subject: [PATCH 1/3] Remove some `try_compile` CMake checks for compiler flag

[clang] [Clang] Resolve FIXME: Use class method when receiver is reference to class (PR #85316)

2024-05-22 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/85316 >From 3a1cc2ba9c3b5f5bd290eda890287f3f87803e61 Mon Sep 17 00:00:00 2001 From: Rose Date: Thu, 14 Mar 2024 17:34:16 -0400 Subject: [PATCH] Resolve FIXME: Use class method when receiver is reference to class

[clang] [Clang] Resolve FIXME: Use class method when receiver is reference to class (PR #85316)

2024-05-22 Thread via cfe-commits
https://github.com/AtariDreams edited https://github.com/llvm/llvm-project/pull/85316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Resolve FIXME: Use class method when receiver is reference to class (PR #85316)

2024-05-22 Thread via cfe-commits
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/85316 >From cf9b776ff6fd59fc9488eedf45b9344f711ee155 Mon Sep 17 00:00:00 2001 From: Rose Date: Thu, 14 Mar 2024 17:34:16 -0400 Subject: [PATCH] Resolve FIXME: Use class method when receiver is reference to class

[clang] [clang-repl] Extend the C support. (PR #89804)

2024-05-22 Thread Daniel Thornburgh via cfe-commits
mysterymath wrote: This still exhibits the same issue: https://luci-milo.appspot.com/raw/build/logs.chromium.org/fuchsia/led/dthorn_google.com/0d77d2b0963e18ad11cb83db0680c2382ed7f8df95cf733f42fcdbd1dda8a7ec/+/build.proto https://logs.chromium.org/logs/fuchsia/led/dthorn_google.com/0d77d2b0963

[clang] [clang-repl] Extend the C support. (PR #89804)

2024-05-22 Thread Jason Molenda via cfe-commits
jasonmolenda wrote: fwiw if you have access to a mac, I don't think it's hard to build lldb+clang? I have swig, cmake, and ninja installed on my mac via homebrew. ``` lldb/scripts/macos-setup-codesign.sh mkdir build cd build cmake ../llvm -G Ninja -DLLDB_ENABLE_SWIFT_SUPPORT=0 -DPython3_EXE

[clang] [Coverage][Expansion] handle nested macros in scratch space (PR #89869)

2024-05-22 Thread NAKAMURA Takumi via cfe-commits
@@ -292,10 +292,36 @@ class CoverageMappingBuilder { return SM.getLocForEndOfFile(SM.getFileID(Loc)); } - /// Find out where the current file is included or macro is expanded. - SourceLocation getIncludeOrExpansionLoc(SourceLocation Loc) { -return Loc.isMacroID() ?

[clang] [Coverage][Expansion] handle nested macros in scratch space (PR #89869)

2024-05-22 Thread NAKAMURA Takumi via cfe-commits
@@ -339,8 +365,18 @@ class CoverageMappingBuilder { llvm::SmallSet Visited; SmallVector, 8> FileLocs; -for (const auto &Region : SourceRegions) { +for (auto &Region : SourceRegions) { SourceLocation Loc = Region.getBeginLoc(); + + // Replace Region

[clang] [llvm] [Inliner] Propagate more attributes to params when inlining (PR #91101)

2024-05-22 Thread via cfe-commits
@@ -1427,8 +1429,17 @@ static void AddParamAndFnBasicAttributes(const CallBase &CB, ValidExactParamAttrs[ArgNo].getAlignment().valueOrOne()) AL = AL.removeParamAttribute(Context, I, Attribute::Alignment); + auto ExistingRange = AL.getParamRa

[clang] [llvm] [Inliner] Propagate more attributes to params when inlining (PR #91101)

2024-05-22 Thread via cfe-commits
https://github.com/goldsteinn updated https://github.com/llvm/llvm-project/pull/91101 >From 0f04281f4c064d0c873abf0c95c54b53fa3deafd Mon Sep 17 00:00:00 2001 From: Noah Goldstein Date: Sat, 4 May 2024 18:12:34 -0500 Subject: [PATCH 1/3] [Inliner] Add tests for propagating more parameter attrib

[clang] [Clang] Throw error when calling atomic with pointer to zero size object (PR #91057)

2024-05-22 Thread Hendrik Hübner via cfe-commits
https://github.com/HendrikHuebner updated https://github.com/llvm/llvm-project/pull/91057 From d1013726315209ba2517ecd767daa067b4b34143 Mon Sep 17 00:00:00 2001 From: hhuebner Date: Sat, 4 May 2024 13:49:38 +0200 Subject: [PATCH] gClang] Throw error when calling atomic with pointer to zero siz

[clang] [Clang] Throw error when calling atomic with pointer to zero size object (PR #91057)

2024-05-22 Thread Hendrik Hübner via cfe-commits
https://github.com/HendrikHuebner updated https://github.com/llvm/llvm-project/pull/91057 From 9a0cb155e9d05043b31736080cb355ae73e16860 Mon Sep 17 00:00:00 2001 From: hhuebner Date: Sat, 4 May 2024 13:49:38 +0200 Subject: [PATCH] [Clang] Throw error when calling atomic with pointer to zero siz

[clang] [llvm] [AArch64] Support preserve_none calling convention (PR #91046)

2024-05-22 Thread via cfe-commits
antangelo wrote: Friendly ping https://github.com/llvm/llvm-project/pull/91046 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix PS "selective" DLL import/export of vtable & typeinfo (PR #92579)

2024-05-22 Thread via cfe-commits
@@ -1793,6 +1793,37 @@ void ItaniumCXXABI::EmitDestructorCall(CodeGenFunction &CGF, ThisTy, VTT, VTTTy, nullptr); } +// Check if any non-inline method has the specified attribute. +template +static bool CXXRecordNonInlineHasAttr(const CXXRecordDec

[clang] [Clang] Throw error when calling atomic with pointer to zero size object (PR #91057)

2024-05-22 Thread Hendrik Hübner via cfe-commits
https://github.com/HendrikHuebner updated https://github.com/llvm/llvm-project/pull/91057 From c6a28f1ca3fe64deee892abdf2d3646e9ccf0a87 Mon Sep 17 00:00:00 2001 From: hhuebner Date: Sat, 4 May 2024 13:49:38 +0200 Subject: [PATCH] [Clang] Throw error when calling atomic with pointer to zero siz

[clang] [Clang] Throw error when calling atomic with pointer to zero size object (PR #91057)

2024-05-22 Thread Hendrik Hübner via cfe-commits
HendrikHuebner wrote: Alright, I implemented the changes you suggested. There may have been an easier way to modify the diagnostic though. https://github.com/llvm/llvm-project/pull/91057 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://

[clang] [Clang] Fix __is_trivially_equality_comparable returning true with ineligebile defaulted overloads (PR #93113)

2024-05-22 Thread Nikolas Klauser via cfe-commits
https://github.com/philnik777 created https://github.com/llvm/llvm-project/pull/93113 This changes `__is_trivially_equality_comparable` to do overload resolution instead, which fixes a couple of false-positives (and a false-negative as a drive-by). Fixes #89293 >From 53b52a07f8720db4495b93

<    1   2   3   4   >