@@ -4429,6 +4433,218 @@ class FunctionNoProtoType : public FunctionType, public
llvm::FoldingSetNode {
}
};
+//
--
+
+// TODO: Should FunctionEffect be located elsewhere, where Decl is not
+// forw
@@ -4429,6 +4433,218 @@ class FunctionNoProtoType : public FunctionType, public
llvm::FoldingSetNode {
}
};
+//
--
+
+// TODO: Should FunctionEffect be located elsewhere, where Decl is not
+// forw
@@ -4639,6 +4645,303 @@ class FunctionNoProtoType : public FunctionType, public
llvm::FoldingSetNode {
}
};
+//
--
+
+/// Represents an abstract function effect, using just an enumeration
describi
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff e5936b245e9af0cea69a7e4eae22a05b7ffcf5a3
e03d8cfdc697bf714d1f13247233cf514b77f0de --
https://github.com/MitalAshok created
https://github.com/llvm/llvm-project/pull/93046
This DR's effects are backported to C++98.
Does not affect C where integral constant expressions cannot involve pointers.
>From aa5e7f71efdfcdea902ac881fd8db6b7c4f4538d Mon Sep 17 00:00:00 2001
From: Mital As
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Mital Ashok (MitalAshok)
Changes
This DR's effects are backported to C++98.
Does not affect C where integral constant expressions cannot involve pointers.
---
Full diff: https://github.com/llvm/llvm-project/pull/93046.diff
7 Files Affec
@@ -7973,3 +7973,20 @@ requirement:
}
}];
}
+
+def NoLockNoAllocDocs : Documentation {
+ let Category = DocCatType;
+ let Content = [{
+The ``nolock`` and ``noalloc`` attributes can be attached to functions,
blocks,
+function pointers, lambdas, and member functions. The
@@ -10510,6 +10512,8 @@ QualType ASTContext::mergeFunctionTypes(QualType lhs,
QualType rhs,
if (lproto->getMethodQuals() != rproto->getMethodQuals())
return {};
+// TODO: (nonblocking) Does anything need to be done with FunctionEffects?
+
dougso
dougsonos wrote:
I've been through all the feedback again and believe I have addressed
everything.
https://github.com/llvm/llvm-project/pull/84983
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/
Sirraide wrote:
Ok, the only CI failure is apparently
`CoverageMapping/mcdc-system-headers.cpp`, which seems unrelated.
https://github.com/llvm/llvm-project/pull/84934
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cg
Sirraide wrote:
> the GNU __attribute__((assume)) spelling is no longer diagnosed as a C++23
> extension, but from what I can tell, this pr is finally done now.
@erichkeane @AaronBallman Just wanted to double-check whether this is fine
because I committed this change after this pr was approved
erichkeane wrote:
> > the GNU `__attribute__((assume))` spelling is no longer diagnosed as a
> > C++23 extension
>
> @erichkeane @AaronBallman Just wanted to double-check whether this is fine
> because I committed this change after this pr was approved.
Yep, that makes sense to me. Still LGT
https://github.com/Sirraide created
https://github.com/llvm/llvm-project/pull/93059
Adding a release note about this as discussed in #92439.
(This is an NFC change, but I’m adding you as reviewers in case there is
anything you want to add to this since you were involved in the discussion.)
T
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (Sirraide)
Changes
Adding a release note about this as discussed in #92439.
(This is an NFC change, but I’m adding you as reviewers in case there is
anything you want to add to this since you were involved in the discussion.)
This
cor3ntin wrote:
> This closes https://github.com/llvm/llvm-project/issues/92439.
It does not (`s` is still not diagnosed)
https://github.com/llvm/llvm-project/pull/93059
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.or
@@ -59,6 +59,18 @@ C++ Specific Potentially Breaking Changes
- Clang now performs semantic analysis for unary operators with dependent
operands
that are known to be of non-class non-enumeration type prior to
instantiation.
+ This change uncovered a bug in libstdc++ 14.1.0
Sirraide wrote:
> > This closes #92439.
>
> It does not (`s` is still not diagnosed)
Oh, right; this was mainly in reference to the libstdc++ bug since that’s
what’s most of the discussion on that issue has been about. I’d maybe suggest
moving the `s` case to a different issue?
https
cor3ntin wrote:
I would keep that issue and just remove the fixes (We can still link the issue
to this PR by posting a link in a comment)
https://github.com/llvm/llvm-project/pull/93059
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://l
Sirraide wrote:
> I would keep that issue and just remove the fixes
Done
https://github.com/llvm/llvm-project/pull/93059
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
(I also think that the libstdc++ bug demonstrated some usefulness for a
`++this` -> `++*this` fixit... maybe?)
https://github.com/llvm/llvm-project/pull/93059
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
Sirraide wrote:
> (I also think that the libstdc++ bug demonstrated some usefulness for a
> `++this` -> `++*this` fixit... maybe?)
That does sound like it might be useful; I’m going to open another issue about
that so we don’t forget about it.
https://github.com/llvm/llvm-project/pull/93059
_
@@ -2415,46 +2415,112 @@ DiagnosticBuilder
ItaniumRecordLayoutBuilder::Diag(SourceLocation Loc,
return Context.getDiagnostics().Report(Loc, DiagID);
}
+/// https://itanium-cxx-abi.github.io/cxx-abi/abi.html#POD
+/// POD for the purpose of layout
+/// In general, a type is
@@ -2415,46 +2415,112 @@ DiagnosticBuilder
ItaniumRecordLayoutBuilder::Diag(SourceLocation Loc,
return Context.getDiagnostics().Report(Loc, DiagID);
}
+/// https://itanium-cxx-abi.github.io/cxx-abi/abi.html#POD
+/// POD for the purpose of layout
+/// In general, a type is
Sirraide wrote:
I’ve opened an issue to add a fix-it hint and tagged it as a good first issue
because for once this is something that seems like it would be fairly
straight-forward to do: #93066
https://github.com/llvm/llvm-project/pull/93059
___
cfe
mysterymath wrote:
> @jasonmolenda, I am stuck. I could not find how the bot configures llvm and
> lldb. I built lldb and ran `make check-lldb` but did not fail in the same
> way. Can you provide a recipe to reproduce the failure?
For some reason it only fails on our Mac LLDB builders, and not
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 4ea21a0261cd8599a9ffa15f5c554ab0d4bbbe27
cf074221241e4d5c83426c58f70438fb592ca7ad --
@@ -0,0 +1,112 @@
+//===- MemberPointer.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,112 @@
+//===- MemberPointer.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,112 @@
+//===- MemberPointer.h --*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
mysterymath wrote:
I was able to verify that the revert fixed the tests at least.
https://github.com/llvm/llvm-project/pull/89804
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -11,6 +11,8 @@
//
//===--===//
+#include "clang/Config/config.h"
perry-ca wrote:
This is needed for the change in SystemZ.h to replace the hard coded `"z10"`
string with the CLANG_SYSTEM
https://github.com/Sirraide created
https://github.com/llvm/llvm-project/pull/93077
Currently, if the argument to `__builtin_assume` and friends contains
side-effects, we issue the following diagnostic:
```
:1:34: warning: the argument to '__builtin_assume' has side effects
that will be discar
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (Sirraide)
Changes
Currently, if the argument to `__builtin_assume` and friends contains
side-effects, we issue the following diagnostic:
```
:1:34: warning: the argument to '__builtin_assume' has side
effects that will be di
aganea wrote:
@jansvoboda11 Do you see any further changes for this PR? Can I land it?
https://github.com/llvm/llvm-project/pull/89950
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
