https://github.com/lamb-j updated
https://github.com/llvm/llvm-project/pull/91495
>From 4c687db250dabbc13557df46433a3c1cb3dff01e Mon Sep 17 00:00:00 2001
From: Jacob Lambert
Date: Wed, 8 May 2024 08:52:14 -0700
Subject: [PATCH 1/2] [clang][CodeGen] Remove now-unused FileManager variable
Fixes
rjodinchr wrote:
It has nothing to do with OpenMP.
The goal was just to get something in the llvm IR that we could check for. The
`assume` attribute allows us to pass a string that we can then check in a llvm
pass.
https://github.com/llvm/llvm-project/pull/84934
__
erichkeane wrote:
> It has nothing to do with OpenMP. The goal was just to get something in the
> llvm IR that we could check for. The `assume` attribute allows us to pass a
> string that we can then check in a llvm pass.
Could you investigate whether 'annotate' would do what you want? IIRC,
@@ -0,0 +1,25 @@
+// Test which driver flags enable/disable Function Multiversioning on aarch64.
+
+// FMV is enabled for non-android aarch64 targets:
+// RUN: %clang --target=aarch64 --rtlib=compiler-rt -### -c %s 2>&1 |
FileCheck -check-prefix=FMV-ENABLED %s
+// RUN: %clang --t
https://github.com/jroelofs approved this pull request.
https://github.com/llvm/llvm-project/pull/91490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Justin Bogner
Date: 2024-05-08T10:28:54-06:00
New Revision: 8d9b15497d70ac782d7d01a2d606f9fec7e7f642
URL:
https://github.com/llvm/llvm-project/commit/8d9b15497d70ac782d7d01a2d606f9fec7e7f642
DIFF:
https://github.com/llvm/llvm-project/commit/8d9b15497d70ac782d7d01a2d606f9fec7e7f642.diff
https://github.com/bogner closed https://github.com/llvm/llvm-project/pull/91500
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
@llvm/pr-subscribers-clang
Author: Justin Bogner (bogner)
Changes
After 11a6799740f8 "[clang][CodeGen] Omit pre-opt link when post-opt is link
requested (#85672)" I'm seeing a new warning:
> BackendConsumer.h:37:22: error: private field '
https://github.com/lamb-j closed https://github.com/llvm/llvm-project/pull/91495
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh wrote:
> @bgra8 see #91498
Can you check if it also fixes
https://github.com/llvm/llvm-project/pull/90152#issuecomment-2100932093 ? Or
should it?
https://github.com/llvm/llvm-project/pull/90152
___
cfe-commits mailing list
cfe-commits@lists.
lamb-j wrote:
https://github.com/llvm/llvm-project/pull/91495
Follow up PR to fix warning with now-unused private variable in BackendConsumer
class (FileMgr)
https://github.com/llvm/llvm-project/pull/85672
___
cfe-commits mailing list
cfe-commits@lis
jyu2-git wrote:
The test fails in log file.
bk;t=1715139976737^G TEST 'DataFlowSanitizer-x86_64 ::
release_shadow_space.c' FAILED ^M
^[_bk;t=1715139976737^GExit Code: 134^M
It is fix in: https://github.com/llvm/llvm-project/pull/91493
https://github.com
https://github.com/efriedma-quic approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/90602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yronglin updated
https://github.com/llvm/llvm-project/pull/90574
>From 1dcb4c3ac1efaf3a6a4317751e23089a6c8ccac1 Mon Sep 17 00:00:00 2001
From: yronglin
Date: Tue, 30 Apr 2024 17:18:26 +0800
Subject: [PATCH 01/10] =?UTF-8?q?[Clang]=20Implement=20P3034R1=20Module=20?=
=?UTF-8?
sdkrystian wrote:
@alexfh It won't fix the example in your comment (but I have a separate fix for
it)
https://github.com/llvm/llvm-project/pull/90152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
@@ -1329,6 +1341,129 @@ bool Preprocessor::LexAfterModuleImport(Token &Result) {
return true;
}
+/// Lex a token following the 'module' contextual keyword.
+///
+/// [cpp.module]/p2:
+/// The pp-tokens, if any, of a pp-module shall be of the form:
+/// pp-module-name p
alexfh wrote:
Great! Thanks for the prompt action!
https://github.com/llvm/llvm-project/pull/90152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1329,6 +1341,129 @@ bool Preprocessor::LexAfterModuleImport(Token &Result) {
return true;
}
+/// Lex a token following the 'module' contextual keyword.
+///
+/// [cpp.module]/p2:
+/// The pp-tokens, if any, of a pp-module shall be of the form:
+/// pp-module-name p
@@ -0,0 +1,87 @@
+// RUN: rm -rf %t
+// RUN: mkdir -p %t
+// RUN: split-file %s %t
+
+// RUN: %clang_cc1 -std=c++20 %t/A.cppm -triple x86_64-linux-gnu -verify
+// RUN: %clang_cc1 -std=c++20 %t/B.cppm -triple x86_64-linux-gnu -verify
+// RUN: %clang_cc1 -std=c++20 %t/C.cppm -triple
https://github.com/yronglin edited
https://github.com/llvm/llvm-project/pull/90574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1329,6 +1341,129 @@ bool Preprocessor::LexAfterModuleImport(Token &Result) {
return true;
}
+/// Lex a token following the 'module' contextual keyword.
+///
+/// [cpp.module]/p2:
+/// The pp-tokens, if any, of a pp-module shall be of the form:
+/// pp-module-name p
@@ -932,6 +932,12 @@ def warn_module_conflict : Warning<
InGroup;
// C++20 modules
+def err_module_decl_cannot_be_macros : Error<
+ "the name of a module%select{| partition}0 declaration cannot contains "
+ "an object-like macro %1, and the macro will not expand"
+ "%sele
yronglin wrote:
Thanks for your review @Bigcheese !
https://github.com/llvm/llvm-project/pull/90574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yronglin wrote:
Should we continue build a module declaration even if error occurred when
parsing module names?
https://github.com/llvm/llvm-project/pull/90574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mail
dwblaikie wrote:
> This approahc parallels the strategy used for
> [-enable-trivial-auto-var-init-zero-knowing-it-will-be-removed-from-clang](https://reviews.llvm.org/D125142),
> albeit a nicer name.
Fair enough - yeah, if we're wordsmithing this. Maybe "allow" would be a good
word, rather th
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/91503
Fixes [this
bug](https://github.com/llvm/llvm-project/pull/90152#issuecomment-2100932093)
caused by #90152.
Will add tests shortly.
>From 60d2030216403c7cfa8272396497d31aed314288 Mon Sep 17 00:00:00 2001
Fr
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/91503
>From fd4172e64384379a7c976c4ce597eac629bc111f Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 8 May 2024 12:59:24 -0400
Subject: [PATCH] [Clang][Sema] Fix lookup of dependent operator= named by
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Krystian Stasiowski (sdkrystian)
Changes
Fixes [this
bug](https://github.com/llvm/llvm-project/pull/90152#issuecomment-2100932093)
caused by #90152.
Will add tests shortly.
---
Full diff: https://github.com/llvm/llvm-project/pull/91503.
sdkrystian wrote:
@alexfh see #91503
https://github.com/llvm/llvm-project/pull/90152
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zygoloid approved this pull request.
Looks great!
I think it'd be good to understand what's happening with the static analyzer
test, and update the comment to explain. But given that this is fixing a
conformance / wrong code bug, I don't think we should block this PR on fixi
jyu2-git wrote:
Thanks @vitalybuka for merge this patch for me. I did see the TEST 'Clang ::
OpenMP/target_ast_print.cpp' FAILED . I am fixing.
https://github.com/llvm/llvm-project/pull/90885
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
@@ -578,6 +579,13 @@ llvm::Regex
*ClangTidyDiagnosticConsumer::getHeaderFilter() {
return HeaderFilter.get();
}
+llvm::Regex *ClangTidyDiagnosticConsumer::getExcludeHeaderFilter() {
+ if (!ExcludeHeaderFilter)
+ExcludeHeaderFilter = std::make_unique(
+*Context.
@@ -0,0 +1,111 @@
+// REQUIRES: amdgpu-registered-target
+// RUN: %clang_cc1 -triple spirv64-amd-amdhsa -fsyntax-only -verify %s
+
+#pragma OPENCL EXTENSION cl_khr_fp64 : enable
+
+kernel void test () {
+
+ int sgpr = 0, vgpr = 0, imm = 0;
+
+ // sgpr constraints
+ __asm__ ("s_
@@ -0,0 +1,111 @@
+// REQUIRES: amdgpu-registered-target
+// RUN: %clang_cc1 -triple spirv64-amd-amdhsa -fsyntax-only -verify %s
+
+#pragma OPENCL EXTENSION cl_khr_fp64 : enable
+
+kernel void test () {
+
+ int sgpr = 0, vgpr = 0, imm = 0;
+
+ // sgpr constraints
+ __asm__ ("s_
https://github.com/jyu2-git edited
https://github.com/llvm/llvm-project/pull/91426
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6178,10 +6178,16 @@ The current supported opcode vocabulary is limited:
the last entry from the second last entry and appends the result to the
expression stack.
- ``DW_OP_plus_uconst, 93`` adds ``93`` to the working expression.
-- ``DW_OP_LLVM_fragment, 16, 8`` specifi
@@ -6178,10 +6178,16 @@ The current supported opcode vocabulary is limited:
the last entry from the second last entry and appends the result to the
expression stack.
- ``DW_OP_plus_uconst, 93`` adds ``93`` to the working expression.
-- ``DW_OP_LLVM_fragment, 16, 8`` specifi
@@ -578,6 +579,13 @@ llvm::Regex
*ClangTidyDiagnosticConsumer::getHeaderFilter() {
return HeaderFilter.get();
}
+llvm::Regex *ClangTidyDiagnosticConsumer::getExcludeHeaderFilter() {
+ if (!ExcludeHeaderFilter)
+ExcludeHeaderFilter = std::make_unique(
+*Context.
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/88978
>From 3acc848f4fcc68445dfc849f9c6f8d384d3692af Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Tue, 16 Apr 2024 13:09:58 -0700
Subject: [PATCH 1/4] Adding C23 constexpr math functions fmin and frexp.
-
@@ -0,0 +1,59 @@
+// RUN: %clang_cc1 -x c++ -triple x86_64-unknown-unknown -std=c++23 \
+// RUN: -DWIN -emit-llvm -o - %s | FileCheck %s --check-prefixes=WIN
+
+// RUN: %clang_cc1 -x c++ -triple x86_64-unknown-unknown -std=c++23 \
+// RUN: -emit-llvm -o - %s | FileCheck %s --check
@@ -578,6 +579,13 @@ llvm::Regex
*ClangTidyDiagnosticConsumer::getHeaderFilter() {
return HeaderFilter.get();
}
+llvm::Regex *ClangTidyDiagnosticConsumer::getExcludeHeaderFilter() {
+ if (!ExcludeHeaderFilter)
+ExcludeHeaderFilter = std::make_unique(
+*Context.
@@ -14547,6 +14547,20 @@ bool FloatExprEvaluator::VisitCallExpr(const CallExpr
*E) {
default:
return false;
+ case Builtin::BI__builtin_frexp:
+ case Builtin::BI__builtin_frexpf:
+ case Builtin::BI__builtin_frexpl: {
+LValue Pointer;
+if (!EvaluateFloat(E->ge
zahiraam wrote:
@hubert-reinterpretcast Thanks for the reviews/suggestions. Let me know what
you think.
https://github.com/llvm/llvm-project/pull/88978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
@@ -0,0 +1,111 @@
+// REQUIRES: amdgpu-registered-target
+// RUN: %clang_cc1 -triple spirv64-amd-amdhsa -fsyntax-only -verify %s
+
+#pragma OPENCL EXTENSION cl_khr_fp64 : enable
+
+kernel void test () {
+
+ int sgpr = 0, vgpr = 0, imm = 0;
+
+ // sgpr constraints
+ __asm__ ("s_
adrian-prantl wrote:
Interesting. I though that the check-lldb target would clean the module cache
before each run?
https://github.com/llvm/llvm-project/blob/fcfc15b7052a311b7a045e2c6bd26fb5d0b7122c/lldb/test/CMakeLists.txt#L56
https://github.com/llvm/llvm-project/blob/fcfc15b7052a311b7a045e2c6
@@ -0,0 +1,111 @@
+// REQUIRES: amdgpu-registered-target
+// RUN: %clang_cc1 -triple spirv64-amd-amdhsa -fsyntax-only -verify %s
+
+#pragma OPENCL EXTENSION cl_khr_fp64 : enable
+
+kernel void test () {
+
+ int sgpr = 0, vgpr = 0, imm = 0;
+
+ // sgpr constraints
+ __asm__ ("s_
Fznamznon wrote:
Thank you everyone for the feedback. I'm working on applying.
https://github.com/llvm/llvm-project/pull/91364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/tmatheson-arm updated
https://github.com/llvm/llvm-project/pull/91490
>From 9097058fe1c6e661efe60899f0da7cfd966c6ee7 Mon Sep 17 00:00:00 2001
From: Tomas Matheson
Date: Wed, 8 May 2024 16:42:24 +0100
Subject: [PATCH 1/3] [AArch64] add some more tests for FMV
---
clang/test/
@@ -0,0 +1,381 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --check-attributes --check-globals all --filter "define|attributes"
--include-generated-funcs --version 4
+
+// Test/document all of the dependencies between possible AArch
@@ -0,0 +1,381 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --check-attributes --check-globals all --filter "define|attributes"
--include-generated-funcs --version 4
+
+// Test/document all of the dependencies between possible AArch
@@ -0,0 +1,25 @@
+// Test which driver flags enable/disable Function Multiversioning on aarch64.
+
+// FMV is enabled for non-android aarch64 targets:
+// RUN: %clang --target=aarch64 --rtlib=compiler-rt -### -c %s 2>&1 |
FileCheck -check-prefix=FMV-ENABLED %s
+// RUN: %clang --t
eddyz87 wrote:
Hi @dwblaikie, @yonghong-song,
Could you please take a look at this pull request?
Rationale is here:
https://github.com/llvm/llvm-project/pull/91422#issuecomment-2101104708
The CI failure seems to be a fluke as it is reported for
`DataFlowSanitizer-x86_64 :: release_shadow_space
https://github.com/eddyz87 ready_for_review
https://github.com/llvm/llvm-project/pull/91423
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-llvm-ir
Author: None (eddyz87)
Changes
This commit is a follow-up for BPF mailing list discussion at [1]. It changes
the way `__attribute__((btf_type_tag("...")))`s are represented in DWARF.
Prior to this commit type tags could only be attached to poin
tmatheson-arm wrote:
The autogenerated checks for `clang/test/CodeGen/aarch64-fmv-dependencies.c`
did not actually pass, due to changes in function ordering, so I have manually
written the check lines, which makes the intent clearer anyway.
Some things look odd to me:
- The "aes", "dgh", "fp",
eddyz87 wrote:
Hi @yonghong-song,
Could you please take a look at this pull request?
Rationale is here:
https://github.com/llvm/llvm-project/pull/91422#issuecomment-2101104708
@dafaust, @jemarch, @4ast, fyi.
https://github.com/llvm/llvm-project/pull/91424
_
https://github.com/eddyz87 ready_for_review
https://github.com/llvm/llvm-project/pull/91424
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: None (eddyz87)
Changes
This is a follow-up for BPF mailing list discussion at [1].
Previous commit in a series updated DWARF generation for the following example:
int __attribute__((btf_type_tag("tag1"))) *g;
To generate DWAR
https://github.com/PiotrZSL closed
https://github.com/llvm/llvm-project/pull/90621
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Piotr Zegar
Date: 2024-05-08T20:10:47+02:00
New Revision: 10bdcf6b4cd37d017753b3821fbf8eb2ad924a1a
URL:
https://github.com/llvm/llvm-project/commit/10bdcf6b4cd37d017753b3821fbf8eb2ad924a1a
DIFF:
https://github.com/llvm/llvm-project/commit/10bdcf6b4cd37d017753b3821fbf8eb2ad924a1a.diff
L
Author: Piotr Zegar
Date: 2024-05-08T20:11:10+02:00
New Revision: 37b6ba96dea54e7af3772d78c90bfb3fd61140f6
URL:
https://github.com/llvm/llvm-project/commit/37b6ba96dea54e7af3772d78c90bfb3fd61140f6
DIFF:
https://github.com/llvm/llvm-project/commit/37b6ba96dea54e7af3772d78c90bfb3fd61140f6.diff
L
https://github.com/PiotrZSL closed
https://github.com/llvm/llvm-project/pull/90736
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Artem-B created
https://github.com/llvm/llvm-project/pull/91516
None
>From 6bb4800a5ed7c5f2ffeaded874d72f7624539122 Mon Sep 17 00:00:00 2001
From: Artem Belevich
Date: Wed, 8 May 2024 11:07:34 -0700
Subject: [PATCH] [CUDA] Mark CUDA-12.4 as supported and introduce ptx 8.4.
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-driver
Author: Artem Belevich (Artem-B)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/91516.diff
6 Files Affected:
- (modified) clang/docs/ReleaseNotes.rst (+1)
- (modified) clang/include/clang/Ba
https://github.com/jhuber6 approved this pull request.
https://github.com/llvm/llvm-project/pull/91516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay edited
https://github.com/llvm/llvm-project/pull/91280
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay updated
https://github.com/llvm/llvm-project/pull/91280
>From a0cfafb82db825512b0ca44778fa9d4bb435563d Mon Sep 17 00:00:00 2001
From: Fangrui Song
Date: Mon, 6 May 2024 15:37:50 -0700
Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?=
=?UTF-
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 79921fbd5c6223ff7e6c75ed75974b4d16cad529
24c0fbb48e1cc7ffb9b3d321a11d399452e00341 --
MaskRay wrote:
```
// TODO: Experimental CREL relocations. LLVM will change the value and
// break compatibility in the future.
SHT_CREL = 0x4014,
```
Switched to 0x4014 (generic range) to retain linker errors while making the
experimental status stand out. Add a comment to make th
Author: Artem Belevich
Date: 2024-05-08T12:02:57-07:00
New Revision: 2f956a35edb61d250a52c4d883f368d060fae57c
URL:
https://github.com/llvm/llvm-project/commit/2f956a35edb61d250a52c4d883f368d060fae57c
DIFF:
https://github.com/llvm/llvm-project/commit/2f956a35edb61d250a52c4d883f368d060fae57c.diff
https://github.com/Artem-B closed
https://github.com/llvm/llvm-project/pull/91516
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/91498
>From 60d2030216403c7cfa8272396497d31aed314288 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 8 May 2024 12:18:49 -0400
Subject: [PATCH 1/2] [Clang][Sema] Fix lookup of dependent operator= outsi
https://github.com/jakeegan created
https://github.com/llvm/llvm-project/pull/91522
This fixes matching `clang: error: argument unused during compilation:
'-Werror' [-Werror,-Wunused-command-line-argument]` on AIX.
>From 7684f9e6f99c30287f2822152dc83367a934d8b6 Mon Sep 17 00:00:00 2001
From: J
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-driver
Author: Jake Egan (jakeegan)
Changes
This fixes matching `clang: error: argument unused during compilation:
'-Werror' [-Werror,-Wunused-command-line-argument]` on AIX.
---
Full diff: https://github.com/llvm/llvm-
kovdan01 wrote:
@MaskRay Please let me know if you have some additional feedback after the
latest updates b0f9a1985846448d01af9bacdb6e3ddb23d4588f or if this can be
merged.
https://github.com/llvm/llvm-project/pull/85235
___
cfe-commits mailing list
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/91503
>From fd4172e64384379a7c976c4ce597eac629bc111f Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 8 May 2024 12:59:24 -0400
Subject: [PATCH 1/2] [Clang][Sema] Fix lookup of dependent operator= named
Nathan =?utf-8?q?Gau=C3=ABr?= ,
Nathan =?utf-8?q?Gau=C3=ABr?= ,
Nathan =?utf-8?q?Gau=C3=ABr?= ,
Nathan =?utf-8?q?Gau=C3=ABr?=
Message-ID:
In-Reply-To:
https://github.com/sudonatalie approved this pull request.
https://github.com/llvm/llvm-project/pull/88918
___
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/91503
>From fd4172e64384379a7c976c4ce597eac629bc111f Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 8 May 2024 12:59:24 -0400
Subject: [PATCH 1/3] [Clang][Sema] Fix lookup of dependent operator= named
https://github.com/erichkeane edited
https://github.com/llvm/llvm-project/pull/91498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane commented:
few little things? Mostly looks ok.
https://github.com/llvm/llvm-project/pull/91498
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1269,19 +1269,19 @@ struct FindLocalExternScope {
};
} // end anonymous namespace
+static bool isDependentAssignmentOperator(DeclarationName Name,
+ DeclContext *LookupContext) {
+ auto *LookupRecord = dyn_cast_if_present(LookupCon
@@ -1269,19 +1269,19 @@ struct FindLocalExternScope {
};
} // end anonymous namespace
+static bool isDependentAssignmentOperator(DeclarationName Name,
+ DeclContext *LookupContext) {
+ auto *LookupRecord = dyn_cast_if_present(LookupCon
@@ -137,17 +137,16 @@ namespace InhCtor {
int n = b.T(); // expected-error {{'T' is a protected member of
'InhCtor::A'}}
// expected-note@-15 {{declared protected here}}
- // FIXME: EDG and GCC reject this too, but it's not clear why it would be
- // ill-
PiotrZSL wrote:
@5chmidti
I did some testing with this. And in example that you provided there is no
issue.
This is because if optional will be uninitialized, then this code won't compile
regardless if .value() or operator * is used.
Compiler will simply complain that expression is not constex
@@ -137,17 +137,16 @@ namespace InhCtor {
int n = b.T(); // expected-error {{'T' is a protected member of
'InhCtor::A'}}
// expected-note@-15 {{declared protected here}}
- // FIXME: EDG and GCC reject this too, but it's not clear why it would be
- // ill-
@@ -1269,19 +1269,19 @@ struct FindLocalExternScope {
};
} // end anonymous namespace
+static bool isDependentAssignmentOperator(DeclarationName Name,
+ DeclContext *LookupContext) {
+ auto *LookupRecord = dyn_cast_if_present(LookupCon
@@ -1269,19 +1269,19 @@ struct FindLocalExternScope {
};
} // end anonymous namespace
+static bool isDependentAssignmentOperator(DeclarationName Name,
+ DeclContext *LookupContext) {
+ auto *LookupRecord = dyn_cast_if_present(LookupCon
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/91498
>From 60d2030216403c7cfa8272396497d31aed314288 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 8 May 2024 12:18:49 -0400
Subject: [PATCH 1/4] [Clang][Sema] Fix lookup of dependent operator= outsi
@@ -1248,6 +1248,13 @@ static DeclContext *findOuterContext(Scope *S) {
return nullptr;
}
+static bool isDependentAssignmentOperator(DeclarationName Name,
erichkeane wrote:
a comment on this function similar to what you replied to me before woudl also
be a
@@ -1248,6 +1248,13 @@ static DeclContext *findOuterContext(Scope *S) {
return nullptr;
}
+static bool isDependentAssignmentOperator(DeclarationName Name,
erichkeane wrote:
Ah, perhaps I was confusing... i'd like this inside the `namespace {`, now
below.
@@ -137,17 +137,16 @@ namespace InhCtor {
int n = b.T(); // expected-error {{'T' is a protected member of
'InhCtor::A'}}
// expected-note@-15 {{declared protected here}}
- // FIXME: EDG and GCC reject this too, but it's not clear why it would be
- // ill-
@@ -137,17 +137,16 @@ namespace InhCtor {
int n = b.T(); // expected-error {{'T' is a protected member of
'InhCtor::A'}}
// expected-note@-15 {{declared protected here}}
- // FIXME: EDG and GCC reject this too, but it's not clear why it would be
- // ill-
SimplyDanny wrote:
Why can the tests not just accept reference files that do not contain any
`CHECK-*` comments? Then, no separate argument would be needed. In fact, I
still sometimes struggle to find the correct options, command line and
`CHECK-*` syntax. More options further complicate the s
https://github.com/justincady updated
https://github.com/llvm/llvm-project/pull/91400
>From a5de583aa94ef794a083c8b27df6dc6fc0762cb7 Mon Sep 17 00:00:00 2001
From: Justin Cady
Date: Tue, 7 May 2024 16:54:35 -0400
Subject: [PATCH 1/2] Add option to exclude headers from clang-tidy analysis
This
@@ -578,6 +579,13 @@ llvm::Regex
*ClangTidyDiagnosticConsumer::getHeaderFilter() {
return HeaderFilter.get();
}
+llvm::Regex *ClangTidyDiagnosticConsumer::getExcludeHeaderFilter() {
+ if (!ExcludeHeaderFilter)
+ExcludeHeaderFilter = std::make_unique(
+*Context.
@@ -309,21 +309,8 @@ class TrivialFunctionAnalysisVisitor
bool VisitDefaultStmt(const DefaultStmt *DS) { return VisitChildren(DS); }
bool VisitUnaryOperator(const UnaryOperator *UO) {
-// Operator '*' and '!' are allowed as long as the operand is trivial.
-auto op
https://github.com/haoNoQ edited https://github.com/llvm/llvm-project/pull/91102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/haoNoQ approved this pull request.
LGTM now thanks!
https://github.com/llvm/llvm-project/pull/91102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cjappl closed https://github.com/llvm/llvm-project/pull/91529
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/haoNoQ edited https://github.com/llvm/llvm-project/pull/91102
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
201 - 300 of 378 matches
Mail list logo
