pogo59 wrote:
> I want to hear about opinions why the old compiler-rt file hierarchy is
> preferred by some users.
I think if you really want a range of opinions, you can get them from an RFC.
Not many people will be watching this PR.
https://github.com/llvm/llvm-project/pull/89775
__
Author: Duo Wang
Date: 2024-05-07T16:51:12+01:00
New Revision: b2477765dbf9bd28bd2d1813c41ae12613f87717
URL:
https://github.com/llvm/llvm-project/commit/b2477765dbf9bd28bd2d1813c41ae12613f87717
DIFF:
https://github.com/llvm/llvm-project/commit/b2477765dbf9bd28bd2d1813c41ae12613f87717.diff
LOG:
https://github.com/goussepi closed
https://github.com/llvm/llvm-project/pull/91021
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,7 @@
+// RUN: %clang --target=riscv64 -menable-experimental-extensions -c -o
/dev/null %s
+// RUN: ! %clang --target=riscv64 -c -o /dev/null %s 2>&1 | FileCheck
-check-prefixes=CHECK-ERR %s
yetingk wrote:
Thank you. I will fix this if https://github.
https://github.com/yetingk edited
https://github.com/llvm/llvm-project/pull/89727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -111,6 +111,13 @@ Clang Frontend Potentially Breaking Changes
$ clang --target= -print-target-triple
+- The ``getTypeAsWritten`` member function has been removed from
``ClassTemplateSpecializationDecl`` and
+ ``VarTemplateSpecializationDecl``, and a new member fu
@@ -0,0 +1,7 @@
+// RUN: %clang --target=riscv64 -menable-experimental-extensions -c -o
/dev/null %s
yetingk wrote:
Yes. I am sorry that I didn't find out the obvious mistake. I am going to
review my development process.
https://github.com/llvm/llvm-project/pu
@@ -111,6 +111,13 @@ Clang Frontend Potentially Breaking Changes
$ clang --target= -print-target-triple
+- The ``getTypeAsWritten`` member function has been removed from
``ClassTemplateSpecializationDecl`` and
+ ``VarTemplateSpecializationDecl``, and a new member fu
@@ -111,6 +111,13 @@ Clang Frontend Potentially Breaking Changes
$ clang --target= -print-target-triple
+- The ``getTypeAsWritten`` member function has been removed from
``ClassTemplateSpecializationDecl`` and
+ ``VarTemplateSpecializationDecl``, and a new member fu
https://github.com/petrhosek updated
https://github.com/llvm/llvm-project/pull/91028
>From 78193f68a149e378fbb180a1a5fa1f4551f2af66 Mon Sep 17 00:00:00 2001
From: Petr Hosek
Date: Fri, 3 May 2024 15:48:31 -0700
Subject: [PATCH 1/5] [Clang] -fseparate-named-sections option
When set, the compile
@@ -277,6 +277,8 @@ namespace llvm {
/// Use unique names for basic block sections.
unsigned UniqueBasicBlockSectionNames : 1;
+unsigned SeparateNamedSections : 1;
petrhosek wrote:
Done
https://github.com/llvm/llvm-project/pull/91028
@@ -221,6 +221,11 @@ New Compiler Flags
- ``-fexperimental-modules-reduced-bmi`` enables the Reduced BMI for C++20
named modules.
See the document of standard C++ modules for details.
+- ``-fseparate-named-sections`` uses separate unique sections for global
+ symbols in na
@@ -518,6 +518,16 @@ class TargetInfo : public TransferrableTargetInfo,
/// getInt128Align() - Returns the alignment of Int128.
unsigned getInt128Align() const { return Int128Align; }
+ /// getBitIntAlign/Width - Return aligned size of '_BitInt' and
+ /// 'unsigned _BitI
soukatch wrote:
Thank you everyone for the reviews!
https://github.com/llvm/llvm-project/pull/90012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -8194,25 +8216,18 @@ void Sema::checkInitializerLifetime(const
InitializedEntity &Entity,
}
switch (shouldLifetimeExtendThroughPath(Path)) {
+ case PathLifetimeKind::ShouldExtend:
yronglin wrote:
Yeah, `ShouldExtend ` can be removed, and
Author: Fangrui Song
Date: 2024-05-07T09:15:52-07:00
New Revision: e74a7a9fd79a74073277471243a44527c71eb4a9
URL:
https://github.com/llvm/llvm-project/commit/e74a7a9fd79a74073277471243a44527c71eb4a9
DIFF:
https://github.com/llvm/llvm-project/commit/e74a7a9fd79a74073277471243a44527c71eb4a9.diff
https://github.com/MaskRay closed
https://github.com/llvm/llvm-project/pull/91140
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MatzeB updated
https://github.com/llvm/llvm-project/pull/91275
>From c0b7ec2e336476b1a1d6cf05d07bfde2f3dc88a4 Mon Sep 17 00:00:00 2001
From: Matthias Braun
Date: Mon, 6 May 2024 14:39:37 -0700
Subject: [PATCH 1/6] Use cmake to find perl executable
---
clang/CMakeLists.txt
@@ -206,13 +206,10 @@ namespace cwg1814 { // cwg1814: yes
#endif
}
-namespace cwg1815 { // cwg1815: no
+namespace cwg1815 { // cwg1815: yes
yronglin wrote:
Agree 100%!
https://github.com/llvm/llvm-project/pull/87933
__
@@ -269,6 +269,26 @@ void init_capture_init_list() {
// CHECK: }
}
+void check_dr1815() { // dr1815: yes
+#if __cplusplus >= 201402L
+
+ struct A {
+int &&r = 0;
+~A() {}
+ };
+
+ struct B {
+A &&a = A{};
+~B() {}
+ };
+
+ // CHECK: void @_Z12check_dr181
@@ -10698,7 +10698,7 @@ C++ defect report implementation
status
https://cplusplus.github.io/CWG/issues/1815.html";>1815
CD4
Lifetime extension in aggregate initialization
-No
+Clang 19
yronglin wrote:
Thanks for your tips!
https://github.
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88963
>From 01db101ca28f26181dfedeaef1ec49a5ae42ee99 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 16 Apr 2024 13:36:11 -0400
Subject: [PATCH 1/8] [Clang][Sema] Improve support for explicit
speciali
https://github.com/petrhosek updated
https://github.com/llvm/llvm-project/pull/91028
>From 78193f68a149e378fbb180a1a5fa1f4551f2af66 Mon Sep 17 00:00:00 2001
From: Petr Hosek
Date: Fri, 3 May 2024 15:48:31 -0700
Subject: [PATCH 1/5] [Clang] -fseparate-named-sections option
When set, the compile
Author: Petr Hosek
Date: 2024-05-07T09:18:55-07:00
New Revision: 8bcb0737056163686e967821bea7f9e87c57cdfc
URL:
https://github.com/llvm/llvm-project/commit/8bcb0737056163686e967821bea7f9e87c57cdfc
DIFF:
https://github.com/llvm/llvm-project/commit/8bcb0737056163686e967821bea7f9e87c57cdfc.diff
LO
https://github.com/petrhosek closed
https://github.com/llvm/llvm-project/pull/91028
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/topperc approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/91324
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MatzeB updated
https://github.com/llvm/llvm-project/pull/91275
>From c0b7ec2e336476b1a1d6cf05d07bfde2f3dc88a4 Mon Sep 17 00:00:00 2001
From: Matthias Braun
Date: Mon, 6 May 2024 14:39:37 -0700
Subject: [PATCH 1/6] Use cmake to find perl executable
---
clang/CMakeLists.txt
sdkrystian wrote:
@erichkeane I added two release notes (one for the bug fix to constraint
substitution, and one for allowing explicit specializations of constrained
member functions).
https://github.com/llvm/llvm-project/pull/88963
___
cfe-commits
AaronBallman wrote:
> Thank you everyone for the reviews!
Thank you for the improvement!
https://github.com/llvm/llvm-project/pull/90012
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commit
@@ -8194,25 +8216,18 @@ void Sema::checkInitializerLifetime(const
InitializedEntity &Entity,
}
switch (shouldLifetimeExtendThroughPath(Path)) {
+ case PathLifetimeKind::ShouldExtend:
yronglin wrote:
Hmm, thanks point it out, somehow I misund
https://github.com/yronglin deleted
https://github.com/llvm/llvm-project/pull/87933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -711,6 +711,26 @@ void InitListChecker::FillInEmptyInitForField(unsigned
Init, FieldDecl *Field,
if (VerifyOnly)
return;
+ // Enter a lifetime extension context, then we can support lifetime
+ // extension of temporary created by aggregate initializ
@@ -122,7 +122,7 @@ void aggregateWithReferences() {
clang_analyzer_dump(viaReference.ry); // expected-warning-re
{{&lifetime_extended_object{Composite, viaReference, S{{[0-9]+}}} }}
// clang does not currently implement extending lifetime of object bound to
reference me
https://github.com/sdesmalen-arm created
https://github.com/llvm/llvm-project/pull/91356
Scalable types are only available when:
* The function is compiled with +sve
* The function is compiled with +sme and the function is executed in
Streaming-SVE mode.
>From 1cc17981a612dcb31fba86c5d64c444f2
yronglin wrote:
Thanks for you review!
https://github.com/llvm/llvm-project/pull/87933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Sander de Smalen (sdesmalen-arm)
Changes
Scalable types are only available when:
* The function is compiled with +sve
* The function is compiled with +sme and the function is executed in
Streaming-SVE mode.
---
Patch is 73.71 KiB, trunca
https://github.com/jhuber6 updated
https://github.com/llvm/llvm-project/pull/87009
>From 6dfa6dc2956ca714e98bf24b176315da42446553 Mon Sep 17 00:00:00 2001
From: Joseph Huber
Date: Thu, 28 Mar 2024 16:18:19 -0500
Subject: [PATCH] [Libomptarget] Statically link all plugin runtimes
Summary:
This
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88963
>From 01db101ca28f26181dfedeaef1ec49a5ae42ee99 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 16 Apr 2024 13:36:11 -0400
Subject: [PATCH 1/9] [Clang][Sema] Improve support for explicit
speciali
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 6a6fcbffbb31f83fab7425d43e28eb6aa39dbfe9
1cc17981a612dcb31fba86c5d64c444f26a44d38 --
https://github.com/sdesmalen-arm updated
https://github.com/llvm/llvm-project/pull/91356
>From 9cbff1320d6f47245c97559bf3c614b931e80f06 Mon Sep 17 00:00:00 2001
From: Sander de Smalen
Date: Fri, 3 May 2024 13:07:18 +0100
Subject: [PATCH] [Clang][AArch64] Require SVE or SSVE for scalable types.
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88963
>From 01db101ca28f26181dfedeaef1ec49a5ae42ee99 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 16 Apr 2024 13:36:11 -0400
Subject: [PATCH 01/10] [Clang][Sema] Improve support for explicit
specia
Author: Yeting Kuo
Date: 2024-05-08T00:40:18+08:00
New Revision: 1318230587c30acb82324f851734a40341847a50
URL:
https://github.com/llvm/llvm-project/commit/1318230587c30acb82324f851734a40341847a50
DIFF:
https://github.com/llvm/llvm-project/commit/1318230587c30acb82324f851734a40341847a50.diff
LO
https://github.com/yetingk closed
https://github.com/llvm/llvm-project/pull/91324
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/yronglin edited
https://github.com/llvm/llvm-project/pull/87933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ellishg wrote:
@benlangmuir do you have other concerns? Can I get a stamp?
https://github.com/llvm/llvm-project/pull/90925
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jakeegan wrote:
Hi, the test plugin-driver-args.cpp is failing on AIX now, could you take a
look please?
https://lab.llvm.org/buildbot/#/builders/214/builds/12118/steps/6/logs/FAIL__Clang__plugin-driver-args_cpp
https://github.com/llvm/llvm-project/pull/88948
___
https://github.com/aemerson approved this pull request.
https://github.com/llvm/llvm-project/pull/91356
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay wrote:
This PR will address a Linux kernel need.
https://lore.kernel.org/all/CAFP8O3JkgQsH-4Lmr2W_teuvLjOCPi1htr9r3CO1O0yLyw=a...@mail.gmail.com/
The code already assembles with `clang -S -fno-integrated-as` and `gcc -c`,
and this patch is to make `clang -c` work by removeing an unnecess
alexey-bataev wrote:
> ```llvm
> struct.anon
> ```
Can you provide full IR dump here?
https://github.com/llvm/llvm-project/pull/91264
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/wxz2020 updated
https://github.com/llvm/llvm-project/pull/91022
>From 8aebe46d7fdd15f02a9716718f53b03056ef0d19 Mon Sep 17 00:00:00 2001
From: Wei Zhao
Date: Fri, 3 May 2024 22:01:58 +
Subject: [PATCH 1/2] [AArch64] Add support for Qualcomm Oryon processor
---
clang/test
https://github.com/llvm-beanz approved this pull request.
https://github.com/llvm/llvm-project/pull/89836
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Wei Zhao (wxz2020)
Changes
Oryon is an ARM V8 AArch64 CPU from Qualcomm.
---
Patch is 73.24 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/91022.diff
10 Files Affected:
- (added) clang/test
@@ -833,32 +833,33 @@ bool SimpleASTReaderListener::ReadPreprocessorOptions(
/// against the header search options in an existing preprocessor.
///
/// \param Diags If non-null, produce diagnostics for any mismatches incurred.
-static bool checkHeaderSearchOptions(const HeaderS
https://github.com/benlangmuir approved this pull request.
LGTM if we rename the checkHeaderSearchOptions function.
https://github.com/llvm/llvm-project/pull/90925
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
https://github.com/benlangmuir edited
https://github.com/llvm/llvm-project/pull/90925
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -85,6 +85,10 @@ def SMEUnsupported : AArch64Unsupported {
SME2Unsupported.F);
}
+def MTEUnsupported : AArch64Unsupported {
+ let F = [HasMTE];
+}
+
wxz2020 wrote:
Thanks for the FIXME prompt, I got it fixed and did some cleaning, Jus
jhuber6 wrote:
> > ```llvm
> > struct.anon
> > ```
>
> Can you provide full IR dump here?
https://godbolt.org/z/48h5s3W6v
https://github.com/llvm/llvm-project/pull/91264
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/c
@@ -85,6 +85,10 @@ def SMEUnsupported : AArch64Unsupported {
SME2Unsupported.F);
}
+def MTEUnsupported : AArch64Unsupported {
+ let F = [HasMTE];
+}
+
jthackray wrote:
Thanks for removing those. Can't see anything else obviously wrong.
https://github.com/jthackray deleted
https://github.com/llvm/llvm-project/pull/91022
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jthackray deleted
https://github.com/llvm/llvm-project/pull/91022
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jthackray deleted
https://github.com/llvm/llvm-project/pull/91022
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,58 @@
+// RUN: %clang_cc1 -std=c++20 -verify %s
+
+template
+concept C = I >= 4;
+
+template
+concept D = I < 8;
+
+template
+struct A {
+ constexpr static int f() { return 0; }
+ constexpr static int f() requires C && D { return 1; }
+ constexpr static int f() requi
@@ -5386,6 +5386,130 @@ bool
AMDGPULegalizerInfo::legalizeDSAtomicFPIntrinsic(LegalizerHelper &Helper,
return true;
}
+bool AMDGPULegalizerInfo::legalizeLaneOp(LegalizerHelper &Helper,
+ MachineInstr &MI,
+
@@ -5386,6 +5386,130 @@ bool
AMDGPULegalizerInfo::legalizeDSAtomicFPIntrinsic(LegalizerHelper &Helper,
return true;
}
+bool AMDGPULegalizerInfo::legalizeLaneOp(LegalizerHelper &Helper,
+ MachineInstr &MI,
+
@@ -5982,6 +5982,68 @@ static SDValue lowerBALLOTIntrinsic(const
SITargetLowering &TLI, SDNode *N,
DAG.getConstant(0, SL, MVT::i32), DAG.getCondCode(ISD::SETNE));
}
+static SDValue lowerLaneOp(const SITargetLowering &TLI, SDNode *N,
+ Selection
@@ -5386,6 +5386,130 @@ bool
AMDGPULegalizerInfo::legalizeDSAtomicFPIntrinsic(LegalizerHelper &Helper,
return true;
}
+bool AMDGPULegalizerInfo::legalizeLaneOp(LegalizerHelper &Helper,
+ MachineInstr &MI,
+
@@ -5386,6 +5386,130 @@ bool
AMDGPULegalizerInfo::legalizeDSAtomicFPIntrinsic(LegalizerHelper &Helper,
return true;
}
+bool AMDGPULegalizerInfo::legalizeLaneOp(LegalizerHelper &Helper,
+ MachineInstr &MI,
+
@@ -504,3 +508,16 @@ def AMDGPUdiv_fmas : PatFrags<(ops node:$src0, node:$src1,
node:$src2, node:$vcc
def AMDGPUperm : PatFrags<(ops node:$src0, node:$src1, node:$src2),
[(int_amdgcn_perm node:$src0, node:$src1, node:$src2),
(AMDGPUperm_impl node:$src0, node:$src1, node:$
https://github.com/python3kgae updated
https://github.com/llvm/llvm-project/pull/89836
>From 4d8c72688656fe3b2ce8817087d8cf7352b5876b Mon Sep 17 00:00:00 2001
From: Xiang Li
Date: Tue, 23 Apr 2024 17:49:02 -0400
Subject: [PATCH 1/9] [HLSL] Support packoffset attribute in AST
Add HLSLPackOffset
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?=
Message-ID:
In-Reply-To:
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/88918
___
cfe-commits mailing list
cfe-commit
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?= ,
Nathan =?utf-8?q?Gauër?=
Message-ID:
In-Reply-To:
https://github.com/arsenm edited https://github.com/llvm/llvm-project/pull/88918
___
cfe-commits mailing list
cfe-commit
Nathan =?utf-8?q?Gau=C3=ABr?= ,
Nathan =?utf-8?q?Gau=C3=ABr?= ,
Nathan =?utf-8?q?Gau=C3=ABr?= ,
Nathan =?utf-8?q?Gau=C3=ABr?=
Message-ID:
In-Reply-To:
https://github.com/arsenm approved this pull request.
https://github.com/llvm/llvm-project/pull/88918
Nathan =?utf-8?q?Gau=C3=ABr?= ,
Nathan =?utf-8?q?Gau=C3=ABr?= ,
Nathan =?utf-8?q?Gau=C3=ABr?= ,
Nathan =?utf-8?q?Gau=C3=ABr?=
Message-ID:
In-Reply-To:
@@ -1586,6 +1586,12 @@ class CodeGenModule : public CodeGenTypeCache {
void AddGlobalDtor(llvm::Function *Dtor, int Priority
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/91339
>From b199345e93410ad4e7f7f4b37f09c7e66572d43a Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 7 May 2024 10:07:26 -0400
Subject: [PATCH 1/6] [Clang][Sema] Don't set instantiated from function wh
https://github.com/dschuff approved this pull request.
LGTM.
Are we currently running wasm-eh tests on the Chromium CI with node 16? If so,
I guess this will have the same issue we had when we tried to turn it on by
default.
I don't think this needs to be a showstopper in the same way (since th
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88963
>From 01db101ca28f26181dfedeaef1ec49a5ae42ee99 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Tue, 16 Apr 2024 13:36:11 -0400
Subject: [PATCH 01/11] [Clang][Sema] Improve support for explicit
specia
https://github.com/Fznamznon created
https://github.com/llvm/llvm-project/pull/91364
Currently for i128:128 targets correct implementation is possible either for
__int128 or for _BitInt(129+) with lowering to iN, but not both. Since we have
now correct implementation of __int128 in place afte
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-clang-codegen
Author: Mariya Podchishchaeva (Fznamznon)
Changes
Currently for i128:128 targets correct implementation is possible either for
__int128 or for _BitInt(129+) with lowering to iN, but not both. Since we have
now
https://github.com/erichkeane approved this pull request.
happy now :)
https://github.com/llvm/llvm-project/pull/88963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane commented:
This is unfortunate, and will likely result in the FPGAs needing to generate
extra bits here, so this is somewhat harmful in that regard.
It seems to me this is a case where we're trying to work -around an llvm bug?
Should we just be fixing that instea
@@ -1774,6 +1774,18 @@ llvm::Constant
*ConstantEmitter::emitForMemory(CodeGenModule &CGM,
return Res;
}
+ if (const auto *BIT = destType->getAs()) {
+if (BIT->getNumBits() > 128) {
+ // Long _BitInt has array of bytes as in-memory type.
+ ConstantAggregat
https://github.com/efriedma-quic edited
https://github.com/llvm/llvm-project/pull/91364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/efriedma-quic commented:
Maybe add a helper somewhere to check "is this type a bitint wider than 128
bits"?
https://github.com/llvm/llvm-project/pull/91364
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
@@ -5348,6 +5348,13 @@ Value *ScalarExprEmitter::VisitVAArgExpr(VAArgExpr *VE) {
return llvm::UndefValue::get(ArgTy);
}
+ if (const auto *BIT = Ty->getAs()) {
+if (BIT->getNumBits() > 128) {
efriedma-quic wrote:
This seems a little fragile; specifi
https://github.com/AaronBallman updated
https://github.com/llvm/llvm-project/pull/90237
>From a75aa14fcad6f346a3073ae88e91fa890e803422 Mon Sep 17 00:00:00 2001
From: Aaron Ballman
Date: Fri, 26 Apr 2024 13:12:51 -0400
Subject: [PATCH 1/2] Revise the modules document for clarity
The intention i
eaeltsin wrote:
Hi, is there a way to make a compile-time check for this feature?
Looking at
1.
https://github.com/xtensor-stack/xtensor/blob/master/include/xtensor/xutils.hpp#L1029
2.
https://github.com/xtensor-stack/xtensor/blob/master/include/xtensor/xstorage.hpp#L1415
After this commit,
efriedma-quic wrote:
> It seems to me this is a case where we're trying to work -around an llvm bug?
> Should we just be fixing that instead?
You mean, revert https://reviews.llvm.org/D86310 ? Making any changes in LLVM
here is painful; I'd rather not revisit that. CC @hvdijk @rnk
https://g
erichkeane wrote:
> > It seems to me this is a case where we're trying to work -around an llvm
> > bug? Should we just be fixing that instead?
>
> You mean, revert https://reviews.llvm.org/D86310 ? Making any changes in LLVM
> here is painful; I'd rather not revisit that. CC @hvdijk @rnk
I di
efriedma-quic wrote:
I don't think FPGA folks will run into any practical issue with this; this only
impacts the in-memory types, and backends shouldn't really be using in-memory
types for anything anyways.
https://github.com/llvm/llvm-project/pull/91364
___
@@ -8,79 +8,60 @@ Standard C++ Modules
Introduction
-The term ``modules`` has a lot of meanings. For the users of Clang, modules may
-refer to ``Objective-C Modules``, ``Clang C++ Modules`` (or ``Clang Header
Modules``,
-etc.) or ``Standard C++ Modules``. The imp
mizvekov wrote:
> Hi, is there a way to make a compile-time check for this feature?
Yes, this is exposed by a standard feature testing macro:
https://en.cppreference.com/w/cpp/feature_test#cpp_template_template_args
>
> Looking at
>
Thanks for reporting this. A few questions:
* Does https:/
@@ -1989,6 +1989,14 @@ llvm::Value *CodeGenFunction::EmitLoadOfScalar(Address
Addr, bool Volatile,
return EmitAtomicLoad(AtomicLValue, Loc).getScalarVal();
}
+ if (const auto *BIT = Ty->getAs()) {
+if (BIT->getNumBits() > 128) {
hvdijk wrote:
For
smithp35 wrote:
Thanks for the additional context. My main concern is that we're undoing the
consensus of https://reviews.llvm.org/D45164 which if I've understood the
comments properly was "There is a reasonable expectation that compiled (not
assembled) code should be identical, or at least as
@@ -1,14 +1,17 @@
// RUN: %clang_cc1 %s -triple=amdgcn-amd-amdhsa -std=c++11 -emit-llvm -o %t.ll
-O1 -disable-llvm-passes -fms-extensions -fstrict-vtable-pointers
+// RUN: %clang_cc1 %s -triple i686-pc-win32 -emit-llvm -o %t.ms.ll -O1
-disable-llvm-passes -fms-extensions -fstri
mizvekov wrote:
Oh I see the code already includes workaround for GCC vs non-GCC. It's possible
in this case you may replace the workaround with a check for the feature
testing macro.
But if this is a new ambiguity not covered by any of the cases I am tracking,
it could still be worthwhile to
alexey-bataev wrote:
> > > ```llvm
> > > struct.anon
> > > ```
> >
> >
> > Can you provide full IR dump here?
>
> https://godbolt.org/z/48h5s3W6v
It does not look like the issue of the target code, I don't see any wrong
access for __context. Мост probably something wrong with the host code/r
hvdijk wrote:
Thanks for doing this, it's unfortunate that Clang is in a rather broken state
with these types right now and it will be good to see improvement. I think the
approach you're taking here is the only approach that will work.
https://github.com/llvm/llvm-project/pull/91364
_
jhuber6 wrote:
> > > > ```llvm
> > > > struct.anon
> > > > ```
> > >
> > >
> > > Can you provide full IR dump here?
> >
> >
> > https://godbolt.org/z/48h5s3W6v
>
> It does not look like the issue of the target code, I don't see any wrong
> access for __context. Мост probably something wrong
Author: Brendan Dahl
Date: 2024-05-07T11:33:10-07:00
New Revision: 1a2a1fbd7c03381fe5e4f459f7081bef13366ef4
URL:
https://github.com/llvm/llvm-project/commit/1a2a1fbd7c03381fe5e4f459f7081bef13366ef4
DIFF:
https://github.com/llvm/llvm-project/commit/1a2a1fbd7c03381fe5e4f459f7081bef13366ef4.diff
https://github.com/tlively closed
https://github.com/llvm/llvm-project/pull/90906
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
201 - 300 of 488 matches
Mail list logo
