[clang] [llvm] [RISCV] Add smstateen extension (PR #90818)

2024-05-02 Thread Kito Cheng via cfe-commits
https://github.com/kito-cheng commented: Don't forgot `llvm/docs/RISCVUsage.rst`, otherwise LGTM :P https://github.com/llvm/llvm-project/pull/90818 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[clang] [clang] pointer to member with qualified-id enclosed in parentheses in unevaluated context should be invalid (PR #89713)

2024-05-02 Thread via cfe-commits
cor3ntin wrote: @zwuis Thanks for your contribution. Will you need me to merge that for you? https://github.com/llvm/llvm-project/pull/89713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com

[clang] [clang][Sema] Re-use existing BinaryOperator if possible (PR #90625)

2024-05-02 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/90625 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] Reapply "[Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent

2024-05-02 Thread Luke Lau via cfe-commits
lukel97 wrote: Hi, this seems to uncover an unfortunate error in xalan-c https://github.com/apache/xalan-c/blob/c326619da4813acfc845c2830d904a4860f9afe1/src/xalanc/XMLSupport/XalanOtherEncodingWriter.hpp#L323 which is present in one of the SPEC CPU 2017 benchmarks (and prevents SPEC CPU 2017 f

[clang] cd132dc - [clang] fix(85447): clang 18.1.0 crashes in clang::ASTContext::getTypeInfoImpl (#89850)

2024-05-02 Thread via cfe-commits
Author: Oleksandr T Date: 2024-05-02T09:22:59+02:00 New Revision: cd132dcbeb0fc79fd657bd5e0a8e9244c3fb5da6 URL: https://github.com/llvm/llvm-project/commit/cd132dcbeb0fc79fd657bd5e0a8e9244c3fb5da6 DIFF: https://github.com/llvm/llvm-project/commit/cd132dcbeb0fc79fd657bd5e0a8e9244c3fb5da6.diff L

[clang] [clang] fix(85447): clang 18.1.0 crashes in clang::ASTContext::getTypeInfoImpl (PR #89850)

2024-05-02 Thread via cfe-commits
https://github.com/cor3ntin closed https://github.com/llvm/llvm-project/pull/89850 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] fix(85447): clang 18.1.0 crashes in clang::ASTContext::getTypeInfoImpl (PR #89850)

2024-05-02 Thread via cfe-commits
github-actions[bot] wrote: @a-tarasyuk Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a bui

[clang] [clang] pointer to member with qualified-id enclosed in parentheses in unevaluated context should be invalid (PR #89713)

2024-05-02 Thread via cfe-commits
zwuis wrote: > @zwuis Thanks for your contribution. Will you need me to merge that for you? Yes. Thanks for your review! https://github.com/llvm/llvm-project/pull/89713 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [clang] Implement provisional wording for CWG2398 regarding packs (PR #90820)

2024-05-02 Thread Vlad Serebrennikov via cfe-commits
Endilll wrote: > Sounds like should perhaps note that we are implementing our own resolution, > until there's an update to the cwg issue that can be referred to? Our tooling is not ready for describing own own resolutions, unfortunately. Ideally if we have a

[clang] [clang-tools-extra] Reapply "[Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent

2024-05-02 Thread David Green via cfe-commits
davemgreen wrote: Hi - We've ran into a couple of places where this causes problems, one of them in running Spec as above. Is it possible to turn off this error for older codebases with a flag, turning it into a warning? It doesn't seem like a very useful error if it applies to code that is ne

[clang] [clang] solve crash due to function overloading. (PR #90255)

2024-05-02 Thread Eli Friedman via cfe-commits
@@ -0,0 +1,7 @@ +// RUN: %clang_cc1 -emit-llvm < %s efriedma-quic wrote: Can you integrate this test into some existing file that's testing something similar? Please leave the bug number in a comment: something like `//GH88917`. Please use FileCheck CHECK line

[clang] [clang] solve crash due to function overloading. (PR #90255)

2024-05-02 Thread Eli Friedman via cfe-commits
@@ -5702,13 +5702,16 @@ CodeGenModule::getLLVMLinkageVarDefinition(const VarDecl *VD) { static void replaceUsesOfNonProtoConstant(llvm::Constant *old, llvm::Function *newFn) { // Fast path. - if (old->use_empty()) return; + if (old

[clang] 1609632 - [clang][Docs] Add release note for {target}-none-{environment} triple normalization changes (#90734)

2024-05-02 Thread via cfe-commits
Author: David Spickett Date: 2024-05-02T08:44:32+01:00 New Revision: 16096325a5ff66d26b7e3424e7fac029c3dd35ea URL: https://github.com/llvm/llvm-project/commit/16096325a5ff66d26b7e3424e7fac029c3dd35ea DIFF: https://github.com/llvm/llvm-project/commit/16096325a5ff66d26b7e3424e7fac029c3dd35ea.diff

[clang] [clang][Docs] Add release note for {target}-none-{environment} triple normalization changes (PR #90734)

2024-05-02 Thread David Spickett via cfe-commits
https://github.com/DavidSpickett closed https://github.com/llvm/llvm-project/pull/90734 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Don't propagate result objects in unevaluated contexts (PR #90438)

2024-05-02 Thread Tom Weaver via cfe-commits
cHackz18 wrote: Hello and good morning from the UK! It looks as though this change caused a test failure on the following buildbot: https://lab.llvm.org/buildbot/#/builders/216/builds/38446 Are you able to take a look see? many thanks for yoru time, Tom W https://github.com/llvm/llvm-project/

[clang-tools-extra] [clang-tidy] new check readability-mark-static (PR #90830)

2024-05-02 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 created https://github.com/llvm/llvm-project/pull/90830 Add new check readability-mark-static to dectect variable and function can be marked as static. >From 7f42888a6c7ee2bdb21c8d84b36b0821d32ffcc7 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 2 May 2

[clang-tools-extra] [clang-tidy] new check readability-mark-static (PR #90830)

2024-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-tidy Author: Congcong Cai (HerrCai0907) Changes Add new check readability-mark-static to dectect variable and function can be marked as static. --- Full diff: https://github.com/llvm/llvm-project/pull/90830.diff 11 Files Affected: - (modified

[clang-tools-extra] [clang-tidy] new check readability-mark-static (PR #90830)

2024-05-02 Thread Congcong Cai via cfe-commits
https://github.com/HerrCai0907 updated https://github.com/llvm/llvm-project/pull/90830 >From ec7ddff8aedaa9d42796b5f952ff7ca77465dfd1 Mon Sep 17 00:00:00 2001 From: Congcong Cai Date: Thu, 2 May 2024 15:44:45 +0800 Subject: [PATCH] [clang-tidy] new check readability-mark-static Add new check r

[clang] cirgenmodule buildtopleveldecl husk (PR #90831)

2024-05-02 Thread Nathan Lanza via cfe-commits
https://github.com/lanza created https://github.com/llvm/llvm-project/pull/90831 None >From e57548737a72c5308e23fb442774b9bd9eca0bfa Mon Sep 17 00:00:00 2001 From: Nathan Lanza Date: Thu, 2 May 2024 07:55:36 + Subject: [PATCH] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20initia?= =?U

[clang] cirgenmodule buildtopleveldecl husk (PR #90831)

2024-05-02 Thread Nathan Lanza via cfe-commits
https://github.com/lanza converted_to_draft https://github.com/llvm/llvm-project/pull/90831 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cirgenmodule buildtopleveldecl husk (PR #90831)

2024-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Nathan Lanza (lanza) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/90831.diff 12 Files Affected: - (added) clang/include/clang/CIR/CIRGenerator.h (+28) - (added) clang/include/clang/CIRFrontendAction/CIRGenAction.h

[clang] cirgenmodule buildtopleveldecl husk (PR #90831)

2024-05-02 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff e3f42b02a4129947ca2dd820bfb63ffed83027b7 e57548737a72c5308e23fb442774b9bd9eca0bfa --

[clang] [llvm] Triple::normalize: Use none as OS for XX-none-ABI (PR #89638)

2024-05-02 Thread David Spickett via cfe-commits
DavidSpickett wrote: @wzssyqa thanks for working with us on this. Bare metal is always a wild card but I think in the end we'll all have cleaner builds because of these changes. https://github.com/llvm/llvm-project/pull/89638 ___ cfe-commits mailing l

[clang] [llvm] [LV][LAA] Vectorize math lib calls with mem write-only attribute (PR #78432)

2024-05-02 Thread Maciej Gabka via cfe-commits
@@ -0,0 +1,134 @@ +; NOTE: Assertions have been autogenerated by utils/update_test_checks.py UTC_ARGS: --filter "call.*(frexp|modf)" --version 4 mgabka wrote: sincos (which also takes linear pointers) has tests inside veclib-function-calls.ll, so I would sugges

[clang] [AArch64] Diagnose more functions when FP not enabled (PR #90832)

2024-05-02 Thread via cfe-commits
https://github.com/ostannard created https://github.com/llvm/llvm-project/pull/90832 When using a hard-float ABI for a target without FP registers, it's not possible to correctly generate code for functions with arguments which must be passed in floating-point registers. This is diagnosed in C

[clang] [AArch64] Diagnose more functions when FP not enabled (PR #90832)

2024-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-aarch64 Author: None (ostannard) Changes When using a hard-float ABI for a target without FP registers, it's not possible to correctly generate code for functions with arguments which must be passed in floating-point registers. This is diagnose

[clang] [AArch64] Diagnose more functions when FP not enabled (PR #90832)

2024-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-codegen Author: None (ostannard) Changes When using a hard-float ABI for a target without FP registers, it's not possible to correctly generate code for functions with arguments which must be passed in floating-point registers. This is diagnosed

[clang] [AArch64] Diagnose more functions when FP not enabled (PR #90832)

2024-05-02 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 16bd10a38730fed27a3bf111076b8ef7a7e7b3ee b562b354a7bb955c3c46cd79753fd3d2d72d48fe --

[clang] [AArch64] Diagnose more functions when FP not enabled (PR #90832)

2024-05-02 Thread via cfe-commits
https://github.com/ostannard updated https://github.com/llvm/llvm-project/pull/90832 >From b562b354a7bb955c3c46cd79753fd3d2d72d48fe Mon Sep 17 00:00:00 2001 From: Oliver Stannard Date: Tue, 30 Apr 2024 11:40:18 +0100 Subject: [PATCH 1/2] [AArch64] Diagnose more functions when FP not enabled Wh

[clang] [llvm] [clang backend] In AArch64's DataLayout, specify a minimum function alignment of 4. (PR #90702)

2024-05-02 Thread Florian Hahn via cfe-commits
@@ -1480,11 +1480,11 @@ AArch64leTargetInfo::AArch64leTargetInfo(const llvm::Triple &Triple, void AArch64leTargetInfo::setDataLayout() { if (getTriple().isOSBinFormatMachO()) { if(getTriple().isArch32Bit()) - resetDataLayout("e-m:o-p:32:32-i64:64-i128:128-n32:64-S12

[clang-tools-extra] [clangd] Remove potential prefix from enum value names (PR #83412)

2024-05-02 Thread Christian Kandeler via cfe-commits
https://github.com/ckandeler updated https://github.com/llvm/llvm-project/pull/83412 >From 349edc160e9c13068c42b35321814296bb713a09 Mon Sep 17 00:00:00 2001 From: Christian Kandeler Date: Thu, 29 Feb 2024 12:26:52 +0100 Subject: [PATCH] [clangd] Remove potential prefix from enum value names ..

[clang-tools-extra] [clangd] Remove potential prefix from enum value names (PR #83412)

2024-05-02 Thread Christian Kandeler via cfe-commits
ckandeler wrote: Underscore separators get removed now. https://github.com/llvm/llvm-project/pull/83412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Reland "[Win32][ELF] Make CodeView a DebugInfoFormat only for COFF format", second try (PR #88245)

2024-05-02 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang closed https://github.com/llvm/llvm-project/pull/88245 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] new check readability-mark-static (PR #90830)

2024-05-02 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL edited https://github.com/llvm/llvm-project/pull/90830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] new check readability-mark-static (PR #90830)

2024-05-02 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,65 @@ +//===--- MarkStaticCheck.cpp - clang-tidy -===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang-tools-extra] [clang-tidy] new check readability-mark-static (PR #90830)

2024-05-02 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,26 @@ +.. title:: clang-tidy - readability-mark-static + +readability-mark-static +=== + +Detects variable and function can be marked as static. + +Static functions and variables are scoped to a single file. Marking functions +and variables as static

[clang-tools-extra] [clang-tidy] new check readability-mark-static (PR #90830)

2024-05-02 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL requested changes to this pull request. 1. Wrong check name, maybe readability-unessesary-external-linkage or something, maybe it should even be an performance check [as there it will bring more benefits] (current check suggest more an "static methods"). 2. Add suppo

[clang-tools-extra] [clang-tidy] new check readability-mark-static (PR #90830)

2024-05-02 Thread Congcong Cai via cfe-commits
HerrCai0907 wrote: > Add support for unity builds (.cpp files included from single .cpp file = > isInMainFile is not sufficient) For unity build, it looks like a project level decision. Then they can ignore this check. Maybe I can provide an option to treat some extension as main file also.

[clang] f17b1fb - [Clang][CodeGen] Optimised LLVM IR for atomic increments/decrements on floats (#89362)

2024-05-02 Thread via cfe-commits
Author: Krishna Narayanan Date: 2024-05-02T10:42:34+01:00 New Revision: f17b1fb6673e9ed6a7d9180230586113bb99748c URL: https://github.com/llvm/llvm-project/commit/f17b1fb6673e9ed6a7d9180230586113bb99748c DIFF: https://github.com/llvm/llvm-project/commit/f17b1fb6673e9ed6a7d9180230586113bb99748c.d

[clang] [Clang][CodeGen] Optimised LLVM IR for atomic increments/decrements on floats (PR #89362)

2024-05-02 Thread Simon Pilgrim via cfe-commits
https://github.com/RKSimon closed https://github.com/llvm/llvm-project/pull/89362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] b6328db - [clang][CodeGen] Put constant initializer globals into constant addrspace (#90048)

2024-05-02 Thread via cfe-commits
Author: Sven van Haastregt Date: 2024-05-02T11:43:56+02:00 New Revision: b6328db80b4294cf83a3471ecdfab33003fa742d URL: https://github.com/llvm/llvm-project/commit/b6328db80b4294cf83a3471ecdfab33003fa742d DIFF: https://github.com/llvm/llvm-project/commit/b6328db80b4294cf83a3471ecdfab33003fa742d.

[clang] [OpenCL] Put constant initializer globals into constant addrspace (PR #90048)

2024-05-02 Thread Sven van Haastregt via cfe-commits
https://github.com/svenvh closed https://github.com/llvm/llvm-project/pull/90048 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang backend] In AArch64's DataLayout, specify a minimum function alignment of 4. (PR #90702)

2024-05-02 Thread Tim Northover via cfe-commits
@@ -1480,11 +1480,11 @@ AArch64leTargetInfo::AArch64leTargetInfo(const llvm::Triple &Triple, void AArch64leTargetInfo::setDataLayout() { if (getTriple().isOSBinFormatMachO()) { if(getTriple().isArch32Bit()) - resetDataLayout("e-m:o-p:32:32-i64:64-i128:128-n32:64-S12

[clang] [clang][CodeGen] Propagate pragma set fast-math flags to floating point builtins (PR #90377)

2024-05-02 Thread Karl-Johan Karlsson via cfe-commits
https://github.com/karka228 updated https://github.com/llvm/llvm-project/pull/90377 >From 80836f51573c8ba474a0b5d5890a489d5f0c7034 Mon Sep 17 00:00:00 2001 From: Karl-Johan Karlsson Date: Sat, 27 Apr 2024 22:04:11 +0200 Subject: [PATCH 1/4] Pre-commit reproducer for fast-math flags on calls Ad

[clang] [Clang][Sema] Fix malformed AST for anonymous class access in template. (PR #90842)

2024-05-02 Thread via cfe-commits
https://github.com/martinboehme created https://github.com/llvm/llvm-project/pull/90842 # Observed erroneous behavior Prior to this change, a `MemberExpr` that accesses an anonymous class might have a prvalue as its base (even though C++ mandates that the base of a `MemberExpr` must be a glvalu

[clang] [Clang][Sema] Fix malformed AST for anonymous class access in template. (PR #90842)

2024-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (martinboehme) Changes # Observed erroneous behavior Prior to this change, a `MemberExpr` that accesses an anonymous class might have a prvalue as its base (even though C++ mandates that the base of a `MemberExpr` must be a glvalue),

[clang] [llvm] [clang backend] In AArch64's DataLayout, specify a minimum function alignment of 4. (PR #90702)

2024-05-02 Thread Florian Hahn via cfe-commits
https://github.com/fhahn approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/90702 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] new check readability-mark-static (PR #90830)

2024-05-02 Thread Oliver Stöneberg via cfe-commits
firewave wrote: Isn't this already covered by `-Wmissing-prototypes`? https://github.com/llvm/llvm-project/pull/90830 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang backend] In AArch64's DataLayout, specify a minimum function alignment of 4. (PR #90702)

2024-05-02 Thread Florian Hahn via cfe-commits
https://github.com/fhahn updated https://github.com/llvm/llvm-project/pull/90702 >From 4c312af7af5d0e419269c5b2304b0f898363bb85 Mon Sep 17 00:00:00 2001 From: Doug Wyatt Date: Tue, 30 Apr 2024 21:43:16 -0700 Subject: [PATCH 1/5] In AArch64's DataLayout, specify a minimum function alignment of 4

[clang-tools-extra] [clang-tidy] new check readability-mark-static (PR #90830)

2024-05-02 Thread Oliver Stöneberg via cfe-commits
@@ -0,0 +1,26 @@ +.. title:: clang-tidy - readability-mark-static + +readability-mark-static +=== + +Detects variable and function can be marked as static. + +Static functions and variables are scoped to a single file. Marking functions +and variables as static

[clang-tools-extra] [clang-tidy] new check readability-mark-static (PR #90830)

2024-05-02 Thread Piotr Zegar via cfe-commits
PiotrZSL wrote: > Isn't this already covered by `-Wmissing-prototypes`? No, because -Wmissing-prototypes will not provide warning, when both declaration and definition is in .cpp https://github.com/llvm/llvm-project/pull/90830 ___ cfe-commits mailing

[clang-tools-extra] [clang-tidy] new check readability-mark-static (PR #90830)

2024-05-02 Thread Piotr Zegar via cfe-commits
PiotrZSL wrote: > Maybe I can provide an option to treat some extension as main file also. Clang-tidy already got those options, check just need to utilize them. https://github.com/llvm/llvm-project/pull/90830 ___ cfe-commits mailing list cfe-commits

[clang] [Clang][Sema] Fix malformed AST for anonymous class access in template. (PR #90842)

2024-05-02 Thread via cfe-commits
https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/90842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix malformed AST for anonymous class access in template. (PR #90842)

2024-05-02 Thread via cfe-commits
https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/90842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix malformed AST for anonymous class access in template. (PR #90842)

2024-05-02 Thread via cfe-commits
https://github.com/martinboehme edited https://github.com/llvm/llvm-project/pull/90842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Remove potential prefix from enum value names (PR #83412)

2024-05-02 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/83412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix malformed AST for anonymous class access in template. (PR #90842)

2024-05-02 Thread via cfe-commits
martinboehme wrote: @AaronBallman You're probably not the right person to review this yourself, but I'm told you probably have an idea of who might be an appropriate reviewer? https://github.com/llvm/llvm-project/pull/90842 ___ cfe-commits mailing lis

[clang-tools-extra] [clang-tidy] new check readability-mark-static (PR #90830)

2024-05-02 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,26 @@ +.. title:: clang-tidy - readability-mark-static + +readability-mark-static +=== + +Detects variable and function can be marked as static. + +Static functions and variables are scoped to a single file. Marking functions +and variables as static

[clang-tools-extra] [clangd] Remove potential prefix from enum value names (PR #83412)

2024-05-02 Thread Christian Kandeler via cfe-commits
https://github.com/ckandeler closed https://github.com/llvm/llvm-project/pull/83412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Remove potential prefix from enum value names (PR #83412)

2024-05-02 Thread Christian Kandeler via cfe-commits
https://github.com/ckandeler reopened https://github.com/llvm/llvm-project/pull/83412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] new check readability-mark-static (PR #90830)

2024-05-02 Thread Oliver Stöneberg via cfe-commits
@@ -0,0 +1,26 @@ +.. title:: clang-tidy - readability-mark-static + +readability-mark-static +=== + +Detects variable and function can be marked as static. + +Static functions and variables are scoped to a single file. Marking functions +and variables as static

[clang] [clang-tools-extra] [llvm] Add ``ignoringParenImpCasts`` in arguments of hasArgument (PR #89553)

2024-05-02 Thread via cfe-commits
komalverma04 wrote: > Thanks for looking into this. Because this is touching a lot of checks, there > was bound to be some conversation about which matchers need the > `ignoringParenImpCasts` and which don't. I think we should check that now > instead of later, so don't be alarmed about the nu

[clang-tools-extra] [clang-tidy] new check readability-mark-static (PR #90830)

2024-05-02 Thread Piotr Zegar via cfe-commits
@@ -0,0 +1,26 @@ +.. title:: clang-tidy - readability-mark-static + +readability-mark-static +=== + +Detects variable and function can be marked as static. + +Static functions and variables are scoped to a single file. Marking functions +and variables as static

[clang-tools-extra] [clang-tidy] fix false-positives for templates in `bugprone-return-const-ref-from-parameter` (PR #90273)

2024-05-02 Thread Julian Schmidt via cfe-commits
https://github.com/5chmidti updated https://github.com/llvm/llvm-project/pull/90273 >From 9b5bf4e1d53b3a55f9290199aeccb02c20a1e2cc Mon Sep 17 00:00:00 2001 From: Julian Schmidt Date: Fri, 26 Apr 2024 22:49:38 +0200 Subject: [PATCH 1/2] [clang-tidy] fix false-positives for templates in `bugpron

[clang] [Clang][CodeGen] Optimised LLVM IR for atomic increments/decrements on floats (PR #89362)

2024-05-02 Thread Krishna Narayanan via cfe-commits
Krishna-13-cyber wrote: > LGTM Thanks! https://github.com/llvm/llvm-project/pull/89362 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Fix in codegen for __builtin_popcountg/ctzg/clzg (PR #90845)

2024-05-02 Thread Björn Pettersson via cfe-commits
https://github.com/bjope created https://github.com/llvm/llvm-project/pull/90845 Make sure that the result from the popcnt/ctlz/cttz intrinsics is unsigned casted to int, rather than casted as a signed value, when expanding the __builtin_popcountg/__builtin_ctzg/__builtin_clzg builtins. An exa

[clang] [clang][CodeGen] Fix in codegen for __builtin_popcountg/ctzg/clzg (PR #90845)

2024-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Björn Pettersson (bjope) Changes Make sure that the result from the popcnt/ctlz/cttz intrinsics is unsigned casted to int, rather than casted as a signed value, when expanding the __builtin_popcountg/__builtin_ctzg/__builtin_clzg builtins

[clang] [clang] Implement __builtin_popcountg (PR #82359)

2024-05-02 Thread Björn Pettersson via cfe-commits
@@ -3216,7 +3216,8 @@ RValue CodeGenFunction::EmitBuiltinExpr(const GlobalDecl GD, unsigned BuiltinID, case Builtin::BI__popcnt64: case Builtin::BI__builtin_popcount: case Builtin::BI__builtin_popcountl: - case Builtin::BI__builtin_popcountll: { + case Builtin::BI__bui

[clang] [clang][CodeGen] Fix in codegen for __builtin_popcountg/ctzg/clzg (PR #90845)

2024-05-02 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff d9fc5babb96ca9c75f36f9cf3d3f2a55ddc0ab4d bab0da08c41ed13935ad607e633939b6870d4ffb --

[clang] [clang-tools-extra] Reapply "[Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent

2024-05-02 Thread Krystian Stasiowski via cfe-commits
sdkrystian wrote: @davemgreen you can try using `-fdelayed-template-parsing` to fix the error. A compatibility flag could be added for older code bases -- but I'd like guidance from @erichkeane, @cor3ntin, and/or @AaronBallman on that. https://github.com/llvm/llvm-project/pull/90152 __

[clang] 2252c5c - Revert "[clang][dataflow] Don't propagate result objects in unevaluated contexts (#90438)"

2024-05-02 Thread via cfe-commits
Author: Weaver Date: 2024-05-02T11:51:45+01:00 New Revision: 2252c5c42b95dd12dda0c7fb1b2811f943b21949 URL: https://github.com/llvm/llvm-project/commit/2252c5c42b95dd12dda0c7fb1b2811f943b21949 DIFF: https://github.com/llvm/llvm-project/commit/2252c5c42b95dd12dda0c7fb1b2811f943b21949.diff LOG: R

[clang] [clang][dataflow] Don't propagate result objects in unevaluated contexts (PR #90438)

2024-05-02 Thread Tom Weaver via cfe-commits
TomWeaver18 wrote: Reverted in 2252c5c42b95dd12dda0c7fb1b2811f943b21949 https://github.com/llvm/llvm-project/pull/90438 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [lldb] [llvm] [AArch64][TargetParser] autogen ArchExtKind enum - renaming (PR #90320)

2024-05-02 Thread Tomas Matheson via cfe-commits
https://github.com/tmatheson-arm edited https://github.com/llvm/llvm-project/pull/90320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Fix sanitize problem. (PR #90800)

2024-05-02 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: A test? https://github.com/llvm/llvm-project/pull/90800 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement SubArray Parsing/Sema (PR #90796)

2024-05-02 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev edited https://github.com/llvm/llvm-project/pull/90796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement SubArray Parsing/Sema (PR #90796)

2024-05-02 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev edited https://github.com/llvm/llvm-project/pull/90796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenACC] Implement SubArray Parsing/Sema (PR #90796)

2024-05-02 Thread Alexey Bataev via cfe-commits
@@ -503,12 +512,211 @@ ExprResult SemaOpenACC::ActOnArraySectionExpr(Expr *Base, SourceLocation LBLoc, SourceLocation RBLoc) { ASTContext &Context = getASTContext(); - // TODO OpenACC: We likely have to reproduce a lot of the s

[clang] [OpenACC] Implement SubArray Parsing/Sema (PR #90796)

2024-05-02 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG with a nit https://github.com/llvm/llvm-project/pull/90796 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] f2daa32 - [clangd] Remove potential prefix from enum value names (#83412)

2024-05-02 Thread via cfe-commits
Author: Christian Kandeler Date: 2024-05-02T13:18:59+02:00 New Revision: f2daa32fcaa061daa04546c343198d876e635def URL: https://github.com/llvm/llvm-project/commit/f2daa32fcaa061daa04546c343198d876e635def DIFF: https://github.com/llvm/llvm-project/commit/f2daa32fcaa061daa04546c343198d876e635def.

[clang-tools-extra] [clangd] Remove potential prefix from enum value names (PR #83412)

2024-05-02 Thread Christian Kandeler via cfe-commits
https://github.com/ckandeler closed https://github.com/llvm/llvm-project/pull/83412 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Allow "move function body out-of-line" in non-header files (PR #69704)

2024-05-02 Thread Christian Kandeler via cfe-commits
ckandeler wrote: ping https://github.com/llvm/llvm-project/pull/69704 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5d9889a - [clang][Interp] Fix zero-initializing records with non-trivial ctors

2024-05-02 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-05-02T13:20:04+02:00 New Revision: 5d9889a6c6c97c92380c8eee48eaa35067f63766 URL: https://github.com/llvm/llvm-project/commit/5d9889a6c6c97c92380c8eee48eaa35067f63766 DIFF: https://github.com/llvm/llvm-project/commit/5d9889a6c6c97c92380c8eee48eaa35067f63766.diff LO

[clang] [clang-tools-extra] [clangd] Collect comments from function definitions into the index (PR #67802)

2024-05-02 Thread Christian Kandeler via cfe-commits
ckandeler wrote: ping https://github.com/llvm/llvm-project/pull/67802 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][CodeGen] Propagate pragma set fast-math flags to floating point builtins (PR #90377)

2024-05-02 Thread Karl-Johan Karlsson via cfe-commits
@@ -0,0 +1,28 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --version 4 +// RUN: %clang_cc1 -triple x86_64-linux-gnu -O3 -emit-llvm -o - %s \ +// RUN: | FileCheck -check-prefix=CHECK %s + +// Reproducer for issue #87758 +// The testca

[clang] e5fb656 - [clang][Interp] Handle RecoveryExprs

2024-05-02 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-05-02T13:43:06+02:00 New Revision: e5fb6564358f10c01d7533f2f805eedd7d663417 URL: https://github.com/llvm/llvm-project/commit/e5fb6564358f10c01d7533f2f805eedd7d663417 DIFF: https://github.com/llvm/llvm-project/commit/e5fb6564358f10c01d7533f2f805eedd7d663417.diff LO

[clang] 3d8a44d - [clang][Interp][NFC] Refactor if condition

2024-05-02 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-05-02T13:43:06+02:00 New Revision: 3d8a44d542b15ac9bc21f9fd3494f1649fca1aa9 URL: https://github.com/llvm/llvm-project/commit/3d8a44d542b15ac9bc21f9fd3494f1649fca1aa9 DIFF: https://github.com/llvm/llvm-project/commit/3d8a44d542b15ac9bc21f9fd3494f1649fca1aa9.diff LO

[clang] de04e6c - [clang][Interp][NFC] Save source location of evaluating expression

2024-05-02 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-05-02T13:43:07+02:00 New Revision: de04e6cd90b891215f1dfc83ec886d037a7c2ed0 URL: https://github.com/llvm/llvm-project/commit/de04e6cd90b891215f1dfc83ec886d037a7c2ed0 DIFF: https://github.com/llvm/llvm-project/commit/de04e6cd90b891215f1dfc83ec886d037a7c2ed0.diff LO

[clang] [llvm] [AMDGPU] Add OpenCL-specific fence address space masks (PR #78572)

2024-05-02 Thread Pierre van Houtryve via cfe-commits
Pierre-vh wrote: I changed it so it's one or more string arguments: ``` __builtin_amdgcn_masked_fence(__ATOMIC_SEQ_CST, "workgroup", "local", "global") ``` I'm now wondering if adding a new builtin is needed at all, or if it should just be part of the original builtin? It's an additive change.

[clang] 1c7673b - [clang][Interp] Fix locals created in ExprWithCleanups

2024-05-02 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-05-02T13:51:50+02:00 New Revision: 1c7673b91d4d3bab4e296f5c67751d3879fb21a2 URL: https://github.com/llvm/llvm-project/commit/1c7673b91d4d3bab4e296f5c67751d3879fb21a2 DIFF: https://github.com/llvm/llvm-project/commit/1c7673b91d4d3bab4e296f5c67751d3879fb21a2.diff LO

[clang] [Clang][Sema] Improve support for explicit specializations of constrained member functions & member function templates (PR #88963)

2024-05-02 Thread Qizhi Hu via cfe-commits
@@ -275,6 +275,13 @@ Response HandleFunction(Sema &SemaRef, const FunctionDecl *Function, TemplateArgs->asArray(), /*Final=*/false); +if (RelativeToPrimary && +(Function->getTemplateSpeciali

[clang] ebcb04a - Revert "[clang][Interp][NFC] Save source location of evaluating expression"

2024-05-02 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-05-02T14:01:09+02:00 New Revision: ebcb04ae8825b15fd6aa249a8da0617b877b4705 URL: https://github.com/llvm/llvm-project/commit/ebcb04ae8825b15fd6aa249a8da0617b877b4705 DIFF: https://github.com/llvm/llvm-project/commit/ebcb04ae8825b15fd6aa249a8da0617b877b4705.diff LO

[clang] 427c5bf - Revert "[clang][Interp] Fix locals created in ExprWithCleanups"

2024-05-02 Thread Timm Bäder via cfe-commits
Author: Timm Bäder Date: 2024-05-02T14:03:48+02:00 New Revision: 427c5bfd39ebb9d008b621370579444fbf2a60d7 URL: https://github.com/llvm/llvm-project/commit/427c5bfd39ebb9d008b621370579444fbf2a60d7 DIFF: https://github.com/llvm/llvm-project/commit/427c5bfd39ebb9d008b621370579444fbf2a60d7.diff LO

[clang] [Clang][Sema] fix a bug on constraint check with template friend function (PR #90646)

2024-05-02 Thread Qizhi Hu via cfe-commits
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/90646 >From 50aa5b64f6d2cf98706bfb4792f274bd071e3b9c Mon Sep 17 00:00:00 2001 From: Qizhi Hu <836744...@qq.com> Date: Wed, 1 May 2024 02:25:04 +0800 Subject: [PATCH 1/2] [Clang][Sema] fix a bug on constraint check with t

[clang] [Clang][Sema] Improve support for explicit specializations of constrained member functions & member function templates (PR #88963)

2024-05-02 Thread Krystian Stasiowski via cfe-commits
@@ -275,6 +275,13 @@ Response HandleFunction(Sema &SemaRef, const FunctionDecl *Function, TemplateArgs->asArray(), /*Final=*/false); +if (RelativeToPrimary && +(Function->getTemplateSpeciali

[clang] [Clang][Sema] Improve support for explicit specializations of constrained member functions & member function templates (PR #88963)

2024-05-02 Thread Krystian Stasiowski via cfe-commits
https://github.com/sdkrystian edited https://github.com/llvm/llvm-project/pull/88963 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] fix a bug on constraint check with template friend function (PR #90646)

2024-05-02 Thread Qizhi Hu via cfe-commits
jcsxky wrote: > I agree with @sdkrystian, even though the test crashes for maybe yet another > reason, it demonstrates you can friend a function from a different template > context, so comparing the depths from different branches is not helpful. @mizvekov I missed the case which friend functio

[clang] [lldb] [llvm] [AArch64][TargetParser] autogen ArchExtKind enum - renaming (PR #90320)

2024-05-02 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray approved this pull request. LGTM (presumably these were mechanically renamed, given the diff size). https://github.com/llvm/llvm-project/pull/90320 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.

[clang] [Clang] Added lifetime markers for indereacly passed Aggregate types (PR #90849)

2024-05-02 Thread via cfe-commits
https://github.com/Lukacma created https://github.com/llvm/llvm-project/pull/90849 Adding lifetime markers to pointers to temporary stack allocated objects, allows compiler to make more efficient use of the stack. Currently these markers are not added to indirectly called aggregate types so th

[clang] [Clang] Added lifetime markers for indereacly passed Aggregate types (PR #90849)

2024-05-02 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Lukacma) Changes Adding lifetime markers to pointers to temporary stack allocated objects, allows compiler to make more efficient use of the stack. Currently these markers are not added to indirectly called aggregate types so this p

[clang] [Clang] Added lifetime markers for indereacly passed Aggregate types (PR #90849)

2024-05-02 Thread via cfe-commits
Lukacma wrote: As this pull request is using _BitInt datatype as motivating example, this PR is dependent on #90741 https://github.com/llvm/llvm-project/pull/90849 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/

  1   2   3   4   >