steakhal wrote:
In the LLVM project we expect functional changes to include tests demonstrating
the motivational example, and to also serve as a regression test for the future.
https://github.com/llvm/llvm-project/pull/90733
___
cfe-commits mailing li
https://github.com/peterwaller-arm approved this pull request.
https://github.com/llvm/llvm-project/pull/90734
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
perry-ca wrote:
@MaskRay Got it.
The problem with that solution is that if you use --target you won't get the
correct arch. This would be a problem for any cross compilation. For example,
say you cross compile from zLinux (which wouldn't have the config file), the
arch would be arch8. A
@@ -9767,7 +9767,9 @@ bool Sema::ShouldDeleteSpecialMember(CXXMethodDecl *MD,
return false;
CXXRecordDecl *RD = MD->getParent();
assert(!RD->isDependentType() && "do deletion after instantiation");
- if (!LangOpts.CPlusPlus || (!LangOpts.CPlusPlus11 && !RD->isLambda())
https://github.com/MitalAshok updated
https://github.com/llvm/llvm-project/pull/90725
>From 0793795ba7d5d5974b1403cd6ead0221fc20c5bb Mon Sep 17 00:00:00 2001
From: Mital Ashok
Date: Wed, 1 May 2024 12:45:54 +0100
Subject: [PATCH 1/2] [Clang] Ensure "=default"ed function can be deleted when
use
@@ -9767,7 +9767,9 @@ bool Sema::ShouldDeleteSpecialMember(CXXMethodDecl *MD,
return false;
CXXRecordDecl *RD = MD->getParent();
assert(!RD->isDependentType() && "do deletion after instantiation");
- if (!LangOpts.CPlusPlus || (!LangOpts.CPlusPlus11 && !RD->isLambda())
https://github.com/jdoerfert edited
https://github.com/llvm/llvm-project/pull/87009
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -34,38 +33,10 @@
#include
#include
-struct PluginManager;
-
-/// Plugin adaptors should be created via `PluginAdaptorTy::create` which will
-/// invoke the constructor and call `PluginAdaptorTy::init`. Eventual errors
are
-/// reported back to the caller, otherwise a val
@@ -3476,3 +3472,9 @@ void *AMDGPUDeviceTy::allocate(size_t Size, void *,
TargetAllocTy Kind) {
} // namespace target
} // namespace omp
} // namespace llvm
+
+extern "C" {
+llvm::omp::target::plugin::GenericPluginTy *createPlugin_amdgpu() {
jdoerfert wrote:
https://github.com/jdoerfert approved this pull request.
I left minor comments.
This LGTM, assuming it passes our tests.
https://github.com/llvm/llvm-project/pull/87009
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi
@@ -92,10 +65,10 @@ struct PluginManager {
std::make_unique(TgtBinDesc, TgtDeviceImage));
}
- /// Initialize as many devices as possible for this plugin adaptor. Devices
- /// that fail to initialize are ignored. Returns the offset the devices were
- /// registere
@@ -92,10 +65,10 @@ struct PluginManager {
std::make_unique(TgtBinDesc, TgtDeviceImage));
}
- /// Initialize as many devices as possible for this plugin adaptor. Devices
- /// that fail to initialize are ignored. Returns the offset the devices were
- /// registere
@@ -34,38 +33,10 @@
#include
#include
-struct PluginManager;
-
-/// Plugin adaptors should be created via `PluginAdaptorTy::create` which will
-/// invoke the constructor and call `PluginAdaptorTy::init`. Eventual errors
are
-/// reported back to the caller, otherwise a val
@@ -3476,3 +3472,9 @@ void *AMDGPUDeviceTy::allocate(size_t Size, void *,
TargetAllocTy Kind) {
} // namespace target
} // namespace omp
} // namespace llvm
+
+extern "C" {
+llvm::omp::target::plugin::GenericPluginTy *createPlugin_amdgpu() {
jhuber6 wrote:
I
mstorsjo wrote:
One reason why I’m not entirely thrilled (not firmly against, but not thrilled
- but I’m not sure if there are much better options either) with this
direction, is that it becomes messy when cross compiling.
LLVM_ENABLE_PER_TARGET_RUNTIME_DIR is automatically set based on the ho
JOE1994 wrote:
Buildkite passed on Linux x64 but failed on Windows x64 .
Test log doesn't show any test failures except for `XFAIL` runs, so I'm not
sure what's causing the failure.
Will rebase onto latest `main` to try the build again.
https://github.com/llvm/llvm-project/pull/90625
___
https://github.com/farzonl approved this pull request.
https://github.com/llvm/llvm-project/pull/90694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/JOE1994 updated
https://github.com/llvm/llvm-project/pull/90625
>From 0a1598d0e00cbbfd0320ea72491500957ddb6b52 Mon Sep 17 00:00:00 2001
From: Youngsuk Kim
Date: Tue, 30 Apr 2024 11:18:15 -0500
Subject: [PATCH] [clang][Sema] Re-use existing BinaryOperator if possible
First ro
@@ -406,6 +406,16 @@ void TargetInfo::adjust(DiagnosticsEngine &Diags,
LangOptions &Opts) {
LongDoubleAlign = 64;
}
+ // HLSL explicitly defines the sizes and formats of some data types, and we
+ // need to conform to those regardless of what architecture you are
tar
cor3ntin wrote:
It would be better to do, in all cases
```cpp
Diag(PrefixEnd, diag::err_invalid_char_raw_delim) <<
escapeCStyle(*PrefixEnd);
```
(and remove the `err_invalid_newline_raw_delim` diagnostic altogether)
https://github.com/llvm/llvm-project/pull/81670
__
https://github.com/zahiraam updated
https://github.com/llvm/llvm-project/pull/88978
>From 3acc848f4fcc68445dfc849f9c6f8d384d3692af Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Tue, 16 Apr 2024 13:09:58 -0700
Subject: [PATCH 1/3] Adding C23 constexpr math functions fmin and frexp.
-
https://github.com/dougsonos updated
https://github.com/llvm/llvm-project/pull/90702
>From 4c312af7af5d0e419269c5b2304b0f898363bb85 Mon Sep 17 00:00:00 2001
From: Doug Wyatt
Date: Tue, 30 Apr 2024 21:43:16 -0700
Subject: [PATCH 1/4] In AArch64's DataLayout, specify a minimum function
alignment
https://github.com/dougsonos edited
https://github.com/llvm/llvm-project/pull/90702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,57 @@
+// RUN: %clang_cc1 -DWIN -verify -std=c++23 -fsyntax-only %s
+// RUN: %clang_cc1 -verify -std=c++23 -fsyntax-only %s
+
+// expected-no-diagnostics
+
+
+#ifdef WIN
+#define INFINITY ((float)(1e+300 * 1e+300))
+#define NAN (-(float)(INFINITY * 0.0F))
+#else
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff a3efc53f168b1451803a40075201c3490d6e3928
625028aed5ad85922f082f5192abd5ceedb0b68d --
https://github.com/erichkeane commented:
This seems reasonable to me. We need a release note however.
https://github.com/llvm/llvm-project/pull/90625
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listin
wzssyqa wrote:
LGTM.
https://github.com/llvm/llvm-project/pull/89638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Lukacma created
https://github.com/llvm/llvm-project/pull/90741
This patch removes incorrect `byval` attribute from pointer argument passed
with >128 bit long _BitInt types.
>From dfb8a9de874f233c9d3964569f3d5201fd717c16 Mon Sep 17 00:00:00 2001
From: Marian Lukac
Date: Tu
wzssyqa wrote:
LGTM.
https://github.com/llvm/llvm-project/pull/90734
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-backend-aarch64
Author: None (Lukacma)
Changes
This patch removes incorrect `byval` attribute from pointer argument passed
with >128 bit long _BitInt types.
---
Full diff: https://github.com/llvm/llvm-project/pull/90741.diff
7 Files Affected:
- (mo
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: None (Lukacma)
Changes
This patch removes incorrect `byval` attribute from pointer argument passed
with >128 bit long _BitInt types.
---
Full diff: https://github.com/llvm/llvm-project/pull/90741.diff
7 Files Affected:
- (modi
https://github.com/MitalAshok updated
https://github.com/llvm/llvm-project/pull/90725
>From 0793795ba7d5d5974b1403cd6ead0221fc20c5bb Mon Sep 17 00:00:00 2001
From: Mital Ashok
Date: Wed, 1 May 2024 12:45:54 +0100
Subject: [PATCH 1/3] [Clang] Ensure "=default"ed function can be deleted when
use
Lukacma wrote:
This PR is dependent on #90602 to be merged.
https://github.com/llvm/llvm-project/pull/90741
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Congcong Cai
Date: 2024-05-02T00:11:32+08:00
New Revision: 6e31714d249f857f15262518327b0f0c9509db72
URL:
https://github.com/llvm/llvm-project/commit/6e31714d249f857f15262518327b0f0c9509db72
DIFF:
https://github.com/llvm/llvm-project/commit/6e31714d249f857f15262518327b0f0c9509db72.diff
https://github.com/HerrCai0907 closed
https://github.com/llvm/llvm-project/pull/90581
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
pogo59 wrote:
Worth noting that this only affects the presumed layout if the driver can't
find either layout. In most installations, it will detect which one you have
installed, and use it correctly. It's when the driver can't find the libs, and
has to guess, that we run into difficulty.
I st
https://github.com/benlangmuir approved this pull request.
https://github.com/llvm/llvm-project/pull/89992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/python3kgae updated
https://github.com/llvm/llvm-project/pull/89836
>From 4d8c72688656fe3b2ce8817087d8cf7352b5876b Mon Sep 17 00:00:00 2001
From: Xiang Li
Date: Tue, 23 Apr 2024 17:49:02 -0400
Subject: [PATCH 1/4] [HLSL] Support packoffset attribute in AST
Add HLSLPackOffset
MitalAshok wrote:
This is [CWG2084](https://wg21.link/CWG2084). Could you also add some tests to
CXX/drs/ so that www/cxx_dr_status.html can be updated?
https://github.com/llvm/llvm-project/pull/82407
___
cfe-commits mailing list
cfe-commits@lists.llv
@@ -0,0 +1,16 @@
+// RUN: %clang_cc1 -triple dxil-unknown-shadermodel6.3-library -S
-finclude-default-header -ast-dump -x hlsl %s | FileCheck %s
+
+
+// CHECK: HLSLBufferDecl {{.*}} cbuffer A
+cbuffer A
+{
+// CHECK-NEXT: VarDecl {{.*}} C1 'float4'
python3k
@@ -0,0 +1,55 @@
+// RUN: %clang_cc1 -finclude-default-header -triple
dxil-pc-shadermodel6.3-library -verify %s
+
+// expected-error@+1{{cannot mix packoffset elements with nonpackoffset
elements in a cbuffer}}
+cbuffer Mix
+{
+float4 M1 : packoffset(c0);
+float M2;
+
@@ -183,6 +183,86 @@ void Parser::ParseHLSLAnnotations(ParsedAttributes &Attrs,
return;
}
} break;
+ case ParsedAttr::AT_HLSLPackOffset: {
+// Parse 'packoffset( c[Subcomponent][.component] )'.
+// Check '('.
+if (ExpectAndConsume(tok::l_paren, diag::er
smanna12 wrote:
@sam-mccall, could you please review/comment on the fix? Thank you
https://github.com/llvm/llvm-project/pull/90490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,16 @@
+// RUN: %clang_cc1 -triple dxil-unknown-shadermodel6.3-library -S
-finclude-default-header -ast-dump -x hlsl %s | FileCheck %s
+
+
+// CHECK: HLSLBufferDecl {{.*}} cbuffer A
+cbuffer A
+{
+// CHECK-NEXT: VarDecl {{.*}} C1 'float4'
+// CHECK-NEXT: HLSLP
@@ -7398,6 +7398,26 @@ The full documentation is available here:
https://docs.microsoft.com/en-us/windo
}];
}
+def HLSLPackOffsetDocs : Documentation {
+ let Category = DocCatFunction;
+ let Content = [{
+The packoffset attribute is used to change the layout of a cbuffer.
@@ -0,0 +1,77 @@
+// This tests that the coroutine elide optimization could happen succesfully
with ThinLTO.
+// This test is adapted from coro-elide.cpp and splits functions into two
files.
+//
+// RUN: split-file %s %t
+// RUN: %clang --target=x86_64-linux -std=c++20 -O2 -flto
@@ -1612,15 +1612,7 @@ const llvm::fltSemantics
&ASTContext::getFloatTypeSemantics(QualType T) const {
case BuiltinType::Float16:
return Target->getHalfFormat();
case BuiltinType::Half:
-// For HLSL, when the native half type is disabled, half will be treat as
-
Author: Jan Svoboda
Date: 2024-05-01T09:38:16-07:00
New Revision: 477c705cb0d7cc857fad8184faac523f8ef72c84
URL:
https://github.com/llvm/llvm-project/commit/477c705cb0d7cc857fad8184faac523f8ef72c84
DIFF:
https://github.com/llvm/llvm-project/commit/477c705cb0d7cc857fad8184faac523f8ef72c84.diff
L
https://github.com/jansvoboda11 closed
https://github.com/llvm/llvm-project/pull/89992
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/coopp approved this pull request.
Just a small nit from me about switch( ) statement formatting in existing code.
Not the new code. Looks good to me.
https://github.com/llvm/llvm-project/pull/90694
___
cfe-commits mailing list
cfe
@@ -1612,15 +1612,7 @@ const llvm::fltSemantics
&ASTContext::getFloatTypeSemantics(QualType T) const {
case BuiltinType::Float16:
return Target->getHalfFormat();
case BuiltinType::Half:
-// For HLSL, when the native half type is disabled, half will be treat as
-
https://github.com/python3kgae updated
https://github.com/llvm/llvm-project/pull/89836
>From 4d8c72688656fe3b2ce8817087d8cf7352b5876b Mon Sep 17 00:00:00 2001
From: Xiang Li
Date: Tue, 23 Apr 2024 17:49:02 -0400
Subject: [PATCH 1/5] [HLSL] Support packoffset attribute in AST
Add HLSLPackOffset
@@ -7314,6 +7314,41 @@ static void handleHLSLSV_DispatchThreadIDAttr(Sema &S,
Decl *D,
D->addAttr(::new (S.Context) HLSLSV_DispatchThreadIDAttr(S.Context, AL));
}
+static void handleHLSLPackOffsetAttr(Sema &S, Decl *D, const ParsedAttr &AL) {
+ if (!isa(D) || !isa(D->getDe
@@ -406,6 +406,16 @@ void TargetInfo::adjust(DiagnosticsEngine &Diags,
LangOptions &Opts) {
LongDoubleAlign = 64;
}
+ // HLSL explicitly defines the sizes and formats of some data types, and we
+ // need to conform to those regardless of what architecture you are
tar
https://github.com/llvm-beanz edited
https://github.com/llvm/llvm-project/pull/90694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvm-beanz edited
https://github.com/llvm/llvm-project/pull/90694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/MaskRay approved this pull request.
Thx. This looks great!
https://github.com/llvm/llvm-project/pull/90734
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay wrote:
#90734 provided a release note.
The `armv7m-none-eabi` example can probably be copied as an example to improve
the commit message/description.
https://github.com/llvm/llvm-project/pull/89638
___
cfe-commits mailing list
cfe-commits@li
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/89638
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Tomas Matheson
Date: 2024-05-01T18:01:14+01:00
New Revision: 6c369cf937b7d9acb98a1fc46b1340cef7703e12
URL:
https://github.com/llvm/llvm-project/commit/6c369cf937b7d9acb98a1fc46b1340cef7703e12
DIFF:
https://github.com/llvm/llvm-project/commit/6c369cf937b7d9acb98a1fc46b1340cef7703e12.diff
https://github.com/llvm-beanz updated
https://github.com/llvm/llvm-project/pull/90694
>From 2464bcb75b047c49076f0718470f27a561252a62 Mon Sep 17 00:00:00 2001
From: Chris Bieneman
Date: Tue, 30 Apr 2024 20:49:35 -0500
Subject: [PATCH 1/2] [NFC][HLSL] Cleanup TargetInfo handling
We had some odd
https://github.com/asb approved this pull request.
LGTM.
https://github.com/llvm/llvm-project/pull/90700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dougsonos wrote:
Linux x86_64 has one test failure: RISCV/unnamed-sym-no-entry.c . AFAICT it
looks unrelated.
https://github.com/llvm/llvm-project/pull/90702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailma
lamb-j wrote:
I've been working on testing this patch with an array of OpenCL benchmarks over
the past month. We did some high-level regression testing with the following
benchmarks:
BlackMagic
Linpack_Dgemm
babelstream-Double
babelstream-Float
chimex
clfft
clmem
clpeak-Double-precision comput
rniwa wrote:
> As per the guidelines, trivial inline functions shouldn't be changed to adopt
> smart pointers.
The triviality of a function is checked by `TrivialFunctionAnalysis`. We
shouldn't assume every inline function as trivial. For example, an inline
function could call a non-inline fu
https://github.com/rniwa requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/90733
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -178,6 +178,11 @@ class UncountedLocalVarsChecker
if (shouldSkipVarDecl(V))
return;
+if (auto *FD = dyn_cast(V->getDeclContext())) {
+ if (FD->isInlined())
rniwa wrote:
I don't think we should do this.
https://github.com/llvm/llvm-proje
https://github.com/rniwa edited https://github.com/llvm/llvm-project/pull/90733
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sudonatalie approved this pull request.
LGTM, thanks for the work on this!
https://github.com/llvm/llvm-project/pull/90278
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
Author: Craig Topper
Date: 2024-05-01T10:39:24-07:00
New Revision: 09f4b06dde65adcd077bd1d10f1165083c1fe410
URL:
https://github.com/llvm/llvm-project/commit/09f4b06dde65adcd077bd1d10f1165083c1fe410
DIFF:
https://github.com/llvm/llvm-project/commit/09f4b06dde65adcd077bd1d10f1165083c1fe410.diff
https://github.com/topperc closed
https://github.com/llvm/llvm-project/pull/90700
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
mizvekov wrote:
I agree with @sdkrystian, even though the test crashes for maybe yet another
reason, it demonstrates you can friend a function from a different template
context, so comparing the depths from different branches is not helpful.
https://github.com/llvm/llvm-project/pull/90646
@@ -9442,9 +9442,21 @@ bool
SpecialMemberDeletionInfo::shouldDeleteForSubobjectCall(
int DiagKind = -1;
- if (SMOR.getKind() == Sema::SpecialMemberOverloadResult::NoMemberOrDeleted)
-DiagKind = !Decl ? 0 : 1;
- else if (SMOR.getKind() == Sema::SpecialMemberOverloadRe
rniwa wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/90414
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/90414
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Ryosuke Niwa
Date: 2024-05-01T11:27:45-07:00
New Revision: 1ca600586a61cee41e117a188d880417de3e1c00
URL:
https://github.com/llvm/llvm-project/commit/1ca600586a61cee41e117a188d880417de3e1c00
DIFF:
https://github.com/llvm/llvm-project/commit/1ca600586a61cee41e117a188d880417de3e1c00.diff
@@ -4372,6 +4372,13 @@ def HLSLResourceBinding: InheritableAttr {
let Documentation = [HLSLResourceBindingDocs];
}
+def HLSLPackOffset: HLSLAnnotationAttr {
+ let Spellings = [HLSLAnnotation<"packoffset">];
+ let LangOpts = [HLSL];
+ let Args = [IntArgument<"Offset">];
--
@@ -4372,6 +4372,13 @@ def HLSLResourceBinding: InheritableAttr {
let Documentation = [HLSLResourceBindingDocs];
}
+def HLSLPackOffset: HLSLAnnotationAttr {
+ let Spellings = [HLSLAnnotation<"packoffset">];
+ let LangOpts = [HLSL];
+ let Args = [IntArgument<"Offset">];
--
https://github.com/python3kgae edited
https://github.com/llvm/llvm-project/pull/89836
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,229 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -fnative-half-type
-finclude-default-header -Wconversion -verify -o - %s
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -fnative-half-type
-finclude-default-header -ast-dump %s | FileCheck %
https://github.com/DavidTruby created
https://github.com/llvm/llvm-project/pull/90758
Currently the paths to compiler-rt and the Flang runtimes from the LLVM
build/install directory are preferred over any user-provided library paths.
This means a user can't override compiler-rt or the Flang ru
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/90760
[[temp.deduct.general] p6](eel.is/c++draft/temp.deduct.general#6) states:
> At certain points in the template argument deduction process it is necessary
> to take a function type that makes use of template par
@@ -4372,6 +4372,13 @@ def HLSLResourceBinding: InheritableAttr {
let Documentation = [HLSLResourceBindingDocs];
}
+def HLSLPackOffset: HLSLAnnotationAttr {
+ let Spellings = [HLSLAnnotation<"packoffset">];
+ let LangOpts = [HLSL];
+ let Args = [IntArgument<"Offset">];
--
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Krystian Stasiowski (sdkrystian)
Changes
[[temp.deduct.general] p6](eel.is/c++draft/temp.deduct.general#6)
states:
> At certain points in the template argument deduction process it is
necessary to take a function type that makes use of te
https://github.com/coopp approved this pull request.
Looks good. Took me a while to go through all of the tests. Looks like
everything is covered!
https://github.com/llvm/llvm-project/pull/90222
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
Author: Igor Kudrin
Date: 2024-05-02T01:55:18+07:00
New Revision: f0fbccb15384393a2ede3328517c1050e9f468ae
URL:
https://github.com/llvm/llvm-project/commit/f0fbccb15384393a2ede3328517c1050e9f468ae
DIFF:
https://github.com/llvm/llvm-project/commit/f0fbccb15384393a2ede3328517c1050e9f468ae.diff
L
https://github.com/igorkudrin closed
https://github.com/llvm/llvm-project/pull/90370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/90760
>From 5086c9801842b22dbc99393d52a02f35d1fcfdfc Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Wed, 1 May 2024 10:54:12 -0400
Subject: [PATCH 1/2] [Clang][Sema] Explicit template arguments are not
su
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 7cbaaed63612fe6446355c5ffe33ddd57578b929
2bc18f45560f607a09c756bb9ebca0b7ad5d1bb4 --
https://github.com/Endilll commented:
Changes to DR tests look good to me.
https://github.com/llvm/llvm-project/pull/90760
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: David Truby (DavidTruby)
Changes
Currently the paths to compiler-rt and the Flang runtimes from the LLVM
build/install directory are preferred over any user-provided library paths.
This means a user can't override compiler-rt or the Flang
haoNoQ wrote:
Hmm it doesn't look like we actually have that other suppression. It looks like
the checker simply never warned in the standard library because there aren't
WebKit classes in the standard library. But it looks like you've found a few
cases where it actually happens? How does this
@@ -2616,6 +2617,13 @@ bool Sema::IsFloatingPointPromotion(QualType FromType,
QualType ToType) {
ToBuiltin->getKind() == BuiltinType::Ibm128))
return true;
+ // In HLSL, `half` promotes to `float` or `double`, regardless of whether
+ // or not nat
@@ -0,0 +1,229 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -fnative-half-type
-finclude-default-header -Wconversion -verify -o - %s
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -fnative-half-type
-finclude-default-header -ast-dump %s | FileCheck %
https://github.com/sdkrystian edited
https://github.com/llvm/llvm-project/pull/90760
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
b-sumner wrote:
@lamb-j I appreciate your carrying out these performance tests!
Would you be open to providing an option to enable post-link optimization that
could be off by default for now?
https://github.com/llvm/llvm-project/pull/85672
___
cfe-co
sdkrystian wrote:
FWIW, the changes in be79079507ffbd9b29683498f405dc2c32dd8ba7 fix the crash
https://github.com/llvm/llvm-project/pull/90646
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
@@ -4393,6 +4401,24 @@ getFixedEnumPromtion(Sema &S, const
StandardConversionSequence &SCS) {
return FixedEnumPromotion::ToPromotedUnderlyingType;
}
+static ImplicitConversionSequence::CompareKind
+HLSLCompareFloatingRank(QualType LHS, QualType RHS) {
+ assert(LHS->isVecto
@@ -2616,6 +2617,13 @@ bool Sema::IsFloatingPointPromotion(QualType FromType,
QualType ToType) {
ToBuiltin->getKind() == BuiltinType::Ibm128))
return true;
+ // In HLSL, `half` promotes to `float` or `double`, regardless of whether
+ // or not nat
@@ -0,0 +1,229 @@
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -fnative-half-type
-finclude-default-header -Wconversion -verify -o - %s
+// RUN: %clang_cc1 -triple dxil-pc-shadermodel6.3-library -fnative-half-type
-finclude-default-header -ast-dump %s | FileCheck %
101 - 200 of 363 matches
Mail list logo
