https://github.com/apolloww closed
https://github.com/llvm/llvm-project/pull/90672
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/haoNoQ approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/90180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -360,6 +370,16 @@ class TrivialFunctionAnalysisVisitor
return TrivialFunctionAnalysis::isTrivialImpl(Callee, Cache);
}
+ bool
+ VisitSubstNonTypeTemplateParmExpr(const SubstNonTypeTemplateParmExpr *E) {
+// Non-type template paramter is trivial if the replacemen
https://github.com/haoNoQ approved this pull request.
LGTM other than the other tiny comment.
https://github.com/llvm/llvm-project/pull/90414
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
@@ -0,0 +1,77 @@
+// This tests that the coroutine elide optimization could happen succesfully
with ThinLTO.
+// This test is adapted from coro-elide.cpp and splits functions into two
files.
+//
+// RUN: split-file %s %t
+// RUN: %clang --target=x86_64-linux -std=c++20 -O2 -flto
@@ -1151,6 +1151,13 @@ std::string Triple::normalize(StringRef Str) {
}
}
+ // For 3-component triples, the middle component is used to set Vendor;
+ // while if it is "none", we'd prefer to set OS.
+ // This is for some baremetal cases, such as "arm-none-elf".
+ if
haoNoQ wrote:
Ok am I reading this right: this is about testing code that lives directly in
namespace `std::` but somehow still lives in your project right? Such as your
custom modifications to standard classes, various overloads and specializations
of standard things.
This patch does not aff
@@ -1151,6 +1151,13 @@ std::string Triple::normalize(StringRef Str) {
}
}
+ // For 3-component triples, the middle component is used to set Vendor;
MaskRay wrote:
Suggested comment
If "none" is in the middle component in a three-component triple, trea
haoNoQ wrote:
(If yes, LGTM!)
https://github.com/llvm/llvm-project/pull/90552
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvm-beanz created
https://github.com/llvm/llvm-project/pull/90694
We had some odd places where we set target behaviors. We were setting the long
size in target-specific code, but it should be language-based. We were not
setting the Half float type semantics correctly, and i
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Chris B (llvm-beanz)
Changes
We had some odd places where we set target behaviors. We were setting the long
size in target-specific code, but it should be language-based. We were not
setting the Half float type semantics correctly, and in
@@ -406,6 +406,16 @@ void TargetInfo::adjust(DiagnosticsEngine &Diags,
LangOptions &Opts) {
LongDoubleAlign = 64;
}
+ // HLSL explicitly defines the sizes and formats of some data types, and we
+ // need to conform to those regardless of what architecture you are
tar
shafik wrote:
> @cor3ntin @shafik Hi, I want to take charge of this issue and submit a PR for
> the fix.
I would open a new PR and reference this one in the summary for completeness.
It looks like this one is not going to picked up by the author and so if you
can take it over and finish it th
MaskRay wrote:
> When we parse 3-components triples, if the Arch and Env have been parsed
> successfully, we have to make a choice between Vendor and OS for the
> unrecoginzed component. Noramlly it is the middle one.
>
> In the current code, Vendor is choosed, and then OS is fallbacked to unk
@@ -0,0 +1,77 @@
+// This tests that the coroutine elide optimization could happen succesfully
with ThinLTO.
+// This test is adapted from coro-elide.cpp and splits functions into two
files.
+//
+// RUN: split-file %s %t
+// RUN: %clang --target=x86_64-linux -std=c++20 -O2 -flto
Author: Owen Pan
Date: 2024-04-30T20:01:34-07:00
New Revision: 8e9b1e9aa83b44fad44954bbd01c824def2b190f
URL:
https://github.com/llvm/llvm-project/commit/8e9b1e9aa83b44fad44954bbd01c824def2b190f
DIFF:
https://github.com/llvm/llvm-project/commit/8e9b1e9aa83b44fad44954bbd01c824def2b190f.diff
LOG:
https://github.com/owenca closed https://github.com/llvm/llvm-project/pull/90555
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nikic wrote:
> I gave this a test and _almost_ nothing changed. So looks good in that regard.
I expect that the main producer of scalable GEPs is LoopVectorize, which will
already use the llvm.vscale representation anyway. So there's probably not many
`https://github.com/llvm/llvm-project/pull
https://github.com/cyndyishida updated
https://github.com/llvm/llvm-project/pull/90686
>From c4fec501607059b1030b7c53794ad271194d Mon Sep 17 00:00:00 2001
From: Cyndy Ishida
Date: Thu, 18 Apr 2024 07:28:44 -0700
Subject: [PATCH 1/2] [InstallAPI] Support mutually exclusive parse options
Pro
https://github.com/damyanp approved this pull request.
https://github.com/llvm/llvm-project/pull/90694
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/90195
>From f708694fc2686684589dca7b8f3738a117fc047e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 26 Apr 2024 19:06:57 +0800
Subject: [PATCH 1/4] [Sema] Avoid an undesired pack expansion while
transforming P
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/90195
>From f708694fc2686684589dca7b8f3738a117fc047e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 26 Apr 2024 19:06:57 +0800
Subject: [PATCH 1/5] [Sema] Avoid an undesired pack expansion while
transforming P
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 3ea9ed471c8dca8f703d7f3ce93d274a718b54bb
7a087f06240ce09a64fe679df14380e2fa538701 --
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/90195
>From f708694fc2686684589dca7b8f3738a117fc047e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 26 Apr 2024 19:06:57 +0800
Subject: [PATCH 1/6] [Sema] Avoid an undesired pack expansion while
transforming P
Author: Younan Zhang
Date: 2024-05-01T11:52:14+08:00
New Revision: 410d6350eda322de213941b36adcdab13a0b557b
URL:
https://github.com/llvm/llvm-project/commit/410d6350eda322de213941b36adcdab13a0b557b
DIFF:
https://github.com/llvm/llvm-project/commit/410d6350eda322de213941b36adcdab13a0b557b.diff
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/90195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/topperc created
https://github.com/llvm/llvm-project/pull/90700
Instead of hardcoding the 4 current profile prefixes, treat profile selection
as a fallback if we don't find "rv32" or "rv64".
Update the error message accordingly.
>From 4898039d647424fdc3ad4c8db7ee114385f3a37
llvmbot wrote:
@llvm/pr-subscribers-mc
Author: Craig Topper (topperc)
Changes
Instead of hardcoding the 4 current profile prefixes, treat profile selection
as a fallback if we don't find "rv32" or "rv64".
Update the error message accordingly.
---
Full diff: https://github.com/llvm/llvm-
llvmbot wrote:
@llvm/pr-subscribers-backend-risc-v
Author: Craig Topper (topperc)
Changes
Instead of hardcoding the 4 current profile prefixes, treat profile selection
as a fallback if we don't find "rv32" or "rv64".
Update the error message accordingly.
---
Full diff: https://github.co
@@ -360,6 +370,16 @@ class TrivialFunctionAnalysisVisitor
return TrivialFunctionAnalysis::isTrivialImpl(Callee, Cache);
}
+ bool
+ VisitSubstNonTypeTemplateParmExpr(const SubstNonTypeTemplateParmExpr *E) {
+// Non-type template paramter is trivial if the replacemen
rniwa wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/90180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Ryosuke Niwa
Date: 2024-04-30T21:12:52-07:00
New Revision: 240592a772a40b4ffa75921f7b555d2a969b3383
URL:
https://github.com/llvm/llvm-project/commit/240592a772a40b4ffa75921f7b555d2a969b3383
DIFF:
https://github.com/llvm/llvm-project/commit/240592a772a40b4ffa75921f7b555d2a969b3383.diff
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/90180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
rniwa wrote:
> Ok am I reading this right: this is about testing code that lives directly in
> namespace `std::` but somehow still lives in your project right? Such as your
> custom modifications to standard classes, various overloads and
> specializations of standard things.
No, this is abou
rniwa wrote:
Oh, looks like I broke tests. Reverting.
https://github.com/llvm/llvm-project/pull/90180
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/90701
Reverts llvm/llvm-project#90180
>From 54ff88ab2b46e0ba82cc59077c6d3b367eecd497 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Tue, 30 Apr 2024 21:28:03 -0700
Subject: [PATCH] =?UTF-8?q?Revert=20"[alpha.webkit.Un
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Ryosuke Niwa (rniwa)
Changes
Reverts llvm/llvm-project#90180
---
Full diff: https://github.com/llvm/llvm-project/pull/90701.diff
3 Files Affected:
- (modified)
clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedCallArgsChecker.cpp (+3-1
https://github.com/dougsonos created
https://github.com/llvm/llvm-project/pull/90702
This addresses an issue where the explicit alignment of 2 (for C++ ABI reasons)
was being propagated to the back end and causing under-aligned functions (in
special sections). (#90358)
This is an alternate ap
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-backend-aarch64
@llvm/pr-subscribers-llvm-ir
Author: Doug Wyatt (dougsonos)
Changes
This addresses an issue where the explicit alignment of 2 (for C++ ABI reasons)
was being propagated to the back end and causing under-aligned functions (in
special sec
Author: Ryosuke Niwa
Date: 2024-04-30T21:51:45-07:00
New Revision: 3684a38d33d7643fe8c3a870006efa8677ac37f8
URL:
https://github.com/llvm/llvm-project/commit/3684a38d33d7643fe8c3a870006efa8677ac37f8
DIFF:
https://github.com/llvm/llvm-project/commit/3684a38d33d7643fe8c3a870006efa8677ac37f8.diff
https://github.com/rniwa closed https://github.com/llvm/llvm-project/pull/90701
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/efriedma-quic edited
https://github.com/llvm/llvm-project/pull/90702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/efriedma-quic commented:
This looks correct.
I'd expect regression tests for the autoupgrade, and a test that clang isn't
generating the alignment markings anymore.
https://github.com/llvm/llvm-project/pull/90702
___
cfe-commits ma
@@ -5387,6 +5387,14 @@ std::string llvm::UpgradeDataLayoutString(StringRef DL,
StringRef TT) {
return Res;
}
+ // AArch64 data layout upgrades.
+ if (T.isAArch64()) {
+// Add "-Fn32"
+if (!DL.contains("-Fn32"))
+ Res.append("-Fn32");
efri
@@ -5387,6 +5387,14 @@ std::string llvm::UpgradeDataLayoutString(StringRef DL,
StringRef TT) {
return Res;
}
+ // AArch64 data layout upgrades.
+ if (T.isAArch64()) {
+// Add "-Fn32"
+if (!DL.contains("-Fn32"))
+ Res.append("-Fn32");
doug
https://github.com/dougsonos edited
https://github.com/llvm/llvm-project/pull/90702
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/rniwa created https://github.com/llvm/llvm-project/pull/90704
None
>From e408befb6422d9063572ddcad2c152eede1b5ca0 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Tue, 30 Apr 2024 21:12:52 -0700
Subject: [PATCH] [alpha.webkit.UncountedCallArgsChecker] Ignore methods of WTF
llvmbot wrote:
@llvm/pr-subscribers-clang-static-analyzer-1
Author: Ryosuke Niwa (rniwa)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/90704.diff
3 Files Affected:
- (modified)
clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedCallArgsChecker.cpp (+10-3)
- (modifi
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Ryosuke Niwa (rniwa)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/90704.diff
3 Files Affected:
- (modified)
clang/lib/StaticAnalyzer/Checkers/WebKit/UncountedCallArgsChecker.cpp (+10-3)
- (modified) clang/test/Ana
https://github.com/nikic closed https://github.com/llvm/llvm-project/pull/90569
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -5387,6 +5387,14 @@ std::string llvm::UpgradeDataLayoutString(StringRef DL,
StringRef TT) {
return Res;
}
+ // AArch64 data layout upgrades.
+ if (T.isAArch64()) {
+// Add "-Fn32"
+if (!DL.contains("-Fn32"))
+ Res.append("-Fn32");
efri
@@ -2824,8 +2826,12 @@ bool RISCVAsmParser::parseDirectiveOption() {
break;
}
- auto Ext = llvm::lower_bound(RISCVFeatureKV, Arch);
- if (Ext == std::end(RISCVFeatureKV) || StringRef(Ext->Key) != Arch ||
+ std::string Feature = RISCVISAInfo::getTar
@@ -51,7 +51,6 @@ STATISTIC(RISCVNumInstrsCompressed,
static cl::opt AddBuildAttributes("riscv-add-build-attributes",
cl::init(false));
-
topperc wrote:
Unrelated change?
https://github.com/llvm/llvm-project/pull/89727
https://github.com/rniwa updated https://github.com/llvm/llvm-project/pull/90414
>From 416dec586ed566e6c29ca8f5fa66be488ac09e78 Mon Sep 17 00:00:00 2001
From: Ryosuke Niwa
Date: Sun, 28 Apr 2024 13:17:48 -0700
Subject: [PATCH 1/2] [alpha.webkit.UncountedCallArgsChecker] Support more
trivial exp
https://github.com/wzssyqa updated
https://github.com/llvm/llvm-project/pull/89638
>From a165cd689e6fa23163736ea6d76d8a60440f4b30 Mon Sep 17 00:00:00 2001
From: YunQiang Su
Date: Sat, 27 Apr 2024 10:55:38 +0800
Subject: [PATCH 1/2] Triple::normalize: Use none as OS for XX-none-ABI
When parsing
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff e04df693bf5b38099ef1d7ab8e6ce6a1469597e2
7471e4f6032b7913f9d983a3488f0c6f7e33c9b8 --
https://github.com/wzssyqa updated
https://github.com/llvm/llvm-project/pull/89638
>From cd3107eca3575b066915c6ea9d6d1a38ad68d913 Mon Sep 17 00:00:00 2001
From: YunQiang Su
Date: Sat, 27 Apr 2024 10:55:38 +0800
Subject: [PATCH 1/2] Triple::normalize: Use none as OS for XX-none-ABI
When parsing
https://github.com/wzssyqa updated
https://github.com/llvm/llvm-project/pull/89638
>From 942b1a8ad3e994aaa7eae63ee923d9946cba0087 Mon Sep 17 00:00:00 2001
From: YunQiang Su
Date: Sat, 27 Apr 2024 10:55:38 +0800
Subject: [PATCH 1/2] Triple::normalize: Use none as OS for XX-none-ABI
When parsing
https://github.com/wzssyqa updated
https://github.com/llvm/llvm-project/pull/89638
>From 3cec71e178264b69e43c4842302b61465271d735 Mon Sep 17 00:00:00 2001
From: YunQiang Su
Date: Sat, 27 Apr 2024 10:55:38 +0800
Subject: [PATCH 1/2] Triple::normalize: Use none as OS for XX-none-ABI
When parsing
401 - 460 of 460 matches
Mail list logo
