https://github.com/erichkeane approved this pull request.
This needs a release note, likely in the 'potentially breaking changes'.
Projects are filled with code that is not ever instantiated, and Clang's
aggressive instantiation can be a problem.
Else, LGTM.
https://github.com/llvm/llvm-proj
https://github.com/hekota approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/90276
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hekota approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/90277
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
delcypher wrote:
@AaronBallman @erichkeane Ping. Is this ready to land?
https://github.com/llvm/llvm-project/pull/88596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane approved this pull request.
This looks fine enough to me. Aaron is away this week, so you can either let
him review this when he gets back, or just merge this and let him make comments
on followups/on the commit when he gets back.
https://github.com/llvm/llvm-proj
https://github.com/ldionne approved this pull request.
The libc++abi changes look fine to me.
https://github.com/llvm/llvm-project/pull/90391
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
@@ -113,7 +114,7 @@ struct SA {
#pragma omp target map(b[true:true])
{}
-#pragma omp target map(: c,f) // expected-error {{missing map type}}
+#pragma omp target map(: c,f) // lt60-error {{missing map type}}
jyu2-git wrote:
In OMP60, the map-t
tschuett wrote:
Nit: the `declare` is not necessary anymore. You touched the IRTranslator
without a test at, e.g.,
https://github.com/llvm/llvm-project/blob/main/llvm/test/CodeGen/AArch64/GlobalISel/arm64-irtranslator.ll
https://github.com/llvm/llvm-project/pull/90503
_
@@ -113,7 +114,7 @@ struct SA {
#pragma omp target map(b[true:true])
{}
-#pragma omp target map(: c,f) // expected-error {{missing map type}}
+#pragma omp target map(: c,f) // lt60-error {{missing map type}}
alexey-bataev wrote:
So, does hangi
https://github.com/alexey-bataev edited
https://github.com/llvm/llvm-project/pull/90499
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -28,12 +28,8 @@ PreservedAnalyses LinkInModulesPass::run(Module &M,
ModuleAnalysisManager &AM) {
if (!BC)
return PreservedAnalyses::all();
- // Re-load bitcode modules from files
- if (BC->ReloadModules(&M))
-report_fatal_error("Bitcode module re-loading failed
https://github.com/andykaylor updated
https://github.com/llvm/llvm-project/pull/89477
>From 8ab931c4506f08685758a58f4cf7974c5254c3fa Mon Sep 17 00:00:00 2001
From: Andy Kaylor
Date: Fri, 19 Apr 2024 17:53:52 -0700
Subject: [PATCH 1/8] Clean up denormal handling with -ffp-model, -ffast-math,
et
https://github.com/andykaylor edited
https://github.com/llvm/llvm-project/pull/89477
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,28 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 4
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -O3 -emit-llvm -o - %s \
zahiraam wrote:
There is no need to use -O3 here to prove what you want, I
@@ -0,0 +1,28 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 4
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -O3 -emit-llvm -o - %s \
+// RUN: | FileCheck -check-prefix=CHECK %s
+
zahiraam wrote:
How about ad
@@ -0,0 +1,28 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 4
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -O3 -emit-llvm -o - %s \
+// RUN: | FileCheck -check-prefix=CHECK %s
+
+// Reproducer for issue #87758
+// The testca
@@ -1056,6 +1083,25 @@ void CoroCloner::create() {
// Set up the new entry block.
replaceEntryBlock();
+ // Turn symmetric transfers into musttail calls.
+ for (CallInst *ResumeCall : Shape.SymmetricTransfers) {
+ResumeCall = cast(VMap[ResumeCall]);
+ResumeCall->
@@ -1465,6 +1465,7 @@ void CodeGenFunction::GenerateCode(GlobalDecl GD,
llvm::Function *Fn,
// Ensure that the function adheres to the forward progress guarantee, which
// is required by certain optimizations.
+ // The attribute will be removed if the body contains a tri
@@ -908,6 +908,74 @@ void CodeGenFunction::EmitIfStmt(const IfStmt &S) {
incrementProfileCounter(&S);
}
+bool CodeGenFunction::checkIfLoopMustProgress(const Expr
*ControllingExpression,
+ bool IsTrivialCXXLoop) {
+ if (CGM.get
lntue wrote:
> #85868
You can update the title of the PR to reflect the changes, and add `Fixes
https://github.com/llvm/llvm-project/issues/85868` to relating the PR to the
issue.
OTOH, the libc changes look good to me.
https://github.com/llvm/llvm-project/pull/90391
https://github.com/sousajo-cc edited
https://github.com/llvm/llvm-project/pull/90485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma-quic wrote:
Are you intentionally skipping implementing changes to __builtin_tan()?
https://github.com/llvm/llvm-project/pull/90276
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-com
Author: Eli Friedman
Date: 2024-04-29T12:00:12-07:00
New Revision: 3ab4ae9e58c09dfd8203547ba8916f3458a0a481
URL:
https://github.com/llvm/llvm-project/commit/3ab4ae9e58c09dfd8203547ba8916f3458a0a481
DIFF:
https://github.com/llvm/llvm-project/commit/3ab4ae9e58c09dfd8203547ba8916f3458a0a481.diff
https://github.com/efriedma-quic closed
https://github.com/llvm/llvm-project/pull/90151
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hokein edited https://github.com/llvm/llvm-project/pull/90466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
farzonl wrote:
> Nit: the `declare` is not necessary anymore. You touched the IRTranslator
> without a test at, e.g.,
> https://github.com/llvm/llvm-project/blob/main/llvm/test/CodeGen/AArch64/GlobalISel/arm64-irtranslator.ll
The aarch64 backend tag is a misnomer because adding `G_FTAN` caused
dwblaikie wrote:
> > C doesn't have an odr, does it?
>
> For non-C++ "ODR" has a meaning more like "ODR-inspired checks". But there is
> no language rule that would require enforcement and there is no impact on
> linkage (at least during deserialization).
Not sure I'm following the response h
@@ -1105,6 +1105,11 @@ bool MicrosoftCXXABI::hasMostDerivedReturn(GlobalDecl
GD) const {
static bool isTrivialForMSVC(const CXXRecordDecl *RD, QualType Ty,
CodeGenModule &CGM) {
+ // If the record is marked with the trivial_abi attribute, we don'
tschuett wrote:
Firstly, it is a nit. The IRTranslator translates LLVM-IR into GMIR for
GlobalIsel. Testing the IRTranslator is independent of any SDAG changes.
https://github.com/llvm/llvm-project/pull/90503
___
cfe-commits mailing list
cfe-commits@l
https://github.com/shafik approved this pull request.
LGTM, thank you for the documentation fix.
https://github.com/llvm/llvm-project/pull/90485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe
shafik wrote:
The `amdgpu-toolchain.c` test failure looks unrelated. I think we need another
empty commit to kick off the build again unfortunately.
https://github.com/llvm/llvm-project/pull/89923
___
cfe-commits mailing list
cfe-commits@lists.llvm.or
cor3ntin wrote:
I think CI is having some difficulties. No need to wait for it for this.
Thanks a lot for your first contribution!
We have some good first issues if you want to have a go at some more
contributions
https://github.com/llvm/llvm-project/issues?q=is%3Aissue+is%3Aopen+good+first+issu
Author: Troy Butler
Date: 2024-04-29T21:24:29+02:00
New Revision: 99ce84cef0185fe9eaec51e40ea80f69f06981f0
URL:
https://github.com/llvm/llvm-project/commit/99ce84cef0185fe9eaec51e40ea80f69f06981f0
DIFF:
https://github.com/llvm/llvm-project/commit/99ce84cef0185fe9eaec51e40ea80f69f06981f0.diff
L
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/89923
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -674,6 +674,9 @@
# DEBUG-NEXT: .. opcode {{[0-9]+}} is aliased to {{[0-9]+}}
# DEBUG-NEXT: .. the first uncovered type index: 1, OK
# DEBUG-NEXT: .. the first uncovered imm index: 0, OK
+# DEBUG-NEXT: G_FTAN (opcode {{[0-9]+}}): 1 type index, 0 imm indices
t
https://github.com/lanza edited https://github.com/llvm/llvm-project/pull/89030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Nathan Lanza
Date: 2024-04-29T15:46:18-04:00
New Revision: 359ab3aebba302fb4c37373b9907bc8880be7363
URL:
https://github.com/llvm/llvm-project/commit/359ab3aebba302fb4c37373b9907bc8880be7363
DIFF:
https://github.com/llvm/llvm-project/commit/359ab3aebba302fb4c37373b9907bc8880be7363.diff
https://github.com/lanza closed https://github.com/llvm/llvm-project/pull/89030
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/90517
According to [[class.mem.general]
p8](http://eel.is/c++draft/class.mem.general#8):
> A complete-class context of a class (template) is a
> - function body,
> - default argument,
> - default template argument,
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Krystian Stasiowski (sdkrystian)
Changes
According to [[class.mem.general]
p8](http://eel.is/c++draft/class.mem.general#8):
> A complete-class context of a class (template) is a
> - function body,
> - default argument,
> - default template
sdkrystian wrote:
Note: This still needs a release note + test updates
https://github.com/llvm/llvm-project/pull/90517
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aganea updated
https://github.com/llvm/llvm-project/pull/89950
>From f2340c98c95e0d72516fc240ff268fead9f15391 Mon Sep 17 00:00:00 2001
From: Alexandre Ganea
Date: Wed, 17 Apr 2024 16:28:21 -0400
Subject: [PATCH 1/5] [clang-scan-deps] Expand response files before the
argument
@@ -1069,7 +1069,7 @@ void Clang::AddPreprocessingOptions(Compilation &C, const
JobAction &JA,
// If user provided -o, that is the dependency target, except
// when we are only generating a dependency file.
- Arg *OutputOpt = Args.getLastArg(options::OPT_o);
@@ -0,0 +1,36 @@
+// Check that the scanner can adjust arguments by reading .rsp files in
advance.
+
+// RUN: rm -rf %t
+// RUN: split-file %s %t
+// RUN: sed -e "s|DIR|%/t|g" %t/cdb.json.template > %t/cdb.json
aganea wrote:
As suggested. We're taking a differen
@@ -0,0 +1,36 @@
+// Check that the scanner can adjust arguments by reading .rsp files in
advance.
+
+// RUN: rm -rf %t
+// RUN: split-file %s %t
+// RUN: sed -e "s|DIR|%/t|g" %t/cdb.json.template > %t/cdb.json
+// RUN: echo /Fo%t/tu.obj >> %t/args_nested.rsp
aga
@@ -792,10 +792,15 @@ int clang_scan_deps_main(int argc, char **argv, const
llvm::ToolContext &) {
llvm::cl::PrintOptionValues();
+ // Expand response files in advance, so that we can "see" all the arguments
+ // when adjusting below.
+ auto ResponseExpander = expandRes
https://github.com/aganea edited https://github.com/llvm/llvm-project/pull/89950
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
sdkrystian wrote:
This actually requires a little more work... (the delayed exception
specification parsing code seems to only expect `CXXMethodDecl`s). I'll take
care of that tomorrow.
https://github.com/llvm/llvm-project/pull/90517
___
cfe-commits
Author: cor3ntin
Date: 2024-04-29T22:11:09+02:00
New Revision: 326657f5679889e3374354ba3243e27bda2080f4
URL:
https://github.com/llvm/llvm-project/commit/326657f5679889e3374354ba3243e27bda2080f4
DIFF:
https://github.com/llvm/llvm-project/commit/326657f5679889e3374354ba3243e27bda2080f4.diff
LOG:
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/90495
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
cor3ntin wrote:
This compiles locally. CI is really slow...
https://github.com/llvm/llvm-project/pull/90495
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Jorge Pinto Sousa
Date: 2024-04-29T22:14:53+02:00
New Revision: e5907c88594133e45b8d1d4e29702b96d7f45c77
URL:
https://github.com/llvm/llvm-project/commit/e5907c88594133e45b8d1d4e29702b96d7f45c77
DIFF:
https://github.com/llvm/llvm-project/commit/e5907c88594133e45b8d1d4e29702b96d7f45c77.d
https://github.com/cor3ntin closed
https://github.com/llvm/llvm-project/pull/90485
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jyu2-git updated
https://github.com/llvm/llvm-project/pull/90499
>From 20904df466de953880ca6af4afd72d7dfae33224 Mon Sep 17 00:00:00 2001
From: Jennifer Yu
Date: Mon, 29 Apr 2024 10:01:12 -0700
Subject: [PATCH 1/2] [OpenMP][TR12] change proerty of map-type modifer.
map-type c
@@ -113,7 +114,7 @@ struct SA {
#pragma omp target map(b[true:true])
{}
-#pragma omp target map(: c,f) // expected-error {{missing map type}}
+#pragma omp target map(: c,f) // lt60-error {{missing map type}}
jyu2-git wrote:
Yes.
https://gith
klausler wrote:
See https://github.com/llvm/llvm-project/pull/90518, which I think would
greatly ease implementation of `-w`.
https://github.com/llvm/llvm-project/pull/90420
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.or
farzonl wrote:
> Are you intentionally skipping implementing changes to __builtin_tan()?
Yes but, maybe my reasoning isn't good enough to exclude. Let me know. I didn't
add it for two reasons.
First sine and cosine define builtins like so:
```
def SinF16F128 : Builtin, F16F128MathTemplate {
@@ -908,6 +908,74 @@ void CodeGenFunction::EmitIfStmt(const IfStmt &S) {
incrementProfileCounter(&S);
}
+bool CodeGenFunction::checkIfLoopMustProgress(const Expr
*ControllingExpression,
+ bool IsTrivialCXXLoop) {
+ if (CGM.get
Author: Andy Kaylor
Date: 2024-04-29T13:22:08-07:00
New Revision: 8ba880b587074ad6c8624ed45ea2b289f653667f
URL:
https://github.com/llvm/llvm-project/commit/8ba880b587074ad6c8624ed45ea2b289f653667f
DIFF:
https://github.com/llvm/llvm-project/commit/8ba880b587074ad6c8624ed45ea2b289f653667f.diff
L
https://github.com/andykaylor closed
https://github.com/llvm/llvm-project/pull/89477
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3123,8 +3123,22 @@ Address X86_64ABIInfo::EmitVAArg(CodeGenFunction &CGF,
Address VAListAddr,
RegAddr = Tmp.withElementType(LTy);
} else if (neededInt) {
-RegAddr = Address(CGF.Builder.CreateGEP(CGF.Int8Ty, RegSaveArea,
gp_offset),
- LTy, C
https://github.com/hekota updated
https://github.com/llvm/llvm-project/pull/89809
>From 22b67d30ca087d6a912183039c87fd1790eedfe4 Mon Sep 17 00:00:00 2001
From: Helena Kotas
Date: Tue, 23 Apr 2024 00:49:28 -0700
Subject: [PATCH 1/3] Add environment parameter to clang availability attribute
---
https://github.com/erichkeane created
https://github.com/llvm/llvm-project/pull/90521
The private clause is the first that takes a 'var-list', thus this has a lot of
additional work to enable the var-list type. A 'var' is a traditional variable
reference, subscript, member-expression, or arra
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Erich Keane (erichkeane)
Changes
The private clause is the first that takes a 'var-list', thus this has a lot of
additional work to enable the var-list type. A 'var' is a traditional variable
reference, subscript, member-expression, or a
@@ -1056,6 +1083,25 @@ void CoroCloner::create() {
// Set up the new entry block.
replaceEntryBlock();
+ // Turn symmetric transfers into musttail calls.
+ for (CallInst *ResumeCall : Shape.SymmetricTransfers) {
+ResumeCall = cast(VMap[ResumeCall]);
+ResumeCall->
@@ -535,20 +535,24 @@ void AggExprEmitter::EmitArrayInit(Address DestPtr,
llvm::ArrayType *AType,
elementType.isTriviallyCopyableType(CGF.getContext())) {
CodeGen::CodeGenModule &CGM = CGF.CGM;
ConstantEmitter Emitter(CGF);
-LangAS AS = ArrayQTy.getAddressSpa
https://github.com/erichkeane commented:
Missing test + release note.
In the future, please use 'draft pull request' when your patch is not ready for
review/to be committed.
https://github.com/llvm/llvm-project/pull/90517
___
cfe-commits mailing list
Author: Seth Pellegrino
Date: 2024-04-29T13:45:00-07:00
New Revision: 347a02b408567ba15fdc68646129c1f5de97ab7e
URL:
https://github.com/llvm/llvm-project/commit/347a02b408567ba15fdc68646129c1f5de97ab7e
DIFF:
https://github.com/llvm/llvm-project/commit/347a02b408567ba15fdc68646129c1f5de97ab7e.dif
Author: Fangrui Song
Date: 2024-04-29T13:47:09-07:00
New Revision: 6f390ea60d987f6e1e027d1c72982c2eb7896005
URL:
https://github.com/llvm/llvm-project/commit/6f390ea60d987f6e1e027d1c72982c2eb7896005
DIFF:
https://github.com/llvm/llvm-project/commit/6f390ea60d987f6e1e027d1c72982c2eb7896005.diff
MaskRay wrote:
This simplification seems desired. https://reviews.llvm.org/D00#3302749 had
a `LLVM_INSTALL_TOOLCHAIN_ONLY` condition, which seems unneeded.
https://github.com/llvm/llvm-project/pull/90370
___
cfe-commits mailing list
cfe-commits@li
https://github.com/MaskRay approved this pull request.
https://github.com/llvm/llvm-project/pull/90370
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -177,7 +177,7 @@ C++2c implementation status
Attributes for Structured Bindings
https://wg21.link/P0609R3";>P0609R3
- No
+ Clang 19
vogelsgesang wrote:
none -> unreleased
But maybe just fix this together when landing #90066...
https://github.com/l
@@ -187,7 +187,7 @@ C++2c implementation status
Trivial infinite loops are not Undefined Behavior
https://wg21.link/P2809R3";>P2809R3 (DR)
- Clang 19
+ No
vogelsgesang wrote:
unreleased -> none
https://github.com/llvm/llvm-project/pull/90495
_
@@ -113,7 +114,7 @@ struct SA {
#pragma omp target map(b[true:true])
{}
-#pragma omp target map(: c,f) // expected-error {{missing map type}}
+#pragma omp target map(: c,f) // lt60-error {{missing map type}}
alexey-bataev wrote:
Hm,, I see in
https://github.com/shafik commented:
So this seems to apply to member pointer types, pointer types, arrays and
function types but I don't see coverage for the full set of paths in the tests.
Can we please add more testing.
Erich also expressed some concern about breaking existing code due to e
https://github.com/efriedma-quic approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/89707
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aheejin edited
https://github.com/llvm/llvm-project/pull/80923
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/aheejin edited
https://github.com/llvm/llvm-project/pull/80923
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Heejin Ahn
Date: 2024-04-29T14:23:08-07:00
New Revision: 5bbf1ea8f18d1f99637b7b8bf6b985c186c808f6
URL:
https://github.com/llvm/llvm-project/commit/5bbf1ea8f18d1f99637b7b8bf6b985c186c808f6
DIFF:
https://github.com/llvm/llvm-project/commit/5bbf1ea8f18d1f99637b7b8bf6b985c186c808f6.diff
LO
https://github.com/aheejin closed
https://github.com/llvm/llvm-project/pull/80923
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vsapsai wrote:
> Not sure I'm following the response here - but I guess what I'm trying to
> say, with more words, is that my understanding was that C doesn't have an
> ODR, and you can have different definitions of a type, with the same name, in
> C and that's OK.
In different translation un
@@ -21,6 +21,12 @@ char f_int_4(char x) { return x; }
// CHECK-LABEL: define{{.*}} fp128 @f_ld(fp128 noundef %x)
long double f_ld(long double x) { return x; }
+// Empty struct is lowered as a placeholder word parameter.
+struct empty {};
+
+// CHECK-LABEL: define{{.*}} i64 @f_
@@ -263,7 +263,10 @@ SparcV9ABIInfo::classifyType(QualType Ty, unsigned
SizeLimit) const {
CoerceBuilder CB(getVMContext(), getDataLayout());
CB.addStruct(0, StrTy);
- CB.pad(llvm::alignTo(CB.DL.getTypeSizeInBits(StrTy), 64));
+ // All structs, even empty ones, should t
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/90490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -6714,14 +6714,16 @@ void Sema::CodeCompleteQualifiedId(Scope *S,
CXXScopeSpec &SS,
// If the scope is a concept-constrained type parameter, infer nested
// members based on the constraints.
- if (const auto *TTPT =
- dyn_cast_or_null(NNS->getAsType())) {
-
https://github.com/shafik commented:
Looks good, I will let Tom make the final accept.
https://github.com/llvm/llvm-project/pull/90490
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -113,7 +114,7 @@ struct SA {
#pragma omp target map(b[true:true])
{}
-#pragma omp target map(: c,f) // expected-error {{missing map type}}
+#pragma omp target map(: c,f) // lt60-error {{missing map type}}
jyu2-git wrote:
Hi Alexey, could yo
@@ -6714,14 +6714,16 @@ void Sema::CodeCompleteQualifiedId(Scope *S,
CXXScopeSpec &SS,
// If the scope is a concept-constrained type parameter, infer nested
// members based on the constraints.
- if (const auto *TTPT =
- dyn_cast_or_null(NNS->getAsType())) {
-
Author: Kees Cook
Date: 2024-04-29T14:54:10-07:00
New Revision: 869ffcf3f6ca74c8a0ec6eb250d45e6ea0680c81
URL:
https://github.com/llvm/llvm-project/commit/869ffcf3f6ca74c8a0ec6eb250d45e6ea0680c81
DIFF:
https://github.com/llvm/llvm-project/commit/869ffcf3f6ca74c8a0ec6eb250d45e6ea0680c81.diff
LOG
https://github.com/kees closed https://github.com/llvm/llvm-project/pull/89707
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Reid Kleckner
Date: 2024-04-29T22:09:09Z
New Revision: 1f44a0b1ff2daebe10b9916da228f7c0ba66827c
URL:
https://github.com/llvm/llvm-project/commit/1f44a0b1ff2daebe10b9916da228f7c0ba66827c
DIFF:
https://github.com/llvm/llvm-project/commit/1f44a0b1ff2daebe10b9916da228f7c0ba66827c.diff
LOG:
@@ -177,7 +177,7 @@ C++2c implementation status
Attributes for Structured Bindings
https://wg21.link/P0609R3";>P0609R3
- No
+ Clang 19
cor3ntin wrote:
Ugh, how did that happen? Thanks for noticing!
https://github.com/llvm/llvm-project/pull/90495
_
@@ -169,6 +169,9 @@ void riscv::getRISCVTargetFeatures(const Driver &D, const
llvm::Triple &Triple,
Features.push_back("-relax");
}
+ if (!Args.hasArg(options::OPT_menable_experimental_extensions))
+Features.push_back("+no-experimental-ext");
toppe
https://github.com/topperc edited
https://github.com/llvm/llvm-project/pull/89727
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jkorous-apple edited
https://github.com/llvm/llvm-project/pull/89553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,72 @@
+set(CMAKE_C_COMPILER "/usr/bin/cc")
jkorous-apple wrote:
Why does this PR touch any CMake files? Is it necessary for the intended change
of behavior of one or two AST matchers?
https://github.com/llvm/llvm-project/pull/89553
__
@@ -0,0 +1,72 @@
+set(CMAKE_C_COMPILER "/usr/bin/cc")
jkorous-apple wrote:
Also, why are we adding binaries?
https://github.com/llvm/llvm-project/pull/89553
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https
@@ -0,0 +1,5 @@
+Script started on 2024-04-27 13:50:15+05:30 [TERM="xterm-256color"
TTY="/dev/pts/0" COLUMNS="100" LINES="18"]
jkorous-apple wrote:
Please clean up the PR so it doesn't contain files that shouldn't be merged.
https://github.com/llvm/llvm-project
@@ -22,7 +22,7 @@ namespace clang::tidy::abseil {
// - Make it work in macros if the outer and inner StrCats are both in the
//argument.
-void RedundantStrcatCallsCheck::registerMatchers(MatchFinder* Finder) {
+void RedundantStrcatCallsCheck::registerMatchers(MatchFinder
https://github.com/jkorous-apple requested changes to this pull request.
Please start with removing all files that shouldn't be part of the PR.
Then please remove changes that affect only format/whitespace.
https://github.com/llvm/llvm-project/pull/89553
_
301 - 400 of 487 matches
Mail list logo
