https://github.com/ChuanqiXu9 commented:
Big thanks!
I left some comments about correctness or clearness. And all other change looks
good to me.
https://github.com/llvm/llvm-project/pull/90237
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
@@ -738,22 +736,21 @@ the following style significantly:
import M;
... // use declarations from module M.
-The key part of the tip is to reduce the duplications from the text includes.
+Reducing the duplication from textual includes is what improves compile-time
+performan
@@ -8,79 +8,60 @@ Standard C++ Modules
Introduction
-The term ``modules`` has a lot of meanings. For the users of Clang, modules may
-refer to ``Objective-C Modules``, ``Clang C++ Modules`` (or ``Clang Header
Modules``,
-etc.) or ``Standard C++ Modules``. The imp
@@ -577,15 +574,16 @@ the generated BMI specified by ``-o`` will be full BMI
and the BMI specified by
-> ...
-> consumer_n.cpp
-We don't emit diagnostics if ``-fexperimental-modules-
@@ -530,43 +527,43 @@ Now the linkage name of ``NS::foo()`` will be
``_ZN2NS3fooEv``.
Module Initializers
~~~
-All the importable module units are required to emit an initializer function.
-The initializer function should contain calls to importing modules fir
https://github.com/nicovank updated
https://github.com/llvm/llvm-project/pull/89490
>From 129187f336bf6351dae4604d690809f4095a2e7e Mon Sep 17 00:00:00 2001
From: Nicolas van Kempen
Date: Sat, 20 Apr 2024 02:58:25 +
Subject: [PATCH] [run-clang-tidy.py] Refactor, add progress indicator, add
https://github.com/wangpc-pp edited
https://github.com/llvm/llvm-project/pull/84877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/wangpc-pp updated
https://github.com/llvm/llvm-project/pull/84877
>From ec68548a470d6d9032a900a725e95b92691657b2 Mon Sep 17 00:00:00 2001
From: Wang Pengcheng
Date: Tue, 12 Mar 2024 14:28:09 +0800
Subject: [PATCH 1/7] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?=
=
https://github.com/wangpc-pp closed
https://github.com/llvm/llvm-project/pull/84877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
wangpc-pp wrote:
I don't know why spr added so many reviewers... sorry for bothering.
https://github.com/llvm/llvm-project/pull/84877
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/wangpc-pp created
https://github.com/llvm/llvm-project/pull/90373
Since C++14 has been released for about nine years and most standard
libraries have implemented sized deallocation functions, it's time to
make this feature default again.
This is another try of https://reviews
llvmbot wrote:
@llvm/pr-subscribers-coroutines
@llvm/pr-subscribers-libcxx
Author: Pengcheng Wang (wangpc-pp)
Changes
Since C++14 has been released for about nine years and most standard
libraries have implemented sized deallocation functions, it's time to
make this feature default again.
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Pengcheng Wang (wangpc-pp)
Changes
Since C++14 has been released for about nine years and most standard
libraries have implemented sized deallocation functions, it's time to
make this feature default again.
This is another try of http
wangpc-pp wrote:
@dyung Can you help me to comfirm whether the Windows builder is passing now? I
don't have such environment. Thanks in advance!
https://github.com/llvm/llvm-project/pull/90373
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
https://github.com/mizvekov updated
https://github.com/llvm/llvm-project/pull/89807
>From 4ee58efa0f154b531dcc674b6f4fe084182aa803 Mon Sep 17 00:00:00 2001
From: Matheus Izvekov
Date: Tue, 9 Apr 2024 01:14:28 -0300
Subject: [PATCH] [clang] Enable C++17 relaxed template template argument
matchi
dyung wrote:
> @dyung Can you help me to comfirm whether the Windows builder is passing now?
> I don't have such environment. Thanks in advance!
Sure, I'll try it on our internal builder and see if it passes and let you know
the result.
https://github.com/llvm/llvm-project/pull/90373
mizvekov wrote:
> @mizvekov We have a bunch of related issues, could you look at them
> https://github.com/llvm/llvm-project/issues?q=is%3Aissue+is%3Aopen+%22-frelaxed-template-template-args%22
> ?
Removed a bunch of duplicates. 4 issues remaining:
1) #36505 Is the issue we are fixing in this
https://github.com/mizvekov edited
https://github.com/llvm/llvm-project/pull/89807
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/90195
>From f708694fc2686684589dca7b8f3738a117fc047e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 26 Apr 2024 19:06:57 +0800
Subject: [PATCH 1/3] [Sema] Avoid an undesired pack expansion while
transforming P
@@ -160,3 +160,22 @@ namespace GH88929 {
using E = P...[0]; // expected-error {{unknown type name 'P'}} \
// expected-error {{expected ';' after alias
declaration}}
}
+
+namespace GH88925 {
+template struct S {};
+
+template struct sequence {};
+
+
https://github.com/zyn0217 updated
https://github.com/llvm/llvm-project/pull/90195
>From f708694fc2686684589dca7b8f3738a117fc047e Mon Sep 17 00:00:00 2001
From: Younan Zhang
Date: Fri, 26 Apr 2024 19:06:57 +0800
Subject: [PATCH 1/3] [Sema] Avoid an undesired pack expansion while
transforming P
https://github.com/zyn0217 edited
https://github.com/llvm/llvm-project/pull/90195
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jcsxky created
https://github.com/llvm/llvm-project/pull/90376
Fix https://github.com/llvm/llvm-project/issues/68885
When build expression from a deduced argument whose kind is `Declaration` and
`NTTPType`(which declared as `decltype(auto)`) is deduced as a reference type,
`
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Qizhi Hu (jcsxky)
Changes
Fix https://github.com/llvm/llvm-project/issues/68885
When build expression from a deduced argument whose kind is `Declaration` and
`NTTPType`(which declared as `decltype(auto)`) is deduced as a reference type,
`
https://github.com/karka228 created
https://github.com/llvm/llvm-project/pull/90377
This is a fix for the issue #87758 where fast-math flags are not propagated all
builtins.
It seems like pragmas with fast math flags was only propagated to calls of
unary floating point builtins. This patch pr
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Karl-Johan Karlsson (karka228)
Changes
This is a fix for the issue #87758 where fast-math flags are not
propagated all builtins.
It seems like pragmas with fast math flags was only propagated to calls of
unary floating point builtins. Th
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/90378
Fixes #47333.
Fixes #47624.
Fixes #75929.
Fixes #87885.
Fixes #89916.
>From d671f32e9bcc6e42e53ddd1799eb0fdef774c142 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Sat, 27 Apr 2024 23:34:45 -0700
Subject: [PATCH]
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Fixes #47333.
Fixes #47624.
Fixes #75929.
Fixes #87885.
Fixes #89916.
---
Full diff: https://github.com/llvm/llvm-project/pull/90378.diff
2 Files Affected:
- (modified) clang/lib/Format/WhitespaceManager
101 - 128 of 128 matches
Mail list logo