@@ -657,17 +658,22 @@ class TransferVisitor : public
ConstStmtVisitor {
}
void VisitConditionalOperator(const ConditionalOperator *S) {
-// FIXME: Revisit this once flow conditions are added to the framework. For
-// `a = b ? c : d` we can add `b => a == c && !b =
https://github.com/martinboehme updated
https://github.com/llvm/llvm-project/pull/89213
>From e6f729dff29cb74ca0599ba486561d04963c1ac5 Mon Sep 17 00:00:00 2001
From: Martin Braenne
Date: Thu, 18 Apr 2024 10:50:40 +
Subject: [PATCH 1/4] [clang][dataflow] Model conditional operator correctly.
kito-cheng wrote:
> Oh, I forgot to remove them. Or do you think they should be moved to bfloat
> folder to make them consistent?
Remove files from this PR, that should be a separated NFC PR for moving those
files, but I am fine to keep those file in same place :)
https://github.com/llvm/llvm
https://github.com/martinboehme closed
https://github.com/llvm/llvm-project/pull/89213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: martinboehme
Date: 2024-04-22T09:23:13+02:00
New Revision: abb958f1610becc0a753ad8f4308a90f85e1338f
URL:
https://github.com/llvm/llvm-project/commit/abb958f1610becc0a753ad8f4308a90f85e1338f
DIFF:
https://github.com/llvm/llvm-project/commit/abb958f1610becc0a753ad8f4308a90f85e1338f.diff
martinboehme wrote:
This is causing buildbot failures. Reverting.
https://github.com/llvm/llvm-project/pull/89213
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/martinboehme created
https://github.com/llvm/llvm-project/pull/89577
Reverts llvm/llvm-project#89213
This is causing buildbot failures.
>From b0456501b10a3a83e6e6818a050f3fd691972d79 Mon Sep 17 00:00:00 2001
From: martinboehme
Date: Mon, 22 Apr 2024 09:35:06 +0200
Subject:
https://github.com/martinboehme closed
https://github.com/llvm/llvm-project/pull/89577
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: martinboehme
Date: 2024-04-22T09:35:29+02:00
New Revision: 8ff6434546bcb4602bd079f4161f746956905c60
URL:
https://github.com/llvm/llvm-project/commit/8ff6434546bcb4602bd079f4161f746956905c60
DIFF:
https://github.com/llvm/llvm-project/commit/8ff6434546bcb4602bd079f4161f746956905c60.diff
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (martinboehme)
Changes
Reverts llvm/llvm-project#89213
This is causing buildbot failures.
---
Full diff: https://github.com/llvm/llvm-project/pull/89577.diff
7 Files Affected:
- (modified) clang/include/clang/Analysis/FlowSensitiv
hokein wrote:
> This seems to have broken the bot: #89476 (you should have had an email?)
>
> I reverted in #89476
sorry, and thanks for the revert. I will take a further look.
https://github.com/llvm/llvm-project/pull/89378
___
cfe-commits mailing
https://github.com/jeanPerier approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/89418
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ealcdan wrote:
ping :)
https://github.com/llvm/llvm-project/pull/85060
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
arsenm wrote:
For AMDGPU 64 is probably right
https://github.com/llvm/llvm-project/pull/89446
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Timm Bäder
Date: 2024-04-22T10:04:09+02:00
New Revision: eef5798844a6ed489c28b37113f3bcaafd1d6e68
URL:
https://github.com/llvm/llvm-project/commit/eef5798844a6ed489c28b37113f3bcaafd1d6e68
DIFF:
https://github.com/llvm/llvm-project/commit/eef5798844a6ed489c28b37113f3bcaafd1d6e68.diff
LO
Author: Haojian Wu
Date: 2024-04-22T10:04:55+02:00
New Revision: 57c24eb0a7482ca7f661a2a9cb45249f1553d6d2
URL:
https://github.com/llvm/llvm-project/commit/57c24eb0a7482ca7f661a2a9cb45249f1553d6d2
DIFF:
https://github.com/llvm/llvm-project/commit/57c24eb0a7482ca7f661a2a9cb45249f1553d6d2.diff
LO
https://github.com/weliveindetail updated
https://github.com/llvm/llvm-project/pull/84758
From 7ee5d29f69daf626a4fdc2fced802fe7e881f31e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Sun, 10 Mar 2024 18:17:48 +0100
Subject: [PATCH 1/2] [clang-repl] Set up executor implic
https://github.com/balazske updated
https://github.com/llvm/llvm-project/pull/89247
From 7138f026e845ebb4f1a3e6a86bdeb534d666ae7a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bal=C3=A1zs=20K=C3=A9ri?=
Date: Thu, 18 Apr 2024 16:40:03 +0200
Subject: [PATCH 1/4] [clang][analyzer] Move StreamChecker ou
martinboehme wrote:
Postmortem reveals that I inadvertently had my build configured with
`-DCMAKE_BUILD_TYPE=Release`.
https://github.com/llvm/llvm-project/pull/89577
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
https://github.com/sebastianpoeplau updated
https://github.com/llvm/llvm-project/pull/72400
>From cc15f9bb8b37fb1b68bd33241ab37e98d57d274c Mon Sep 17 00:00:00 2001
From: Matthieu Eyraud
Date: Mon, 11 Apr 2022 16:53:24 +0200
Subject: [PATCH] [libclang] Compute the right spelling location
Locati
@@ -1292,6 +1292,31 @@ void func() {}
EXPECT_EQ(attrCount, 1);
}
+TEST_F(LibclangParseTest, clang_getSpellingLocation) {
+ std::string fileName = "main.c";
+ WriteFile(fileName, "#define X(value) int x = value;\nX(42)\n");
+
+ ClangTU = clang_parseTranslationUnit(Index, f
Khao7342 wrote:
> Has KunMingHu's RTL been finalized (IIRC, we have vector unit under
> development)? And can we have different doc for different generations of
> XiangShan?
Thanks for your attention to Xiangshan. KunMingHu's RTL has not been finalized
yet. The development work on vectors is
Khao7342 wrote:
> Has the target architecture been finalized? (As in what it should be, not
> necessarily the rtl)
>
> Just yesterday, there was a significant change in vector execution units:
>
> [before](https://github.com/OpenXiangShan/XiangShan/blob/e25e4d90505c592524b410b127fe611ac49a3adf
Author: Timm Bäder
Date: 2024-04-22T10:32:31+02:00
New Revision: 6195e228eb2a7085fac53603f534d2401ab1ac39
URL:
https://github.com/llvm/llvm-project/commit/6195e228eb2a7085fac53603f534d2401ab1ac39
DIFF:
https://github.com/llvm/llvm-project/commit/6195e228eb2a7085fac53603f534d2401ab1ac39.diff
LO
Author: Timm Bäder
Date: 2024-04-22T10:34:43+02:00
New Revision: 0ff992e5f210fdcbfdd1dcc3687c9aeabde318c3
URL:
https://github.com/llvm/llvm-project/commit/0ff992e5f210fdcbfdd1dcc3687c9aeabde318c3
DIFF:
https://github.com/llvm/llvm-project/commit/0ff992e5f210fdcbfdd1dcc3687c9aeabde318c3.diff
LO
@@ -378,3 +378,30 @@ def XIANGSHAN_NANHU :
RISCVProcessorModel<"xiangshan-nanhu",
TuneZExtHFusion,
TuneZExtWFusion,
TuneShiftedZExtWFusion]>;
+de
Author: Timm Bäder
Date: 2024-04-22T10:35:45+02:00
New Revision: 6b6c7e46cc1e97b678e969bad78825dd02c11ff9
URL:
https://github.com/llvm/llvm-project/commit/6b6c7e46cc1e97b678e969bad78825dd02c11ff9
DIFF:
https://github.com/llvm/llvm-project/commit/6b6c7e46cc1e97b678e969bad78825dd02c11ff9.diff
LO
cor3ntin wrote:
I think the change makes sense.
Can you add a release note?
https://github.com/llvm/llvm-project/pull/89565
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vvd170501 wrote:
Ping.
@PiotrZSL, I've added the changes you requested (except
`matchesAnyListedName`), waiting for your feedback
https://github.com/llvm/llvm-project/pull/88636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llv
Author: Fraser Cormack
Date: 2024-04-22T09:50:39+01:00
New Revision: e614e037f371e92499e19ada730f61e77d640780
URL:
https://github.com/llvm/llvm-project/commit/e614e037f371e92499e19ada730f61e77d640780
DIFF:
https://github.com/llvm/llvm-project/commit/e614e037f371e92499e19ada730f61e77d640780.diff
https://github.com/frasercrmck closed
https://github.com/llvm/llvm-project/pull/89147
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -39,6 +39,10 @@ function(compile_to_bc)
set( TARGET_ARG "-target" ${ARG_TRIPLE} )
endif()
+ # Ensure the directory we are told to output to exists
+ get_filename_component( ARG_OUTPUT_DIR ${ARG_OUTPUT} DIRECTORY )
frasercrmck wrote:
Yeah, there ver
@@ -0,0 +1,194 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 4
+// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -target-feature +fullbf16
-S -emit-llvm %s -o - | FileCheck %s
+// CHECK-LABEL: define dso_local half @test
@@ -0,0 +1,194 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 4
+// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -target-feature +fullbf16
-S -emit-llvm %s -o - | FileCheck %s
+// CHECK-LABEL: define dso_local half @test
@@ -0,0 +1,194 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 4
+// RUN: %clang_cc1 -triple x86_64-unknown-linux-gnu -target-feature +fullbf16
-S -emit-llvm %s -o - | FileCheck %s
+// CHECK-LABEL: define dso_local half @test
Author: Timm Bäder
Date: 2024-04-22T10:58:55+02:00
New Revision: c2d665b7aeb68f3e8e643ee9dfe5bb7dd31137e5
URL:
https://github.com/llvm/llvm-project/commit/c2d665b7aeb68f3e8e643ee9dfe5bb7dd31137e5
DIFF:
https://github.com/llvm/llvm-project/commit/c2d665b7aeb68f3e8e643ee9dfe5bb7dd31137e5.diff
LO
https://github.com/Meinersbur ready_for_review
https://github.com/llvm/llvm-project/pull/88948
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Michael Kruse (Meinersbur)
Changes
Plugins are not loaded without the -cc1 phase. Do not report them when running
on an assembly file or when linking. Many build tools add these options to all
driver invocations, including LLVM's b
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Michael Kruse (Meinersbur)
Changes
Plugins are not loaded without the -cc1 phase. Do not report them when running
on an assembly file or when linking. Many build tools add these options to all
driver invocations, including LLVM's build sy
Author: Matt Arsenault
Date: 2024-04-22T11:35:09+02:00
New Revision: bd84f5d5d71ee26d9552a9cd96ef058cfb8a39fc
URL:
https://github.com/llvm/llvm-project/commit/bd84f5d5d71ee26d9552a9cd96ef058cfb8a39fc
DIFF:
https://github.com/llvm/llvm-project/commit/bd84f5d5d71ee26d9552a9cd96ef058cfb8a39fc.diff
Meinersbur wrote:
> IIRC it was unnecessary for the documentation because it gets built multiple
> times, for the driver it's built once so it has to include all possible
> variants the first time.
>
> I have no preference for how it's done, if the `%Program` thing works then
> fine. We only
Author: Michael Kruse
Date: 2024-04-22T11:56:19+02:00
New Revision: fdc8c5440041ac53726d0b3587762ceeb8cbbb4f
URL:
https://github.com/llvm/llvm-project/commit/fdc8c5440041ac53726d0b3587762ceeb8cbbb4f
DIFF:
https://github.com/llvm/llvm-project/commit/fdc8c5440041ac53726d0b3587762ceeb8cbbb4f.diff
https://github.com/Meinersbur closed
https://github.com/llvm/llvm-project/pull/88932
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL approved this pull request.
- One code duplication that could be avoided.
- Add entry in release notes, about fixing issue with big unsigned config
option values printed as negative numbers in --dump-config
Overall, fine.
As for misc-throw-by-value-catch-by-reference
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/85060
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -422,7 +425,10 @@ class ClangTidyCheck : public
ast_matchers::MatchFinder::MatchCallback {
store(ClangTidyOptions::OptionMap &Options, StringRef LocalName,
std::optional Value) const {
if (Value)
-storeInt(Options, LocalName, *Value);
+if
https://github.com/PiotrZSL approved this pull request.
Looks fine for me.
https://github.com/llvm/llvm-project/pull/88636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -7,42 +7,70 @@
//===--===//
#include "StringCompareCheck.h"
-#include "../utils/FixItHintUtils.h"
+#include "../utils/OptionsUtils.h"
#include "clang/AST/ASTContext.h"
#include "clang/ASTMatchers/ASTMatc
https://github.com/ealcdan updated
https://github.com/llvm/llvm-project/pull/85060
>From 20f7b3172c6735e8dbdda24ffde7ee8ecd7c7404 Mon Sep 17 00:00:00 2001
From: Daniel Alcaide Nombela
Date: Wed, 13 Mar 2024 11:28:34 +0100
Subject: [PATCH] [clang-tidy] Avoid overflow when dumping unsigned intege
https://github.com/ealcdan updated
https://github.com/llvm/llvm-project/pull/85060
>From afe6658e869646730a18c52e18f5cb4675d67a6b Mon Sep 17 00:00:00 2001
From: Daniel Alcaide Nombela
Date: Wed, 13 Mar 2024 11:28:34 +0100
Subject: [PATCH] [clang-tidy] Avoid overflow when dumping unsigned intege
ealcdan wrote:
Great, both points have been addressed in the new patches, hope the release
notes entry is clear enough.
https://github.com/llvm/llvm-project/pull/85060
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-
https://github.com/yronglin approved this pull request.
https://github.com/llvm/llvm-project/pull/89567
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh wrote:
Thanks for the prompt fix!
https://github.com/llvm/llvm-project/pull/88666
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/88528
>From 0c9372749f4b2d52deddea82be4e77524a66a348 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Fri, 12 Apr 2024 17:36:53 +0200
Subject: [PATCH] [Clang] Fix __is_trivially_equaltiy_comparable documentation
yronglin wrote:
Friendly ping! @zygoloid @hubert-reinterpretcast
https://github.com/llvm/llvm-project/pull/87933
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
yronglin wrote:
Friendly ping~
https://github.com/llvm/llvm-project/pull/88602
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
abidh wrote:
I am going to merge this. There is bot failure (trailing whitespace in
clang/lib/Serialization/ASTWriter.cpp) which seems unrelated to this PR.
https://github.com/llvm/llvm-project/pull/89418
___
cfe-commits mailing list
cfe-commits@list
Author: abidh
Date: 2024-04-22T11:19:05+01:00
New Revision: 087b33bbff1ab966656a81f9dd8e136fbd966f58
URL:
https://github.com/llvm/llvm-project/commit/087b33bbff1ab966656a81f9dd8e136fbd966f58
DIFF:
https://github.com/llvm/llvm-project/commit/087b33bbff1ab966656a81f9dd8e136fbd966f58.diff
LOG: [f
https://github.com/abidh closed https://github.com/llvm/llvm-project/pull/89418
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,34 @@
+//===--- ReturnConstRefFromParameterCheck.cpp - clang-tidy
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/HerrCai0907 updated
https://github.com/llvm/llvm-project/pull/89497
>From 91915f68902ade86c0bf8eba643428017ae8bb3c Mon Sep 17 00:00:00 2001
From: Congcong Cai
Date: Sat, 20 Apr 2024 17:58:19 +0800
Subject: [PATCH 1/5] [tidy] add new check
bugprone-return-const-ref-from-param
@@ -0,0 +1,34 @@
+//===--- ReturnConstRefFromParameterCheck.cpp - clang-tidy
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/HerrCai0907 edited
https://github.com/llvm/llvm-project/pull/89497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
martinboehme wrote:
Needed to revert this because it turns out that, embarrassingly, I was locally
running my tests in `Release` mode, i.e. with `assert()` disabled. I'm working
on a PR to re-land this that fixes the assertion failures that were occurring.
https://github.com/llvm/llvm-project/
@@ -251,6 +251,9 @@ Miscellaneous
option is specified. Now ``clang-apply-replacements`` applies formatting
only with
the option.
+- Fixed bug where big values for unsigned check options overflowed into
negative values
+ when being printed with ``--dump-config``.
---
https://github.com/PiotrZSL approved this pull request.
https://github.com/llvm/llvm-project/pull/85060
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/hokein updated
https://github.com/llvm/llvm-project/pull/89358
>From 9583811bfa66ff058f5e33012cd77501ce3e5e23 Mon Sep 17 00:00:00 2001
From: Haojian Wu
Date: Fri, 19 Apr 2024 10:54:12 +0200
Subject: [PATCH 1/2] [clang] CTAD: implement the missing IsDeducible
constraint for a
@@ -3207,6 +3241,59 @@
Sema::DeduceTemplateArguments(VarTemplatePartialSpecializationDecl *Partial,
return ::DeduceTemplateArguments(*this, Partial, TemplateArgs, Info);
}
+TemplateDeductionResult
+Sema::DeduceTemplateArgumentsFromType(TemplateDecl *TD, QualType FromType,
+
@@ -6100,6 +6100,17 @@ static bool EvaluateBinaryTypeTrait(Sema &Self,
TypeTrait BTT, const TypeSourceI
tok::kw___is_pointer_interconvertible_base_of);
return Self.IsPointerInterconvertibleBaseOf(Lhs, Rhs);
+ }
+ case BTT_IsDeducible: {
+
hokein wrote:
> Needs a release note, and I think we actually DO have to do those diagnostics
> here.
Added a release note for the new builtin.
https://github.com/llvm/llvm-project/pull/89358
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
h
https://github.com/OCHyams created
https://github.com/llvm/llvm-project/pull/89594
DW_TAG_template_alias DIEs were added in DWARFv4, not DWARFv5
>From 95c86b499e1eebb15dbd61f839f5fefa83dc910d Mon Sep 17 00:00:00 2001
From: Orlando Cazalet-Hyams
Date: Mon, 22 Apr 2024 11:48:19 +0100
Subject: [P
llvmbot wrote:
@llvm/pr-subscribers-clang-driver
Author: Orlando Cazalet-Hyams (OCHyams)
Changes
DW_TAG_template_alias DIEs were added in DWARFv4, not DWARFv5
---
Full diff: https://github.com/llvm/llvm-project/pull/89594.diff
2 Files Affected:
- (modified) clang/lib/Driver/ToolChains/
https://github.com/ealcdan updated
https://github.com/llvm/llvm-project/pull/85060
>From 07248879092c0e752811b4c33b98c50d42230d14 Mon Sep 17 00:00:00 2001
From: Daniel Alcaide Nombela
Date: Wed, 13 Mar 2024 11:28:34 +0100
Subject: [PATCH] [clang-tidy] Avoid overflow when dumping unsigned intege
https://github.com/Michael137 approved this pull request.
https://github.com/llvm/llvm-project/pull/89594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
alexfh wrote:
Hi Jan, we started seeing a compilation error in a (quite unusual, frankly
speaking) code:
```
pigweed/pw_rpc/public/pw_rpc/internal/channel_list.h:24:10: fatal error:
'vector' file not found
24 | #include PW_RPC_DYNAMIC_CONTAINER_INCLUDE
| ^~
Author: Orlando Cazalet-Hyams
Date: 2024-04-22T12:01:21+01:00
New Revision: 093171b053838020a30c7710015c56c88d51c7ef
URL:
https://github.com/llvm/llvm-project/commit/093171b053838020a30c7710015c56c88d51c7ef
DIFF:
https://github.com/llvm/llvm-project/commit/093171b053838020a30c7710015c56c88d51c7
https://github.com/OCHyams closed
https://github.com/llvm/llvm-project/pull/89594
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/martinboehme created
https://github.com/llvm/llvm-project/pull/89596
- **Reapply "[clang][dataflow] Model conditional operator correctly." (#89577)**
- **Fix failing tests for `TransferVisitor::VisitConditionalOperator().`**
>From db32339492774cad8a6ceeb86ca8e13e6fef8c2a Mon
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (martinboehme)
Changes
- **Reapply "[clang][dataflow] Model conditional operator correctly." (#89577)**
- **Fix failing tests for `TransferVisitor::VisitConditionalOperator().`**
---
Full diff: https://github.com/llvm/llvm-project/pu
https://github.com/martinboehme edited
https://github.com/llvm/llvm-project/pull/89596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
martinboehme wrote:
I reverted https://github.com/llvm/llvm-project/pull/89213 beause it was
causing buildbots to fail with assertion failures.
Embarrassingly, it turns out I had been running tests locally in `Release`
mode, i.e. with `assert()` compiled away.
This PR re-lands #89213 with fix
https://github.com/martinboehme edited
https://github.com/llvm/llvm-project/pull/89596
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2554,16 +2554,26 @@ Decl *Parser::ParseDeclarationAfterDeclarator(
return ParseDeclarationAfterDeclaratorAndAttributes(D, TemplateInfo);
}
+static bool isConstexprVariable(const Decl *D) {
+ if (const VarDecl *Var = dyn_cast_or_null(D))
+return Var->isConstexpr();
+
@@ -2554,16 +2554,26 @@ Decl *Parser::ParseDeclarationAfterDeclarator(
return ParseDeclarationAfterDeclaratorAndAttributes(D, TemplateInfo);
}
+static bool isConstexprVariable(const Decl *D) {
+ if (const VarDecl *Var = dyn_cast_or_null(D))
cor3ntin wrote:
@@ -1032,17 +1043,15 @@ int f() {
namespace GH57682 {
void test() {
- constexpr auto l1 = []() consteval { // expected-error {{cannot take address
of consteval call operator of '(lambda at}} \
- // expected-note 2{{declared here}}
+ co
TIFitis wrote:
> This patch is huge, and just skimming over it shows various places that could
> be split off, and others that should not make it to the review stage
> (commented out code). Please update.
Hi, thanks for talking the time out to review the patch.
I've addressed the comments you
cor3ntin wrote:
> Regarding the __is_deducible type trait, GCC also provides one, but it was
> hidden from users and only used for internal CTAD implementation. I'm not
> sure if we should follow the same strategy in clang, ideas?
I have mixed feeling. What do you think @AaronBallman ?
https:
@@ -5,13 +5,18 @@
// RUN: %clang -target arm-arm-none-eabi -march=armv8.1-m.main -S -emit-llvm
-o - -mbranch-protection=pac-ret+b-key %s | FileCheck %s --check-prefix=CHECK
--check-prefix=PART
// RUN: %clang -target arm-arm-none-eabi -march=armv8.1-m.main -S -emit-llvm
-o - -
https://github.com/aniplcc ready_for_review
https://github.com/llvm/llvm-project/pull/89551
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: aniplcc (aniplcc)
Changes
Closes #89192.
Also updated with review patches.
In continuation of: `https://github.com/llvm/llvm-project/pull/89202` [Closed
due to a bad rebase]
---
Full diff: https://github.com/llvm/llvm-project/pull/89551
@@ -4822,6 +4822,111 @@ static MachineBasicBlock *lowerWaveReduce(MachineInstr
&MI,
return RetBB;
}
+static MachineBasicBlock *lowerPseudoLaneOp(MachineInstr &MI,
vikramRH wrote:
@arsenm, would "PreISelIntrinsicLowering" be a proper place for this ?
https
AaronBallman wrote:
> @AaronBallman Did you read
> https://discourse.llvm.org/t/rfc-c-17-hardware-constructive-destructive-interference-size/48674/42
> ? I want to make sure we do abide by it and it's unclear a consensus was
> ever formed or called
Yes, I looked at the thread and while there
AaronBallman wrote:
> Sorry, I know nothing about it. But it looks to me it's to match with GCC,
> why don't borrow the value from GCC as a beginning?
Because the values depend on the target and the compiler options picked. I
don't have that information myself, and given how many targets and o
https://github.com/sdkrystian updated
https://github.com/llvm/llvm-project/pull/88731
>From 9b54d77ef690a69b94ab2985f62fa1a281259796 Mon Sep 17 00:00:00 2001
From: Krystian Stasiowski
Date: Mon, 15 Apr 2024 09:17:39 -0400
Subject: [PATCH 1/5] Reapply "[Clang][Sema] Fix crash when 'this' is used
hokein wrote:
> It seems to me that exposing these as children is the better option here,
> right? That way it would better model a CallExpr or template type-trait, and
> would work in our StmtProfiler et-al.
Agree that exposing them as children is better. However, we encounter an
implementat
AaronBallman wrote:
> For SystemZ the correct value is 256.
Thanks! Double-checking: for both constructive and destructive?
> In general I agree it makes sense to look at the GCC implementation as a
> source of reasonable values. Also, I think there probably should be no
> generic default val
https://github.com/RKSimon approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/89551
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
martinboehme wrote:
First of all, a followup: I should of course have noticed the failling CI
tests, but a contributing factor was that I was locally running tests in
`Release` mode, i.e. with `assert()` compiled out.
I've now looked at why tests fail, and it is because when using
`E->getStmt
=?utf-8?q?Balázs_Kéri?= ,
=?utf-8?q?Balázs_Kéri?= ,
=?utf-8?q?Balázs_Kéri?=
Message-ID:
In-Reply-To:
https://github.com/NagyDonat edited
https://github.com/llvm/llvm-project/pull/89247
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://l
=?utf-8?q?Balázs_Kéri?= ,
=?utf-8?q?Balázs_Kéri?= ,
=?utf-8?q?Balázs_Kéri?=
Message-ID:
In-Reply-To:
https://github.com/NagyDonat approved this pull request.
LGTM, the diff is clean and the results on open source projects are good enough
for a non-alpha checker.
Note that the direct codeche
1 - 100 of 478 matches
Mail list logo
