Author: Fangrui Song
Date: 2024-04-16T11:49:25-07:00
New Revision: 0665669876cd7f51f7572cff3bb97485d78f5de5
URL:
https://github.com/llvm/llvm-project/commit/0665669876cd7f51f7572cff3bb97485d78f5de5
DIFF:
https://github.com/llvm/llvm-project/commit/0665669876cd7f51f7572cff3bb97485d78f5de5.diff
@@ -1,5 +1,5 @@
-// RUN: %clang -S -fno-discard-value-names -emit-llvm -o - %s | FileCheck %s
-// Issue no: 41441
+// RUN: %clang --target=x86_64-pc-linux -S -fno-discard-value-names -emit-llvm
-o - %s | FileCheck %s
+
#include
dyung wrote:
It does:
https://l
https://github.com/sdkrystian created
https://github.com/llvm/llvm-project/pull/88963
Consider the following snippet from the discussion of
[CWG2847](https://cplusplus.github.io/CWG/issues/2847.html) on the [core
reflector](https://lists.isocpp.org/core/2024/04/15720.php) ([godbolt
link](http
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Krystian Stasiowski (sdkrystian)
Changes
Consider the following snippet from the discussion of
[CWG2847](https://cplusplus.github.io/CWG/issues/2847.html) on the [core
reflector](https://lists.isocpp.org/core/2024/04/15720.php) ([godbolt
david-xl wrote:
Is there a need for a small test case?
https://github.com/llvm/llvm-project/pull/88793
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -1,5 +1,5 @@
-// RUN: %clang -S -fno-discard-value-names -emit-llvm -o - %s | FileCheck %s
-// Issue no: 41441
+// RUN: %clang --target=x86_64-pc-linux -S -fno-discard-value-names -emit-llvm
-o - %s | FileCheck %s
+
#include
erichkeane wrote:
Blarg, the bui
https://github.com/sdkrystian edited
https://github.com/llvm/llvm-project/pull/88963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/erichkeane commented:
Approach/fix looks fine, other than release notes + tests, LGTM.
https://github.com/llvm/llvm-project/pull/88963
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
bogner wrote:
> a) Thanks!; b) apologies for the noise; c) this was actually done on purpose,
> I actively eschewed changing Logical SPIRV because it wasn't actually clear
> to me if in the long run it'd have the same AS map / would use numerical 1
> for globals. If Logical SPIRV is going to g
Author: Justin Bogner
Date: 2024-04-16T12:09:32-07:00
New Revision: b0ddbfb77d15e00e08fc36f6ccd8a4fecde465d1
URL:
https://github.com/llvm/llvm-project/commit/b0ddbfb77d15e00e08fc36f6ccd8a4fecde465d1
DIFF:
https://github.com/llvm/llvm-project/commit/b0ddbfb77d15e00e08fc36f6ccd8a4fecde465d1.diff
https://github.com/bogner closed https://github.com/llvm/llvm-project/pull/88939
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/labrinea created
https://github.com/llvm/llvm-project/pull/88965
As explained in https://github.com/ARM-software/acle/pull/315 we are
deprecating features which aren't adding any value.
>From 9c2dc3240d79e4a05015bcc60a300e94971ae983 Mon Sep 17 00:00:00 2001
From: Alexandros
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Alexandros Lamprineas (labrinea)
Changes
As explained in https://github.com/ARM-software/acle/pull/315 we are
deprecating features which aren't adding any value.
---
Patch is 105.51 KiB, truncated to 20.00 KiB below, full version:
https
labrinea wrote:
In a follow up patch I will be sorting out inconsistencies in TargetParser
regarding:
* features without corresponding ArchExtKind
* features without (Neg)Feature string
* features with incorrect DependentFeatures string
https://github.com/llvm/llvm-project/pull/88965
__
Author: erichkeane
Date: 2024-04-16T12:13:50-07:00
New Revision: 0a789ea8a829da345e46d8224d73b2ddaba6969f
URL:
https://github.com/llvm/llvm-project/commit/0a789ea8a829da345e46d8224d73b2ddaba6969f
DIFF:
https://github.com/llvm/llvm-project/commit/0a789ea8a829da345e46d8224d73b2ddaba6969f.diff
LO
@@ -1,5 +1,5 @@
-// RUN: %clang -S -fno-discard-value-names -emit-llvm -o - %s | FileCheck %s
-// Issue no: 41441
+// RUN: %clang --target=x86_64-pc-linux -S -fno-discard-value-names -emit-llvm
-o - %s | FileCheck %s
+
#include
erichkeane wrote:
Should be good
cor3ntin wrote:
@mizvekov are you able to take a look at this? Thanks!
https://github.com/llvm/llvm-project/pull/88637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
estewart08 wrote:
> > Is it expected now that `clang --print-runtime-dir` will always have the
> > clang host triple appended even if `LLVM_ENABLE_PER_TARGET_RUNTIME_DIR` is
> > off? I guess I was expecting to see `lib/linux` instead of
> > `lib/x86_64-unknown-linux-gnu`.
>
> https://reviews.
jroelofs wrote:
Mind listing which ones are affected in the commit summary?
https://github.com/llvm/llvm-project/pull/88965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/labrinea edited
https://github.com/llvm/llvm-project/pull/88965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/labrinea updated
https://github.com/llvm/llvm-project/pull/88965
>From 22dffaef7a1f8e3cd8efdbf51536e38986d622ea Mon Sep 17 00:00:00 2001
From: Alexandros Lamprineas
Date: Tue, 16 Apr 2024 19:42:07 +0100
Subject: [PATCH] [FMV] Remove useless features according the latest ACLE
labrinea wrote:
> Mind listing which ones are affected in the commit summary?
Done
https://github.com/llvm/llvm-project/pull/88965
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/nabijaczleweli updated
https://github.com/llvm/llvm-project/pull/88673
From 05545c8cc2ef2751128f1906933151fb09e37b65 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=D0=BD=D0=B0=D0=B1?=
Date: Mon, 15 Apr 2024 03:52:50 +0200
Subject: [PATCH] Allow struct q{int q;~q();} (#88597)
---
sdkrystian wrote:
@erichkeane Perhaps the release note should go under "Attribute Changes in
Clang"?
https://github.com/llvm/llvm-project/pull/88777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinf
https://github.com/PiotrZSL approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/88843
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
erichkeane wrote:
> @erichkeane Perhaps the release note should go under "Attribute Changes in
> Clang"?
That would be fine for me as well.
https://github.com/llvm/llvm-project/pull/88777
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https:
Author: juan.vazquez
Date: 2024-04-16T12:42:59-07:00
New Revision: 13ea36db166b7007f8b1e84e0827faaf24eb448e
URL:
https://github.com/llvm/llvm-project/commit/13ea36db166b7007f8b1e84e0827faaf24eb448e
DIFF:
https://github.com/llvm/llvm-project/commit/13ea36db166b7007f8b1e84e0827faaf24eb448e.diff
https://github.com/jkorous-apple closed
https://github.com/llvm/llvm-project/pull/88406
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL approved this pull request.
https://github.com/llvm/llvm-project/pull/88912
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
@juanvazquez Congratulations on having your first Pull Request (PR) merged into
the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a bu
https://github.com/farzonl created
https://github.com/llvm/llvm-project/pull/88976
- `clang/lib/CodeGen/CGBuiltin.cpp` - switch to using `getLerpIntrinsic()` to
abstract backend intrinsic
- `clang/lib/CodeGen/CGHLSLRuntime.h` - add `getLerpIntrinsic()`
- `llvm/include/llvm/IR/IntrinsicsSPIRV.t
llvmbot wrote:
@llvm/pr-subscribers-backend-spir-v
@llvm/pr-subscribers-hlsl
@llvm/pr-subscribers-llvm-ir
Author: Farzon Lotfi (farzonl)
Changes
- `clang/lib/CodeGen/CGBuiltin.cpp` - switch to using `getLerpIntrinsic()` to
abstract backend intrinsic
- `clang/lib/CodeGen/CGHLSLRuntime.h` -
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Farzon Lotfi (farzonl)
Changes
- `clang/lib/CodeGen/CGBuiltin.cpp` - switch to using `getLerpIntrinsic()` to
abstract backend intrinsic
- `clang/lib/CodeGen/CGHLSLRuntime.h` - add `getLerpIntrinsic()`
- `llvm/include/llvm/IR/Intri
https://github.com/js324 updated https://github.com/llvm/llvm-project/pull/86586
>From c822eaf87526567825e9c4403ae9f01dd4ff58a3 Mon Sep 17 00:00:00 2001
From: Jin S
Date: Mon, 25 Mar 2024 17:19:41 -0400
Subject: [PATCH] [BitInt] Expose a _BitInt literal suffix in C++
---
clang/docs/ReleaseNote
https://github.com/artemcm created
https://github.com/llvm/llvm-project/pull/88977
A client's Clang instance may require to perform type-checking against one OS
version and compilation/code-generation against an earlier version. This change
allows such clients to configure their built-in Clang
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Artem Chikin (artemcm)
Changes
A client's Clang instance may require to perform type-checking against one OS
version and compilation/code-generation against an earlier version. This change
allows such clients to configure their built-in C
https://github.com/coopp approved this pull request.
Looks good to me.
https://github.com/llvm/llvm-project/pull/88976
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 281d71604f418eb952e967d9dc4b26241b7f96aa
c86ee8d6fc2b0d3995f0dee4e7bc206ef6e05c8b --
https://github.com/coopp commented:
Looks good
https://github.com/llvm/llvm-project/pull/88939
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/zahiraam created
https://github.com/llvm/llvm-project/pull/88978
None
>From 3acc848f4fcc68445dfc849f9c6f8d384d3692af Mon Sep 17 00:00:00 2001
From: Zahira Ammarguellat
Date: Tue, 16 Apr 2024 13:09:58 -0700
Subject: [PATCH] Adding C23 constexpr math functions fmin and frexp.
https://github.com/zahiraam edited
https://github.com/llvm/llvm-project/pull/88978
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8
Author: Noah Goldstein
Date: 2024-04-16T15:26:25-05:00
New Revision: b6bd41db31c798f3fc82368381fad6d42795f512
URL:
https://github.com/llvm/llvm-project/commit/b6bd41db31c798f3fc82368381fad6d42795f512
DIFF:
https://github.com/llvm/llvm-project/commit/b6bd41db31c798f3fc82368381fad6d42795f512.diff
https://github.com/goldsteinn closed
https://github.com/llvm/llvm-project/pull/88299
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/preames approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/88954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/benisxdxd created
https://github.com/llvm/llvm-project/pull/88981
I tried doing it like
[this](https://github.com/llvm/llvm-project/commit/fcbec02ea6fb2a76352b64790cd9ae300f6a9943)
I'm not really an expert in LLVM and such so I don't really know where to add
tests if needed
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
efriedma-quic wrote:
I don't understand the scenario you're envisioning here. If, for example,
`sizeof(long)` is different in the AST vs. CodeGen, everything will very likely
explode. And I don't want to make an open-ended commitment to support
modifying properties of the target based on wha
llvmbot wrote:
@llvm/pr-subscribers-clang
@llvm/pr-subscribers-backend-arm
Author: None (benisxdxd)
Changes
I tried doing it like
[this](https://github.com/llvm/llvm-project/commit/fcbec02ea6fb2a76352b64790cd9ae300f6a9943)
I'm not really an expert in LLVM and such so I don't really know
https://github.com/pogo59 commented:
The flag situation is good. Tuning influences the default for the new option,
which is how we want that to work.
I'm happy, a couple of nits left. I'll leave it to others to do the final
approval.
https://github.com/llvm/llvm-project/pull/87623
___
@@ -1332,6 +1332,54 @@ llvm::DIType *CGDebugInfo::CreateType(const
TemplateSpecializationType *Ty,
auto PP = getPrintingPolicy();
Ty->getTemplateName().print(OS, PP, TemplateName::Qualified::None);
+ SourceLocation Loc = AliasDecl->getLocation();
+
+ if (CGM.getCodeGenO
https://github.com/pogo59 edited https://github.com/llvm/llvm-project/pull/87623
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -465,3 +465,15 @@
// MANGLED_TEMP_NAMES: error: unknown argument
'-gsimple-template-names=mangled'; did you mean '-Xclang
-gsimple-template-names=mangled'
// RUN: %clang -### -target x86_64 -c -g %s 2>&1 | FileCheck
--check-prefix=FULL_TEMP_NAMES
--implicit-check-not=debu
@@ -310,6 +310,24 @@ namespace llvm {
DINode::DIFlags Flags = DINode::FlagZero,
DINodeArray Annotations = nullptr);
+/// Create debugging information entry for a template alias.
+/// \param Ty O
@@ -26,123 +26,132 @@ namespace clang {
class VarDecl;
class FunctionDecl;
class ImportDecl;
-
-/// ASTConsumer - This is an abstract interface that should be implemented by
-/// clients that read ASTs. This abstraction layer allows the client to be
-/// independent of t
@@ -26,123 +26,132 @@ namespace clang {
class VarDecl;
class FunctionDecl;
class ImportDecl;
-
-/// ASTConsumer - This is an abstract interface that should be implemented by
-/// clients that read ASTs. This abstraction layer allows the client to be
-/// independent of t
https://github.com/efriedma-quic approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/88910
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma-quic wrote:
I don't think this works correctly? You need to evaluate both the
getCommonExpr(), and the getSubExpr().
https://github.com/llvm/llvm-project/pull/1
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.o
Author: Hubert Tong
Date: 2024-04-16T17:26:55-04:00
New Revision: d19bd05c79ad3b1a2c3cb439c3fc60825f66bed7
URL:
https://github.com/llvm/llvm-project/commit/d19bd05c79ad3b1a2c3cb439c3fc60825f66bed7
DIFF:
https://github.com/llvm/llvm-project/commit/d19bd05c79ad3b1a2c3cb439c3fc60825f66bed7.diff
L
@@ -1332,6 +1332,54 @@ llvm::DIType *CGDebugInfo::CreateType(const
TemplateSpecializationType *Ty,
auto PP = getPrintingPolicy();
Ty->getTemplateName().print(OS, PP, TemplateName::Qualified::None);
+ SourceLocation Loc = AliasDecl->getLocation();
+
+ if (CGM.getCodeGenO
zygoloid wrote:
Have you tried changing the behavior of the existing `-fmodule-map-file=` to
load the file after we load module files? If so, what kinds of things do you
see breaking or changing? If we can avoid it, I think it would be better to
only have a single mode here, and loading the mo
ian-twilightcoder wrote:
Wall of text incoming... Sorry but our documentation in this area is poor, so I
feel like I need to spell out the assumptions behind this change.
First of all, this _should_ be a relatively minor change that should affect a
very limited set of circumstances.
1. Only `#
ian-twilightcoder wrote:
> To get back to my previous point about the semantics implemented by this
> patch being unfortunate -- the upshot is that, now:
>
> ```
> #include
> #define NDEBUG
> #import
> ```
It would be nice if we could make this work without modules too. `#pragma many`
or so
Michael137 wrote:
Btw, as a follow-up to this patch should we check that this is compatible with
dsymutil (i.e., running `dsymutil --verify`)? I suspect it might need a fixup
(given LLDB doesn't even support this tag)
https://github.com/llvm/llvm-project/pull/87623
ian-twilightcoder wrote:
+ @Bigcheese and @jansvoboda11 as I think they know this area of the code better
https://github.com/llvm/llvm-project/pull/88893
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/lis
bolshakov-a wrote:
Honestly, I'm not very familiar with code coverage technique, but it seems to
me that only explicitly written code is relevant for that. "Common expression"
is exactly the explicitly written part. "Subexpression" is an implicitly
generated per-element initializer which refer
bolshakov-a wrote:
Could you merge it please?
https://github.com/llvm/llvm-project/pull/88910
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/artemcm updated
https://github.com/llvm/llvm-project/pull/88977
>From 04e826688a504e141f3407567616bcf5cce9e2cc Mon Sep 17 00:00:00 2001
From: Artem Chikin
Date: Wed, 20 Dec 2023 10:56:42 -0800
Subject: [PATCH] [NFC] Parameterize Initialization of 'clang::CodeGenerator'
on a
@@ -67,57 +67,42 @@ enum CPUFeatures {
FEAT_FP,
FEAT_SIMD,
FEAT_CRC,
- FEAT_SHA1,
FEAT_SHA2,
FEAT_SHA3,
FEAT_AES,
- FEAT_PMULL,
FEAT_FP16,
- FEAT_DIT,
FEAT_DPB,
FEAT_DPB2,
FEAT_JSCVT,
FEAT_FCMA,
FEAT_RCPC,
FEAT_RCPC2,
FEAT_FRINTTS,
- F
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/88595
>From 29d2d19c9dea9e3f818a34c97f95bd7c93b9433b Mon Sep 17 00:00:00 2001
From: Zijun
Date: Sat, 13 Apr 2024 00:53:38 +
Subject: [PATCH 1/2] Carving out -Wformat warning about scoped enums into a
subwarni
https://github.com/nabijaczleweli updated
https://github.com/llvm/llvm-project/pull/88673
From 05545c8cc2ef2751128f1906933151fb09e37b65 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=D0=BD=D0=B0=D0=B1?=
Date: Mon, 15 Apr 2024 03:52:50 +0200
Subject: [PATCH 1/2] Allow struct q{int q;~q();} (#88597)
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/88595
>From 29d2d19c9dea9e3f818a34c97f95bd7c93b9433b Mon Sep 17 00:00:00 2001
From: Zijun
Date: Sat, 13 Apr 2024 00:53:38 +
Subject: [PATCH 1/3] Carving out -Wformat warning about scoped enums into a
subwarni
https://github.com/ZijunZhaoCCK updated
https://github.com/llvm/llvm-project/pull/88595
>From 29d2d19c9dea9e3f818a34c97f95bd7c93b9433b Mon Sep 17 00:00:00 2001
From: Zijun
Date: Sat, 13 Apr 2024 00:53:38 +
Subject: [PATCH 1/4] Carving out -Wformat warning about scoped enums into a
subwarni
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8?q?Mösch?= ,
Danny =?utf-8
@@ -1,5 +1,5 @@
-// RUN: %clang -S -fno-discard-value-names -emit-llvm -o - %s | FileCheck %s
-// Issue no: 41441
+// RUN: %clang --target=x86_64-pc-linux -S -fno-discard-value-names -emit-llvm
-o - %s | FileCheck %s
+
#include
nico wrote:
Thanks!
https://git
@@ -1403,94 +1421,146 @@ bool
HeaderSearch::isFileMultipleIncludeGuarded(FileEntryRef File) const {
void HeaderSearch::MarkFileModuleHeader(FileEntryRef FE,
ModuleMap::ModuleHeaderRole Role,
bool i
@@ -161,8 +161,13 @@ static TypeCode getTypeCodeForTypeClass(Type::TypeClass
id) {
namespace {
-std::set GetAffectingModuleMaps(const Preprocessor &PP,
- Module *RootModule) {
+std::optional>
+GetAffectingModuleMaps(const Pre
@@ -161,8 +161,13 @@ static TypeCode getTypeCodeForTypeClass(Type::TypeClass
id) {
namespace {
-std::set GetAffectingModuleMaps(const Preprocessor &PP,
- Module *RootModule) {
+std::optional>
+GetAffectingModuleMaps(const Pre
https://github.com/hubert-reinterpretcast edited
https://github.com/llvm/llvm-project/pull/84132
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -3362,6 +3362,64 @@ SDValue PPCTargetLowering::LowerGlobalTLSAddress(SDValue
Op,
return LowerGlobalTLSAddressLinux(Op, DAG);
}
+/// updateForAIXShLibTLSModelOpt - Helper to initialize TLS model opt settings,
+/// and then apply the update.
+static void updateForAIXShLibT
@@ -3362,6 +3362,64 @@ SDValue PPCTargetLowering::LowerGlobalTLSAddress(SDValue
Op,
return LowerGlobalTLSAddressLinux(Op, DAG);
}
+/// updateForAIXShLibTLSModelOpt - Helper to initialize TLS model opt settings,
+/// and then apply the update.
+static void updateForAIXShLibT
https://github.com/hubert-reinterpretcast commented:
See inline comments for rationale re: scoping to LD -> IE only (and not
performing IE -> LD).
https://github.com/llvm/llvm-project/pull/84132
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
MaxEW707 wrote:
> Thank you for polishing this corner of the driver interface! It's interesting
> that they have an alternative separate spelling. I always felt like the
> /Fopath.cpp pattern was a bit unreadable.
Thanks for the review. I will need you to commit on my behalf. I think its
abou
@@ -161,8 +161,13 @@ static TypeCode getTypeCodeForTypeClass(Type::TypeClass
id) {
namespace {
-std::set GetAffectingModuleMaps(const Preprocessor &PP,
- Module *RootModule) {
+std::optional>
+GetAffectingModuleMaps(const Pre
efriedma-quic wrote:
Say you have:
```
int foo();
struct A { A(); A(const A&, int = foo()); };
struct B { A a[10]; };
void f(const B& b) { B bb = b; }
```
We want to visit the call to foo(), I think?
https://github.com/llvm/llvm-project/pull/1
__
@@ -1403,94 +1421,146 @@ bool
HeaderSearch::isFileMultipleIncludeGuarded(FileEntryRef File) const {
void HeaderSearch::MarkFileModuleHeader(FileEntryRef FE,
ModuleMap::ModuleHeaderRole Role,
bool i
efriedma-quic wrote:
Looks like automation didn't trigger for some reason... but quoting the
automated message that's supposed to trigger:
> ⚠️ We detected that you are using a GitHub private e-mail address to
> contribute to the repo.
> Please turn off [Keep my email addresses
> private](htt
Sterling-Augustine wrote:
Unless the original test was subtly broken, the forward fix in
0a789ea8a829da345e46d8224d73b2ddaba6969f seems erroneous.
The forward fix changes the test to have a different declaration of `new`. But
I would not expect this original change to require source-code level
https://github.com/topperc approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/88474
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
vitalybuka wrote:
A new memory leak https://lab.llvm.org/buildbot/#/builders/5/builds/42694
https://github.com/llvm/llvm-project/pull/88546
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
Author: Eli Friedman
Date: 2024-04-16T17:08:02-07:00
New Revision: 8c9f45e2decbb68dbf83794f98291b53f59390f8
URL:
https://github.com/llvm/llvm-project/commit/8c9f45e2decbb68dbf83794f98291b53f59390f8
DIFF:
https://github.com/llvm/llvm-project/commit/8c9f45e2decbb68dbf83794f98291b53f59390f8.diff
https://github.com/efriedma-quic closed
https://github.com/llvm/llvm-project/pull/88572
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
tstellar wrote:
PR is here: https://github.com/llvm/llvm-project/pull/89000
https://github.com/llvm/llvm-project/pull/88465
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ian-twilightcoder created
https://github.com/llvm/llvm-project/pull/89005
HeaderSearch::MarkFileModuleHeader is no longer properly checking for
no-changes, and so creates a new HeaderFileInfo for every `textual header`,
causes PCM use to go ballistic.
>From f45cb72cb9c70d71
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Ian Anderson (ian-twilightcoder)
Changes
HeaderSearch::MarkFileModuleHeader is no longer properly checking for
no-changes, and so creates a new HeaderFileInfo for every `textual header`,
causes PCM use to go ballistic.
---
Full diff: htt
@@ -1403,94 +1421,146 @@ bool
HeaderSearch::isFileMultipleIncludeGuarded(FileEntryRef File) const {
void HeaderSearch::MarkFileModuleHeader(FileEntryRef FE,
ModuleMap::ModuleHeaderRole Role,
bool i
ian-twilightcoder wrote:
I don't really know a great way to write a test for this. If someone could
point me at a similar existing test or has an idea how to write a new test that
would be much appreciated.
https://github.com/llvm/llvm-project/pull/89005
___
kito-cheng wrote:
`llvm/docs/RISCVUsage.rst` need update
https://github.com/llvm/llvm-project/pull/88474
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/benlangmuir approved this pull request.
https://github.com/llvm/llvm-project/pull/88764
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
nikic wrote:
This change seems to cause significant compile-time regressions for C++ code
(https://llvm-compile-time-tracker.com/compare.php?from=184ba038ac1d444980b3e554b0057f3f30c516ab&to=4082a7554521572a65a5a0008c4661a534df659d&stat=instructions%3Au).
Probably most damning are the times for
301 - 400 of 472 matches
Mail list logo