https://github.com/HighCommander4 updated
https://github.com/llvm/llvm-project/pull/81662
>From 120bade6c7077eb37222e125952befe53a9fb8cc Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Tue, 13 Feb 2024 12:26:17 -0500
Subject: [PATCH] [clang][Sema] Improve error recovery for id-expressions
re
https://github.com/yronglin created
https://github.com/llvm/llvm-project/pull/88602
Fixes https://github.com/llvm/llvm-project/issues/88522
This PR introduce a new diagnostic to report apply AST consume actions on LLVM
IR.
>From a180c067d36b731cbd075651ca4ecd903a643ffa Mon Sep 17 00:00:00 200
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (yronglin)
Changes
Fixes https://github.com/llvm/llvm-project/issues/88522
This PR introduce a new diagnostic to report apply AST consume actions on LLVM
IR.
---
Full diff: https://github.com/llvm/llvm-project/pull/88602.diff
3 Fi
https://github.com/vincent-mailhol edited
https://github.com/llvm/llvm-project/pull/88489
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,30 @@
+// RUN: %clang_cc1 -Wno-pointer-integer-compare
-Wpointer-integer-ordered-compare -fsyntax-only -verify=pointer-integer-ordered
%s
+// RUN: %clang_cc1 -Wpointer-integer-compare
-Wno-pointer-integer-ordered-compare -fsyntax-only -verify=pointer-integer %s
+
+vo
https://github.com/vincent-mailhol commented:
Thanks for taking care of the issue I created.
For what it is worth, here is my review. I am not a contributor of the llvm
project, so I only left superficial nitpicks.
https://github.com/llvm/llvm-project/pull/88489
___
@@ -714,10 +714,11 @@ def HeaderHygiene : DiagGroup<"header-hygiene">;
def DuplicateDeclSpecifier : DiagGroup<"duplicate-decl-specifier">;
def CompareDistinctPointerType : DiagGroup<"compare-distinct-pointer-types">;
def GNUUnionCast : DiagGroup<"gnu-union-cast">;
+def PointerI
@@ -245,6 +245,12 @@ Modified Compiler Flags
f3 *c = (f3 *)x;
}
+- Added a new diagnostic flag ``-Wpointer-integer-ordered-compare`` which is
+ grouped under ``-Wpointer-integer-compare`` and moved previously
+ ungrouped diagnostics
``ext_typecheck_ordered_compa
h-vetinari wrote:
I'm surprised about the "compiler-rt is not supported on windows" comment - in
our distribution, we've been building compiler-rt on windows for years, and I
don't remember significant issues.
It's true that `__divsc3` is not available _without_ compiler-rt (i.e. just
relyin
kimgr wrote:
Thanks!
Could you add this DeclPrinterTest unittest for regression?
```
TEST(DeclPrinter, TestTemplateFinal) {
ASSERT_TRUE(PrintedDeclCXX11Matches(
"template"
"class FinalTemplate final {};",
classTemplateDecl(hasName("FinalTemplate")).bind("id"),
"template class
https://github.com/Endilll created
https://github.com/llvm/llvm-project/pull/88611
This patch touches a number of tests that run in C++98 mode that have been
using array size as a context that requires a constant expression, replacing it
with a `static_assert` backported via a macro. This redu
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Vlad Serebrennikov (Endilll)
Changes
This patch touches a number of tests that run in C++98 mode that have been
using array size as a context that requires a constant expression, replacing it
with a `static_assert` backported via a macro.
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/88611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Endilll wrote:
This PR removes a FIXME since it doesn't make sense anymore in that particular
context. I created issue #88608 out of it to make sure we don't lose track of
it.
https://github.com/llvm/llvm-project/pull/88611
___
cfe-commits mailing li
no92 wrote:
Ping
https://github.com/llvm/llvm-project/pull/87845
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/88611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Sirraide commented:
I remember thinking that using array sizes for this was a bit outdated the last
time I saw a test that did this, so it’s nice to see them refactored.
https://github.com/llvm/llvm-project/pull/88611
___
cfe-commit
@@ -5,6 +5,17 @@
// RUN: %clang_cc1 -std=c++11
-verify=expected,cxx98-14,cxx98-17,cxx98-20,cxx11-14,since-cxx11 -triple
%itanium_abi_triple %s -fexceptions -fcxx-exceptions -pedantic-errors
// RUN: %clang_cc1 -std=c++98
-verify=expected,cxx98-14,cxx98-17,cxx98-20,cxx98 -tripl
Author: Vlad Serebrennikov
Date: 2024-04-13T13:10:42+03:00
New Revision: 0412a8651aa6cbdd697e904a758e0f95e6635cee
URL:
https://github.com/llvm/llvm-project/commit/0412a8651aa6cbdd697e904a758e0f95e6635cee
DIFF:
https://github.com/llvm/llvm-project/commit/0412a8651aa6cbdd697e904a758e0f95e6635cee.
@@ -5,6 +5,17 @@
// RUN: %clang_cc1 -std=c++11
-verify=expected,cxx98-14,cxx98-17,cxx98-20,cxx11-14,since-cxx11 -triple
%itanium_abi_triple %s -fexceptions -fcxx-exceptions -pedantic-errors
// RUN: %clang_cc1 -std=c++98
-verify=expected,cxx98-14,cxx98-17,cxx98-20,cxx98 -tripl
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/88611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/88611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2193,6 +2193,41 @@ struct FormatStyle {
/// \version 3.7
bool BreakBeforeTernaryOperators;
+ /// Different ways to Break Between Chevrons.
+ enum BreakChevronOperatorStyle : int8_t {
+/// Break using ColumnLimit rules.
+/// \code
+/// os << "a" << "
@@ -5598,10 +5598,34 @@ bool TokenAnnotator::mustBreakBefore(const
AnnotatedLine &Line,
// FIXME: Breaking after newlines seems useful in general. Turn this into an
// option and recognize more cases like endl etc, and break independent of
// what comes after operator le
https://github.com/mydeveloperday updated
https://github.com/llvm/llvm-project/pull/88490
>From 1c11c3edd0005a729561d84b9a815279b356e8db Mon Sep 17 00:00:00 2001
From: mydeveloperday
Date: Fri, 12 Apr 2024 10:32:19 +0100
Subject: [PATCH 1/7] [clang-format] revery to string << string handling ba
https://github.com/mydeveloperday updated
https://github.com/llvm/llvm-project/pull/88490
>From 1c11c3edd0005a729561d84b9a815279b356e8db Mon Sep 17 00:00:00 2001
From: mydeveloperday
Date: Fri, 12 Apr 2024 10:32:19 +0100
Subject: [PATCH 1/8] [clang-format] revery to string << string handling ba
@@ -5598,10 +5598,34 @@ bool TokenAnnotator::mustBreakBefore(const
AnnotatedLine &Line,
// FIXME: Breaking after newlines seems useful in general. Turn this into an
// option and recognize more cases like endl etc, and break independent of
// what comes after operator le
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/88611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/Endilll updated
https://github.com/llvm/llvm-project/pull/88611
>From c436fe6b0883577f434ee456fdffb224191108e0 Mon Sep 17 00:00:00 2001
From: Vlad Serebrennikov
Date: Sat, 13 Apr 2024 12:46:32 +0300
Subject: [PATCH 1/4] [clang] Migrate DR tests to `static_assert`
---
clang/
https://github.com/Endilll edited
https://github.com/llvm/llvm-project/pull/88611
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kimgr wrote:
> With .PolishForDeclaration=true, there are NO final specifiers (which is what
> we want to produce forward decls in IWYU)
This is actually a regression in this PR, and it breaks the clangd test added
here:
https://github.com/llvm/llvm-project/commit/9f57b65a272817752aa00e2fb941
Author: Vlad Serebrennikov
Date: 2024-04-13T15:17:04+03:00
New Revision: cbfcfdf75e9939bc47ac7a7c11d2122a6ad426ed
URL:
https://github.com/llvm/llvm-project/commit/cbfcfdf75e9939bc47ac7a7c11d2122a6ad426ed
DIFF:
https://github.com/llvm/llvm-project/commit/cbfcfdf75e9939bc47ac7a7c11d2122a6ad426ed.
Endilll wrote:
> (especially considering you said you’re going to refactor more tests than
> just these)
@Sirraide I didn't say that originally, but you reminded me that I indeed
forgot about all the uses of arrays that don't trigger diagnostics. I went over
all of them, and decided to includ
@@ -7735,7 +7735,8 @@ ExprResult Sema::BuildResolvedCallExpr(Expr *Fn,
NamedDecl *NDecl,
}
if (CXXMethodDecl *Method = dyn_cast_or_null(FDecl))
-if (Method->isImplicitObjectMemberFunction())
+if (!isa(CurContext) &&
jcsxky wrote:
Do you mean that
https://github.com/vgvassilev updated
https://github.com/llvm/llvm-project/pull/88600
>From bcd04db735a78b4d7df93e88229ea4e2491fc09e Mon Sep 17 00:00:00 2001
From: Vassil Vassilev
Date: Sat, 13 Apr 2024 06:39:34 +
Subject: [PATCH] Fix the double space and double attribute printing of the
f
vgvassilev wrote:
> > With .PolishForDeclaration=true, there are NO final specifiers (which is
> > what we want to produce forward decls in IWYU)
>
> This is actually a regression in this PR, and it breaks the clangd test added
> here:
> [9f57b65](https://github.com/llvm/llvm-project/commit/9
kimgr wrote:
Thank you.
I believe this should cover both cases, added some attempt at rationale in
comments:
```diff
diff --git a/clang/unittests/AST/DeclPrinterTest.cpp
b/clang/unittests/AST/DeclPrinterTest.cpp
index f2b027a25621..8691a6c38f16 100644
--- a/clang/unittests/AST/DeclPrinterTest.
vgvassilev wrote:
IIUC, the PolishForDeclaration option is supposed to `When true, do certain
refinement needed for producing proper declaration tag; such as, do not print
attributes attached to the declaration. `. If the intent is to produce a
forward declaration the `final` keyword cannot be
jyknight wrote:
To get back to my previous point about the semantics implemented by this patch
being unfortunate -- the upshot is that, now:
```
#include
#define NDEBUG
#import
```
will include assert.h twice (even though the latter is an "import") _only_ if
modules are enabled. If modules ar
https://github.com/vgvassilev updated
https://github.com/llvm/llvm-project/pull/88600
>From c68344d2d2f22f88ef386f655cc7698759fb551c Mon Sep 17 00:00:00 2001
From: Vassil Vassilev
Date: Sat, 13 Apr 2024 06:39:34 +
Subject: [PATCH] Fix the double space and double attribute printing of the
f
vgvassilev wrote:
I've put a fix that fixes the cases that you mentioned...
https://github.com/llvm/llvm-project/pull/88600
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vgvassilev updated
https://github.com/llvm/llvm-project/pull/88600
>From cb3da95dd80c5ed991c5342e655e0f170eab16eb Mon Sep 17 00:00:00 2001
From: Vassil Vassilev
Date: Sat, 13 Apr 2024 06:39:34 +
Subject: [PATCH] Fix the double space and double attribute printing of the
f
https://github.com/vgvassilev updated
https://github.com/llvm/llvm-project/pull/88600
>From 9b2bb9068cbefcfffd0931fbbee46b1a0f536a4f Mon Sep 17 00:00:00 2001
From: Vassil Vassilev
Date: Sat, 13 Apr 2024 06:39:34 +
Subject: [PATCH] Fix the double space and double attribute printing of the
f
kimgr wrote:
> If the intent is to produce a forward declaration the final keyword cannot be
> attached to a forward declaration. So I am not sure what's the "right" fix
> here...
I don't believe that's the intent of `DeclPrinter` or `PolishForDeclaration` --
* Clangd uses `PolishForDeclarati
@@ -252,16 +252,19 @@ static DeclPrinter::AttrPosAsWritten
getPosAsWritten(const Attr *A,
return DeclPrinter::AttrPosAsWritten::Right;
}
-void DeclPrinter::prettyPrintAttributes(const Decl *D,
+// returns true if an attribute was printed.
+bool DeclPrinter::prettyPrintAttri
vgvassilev wrote:
> * IWYU uses `PolishForDeclaration` to get a valid _declaration_, and then
> does [some very hacky heuristic
> post-processing](https://github.com/include-what-you-use/include-what-you-use/blob/125341c412ceee9233ece8973848b49e770a9b82/iwyu_output.cc#L469)
> to turn it into a
kimgr wrote:
Current PR passes all my tests, both Clang (`ninja ASTTests`), Clangd (`ninja
ClangdTests`) and IWYU end-to-end tests -- thanks!
https://github.com/llvm/llvm-project/pull/88600
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https
https://github.com/edwardbottom created
https://github.com/llvm/llvm-project/pull/88628
None
>From 22ae52878602dfc79ab90bbc6e9dea508c3762e2 Mon Sep 17 00:00:00 2001
From: Edward Bottom <31777866+edwardbot...@users.noreply.github.com>
Date: Sat, 13 Apr 2024 08:49:47 -0700
Subject: [PATCH] Update
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Edward Bottom (edwardbottom)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/88628.diff
1 Files Affected:
- (modified) clang/unittests/Format/FormatTest.cpp (+4-4)
``diff
diff --git a/clang/unittests/
https://github.com/edwardbottom edited
https://github.com/llvm/llvm-project/pull/88628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
kimgr wrote:
> I am wondering if that'd be interesting and if so, maybe we can share it
> between both projects via upstreaming to Clang...
That sounds fantastic, but mostly because I don't have anything to offer, and
everything to benefit :)
I was just thinking about adding a `.ForwardDeclar
https://github.com/philnik777 updated
https://github.com/llvm/llvm-project/pull/87361
>From b8a626116b0719c1acf75e9e7300df8e2bf82f99 Mon Sep 17 00:00:00 2001
From: Nikolas Klauser
Date: Tue, 2 Apr 2024 18:00:05 +0200
Subject: [PATCH 1/3] [Clang] Reduce the size of Decl and classes derived from
aganea wrote:
I think in the short term @jansvoboda11's suggestion should be good enough.
Bit if we want `Statistics` to be always cheap, we should make them
`thread_local` instead, not atomic. `getValue()` could do the "collection" of
data over all active, or past threads. It would also need
https://github.com/vgvassilev updated
https://github.com/llvm/llvm-project/pull/86402
>From 4434ceeef152b95998ebd0a3b09a56d105490c4d Mon Sep 17 00:00:00 2001
From: Anubhab Ghosh
Date: Sat, 23 Mar 2024 15:13:57 +
Subject: [PATCH 1/2] [clang-repl] Support wasm execution.
This commit introduc
https://github.com/steakhal updated
https://github.com/llvm/llvm-project/pull/88536
>From 915ab37028067fb38ffa69ae5c9726bb8c971436 Mon Sep 17 00:00:00 2001
From: Balazs Benics
Date: Fri, 12 Apr 2024 19:07:49 +0200
Subject: [PATCH 1/2] [analyzer] Harden security.cert.env.InvalidPtr checker fn
m
https://github.com/chrisnc created
https://github.com/llvm/llvm-project/pull/88631
None
>From 40d774ab8c598f0dfb76dcd087f1af17c7fdd01d Mon Sep 17 00:00:00 2001
From: Chris Copeland
Date: Fri, 12 Apr 2024 23:42:32 -0700
Subject: [PATCH] [clang][docs] fix whitespace in AttrDocs.td
---
clang/in
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Chris Copeland (chrisnc)
Changes
---
Full diff: https://github.com/llvm/llvm-project/pull/88631.diff
1 Files Affected:
- (modified) clang/include/clang/Basic/AttrDocs.td (+16-16)
``diff
diff --git a/clang/include/clang/Basic
https://github.com/chrisnc edited
https://github.com/llvm/llvm-project/pull/88631
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/chrisnc updated
https://github.com/llvm/llvm-project/pull/88631
>From d3e993c34e9d05f149b2670502794eaf93dee89a Mon Sep 17 00:00:00 2001
From: Chris Copeland
Date: Fri, 12 Apr 2024 23:42:32 -0700
Subject: [PATCH] [clang][docs] fix whitespace in AttrDocs.td
---
clang/include/
chrisnc wrote:
@cachemeifyoucan @cyndyishida for review?
https://github.com/llvm/llvm-project/pull/88631
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Edwin Vane
Date: 2024-04-13T21:01:06+02:00
New Revision: fad37526a3ea7d669af621342968029085862281
URL:
https://github.com/llvm/llvm-project/commit/fad37526a3ea7d669af621342968029085862281
DIFF:
https://github.com/llvm/llvm-project/commit/fad37526a3ea7d669af621342968029085862281.diff
LO
https://github.com/PiotrZSL closed
https://github.com/llvm/llvm-project/pull/88186
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/cachemeifyoucan approved this pull request.
LGTM. Thanks for fixing.
https://github.com/llvm/llvm-project/pull/88631
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL commented:
Missing release notes entry, except that looks fine.
https://github.com/llvm/llvm-project/pull/88138
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-comm
https://github.com/steakhal edited
https://github.com/llvm/llvm-project/pull/87521
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2836,6 +2836,10 @@ bool RangeConstraintManager::canReasonAbout(SVal X)
const {
return false;
}
+ // Non-integer types are not supported.
+ if (X.getAs())
+return false;
+
steakhal wrote:
My problem with this is that I think LCVs shouldn't eve
@@ -0,0 +1,16 @@
+// RUN: %clang_analyze_cc1 %s \
+// RUN: -analyzer-checker=alpha.cplusplus.InvalidatedIterator \
+// RUN: -analyzer-config aggressive-binary-operation-simplification=true \
+// RUN: 2>&1
+
+struct node {};
+struct prop : node {};
+struct bitvec : node {
+
@@ -57,10 +57,14 @@ ProgramStateRef
SimpleConstraintManager::assumeAux(ProgramStateRef State,
// We cannot reason about SymSymExprs, and can only reason about some
// SymIntExprs.
if (!canReasonAbout(Cond)) {
-// Just add the constraint to the expression without tryi
@@ -0,0 +1,16 @@
+// RUN: %clang_analyze_cc1 %s \
steakhal wrote:
I think you should put this test without the RUN lines into the
`clang/test/Analysis/invalidated-iterator.cpp` to have them at one place.
https://github.com/llvm/llvm-project/pull/87521
_
https://github.com/steakhal requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/87521
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/PiotrZSL edited
https://github.com/llvm/llvm-project/pull/87954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -22,8 +21,15 @@ class FunctionParmMutationAnalyzer;
/// a given statement.
class ExprMutationAnalyzer {
public:
+ friend class FunctionParmMutationAnalyzer;
+ struct Cache {
+llvm::DenseMaphttps://github.com/llvm/llvm-project/pull/87954
https://github.com/PiotrZSL approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/87954
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fhahn wrote:
Is it possible that this broke this bot failing with the error below?
```
usr/local/clang-17.0.2/bin/clang++ -DGTEST_HAS_RTTI=0 -D_CINDEX_LIB_ -D_DEBUG
-D_GLIBCXX_ASSERTIONS -D_LARGE_FILE_API -D__STDC_CONSTANT_MACROS
-D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS
-I/home/powerllvm/
https://github.com/rymiel closed https://github.com/llvm/llvm-project/pull/88628
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
PiotrZSL wrote:
@sopyb
Check is for modernize, not performance, so:
- Add entry in documentation that due to need of copy object into
initialization list check may cause performance degradation, add entry that
using std::ref, std::cref is recommended in such case:
`b = std::max({std::ref(i), s
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
https://github.com/vgvassilev updated
https://github.com/llvm/llvm-project/pull/84758
>From f28fc3aa917b24063707f99dd6545512630f48e8 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Stefan=20Gr=C3=A4nitz?=
Date: Sun, 10 Mar 2024 18:17:48 +0100
Subj
@@ -5598,10 +5598,34 @@ bool TokenAnnotator::mustBreakBefore(const
AnnotatedLine &Line,
// FIXME: Breaking after newlines seems useful in general. Turn this into an
// option and recognize more cases like endl etc, and break independent of
// what comes after operator le
@@ -2193,6 +2193,41 @@ struct FormatStyle {
/// \version 3.7
bool BreakBeforeTernaryOperators;
+ /// Different ways to Break Between Chevrons.
+ enum BreakChevronOperatorStyle : int8_t {
+/// Break using ColumnLimit rules.
+/// \code
+/// os << "a" << "
@@ -5598,11 +5598,45 @@ bool TokenAnnotator::mustBreakBefore(const
AnnotatedLine &Line,
// FIXME: Breaking after newlines seems useful in general. Turn this into an
// option and recognize more cases like endl etc, and break independent of
// what comes after operator le
chrisnc wrote:
Ready to merge, but I'm not able to myself.
https://github.com/llvm/llvm-project/pull/88631
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vvd170501 created
https://github.com/llvm/llvm-project/pull/88636
This PR aims to expand the list of classes that are considered to be "strings"
by `readability-string-compare` check.
1. Currently `readability-string-compare` only checks `std::string;:compare`,
but `std::s
https://github.com/vvd170501 edited
https://github.com/llvm/llvm-project/pull/88636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/term-est created
https://github.com/llvm/llvm-project/pull/88637
Henlo frens! 🍓
We folks at Armelsan Defense has been using LLVM for quite some time. Recently
we encountered an issue with clangd where it tries to allocate 137 gigs of
memory in one of our template heavy cod
github-actions[bot] wrote:
Thank you for submitting a Pull Request (PR) to the LLVM Project!
This PR will be automatically labeled and the relevant teams will be
notified.
If you wish to, you can add reviewers by using the "Reviewers" section on this
page.
If this is not working for you, it
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (term-est)
Changes
Henlo frens! 🍓
We folks at Armelsan Defense has been using LLVM for quite some time. Recently
we encountered an issue with clangd where it tries to allocate 137 gigs of
memory in one of our template heavy codebas
https://github.com/term-est edited
https://github.com/llvm/llvm-project/pull/88637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/komalverma04 updated
https://github.com/llvm/llvm-project/pull/87268
>From 9b5781108081565e4009c3809eab623387655f1c Mon Sep 17 00:00:00 2001
From: komalverma04
Date: Mon, 1 Apr 2024 22:43:10 +0530
Subject: [PATCH 1/7] [clang-tidy] Add ignoringParenImpCasts in hasAnyArgument
https://github.com/term-est edited
https://github.com/llvm/llvm-project/pull/88637
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/vvd170501 updated
https://github.com/llvm/llvm-project/pull/88636
>From 91eccdd291fa4f0753aa8e9970fa146516823e22 Mon Sep 17 00:00:00 2001
From: Vadim Dudkin
Date: Sat, 13 Apr 2024 23:36:12 +0300
Subject: [PATCH] readability-string-compare: check std::string_view, allow
custo
https://github.com/vvd170501 updated
https://github.com/llvm/llvm-project/pull/88636
>From b63dd11ea87cd504c8972de6ed29330d6702abca Mon Sep 17 00:00:00 2001
From: Vadim Dudkin
Date: Sat, 13 Apr 2024 23:36:12 +0300
Subject: [PATCH] readability-string-compare: check std::string_view, allow
custo
https://github.com/vvd170501 updated
https://github.com/llvm/llvm-project/pull/88636
>From 0db24a6806e9429b5e7b9cd9d0777315b3e6d87e Mon Sep 17 00:00:00 2001
From: Vadim Dudkin
Date: Sat, 13 Apr 2024 23:36:12 +0300
Subject: [PATCH] readability-string-compare: check std::string_view, allow
custo
@@ -7,42 +7,70 @@
//===--===//
#include "StringCompareCheck.h"
-#include "../utils/FixItHintUtils.h"
+#include "../utils/OptionsUtils.h"
#include "clang/AST/ASTContext.h"
#include "clang/ASTMatchers/ASTMatc
https://github.com/vvd170501 ready_for_review
https://github.com/llvm/llvm-project/pull/88636
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
llvmbot wrote:
@llvm/pr-subscribers-clang-tidy
Author: Vadim D. (vvd170501)
Changes
This PR aims to expand the list of classes that are considered to be "strings"
by `readability-string-compare` check.
1. Currently only `std::string;:compare` is checked, but `std::string_view`
has a si
llvmbot wrote:
@llvm/pr-subscribers-clang-tools-extra
Author: Vadim D. (vvd170501)
Changes
This PR aims to expand the list of classes that are considered to be "strings"
by `readability-string-compare` check.
1. Currently only `std::string;:compare` is checked, but `std::string_view`
h
amygrinn wrote:
ping
https://github.com/llvm/llvm-project/pull/78904
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
⚠️ We detected that you are using a GitHub private e-mail address to contribute
to the repo. Please turn off [Keep my email addresses
private](https://github.com/settings/emails) setting in your account. See
[LLVM
Discourse](https://discourse.llvm.org/t/hidden-email
1 - 100 of 145 matches
Mail list logo
