[clang] [clang][dataflow] Propagate locations from result objects to initializers. (PR #87320)

2024-04-05 Thread Gábor Horváth via cfe-commits
@@ -688,22 +689,45 @@ class Environment { /// and functions referenced in `FuncDecl`. `FuncDecl` must have a body. void initFieldsGlobalsAndFuncs(const FunctionDecl *FuncDecl); + static PrValueToResultObject + buildResultObjectMap(DataflowAnalysisContext *DACtx, +

[clang] [clang][dataflow] Propagate locations from result objects to initializers. (PR #87320)

2024-04-05 Thread Gábor Horváth via cfe-commits
@@ -688,22 +689,45 @@ class Environment { /// and functions referenced in `FuncDecl`. `FuncDecl` must have a body. void initFieldsGlobalsAndFuncs(const FunctionDecl *FuncDecl); + static PrValueToResultObject + buildResultObjectMap(DataflowAnalysisContext *DACtx, +

[clang] [clang][dataflow] Propagate locations from result objects to initializers. (PR #87320)

2024-04-05 Thread Gábor Horváth via cfe-commits
@@ -385,6 +388,185 @@ getFieldsGlobalsAndFuncs(const Stmt &S, FieldSet &Fields, } } +namespace { + +// Visitor that builds a map from record prvalues to result objects. +// This traverses the body of the function to be analyzed; for each result +// object that it encounters,

[clang] [NFC][OpenMP] Split nesting_of_regions test (PR #87842)

2024-04-05 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/87842 This test is the bottleneck for OpenMP lit tests, running about twice as long as the others. Break it into five tests based on run lines with the same version. >From e184c8ec9b25b3e077a42646775755dd3a4b449

[clang] [NFC][OpenMP] Split nesting_of_regions test (PR #87842)

2024-04-05 Thread Mike Rice via cfe-commits
mikerice1969 wrote: This is one way to improve the overall test time. Open for other suggestions. ``` Before change: Slowest Tests: -- 144.09s: Clang :: OpenMP/nesting_of_regions.cpp 60.81s: Clang :: OpenMP/target_defaultma

[clang] [NFC][OpenMP] Split nesting_of_regions test (PR #87842)

2024-04-05 Thread Mike Rice via cfe-commits
https://github.com/mikerice1969 ready_for_review https://github.com/llvm/llvm-project/pull/87842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [NFC][OpenMP] Split nesting_of_regions test (PR #87842)

2024-04-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Mike Rice (mikerice1969) Changes This test is the bottleneck for OpenMP lit tests, running about twice as long as the others. Break it into five tests based on run lines with the same version. --- Full diff: https://github.com/llvm/llvm-

[clang] [llvm] [llvm] Add triples for managarm (PR #87845)

2024-04-05 Thread via cfe-commits
https://github.com/no92 created https://github.com/llvm/llvm-project/pull/87845 This PR aims to add a target for [managarm](https://github.com/managarm/managarm). The targets `{x86_64,aarch64,riscv64}-pc-managarm-{kernel,system}` are enabled by this PR and have been tested to work on managarm.

[clang] [llvm] [llvm] Add triples for managarm (PR #87845)

2024-04-05 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [llvm] [llvm] Add triples for managarm (PR #87845)

2024-04-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: no92 (no92) Changes This PR aims to add a target for [managarm](https://github.com/managarm/managarm). The targets `{x86_64,aarch64,riscv64}-pc-managarm-{kernel,system}` are enabled by this PR and have been tested to work on manag

[clang] [llvm] [llvm] Add triples for managarm (PR #87845)

2024-04-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-adt Author: no92 (no92) Changes This PR aims to add a target for [managarm](https://github.com/managarm/managarm). The targets `{x86_64,aarch64,riscv64}-pc-managarm-{kernel,system}` are enabled by this PR and have been tested to work on managarm.

[clang] [llvm] [llvm] Add triples for managarm (PR #87845)

2024-04-05 Thread via cfe-commits
https://github.com/no92 edited https://github.com/llvm/llvm-project/pull/87845 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Flang] responds to Clang Tidy feedback (PR #87847)

2024-04-05 Thread Christopher Di Bella via cfe-commits
https://github.com/cjdb created https://github.com/llvm/llvm-project/pull/87847 Line 267: performance-unnecessary-copy-initialization Line 592: readability-container-size-empty >From b8e67dfae63ee64753724dba8735799b39f4fcc0 Mon Sep 17 00:00:00 2001 From: Christopher Di Bella Date: Sat, 6 Apr 20

[clang] [Flang] responds to Clang Tidy feedback (PR #87847)

2024-04-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Christopher Di Bella (cjdb) Changes Line 267: performance-unnecessary-copy-initialization Line 592: readability-container-size-empty --- Full diff: https://github.com/llvm/llvm-project/pull/87847.diff 1 Files Affected: - (modified) clan

[clang] [Flang] responds to Clang Tidy feedback (PR #87847)

2024-04-05 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 8bd391457fbd5108610557efdb26c2397aa0bd24 b8e67dfae63ee64753724dba8735799b39f4fcc0 --

[clang] [Flang] responds to Clang Tidy feedback (PR #87847)

2024-04-05 Thread Christopher Di Bella via cfe-commits
https://github.com/cjdb updated https://github.com/llvm/llvm-project/pull/87847 >From b8e67dfae63ee64753724dba8735799b39f4fcc0 Mon Sep 17 00:00:00 2001 From: Christopher Di Bella Date: Sat, 6 Apr 2024 00:13:29 + Subject: [PATCH 1/2] [Flang] responds to Clang Tidy feedback Line 267: performa

[clang] Match against all plugins when parsing microsoft attributes (PR #86426)

2024-04-05 Thread via cfe-commits
https://github.com/apache-hb updated https://github.com/llvm/llvm-project/pull/86426 >From 245a21512d8658225b17b91b8af4764f54084e01 Mon Sep 17 00:00:00 2001 From: Elliot <35050275+apache...@users.noreply.github.com> Date: Sun, 24 Mar 2024 03:03:47 -0400 Subject: [PATCH 1/7] Match against all plu

[clang] Match against all plugins when parsing microsoft attributes (PR #86426)

2024-04-05 Thread via cfe-commits
@@ -345,6 +345,9 @@ Bug Fixes to Compiler Builtins Bug Fixes to Attribute Support ^^ +- Clang now correctly matches plugin attributes with microsoft ``[attribute]`` syntax. apache-hb wrote: Microsoft attributes use single brackets

[clang] [clang][modules] Do not resolve `HeaderFileInfo` externally in `ASTWriter` (PR #87848)

2024-04-05 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/87848 None >From ee56548604be9473f33cd809c901886f37a3d8e9 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Fri, 5 Apr 2024 15:12:39 -0700 Subject: [PATCH] [clang][modules] Do not resolve `HeaderFileInfo` external

[clang] [clang][modules] Only compute affecting module maps with implicit search (PR #87849)

2024-04-05 Thread Jan Svoboda via cfe-commits
https://github.com/jansvoboda11 created https://github.com/llvm/llvm-project/pull/87849 None >From 158ecc0736f0011f7da2c737ae323ddf5ef599c9 Mon Sep 17 00:00:00 2001 From: Jan Svoboda Date: Thu, 4 Apr 2024 12:31:09 -0700 Subject: [PATCH] [clang][modules] Only compute affecting module maps with

[clang-tools-extra] ed4e505 - [clang-tidy] Fix readability-duplicate-include for includes with macro (#87433)

2024-04-05 Thread via cfe-commits
Author: Mike Date: 2024-04-06T04:38:08+03:00 New Revision: ed4e505c219fe6c7464ea5a056e90d8cd94c7332 URL: https://github.com/llvm/llvm-project/commit/ed4e505c219fe6c7464ea5a056e90d8cd94c7332 DIFF: https://github.com/llvm/llvm-project/commit/ed4e505c219fe6c7464ea5a056e90d8cd94c7332.diff LOG: [cl

[clang-tools-extra] [clang-tidy] Fix readability-duplicate-include for includes with macro (PR #87433)

2024-04-05 Thread via cfe-commits
https://github.com/FruitClover closed https://github.com/llvm/llvm-project/pull/87433 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Clang: Return new layout path if cannot find CRT (PR #87319)

2024-04-05 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay requested changes to this pull request. I don't think we should add another copy of `buildCompilerRTBasename` to `getCompilerRT` to make it more complex. Let's keep the discussion in #87150 https://github.com/llvm/llvm-project/pull/87319 __

[clang] Fix/interp init list unnamed bitfields (PR #87799)

2024-04-05 Thread Timm Baeder via cfe-commits
@@ -0,0 +1,114 @@ +// UNSUPPORTED: asserts +// REQUIRES: asserts +// ^ this attempts to say "don't actually run this test", because it's broken tbaederr wrote: It's broken even with the changes in this PR? https://github.com/llvm/llvm-project/pull/87799

[clang] Fix/interp init list unnamed bitfields (PR #87799)

2024-04-05 Thread Timm Baeder via cfe-commits
@@ -0,0 +1,114 @@ +// UNSUPPORTED: asserts +// REQUIRES: asserts +// ^ this attempts to say "don't actually run this test", because it's broken +// +// The point of this test is to demonstrate something that ExprConstant accepts, +// but Interp rejects. I had hoped to express tha

[clang] Fix/interp init list unnamed bitfields (PR #87799)

2024-04-05 Thread Timm Baeder via cfe-commits
@@ -884,8 +884,36 @@ bool ByteCodeExprGen::visitInitList(ArrayRef Inits, if (!this->emitDupPtr(E)) return false; +// guard relatively expensive base check behind an almost-always-false tbaederr wrote: The comment sounds like this is just a perf

[clang] 813f68c - [clang] Reject VLAs in `__is_layout_compatible()` (#87737)

2024-04-05 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2024-04-06T08:09:54+04:00 New Revision: 813f68caf42260452ad7a5cc224ef199a2ad0067 URL: https://github.com/llvm/llvm-project/commit/813f68caf42260452ad7a5cc224ef199a2ad0067 DIFF: https://github.com/llvm/llvm-project/commit/813f68caf42260452ad7a5cc224ef199a2ad0067.

[clang] [clang] Reject VLAs in `__is_layout_compatible()` (PR #87737)

2024-04-05 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/87737 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] cd0f5b2 - [clang] Add test for CWG392 (#87744)

2024-04-05 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2024-04-06T08:10:53+04:00 New Revision: cd0f5b2e58fad3973f2f50936b0467b2de3b3e12 URL: https://github.com/llvm/llvm-project/commit/cd0f5b2e58fad3973f2f50936b0467b2de3b3e12 DIFF: https://github.com/llvm/llvm-project/commit/cd0f5b2e58fad3973f2f50936b0467b2de3b3e12.

[clang] [clang] Add test for CWG392 (PR #87744)

2024-04-05 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/87744 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Claim conformance for CWG466 (PR #87748)

2024-04-05 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll closed https://github.com/llvm/llvm-project/pull/87748 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0b021c4 - [clang] Claim conformance for CWG466 (#87748)

2024-04-05 Thread via cfe-commits
Author: Vlad Serebrennikov Date: 2024-04-06T08:11:58+04:00 New Revision: 0b021c4b603b4e076f9e54572a4eef3e43ab57c0 URL: https://github.com/llvm/llvm-project/commit/0b021c4b603b4e076f9e54572a4eef3e43ab57c0 DIFF: https://github.com/llvm/llvm-project/commit/0b021c4b603b4e076f9e54572a4eef3e43ab57c0.

[clang] [clang][NFC] Introduce `SemaBase` (PR #87634)

2024-04-05 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll updated https://github.com/llvm/llvm-project/pull/87634 >From 311e2ef14dda46686b473e813028a2c3b2ac1254 Mon Sep 17 00:00:00 2001 From: Vlad Serebrennikov Date: Thu, 4 Apr 2024 16:07:35 +0300 Subject: [PATCH] [clang][NFC] Introduce `SemaBase` This is a follow-up to #84

[clang] [Driver] Ensure ToolChain::LibraryPaths is not empty (PR #87866)

2024-04-05 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay created https://github.com/llvm/llvm-project/pull/87866 Follow-up to #81037. ToolChain::LibraryPaths holds the new compiler-rt library directory (e.g. `/tmp/Debug/lib/clang/19/lib/x86_64-unknown-linux-gnu`). However, it might be empty when the directory does not exist

[clang] [Driver] Ensure ToolChain::LibraryPaths is not empty (PR #87866)

2024-04-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Fangrui Song (MaskRay) Changes Follow-up to #81037. ToolChain::LibraryPaths holds the new compiler-rt library directory (e.g. `/tmp/Debug/lib/clang/19/lib/x86_64-unknown-linux-gnu`). However, it might be empty when the directory does not e

[clang] [Driver] Ensure ToolChain::LibraryPaths is not empty (PR #87866)

2024-04-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-risc-v Author: Fangrui Song (MaskRay) Changes Follow-up to #81037. ToolChain::LibraryPaths holds the new compiler-rt library directory (e.g. `/tmp/Debug/lib/clang/19/lib/x86_64-unknown-linux-gnu`). However, it might be empty when the directory d

[clang] [Driver] Ensure ToolChain::LibraryPaths is not empty (PR #87866)

2024-04-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Fangrui Song (MaskRay) Changes Follow-up to #81037. ToolChain::LibraryPaths holds the new compiler-rt library directory (e.g. `/tmp/Debug/lib/clang/19/lib/x86_64-unknown-linux-gnu`). However, it might be empty when the directory doe

[clang] 7702023 - [clang-format][NFC] Rename `kind` to `Kind`

2024-04-05 Thread Owen Pan via cfe-commits
Author: Owen Pan Date: 2024-04-05T22:17:50-07:00 New Revision: 770202343ebce1f2bc0745c78e298e251f204bee URL: https://github.com/llvm/llvm-project/commit/770202343ebce1f2bc0745c78e298e251f204bee DIFF: https://github.com/llvm/llvm-project/commit/770202343ebce1f2bc0745c78e298e251f204bee.diff LOG:

[clang] [clang-format][NFC] Add getNextNonComment() to FormatTokenSource (PR #87868)

2024-04-05 Thread Owen Pan via cfe-commits
https://github.com/owenca created https://github.com/llvm/llvm-project/pull/87868 None >From 5c614fec2b54c146841a9ef3089dee1a63f72543 Mon Sep 17 00:00:00 2001 From: Owen Pan Date: Fri, 5 Apr 2024 22:45:47 -0700 Subject: [PATCH] [clang-format][NFC] Add getNextNonComment() to FormatTokenSource

[clang] [clang-format][NFC] Add getNextNonComment() to FormatTokenSource (PR #87868)

2024-04-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-format Author: Owen Pan (owenca) Changes --- Full diff: https://github.com/llvm/llvm-project/pull/87868.diff 2 Files Affected: - (modified) clang/lib/Format/FormatTokenSource.h (+9) - (modified) clang/lib/Format/UnwrappedLineParser.cpp (+2-9)

[clang] [clang] Reject incomplete types in `__is_layout_compatible()` (PR #87869)

2024-04-05 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll created https://github.com/llvm/llvm-project/pull/87869 This is a follow-up to #81506. As discussed in #87737, we're rejecting incomplete types, save for exceptions listed in the C++ standard (`void` and arrays of unknown bound). Note that arrays of unknown bound of

[clang] [clang] Reject incomplete types in `__is_layout_compatible()` (PR #87869)

2024-04-05 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Vlad Serebrennikov (Endilll) Changes This is a follow-up to #81506. As discussed in #87737, we're rejecting incomplete types, save for exceptions listed in the C++ standard (`void` and arrays of unknown bound). Note that arrays of unknown

<    1   2   3   4