@@ -761,6 +761,13 @@ void ASTDeclWriter::VisitFunctionDecl(FunctionDecl *D) {
}
}
+ // FIXME: Hack: We're out of bits in FunctionDeclBits, so always
+ // add this even though it's 0 in the vast majority of cases. We
+ // might really want to consider storing this in t
https://github.com/CoTinker edited
https://github.com/llvm/llvm-project/pull/86388
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -761,6 +761,13 @@ void ASTDeclWriter::VisitFunctionDecl(FunctionDecl *D) {
}
}
+ // FIXME: Hack: We're out of bits in FunctionDeclBits, so always
+ // add this even though it's 0 in the vast majority of cases. We
+ // might really want to consider storing this in t
Sirraide wrote:
> Have you had a chat with OpenMP folks?
@alexey-bataev has been commenting on this matter since the original assume pr,
and according to them, `[[omp::assume]]` is the only spelling of the attribute
mandated by the OpenMP standard, and we’ve already added that one in #84582.
zyn0217 wrote:
> Hmm, actually - does this fix address /other/ ways a pack could appear, like
> this? https://godbolt.org/z/oez8TbGqM
>
> Presumably a pack could appear in a variety of expressions, not just wrapped
> in parens - could be in a function call (as in the above example), or nested
@@ -418,39 +448,60 @@ static ReadySuspendResumeResult buildCoawaitCalls(Sema
&S, VarDecl *CoroPromise,
return Calls;
}
Expr *CoroHandle = CoroHandleRes.get();
- CallExpr *AwaitSuspend = cast_or_null(
- BuildSubExpr(ACT::ACT_Suspend, "await_suspend", CoroHandle));
Sirraide wrote:
> because there’s one header in LibCL that uses `__attribute__((assume))`
Specifically,
[libclc/generic/include/clc/clcfunc.h](https://github.com/llvm/llvm-project/blob/main/libclc/generic/include/clc/clcfunc.h).
https://github.com/llvm/llvm-project/pull/84934
_
zyn0217 wrote:
@dwblaikie Feel free to checkout this patch locally and see if it resolves the
original issue - I won't merge it until you confirm it works or discover
another issue that goes beyond the scope of this patch. (e.g. another
aforementioned issue)
https://github.com/llvm/llvm-proje
https://github.com/JustinStitt created
https://github.com/llvm/llvm-project/pull/86618
## Intro
This attribute would allow for more granular control over what expressions can
emit integer overflow warnings or integer overflow sanitizer errors.
Here are some examples:
_copy-pasted from m
llvmbot wrote:
@llvm/pr-subscribers-clang-codegen
Author: Justin Stitt (JustinStitt)
Changes
## Intro
This attribute would allow for more granular control over what expressions can
emit integer overflow warnings or integer overflow sanitizer errors.
Here are some examples:
_copy-p
https://github.com/JustinStitt updated
https://github.com/llvm/llvm-project/pull/86618
>From 0fa8f07c722f9d7f80a90824f961ae6e9c5bdef7 Mon Sep 17 00:00:00 2001
From: Justin Stitt
Date: Tue, 5 Mar 2024 03:14:49 +
Subject: [PATCH 1/2] implement wraps attribute
Signed-off-by: Justin Stitt
---
@@ -424,6 +448,56 @@ InstallAPIContext Options::createContext() {
if (!Glob->didMatch())
Diags->Report(diag::warn_glob_did_not_match) << Glob->str();
+ // Mark any explicit or inferred umbrella headers. If one exists, move
+ // that to the beginning of the input he
@@ -424,6 +448,56 @@ InstallAPIContext Options::createContext() {
if (!Glob->didMatch())
Diags->Report(diag::warn_glob_did_not_match) << Glob->str();
+ // Mark any explicit or inferred umbrella headers. If one exists, move
+ // that to the beginning of the input he
llvm-beanz wrote:
> I'm a bit confused. Are you saying that as I've expressed it, `autocrlf=true`
> won't work correctly? I _think_ you're saying you're in favour of this patch
> _in principal_, but I need to fix the mixed line endings case?
Sorry for being unclear. I meant to express that I'm
https://github.com/ChuanqiXu9 updated
https://github.com/llvm/llvm-project/pull/85050
>From 5fcccd75d0823ff11a4e385565cad65034d0def7 Mon Sep 17 00:00:00 2001
From: Chuanqi Xu
Date: Tue, 12 Mar 2024 17:26:49 +0800
Subject: [PATCH 1/2] [C++20] [Modules] Introduce -fgen-reduced-bmi
---
clang/inc
@@ -0,0 +1,53 @@
+// It is annoying to handle different slash direction
+// in Windows and Linux. So we disable the test on Windows
+// here.
+// REQUIRES: !system-windows
ChuanqiXu9 wrote:
Done
https://github.com/llvm/llvm-project/pull/85050
___
@@ -3031,6 +3032,11 @@ defm skip_odr_check_in_gmf : BoolOption<"f",
"skip-odr-check-in-gmf",
"Perform ODR checks for decls in the global module fragment.">>,
Group;
+def gen_reduced_bmi : Flag<["-"], "fgen-reduced-bmi">,
ChuanqiXu9 wrote:
Done by
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 93f9fb2c825dba48db64d5f726b54bcbd4766009
527b69efe66961aa7d7febcdda66f042f50adf2b --
ChuanqiXu9 wrote:
@iains @dwblaikie Understood. And I thought the major problem is that there are
a lot flags from clang modules. And it is indeed confusing. But given we have
to introduce new flags in this case, probably we can only try to make it more
clear by better documents.
https://gith
ChuanqiXu9 wrote:
> Using `-fgen-reduced-bmi` currently fails for me with a case that looks like
> this:
>
> ```c++
> // a.hpp
> template
> void ignore(T const &) noexcept {}
>
> inline void resultCheck(char const *message) {
> ignore(message);
> }
>
> // b.cppm
> modul
ChuanqiXu9 wrote:
> Do I miss something? The performance and file size is similar with and
> without `-fgen-reduced-bmi`. To reproduce clone
> https://github.com/koplas/clang-modules-test and run `build.sh` and
> `build_thin_bmi.sh`.
Currently, the Reduced BMI will only remove function bodies
ye-luo wrote:
The term deprecated refers to a functionality that still exists in software
whose use is not recommended. Contradictorily, GCC_INSTALL_PREFIX got me fatal
error now without a clear message explaining how to keep it working. I had to
dig deep to figure it out.
Will "temporary" `U
https://github.com/ChuanqiXu9 edited
https://github.com/llvm/llvm-project/pull/85050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/ChuanqiXu9 edited
https://github.com/llvm/llvm-project/pull/85050
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
jhuber6 wrote:
What's the suggested way to handle this in a standard build? The documents
state to use `-DCMAKE_CXX_FLAGS=--gcc-isntall-dir=` but that doesn't work
if you build LLVM with `gcc` initially. You'd need to somehow only pass that
flag to the invocations that use `clang`. We also hav
jhuber6 wrote:
@petrhosek Is there a way to pass flags only to the runtimes portion of the
build within the normal workflow? I know we have
`-DRUNTIMES_x86_64-unknown-linux-gnu_CMAKE_CXX_COMPILE_FLAGS=` that might work,
but I don't think this is respected if we're using the `default` target.
https://github.com/HighCommander4 approved this pull request.
Thanks!
https://github.com/llvm/llvm-project/pull/85497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/HighCommander4 updated
https://github.com/llvm/llvm-project/pull/86466
>From 73d2082c164ba629babec3cc3dc9b1d06b41ec60 Mon Sep 17 00:00:00 2001
From: Nathan Ridge
Date: Mon, 25 Mar 2024 02:14:00 -0400
Subject: [PATCH] [clang][CodeComplete] Handle deref operator in
getApproxim
Author: Nathan Ridge
Date: 2024-03-25T23:54:40-04:00
New Revision: bc31be7949a3d5382be0e15e3957fa957da9de45
URL:
https://github.com/llvm/llvm-project/commit/bc31be7949a3d5382be0e15e3957fa957da9de45
DIFF:
https://github.com/llvm/llvm-project/commit/bc31be7949a3d5382be0e15e3957fa957da9de45.diff
https://github.com/HighCommander4 closed
https://github.com/llvm/llvm-project/pull/86466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HighCommander4 wrote:
Thanks for the review!
https://github.com/llvm/llvm-project/pull/86466
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -4827,6 +4827,10 @@ bool TokenAnnotator::spaceRequiredBefore(const
AnnotatedLine &Line,
Right.is(TT_TemplateOpener)) {
return true;
}
+if (Left.is(tok::identifier) && Right.is(tok::numeric_constant) &&
+Right.TokenText[0] == '.') {
aniplcc wrote:
Requesting review, @llvm-beanz
https://github.com/llvm/llvm-project/pull/86571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
HighCommander4 wrote:
> I think other than the review it would be 100% done? I mean, no big further
> modifications would be involved?
In terms of functionality, I'd say the patch is complete.
In terms of performance (and specifically memory usage), it's a matter of
judgment of what we consid
https://github.com/owenca created
https://github.com/llvm/llvm-project/pull/86624
Fixes #86559.
>From 5ba6a0adcf9de7035dd195f0b83ada39019b7e12 Mon Sep 17 00:00:00 2001
From: Owen Pan
Date: Mon, 25 Mar 2024 21:13:04 -0700
Subject: [PATCH] [clang-format] Fix a regression in annotating
TrailingR
llvmbot wrote:
@llvm/pr-subscribers-clang-format
Author: Owen Pan (owenca)
Changes
Fixes #86559.
---
Full diff: https://github.com/llvm/llvm-project/pull/86624.diff
2 Files Affected:
- (modified) clang/lib/Format/TokenAnnotator.cpp (+2)
- (modified) clang/unittests/Format/TokenAnnotat
atetubou wrote:
Thank you for your review and merge!
https://github.com/llvm/llvm-project/pull/83961
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
efriedma-quic wrote:
If you implement #86075 like I suggested, the inconsistency here also goes
away, I think: if va_arg queries classifyArgumentType, you get the same result
as argument lowering, so clang becomes self-consistent. (Whether that's
gcc-compatible is a different question...)
ht
@@ -0,0 +1,25 @@
+.. title:: clang-tidy - readability-math-missing-parentheses
+
+readability-math-missing-parentheses
+
+
+Check for missing parentheses in mathematical expressions that involve
operators
+of different priorities. Parentheses i
https://github.com/11happy updated
https://github.com/llvm/llvm-project/pull/84481
>From 8fdf6306085ed4cf0f77b7e718e374e9f65fedf9 Mon Sep 17 00:00:00 2001
From: 11happy
Date: Fri, 8 Mar 2024 19:02:47 +0530
Subject: [PATCH 1/7] add clang-tidy check readability-math-missing-parentheses
Signed-of
@@ -0,0 +1,87 @@
+//===--- MathMissingParenthesesCheck.cpp - clang-tidy
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,87 @@
+//===--- MathMissingParenthesesCheck.cpp - clang-tidy
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -0,0 +1,87 @@
+//===--- MathMissingParenthesesCheck.cpp - clang-tidy
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
Author: Younan Zhang
Date: 2024-03-26T12:57:09+08:00
New Revision: c6a65e4b0c80245d766ae2f2f7305b5371d096f5
URL:
https://github.com/llvm/llvm-project/commit/c6a65e4b0c80245d766ae2f2f7305b5371d096f5
DIFF:
https://github.com/llvm/llvm-project/commit/c6a65e4b0c80245d766ae2f2f7305b5371d096f5.diff
https://github.com/zyn0217 closed
https://github.com/llvm/llvm-project/pull/85497
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
petrhosek wrote:
> @petrhosek Is there a way to pass flags only to the runtimes portion of the
> build within the normal workflow? I know we have
> `-DRUNTIMES_x86_64-unknown-linux-gnu_CMAKE_CXX_COMPILE_FLAGS=` that might
> work, but I don't think this is respected if we're using the `default`
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff c6a65e4b0c80245d766ae2f2f7305b5371d096f5
b8a69cbd9e0ee0aa35b38b7e3a78048cbe61447e --
@@ -804,10 +804,38 @@ Check for performance anti-patterns when using Grand
Central Dispatch.
.. _optin-performance-Padding:
-optin.performance.Padding
-"
+optin.performance.Padding (C, C++, ObjC)
+
Check for ex
401 - 448 of 448 matches
Mail list logo
