Author: Aaron Ballman
Date: 2024-03-25T12:19:40-04:00
New Revision: 7ee1007eddcfc4efe582512b78704038f17fa5a3
URL:
https://github.com/llvm/llvm-project/commit/7ee1007eddcfc4efe582512b78704038f17fa5a3
DIFF:
https://github.com/llvm/llvm-project/commit/7ee1007eddcfc4efe582512b78704038f17fa5a3.diff
llvmbot wrote:
@llvm/pr-subscribers-clang-modules
Author: None (Sirraide)
Changes
This implements support for the `= delete("message")` syntax that was only just
added to C++26
([P2573R2](https://isocpp.org/files/papers/P2573R2.html#proposal-scope)).
The major parts are all done, from
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (Sirraide)
Changes
This implements support for the `= delete("message")` syntax that was only just
added to C++26
([P2573R2](https://isocpp.org/files/papers/P2573R2.html#proposal-scope)).
The major parts are all done, from what I c
dwblaikie wrote:
+1 to @iains's comments about being careful about the introduction and naming
of driver flags & probably avoid it in this case, if possible, or try to make
it clearly experimental.
https://github.com/llvm/llvm-project/pull/85050
___
@@ -54,6 +54,12 @@ ABI Changes in This Version
inline member function that contains a static local variable with a dynamic
initializer is declared with ``__declspec(dllimport)``. (#GH83616).
+- Fixed Microsoft name mangling of lifetime extended temporary objects. This
+ c
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/86526
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the C/C++ code
formatter.
https://github.com/llvm/llvm-project/pull/86526
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the Python code
formatter.
https://github.com/llvm/llvm-project/pull/86526
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
https://github.com/Sirraide updated
https://github.com/llvm/llvm-project/pull/86526
>From 98af47e8ccc633016c14b91c221f9f8fc620f068 Mon Sep 17 00:00:00 2001
From: Sirraide
Date: Mon, 25 Mar 2024 14:46:52 +0100
Subject: [PATCH 1/6] [Clang] Parse `= delete("message")`
---
clang/include/clang/AST
https://github.com/Sirraide edited
https://github.com/llvm/llvm-project/pull/86526
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
aabysswalker wrote:
@farzonl Thank for review, i dont have write access, can you merge the PR? btw,
i spend long time searching for a tests, but these intrinsics werent really
covered, shouldv mentioned that in pr.
https://github.com/llvm/llvm-project/pull/86440
___
@@ -295,6 +295,15 @@ def IMad : DXILOpMapping<48, tertiary, int_dx_imad,
"Signed integer arithmetic multiply/add operation.
imad(m,a,b) = m * a + b.">;
def UMad : DXILOpMapping<49, tertiary, int_dx_umad,
"Unsigned integer arith
Author: Andrii Levitskiy
Date: 2024-03-25T12:42:51-04:00
New Revision: 20392687d38169c7f7de484050e734cb72630b2f
URL:
https://github.com/llvm/llvm-project/commit/20392687d38169c7f7de484050e734cb72630b2f
DIFF:
https://github.com/llvm/llvm-project/commit/20392687d38169c7f7de484050e734cb72630b2f.di
https://github.com/farzonl closed
https://github.com/llvm/llvm-project/pull/86440
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
@aabysswalker Congratulations on having your first Pull Request (PR) merged
into the LLVM Project!
Your changes will be combined with recent changes from other authors, then
tested
by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with
a b
https://github.com/MaskRay closed
https://github.com/llvm/llvm-project/pull/85494
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay wrote:
> > There is a use case to pass customized arguments to main without using
> > -ffreestanding.
>
> This is not motivating for C++ because that's not actually valid to do
> ([eel.is/c++draft/basic.start.main#3.sentence-1](https://eel.is/c++draft/basic.start.main#3.sentence-1)),
>
Author: Aaron Ballman
Date: 2024-03-25T12:55:43-04:00
New Revision: d99cfa053998483e7283e91ff204fbe117345685
URL:
https://github.com/llvm/llvm-project/commit/d99cfa053998483e7283e91ff204fbe117345685
DIFF:
https://github.com/llvm/llvm-project/commit/d99cfa053998483e7283e91ff204fbe117345685.diff
https://github.com/NagyDonat created
https://github.com/llvm/llvm-project/pull/86532
This non-functional change eliminates the compiler warning
```
/repo/llvm-project/clang/include/clang/Basic/SyncScope.h: In member function
‘virtual bool clang::AtomicScopeGenericModel::isValid(unsigned int) co
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (NagyDonat)
Changes
This non-functional change eliminates the compiler warning
```
/repo/llvm-project/clang/include/clang/Basic/SyncScope.h: In member function
‘virtual bool clang::AtomicScopeGenericModel::isValid(unsigned int) const’
NagyDonat wrote:
(By the way, I'm fine with any other resolution that silences this warning.)
https://github.com/llvm/llvm-project/pull/86532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-co
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the Python code
formatter.
https://github.com/llvm/llvm-project/pull/86532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the C/C++ code
formatter.
https://github.com/llvm/llvm-project/pull/86532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
@@ -0,0 +1,278 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --function-signature --check-attributes --check-globals
--include-generated-funcs
+// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature -v9.5a -S
-emit-llvm -
https://github.com/labrinea edited
https://github.com/llvm/llvm-project/pull/86493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ameerj wrote:
@HazardyKnusperkeks @owenca I'd like to request a review please
https://github.com/llvm/llvm-project/pull/84988
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,278 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --function-signature --check-attributes --check-globals
--include-generated-funcs
+// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature -v9.5a -S
-emit-llvm -
https://github.com/jansvoboda11 created
https://github.com/llvm/llvm-project/pull/86534
None
>From 15e732563c77a0990210bc6f9212e6f96d5e727a Mon Sep 17 00:00:00 2001
From: Jan Svoboda
Date: Mon, 25 Mar 2024 10:15:33 -0700
Subject: [PATCH] [clang] Move VFS overlays from `HeaderSearchOptions` to
https://github.com/NagyDonat edited
https://github.com/llvm/llvm-project/pull/86532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/labrinea edited
https://github.com/llvm/llvm-project/pull/86493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the Python code
formatter.
https://github.com/llvm/llvm-project/pull/86534
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff 6b1cf0040059c407264d2609403c4fc090673167
15e732563c77a0990210bc6f9212e6f96d5e727a --
https://github.com/NagyDonat created
https://github.com/llvm/llvm-project/pull/86536
In builds that use source hardening (-D_FORTIFY_SOURCE), many standard
functions are implemented as macros that expand to calls of hardened functions
that take one additional argument compared to the "usual" v
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: None (NagyDonat)
Changes
In builds that use source hardening (-D_FORTIFY_SOURCE), many standard
functions are implemented as macros that expand to calls of hardened functions
that take one additional argument compared to the "usual" varia
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the C/C++ code
formatter.
https://github.com/llvm/llvm-project/pull/86536
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the Python code
formatter.
https://github.com/llvm/llvm-project/pull/86536
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
Stefan =?utf-8?q?Gränitz?=
Message-ID:
In-Reply-To:
amy-kwan wrote:
Hi @weliveindetail!
I just wanted to give a heads up, that I believe
13078cbc3eeb0ae91c370ce0f604f7165b26e0c8 is causing a failure of the
clang-ppc64le-rhel bot:
https://lab.llvm.org/buildbot/#/builders/57/builds/33764/step
NagyDonat wrote:
Note that the build of "ClangReplInterpreterTests" (whatever that may be) fails
on this commit, but it's very likely that this issue is coming from the current
state of the "main" branch.
https://github.com/llvm/llvm-project/pull/86536
https://github.com/Sirraide updated
https://github.com/llvm/llvm-project/pull/86526
>From 98af47e8ccc633016c14b91c221f9f8fc620f068 Mon Sep 17 00:00:00 2001
From: Sirraide
Date: Mon, 25 Mar 2024 14:46:52 +0100
Subject: [PATCH 1/7] [Clang] Parse `= delete("message")`
---
clang/include/clang/AST
@@ -0,0 +1,278 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --function-signature --check-attributes --check-globals
--include-generated-funcs
+// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature -v9.5a -S
-emit-llvm -
https://github.com/jroelofs edited
https://github.com/llvm/llvm-project/pull/86493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/jroelofs approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/86493
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Aaron Ballman
Date: 2024-03-25T13:47:46-04:00
New Revision: bd4086f0464cc6e3e85b57ae58bc6892e777297f
URL:
https://github.com/llvm/llvm-project/commit/bd4086f0464cc6e3e85b57ae58bc6892e777297f
DIFF:
https://github.com/llvm/llvm-project/commit/bd4086f0464cc6e3e85b57ae58bc6892e777297f.diff
Author: Aaron Ballman
Date: 2024-03-25T13:50:10-04:00
New Revision: 32466e55b19586880199347744fc1b76d6b04cfb
URL:
https://github.com/llvm/llvm-project/commit/32466e55b19586880199347744fc1b76d6b04cfb
DIFF:
https://github.com/llvm/llvm-project/commit/32466e55b19586880199347744fc1b76d6b04cfb.diff
@@ -3379,6 +3379,60 @@ Query for this feature with
``__has_builtin(__builtin_debugtrap)``.
Query for this feature with ``__has_builtin(__builtin_trap)``.
+``__builtin_verbose_trap``
ahatanak wrote:
It doesn't look like the existing builtins are in lexicogra
@@ -660,15 +660,23 @@ def Clz : Builtin, BitShort_Int_Long_LongLongTemplate {
let Prototype = "int(unsigned T)";
}
-// FIXME: Add int clzimax(uintmax_t)
+def Clzg : Builtin {
+ let Spellings = ["__builtin_clzg"];
+ let Attributes = [NoThrow, Const, CustomTypeChecking];
---
@@ -660,15 +660,23 @@ def Clz : Builtin, BitShort_Int_Long_LongLongTemplate {
let Prototype = "int(unsigned T)";
}
-// FIXME: Add int clzimax(uintmax_t)
+def Clzg : Builtin {
+ let Spellings = ["__builtin_clzg"];
+ let Attributes = [NoThrow, Const, CustomTypeChecking];
---
@@ -660,15 +660,23 @@ def Clz : Builtin, BitShort_Int_Long_LongLongTemplate {
let Prototype = "int(unsigned T)";
}
-// FIXME: Add int clzimax(uintmax_t)
+def Clzg : Builtin {
+ let Spellings = ["__builtin_clzg"];
+ let Attributes = [NoThrow, Const, CustomTypeChecking];
---
https://github.com/ycdtosa updated
https://github.com/llvm/llvm-project/pull/86486
>From 016152bc21c2625db77d3e31a7123bcf08114133 Mon Sep 17 00:00:00 2001
From: ycdtosa
Date: Mon, 25 Mar 2024 10:28:02 +
Subject: [PATCH 1/3] add test for [[clang::always-destroy]] attribute
user wants the wa
https://github.com/ycdtosa updated
https://github.com/llvm/llvm-project/pull/86486
>From 016152bc21c2625db77d3e31a7123bcf08114133 Mon Sep 17 00:00:00 2001
From: ycdtosa
Date: Mon, 25 Mar 2024 10:28:02 +
Subject: [PATCH 1/4] add test for [[clang::always-destroy]] attribute
user wants the wa
https://github.com/jhuber6 approved this pull request.
https://github.com/llvm/llvm-project/pull/86532
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
ycdtosa wrote:
Mind my English. I hope the wording for the docs is correct.
https://github.com/llvm/llvm-project/pull/86486
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
Author: Aaron Ballman
Date: 2024-03-25T14:20:45-04:00
New Revision: edfa97a8fbd5d8a763c30b083771c679d6a51a31
URL:
https://github.com/llvm/llvm-project/commit/edfa97a8fbd5d8a763c30b083771c679d6a51a31
DIFF:
https://github.com/llvm/llvm-project/commit/edfa97a8fbd5d8a763c30b083771c679d6a51a31.diff
https://github.com/farzonl created
https://github.com/llvm/llvm-project/pull/86555
fixes #86551
closes #86552
Thanks to #86440 and #86407 it makes more sense for us to do type checks early
via Sema to prevent the generation of invalid intrinsics.
>From 8d2d3399cbd69da3af62e5b67ae2785f1edbce
llvmbot wrote:
@llvm/pr-subscribers-hlsl
Author: Farzon Lotfi (farzonl)
Changes
fixes #86551
closes #86552
Thanks to #86440 and #86407 it makes more sense for us to do
type checks early via Sema to prevent the generation of invalid intrinsics.
---
Full diff: https://github.com/llvm/ll
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Farzon Lotfi (farzonl)
Changes
fixes #86551
closes #86552
Thanks to #86440 and #86407 it makes more sense for us to do
type checks early via Sema to prevent the generation of invalid intrinsics.
---
Full diff: https://github.com/llvm/l
github-actions[bot] wrote:
:warning: C/C++ code formatter, clang-format found issues in your code.
:warning:
You can test this locally with the following command:
``bash
git-clang-format --diff ce37a7131ff33bbd04bd1893de78c1bd3a1f0897
7affdb487a88f0c7b31ec20c027ceeaa92f2fe4a --
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the C/C++ code
formatter.
https://github.com/llvm/llvm-project/pull/86555
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the Python code
formatter.
https://github.com/llvm/llvm-project/pull/86555
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
https://github.com/dwblaikie approved this pull request.
LGTM, seems consistent with the previous patch - thanks!
https://github.com/llvm/llvm-project/pull/86401
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mai
https://github.com/bob80905 approved this pull request.
https://github.com/llvm/llvm-project/pull/86555
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
dwblaikie wrote:
Hmm, actually - does this fix address /other/ ways a pack could appear, like
this? https://godbolt.org/z/oez8TbGqM
Presumably a pack could appear in a variety of expressions, not just wrapped in
parens - could be in a function call (as in the above example), or nested
arbitr
@@ -18533,51 +18533,35 @@ Value
*CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID,
}
case AMDGPU::BI__builtin_amdgcn_global_load_tr_b64_i32:
case AMDGPU::BI__builtin_amdgcn_global_load_tr_b64_v2i32:
- case AMDGPU::BI__builtin_amdgcn_global_load_tr_b128_v4bf16:
dwblaikie wrote:
> For those files in the repository that do need CRLF endings, I've adopted a
> policy of eol=crlf which means that git will store them in history with LF,
> but regardless of user config, they'll be checked out in tree with CRLF.
This ^ seems a bit problematic to me, though (
https://github.com/efriedma-quic approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/86377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/efriedma-quic edited
https://github.com/llvm/llvm-project/pull/86377
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -0,0 +1,69 @@
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
UTC_ARGS: --version 4
+// RUN: %clang_cc1 -triple x86_64-linux-gnu -emit-llvm -o - %s | FileCheck %s
+
+
+typedef struct { struct {} a; } empty;
+
+// CHECK-LABEL: define dso_local voi
https://github.com/MaskRay closed
https://github.com/llvm/llvm-project/pull/85668
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
MaskRay wrote:
> Looks like we were able to fix code on our end and this here isn't needed.
> But maybe the current behavior isn't 100% ideal.
Thanks. I am abandoning this workaround.
> Here's what I think the situation currently is (please correct me if I'm
> wrong):
>
> * With clang-cl, yo
https://github.com/farzonl created
https://github.com/llvm/llvm-project/pull/86560
completes #86187
- fix hlsl_intrinsic to cover the correct cases
- move to using `__builtin_elementwise_sqrt`
- add lowering of `Intrinsic::sqrt` to dxilop 24.
>From 5d8b1439d0e6967a4827d60ca39f49a2ad975af7 Mon S
llvmbot wrote:
@llvm/pr-subscribers-backend-x86
Author: Farzon Lotfi (farzonl)
Changes
completes #86187
- fix hlsl_intrinsic to cover the correct cases
- move to using `__builtin_elementwise_sqrt`
- add lowering of `Intrinsic::sqrt` to dxilop 24.
---
Full diff: https://github.com/llvm/llv
https://github.com/llvm-beanz approved this pull request.
https://github.com/llvm/llvm-project/pull/86555
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/llvm-beanz approved this pull request.
https://github.com/llvm/llvm-project/pull/86560
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
fmayer wrote:
I don't have a strong opinion, but fundamentally I would prefer if the source
control system stored exactly the files I have in my checkout, not mess with
them in any way. I understand there are practical concerns, but a linter for
unexpected CRLF would maybe be an option?
https
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the C/C++ code
formatter.
https://github.com/llvm/llvm-project/pull/86560
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the Python code
formatter.
https://github.com/llvm/llvm-project/pull/86560
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
https://github.com/python3kgae approved this pull request.
https://github.com/llvm/llvm-project/pull/86560
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/apache-hb updated
https://github.com/llvm/llvm-project/pull/86426
>From 245a21512d8658225b17b91b8af4764f54084e01 Mon Sep 17 00:00:00 2001
From: Elliot <35050275+apache...@users.noreply.github.com>
Date: Sun, 24 Mar 2024 03:03:47 -0400
Subject: [PATCH 1/4] Match against all plu
@@ -18533,51 +18533,35 @@ Value
*CodeGenFunction::EmitAMDGPUBuiltinExpr(unsigned BuiltinID,
}
case AMDGPU::BI__builtin_amdgcn_global_load_tr_b64_i32:
case AMDGPU::BI__builtin_amdgcn_global_load_tr_b64_v2i32:
- case AMDGPU::BI__builtin_amdgcn_global_load_tr_b128_v4bf16:
https://github.com/cyndyishida closed
https://github.com/llvm/llvm-project/pull/86522
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/changpeng edited
https://github.com/llvm/llvm-project/pull/86313
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/85340
>From 3ba14cb55a85bf8bd0ed0cae43af657c6946acb8 Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Thu, 14 Mar 2024 17:04:12 -0700
Subject: [PATCH 01/15] add test
---
.../clang/Basic/DiagnosticDriverKinds.td
@@ -4827,6 +4827,10 @@ bool TokenAnnotator::spaceRequiredBefore(const
AnnotatedLine &Line,
Right.is(TT_TemplateOpener)) {
return true;
}
+if (Left.is(tok::identifier) && Right.is(tok::numeric_constant) &&
+Right.TokenText[0] == '.') {
@@ -464,10 +464,11 @@ AlignTokenSequence(const FormatStyle &Style, unsigned
Start, unsigned End,
if (i + 1 != Changes.size())
Changes[i + 1].PreviousEndOfTokenColumn += Shift;
-// If PointerAlignment is PAS_Right, keep *s or &s next to the token
+// If Point
@@ -19056,6 +19056,9 @@ TEST_F(FormatTest, AlignConsecutiveDeclarations) {
verifyFormat("inta(int x);\n"
"double b();",
Alignment);
+ verifyFormat("inta(const Test & = Test());\n"
HazardyKnusperkeks wrote:
I wanted to s
https://github.com/aniplcc created
https://github.com/llvm/llvm-project/pull/86571
Fixes #86506
>From c22f63359b7391e9f69d74e5d4f4bdf6cf585c2c Mon Sep 17 00:00:00 2001
From: aniplcc
Date: Tue, 26 Mar 2024 01:35:36 +0530
Subject: [PATCH] [HLSL] Enable -fconvergent-functions by default
---
c
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: aniplcc (aniplcc)
Changes
Fixes #86506
---
Full diff: https://github.com/llvm/llvm-project/pull/86571.diff
1 Files Affected:
- (modified) clang/lib/Frontend/CompilerInvocation.cpp (+3-2)
``diff
diff --git a/clang/lib/Fronte
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the C/C++ code
formatter.
https://github.com/llvm/llvm-project/pull/86571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the Python code
formatter.
https://github.com/llvm/llvm-project/pull/86571
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
https://github.com/bob80905 updated
https://github.com/llvm/llvm-project/pull/85340
>From 74a869a282d532ec426dbc1c954779ec2972aa5c Mon Sep 17 00:00:00 2001
From: Joshua Batista
Date: Thu, 14 Mar 2024 17:04:12 -0700
Subject: [PATCH 01/15] add test
---
.../clang/Basic/DiagnosticDriverKinds.td
hdoc wrote:
Ping
https://github.com/llvm/llvm-project/pull/84726
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
@@ -2218,6 +2218,11 @@ struct FormatStyle {
/// \version 3.8
bool BreakAfterJavaFieldAnnotations;
+ /// If ``true``, clang-format will always break before function definition
+ /// parameters
HazardyKnusperkeks wrote:
```suggestion
/// parameters.
```
@@ -5317,6 +5318,12 @@ bool TokenAnnotator::mustBreakBefore(const AnnotatedLine
&Line,
if (Right.NewlinesBefore > 1 && Style.MaxEmptyLinesToKeep > 0)
return true;
+ if (Style.BreakFunctionDefinitionParameters && Line.MightBeFunctionDecl &&
HazardyKnusp
@@ -2218,6 +2218,11 @@ struct FormatStyle {
/// \version 3.8
bool BreakAfterJavaFieldAnnotations;
+ /// If ``true``, clang-format will always break before function definition
+ /// parameters
+ /// \version 19
+ bool BreakFunctionDefinitionParameters;
@@ -7951,6 +7951,24 @@ TEST_F(FormatTest, AllowAllArgumentsOnNextLineDontAlign)
{
Input, Style);
}
+TEST_F(FormatTest, BreakFunctionDefinitionParameters) {
+ FormatStyle Style = getLLVMStyleWithColumns(80);
HazardyKnusperkeks wrote:
```sugges
llvmbot wrote:
@llvm/pr-subscribers-clang
Author: Cyndy Ishida (cyndyishida)
Changes
---
Patch is 167.28 KiB, truncated to 20.00 KiB below, full version:
https://github.com/llvm/llvm-project/pull/86574.diff
23 Files Affected:
- (modified) clang/include/clang/Basic/DiagnosticInstallA
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the C/C++ code
formatter.
https://github.com/llvm/llvm-project/pull/86574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/ma
github-actions[bot] wrote:
:white_check_mark: With the latest revision this PR passed the Python code
formatter.
https://github.com/llvm/llvm-project/pull/86574
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
https://github.com/rayroudc updated
https://github.com/llvm/llvm-project/pull/86254
>From 3d4d9d701ee39d0bd4d60e4d0cd4a8577ce085d7 Mon Sep 17 00:00:00 2001
From: "C. Rayroud"
Date: Mon, 18 Mar 2024 06:39:26 +
Subject: [PATCH 1/2] [clang-format] Fix anonymous reference parameter with
defaul
@@ -19056,6 +19056,9 @@ TEST_F(FormatTest, AlignConsecutiveDeclarations) {
verifyFormat("inta(int x);\n"
"double b();",
Alignment);
+ verifyFormat("inta(const Test & = Test());\n"
rayroudc wrote:
Got it, I have added a
201 - 300 of 448 matches
Mail list logo
