[clang] [codegen] Emit missing cleanups for stmt-expr and coro suspensions [take-2] (PR #85398)

2024-03-25 Thread Aaron Ballman via cfe-commits
@@ -2503,6 +2505,26 @@ Stmt *BlockExpr::getBody() { // Generic Expression Routines //===--===// +bool Expr::mayBranchOut() const { + struct BranchDetector : public RecursiveASTVisitor { +bool HasBranch =

[clang] [codegen] Emit missing cleanups for stmt-expr and coro suspensions [take-2] (PR #85398)

2024-03-25 Thread Aaron Ballman via cfe-commits
@@ -2503,6 +2505,26 @@ Stmt *BlockExpr::getBody() { // Generic Expression Routines //===--===// +bool Expr::mayBranchOut() const { + struct BranchDetector : public RecursiveASTVisitor { +bool HasBranch =

[clang] [APINotes] Upstream the remaining API Notes fixes and tests (PR #84773)

2024-03-25 Thread Egor Zhdan via cfe-commits
egorzhdan wrote: @compnerd I think I addressed all of your comments, let me know if this is good to go! https://github.com/llvm/llvm-project/pull/84773 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[clang] e6f63a9 - [clang][dataflow] Bail out if input is Objective-C++. (#86479)

2024-03-25 Thread via cfe-commits
Author: martinboehme Date: 2024-03-25T14:08:25+01:00 New Revision: e6f63a942a45e3545332cd9a43982a69a4d5667b URL: https://github.com/llvm/llvm-project/commit/e6f63a942a45e3545332cd9a43982a69a4d5667b DIFF: https://github.com/llvm/llvm-project/commit/e6f63a942a45e3545332cd9a43982a69a4d5667b.diff

[clang] [clang][dataflow] Bail out if input is Objective-C++. (PR #86479)

2024-03-25 Thread via cfe-commits
https://github.com/martinboehme closed https://github.com/llvm/llvm-project/pull/86479 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Interp] Merge ByteCodeExprGen and ByteCodeStmtGen (PR #83683)

2024-03-25 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/AaronBallman commented: Splitting the code across a few implementation files might be a reasonable approach, but in general, I'm fine with how this is proceeding. I reviewed t

[clang] [clang][Interp] Integral pointers (PR #84159)

2024-03-25 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/84159 ___ cfe-commits

[clang] [clang][Interp] Integral pointers (PR #84159)

2024-03-25 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: https://github.com/AaronBallman approved this pull request. Basically LGTM, just a few minor things. https://github.com/

[clang] [clang][Interp] Integral pointers (PR #84159)

2024-03-25 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= , Timm =?utf-8?q?B=C3=A4der?= Message-ID: In-Reply-To: @@ -1912,6 +1929,10 @@ inline bool NoRet(InterpState &S, CodePtr OpPC) { inline bool NarrowPtr(InterpS

[clang] [clang][Interp] Integral pointers (PR #84159)

2024-03-25 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -199,6 +207,41 @@ bool ByteCodeExprGen::VisitCastExpr(const CastExpr *CE) { return true; } + case CK_IntegralToPoin

[clang] [clang][Interp] Integral pointers (PR #84159)

2024-03-25 Thread Aaron Ballman via cfe-commits
Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= , Timm =?utf-8?q?Bäder?= Message-ID: In-Reply-To: @@ -2218,6 +2238,14 @@ inline bool GetFnPtr(InterpState &S, CodePtr OpPC, const Function *Func) { return true; } +template

[clang] Split -Wcast-function-type into a separate group (PR #86131)

2024-03-25 Thread Amy Kwan via cfe-commits
amy-kwan wrote: Hi @Abhinkop! I was wondering if there was any progress regarding the patch to resolve the stage 2 failure, as our bot is still red (https://lab.llvm.org/buildbot/#/builders/36/builds/43929/steps/12/logs/stdio). Please let me know if you would also like me to test any patches, a

[clang] [HLSL] Remove double pow intrinsics (PR #86407)

2024-03-25 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. Nice catch! Thank you! https://github.com/llvm/llvm-project/pull/86407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Fix assertion failure when printing atomic apvalues (PR #85259)

2024-03-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: LGTM but this should be testable because `getAsString()` uses `printPretty()`: https://github.com/llvm/llvm-project/blob/e6f63a942a45e3545332cd9a43982a69a4d5667b/clang/lib/AST/Interp/FunctionPointer.h#L53, https://github.com/llvm/llvm-project/blob/e6f

[clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-03-25 Thread Tobias Hieta via cfe-commits
tru wrote: > I think .natvis files should be CRLF (those are used with Visual Studio for > debug visualizers). Agreed, Visual Studio should handle this correctly, but who knows 🤷🏼 https://github.com/llvm/llvm-project/pull/86318 ___ cfe-commits maili

[clang] Match against all plugins when parsing microsoft attributes (PR #86426)

2024-03-25 Thread Aaron Ballman via cfe-commits
@@ -5061,11 +5061,15 @@ void Parser::ParseMicrosoftAttributes(ParsedAttributes &Attrs) { IdentifierInfo *II = Tok.getIdentifierInfo(); SourceLocation NameLoc = Tok.getLocation(); ConsumeToken(); -ParsedAttr::Kind AttrKind = -ParsedAt

[clang-tools-extra] [clang-tidy] Added bugprone-exception-rethrow check (PR #86448)

2024-03-25 Thread via cfe-commits
@@ -0,0 +1,68 @@ +.. title:: clang-tidy - bugprone-exception-rethrow + +bugprone-exception-rethrow +== + +Identifies problematic exception rethrowing, especially with caught exception +variables or empty throw statements outside catch blocks. + +In C++ exce

[clang] Split -Wcast-function-type into a separate group (PR #86131)

2024-03-25 Thread Abhin P Jose via cfe-commits
Abhinkop wrote: > Hi @Abhinkop! I was wondering if there was any progress regarding the patch > to resolve the stage 2 failure, as our bot is still red > (https://lab.llvm.org/buildbot/#/builders/36/builds/43929/steps/12/logs/stdio). > Please let me know if you would also like me to test any p

[clang] [codegen] Emit missing cleanups for stmt-expr and coro suspensions [take-2] (PR #85398)

2024-03-25 Thread Utkarsh Saxena via cfe-commits
@@ -2503,6 +2505,26 @@ Stmt *BlockExpr::getBody() { // Generic Expression Routines //===--===// +bool Expr::mayBranchOut() const { + struct BranchDetector : public RecursiveASTVisitor { +bool HasBranch =

[clang] Fix printing of templated records. (PR #86339)

2024-03-25 Thread Zahira Ammarguellat via cfe-commits
https://github.com/zahiraam ready_for_review https://github.com/llvm/llvm-project/pull/86339 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-03-25 Thread via cfe-commits
ldrumm wrote: On Mon Mar 25, 2024 at 1:48 PM GMT, Tobias Hieta wrote: > > I think .natvis files should be CRLF (those are used with Visual Studio for > > debug visualizers). > > Agreed, Visual Studio should handle this correctly, but who knows > 🤷🏼 > Thanks. I'll add a rule and update https:

[clang] Fix printing of templated records. (PR #86339)

2024-03-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Zahira Ammarguellat (zahiraam) Changes Fixed the printing of templated argument list and added test case. --- Full diff: https://github.com/llvm/llvm-project/pull/86339.diff 2 Files Affected: - (modified) clang/lib/AST/TypePrinter.cpp (

[clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-03-25 Thread Chris B via cfe-commits
llvm-beanz wrote: Philosophically I agree with this change, but I think some subprojects may need to adopt specific policies about how they handle files that are expected to be specific line endings. Specifically, Clang needs testing that verifies correct behavior on both CRLF and LF files in

[clang] [codegen] Emit missing cleanups for stmt-expr and coro suspensions [take-2] (PR #85398)

2024-03-25 Thread Utkarsh Saxena via cfe-commits
@@ -2503,6 +2505,26 @@ Stmt *BlockExpr::getBody() { // Generic Expression Routines //===--===// +bool Expr::mayBranchOut() const { + struct BranchDetector : public RecursiveASTVisitor { +bool HasBranch =

[clang] [codegen] Emit missing cleanups for stmt-expr and coro suspensions [take-2] (PR #85398)

2024-03-25 Thread Utkarsh Saxena via cfe-commits
@@ -2503,6 +2505,26 @@ Stmt *BlockExpr::getBody() { // Generic Expression Routines //===--===// +bool Expr::mayBranchOut() const { + struct BranchDetector : public RecursiveASTVisitor { +bool HasBranch =

[clang] [codegen] Emit missing cleanups for stmt-expr and coro suspensions [take-2] (PR #85398)

2024-03-25 Thread Utkarsh Saxena via cfe-commits
@@ -2503,6 +2505,26 @@ Stmt *BlockExpr::getBody() { // Generic Expression Routines //===--===// +bool Expr::mayBranchOut() const { + struct BranchDetector : public RecursiveASTVisitor { +bool HasBranch =

[clang] [codegen] Emit missing cleanups for stmt-expr and coro suspensions [take-2] (PR #85398)

2024-03-25 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/85398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [clang][HLSL][SPRI-V] Add convergence intrinsics (PR #80680)

2024-03-25 Thread Chris B via cfe-commits
Nathan =?utf-8?q?Gauër?= , Nathan =?utf-8?q?Gauër?= , Nathan =?utf-8?q?Gauër?= , Nathan =?utf-8?q?Gauër?= , Nathan =?utf-8?q?Gauër?= , Nathan =?utf-8?q?Gauër?= , Nathan =?utf-8?q?Gauër?= Message-ID: In-Reply-To: @@ -1295,11 +1295,13 @@ double4 trunc(double4); /// true, across

[clang] [llvm] [clang][HLSL][SPRI-V] Add convergence intrinsics (PR #80680)

2024-03-25 Thread Chris B via cfe-commits
Nathan =?utf-8?q?Gau=C3=ABr?= , Nathan =?utf-8?q?Gau=C3=ABr?= , Nathan =?utf-8?q?Gau=C3=ABr?= , Nathan =?utf-8?q?Gau=C3=ABr?= , Nathan =?utf-8?q?Gau=C3=ABr?= , Nathan =?utf-8?q?Gau=C3=ABr?= , Nathan =?utf-8?q?Gau=C3=ABr?= Message-ID: In-Reply-To: @@ -1295,11 +1295,13 @@ double4

[clang] [codegen] Emit missing cleanups for stmt-expr and coro suspensions [take-2] (PR #85398)

2024-03-25 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/85398 >From 0654f624b3b60026398e8b0168623a85e3129630 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Fri, 15 Mar 2024 13:19:36 + Subject: [PATCH 1/5] [codegen] Emit cleanups for branch in stmt-expr and coro suspe

[clang] [[clang::always-destroy]] attribute silences warn-exit-time-destructor (PR #86486)

2024-03-25 Thread via cfe-commits
ycdtosa wrote: @AaronBallman I finally got some time to prepare this PR, but I am not familiar with the approval process. It also seems that you have commit rights, so there! Still, I fell the test might be incomplete. https://github.com/llvm/llvm-project/pull/86486 ___

[clang] ded6252 - [CMake][HLSL] Add SPIRV to target list for build (#86323)

2024-03-25 Thread via cfe-commits
Author: Chris B Date: 2024-03-25T09:16:18-05:00 New Revision: ded6252dfd96ee8904b6d2250bc9e4841ca5c802 URL: https://github.com/llvm/llvm-project/commit/ded6252dfd96ee8904b6d2250bc9e4841ca5c802 DIFF: https://github.com/llvm/llvm-project/commit/ded6252dfd96ee8904b6d2250bc9e4841ca5c802.diff LOG:

[clang] [CMake][HLSL] Add SPIRV to target list for build (PR #86323)

2024-03-25 Thread Chris B via cfe-commits
https://github.com/llvm-beanz closed https://github.com/llvm/llvm-project/pull/86323 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [codegen] Emit missing cleanups for stmt-expr and coro suspensions [take-2] (PR #85398)

2024-03-25 Thread via cfe-commits
github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the C/C++ code formatter. https://github.com/llvm/llvm-project/pull/85398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [codegen] Emit missing cleanups for stmt-expr and coro suspensions [take-2] (PR #85398)

2024-03-25 Thread via cfe-commits
github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the Python code formatter. https://github.com/llvm/llvm-project/pull/85398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] 32b8283 - [analyzer] Set and display CSA analysis entry points as notes on debugging (#84823)

2024-03-25 Thread via cfe-commits
Author: Balazs Benics Date: 2024-03-25T15:24:03+01:00 New Revision: 32b828306e346bc8e86c0b763f3514329de60ed1 URL: https://github.com/llvm/llvm-project/commit/32b828306e346bc8e86c0b763f3514329de60ed1 DIFF: https://github.com/llvm/llvm-project/commit/32b828306e346bc8e86c0b763f3514329de60ed1.diff

[clang] [analyzer] Set and display CSA analysis entry points as notes on debugging (PR #84823)

2024-03-25 Thread Balazs Benics via cfe-commits
https://github.com/steakhal closed https://github.com/llvm/llvm-project/pull/84823 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [codegen] Emit missing cleanups for stmt-expr and coro suspensions [take-2] (PR #85398)

2024-03-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: I didn't look too hard at the codegen bits, but the Expr bits look good to me. Perhaps we want this test to live in CodeGen rather than CodeGenCoroutines given that it covers so many non-coroutine test cases as well? https://github.com/llvm/llvm-proje

[clang] [[clang::always_destroy]] attribute silences warn-exit-time-destructor (PR #86486)

2024-03-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/86486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [[clang::always_destroy]] attribute silences warn-exit-time-destructor (PR #86486)

2024-03-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/86486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [codegen] Emit missing cleanups for stmt-expr and coro suspensions [take-2] (PR #85398)

2024-03-25 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 edited https://github.com/llvm/llvm-project/pull/85398 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] bea17ff - [clang] Correct Microsoft mangling of lifetime extended temporary objects. (#85529)

2024-03-25 Thread via cfe-commits
Author: Tom Honermann Date: 2024-03-25T10:39:05-04:00 New Revision: bea17ff652bc49b2de8d6be04f77d28170a78be9 URL: https://github.com/llvm/llvm-project/commit/bea17ff652bc49b2de8d6be04f77d28170a78be9 DIFF: https://github.com/llvm/llvm-project/commit/bea17ff652bc49b2de8d6be04f77d28170a78be9.diff

[clang] [[clang::always_destroy]] attribute silences warn-exit-time-destructor (PR #86486)

2024-03-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman commented: Thank you for the fix! I have another suggested test case, and please be sure to add a release note to clang/docs/ReleaseNotes.rst so users know about the fix. Also, I think AttrDocs.td should be updated to document the fact that `always_destroy` will

[clang] [[clang::always_destroy]] attribute silences warn-exit-time-destructor (PR #86486)

2024-03-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/86486 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Correct Microsoft mangling of lifetime extended temporary objects. (PR #85529)

2024-03-25 Thread Tom Honermann via cfe-commits
https://github.com/tahonermann closed https://github.com/llvm/llvm-project/pull/85529 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [[clang::always_destroy]] attribute silences warn-exit-time-destructor (PR #86486)

2024-03-25 Thread Aaron Ballman via cfe-commits
@@ -51,6 +51,11 @@ struct A { ~A(); }; } namespace test5 { +struct A { ~A(); }; +[[clang::always_destroy]] A a; // no warning +} + AaronBallman wrote: ```suggestion struct A { ~A(); }; [[clang::always_destroy]] A a; // no warning void func() { [[clang::alw

[clang] [codegen] Emit missing cleanups for stmt-expr and coro suspensions [take-2] (PR #85398)

2024-03-25 Thread Utkarsh Saxena via cfe-commits
https://github.com/usx95 updated https://github.com/llvm/llvm-project/pull/85398 >From 0654f624b3b60026398e8b0168623a85e3129630 Mon Sep 17 00:00:00 2001 From: Utkarsh Saxena Date: Fri, 15 Mar 2024 13:19:36 + Subject: [PATCH 1/6] [codegen] Emit cleanups for branch in stmt-expr and coro suspe

[clang] [codegen] Emit missing cleanups for stmt-expr and coro suspensions [take-2] (PR #85398)

2024-03-25 Thread Utkarsh Saxena via cfe-commits
usx95 wrote: > Perhaps we want this test to live in CodeGen rather than CodeGenCoroutines > given that it covers so many non-coroutine test cases as well? Makes sense. I split the tests into coroutine and stmt-expr (didn't want to depend on "Inputs/coroutine.h" from CodegenCXX). https://gith

[clang] [NFC] Refactor ConstantArrayType size storage (PR #85716)

2024-03-25 Thread Chris B via cfe-commits
https://github.com/llvm-beanz updated https://github.com/llvm/llvm-project/pull/85716 >From 4a11a73b4dd41637b1d730489954c2994489d6be Mon Sep 17 00:00:00 2001 From: Chris Bieneman Date: Mon, 18 Mar 2024 17:30:41 -0500 Subject: [PATCH 1/2] [NFC] Refactor ConstantArrayType size storage In PR #793

[clang] [NFC] Refactor ConstantArrayType size storage (PR #85716)

2024-03-25 Thread via cfe-commits
github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the Python code formatter. https://github.com/llvm/llvm-project/pull/85716 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [clang] Implement a bitwise_copyable builtin type trait. (PR #86512)

2024-03-25 Thread Haojian Wu via cfe-commits
https://github.com/hokein created https://github.com/llvm/llvm-project/pull/86512 This patch implements a `__is_bitwise_copyable` builtin in clang. The bitwise copyable types act as the trivially copyable types, but they support a wider range of types (e.g. classes with virtual methods) -- the

[clang] [clang] Implement a bitwise_copyable builtin type trait. (PR #86512)

2024-03-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Haojian Wu (hokein) Changes This patch implements a `__is_bitwise_copyable` builtin in clang. The bitwise copyable types act as the trivially copyable types, but they support a wider range of types (e.g. classes with virtual methods) -- t

[clang] Use timeTraceAsyncProfilerBegin for Source span (PR #83961)

2024-03-25 Thread Zequan Wu via cfe-commits
https://github.com/ZequanWu approved this pull request. https://github.com/llvm/llvm-project/pull/83961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Use timeTraceAsyncProfilerBegin for Source span (PR #83961)

2024-03-25 Thread Zequan Wu via cfe-commits
https://github.com/ZequanWu edited https://github.com/llvm/llvm-project/pull/83961 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] Use timeTraceAsyncProfilerBegin for Source span (PR #83961)

2024-03-25 Thread Zequan Wu via cfe-commits
@@ -102,23 +104,24 @@ struct llvm::TimeTraceProfiler { llvm::get_thread_name(ThreadName); } - void begin(std::string Name, llvm::function_ref Detail) { -Stack.emplace_back(ClockType::now(), TimePointType(), std::move(Name), - Detail()); + Time

[clang] [clang] Implement a bitwise_copyable builtin type trait. (PR #86512)

2024-03-25 Thread via cfe-commits
github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the Python code formatter. https://github.com/llvm/llvm-project/pull/86512 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [Clang][analyzer] add documentation for optin performance padding (padding checker) #73675 (PR #86411)

2024-03-25 Thread Balazs Benics via cfe-commits
https://github.com/steakhal edited https://github.com/llvm/llvm-project/pull/86411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Implement a bitwise_copyable builtin type trait. (PR #86512)

2024-03-25 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 5a744776bb6192dae04360609457c9f49dce43a2 481627e3bacf2e9fa5ca71adece32e4ca5fa94ef --

[clang] [Clang][analyzer] add documentation for optin performance padding (padding checker) #73675 (PR #86411)

2024-03-25 Thread Balazs Benics via cfe-commits
@@ -804,10 +804,38 @@ Check for performance anti-patterns when using Grand Central Dispatch. .. _optin-performance-Padding: -optin.performance.Padding -" +optin.performance.Padding (C, C++, ObjC) + Check for ex

[clang] [Clang][analyzer] add documentation for optin performance padding (padding checker) #73675 (PR #86411)

2024-03-25 Thread Balazs Benics via cfe-commits
@@ -804,10 +804,38 @@ Check for performance anti-patterns when using Grand Central Dispatch. .. _optin-performance-Padding: -optin.performance.Padding -" +optin.performance.Padding (C, C++, ObjC) + Check for ex

[clang] [Clang][analyzer] add documentation for optin performance padding (padding checker) #73675 (PR #86411)

2024-03-25 Thread Balazs Benics via cfe-commits
@@ -804,10 +804,38 @@ Check for performance anti-patterns when using Grand Central Dispatch. .. _optin-performance-Padding: -optin.performance.Padding -" +optin.performance.Padding (C, C++, ObjC) + Check for ex

[clang] [Clang][analyzer] add documentation for optin performance padding (padding checker) #73675 (PR #86411)

2024-03-25 Thread Balazs Benics via cfe-commits
@@ -804,10 +804,38 @@ Check for performance anti-patterns when using Grand Central Dispatch. .. _optin-performance-Padding: -optin.performance.Padding -" +optin.performance.Padding (C, C++, ObjC) + Check for ex

[clang] [Clang][analyzer] add documentation for optin performance padding (padding checker) #73675 (PR #86411)

2024-03-25 Thread Balazs Benics via cfe-commits
https://github.com/steakhal requested changes to this pull request. The grammar seems good. I have further concerns inline. https://github.com/llvm/llvm-project/pull/86411 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/c

[clang] [HLSL] Remove double pow intrinsics (PR #86407)

2024-03-25 Thread Robin Caloudis via cfe-commits
robincaloudis wrote: @llvm-beanz, thanks for the review. I miss write access. Can you merge the PR? Thanks. https://github.com/llvm/llvm-project/pull/86407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [clang] Factor out OpenACC part of `Sema` (PR #84184)

2024-03-25 Thread Aaron Ballman via cfe-commits
@@ -0,0 +1,74 @@ +//===- SemaOpenACC.h - Semantic Analysis for OpenACC constructs ---===// +// +// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions. +// See https://llvm.org/LICENSE.txt for license information. +// SPDX-License-Identifier: Apa

[clang] [clang-tools-extra] [compiler-rt] [flang] [lld] [lldb] [llvm] [mlir] [openmp] [pstl] Finally formalise our defacto line-ending policy (PR #86318)

2024-03-25 Thread via cfe-commits
ldrumm wrote: > Should we come up with an expected filename format that we can use with > gitattributes and rename the existing files rather than just listing each > file that has special needs by itself? Either way, the author has to do or know *something*. I'm not a fan of "magic" like this

[clang] [llvm] [Sema] Implement support for -Wformat-signedness (PR #74440)

2024-03-25 Thread Aaron Ballman via cfe-commits
AaronBallman wrote: > > Can you also add a test showing the difference between `-Wformat > > -Wformat-signedness` and `-Wformat-signedness` by itself (which does > > nothing)? > > With the current implementation `-Wformat-signedness` by itself actually turn > on the signedness warnings. This

[clang] [clang] Emit bad shift warnings (PR #70307)

2024-03-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman requested changes to this pull request. https://github.com/llvm/llvm-project/pull/70307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Emit bad shift warnings (PR #70307)

2024-03-25 Thread Aaron Ballman via cfe-commits
@@ -19959,7 +19961,10 @@ bool Sema::DiagRuntimeBehavior(SourceLocation Loc, ArrayRef Stmts, case ExpressionEvaluationContext::ConstantEvaluated: case ExpressionEvaluationContext::ImmediateFunctionContext: // Relevant diagnostics should be produced by constant evaluatio

[clang] [clang] Emit bad shift warnings (PR #70307)

2024-03-25 Thread Aaron Ballman via cfe-commits
@@ -11523,9 +11525,9 @@ static void DiagnoseBadShiftValues(Sema& S, ExprResult &LHS, ExprResult &RHS, } S.Diag(Loc, diag::warn_shift_result_gt_typewidth) -<< HexResult.str() << Result.getMinSignedBits() << LHSType -<< Left.getBitWidth() << LHS.get()->getSourceRang

[clang] [clang] Emit bad shift warnings (PR #70307)

2024-03-25 Thread Aaron Ballman via cfe-commits
https://github.com/AaronBallman edited https://github.com/llvm/llvm-project/pull/70307 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Emit bad shift warnings (PR #70307)

2024-03-25 Thread Aaron Ballman via cfe-commits
@@ -2805,7 +2805,7 @@ static bool handleIntIntBinOp(EvalInfo &Info, const Expr *E, const APSInt &LHS, unsigned SA = (unsigned) RHS.getLimitedValue(LHS.getBitWidth()-1); if (SA != RHS) { Info.CCEDiag(E, diag::note_constexpr_large_shift) -<< RHS << E->getTy

[clang] [clang] Emit bad shift warnings (PR #70307)

2024-03-25 Thread Aaron Ballman via cfe-commits
@@ -11428,7 +11428,7 @@ static bool isScopedEnumerationType(QualType T) { return false; } -static void DiagnoseBadShiftValues(Sema& S, ExprResult &LHS, ExprResult &RHS, +static void DiagnoseBadShiftValues(Sema &S, ExprResult &LHS, ExprResult &RHS, AaronBallm

[clang] [Clang][AArch64] Warn when calling streaming/non-streaming about vect… (PR #79842)

2024-03-25 Thread Sander de Smalen via cfe-commits
@@ -7516,28 +7516,23 @@ void Sema::checkCall(NamedDecl *FDecl, const FunctionProtoType *Proto, } } -auto *CallerFD = dyn_cast(CurContext); -bool IsCalleeStreaming = -(ExtInfo.AArch64SMEAttributes & FunctionType::SME_PStateSMEnabledMask); -bool Is

[clang] [Clang][AArch64] Warn when calling streaming/non-streaming about vect… (PR #79842)

2024-03-25 Thread Sander de Smalen via cfe-commits
@@ -1390,6 +1390,9 @@ def MultiGPU: DiagGroup<"multi-gpu">; // libc and the CRT to be skipped. def AVRRtlibLinkingQuirks : DiagGroup<"avr-rtlib-linking-quirks">; +// A warning group AArch64 related to SME function attribues. sdesmalen-arm wrote: nit: Sorry, j

[clang] [Clang][AArch64] Warn when calling streaming/non-streaming about vect… (PR #79842)

2024-03-25 Thread Sander de Smalen via cfe-commits
@@ -3717,6 +3717,16 @@ def err_sme_definition_using_za_in_non_sme_target : Error< "function using ZA state requires 'sme'">; def err_sme_definition_using_zt0_in_non_sme2_target : Error< "function using ZT0 state requires 'sme2'">; +def warn_sme_streaming_pass_return_vl_to_

[clang] [FMV] Allow mixing target_version with target_clones. (PR #86493)

2024-03-25 Thread Jon Roelofs via cfe-commits
@@ -0,0 +1,278 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --function-signature --check-attributes --check-globals --include-generated-funcs +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature -v9.5a -S -emit-llvm -

[clang] [llvm] [InstallAPI] Add --extra* and --exclude* cli options for header input (PR #86522)

2024-03-25 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Cyndy Ishida (cyndyishida) Changes InstallAPI takes a json list of headers that is typically generated from a build system like Xcode based on a project's attributes. Sometimes, maintainers may want to alter this for tapi input. Using e.g

[clang] [FMV] Allow mixing target_version with target_clones. (PR #86493)

2024-03-25 Thread Jon Roelofs via cfe-commits
@@ -0,0 +1,278 @@ +// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py UTC_ARGS: --function-signature --check-attributes --check-globals --include-generated-funcs +// RUN: %clang_cc1 -triple aarch64-none-linux-gnu -target-feature -v9.5a -S -emit-llvm -

[clang] [HLSL] Remove double pow intrinsics (PR #86407)

2024-03-25 Thread Farzon Lotfi via cfe-commits
farzonl wrote: @robincaloudis Thanks this is what I was looking for. https://github.com/llvm/llvm-project/pull/86407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [InstallAPI] Add --extra* and --exclude* cli options for header input (PR #86522)

2024-03-25 Thread via cfe-commits
github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the C/C++ code formatter. https://github.com/llvm/llvm-project/pull/86522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [llvm] [InstallAPI] Add --extra* and --exclude* cli options for header input (PR #86522)

2024-03-25 Thread via cfe-commits
github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the Python code formatter. https://github.com/llvm/llvm-project/pull/86522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [HLSL] Remove double pow intrinsics (PR #86407)

2024-03-25 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl approved this pull request. https://github.com/llvm/llvm-project/pull/86407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] Remove double pow intrinsics (PR #86407)

2024-03-25 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl closed https://github.com/llvm/llvm-project/pull/86407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 2b351a3 - [HLSL] Remove double pow intrinsics (#86407)

2024-03-25 Thread via cfe-commits
Author: Robin Caloudis Date: 2024-03-25T12:00:43-04:00 New Revision: 2b351a3b76b8e58414fb51ff52978c79904ab331 URL: https://github.com/llvm/llvm-project/commit/2b351a3b76b8e58414fb51ff52978c79904ab331 DIFF: https://github.com/llvm/llvm-project/commit/2b351a3b76b8e58414fb51ff52978c79904ab331.diff

[clang] [HLSL] Remove double pow intrinsics (PR #86407)

2024-03-25 Thread Farzon Lotfi via cfe-commits
farzonl wrote: > @llvm-beanz, thanks for the review. I miss write access. Can you merge the > PR? Thanks. I got you! https://github.com/llvm/llvm-project/pull/86407 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[clang] 6fd3677 - Fixing a think-o with swapped information

2024-03-25 Thread Aaron Ballman via cfe-commits
Author: Aaron Ballman Date: 2024-03-25T12:01:48-04:00 New Revision: 6fd3677fb4f4e806f2efa43bfa814aaf063c506c URL: https://github.com/llvm/llvm-project/commit/6fd3677fb4f4e806f2efa43bfa814aaf063c506c DIFF: https://github.com/llvm/llvm-project/commit/6fd3677fb4f4e806f2efa43bfa814aaf063c506c.diff

[clang] [Clang][Sema] Allow flexible arrays in unions and alone in structs (PR #84428)

2024-03-25 Thread Kees Cook via cfe-commits
https://github.com/kees updated https://github.com/llvm/llvm-project/pull/84428 >From eb5138b45fa450737600050ad8dabdcb27513d42 Mon Sep 17 00:00:00 2001 From: Kees Cook Date: Thu, 7 Mar 2024 17:03:09 -0800 Subject: [PATCH 1/8] [Clang][Sema]: Allow flexible arrays in unions and alone in structs

[clang] [HLSL] remove double impelementation of log, sin, trunc intrinsics (PR #86440)

2024-03-25 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl requested changes to this pull request. This isn't going to work. You have to also fix the tests aswell. https://github.com/llvm/llvm-project/pull/86440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.ll

[clang] [Clang][Sema] Allow flexible arrays in unions and alone in structs (PR #84428)

2024-03-25 Thread via cfe-commits
github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the Python code formatter. https://github.com/llvm/llvm-project/pull/84428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [Clang][Sema] Allow flexible arrays in unions and alone in structs (PR #84428)

2024-03-25 Thread via cfe-commits
github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the C/C++ code formatter. https://github.com/llvm/llvm-project/pull/84428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [llvm] [InstallAPI] Add --extra* and --exclude* cli options for header input (PR #86522)

2024-03-25 Thread Juergen Ributzka via cfe-commits
https://github.com/ributzka approved this pull request. https://github.com/llvm/llvm-project/pull/86522 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] remove double impelementation of log, sin, trunc intrinsics (PR #86440)

2024-03-25 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/86440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] remove double impelementation of log, sin, trunc intrinsics (PR #86440)

2024-03-25 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl approved this pull request. https://github.com/llvm/llvm-project/pull/86440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] remove double impelementation of log, sin, trunc intrinsics (PR #86440)

2024-03-25 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/86440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] remove double impelementation of log, sin, trunc intrinsics (PR #86440)

2024-03-25 Thread via cfe-commits
github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the C/C++ code formatter. https://github.com/llvm/llvm-project/pull/86440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [HLSL] remove double impelementation of log, sin, trunc intrinsics (PR #86440)

2024-03-25 Thread via cfe-commits
github-actions[bot] wrote: :white_check_mark: With the latest revision this PR passed the Python code formatter. https://github.com/llvm/llvm-project/pull/86440 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/m

[clang] [[clang::always_destroy]] attribute silences warn-exit-time-destructor (PR #86486)

2024-03-25 Thread via cfe-commits
@@ -51,6 +51,11 @@ struct A { ~A(); }; } namespace test5 { +struct A { ~A(); }; +[[clang::always_destroy]] A a; // no warning +} + ycdtosa wrote: Yup. I will do. https://github.com/llvm/llvm-project/pull/86486 ___

[clang] [llvm] [DXIL] Add Float `Dot` Intrinsic Lowering (PR #86071)

2024-03-25 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/86071 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang] Implement P2573R2: `= delete("should have a reason");` (PR #86526)

2024-03-25 Thread via cfe-commits
https://github.com/Sirraide created https://github.com/llvm/llvm-project/pull/86526 This implements support for the `= delete("message")` syntax that was only just added to C++26 ([P2573R2](https://isocpp.org/files/papers/P2573R2.html#proposal-scope)). The major parts are all done, from what

<    1   2   3   4   5   >