[clang] [X86] Finally handle target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2/avx (PR #84136)

2024-03-08 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 commented: Thanks for the heads-up @RKSimon I've made suggestions for consistency with existing practice in emmintrin.h which I've adopted in the latest revision to #83316. I'm unsure how replacing a function declaration with an \fn directive will play with our docum

[clang] [X86] Finally handle target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2/avx (PR #84136)

2024-03-08 Thread Paul T Robinson via cfe-commits
@@ -2940,6 +2940,84 @@ _mm_movemask_ps(__m128 __a) return __builtin_ia32_movmskps((__v4sf)__a); } +/* Compare */ +#define _CMP_EQ_OQ0x00 /* Equal (ordered, non-signaling) */ +#define _CMP_LT_OS0x01 /* Less-than (ordered, signaling) */ +#define _CMP_LE_OS0x02 /*

[clang] [X86] Finally handle target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2/avx (PR #84136)

2024-03-08 Thread Paul T Robinson via cfe-commits
@@ -4745,6 +4745,77 @@ static __inline__ __m128d __DEFAULT_FN_ATTRS _mm_castsi128_pd(__m128i __a) { return (__m128d)__a; } +/// Compares each of the corresponding double-precision values of two +///128-bit vectors of [2 x double], using the operation specified by the +/

[clang] [X86] Finally handle target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2/avx (PR #84136)

2024-03-08 Thread Paul T Robinson via cfe-commits
@@ -2940,6 +2940,84 @@ _mm_movemask_ps(__m128 __a) return __builtin_ia32_movmskps((__v4sf)__a); } +/* Compare */ +#define _CMP_EQ_OQ0x00 /* Equal (ordered, non-signaling) */ +#define _CMP_LT_OS0x01 /* Less-than (ordered, signaling) */ +#define _CMP_LE_OS0x02 /*

[clang] [X86] Finally handle target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2/avx (PR #84136)

2024-03-08 Thread Paul T Robinson via cfe-commits
@@ -4745,6 +4745,77 @@ static __inline__ __m128d __DEFAULT_FN_ATTRS _mm_castsi128_pd(__m128i __a) { return (__m128d)__a; } +/// Compares each of the corresponding double-precision values of two +///128-bit vectors of [2 x double], using the operation specified by the +/

[clang] b46f980 - [HIP] fix host-used external kernel (#83870)

2024-03-08 Thread via cfe-commits
Author: Yaxun (Sam) Liu Date: 2024-03-08T10:50:38-05:00 New Revision: b46f980454d5ceafc8dab37dbdb1011e333ae6de URL: https://github.com/llvm/llvm-project/commit/b46f980454d5ceafc8dab37dbdb1011e333ae6de DIFF: https://github.com/llvm/llvm-project/commit/b46f980454d5ceafc8dab37dbdb1011e333ae6de.dif

[clang] [HIP] fix host-used external kernel (PR #83870)

2024-03-08 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu closed https://github.com/llvm/llvm-project/pull/83870 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HIP] Support compressing bundle by LZMA (PR #83306)

2024-03-08 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu closed https://github.com/llvm/llvm-project/pull/83306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HIP] Support compressing bundle by LZMA (PR #83306)

2024-03-08 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: since zstd has comparable compression rate and is much faster, we will use zstd. close this PR. https://github.com/llvm/llvm-project/pull/83306 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mail

[clang] [Sema] Avoid unnecessary copy on MultiLevelTemplateArgumentList. NFC (PR #84459)

2024-03-08 Thread Younan Zhang via cfe-commits
zyn0217 wrote: Thanks. That explains now :) https://github.com/llvm/llvm-project/pull/84459 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Sema] Avoid unnecessary copy on MultiLevelTemplateArgumentList. NFC (PR #84459)

2024-03-08 Thread Erich Keane via cfe-commits
erichkeane wrote: > Thanks. That explains now :) No problem! Feel free to change a bunch of them, I'm sure we pass by copy quite a bit, I chased out many of them a while back, but I'm sure i didnt get them all. https://github.com/llvm/llvm-project/pull/84459 _

[clang] [llvm] [HIP] add --offload-compression-level= option (PR #83605)

2024-03-08 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/83605 >From 16796bc8eb3b32436903db4b689d4cb9cfc348d8 Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Fri, 1 Mar 2024 13:16:45 -0500 Subject: [PATCH] [HIP] add --offload-compression-level= option Added --offloa

[clang] [llvm] [HIP] add --offload-compression-level= option (PR #83605)

2024-03-08 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: zstd developers suggest to enable long distance matching (LDM), i.e. the `--long` option. I updated the PR with the change, and tested that it works well for bundle entry sizes range from 1KB to 20MB, for both compression rate and compression/decompression speed. https://githu

[clang] [llvm] [HIP] add --offload-compression-level= option (PR #83605)

2024-03-08 Thread Joseph Huber via cfe-commits
jhuber6 wrote: Should an option like in https://github.com/llvm/llvm-project/pull/84337 be added for the new driver? https://github.com/llvm/llvm-project/pull/83605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [llvm] [HIP] add --offload-compression-level= option (PR #83605)

2024-03-08 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu edited https://github.com/llvm/llvm-project/pull/83605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [X86] Finally handle target of __builtin_ia32_cmp[p|s][s|d] from avx into sse/sse2/avx (PR #84136)

2024-03-08 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 commented: The example for `\fn` in the [doxygen documentation](https://www.doxygen.nl/manual/commands.html#cmdfn) puts the directive at the top of the comment block, not at the end. Do we know whether putting it at the end will produce the expected result? https://g

[clang] [llvm] [HIP] add --offload-compression-level= option (PR #83605)

2024-03-08 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > Should an option like in #84337 be added for the new driver? Yes please https://github.com/llvm/llvm-project/pull/83605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commi

[clang] [llvm] [HIP] add --offload-compression-level= option (PR #83605)

2024-03-08 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > > Should an option like in #84337 be added for the new driver? > > Yes please Oh. I can add it https://github.com/llvm/llvm-project/pull/83605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [C++20][Coroutines] Lambda-coroutine with operator new in promise_type (PR #84193)

2024-03-08 Thread Andreas Fertig via cfe-commits
andreasfertig wrote: > @andreasfertig Will you need us to merge that for you? @cor3ntin: It looks like I need you, yes. I can only close the PR :-/ https://github.com/llvm/llvm-project/pull/84193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] BPF address space insn (PR #84410)

2024-03-08 Thread via cfe-commits
@@ -638,6 +643,31 @@ SDValue BPFTargetLowering::LowerDYNAMIC_STACKALLOC(SDValue Op, return DAG.getMergeValues(Ops, SDLoc()); } +SDValue BPFTargetLowering::LowerADDRSPACECAST(SDValue Op, + SelectionDAG &DAG) const { + auto *ACast

[clang] [clang] Error on explicit specialization of lambda call operator (PR #84343)

2024-03-08 Thread Shafik Yaghmour via cfe-commits
shafik wrote: Can we please get more descriptive summaries in the future. We should at a minimum state 1) what the underlying problem is 2) what the approach for fixing the problem is. In this case the title describes the problem but it would be nice to have a summary of the fix as well. So f

[clang] 35d3b33 - [C++20][Coroutines] Lambda-coroutine with operator new in promise_type (#84193)

2024-03-08 Thread via cfe-commits
Author: Andreas Fertig Date: 2024-03-08T08:10:20-08:00 New Revision: 35d3b33ba5c9b90443ac985f2521b78f84b611fe URL: https://github.com/llvm/llvm-project/commit/35d3b33ba5c9b90443ac985f2521b78f84b611fe DIFF: https://github.com/llvm/llvm-project/commit/35d3b33ba5c9b90443ac985f2521b78f84b611fe.diff

[clang] [C++20][Coroutines] Lambda-coroutine with operator new in promise_type (PR #84193)

2024-03-08 Thread Erich Keane via cfe-commits
https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/84193 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Add support for Arm Cortex A78AE CPU (PR #84485)

2024-03-08 Thread Jonathan Thackray via cfe-commits
jthackray wrote: Linux and Windows builds are passing, but someone has left a trailing whitespace character at clang/docs/ReleaseNotes.rst:407 (not me), so I'll merge anyway. https://github.com/llvm/llvm-project/pull/84485 ___ cfe-commits mailing lis

[clang] [C++20][Coroutines] Lambda-coroutine with operator new in promise_type (PR #84193)

2024-03-08 Thread via cfe-commits
github-actions[bot] wrote: @andreasfertig Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a

[clang] [llvm] Add support for Arm Cortex A78AE CPU (PR #84485)

2024-03-08 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray closed https://github.com/llvm/llvm-project/pull/84485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 8160139 - Add support for Arm Cortex A78AE CPU (#84485)

2024-03-08 Thread via cfe-commits
Author: Jonathan Thackray Date: 2024-03-08T16:11:36Z New Revision: 81601391369c267216199db3f7fcb9864ccf6fec URL: https://github.com/llvm/llvm-project/commit/81601391369c267216199db3f7fcb9864ccf6fec DIFF: https://github.com/llvm/llvm-project/commit/81601391369c267216199db3f7fcb9864ccf6fec.diff

[clang] [FPEnv] Add strictfp in some C++ constructors lacking a FunctionDecl. (PR #74883)

2024-03-08 Thread Kevin P. Neal via cfe-commits
https://github.com/kpneal closed https://github.com/llvm/llvm-project/pull/74883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [FPEnv] Add strictfp in some C++ constructors lacking a FunctionDecl. (PR #74883)

2024-03-08 Thread Kevin P. Neal via cfe-commits
kpneal wrote: OK, I'll head in the direction you've pointed. Thanks for your time! https://github.com/llvm/llvm-project/pull/74883 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [ARM][AArch64] Add support for Arm Cortex A78AE CPU (PR #84485)

2024-03-08 Thread Jonathan Thackray via cfe-commits
https://github.com/jthackray edited https://github.com/llvm/llvm-project/pull/84485 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang] Error on explicit specialization of lambda call operator (PR #84343)

2024-03-08 Thread Mariya Podchishchaeva via cfe-commits
Fznamznon wrote: > Can we please get more descriptive summaries in the future. Sure, sorry about that. https://github.com/llvm/llvm-project/pull/84343 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[libunwind] [libc][libunwind] support build libunwind with libc (PR #84509)

2024-03-08 Thread Schrodinger ZHU Yifan via cfe-commits
https://github.com/SchrodingerZhu created https://github.com/llvm/llvm-project/pull/84509 None >From 76e99fd03b1fb51b59f0f4dbd5eefaff5e46175f Mon Sep 17 00:00:00 2001 From: Schrodinger ZHU Yifan Date: Fri, 8 Mar 2024 11:14:39 -0500 Subject: [PATCH] [libc][libunwind] support build libunwind wit

[libunwind] [libc][libunwind] support build libunwind with libc (PR #84509)

2024-03-08 Thread Schrodinger ZHU Yifan via cfe-commits
https://github.com/SchrodingerZhu edited https://github.com/llvm/llvm-project/pull/84509 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Headers][X86] Add specific results to comparisons (PR #83316)

2024-03-08 Thread Paul T Robinson via cfe-commits
pogo59 wrote: > I think so - we're just losing the extra info about -1/0 or 1/0 result values? That's my understanding. I haven't actually tried regenerating the tooltips to check. https://github.com/llvm/llvm-project/pull/83316 ___ cfe-commits maili

[clang] c54e052 - [OpenACC] Add Compute Context Serialization test, fix a bug

2024-03-08 Thread via cfe-commits
Author: erichkeane Date: 2024-03-08T08:19:15-08:00 New Revision: c54e0524eeffcf2c5428cd2bc0449a1989e82cd8 URL: https://github.com/llvm/llvm-project/commit/c54e0524eeffcf2c5428cd2bc0449a1989e82cd8 DIFF: https://github.com/llvm/llvm-project/commit/c54e0524eeffcf2c5428cd2bc0449a1989e82cd8.diff LO

[clang] [Headers][X86] Add rounding and exception notes to conversions (PR #83447)

2024-03-08 Thread Paul T Robinson via cfe-commits
@@ -1405,11 +1413,12 @@ static __inline__ __m128d __DEFAULT_FN_ATTRS _mm_cvtss_sd(__m128d __a, /// Converts the two double-precision floating-point elements of a ///128-bit vector of [2 x double] into two signed 32-bit integer values, -///returned in the lower 64 bits

[clang] [clang][Sema] Refine unused-member-function diagnostic message for constructors (PR #84515)

2024-03-08 Thread via cfe-commits
https://github.com/guillem-bartina-sonarsource created https://github.com/llvm/llvm-project/pull/84515 The current diagnostic message is `unused member function A` for every kind of method, including constructors. The idea is to refine the message to `unused constructor A` when the method is a

[clang] [clang][Sema] Refine unused-member-function diagnostic message for constructors (PR #84515)

2024-03-08 Thread via cfe-commits
github-actions[bot] wrote: Thank you for submitting a Pull Request (PR) to the LLVM Project! This PR will be automatically labeled and the relevant teams will be notified. If you wish to, you can add reviewers by using the "Reviewers" section on this page. If this is not working for you, it

[clang] [clang][Sema] Refine unused-member-function diagnostic message for constructors (PR #84515)

2024-03-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (guillem-bartina-sonarsource) Changes The current diagnostic message is `unused member function A` for every kind of method, including constructors. The idea is to refine the message to `unused constructor A` when the method is a con

[clang] [analyzer] Accept C library functions from the `std` namespace (PR #84469)

2024-03-08 Thread Balazs Benics via cfe-commits
=?utf-8?q?Donát?= Nagy , =?utf-8?q?Donát?= Nagy Message-ID: In-Reply-To: steakhal wrote: > I feel that I'm getting bogged down in this area with changes that are more > general than what's strictly necessary and only tangentially related to my > real goals... > > I'm not familiar with the u

[clang] [Clang][Sema]: Allow flexible arrays in unions and alone in structs (PR #84428)

2024-03-08 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers commented: Rather than have a `-f` flag to opt into this extension, I think instead you should just make it always available, then have tests that it can be used, but will trigger diagnostics under `-Wpedantic` since it's technically a language extension (IIU

[clang] [Clang][Sema]: Allow flexible arrays in unions and alone in structs (PR #84428)

2024-03-08 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/84428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema]: Allow flexible arrays in unions and alone in structs (PR #84428)

2024-03-08 Thread Nick Desaulniers via cfe-commits
@@ -0,0 +1,43 @@ +// RUN: %clang_cc1 %s -verify=c -fsyntax-only -fflex-array-extensions + +// The test checks that flexible array members do not emit warnings when +// -fflex-array-extensions when used in a union or alone in a structure. + +struct already_hidden { + int a; -

[clang] [Headers][X86] Add rounding and exception notes to conversions (PR #83447)

2024-03-08 Thread Phoebe Wang via cfe-commits
@@ -1405,11 +1413,12 @@ static __inline__ __m128d __DEFAULT_FN_ATTRS _mm_cvtss_sd(__m128d __a, /// Converts the two double-precision floating-point elements of a ///128-bit vector of [2 x double] into two signed 32-bit integer values, -///returned in the lower 64 bits

[clang] [llvm] [HIP] add --offload-compression-level= option (PR #83605)

2024-03-08 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/83605 >From 60faf7f657fdcc00edfa0a1813d1e2746c341ef1 Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Fri, 1 Mar 2024 13:16:45 -0500 Subject: [PATCH] [HIP] add --offload-compression-level= option Added --offloa

[clang] [llvm] [HIP] add --offload-compression-level= option (PR #83605)

2024-03-08 Thread Yaxun Liu via cfe-commits
yxsamliu wrote: > Should an option like in #84337 be added for the new driver? added the option to linker wrapper https://github.com/llvm/llvm-project/pull/83605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/ma

[clang] [llvm] [HIP] add --offload-compression-level= option (PR #83605)

2024-03-08 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 commented: Looks fine to me, I'll wait a bit to see if Artem or Fangrui have anything to add. https://github.com/llvm/llvm-project/pull/83605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[clang] [analyzer] Mention possibility of underflow in array overflow errors (PR #84201)

2024-03-08 Thread Balázs Kéri via cfe-commits
https://github.com/balazske approved this pull request. I am not totally sure but this looks correct with the new variable names and there are some tests for the new case. https://github.com/llvm/llvm-project/pull/84201 ___ cfe-commits mailing list cf

[clang] [analyzer] Mention possibility of underflow in array overflow errors (PR #84201)

2024-03-08 Thread Balázs Kéri via cfe-commits
https://github.com/balazske edited https://github.com/llvm/llvm-project/pull/84201 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [analyzer] Mention possibility of underflow in array overflow errors (PR #84201)

2024-03-08 Thread Balázs Kéri via cfe-commits
@@ -83,6 +83,8 @@ class StateUpdateReporter { AssumedUpperBound = UpperBoundVal; } + bool assumedNonNegative() { return AssumedNonNegative; } balazske wrote: This should be called `getAssumedNonNegative` or `hasAssumedNonNegative` (but the naming rule

[clang] [C++20][Coroutines] lambda-coroutine with promise_type ctor. (PR #84519)

2024-03-08 Thread Andreas Fertig via cfe-commits
https://github.com/andreasfertig created https://github.com/llvm/llvm-project/pull/84519 This is a follow-up of #84064. It turned out that a coroutine-lambda with a `promise_type` and a user-defined constructor ignores the `this` pointer. Per http://eel.is/c++draft/dcl.fct.def.coroutine#4, in

[clang] [C++20][Coroutines] lambda-coroutine with promise_type ctor. (PR #84519)

2024-03-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-coroutines Author: Andreas Fertig (andreasfertig) Changes This is a follow-up of #84064. It turned out that a coroutine-lambda with a `promise_type` and a user-defined constructor ignores the `this` pointer. Per http://eel.is/c++draft/dcl.fct.def.corou

[clang] [C++20][Coroutines] lambda-coroutine with promise_type ctor. (PR #84519)

2024-03-08 Thread Andreas Fertig via cfe-commits
andreasfertig wrote: @ChuanqiXu9 here is a dedicated patch to support a `promise_type` with a user-provided constructor in a coroutine used with a lambda. https://github.com/llvm/llvm-project/pull/84519 ___ cfe-commits mailing list cfe-commits@lists.l

[clang] [llvm] [HIP] add --offload-compression-level= option (PR #83605)

2024-03-08 Thread Yaxun Liu via cfe-commits
https://github.com/yxsamliu updated https://github.com/llvm/llvm-project/pull/83605 >From 78ad578a19d2a3585f20ab64d364a46a584ec035 Mon Sep 17 00:00:00 2001 From: "Yaxun (Sam) Liu" Date: Fri, 1 Mar 2024 13:16:45 -0500 Subject: [PATCH] [HIP] add --offload-compression-level= option Added --offloa

[clang] [Clang] Update missing varargs arg extension warnings (PR #84520)

2024-03-08 Thread via cfe-commits
https://github.com/Sirraide created https://github.com/llvm/llvm-project/pull/84520 This updates a few warnings that were diagnosing no arguments for a `...` variadic macro parameter as a GNU extension when it actually is a C++20/C23 extension now. This fixes #84495. >From 502692869e3105bb2c

[clang] [Clang] Update missing varargs arg extension warnings (PR #84520)

2024-03-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: None (Sirraide) Changes This updates a few warnings that were diagnosing no arguments for a `...` variadic macro parameter as a GNU extension when it actually is a C++20/C23 extension now. This fixes #84495. --- Full diff: https://githu

[clang] [Clang] Update missing varargs arg extension warnings (PR #84520)

2024-03-08 Thread via cfe-commits
https://github.com/Sirraide updated https://github.com/llvm/llvm-project/pull/84520 >From 502692869e3105bb2c55955bc4baff63b1475770 Mon Sep 17 00:00:00 2001 From: Sirraide Date: Fri, 8 Mar 2024 18:15:07 +0100 Subject: [PATCH 1/2] [Clang] Update missing varargs arg extension warnings --- clang/

[clang-tools-extra] 9fb5528 - [clang-tidy] Fix Hungarian Prefix in readability-identifier-naming (#84236)

2024-03-08 Thread via cfe-commits
Author: Piotr Zegar Date: 2024-03-08T18:34:26+01:00 New Revision: 9fb552812c65a13cd19eedea1cc2ef739ad652e9 URL: https://github.com/llvm/llvm-project/commit/9fb552812c65a13cd19eedea1cc2ef739ad652e9 DIFF: https://github.com/llvm/llvm-project/commit/9fb552812c65a13cd19eedea1cc2ef739ad652e9.diff L

[clang-tools-extra] [clang-tidy] Fix Hungarian Prefix in readability-identifier-naming (PR #84236)

2024-03-08 Thread Piotr Zegar via cfe-commits
https://github.com/PiotrZSL closed https://github.com/llvm/llvm-project/pull/84236 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][dataflow] Refactor processing of terminator element (PR #84499)

2024-03-08 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand updated https://github.com/llvm/llvm-project/pull/84499 >From 3b20e1823753ab46e3e259d3d8c727dea91ce1d4 Mon Sep 17 00:00:00 2001 From: Yitzhak Mandelbaum Date: Fri, 8 Mar 2024 15:19:14 + Subject: [PATCH] [clang][dataflow] Refactor processing of terminator element Thi

[clang] [llvm] [RISCV] Add back SiFive's cdiscard.d.l1 and cflush.d.l1 instructions. (PR #83896)

2024-03-08 Thread Craig Topper via cfe-commits
topperc wrote: @jrtc27 does this look better now? https://github.com/llvm/llvm-project/pull/83896 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [TBAA] Add bail-out to skip tbaa generation to getTBAAStructInfo. (PR #84386)

2024-03-08 Thread via cfe-commits
https://github.com/dobbelaj-snps approved this pull request. lgtm https://github.com/llvm/llvm-project/pull/84386 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-03-08 Thread Kees Cook via cfe-commits
https://github.com/kees closed https://github.com/llvm/llvm-project/pull/80089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [Sanitizer] add signed-integer-wrap sanitizer (PR #80089)

2024-03-08 Thread Kees Cook via cfe-commits
kees wrote: With PR #82432 landed, this PR is redundant. Thanks for changing the option name! Closing... https://github.com/llvm/llvm-project/pull/80089 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/lis

[clang] [Clang][Sema]: Allow flexible arrays in unions and alone in structs (PR #84428)

2024-03-08 Thread Kees Cook via cfe-commits
@@ -0,0 +1,43 @@ +// RUN: %clang_cc1 %s -verify=c -fsyntax-only -fflex-array-extensions + +// The test checks that flexible array members do not emit warnings when +// -fflex-array-extensions when used in a union or alone in a structure. + +struct already_hidden { + int a; -

[clang] Sanitizer: Support -fwrapv with -fsanitize=signed-integer-overflow (PR #82432)

2024-03-08 Thread Nikita Popov via cfe-commits
nikic wrote: Shouldn't plain `-fsanitize=undefined` disable this sanitizer by default (requiring explicit opt-in)? In `-fwrapv` mode this is not undefined behavior, so `-fsanitize=undefined` should not complain about it. https://github.com/llvm/llvm-project/pull/82432

[clang] [Clang][Sema]: Allow flexible arrays in unions and alone in structs (PR #84428)

2024-03-08 Thread Kees Cook via cfe-commits
kees wrote: > Rather than have a `-f` flag to opt into this extension, I think instead you > should just make it always available, then have tests that it can be used, > but will trigger diagnostics under `-Wpedantic` since it's technically a > language extension (IIUC). I didn't do this beca

[clang] [Clang][Sema] Fix crash when using name of UnresolvedUsingValueDecl with template arguments (PR #83842)

2024-03-08 Thread via cfe-commits
bgra8 wrote: Thanks a lot @sdkrystian ! We have a reducer session running! We'll post here when we have it! https://github.com/llvm/llvm-project/pull/83842 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/

[clang] [clang][deps] Fix dependency scanning with -working-directory (PR #84525)

2024-03-08 Thread Ben Langmuir via cfe-commits
https://github.com/benlangmuir created https://github.com/llvm/llvm-project/pull/84525 Stop overriding -working-directory to CWD during argument parsing, which should no longer necessary after we set the VFS working directory, and set FSOpts correctly after parsing arguments so that working-di

[clang] [llvm] [DXIL] `exp`, `any`, `lerp`, & `rcp` Intrinsic Lowering (PR #84526)

2024-03-08 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl created https://github.com/llvm/llvm-project/pull/84526 This change implements lowering for #70076, #70100, #70072, & #70102 `CGBuiltin.cpp` - - simplify `lerp` intrinsic `IntrinsicsDirectX.td` - simplify `lerp` intrinsic `SemaChecking.cpp` - remove unnecessary check

[clang] [clang][deps] Fix dependency scanning with -working-directory (PR #84525)

2024-03-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Ben Langmuir (benlangmuir) Changes Stop overriding -working-directory to CWD during argument parsing, which should no longer necessary after we set the VFS working directory, and set FSOpts correctly after parsing arguments so that workin

[clang] [llvm] [DXIL] `exp`, `any`, `lerp`, & `rcp` Intrinsic Lowering (PR #84526)

2024-03-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-llvm-ir @llvm/pr-subscribers-hlsl Author: Farzon Lotfi (farzonl) Changes This change implements lowering for #70076, #70100, #70072, & #70102 `CGBuiltin.cpp` - - simplify `lerp` intrinsic `IntrinsicsDirectX.td` - simplify `lerp` intrinsic `SemaChecking.

[clang] [llvm] [DXIL] `exp`, `any`, `lerp`, & `rcp` Intrinsic Lowering (PR #84526)

2024-03-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-directx Author: Farzon Lotfi (farzonl) Changes This change implements lowering for #70076, #70100, #70072, & #70102 `CGBuiltin.cpp` - - simplify `lerp` intrinsic `IntrinsicsDirectX.td` - simplify `lerp` intrinsic `SemaChecking.cpp` - remove unne

[clang] [llvm] [DXIL] `exp`, `any`, `lerp`, & `rcp` Intrinsic Lowering (PR #84526)

2024-03-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Farzon Lotfi (farzonl) Changes This change implements lowering for #70076, #70100, #70072, & #70102 `CGBuiltin.cpp` - - simplify `lerp` intrinsic `IntrinsicsDirectX.td` - simplify `lerp` intrinsic `SemaChecking.cpp` - remove unnecessary ch

[clang] [Clang][Sema]: Allow flexible arrays in unions and alone in structs (PR #84428)

2024-03-08 Thread Nick Desaulniers via cfe-commits
@@ -0,0 +1,43 @@ +// RUN: %clang_cc1 %s -verify=c -fsyntax-only -fflex-array-extensions + +// The test checks that flexible array members do not emit warnings when +// -fflex-array-extensions when used in a union or alone in a structure. + +struct already_hidden { + int a; -

[clang] [Clang][Sema]: Allow flexible arrays in unions and alone in structs (PR #84428)

2024-03-08 Thread Nick Desaulniers via cfe-commits
https://github.com/nickdesaulniers edited https://github.com/llvm/llvm-project/pull/84428 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][C++23] Implement P1774R8: Portable assumptions (PR #81014)

2024-03-08 Thread via cfe-commits
cor3ntin wrote: LGTM, thanks! https://github.com/llvm/llvm-project/pull/81014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][C++23] Implement P1774R8: Portable assumptions (PR #81014)

2024-03-08 Thread via cfe-commits
https://github.com/cor3ntin approved this pull request. https://github.com/llvm/llvm-project/pull/81014 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 5a95378 - [NFC] Remove unnecessary 'Builtins.def' file.

2024-03-08 Thread via cfe-commits
Author: erichkeane Date: 2024-03-08T10:16:34-08:00 New Revision: 5a95378659506b0ce94ceb79a43477e73c9756f4 URL: https://github.com/llvm/llvm-project/commit/5a95378659506b0ce94ceb79a43477e73c9756f4 DIFF: https://github.com/llvm/llvm-project/commit/5a95378659506b0ce94ceb79a43477e73c9756f4.diff LO

[clang] [Clang][C++23] Implement P1774R8: Portable assumptions (PR #81014)

2024-03-08 Thread via cfe-commits
Sirraide wrote: @erichkeane @AaronBallman Do we want to figure out what to do wrt OpenMP’s `assume` attribute before we merge this, or do we want to decide on that after this is merged? Currently, only `[[assume]]` is treated as the standard attribute, and `[[clang::assume]]` or `__attribute__

[clang] [llvm] [HLSL] Add -HV option translation to clang-dxc.exe (PR #83938)

2024-03-08 Thread Joshua Batista via cfe-commits
@@ -226,6 +226,47 @@ HLSLToolChain::TranslateArgs(const DerivedArgList &Args, StringRef BoundArch, A->claim(); continue; } +if (A->getOption().getID() == options::OPT_dxc_hlsl_version) { + // Translate -HV into -std for llvm + // depending on the

[clang] [llvm] [HIP] add --offload-compression-level= option (PR #83605)

2024-03-08 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B edited https://github.com/llvm/llvm-project/pull/83605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HIP] add --offload-compression-level= option (PR #83605)

2024-03-08 Thread Artem Belevich via cfe-commits
https://github.com/Artem-B approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/83605 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HIP] add --offload-compression-level= option (PR #83605)

2024-03-08 Thread Artem Belevich via cfe-commits
@@ -2863,3 +2863,18 @@ void tools::addOutlineAtomicsArgs(const Driver &D, const ToolChain &TC, CmdArgs.push_back("+outline-atomics"); } } + +void tools::addOffloadCompressArgs(const llvm::opt::ArgList &TCArgs, + llvm::opt::ArgStringList

[clang] [FMV] Emit the resolver along with the default version definition. (PR #84405)

2024-03-08 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs approved this pull request. https://github.com/llvm/llvm-project/pull/84405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [FMV] Emit the resolver along with the default version definition. (PR #84405)

2024-03-08 Thread Jon Roelofs via cfe-commits
https://github.com/jroelofs edited https://github.com/llvm/llvm-project/pull/84405 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [FMV] Emit the resolver along with the default version definition. (PR #84405)

2024-03-08 Thread Jon Roelofs via cfe-commits
@@ -85,7 +85,21 @@ int hoo(void) { } +// This should generate one target version but no resolver. +__attribute__((target_version("default"))) int unused_with_forward_default_decl(void); +__attribute__((target_version("mops"))) int unused_with_forward_default_decl(void) { re

[clang] [Clang][Sema]: Allow flexible arrays in unions and alone in structs (PR #84428)

2024-03-08 Thread Nick Desaulniers via cfe-commits
nickdesaulniers wrote: > I didn't do this because it seemed like this would change a lot of existing > test cases Can you give some examples of tests that would fail? If we have tests checking that these fail, then perhaps those tests should add `-Werror=pedantic` so that they can continue to

[clang] Turn 'counted_by' into a type attribute and parse it into 'CountAttributedType' (PR #78000)

2024-03-08 Thread Yeoul Na via cfe-commits
https://github.com/rapidsna updated https://github.com/llvm/llvm-project/pull/78000 >From 3d2716ad6088f600c14d6ff724aa90453130a1f7 Mon Sep 17 00:00:00 2001 From: Yeoul Na Date: Mon, 18 Dec 2023 10:58:16 +0900 Subject: [PATCH 01/10] [BoundsSafety] Introduce CountAttributedType CountAttributedTy

[clang] [Clang][C++23] Implement P1774R8: Portable assumptions (PR #81014)

2024-03-08 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: > `[[clang::assume]]` or `__attribute__((assume))` are the OpenMP one OpenMP requires only [[omp::assume]], neither [[clang::assume]] nor __attribute__((assume)) are OpenMP requirement. https://github.com/llvm/llvm-project/pull/81014 ___

[clang] [Clang][C++23] Implement P1774R8: Portable assumptions (PR #81014)

2024-03-08 Thread via cfe-commits
Sirraide wrote: > > `[[clang::assume]]` or `__attribute__((assume))` are the OpenMP one > > OpenMP requires only [[omp::assume]], neither [[clang::assume]] nor > **attribute**((assume)) are OpenMP requirement. Yeah, the weird thing is I’m not sure we support `[[omp::assume]]` at the moment. W

[clang] [Clang][C++23] Implement P1774R8: Portable assumptions (PR #81014)

2024-03-08 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: > > > `[[clang::assume]]` or `__attribute__((assume))` are the OpenMP one > > > > > > OpenMP requires only [[omp::assume]], neither [[clang::assume]] nor > > **attribute**((assume)) are OpenMP requirement. > > Yeah, the weird thing is I’m not sure we support `[[omp::assum

[clang] [Clang][C++23] Implement P1774R8: Portable assumptions (PR #81014)

2024-03-08 Thread via cfe-commits
Sirraide wrote: > > > > `[[clang::assume]]` or `__attribute__((assume))` are the OpenMP one > > > > > > > > > OpenMP requires only [[omp::assume]], neither [[clang::assume]] nor > > > **attribute**((assume)) are OpenMP requirement. > > > > > > Yeah, the weird thing is I’m not sure we support

[clang] [Clang][C++23] Implement P1774R8: Portable assumptions (PR #81014)

2024-03-08 Thread Alexey Bataev via cfe-commits
alexey-bataev wrote: > > > > > `[[clang::assume]]` or `__attribute__((assume))` are the OpenMP one > > > > > > > > > > > > OpenMP requires only [[omp::assume]], neither [[clang::assume]] nor > > > > **attribute**((assume)) are OpenMP requirement. > > > > > > > > > Yeah, the weird thing is I’

[clang] [analyzer] Accept C library functions from the `std` namespace (PR #84469)

2024-03-08 Thread Gábor Horváth via cfe-commits
Xazax-hun wrote: Once the other reviewers are happy, this looks good to me! https://github.com/llvm/llvm-project/pull/84469 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][C++23] Implement P1774R8: Portable assumptions (PR #81014)

2024-03-08 Thread via cfe-commits
Sirraide wrote: If we can come to a consensus as to what to do w/ `clang::assume` and `__attribute__((assume))` reasonably soon, then I’ll handle `[[omp::assume]]` in this pr as well; otherwise, I’ll open a pr for `[[omp::assume]]` tomorrow or so. https://github.com/llvm/llvm-project/pull/810

[clang] [HIP] Make the new driver bundle outputs for device-only (PR #84534)

2024-03-08 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 created https://github.com/llvm/llvm-project/pull/84534 Summary: The current behavior of HIP is that when --offload-device-only is set it still bundles the outputs into a fat binary. Even though this is different from how all the other targets handle this, it seems to

[clang] [clang][dataflow] Refactor processing of terminator element (PR #84499)

2024-03-08 Thread Gábor Horváth via cfe-commits
https://github.com/Xazax-hun approved this pull request. https://github.com/llvm/llvm-project/pull/84499 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HIP] Make the new driver bundle outputs for device-only (PR #84534)

2024-03-08 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Joseph Huber (jhuber6) Changes Summary: The current behavior of HIP is that when --offload-device-only is set it still bundles the outputs into a fat binary. Even though this is different from how all the other targets handle this, i

[clang] [Clang][C++23] Implement P1774R8: Portable assumptions (PR #81014)

2024-03-08 Thread Erich Keane via cfe-commits
erichkeane wrote: > If we can come to a consensus as to what to do w/ `clang::assume` and > `__attribute__((assume))` reasonably soon, then I’ll handle `[[omp::assume]]` > in this pr as well; otherwise, I’ll open a pr for `[[omp::assume]]` tomorrow > or so. This patch is big enough as it is,

<    1   2   3   4   5   >