[clang] [openmp] [OpenMP] Respect LLVM per-target install directories (PR #83282)

2024-03-01 Thread Ye Luo via cfe-commits
ye-luo wrote: It seems being installed twice both under `lib` and `lib/x86_64-unknown-linux-gnu`. files are the identical as diff show nothing. https://github.com/llvm/llvm-project/pull/83282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [clang-format][doc] fix documentation for clang-format (PR #83415)

2024-03-01 Thread via cfe-commits
https://github.com/PeterChou1 updated https://github.com/llvm/llvm-project/pull/83415 >From 67154ff4388447ff78b2912e5635231778ed23d4 Mon Sep 17 00:00:00 2001 From: PeterChou1 <4355+peterch...@users.noreply.github.com> Date: Thu, 29 Feb 2024 06:55:18 -0500 Subject: [PATCH 1/2] [clang][Documen

[clang] [openmp] [OpenMP] Respect LLVM per-target install directories (PR #83282)

2024-03-01 Thread Joseph Huber via cfe-commits
jhuber6 wrote: > It seems being installed twice both under `lib` and > `lib/x86_64-unknown-linux-gnu`. files are the identical as diff show nothing. Makes sense, like `add_llvm_library` is implicitly installing it there, then our subsequent `install` call is doing it again. I wonder if there's

[clang] [clang] Better bitfield access units (PR #65742)

2024-03-01 Thread Eli Friedman via cfe-commits
@@ -394,33 +412,155 @@ void CGRecordLowering::accumulateFields() { : getStorageType(*Field), *Field)); ++Field; -} else { - ++Field; } } } -void -CGRecordLowering::accumulateBitFields(RecordDecl::field_iterator Field, -

[clang] [Clang][DebugInfo] Use CGDebugInfo::createFile in CGDebugInfo::CreateCompileUnit (#83174) (PR #83175)

2024-03-01 Thread Adrian Prantl via cfe-commits
@@ -0,0 +1,20 @@ +// RUN: mkdir -p %t/src +// RUN: cp %s %t/src/debug-info-debug-prefix-map.c + +// RUN: mkdir -p %t/out +// RUN: cd %t/out +// RUN: %clang_cc1 -debug-info-kind=limited -triple %itanium_abi_triple \ +// RUN: -fdebug-prefix-map="%t/=./" %t/src/debug-info-debug-pre

[clang] [clang-format][doc] fix documentation for clang-format (PR #83415)

2024-03-01 Thread via cfe-commits
PeterChou1 wrote: > Hi, you need to edit `clang/include/clang/Format/Format.h` and then run > `clang/docs/tools/dump_format_style.py` to regenerate > `clang/docs/ClangFormatStyleOptions.rst`. Hi my mistake. I'm quite new to the LLVM project so I was not aware the docs were generated through a

[clang] [clang][Builtins] Parse clang extended vectors types. (PR #83584)

2024-03-01 Thread Francesco Petrogalli via cfe-commits
https://github.com/fpetrogalli updated https://github.com/llvm/llvm-project/pull/83584 >From 9cd3e17192833e2cbafed55b649307ead32dcc3e Mon Sep 17 00:00:00 2001 From: Francesco Petrogalli Date: Fri, 1 Mar 2024 16:23:57 +0100 Subject: [PATCH 1/4] [clang][Builtins] Parse clang extended vectors type

[clang] [Clang][Sema] Fix NULL dereferences for invalid references (PR #77703)

2024-03-01 Thread Erich Keane via cfe-commits
https://github.com/erichkeane closed https://github.com/llvm/llvm-project/pull/77703 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema] Fix NULL dereferences for invalid references (PR #77703)

2024-03-01 Thread Erich Keane via cfe-commits
erichkeane wrote: I spent a while debugging this, and this is far from the correct solution. However, in my debugging I was able to identify the correct solution, so I'll prepare a patch to fix this, closing. https://github.com/llvm/llvm-project/pull/77703

[clang] [clang][Builtins] Parse clang extended vectors types. (PR #83584)

2024-03-01 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 2b4d67bf59d609321701540a15f48eda04688652 ab12de397fa0c028ad6b92751a31ccabfe89dc7d --

[clang] [clang][Builtins] Parse clang extended vectors types. (PR #83584)

2024-03-01 Thread Francesco Petrogalli via cfe-commits
fpetrogalli wrote: > > @philnik777 - thank you for the patch at #68324 > > You're welcome! > > FWIW I'd find a syntax like `_ExtVector` better. The underscore and > upper case to make it clear that it's non-standard and the angle bracket > syntax since it's kind-of a template. This unfortunat

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl created https://github.com/llvm/llvm-project/pull/83609 removing the additions of `err_vec_builtin_non_vector_all` & `err_vec_builtin_incompatible_vector_all` caused by https://github.com/llvm/llvm-project/pull/83077. Instead adding a select option to `err_vec_builti

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-hlsl Author: Farzon Lotfi (farzonl) Changes removing the additions of `err_vec_builtin_non_vector_all` & `err_vec_builtin_incompatible_vector_all` caused by https://github.com/llvm/llvm-project/pull/83077. Instead adding a se

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5 (PR #83331)

2024-03-01 Thread David Blaikie via cfe-commits
@@ -11,7 +11,6 @@ // NOINLINE-NOT: "-fsplit-dwarf-inlining" // SPLIT-NOT: "-dumpdir" // SPLIT: "-debug-info-kind=constructor" -// SPLIT-SAME: "-ggnu-pubnames" dwblaikie wrote: has this lost coverage for non `-glldb` configurations? (like would we still

[clang] [llvm] [HLSL] implementation of lerp intrinsic (PR #83077)

2024-03-01 Thread Farzon Lotfi via cfe-commits
@@ -10266,6 +10266,11 @@ def err_block_on_vm : Error< def err_sizeless_nonlocal : Error< "non-local variable with sizeless type %0">; +def err_vec_builtin_non_vector_all : Error< + "all arguments to %0 must be vectors">; +def err_vec_builtin_incompatible_vector_all : Error<

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Xiang Li via cfe-commits
https://github.com/python3kgae approved this pull request. https://github.com/llvm/llvm-project/pull/83609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][Builtins] Parse clang extended vectors types. (PR #83584)

2024-03-01 Thread Francesco Petrogalli via cfe-commits
fpetrogalli wrote: Other C++ compatible option: provide a family of templates, one for each number of lanes, templated on the type: ``` _ExtVector_N ``` So that we need up having: ``` _ExtVector_2 _ExtVector_6 ... ``` This would be pretty easy to handle, without introducing extra complicatio

[clang] [clang][Builtins] Parse clang extended vectors types. (PR #83584)

2024-03-01 Thread Nikolas Klauser via cfe-commits
philnik777 wrote: Hm, yeah. I don't think it's worth complicating the parser for a tiny bit of syntax sugar. I like your idea with a `:` quite a bit. `_ExtVector(bool:4)` would also be an option. I don't have a strong preference either way. I'd like to keep it separate from the name though to

[clang] Fix null-deref thanks to an attribute on a global declarator chunk (PR #83611)

2024-03-01 Thread Erich Keane via cfe-commits
https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/83611 This was reported (sort of) in a PR: #77703. The problem is that a declarator 'owns' an attributes allocation via an `AttributePool`. However, this example tries to copy a DeclaratorChunk from one Declarator

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Chris B via cfe-commits
@@ -38,70 +38,70 @@ float test_dot_element_type_mismatch(int2 p0, float2 p1) { //NOTE: for all the *_promotion we are intentionally not handling type promotion in builtins float test_builtin_dot_vec_int_to_float_promotion(int2 p0, float2 p1) { return __builtin_hlsl_dot(p0, p

[clang] Fix null-deref thanks to an attribute on a global declarator chunk (PR #83611)

2024-03-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Erich Keane (erichkeane) Changes This was reported (sort of) in a PR: #77703. The problem is that a declarator 'owns' an attributes allocation via an `AttributePool`. However, this example tries to copy a DeclaratorChunk from one Declarat

[clang] Fix null-deref thanks to an attribute on a global declarator chunk (PR #83611)

2024-03-01 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 601a9587a1a7eb8dd6377c4ab332edd3bce97a98 8152ad56b320719553701edf020c30aea8c3213e --

[clang] Fix null-deref thanks to an attribute on a global declarator chunk (PR #83611)

2024-03-01 Thread Erich Keane via cfe-commits
https://github.com/erichkeane updated https://github.com/llvm/llvm-project/pull/83611 >From 8152ad56b320719553701edf020c30aea8c3213e Mon Sep 17 00:00:00 2001 From: erichkeane Date: Fri, 1 Mar 2024 11:36:14 -0800 Subject: [PATCH 1/2] Fix null-deref thanks to an attribute on a global declarator

[clang] [clang][nullability] Don't discard expression state before end of full-expression. (PR #82611)

2024-03-01 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand edited https://github.com/llvm/llvm-project/pull/82611 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][nullability] Don't discard expression state before end of full-expression. (PR #82611)

2024-03-01 Thread Yitzhak Mandelbaum via cfe-commits
https://github.com/ymand approved this pull request. I'm a little concerned with the complexity and cost required to support this optimization. With this added cost, do you know if the analysis still faster (and less SAT timeouts?) than if we just did the simple thing of not dropping state? h

[clang] [clang][nullability] Don't discard expression state before end of full-expression. (PR #82611)

2024-03-01 Thread Yitzhak Mandelbaum via cfe-commits
@@ -248,12 +251,12 @@ class JoinedStateBuilder { // initialize the state of each basic block differently. return {AC.Analysis.typeErasedInitialElement(), AC.InitEnv.fork()}; if (All.size() == 1) ymand wrote: guard on ExprBehavior as well, like

[clang] [clang][nullability] Don't discard expression state before end of full-expression. (PR #82611)

2024-03-01 Thread Yitzhak Mandelbaum via cfe-commits
@@ -221,18 +221,21 @@ class PrettyStackTraceCFGElement : public llvm::PrettyStackTraceEntry { // Avoids unneccesary copies of the environment. class JoinedStateBuilder { AnalysisContext &AC; + Environment::ExprJoinBehavior ExprBehavior; ymand wrote: If you

[clang] [clang][nullability] Don't discard expression state before end of full-expression. (PR #82611)

2024-03-01 Thread Yitzhak Mandelbaum via cfe-commits
@@ -307,7 +310,22 @@ computeBlockInputState(const CFGBlock &Block, AnalysisContext &AC) { } } - JoinedStateBuilder Builder(AC); + // If any of the predecessor blocks contains an expression consumed in a + // different block, we need to keep expression state. + // No

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5 (PR #83331)

2024-03-01 Thread Alexander Yermolovich via cfe-commits
@@ -11,7 +11,6 @@ // NOINLINE-NOT: "-fsplit-dwarf-inlining" // SPLIT-NOT: "-dumpdir" // SPLIT: "-debug-info-kind=constructor" -// SPLIT-SAME: "-ggnu-pubnames" ayermolo wrote: Sorry not sure I follow. As discussed in original diff the idea is if -gsplit-d

[clang] [clang][nullability] Don't discard expression state before end of full-expression. (PR #82611)

2024-03-01 Thread Yitzhak Mandelbaum via cfe-commits
@@ -94,6 +94,36 @@ static llvm::BitVector findReachableBlocks(const CFG &Cfg) { return BlockReachable; } +static llvm::DenseSet +buildContainsExprConsumedInDifferentBlock( +const CFG &Cfg, +const llvm::DenseMap &StmtToBlock) { + llvm::DenseSet Result; + + auto Chec

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5 (PR #83331)

2024-03-01 Thread Alexander Yermolovich via cfe-commits
https://github.com/ayermolo edited https://github.com/llvm/llvm-project/pull/83331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5 (PR #83331)

2024-03-01 Thread Fangrui Song via cfe-commits
@@ -4478,14 +4478,20 @@ renderDebugOptions(const ToolChain &TC, const Driver &D, const llvm::Triple &T, Args.getLastArg(options::OPT_ggnu_pubnames, options::OPT_gno_gnu_pubnames, options::OPT_gpubnames, options::OPT_gno_pubnames); if (DwarfFissio

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5 (PR #83331)

2024-03-01 Thread Fangrui Song via cfe-commits
@@ -11,7 +11,6 @@ // NOINLINE-NOT: "-fsplit-dwarf-inlining" // SPLIT-NOT: "-dumpdir" // SPLIT: "-debug-info-kind=constructor" -// SPLIT-SAME: "-ggnu-pubnames" MaskRay wrote: I haven't checked closely, but you probably need a `-NOT` directive, and if the

[clang] [Sema] -Wpointer-bool-conversion: suppress lambda function pointer conversion diagnostic during instantiation (PR #83497)

2024-03-01 Thread David Blaikie via cfe-commits
dwblaikie wrote: Presumably similar things might show up in macros? But can cross that bridge when we come to it. Perhaps we have some/could use some generic utility for this sort of contextual warning "if these things are literally written next to each other, warn, but if they came to be via

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for LLDB tuning, unless -ggnu-pubnames is specified. (PR #83331)

2024-03-01 Thread Alexander Yermolovich via cfe-commits
https://github.com/ayermolo edited https://github.com/llvm/llvm-project/pull/83331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Farzon Lotfi via cfe-commits
@@ -38,70 +38,70 @@ float test_dot_element_type_mismatch(int2 p0, float2 p1) { //NOTE: for all the *_promotion we are intentionally not handling type promotion in builtins float test_builtin_dot_vec_int_to_float_promotion(int2 p0, float2 p1) { return __builtin_hlsl_dot(p0, p

[clang] [clang][Builtins] Parse clang extended vectors types. (PR #83584)

2024-03-01 Thread Visoiu Mistrih Francis via cfe-commits
francisvm wrote: Maybe we can agree to not allow nested `<...>`, and it should simplify the parsing a little? https://github.com/llvm/llvm-project/pull/83584 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[clang] [clang][parse] Fix UAF in MaybeDestroyTemplates (PR #77698)

2024-03-01 Thread Erich Keane via cfe-commits
erichkeane wrote: We do need a unit test for this, a reduced version of the original fuzzed result will help us review this. https://github.com/llvm/llvm-project/pull/77698 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for LLDB tuning, unless -ggnu-pubnames is specified. (PR #83331)

2024-03-01 Thread David Blaikie via cfe-commits
@@ -11,7 +11,6 @@ // NOINLINE-NOT: "-fsplit-dwarf-inlining" // SPLIT-NOT: "-dumpdir" // SPLIT: "-debug-info-kind=constructor" -// SPLIT-SAME: "-ggnu-pubnames" dwblaikie wrote: > As discussed in original PR, #82840 , the idea is if -gsplit-dwarf with > -

[clang] [clang-format][NFC] Replace Style.isCpp() with IsCpp (PR #83533)

2024-03-01 Thread Björn Schäpers via cfe-commits
HazardyKnusperkeks wrote: The question is: why? And why handle c++ different than all other languages? https://github.com/llvm/llvm-project/pull/83533 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [clang] Better bitfield access units (PR #65742)

2024-03-01 Thread John McCall via cfe-commits
@@ -394,33 +412,155 @@ void CGRecordLowering::accumulateFields() { : getStorageType(*Field), *Field)); ++Field; -} else { - ++Field; } } } -void -CGRecordLowering::accumulateBitFields(RecordDecl::field_iterator Field, -

[clang] 76ce3c1 - [clang-format] Enable again some operator tests (#83380)

2024-03-01 Thread via cfe-commits
Author: rayroudc Date: 2024-03-01T21:24:13+01:00 New Revision: 76ce3c1bcf82056a61bcbdf776f67ac53d881df0 URL: https://github.com/llvm/llvm-project/commit/76ce3c1bcf82056a61bcbdf776f67ac53d881df0 DIFF: https://github.com/llvm/llvm-project/commit/76ce3c1bcf82056a61bcbdf776f67ac53d881df0.diff LOG:

[clang] [clang-format] Enable again some operator tests (PR #83380)

2024-03-01 Thread Björn Schäpers via cfe-commits
https://github.com/HazardyKnusperkeks closed https://github.com/llvm/llvm-project/pull/83380 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang-format] Enable again some operator tests (PR #83380)

2024-03-01 Thread via cfe-commits
github-actions[bot] wrote: @rayroudc Congratulations on having your first Pull Request (PR) merged into the LLVM Project! Your changes will be combined with recent changes from other authors, then tested by our [build bots](https://lab.llvm.org/buildbot/). If there is a problem with a build

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for LLDB tuning, unless -ggnu-pubnames is specified. (PR #83331)

2024-03-01 Thread Alexander Yermolovich via cfe-commits
https://github.com/ayermolo updated https://github.com/llvm/llvm-project/pull/83331 >From 7d58760a887fc935e2af670f8aa721cdd5946391 Mon Sep 17 00:00:00 2001 From: Alexander Yermolovich Date: Fri, 23 Feb 2024 14:52:04 -0800 Subject: [PATCH 1/2] [CLANG][DWARF] Do not emit -ggnu-pubnames for split

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for LLDB tuning, unless -ggnu-pubnames is specified. (PR #83331)

2024-03-01 Thread Alexander Yermolovich via cfe-commits
@@ -11,7 +11,6 @@ // NOINLINE-NOT: "-fsplit-dwarf-inlining" // SPLIT-NOT: "-dumpdir" // SPLIT: "-debug-info-kind=constructor" -// SPLIT-SAME: "-ggnu-pubnames" ayermolo wrote: Oh I see! Thanks for clarification. That check should be there. I think it snu

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for LLDB tuning, unless -ggnu-pubnames is specified. (PR #83331)

2024-03-01 Thread Alexander Yermolovich via cfe-commits
https://github.com/ayermolo edited https://github.com/llvm/llvm-project/pull/83331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for LLDB tuning, unless -ggnu-pubnames is specified. (PR #83331)

2024-03-01 Thread Alexander Yermolovich via cfe-commits
https://github.com/ayermolo edited https://github.com/llvm/llvm-project/pull/83331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/83609 >From bfd8afd06400bc936c13d2138576bb0bb51960e9 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Fri, 1 Mar 2024 14:21:17 -0500 Subject: [PATCH] [clang][sema] consolidate diags --- .../clang/Basic/DiagnosticSem

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for LLDB tuning, unless -ggnu-pubnames is specified. (PR #83331)

2024-03-01 Thread David Blaikie via cfe-commits
@@ -11,7 +11,6 @@ // NOINLINE-NOT: "-fsplit-dwarf-inlining" // SPLIT-NOT: "-dumpdir" // SPLIT: "-debug-info-kind=constructor" -// SPLIT-SAME: "-ggnu-pubnames" dwblaikie wrote: Nah, I think that's probably fine without an explicit `-ggdb` test - though w

[clang] [Sema] -Wpointer-bool-conversion: suppress lambda function pointer conversion diagnostic during instantiation (PR #83497)

2024-03-01 Thread Fangrui Song via cfe-commits
MaskRay wrote: > Presumably similar things might show up in macros? But can cross that bridge > when we come to it. > > Perhaps we have some/could use some generic utility for this sort of > contextual warning "if these things are literally written next to each other, > warn, but if they came

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Greg Roth via cfe-commits
@@ -5218,15 +5218,15 @@ bool CheckVectorElementCallArgs(Sema *S, CallExpr *TheCall) { // Note: type promotion is intended to be handeled via the intrinsics // and not the builtin itself. S->Diag(TheCall->getBeginLoc(), -diag::err_vec_bu

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Greg Roth via cfe-commits
https://github.com/pow2clk edited https://github.com/llvm/llvm-project/pull/83609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Greg Roth via cfe-commits
https://github.com/pow2clk commented: Just some nitpicks. I also find it much harder to rereview a change when a force push has gone through. I don't know how things are done around here, but if it can be avoided, I prefer it. https://github.com/llvm/llvm-project/pull/83609 ___

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Greg Roth via cfe-commits
@@ -22,7 +22,7 @@ float test_dot_vector_size_mismatch(float3 p0, float2 p1) { float test_dot_builtin_vector_size_mismatch(float3 p0, float2 p1) { return __builtin_hlsl_dot(p0, p1); - // expected-error@-1 {{all arguments to '__builtin_hlsl_dot' must have vectors of the same

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Greg Roth via cfe-commits
@@ -5241,8 +5241,8 @@ bool CheckVectorElementCallArgs(Sema *S, CallExpr *TheCall) { // Note: if we get here one of the args is a scalar which // requires a VectorSplat on Arg0 or Arg1 - S->Diag(BuiltinLoc, diag::err_vec_builtin_non_vector_all) - << TheCall->getDirec

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Farzon Lotfi via cfe-commits
@@ -22,7 +22,7 @@ float test_dot_vector_size_mismatch(float3 p0, float2 p1) { float test_dot_builtin_vector_size_mismatch(float3 p0, float2 p1) { return __builtin_hlsl_dot(p0, p1); - // expected-error@-1 {{all arguments to '__builtin_hlsl_dot' must have vectors of the same

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Farzon Lotfi via cfe-commits
@@ -5218,15 +5218,15 @@ bool CheckVectorElementCallArgs(Sema *S, CallExpr *TheCall) { // Note: type promotion is intended to be handeled via the intrinsics // and not the builtin itself. S->Diag(TheCall->getBeginLoc(), -diag::err_vec_bu

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Farzon Lotfi via cfe-commits
@@ -5241,8 +5241,8 @@ bool CheckVectorElementCallArgs(Sema *S, CallExpr *TheCall) { // Note: if we get here one of the args is a scalar which // requires a VectorSplat on Arg0 or Arg1 - S->Diag(BuiltinLoc, diag::err_vec_builtin_non_vector_all) - << TheCall->getDirec

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

2024-03-01 Thread Botond István Horváth via cfe-commits
HoBoIs wrote: > DR changes looks good now, save for a nitpick. However, I'm leaving it to > other reviewers to check contents of the test. It looks like an example from > the DR, but I don't feel qualified to say whether this test has sufficient > coverage. I have added tests to other files w

[clang] [llvm] [HIP] change compress level (PR #83605)

2024-03-01 Thread Artem Belevich via cfe-commits
@@ -942,20 +942,28 @@ CompressedOffloadBundle::compress(const llvm::MemoryBuffer &Input, Input.getBuffer().size()); llvm::compression::Format CompressionFormat; + int Level; - if (llvm::compression::zstd::isAvailable()) + if (llvm::compression::zstd::isAvailable(

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

2024-03-01 Thread Atousa Duprat via cfe-commits
https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From ac75fc2873fc7b8eec6c24ba97f4673e94457c8e Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH 1/6] [clang] Use separator for large numeric values in overflow dia

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for LLDB tuning, unless -ggnu-pubnames is specified. (PR #83331)

2024-03-01 Thread Alexander Yermolovich via cfe-commits
@@ -11,7 +11,6 @@ // NOINLINE-NOT: "-fsplit-dwarf-inlining" // SPLIT-NOT: "-dumpdir" // SPLIT: "-debug-info-kind=constructor" -// SPLIT-SAME: "-ggnu-pubnames" ayermolo wrote: At least on my mac it passed. With that check. I double checked, and this is wh

[clang] [llvm] [clang] Use separator for large numeric values in overflow diagnostic (PR #80939)

2024-03-01 Thread Atousa Duprat via cfe-commits
https://github.com/Atousa updated https://github.com/llvm/llvm-project/pull/80939 >From ac75fc2873fc7b8eec6c24ba97f4673e94457c8e Mon Sep 17 00:00:00 2001 From: Atousa Duprat Date: Tue, 6 Feb 2024 21:02:05 -0800 Subject: [PATCH 1/6] [clang] Use separator for large numeric values in overflow dia

[clang] [cfi][CodeGen] Call SetLLVMFunctionAttributes{, ForDefinition} on __cf… (PR #78253)

2024-03-01 Thread Pavel Kosov via cfe-commits
https://github.com/kpdev updated https://github.com/llvm/llvm-project/pull/78253 >From 9850957ff41dd5cbe72fd76925a32ad9c277d5e1 Mon Sep 17 00:00:00 2001 From: Nikolai Kholiavin Date: Wed, 20 Dec 2023 16:19:03 + Subject: [PATCH] [cfi][CodeGen] Call SetLLVMFunctionAttributes{,ForDefinition} o

[clang] [llvm] [TargetParser][AArch64] Add alias for FEAT_RDM. (PR #80540)

2024-03-01 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea closed https://github.com/llvm/llvm-project/pull/80540 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] d01576b - [TargetParser][AArch64] Add alias for FEAT_RDM. (#80540)

2024-03-01 Thread via cfe-commits
Author: Alexandros Lamprineas Date: 2024-03-01T21:06:08Z New Revision: d01576bb6033865c20a4c0da581939dcae5b30be URL: https://github.com/llvm/llvm-project/commit/d01576bb6033865c20a4c0da581939dcae5b30be DIFF: https://github.com/llvm/llvm-project/commit/d01576bb6033865c20a4c0da581939dcae5b30be.di

[clang] [cfi][CodeGen] Call SetLLVMFunctionAttributes{, ForDefinition} on __cf… (PR #78253)

2024-03-01 Thread Pavel Kosov via cfe-commits
@@ -3443,11 +3443,28 @@ void CodeGenFunction::EmitCfiSlowPathCheck( void CodeGenFunction::EmitCfiCheckStub() { llvm::Module *M = &CGM.getModule(); auto &Ctx = M->getContext(); + auto &C = getContext(); kpdev wrote: Changed, please review https://github.c

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Farzon Lotfi via cfe-commits
farzonl wrote: @pow2clk force doesn't seem necessary b\c squash merge is the default behavior for this project. I did it because i tend to rebase my branches when I put out revisions. I'll stop doing that. https://github.com/llvm/llvm-project/pull/83609 ___

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/83609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [cfi][CodeGen] Call SetLLVMFunctionAttributes{, ForDefinition} on __cf… (PR #78253)

2024-03-01 Thread Pavel Kosov via cfe-commits
kpdev wrote: > Should we add a release note to `clang/docs/ReleaseNotes.rst` so users know > about the changes? Seems reasonable ) Should I add it somewhere to [`Sanitizers`](https://github.com/llvm/llvm-project/blob/main/clang/docs/ReleaseNotes.rst#sanitizers) ? https://github.com/llvm/llv

[clang] [CLANG] Full support of complex multiplication and division. (PR #81514)

2024-03-01 Thread Andy Kaylor via cfe-commits
@@ -1847,19 +1847,33 @@ floating point semantic models: precise (the default), strict, and fast. * ``16`` - Forces ``_Float16`` operations to be emitted without using excess precision arithmetic. -.. option:: -fcx-limited-range: - - This option enables the naive mat

[clang] [clang] Bugfix for choosing the more specialized overload (PR #83279)

2024-03-01 Thread Vlad Serebrennikov via cfe-commits
Botond =?utf-8?q?István_Horváth?=,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath ,Botond Istvan Horvath Message-ID: In-Reply-To: Endilll wrote: > I have added tests to other files what are relevant for the DR too. Should I > move them here? I trust your judgement her

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz created https://github.com/llvm/llvm-project/pull/83625 Add members "leafs" and "association" to .td describing OpenMP/ACC directives: "leafs" are the leaf constructs for composite/combined constructs, and "association" is the source language construct to which the

[clang] [CLANG] Full support of complex multiplication and division. (PR #81514)

2024-03-01 Thread Andy Kaylor via cfe-commits
@@ -283,9 +283,46 @@ class ComplexExprEmitter ComplexPairTy EmitComplexBinOpLibCall(StringRef LibCallName, const BinOpInfo &Op); - QualType getPromotionType(QualType Ty) { + QualType HigherPrecisionTypeForComplexArithmetic(QualType E

[clang] [CLANG] Full support of complex multiplication and division. (PR #81514)

2024-03-01 Thread Andy Kaylor via cfe-commits
@@ -1847,19 +1847,50 @@ floating point semantic models: precise (the default), strict, and fast. * ``16`` - Forces ``_Float16`` operations to be emitted without using excess precision arithmetic. +.. option:: -fcomplex-arithmetic=: + + This option specifies the impl

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Krzysztof Parzyszek (kparzysz) Changes Add members "leafs" and "association" to .td describing OpenMP/ACC directives: "leafs" are the leaf constructs for composite/combined constructs, and "association" is the source language construct to

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff d01576bb6033865c20a4c0da581939dcae5b30be 544b309d77a7094d35794e574a1a1d12438021cd --

[clang] [InstallAPI] Collect frontend attributes & ObjCInterface decls (PR #83378)

2024-03-01 Thread Juergen Ributzka via cfe-commits
@@ -16,6 +16,74 @@ using namespace llvm::MachO; namespace clang::installapi { +GlobalRecord *FrontendRecordsSlice::addGlobal( +StringRef Name, RecordLinkage Linkage, GlobalRecord::Kind GV, +const clang::AvailabilityInfo Avail, const Decl *D, const HeaderType Access,

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Alexey Bataev via cfe-commits
@@ -665,60 +619,44 @@ bool clang::isOpenMPTargetDataManagementDirective(OpenMPDirectiveKind DKind) { } bool clang::isOpenMPNestingTeamsDirective(OpenMPDirectiveKind DKind) { - return DKind == OMPD_teams || DKind == OMPD_teams_distribute || - DKind == OMPD_teams_distr

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Alexey Bataev via cfe-commits
@@ -665,60 +619,44 @@ bool clang::isOpenMPTargetDataManagementDirective(OpenMPDirectiveKind DKind) { } bool clang::isOpenMPNestingTeamsDirective(OpenMPDirectiveKind DKind) { - return DKind == OMPD_teams || DKind == OMPD_teams_distribute || - DKind == OMPD_teams_distr

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Alexey Bataev via cfe-commits
@@ -665,60 +619,44 @@ bool clang::isOpenMPTargetDataManagementDirective(OpenMPDirectiveKind DKind) { } bool clang::isOpenMPNestingTeamsDirective(OpenMPDirectiveKind DKind) { - return DKind == OMPD_teams || DKind == OMPD_teams_distribute || - DKind == OMPD_teams_distr

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Alexey Bataev via cfe-commits
@@ -665,60 +619,44 @@ bool clang::isOpenMPTargetDataManagementDirective(OpenMPDirectiveKind DKind) { } bool clang::isOpenMPNestingTeamsDirective(OpenMPDirectiveKind DKind) { - return DKind == OMPD_teams || DKind == OMPD_teams_distribute || - DKind == OMPD_teams_distr

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/83625 >From b62919c2ce24feb3c75a5bbecce3d6b6ee8e5b7e Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Tue, 16 Jan 2024 16:40:47 -0600 Subject: [PATCH] [Frontend] Add leaf constructs and association to OpenMP/A

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Krzysztof Parzyszek via cfe-commits
https://github.com/kparzysz updated https://github.com/llvm/llvm-project/pull/83625 >From b62919c2ce24feb3c75a5bbecce3d6b6ee8e5b7e Mon Sep 17 00:00:00 2001 From: Krzysztof Parzyszek Date: Tue, 16 Jan 2024 16:40:47 -0600 Subject: [PATCH 1/2] [Frontend] Add leaf constructs and association to Ope

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Krzysztof Parzyszek via cfe-commits
@@ -665,60 +619,44 @@ bool clang::isOpenMPTargetDataManagementDirective(OpenMPDirectiveKind DKind) { } bool clang::isOpenMPNestingTeamsDirective(OpenMPDirectiveKind DKind) { - return DKind == OMPD_teams || DKind == OMPD_teams_distribute || - DKind == OMPD_teams_distr

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Krzysztof Parzyszek via cfe-commits
@@ -665,60 +619,44 @@ bool clang::isOpenMPTargetDataManagementDirective(OpenMPDirectiveKind DKind) { } bool clang::isOpenMPNestingTeamsDirective(OpenMPDirectiveKind DKind) { - return DKind == OMPD_teams || DKind == OMPD_teams_distribute || - DKind == OMPD_teams_distr

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Krzysztof Parzyszek via cfe-commits
@@ -665,60 +619,44 @@ bool clang::isOpenMPTargetDataManagementDirective(OpenMPDirectiveKind DKind) { } bool clang::isOpenMPNestingTeamsDirective(OpenMPDirectiveKind DKind) { - return DKind == OMPD_teams || DKind == OMPD_teams_distribute || - DKind == OMPD_teams_distr

[clang] [llvm] [Frontend] Add leaf constructs and association to OpenMP/ACC directives (PR #83625)

2024-03-01 Thread Krzysztof Parzyszek via cfe-commits
kparzysz wrote: I removed the check for `end do simd` with a comment that it can't appear in clang. I think you deleted that remark, let me know if I should bring the check back. https://github.com/llvm/llvm-project/pull/83625 ___ cfe-commits mailin

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Farzon Lotfi via cfe-commits
@@ -5241,8 +5241,8 @@ bool CheckVectorElementCallArgs(Sema *S, CallExpr *TheCall) { // Note: if we get here one of the args is a scalar which // requires a VectorSplat on Arg0 or Arg1 - S->Diag(BuiltinLoc, diag::err_vec_builtin_non_vector_all) - << TheCall->getDirec

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Farzon Lotfi via cfe-commits
@@ -5218,15 +5218,15 @@ bool CheckVectorElementCallArgs(Sema *S, CallExpr *TheCall) { // Note: type promotion is intended to be handeled via the intrinsics // and not the builtin itself. S->Diag(TheCall->getBeginLoc(), -diag::err_vec_bu

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/83609 >From bfd8afd06400bc936c13d2138576bb0bb51960e9 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Fri, 1 Mar 2024 14:21:17 -0500 Subject: [PATCH 1/2] [clang][sema] consolidate diags --- .../clang/Basic/Diagnosti

[clang] [clang][sema] consolidate diags for incompatible_vector_* (PR #83609)

2024-03-01 Thread Chris B via cfe-commits
https://github.com/llvm-beanz approved this pull request. https://github.com/llvm/llvm-project/pull/83609 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 24aec16 - [OpenACC] Implement no throw out of Compute construct

2024-03-01 Thread via cfe-commits
Author: erichkeane Date: 2024-03-01T14:23:27-08:00 New Revision: 24aec16ddad465cc1c2fce528bb3eca49ac9fcdb URL: https://github.com/llvm/llvm-project/commit/24aec16ddad465cc1c2fce528bb3eca49ac9fcdb DIFF: https://github.com/llvm/llvm-project/commit/24aec16ddad465cc1c2fce528bb3eca49ac9fcdb.diff LO

[clang] [Clang] [Sema] Handle placeholders in '.*' expressions (PR #83103)

2024-03-01 Thread Andrew Kaster via cfe-commits
ADKaster wrote: @AaronBallman @Sirraide would this patch be reasonable to backport to the 18.x release branch? It fixes a problem with our application on the FreeBSD-CURRENT branch. https://github.com/SerenityOS/serenity/issues/23365 https://github.com/llvm/llvm-project/pull/83103

[clang] [Clang][ARM][AArch64] Alway emit protection attributes for functions. (PR #82819)

2024-03-01 Thread via cfe-commits
https://github.com/DanielKristofKiss updated https://github.com/llvm/llvm-project/pull/82819 >From 9e844b9e61ad1c81983aafd7ac9b3fb9e1939787 Mon Sep 17 00:00:00 2001 From: Daniel Kiss Date: Mon, 22 Jan 2024 11:33:15 +0100 Subject: [PATCH] Emit attributes for functions always. Branch protection,

[clang] [InstallAPI] Collect frontend attributes & ObjCInterface decls (PR #83378)

2024-03-01 Thread Cyndy Ishida via cfe-commits
https://github.com/cyndyishida updated https://github.com/llvm/llvm-project/pull/83378 >From b3a2e850cbb7953902c6c64eb9c120422ec528bc Mon Sep 17 00:00:00 2001 From: Cyndy Ishida Date: Wed, 28 Feb 2024 14:15:48 -0800 Subject: [PATCH] [InstallAPI] Collect frontend attributes during & ObjCInterfa

[clang] [InstallAPI] Collect frontend attributes & ObjCInterface decls (PR #83378)

2024-03-01 Thread Juergen Ributzka via cfe-commits
https://github.com/ributzka approved this pull request. https://github.com/llvm/llvm-project/pull/83378 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][ARM][AArch64] Add branch protection attributes to the defaults. (PR #83277)

2024-03-01 Thread via cfe-commits
@@ -2022,6 +2022,19 @@ static void getTrivialDefaultFunctionAttributes( std::tie(Var, Value) = Attr.split('='); FuncAttrs.addAttribute(Var, Value); } + + TargetInfo::BranchProtectionInfo BPI(LangOpts); + DanielKristofKiss wrote: after #82819 lands,

[clang] 17ede03 - [InstallAPI] Collect frontend attributes & ObjCInterface decls (#83378)

2024-03-01 Thread via cfe-commits
Author: Cyndy Ishida Date: 2024-03-01T14:56:20-08:00 New Revision: 17ede03a926a8d8d35d887f1fe805b35e2078d5a URL: https://github.com/llvm/llvm-project/commit/17ede03a926a8d8d35d887f1fe805b35e2078d5a DIFF: https://github.com/llvm/llvm-project/commit/17ede03a926a8d8d35d887f1fe805b35e2078d5a.diff

<    1   2   3   4   >