[clang] [flang] [flang] Enable polymorphic lowering by default (PR #83285)

2024-02-28 Thread Tarun Prabhu via cfe-commits
tarunprabhu wrote: > A few of the tests in the gfortran-testsuite using polymorphism fail at > runtime. I'm happy for this PR to be merged as it is and these bugs to be > fixed later. Once this is merged in, the polymorphism tests can be enabled together with the larger group of tests that I

[clang] [llvm] [HLSL] Implementation of the frac intrinsic (PR #83315)

2024-02-28 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl created https://github.com/llvm/llvm-project/pull/83315 This change implements the frontend for #70099 Builtins.td - add the frac builtin CGBuiltin.cpp - add the builtin to DirectX intrinsic mapping hlsl_intrinsics.h - add the frac api SemaChecki

[clang] [clang] Fix __builtin_popcountg not matching GCC (PR #83313)

2024-02-28 Thread via cfe-commits
https://github.com/overmighty updated https://github.com/llvm/llvm-project/pull/83313 >From 6c224c82ec928f6c705af4a6bd0bacc573782bf0 Mon Sep 17 00:00:00 2001 From: OverMighty Date: Wed, 28 Feb 2024 18:10:29 + Subject: [PATCH 1/2] [clang] Fix __builtin_popcountg not matching GCC Our impleme

[clang] [llvm] [HLSL] Implementation of the frac intrinsic (PR #83315)

2024-02-28 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl ready_for_review https://github.com/llvm/llvm-project/pull/83315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implementation of the frac intrinsic (PR #83315)

2024-02-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 @llvm/pr-subscribers-clang Author: Farzon Lotfi (farzonl) Changes This change implements the frontend for #70099 Builtins.td - add the frac builtin CGBuiltin.cpp - add the builtin to DirectX intrinsic mapping hlsl_intrinsic

[clang] [Clang][ARM][AArch64] Add branch protection attributes to the defaults. (PR #83277)

2024-02-28 Thread via cfe-commits
DanielKristofKiss wrote: Thanks. I'm planning to land once all related patches are ready to land and in this order: #82819 #83277 #83153 #83154 https://github.com/llvm/llvm-project/pull/83277 ___ cfe-commits mailing list cfe-commits@lists.llvm.org

[clang] [llvm] [HLSL] implementation of lerp intrinsic (PR #83077)

2024-02-28 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl ready_for_review https://github.com/llvm/llvm-project/pull/83077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] implementation of lerp intrinsic (PR #83077)

2024-02-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl Author: Farzon Lotfi (farzonl) Changes This is the start of implementing the lerp intrinsic https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-lerp Builtins.td - defines the builtin hlsl_intrinsics.h - defines the lerp a

[clang] [llvm] [HLSL] implementation of lerp intrinsic (PR #83077)

2024-02-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-backend-x86 Author: Farzon Lotfi (farzonl) Changes This is the start of implementing the lerp intrinsic https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/dx-graphics-hlsl-lerp Builtins.td - defines the builtin hlsl_intrinsics.h - defines the

[clang] [llvm] [HLSL] Implementation of the frac intrinsic (PR #83315)

2024-02-28 Thread Xiang Li via cfe-commits
@@ -0,0 +1,27 @@ + +// RUN: %clang_cc1 -finclude-default-header -triple dxil-pc-shadermodel6.6-library %s -fnative-half-type -emit-llvm -disable-llvm-passes -verify -verify-ignore-unexpected + python3kgae wrote: What will happen for ``` struct A { float a; };

[clang] [Headers][X86] Add specific results to comparisons (PR #83316)

2024-02-28 Thread Paul T Robinson via cfe-commits
https://github.com/pogo59 created https://github.com/llvm/llvm-project/pull/83316 Comparison intrinsics were described as returning the "result" without specifying how. The "cmp" intrinsics return zero or all 1's in the corresponding elements of a returned vector; the "com" intrinsics return a

[clang] [llvm] [HLSL] implementation of lerp intrinsic (PR #83077)

2024-02-28 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/83077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Headers][X86] Add specific results to comparisons (PR #83316)

2024-02-28 Thread Paul T Robinson via cfe-commits
pogo59 wrote: Also tag @cflores for your review. https://github.com/llvm/llvm-project/pull/83316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Headers][X86] Add specific results to comparisons (PR #83316)

2024-02-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang @llvm/pr-subscribers-backend-x86 Author: Paul T Robinson (pogo59) Changes Comparison intrinsics were described as returning the "result" without specifying how. The "cmp" intrinsics return zero or all 1's in the corresponding elements of a return

[clang] [llvm] [HLSL] Implementation of the frac intrinsic (PR #83315)

2024-02-28 Thread Farzon Lotfi via cfe-commits
@@ -0,0 +1,27 @@ + +// RUN: %clang_cc1 -finclude-default-header -triple dxil-pc-shadermodel6.6-library %s -fnative-half-type -emit-llvm -disable-llvm-passes -verify -verify-ignore-unexpected + farzonl wrote: error: 1st argument must be a vector, integer or floa

[clang] [llvm] [HLSL] Implementation of the frac intrinsic (PR #83315)

2024-02-28 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/83315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema]: Diagnose lambda to bool implicit casts (PR #83152)

2024-02-28 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll edited https://github.com/llvm/llvm-project/pull/83152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Clang][Sema]: Diagnose lambda to bool implicit casts (PR #83152)

2024-02-28 Thread Vlad Serebrennikov via cfe-commits
@@ -281,7 +281,7 @@ namespace dr1837 { // dr1837: 3.3 struct A { int f(); -bool b = [] { +bool b = [] { // since-cxx11-warning{{address of lambda function pointer conversion operator will always evaluate to 'true'}} Endilll wrote: Convert this

[clang] [Clang][Sema]: Diagnose lambda to bool implicit casts (PR #83152)

2024-02-28 Thread Vlad Serebrennikov via cfe-commits
https://github.com/Endilll approved this pull request. DR test changes look good, save for a nit. https://github.com/llvm/llvm-project/pull/83152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cf

[clang] [HIP] fix host min/max in header (PR #82956)

2024-02-28 Thread Artem Belevich via cfe-commits
Artem-B wrote: > Probably I need to define those functions with mixed args by default to avoid > regressions. Are there any other regressions? Can hupCUB be fixed intsead? While their use case is probably benign, I'd rather fix the user code, than propagate CUDA bugs into HIP. https://github

[clang] [OpenMP] Clang Codegen Interop : Accept multiple init (PR #82604)

2024-02-28 Thread via cfe-commits
https://github.com/SunilKuravinakop updated https://github.com/llvm/llvm-project/pull/82604 >From 6444ef3f60a9f8ed8b3f413997259fe5006396b7 Mon Sep 17 00:00:00 2001 From: Sunil Kuravinakop Date: Tue, 20 Feb 2024 11:29:49 -0600 Subject: [PATCH 1/7] Accept multiple init clauses in interop directiv

[clang] [llvm] [HLSL] Implementation of the frac intrinsic (PR #83315)

2024-02-28 Thread Xiang Li via cfe-commits
@@ -0,0 +1,27 @@ + +// RUN: %clang_cc1 -finclude-default-header -triple dxil-pc-shadermodel6.6-library %s -fnative-half-type -emit-llvm -disable-llvm-passes -verify -verify-ignore-unexpected + python3kgae wrote: Just curious. Don't need a test case I think. ht

[clang] [llvm] [HLSL] Implementation of the frac intrinsic (PR #83315)

2024-02-28 Thread Xiang Li via cfe-commits
https://github.com/python3kgae approved this pull request. https://github.com/llvm/llvm-project/pull/83315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [OpenMP] Clang Codegen Interop : Accept multiple init (PR #82604)

2024-02-28 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/82604 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [compiler-rt] [AArch64] Implement __builtin_cpu_supports, compiler-rt tests. (PR #82378)

2024-02-28 Thread Pavel Iliin via cfe-commits
ilinpv wrote: @alexfh thanks for example, clang doesn't compile that on x86 before patch as well. It looks like a bug in GCC that it happily compiles the builtin above on x86. https://github.com/llvm/llvm-project/pull/82378 ___ cfe-commits mailing li

[clang] [llvm] [HLSL] Implementation of the frac intrinsic (PR #83315)

2024-02-28 Thread Justin Bogner via cfe-commits
https://github.com/bogner edited https://github.com/llvm/llvm-project/pull/83315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implementation of the frac intrinsic (PR #83315)

2024-02-28 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. LGTM other than the formatting in the test cases https://github.com/llvm/llvm-project/pull/83315 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[clang] [llvm] [HLSL] Implementation of the frac intrinsic (PR #83315)

2024-02-28 Thread Justin Bogner via cfe-commits
@@ -0,0 +1,69 @@ +// RUN: %clang_cc1 -finclude-default-header -x hlsl -triple \ +// RUN: dxil-pc-shadermodel6.3-library %s -fnative-half-type \ +// RUN: -emit-llvm -disable-llvm-passes -o - | FileCheck %s \ +// RUN: --check-prefixes=CHECK,NATIVE_HALF +// RUN: %clang_cc1 -fi

[clang] [llvm] [HLSL] implementation of lerp intrinsic (PR #83077)

2024-02-28 Thread Justin Bogner via cfe-commits
https://github.com/bogner edited https://github.com/llvm/llvm-project/pull/83077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] implementation of lerp intrinsic (PR #83077)

2024-02-28 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. LGTM, but see my comments in #83315 about test case formatting. https://github.com/llvm/llvm-project/pull/83077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[clang] [llvm] [HLSL] implementation of lerp intrinsic (PR #83077)

2024-02-28 Thread Justin Bogner via cfe-commits
@@ -5169,49 +5169,63 @@ bool Sema::CheckPPCMMAType(QualType Type, SourceLocation TypeLoc) { bool CheckVectorElementCallArgs(Sema *S, CallExpr *TheCall) { assert(TheCall->getNumArgs() > 1); ExprResult A = TheCall->getArg(0); - ExprResult B = TheCall->getArg(1); + QualTy

[clang] [llvm] [HLSL] implementation of lerp intrinsic (PR #83077)

2024-02-28 Thread Justin Bogner via cfe-commits
@@ -10266,6 +10266,11 @@ def err_block_on_vm : Error< def err_sizeless_nonlocal : Error< "non-local variable with sizeless type %0">; +def err_vec_builtin_non_vector_all : Error< + "all arguments to %0 must be vectors">; +def err_vec_builtin_incompatible_vector_all : Error<

[clang] [llvm] Implement a subset of builtin_cpu_supports() features (PR #82809)

2024-02-28 Thread Amy Kwan via cfe-commits
https://github.com/amy-kwan edited https://github.com/llvm/llvm-project/pull/82809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Implement a subset of builtin_cpu_supports() features (PR #82809)

2024-02-28 Thread Amy Kwan via cfe-commits
@@ -132,6 +132,14 @@ PPC_LNX_CPU("power10",47) #ifndef AIX_POWERPC_USE_SYS_CONF #define AIX_POWERPC_USE_SYS_CONF #define AIX_SYSCON_IMPL_IDX 1 + #define AIX_SYSCON_CACHE_IDX 5 + #define AIX_SYSCON_SMT_IDX 44 + #define AIX_SYSCON_VMX_IDX 46 + #define AIX_SYSCON_DFP_IDX

[clang] [llvm] Implement a subset of builtin_cpu_supports() features (PR #82809)

2024-02-28 Thread Amy Kwan via cfe-commits
https://github.com/amy-kwan commented: Group review comments. https://github.com/llvm/llvm-project/pull/82809 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] Implement a subset of builtin_cpu_supports() features (PR #82809)

2024-02-28 Thread Amy Kwan via cfe-commits
@@ -364,7 +364,14 @@ class LLVM_LIBRARY_VISIBILITY PPCTargetInfo : public TargetInfo { // have Glibc since it is Glibc that provides the HWCAP[2] in the auxv. static constexpr int MINIMUM_AIX_OS_MAJOR = 7; static constexpr int MINIMUM_AIX_OS_MINOR = 2; - bool supportsCp

[clang] [llvm] Implement a subset of builtin_cpu_supports() features (PR #82809)

2024-02-28 Thread Amy Kwan via cfe-commits
@@ -16560,32 +16560,72 @@ Value *CodeGenFunction::EmitPPCBuiltinExpr(unsigned BuiltinID, #include "llvm/TargetParser/PPCTargetParser.def" auto GenAIXPPCBuiltinCpuExpr = [&](unsigned SupportMethod, unsigned FieldIdx, - unsigned CompOp, +

[clang] [OpenACC] Implement Compute Construct 'goto' in/out logic (PR #83326)

2024-02-28 Thread Erich Keane via cfe-commits
https://github.com/erichkeane created https://github.com/llvm/llvm-project/pull/83326 Compute Constructs do not permit jumping in/out of them, so this patch implements this for 'goto' as a followup to the other patches that have done the same thing. It does this by modifying the JumpDiagnosti

[clang] [OpenACC] Implement Compute Construct 'goto' in/out logic (PR #83326)

2024-02-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang Author: Erich Keane (erichkeane) Changes Compute Constructs do not permit jumping in/out of them, so this patch implements this for 'goto' as a followup to the other patches that have done the same thing. It does this by modifying the JumpDiagno

[clang] [OpenACC] Implement Compute Construct 'goto' in/out logic (PR #83326)

2024-02-28 Thread Alexey Bataev via cfe-commits
https://github.com/alexey-bataev approved this pull request. LG https://github.com/llvm/llvm-project/pull/83326 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [InstallAPI] Hookup Input files & basic ASTVisitor (PR #82552)

2024-02-28 Thread Fangrui Song via cfe-commits
MaskRay wrote: Hi, I believe this patch introduced a library layering issue. https://llvm.org/docs/CodingStandards.html#library-layering Since clangFrontend depends on clangInstallAPI, clangInstallAPI cannot include include/clang/Frontend header files. CMake doesn't have good support for detect

[clang] [Clang][C++23] Core language changes from P1467R9 extended floating-point types and standard names. (PR #78503)

2024-02-28 Thread Nick Desaulniers via cfe-commits
nickdesaulniers wrote: What's the status of this PR? Seems like it would be helpful for some of the C23 additions (`_Float128` being of most interest to me) https://github.com/llvm/llvm-project/pull/78503 ___ cfe-commits mailing list cfe-commits@list

[clang] [InstallAPI] Hookup Input files & basic ASTVisitor (PR #82552)

2024-02-28 Thread Cyndy Ishida via cfe-commits
cyndyishida wrote: > Since clangFrontend depends on clangInstallAPI, Thanks for reporting this issue. Is it possible the issue is from a stale build? `clangFrontend` should no longer depend on `clangInstallAPI`. That dependency was removed in https://github.com/llvm/llvm-project/commit/0a518

[clang] [InstallAPI] Hookup Input files & basic ASTVisitor (PR #82552)

2024-02-28 Thread Fangrui Song via cfe-commits
MaskRay wrote: > > Since clangFrontend depends on clangInstallAPI, > > @MaskRay Thanks for reporting this issue. Is it possible the issue is from a > stale build? `clangFrontend` should no longer depend on `clangInstallAPI`. > That dependency was removed in > [0a518db#diff-9606e9f9f8eb1bb317d

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5 (PR #83331)

2024-02-28 Thread Alexander Yermolovich via cfe-commits
https://github.com/ayermolo created https://github.com/llvm/llvm-project/pull/83331 When -gsplit-dwarf is passed in clang emmmits -ggnu-pubnames which results in .debug_gnu_pubnames/..debug_gnu_pubtypes being generated. This is used by GDB, but not by LLDB. Changed so that these sections are not

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5 (PR #83331)

2024-02-28 Thread Alexander Yermolovich via cfe-commits
https://github.com/ayermolo edited https://github.com/llvm/llvm-project/pull/83331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5 (PR #83331)

2024-02-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-clang-driver Author: Alexander Yermolovich (ayermolo) Changes When -gsplit-dwarf is passed in clang emmmits -ggnu-pubnames which results in .debug_gnu_pubnames/..debug_gnu_pubtypes being generated. This is used by GDB, but not by LLDB. Changed so that th

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5 (PR #83331)

2024-02-28 Thread Alexander Yermolovich via cfe-commits
ayermolo wrote: Another attempt. Had to return original https://github.com/llvm/llvm-project/pull/82840 because it was breaking a test on mac. https://github.com/llvm/llvm-project/pull/83331 ___ cfe-commits mailing list cfe-commits@lists.llvm.org htt

[clang] [llvm] [HLSL] implementation of lerp intrinsic (PR #83077)

2024-02-28 Thread Farzon Lotfi via cfe-commits
@@ -10266,6 +10266,11 @@ def err_block_on_vm : Error< def err_sizeless_nonlocal : Error< "non-local variable with sizeless type %0">; +def err_vec_builtin_non_vector_all : Error< + "all arguments to %0 must be vectors">; +def err_vec_builtin_incompatible_vector_all : Error<

[clang] [llvm] [HLSL] implementation of lerp intrinsic (PR #83077)

2024-02-28 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl edited https://github.com/llvm/llvm-project/pull/83077 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5 (PR #83331)

2024-02-28 Thread Alexander Yermolovich via cfe-commits
https://github.com/ayermolo updated https://github.com/llvm/llvm-project/pull/83331 >From 668819ef921ecb4d0ef704c2269ea07acd1b5334 Mon Sep 17 00:00:00 2001 From: Alexander Yermolovich Date: Fri, 23 Feb 2024 14:52:04 -0800 Subject: [PATCH] [CLANG][DWARF] Do not emit -ggnu-pubnames for split dwar

[clang] [CLANG][DWARF] Do not emit -ggnu-pubnames for split dwarf version 5 (PR #83331)

2024-02-28 Thread Alexander Yermolovich via cfe-commits
https://github.com/ayermolo updated https://github.com/llvm/llvm-project/pull/83331 >From 7d58760a887fc935e2af670f8aa721cdd5946391 Mon Sep 17 00:00:00 2001 From: Alexander Yermolovich Date: Fri, 23 Feb 2024 14:52:04 -0800 Subject: [PATCH] [CLANG][DWARF] Do not emit -ggnu-pubnames for split dwar

[clang] [HLSL] standardize builtin unit tests (PR #83340)

2024-02-28 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl created https://github.com/llvm/llvm-project/pull/83340 This PR brings best practices mentioned to me on other prs and adds them to the existing builtin tests. Note to reviewers: I put this up in two commits because the clang-format changes is making it hard to tell

[clang] [HLSL] standardize builtin unit tests (PR #83340)

2024-02-28 Thread via cfe-commits
llvmbot wrote: @llvm/pr-subscribers-hlsl @llvm/pr-subscribers-clang Author: Farzon Lotfi (farzonl) Changes This PR brings best practices mentioned to me on other prs and adds them to the existing builtin tests. Note to reviewers: I put this up in two commits because the clang-format cha

[clang] [llvm] [clang][ScanDeps] Allow PCHs to have different VFS overlays (PR #82294)

2024-02-28 Thread Michael Spencer via cfe-commits
@@ -175,8 +192,19 @@ static void sanitizeDiagOpts(DiagnosticOptions &DiagOpts) { DiagOpts.ShowCarets = false; // Don't write out diagnostic file. DiagOpts.DiagnosticSerializationFile.clear(); - // Don't emit warnings as errors (and all other warnings too). - DiagOpts.Ig

[clang] [HLSL] standardize builtin unit tests (PR #83340)

2024-02-28 Thread Greg Roth via cfe-commits
pow2clk wrote: Do we have the suggestions that this is responding to written down somewhere? I think it would be useful to have those guidelines for anyone who might want to contribute HLSL tests. At any rate, I'd like to know the ones that this is in response to. https://github.com/llvm/llv

[clang] [flang] [llvm] [InstCombine] Canonicalize constant GEPs to i8 source element type (PR #68882)

2024-02-28 Thread via cfe-commits
Prabhuk wrote: I am debugging an assertion failure regression in one of our projects that uses the FlatMap data structure implemented here: https://pigweed.googlesource.com/pigweed/pigweed/+/refs/heads/main/pw_containers/public/pw_containers/flat_map.h#180 The regression was that the `find` f

[clang] [HLSL] standardize builtin unit tests (PR #83340)

2024-02-28 Thread Damyan Pepper via cfe-commits
damyanp wrote: > Do we have the suggestions that this is responding to written down somewhere? > I think it would be useful to have those guidelines for anyone who might want > to contribute HLSL tests. At any rate, I'd like to know the ones that this is > in response to. Following on from th

[clang] [HLSL] standardize builtin unit tests (PR #83340)

2024-02-28 Thread Farzon Lotfi via cfe-commits
farzonl wrote: > Do we have the suggestions that this is responding to written down somewhere? > I think it would be useful to have those guidelines for anyone who might want > to contribute HLSL tests. At any rate, I'd like to know the ones that this is > in response to. @pow2clk below are t

[clang] [HLSL] standardize builtin unit tests (PR #83340)

2024-02-28 Thread Farzon Lotfi via cfe-commits
farzonl wrote: > > Do we have the suggestions that this is responding to written down > > somewhere? I think it would be useful to have those guidelines for anyone > > who might want to contribute HLSL tests. At any rate, I'd like to know the > > ones that this is in response to. > > Followin

[clang] 1977404 - [OpenMP] Respect LLVM per-target install directories (#83282)

2024-02-28 Thread via cfe-commits
Author: Joseph Huber Date: 2024-02-28T15:39:27-06:00 New Revision: 1977404d20ab29ff78a58d8c0f1f4c5e7aef6b16 URL: https://github.com/llvm/llvm-project/commit/1977404d20ab29ff78a58d8c0f1f4c5e7aef6b16 DIFF: https://github.com/llvm/llvm-project/commit/1977404d20ab29ff78a58d8c0f1f4c5e7aef6b16.diff

[clang] [openmp] [OpenMP] Respect LLVM per-target install directories (PR #83282)

2024-02-28 Thread Joseph Huber via cfe-commits
https://github.com/jhuber6 closed https://github.com/llvm/llvm-project/pull/83282 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL] Implementation of the frac intrinsic (PR #83315)

2024-02-28 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/83315 >From cd8a27e4571b8e791ce5ccaaf51dd570ee8bc6d3 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Wed, 28 Feb 2024 13:20:01 -0500 Subject: [PATCH 1/2] [HLSL] Implementation of the frac intrinsic This change imple

[clang] [llvm] Implement a subset of builtin_cpu_supports() features (PR #82809)

2024-02-28 Thread zhijian lin via cfe-commits
https://github.com/diggerlin updated https://github.com/llvm/llvm-project/pull/82809 >From cef79b36bcb3f4b7452d01aafdf111ff0e50605d Mon Sep 17 00:00:00 2001 From: zhijian Date: Fri, 23 Feb 2024 13:23:18 -0500 Subject: [PATCH 1/7] Implement a subset of builtin_cpu_supports() features --- clang

[clang] [llvm] Implement a subset of builtin_cpu_supports() features (PR #82809)

2024-02-28 Thread zhijian lin via cfe-commits
@@ -364,7 +364,14 @@ class LLVM_LIBRARY_VISIBILITY PPCTargetInfo : public TargetInfo { // have Glibc since it is Glibc that provides the HWCAP[2] in the auxv. static constexpr int MINIMUM_AIX_OS_MAJOR = 7; static constexpr int MINIMUM_AIX_OS_MINOR = 2; - bool supportsCp

[clang] [HLSL] standardize builtin unit tests (PR #83340)

2024-02-28 Thread Farzon Lotfi via cfe-commits
farzonl wrote: > Do we have the suggestions that this is responding to written down somewhere? > I think it would be useful to have those guidelines for anyone who might want > to contribute HLSL tests. At any rate, I'd like to know the ones that this is > in response to. After consulting wit

[clang] Disable FTZ/DAZ when compiling shared libraries by default. (PR #80475)

2024-02-28 Thread Joshua Cranmer via cfe-commits
jcranmer-intel wrote: > It matters more for AMDGPU, where we need to care because some instructions > just don't respect denormals. We legalize some operations differently > depending on the mode But the shared library stuff isn't an issue for AMDGPU, right? https://github.com/llvm/llvm-proje

[clang] [llvm] [TargetParser][AArch64] Add alias for FEAT_RDM. (PR #80540)

2024-02-28 Thread Alexandros Lamprineas via cfe-commits
https://github.com/labrinea updated https://github.com/llvm/llvm-project/pull/80540 >From fb56f1c31f7f6fb847b95e0ffe97a39ac76759a9 Mon Sep 17 00:00:00 2001 From: Alexandros Lamprineas Date: Tue, 30 Jan 2024 11:17:55 + Subject: [PATCH] [TargetParser][AArch64] Add alias for FEAT_RDM. This pa

[clang] [llvm] [HLSL] implementation of lerp intrinsic (PR #83077)

2024-02-28 Thread Farzon Lotfi via cfe-commits
https://github.com/farzonl updated https://github.com/llvm/llvm-project/pull/83077 >From 56240f07c39deb4c48bf7370dc72b3c67299eee1 Mon Sep 17 00:00:00 2001 From: Farzon Lotfi Date: Sun, 25 Feb 2024 20:08:09 -0500 Subject: [PATCH] start of lerp intrinsic --- clang/include/clang/Basic/Builtins.t

[clang] [HLSL] standardize builtin unit tests (PR #83340)

2024-02-28 Thread Justin Bogner via cfe-commits
bogner wrote: If we want to talk about guidelines for clang-formatting tests in general we should probably bring it up with the wider LLVM community on discourse. The de facto standard today is that tests should be well formatted like anything else unless there's a good reason not to, but this

[clang] [clang] Fix __builtin_popcountg not matching GCC (PR #83313)

2024-02-28 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic approved this pull request. LGTM https://github.com/llvm/llvm-project/pull/83313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [HLSL] standardize builtin unit tests (PR #83340)

2024-02-28 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. https://github.com/llvm/llvm-project/pull/83340 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [TargetParser][AArch64] Add alias for FEAT_RDM. (PR #80540)

2024-02-28 Thread Martin Storsjö via cfe-commits
mstorsjo wrote: FYI, see 4b8d9abca7d0280878fb12de331e688ee85d7cd8 for another existing case where we already support both `rdm` and `rdma`. But I don't think that case can share any of the aliasing logic from here. https://github.com/llvm/llvm-project/pull/80540 ___

[clang] [llvm] [clang][ScanDeps] Allow PCHs to have different VFS overlays (PR #82294)

2024-02-28 Thread Ben Langmuir via cfe-commits
@@ -175,8 +192,19 @@ static void sanitizeDiagOpts(DiagnosticOptions &DiagOpts) { DiagOpts.ShowCarets = false; // Don't write out diagnostic file. DiagOpts.DiagnosticSerializationFile.clear(); - // Don't emit warnings as errors (and all other warnings too). - DiagOpts.Ig

[clang] 14faf0d - [TextAPI][InstallAPI] Fix documentation typos, NFC

2024-02-28 Thread Cyndy Ishida via cfe-commits
Author: Cyndy Ishida Date: 2024-02-28T14:24:42-08:00 New Revision: 14faf0d4aa841aafd0d1982391114bc35fda7e59 URL: https://github.com/llvm/llvm-project/commit/14faf0d4aa841aafd0d1982391114bc35fda7e59 DIFF: https://github.com/llvm/llvm-project/commit/14faf0d4aa841aafd0d1982391114bc35fda7e59.diff

[clang] [clang][fat-lto-objects] Make module flags match non-FatLTO pipelines (PR #83159)

2024-02-28 Thread Paul Kirth via cfe-commits
https://github.com/ilovepi updated https://github.com/llvm/llvm-project/pull/83159 >From 0a37b8e52fe5e17fff3f6e88bf25f1969bbe8bb4 Mon Sep 17 00:00:00 2001 From: Paul Kirth Date: Tue, 27 Feb 2024 17:43:58 + Subject: [PATCH 1/3] =?UTF-8?q?[=F0=9D=98=80=F0=9D=97=BD=F0=9D=97=BF]=20in?= =?UTF-8

[clang] fc8d481 - [clang] Fix __builtin_popcountg not matching GCC (#83313)

2024-02-28 Thread via cfe-commits
Author: OverMighty Date: 2024-02-28T14:46:06-08:00 New Revision: fc8d48106387b8b79531902788ef93571f924da7 URL: https://github.com/llvm/llvm-project/commit/fc8d48106387b8b79531902788ef93571f924da7 DIFF: https://github.com/llvm/llvm-project/commit/fc8d48106387b8b79531902788ef93571f924da7.diff LO

[clang] [clang] Fix __builtin_popcountg not matching GCC (PR #83313)

2024-02-28 Thread Eli Friedman via cfe-commits
https://github.com/efriedma-quic closed https://github.com/llvm/llvm-project/pull/83313 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [openmp] [OpenMP] Introduce support for OMPX extensions and taskgraph frontend (PR #66919)

2024-02-28 Thread Jose Manuel Monsalve Diaz via cfe-commits
josemonsalve2 wrote: Hi Mike, Thanks for the suggestion. Chenle or Adrian divided this PR into multiple ones. They may be able to provide info on it. That was last year. I went on paternity leave and lost track of the progress on these PRs. I have yet to find the time to pick up on this work.

[clang] [llvm] [RISCV] Remove experimental from Zacas. (PR #83195)

2024-02-28 Thread Craig Topper via cfe-commits
https://github.com/topperc updated https://github.com/llvm/llvm-project/pull/83195 >From 8ed68475b43008d9c7baff7f275026cc7ada5993 Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Tue, 27 Feb 2024 14:01:52 -0800 Subject: [PATCH 1/2] [RISCV] Remove experimental from Zacas. Document that we don'

[clang] [llvm] [RISCV] Remove experimental from Zacas. (PR #83195)

2024-02-28 Thread Craig Topper via cfe-commits
https://github.com/topperc updated https://github.com/llvm/llvm-project/pull/83195 >From 8ed68475b43008d9c7baff7f275026cc7ada5993 Mon Sep 17 00:00:00 2001 From: Craig Topper Date: Tue, 27 Feb 2024 14:01:52 -0800 Subject: [PATCH 1/3] [RISCV] Remove experimental from Zacas. Document that we don'

[clang] ff07c9b - [Driver] Unify InstalledDir and Dir (#80527)

2024-02-28 Thread via cfe-commits
Author: Fangrui Song Date: 2024-02-28T15:12:31-08:00 New Revision: ff07c9b701dc6372f82d989d01768051e848b30d URL: https://github.com/llvm/llvm-project/commit/ff07c9b701dc6372f82d989d01768051e848b30d DIFF: https://github.com/llvm/llvm-project/commit/ff07c9b701dc6372f82d989d01768051e848b30d.diff

[clang] [Driver] Unify InstalledDir and Dir (PR #80527)

2024-02-28 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay closed https://github.com/llvm/llvm-project/pull/80527 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] 0f76d9f - clang-installapi: remove setInstalledDir

2024-02-28 Thread Fangrui Song via cfe-commits
Author: Fangrui Song Date: 2024-02-28T15:17:31-08:00 New Revision: 0f76d9fb5fbfea92da7647af70d78165c71c0700 URL: https://github.com/llvm/llvm-project/commit/0f76d9fb5fbfea92da7647af70d78165c71c0700 DIFF: https://github.com/llvm/llvm-project/commit/0f76d9fb5fbfea92da7647af70d78165c71c0700.diff

[clang] [llvm] [HLSL][SPIR-V] Add SV_DispatchThreadID semantic support (PR #82536)

2024-02-28 Thread Justin Bogner via cfe-commits
https://github.com/bogner approved this pull request. LGTM. I don't like how we're choosing an intrinsic but changing that can come in as a follow up if you like. https://github.com/llvm/llvm-project/pull/82536 ___ cfe-commits mailing list cfe-commits

[clang] [llvm] [HLSL][SPIR-V] Add SV_DispatchThreadID semantic support (PR #82536)

2024-02-28 Thread Justin Bogner via cfe-commits
https://github.com/bogner edited https://github.com/llvm/llvm-project/pull/82536 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [HLSL][SPIR-V] Add SV_DispatchThreadID semantic support (PR #82536)

2024-02-28 Thread Justin Bogner via cfe-commits
@@ -342,8 +343,19 @@ llvm::Value *CGHLSLRuntime::emitInputSemantic(IRBuilder<> &B, return B.CreateCall(FunctionCallee(DxGroupIndex)); } if (D.hasAttr()) { -llvm::Function *DxThreadID = CGM.getIntrinsic(Intrinsic::dx_thread_id); -return buildVectorInput(B, DxThr

[clang-tools-extra] [llvm] Add bazel support for clangd as a library. (PR #81556)

2024-02-28 Thread via cfe-commits
josh11b wrote: Ping! https://github.com/llvm/llvm-project/pull/81556 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [llvm] [RISCV] Remove experimental from Zacas. (PR #83195)

2024-02-28 Thread Fangrui Song via cfe-commits
@@ -103,6 +103,7 @@ Changes to the RISC-V Backend * Codegen support was added for the Zimop (May-Be-Operations) extension. * The experimental Ssnpm, Smnpm, Smmpm, Sspm, and Supm 0.8.1 Pointer Masking extensions are supported. * The experimental Ssqosid extension is supported.

[clang] [llvm] [RISCV] Remove experimental from Zacas. (PR #83195)

2024-02-28 Thread Fangrui Song via cfe-commits
https://github.com/MaskRay approved this pull request. https://github.com/llvm/llvm-project/pull/83195 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang] [Headers][X86] Add specific results to comparisons (PR #83316)

2024-02-28 Thread Phoebe Wang via cfe-commits
https://github.com/phoebewang approved this pull request. LGTM. https://github.com/llvm/llvm-project/pull/83316 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clang-tidy] Unsafe CRTP check (PR #82403)

2024-02-28 Thread via cfe-commits
isuckatcs wrote: I ran the checker on LLVM, Clang and Clang-Tidy (`run-clang-tidy.py` in my build directory). There are a total of 33 warnings by the checker, which can be found below. I omitted the use site, where the template parameter says `Derived`, because I think that makes it obvious th

[clang-tools-extra] [clangd] Add container field to remote index Refs grpc method (PR #71605)

2024-02-28 Thread via cfe-commits
https://github.com/tdupes updated https://github.com/llvm/llvm-project/pull/71605 >From 4282c39fd0b40c26c68f57257c150b984264f50b Mon Sep 17 00:00:00 2001 From: dup Date: Fri, 3 Nov 2023 09:03:24 -0700 Subject: [PATCH] Add container field to remote index Refs grpc method --- clang-tools-extra/

[clang] [Clang][Sema]: Diagnose lambda to bool implicit casts (PR #83152)

2024-02-28 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik commented: Thank you for this fix. I am happy the changes were not too different from my suggestion. Sometimes problems end up being more difficult then they seem initially. https://github.com/llvm/llvm-project/pull/83152 __

[clang] [Clang][Sema]: Diagnose lambda to bool implicit casts (PR #83152)

2024-02-28 Thread Shafik Yaghmour via cfe-commits
@@ -16538,6 +16538,17 @@ void Sema::DiagnoseAlwaysNonNullPointer(Expr *E, } } + // Complain if we are converting a lambda expression to a boolean value + if (const auto *MCallExpr = dyn_cast(E)) { +if (const auto *MRecordDecl = MCallExpr->getRecordDecl(); +

[clang] [Clang][Sema]: Diagnose lambda to bool implicit casts (PR #83152)

2024-02-28 Thread Shafik Yaghmour via cfe-commits
@@ -16538,6 +16538,17 @@ void Sema::DiagnoseAlwaysNonNullPointer(Expr *E, } } + // Complain if we are converting a lambda expression to a boolean value + if (const auto *MCallExpr = dyn_cast(E)) { +if (const auto *MRecordDecl = MCallExpr->getRecordDecl(); +

[clang] [Clang][Sema]: Diagnose lambda to bool implicit casts (PR #83152)

2024-02-28 Thread Shafik Yaghmour via cfe-commits
https://github.com/shafik edited https://github.com/llvm/llvm-project/pull/83152 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[clang-tools-extra] [clangd] Add container field to remote index Refs grpc method (PR #71605)

2024-02-28 Thread via cfe-commits
https://github.com/tdupes updated https://github.com/llvm/llvm-project/pull/71605 >From 4282c39fd0b40c26c68f57257c150b984264f50b Mon Sep 17 00:00:00 2001 From: dup Date: Fri, 3 Nov 2023 09:03:24 -0700 Subject: [PATCH 1/2] Add container field to remote index Refs grpc method --- clang-tools-ex

[clang-tools-extra] [clangd] Add container field to remote index Refs grpc method (PR #71605)

2024-02-28 Thread via cfe-commits
github-actions[bot] wrote: :warning: C/C++ code formatter, clang-format found issues in your code. :warning: You can test this locally with the following command: ``bash git-clang-format --diff 5784bf85bc5143266565586ece0113cd773a8616 81271a1a536ca950eba328e5e84571e20a37d46e --

[clang] [clang-tools-extra] [CLANGD] Do not crash on designator initialization of union (PR #83369)

2024-02-28 Thread via cfe-commits
https://github.com/alirezamoshtaghi created https://github.com/llvm/llvm-project/pull/83369 None >From 3d6afe011221ac239bb668b375ed3f6c356fc47d Mon Sep 17 00:00:00 2001 From: alirezamoshtaghi Date: Wed, 28 Feb 2024 13:55:11 -0800 Subject: [PATCH] [CLANGD] Do not crash on designator initializat

<    1   2   3   4   >